• E
    maint: avoid 'const fooPtr' in virnet files · 955af4d4
    Eric Blake 提交于
    'const fooPtr' is the same as 'foo * const' (the pointer won't
    change, but it's contents can).  But in general, if an interface
    is trying to be const-correct, it should be using 'const foo *'
    (the pointer is to data that can't be changed).
    
    Fix up remaining offenders in src/util.
    
    * src/util/virnetdev.h (virNetDevSetMAC)
    (virNetDevReplaceMacAddress, virNetDevValidateConfig)
    (virNetDevReplaceNetConfig): Use intended type.
    * src/util/virnetdevbandwidth.h (virNetDevBandwidthCopy)
    (virNetDevBandwidthPlug): Likewise.
    * src/util/virnetdevmacvlan.h (virNetDevMacVLanCreate)
    (virNetDevMacVLanCreateWithVPortProfile)
    (virNetDevMacVLanDeleteWithVPortProfile)
    (virNetDevMacVLanRestartWithVPortProfile)
    (virNetDevMacVLanVPortProfileRegisterCallback): Likewise.
    * src/util/virnetdevopenvswitch.h (virNetDevOpenvswitchAddPort):
    Likewise.
    * src/util/virnetdevtap.h (virNetDevTapCreateInBridgePort):
    Likewise.
    * src/util/virnetdevvlan.h (virNetDevVlanEqual)
    (virNetDevVlanCopy): Likewise.
    * src/util/virnetdevvportprofile.h
    (virNetDevVPortProfileAssociate)
    (virNetDevVPortProfileDisassociate): Likewise.
    * src/util/virnetlink.h (virNetlinkEventRemoveCallback)
    (virNetlinkEventAddClient, virNetlinkEventRemoveClient):
    Likewise.
    * src/util/virnetdev.c (virNetDevSetMAC)
    (virNetDevReplaceMacAddress, virNetDevValidateConfig)
    (virNetDevReplaceNetConfig): Fix fallout.
    * src/util/virnetdevbandwidth.c (virNetDevBandwidthCopy)
    (virNetDevBandwidthPlug): Likewise.
    * src/util/virnetdevmacvlan.c (virNetDevMacVLanCreate)
    (virNetDevMacVLanCreateWithVPortProfile)
    (virNetDevMacVLanDeleteWithVPortProfile)
    (virNetDevMacVLanRestartWithVPortProfile)
    (virNetDevMacVLanVPortProfileRegisterCallback): Likewise.
    * src/util/virnetdevopenvswitch.c (virNetDevOpenvswitchAddPort):
    Likewise.
    * src/util/virnetdevtap.c (virNetDevTapCreateInBridgePort):
    Likewise.
    * src/util/virnetdevvlan.c (virNetDevVlanEqual)
    (virNetDevVlanCopy): Likewise.
    * src/util/virnetdevvportprofile.c
    (virNetDevVPortProfileAssociate)
    (virNetDevVPortProfileDisassociate)
    (virNetDevVPortProfileOpSetLink, virNetDevVPortProfileOpCommon)
    (virNetDevVPortProfileOp8021Qbg, virNetDevVPortProfileOp8021Qbh):
    Likewise.
    * src/util/virnetlink.c (virNetlinkEventRemoveCallback)
    (virNetlinkEventAddClient, virNetlinkEventRemoveClient):
    Likewise.
    Signed-off-by: NEric Blake <eblake@redhat.com>
    955af4d4
virnetdev.h 5.7 KB