• E
    tests: Fix virsh-snapshot/checkpoint without readline-devel · 8bfb1371
    Eric Blake 提交于
    readline-devel is an optional build dependency; when it is not
    present, the output of 'virsh <<EOF ... EOF' is different in that the
    input provided by the user is not echoed, and prompts become
    interleaved on the same line as actual output, which in turn causes
    the sed doing prompt filtering to mess up:
    
    | ./virsh-snapshot
    | --- exp	2019-07-31 18:42:31.107399428 -0300
    | +++ out.cooked	2019-07-31 18:42:31.108399437 -0300
    | @@ -1,8 +1,3 @@
    | -
    | -
    | -Domain snapshot s3 created from 's3.xml'
    | -Domain snapshot s2 created from 's2.xml'
    | -Name:           s2
    |  Domain:         test
    |  Current:        yes
    |  State:          running
    
    Maybe we should fix virsh in interactive mode to echo regardless of
    whether readline-devel was used, but the quicker fix is to make the
    test use 'virsh "..."' rather than reading its input from stdin.
    Reported-by: NDaniel Henrique Barboza <danielhb413@gmail.com>
    Signed-off-by: NEric Blake <eblake@redhat.com>
    Tested-by: NDaniel Henrique Barboza <danielhb413@gmail.com>
    8bfb1371
virsh-snapshot 5.7 KB