• D
    Make security drivers responsible for checking dynamic vs static labelling · 81fbb4cb
    Daniel P. Berrange 提交于
    The QEMU driver is doing 90% of the calls to check for static vs
    dynamic labelling. Except it is forgetting todo so in many places,
    in particular hotplug is mistakenly assigning disk labels. Move
    all this logic into the security drivers themselves, so the HV
    drivers don't have to think about it.
    
    * src/security/security_driver.h: Add virDomainObjPtr parameter
      to virSecurityDomainRestoreHostdevLabel and to
      virSecurityDomainRestoreSavedStateLabel
    * src/security/security_selinux.c, src/security/security_apparmor.c:
      Add explicit checks for VIR_DOMAIN_SECLABEL_STATIC and skip all
      chcon() code in those cases
    * src/qemu/qemu_driver.c: Remove all checks for VIR_DOMAIN_SECLABEL_STATIC
      or VIR_DOMAIN_SECLABEL_DYNAMIC. Add missing checks for possibly NULL
      driver entry points.
    81fbb4cb
security_apparmor.c 17.3 KB