• E
    spec: require device-mapper-devel for storage-disk · 7cac3afa
    Eric Blake 提交于
    On Fedora 20, with the following in my ~/.rpmmacros:
    
    %_without_udev 1
    %_without_storage_mpath 1
    
    and with device-mapper-devel uninstalled, 'make rpm' fails with:
    
    checking for libdevmapper.h... no
    configure: error: You must install device-mapper-devel/libdevmapper >= 1.0.0 to compile libvirt
    error: Bad exit status from /var/tmp/rpm-tmp.Wo9pOG (%build)
    
    This is a rather late point to be issuing an error; better is
    to flag missing packages up front.  The fix is to match the logic
    in configure.ac on when devmapper is required (for both mpath and
    storage).  While at it, rbd storage is not dependent on mpath.
    With this patch applied, I now get:
    
    $ rpmbuild -ta libvirt-1.2.2.tar.gz
    error: Failed build dependencies:
           device-mapper-devel is needed by libvirt-1.2.2-1.fc20.x86_64
    
    until either installing the package or further modifying
    ~/.rpmmacros to add "%_without_storage_disk 1".
    
    * libvirt.spec.in (BuildRequires): Fix build when mpath is
    disabled.
    Signed-off-by: NEric Blake <eblake@redhat.com>
    7cac3afa
libvirt.spec.in 87.5 KB