• L
    interface: dump inactive xml when interface isn't active · 7284c499
    Laine Stump 提交于
    Other drivers in libvirt (e.g. network, qemu) will automatically
    return the "inactive" (persistent configuration) XML of an object when
    that object is inactive. The netcf backend of the interface driver
    would always try to return the live status XML of the interface, even
    when it was down. Although netcf does return valid XML in that case,
    for bond interfaces it is missing almost all of its content, including
    the <bond> subelement itself, leading to this error message from
    "virsh iface-dumpxml" of a bond interface that is inactive:
    
      error: XML error: bond interface misses the bond element
    
    (this is because libvirt's validation of the XML returned by netcf
    always requires a <bond> element be present).
    
    This patch modifies the interface driver netcf backend to check if the
    interface is inactive, and in that case always return the inactive XML
    (which will always have a <bond> element, thus eliminating the error
    message, as well as making operation more in line with other drivers.
    
    This fixes the following bug:
    
      https://bugzilla.redhat.com/show_bug.cgi?id=878394
    7284c499
interface_backend_netcf.c 35.5 KB