• M
    qemu: Reject updating unsupported disk information · 717c99f3
    Martin Kletzander 提交于
    If one calls update-device with information that is not updatable,
    libvirt reports success even though no data were updated.  The example
    used in the bug linked below uses updating device with <boot order='2'/>
    which, in my opinion, is a valid thing to request from user's
    perspective.  Mainly since we properly error out if user wants to update
    such data on a network device for example.
    
    And since there are many things that might happen (update-device on disk
    basically knows just how to change removable media), check for what's
    changing and moreover, since the function might be usable in other
    drivers (updating only disk path is a valid possibility) let's abstract
    it for any two disks.
    
    We can't possibly check for everything since for many fields our code
    does not properly differentiate between default and unspecified values.
    Even though this could be changed, I don't feel like it's worth the
    complexity so it's not the aim of this patch.
    
    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1007228
    717c99f3
libvirt_private.syms 54.9 KB