• E
    tests: silence qemuargv2xmltest noise · 9e3525df
    Eric Blake 提交于
    Before this patch, the testsuite was noisy:
    
    TEST: qemuargv2xmltest
          ........................................ 40
          ................20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument '-unknown', adding to the qemu namespace
    20:41:28.046: warning : qemuParseCommandLine:6565 : unknown QEMU argument 'parameter', adding to the qemu namespace
    .                        57  OK
    PASS: qemuargv2xmltest
    
    It's not a real failure (which is why the test was completing
    successfully), so much as an intentional warning to the user that use
    of the qemu namespace has the potential for undefined effects that
    leaked through the default logging behavior.  After this patch series,
    all tests can access any logged data, and this particular test can
    explicitly check for the presence or absence of the warning, such that
    the test output becomes:
    
    TEST: qemuargv2xmltest
          ........................................ 40
          .................                        57  OK
    PASS: qemuargv2xmltest
    
    * tests/testutils.h (virtTestLogContentAndReset): New prototype.
    * tests/testutils.c (struct virtTestLogData): New struct.
    (virtTestLogOutput, virtTestLogClose, virtTestLogContentAndReset):
    New functions.
    (virtTestMain): Always capture log data emitted during tests.
    * tests/qemuargv2xmltest.c (testCompareXMLToArgvHelper, mymain):
    Use flag to mark which tests expect noisy stderr.
    (testCompareXMLToArgvFiles): Add parameter to test whether stderr
    was appropriately silent.
    9e3525df
qemuargv2xmltest.c 6.7 KB