You need to sign in or sign up before continuing.
  • D
    Remove use of virConnectPtr from all remaining nwfilter code · 999d72fb
    Daniel P. Berrange 提交于
    The virConnectPtr is passed around loads of nwfilter code in
    order to provide it as a parameter to the callback registered
    by the virt drivers. None of the virt drivers use this param
    though, so it serves no purpose.
    
    Avoiding the need to pass a virConnectPtr means that the
    nwfilterStateReload method no longer needs to open a bogus
    QEMU driver connection. This addresses a race condition that
    can lead to a crash on startup.
    
    The nwfilter driver starts before the QEMU driver and registers
    some callbacks with DBus to detect firewalld reload. If the
    firewalld reload happens while the QEMU driver is still starting
    up though, the nwfilterStateReload method will open a connection
    to the partially initialized QEMU driver and cause a crash.
    Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
    999d72fb
lxc_driver.c 136.3 KB