• P
    virsh: volume: Fix lookup of volumes to provide better error messages · a751e345
    Peter Krempa 提交于
    If a user specifies the pool explicitly, we should make sure to point
    out that it's inactive instead of falling back to lookup by key/path and
    failing at the end. Also if the pool isn't found there's no use in
    continuing the lookup.
    
    This changes the error in case the user-selected pool is inactive from:
    
     $ virsh vol-upload --pool inactivepool --vol somevolname volcontents
     error: failed to get vol 'somevolname'
     error: Storage volume not found: no storage vol with matching path
     somevolname
    
    To a more descriptive:
    
     $ virsh vol-upload --pool inactivepool --vol somevolname volcontents
     error: pool 'inactivepool' is not active
    
    And in case a user specifies an invalid pool from:
    
     $ virsh vol-upload --pool invalidpool --vol somevolname volcontents
     error: failed to get pool 'invalidpool'
     error: failed to get vol 'somevolname', specifying --pool might help
     error: Storage volume not found: no storage vol with matching path somevolname
    
    To something less confusing:
    
     $ virsh vol-upload --pool invalidpool --vol somevolname volcontents
     error: failed to get pool 'invalidpool'
     error: Storage pool not found: no storage pool with matching name 'invalidpool'
    a751e345
virsh-volume.c 48.8 KB