• J
    Fix parsing of bond interface XML · 5ba077dc
    Jim Fehlig 提交于
    Noticed that parsing bond interface XML containing the miimon element
    fails
    
      <interface type="bond" name="bond0">
        ...
        <bond mode="active-backup">
          <miimon freq="100" carrier="netif"/>
          ...
        </bond>
      </interface>
    
    This configuration does not contain the optional updelay and downdelay
    attributes, but parsing will fail due to returning the result of
    virXPathULong (a -1 when the attribute doesn't exist) from
    virInterfaceDefParseBond after examining the updelay attribute.
    
    While fixing this bug, cleanup the function to use virXPathInt instead
    of virXPathULong, and store the result directly instead of using a tmp
    variable.  Using virXPathInt actually fixes a potential silent
    truncation bug noted by Eric Blake.
    
    Also, there is no cleanup in the error label.  Remove the label,
    returning failure where failure occurs and success if the end of the
    function is reached.
    5ba077dc
interface_conf.c 39.1 KB