• L
    conf: eliminate virDomainPCIAddressReleaseSlot() in favor of ...Addr() · 5949b53a
    Laine Stump 提交于
    Surprisingly there was a virDomainPCIAddressReleaseAddr() function
    already, but it was completely unused. Since we don't reserve entire
    slots at once any more, there is no need to release entire slots
    either, so we just replace the single call to
    virDomainPCIAddressReleaseSlot() with a call to
    virDomainPCIAddressReleaseAddr() and remove the now unused function.
    
    The keen observer may be concerned that ...Addr() doesn't call
    virDomainPCIAddressValidate(), as ...Slot() did. But really the
    validation was pointless anyway - if the device hadn't been suitable
    to be connected at that address, it would have failed validation
    before every being reserved in the first place, so by definition it
    will pass validation when it is being unplugged. (And anyway, even if
    something "bad" happened and we managed to have a device incorrectly
    at the given address, we would still want to be able to free it up for
    use by a device that *did* validate properly).
    5949b53a
qemu_domain_address.c 88.5 KB