• D
    Annotate many methods with ATTRIBUTE_RETURN_CHECK & fix problems · 46992453
    Daniel P. Berrange 提交于
    Nearly all of the methods in src/util/util.h have error codes that
    must be checked by the caller to correct detect & report failure.
    Add ATTRIBUTE_RETURN_CHECK to ensure compile time validation of
    this
    
    * daemon/libvirtd.c: Add explicit check on return value of virAsprintf
    * src/conf/domain_conf.c: Add missing check on virParseMacAddr return
      value status & report error
    * src/network/bridge_driver.c: Add missing OOM check on virAsprintf
      and report error
    * src/qemu/qemu_conf.c: Add missing check on virParseMacAddr return
      value status & report error
    * src/security/security_selinux.c: Remove call to virRandomInitialize
      that's done in libvirt.c already
    * src/storage/storage_backend_logical.c: Add check & log on virRun
      return status
    * src/util/util.c: Add missing checks on virAsprintf/Run status
    * src/util/util.h: Annotate all methods with ATTRIBUTE_RETURN_CHECK
      if they return an error status code
    * src/vbox/vbox_tmpl.c: Add missing check on virParseMacAddr
    * src/xen/xm_internal.c: Add missing checks on virAsprintf
    * tests/qemuargv2xmltest.c: Remove bogus call to virRandomInitialize()
    46992453
qemu_conf.c 116.1 KB