• E
    virsh: fix regression in argv parsing · 466f9024
    Eric Blake 提交于
    Prior to commit 85d28108, we had an issue where:
    
    snapshot-create-as dom name --diskspec spec --diskspec spec
    
    failed to parse the second spec, because the first spec had marked
    that option as no longer requiring an argument.
    
    In commit 85d28108, I fixed it by making argv options no longer mark
    the option as seen.  But this in turn breaks mandatory argv options,
    which now complain that the argv option is missing.
    
    This patch reverts that part of 85d28108, and instead replaces it with
    fixes to no longer clear opts_need_arg of an argv argument.
    
    * tools/virsh.c (vshCmddefGetOption, vshCmddefGetData)
    (vshCommandParse): Fix option parsing for required argv option.
    (vshCmddefOptParse): Check that argv option is last.
    * tests/virsh-optparse: Enhance test.
    466f9024
virsh-optparse 3.7 KB