• D
    Revert "Prevent more compiler optimization of mockable functions" · 407a281a
    Daniel P. Berrange 提交于
    This reverts commit e4b980c8.
    
    When a binary links against a .a archive (as opposed to a shared library),
    any symbols which are marked as 'weak' get silently dropped. As a result
    when the binary later runs, those 'weak' functions have an address of
    0x0 and thus crash when run.
    
    This happened with virtlogd and virtlockd because they don't link to
    libvirt.so, but instead just libvirt_util.a and libvirt_rpc.a. The
    virRandomBits symbols was weak and so left out of the virtlogd &
    virtlockd binaries, despite being required by virHashTable functions.
    
    Various other binaries like libvirt_lxc, libvirt_iohelper, etc also
    link directly to .a files instead of libvirt.so, so are potentially
    at risk of dropping symbols leading to a later runtime crash.
    
    This is normal linker behaviour because a weak symbol is not treated
    as undefined, so nothing forces it to be pulled in from the .a You
    have to force the linker to pull in weak symbols using -u$SYMNAME
    which is not a practical approach.
    
    This risk is silent bad linkage that affects runtime behaviour is
    not acceptable for a fix that was merely trying to fix the test
    suite. So stop using __weak__ again.
    Signed-off-by: NDaniel P. Berrange <berrange@redhat.com>
    407a281a
virscsi.h 4.0 KB