• A
    virsh: avoid missing zero value judgement in cmdBlkiotune · 3f39a0bf
    Alex Jia 提交于
    * tools/virsh.c: fix missing zero value judgement in cmdBlkiotune and correct
      vshError information.
    
      when weight is equal to 0, the cmdBlkiotune will not raise any error information
      when judge weight value first time, and execute else branch to judge weight
      value again, strncpy(temp->field, VIR_DOMAIN_BLKIO_WEIGHT, sizeof(temp->field))
      will be not executed for ever. However, if and only if param->field is equal
      to VIR_DOMAIN_BLKIO_WEIGHT, underlying qemuDomainSetBlkioParameters function
      will check whether weight value is in range [100, 1000].
    
    * how to reproduce?
    
      % virsh blkiotune ${guestname} --weight 0
    Signed-off-by: NAlex Jia <ajia@redhat.com>
    3f39a0bf
virsh.c 425.0 KB