• E
    build: use correct type for pid and similar types · 3e2c3d8f
    Eric Blake 提交于
    No thanks to 64-bit windows, with 64-bit pid_t, we have to avoid
    constructs like 'int pid'.  Our API in libvirt-qemu cannot be
    changed without breaking ABI; but then again, libvirt-qemu can
    only be used on systems that support UNIX sockets, which rules
    out Windows (even if qemu could be compiled there) - so for all
    points on the call chain that interact with this API decision,
    we require a different variable name to make it clear that we
    audited the use for safety.
    
    Adding a syntax-check rule only solves half the battle; anywhere
    that uses printf on a pid_t still needs to be converted, but that
    will be a separate patch.
    
    * cfg.mk (sc_correct_id_types): New syntax check.
    * src/libvirt-qemu.c (virDomainQemuAttach): Document why we didn't
    use pid_t for pid, and validate for overflow.
    * include/libvirt/libvirt-qemu.h (virDomainQemuAttach): Tweak name
    for syntax check.
    * src/vmware/vmware_conf.c (vmwareExtractPid): Likewise.
    * src/driver.h (virDrvDomainQemuAttach): Likewise.
    * tools/virsh.c (cmdQemuAttach): Likewise.
    * src/remote/qemu_protocol.x (qemu_domain_attach_args): Likewise.
    * src/qemu_protocol-structs (qemu_domain_attach_args): Likewise.
    * src/util/cgroup.c (virCgroupPidCode, virCgroupKillInternal):
    Likewise.
    * src/qemu/qemu_command.c(qemuParseProcFileStrings): Likewise.
    (qemuParseCommandLinePid): Use pid_t for pid.
    * daemon/libvirtd.c (daemonForkIntoBackground): Likewise.
    * src/conf/domain_conf.h (_virDomainObj): Likewise.
    * src/probes.d (rpc_socket_new): Likewise.
    * src/qemu/qemu_command.h (qemuParseCommandLinePid): Likewise.
    * src/qemu/qemu_driver.c (qemudGetProcessInfo, qemuDomainAttach):
    Likewise.
    * src/qemu/qemu_process.c (qemuProcessAttach): Likewise.
    * src/qemu/qemu_process.h (qemuProcessAttach): Likewise.
    * src/uml/uml_driver.c (umlGetProcessInfo): Likewise.
    * src/util/virnetdev.h (virNetDevSetNamespace): Likewise.
    * src/util/virnetdev.c (virNetDevSetNamespace): Likewise.
    * tests/testutils.c (virtTestCaptureProgramOutput): Likewise.
    * src/conf/storage_conf.h (_virStoragePerms): Use mode_t, uid_t,
    and gid_t rather than int.
    * src/security/security_dac.c (virSecurityDACSetOwnership): Likewise.
    * src/conf/storage_conf.c (virStorageDefParsePerms): Avoid
    compiler warning.
    3e2c3d8f
security_dac.c 21.2 KB