• E
    qemu: nicer error message if live disk snapshot unsupported · 3bef4adf
    Eric Blake 提交于
    Without this patch, attempts to create a disk snapshot when qemu
    is too old results in a cryptic message:
    
    virsh # snapshot-create 23 --disk-only
    error: operation failed: Failed to take snapshot: unknown command: 'snapshot_blkdev'
    
    Now it reports:
    
    virsh # snapshot-create 23 --disk-only
    error: unsupported configuration: live disk snapshot not supported with this QEMU binary
    
    All versions of qemu that support live disk snapshot also support
    QMP (basically upstream qemu 1.1 and later, and backports to RHEL 6.2).
    
    * src/qemu/qemu_capabilities.h (QEMU_CAPS_DISK_SNAPSHOT): New
    capability.
    * src/qemu/qemu_capabilities.c (qemuCaps): Track it.
    (qemuCapsProbeQMPCommands): Set it.
    * src/qemu/qemu_driver.c (qemuDomainSnapshotCreateDiskActive): Use
    it.
    * src/qemu/qemu_monitor.c (qemuMonitorDiskSnapshot): Simplify.
    * src/qemu/qemu_monitor_json.c (qemuMonitorJSONDiskSnapshot):
    Likewise.
    * src/qemu/qemu_monitor_text.h (qemuMonitorTextDiskSnapshot):
    Delete.
    * src/qemu/qemu_monitor_text.c (qemuMonitorTextDiskSnapshot):
    Likewise.
    3bef4adf
qemu_capabilities.h 12.3 KB