• E
    maint: reject raw close, popen in 'make syntax-check' · 030ce43b
    Eric Blake 提交于
    commit f1fe9671 was supposed to make sure we use files.h
    macros to avoid double close, but it didn't work.
    
    Meanwhile, virCommand is vastly superior to system(), fork(),
    and popen() (also to virExec, but we haven't completed that
    conversion), so enforce that, too.
    
    * cfg.mk (sc_prohibit_close): Fix typo that excluded close, and
    add pclose.
    (sc_prohibit_fork_wrappers): New rule, for fork, system, and popen.
    * .x-sc_prohibit_close: More exemptions.
    * .x-sc_prohibit_fork_wrappers: New file.
    * Makefile.am (syntax_check_exceptions): Ship new file.
    * src/datatypes.c (virReleaseConnect): Tweak comment to avoid
    false positive.
    * src/util/files.h (VIR_CLOSE): Likewise.
    030ce43b
.x-sc_prohibit_close 161 字节
新手
引导
客服 返回
顶部