• E
    maint: prohibit access(,X_OK) · 391c397e
    Eric Blake 提交于
    This simplifies several callers that were repeating checks already
    guaranteed by util.c, and makes other callers more robust to now
    reject directories.  remote_driver.c was over-strict - access(,R_OK)
    is only needed to execute a script file; a binary only needs
    access(,X_OK) (besides, it's unusual to see a file with x but not
    r permissions, whether script or binary).
    
    * cfg.mk (sc_prohibit_access_xok): New syntax-check rule.
    (exclude_file_name_regexp--sc_prohibit_access_xok): Exempt one use.
    * src/network/bridge_driver.c (networkStartRadvd): Fix offenders.
    * src/qemu/qemu_capabilities.c (qemuCapsProbeMachineTypes)
    (qemuCapsInitGuest, qemuCapsInit, qemuCapsExtractVersionInfo):
    Likewise.
    * src/remote/remote_driver.c (remoteFindDaemonPath): Likewise.
    * src/uml/uml_driver.c (umlStartVMDaemon): Likewise.
    * src/util/hooks.c (virHookCheck): Likewise.
    391c397e
qemu_capabilities.c 36.7 KB