• L
    conf: remove parse code for long-extinct "<state devaddr='d:b:s'/> · 382c762c
    Laine Stump 提交于
    Back in July 2009, in the days before libvirt supported explicitly
    assigning a PCI address to every device, code was added to save the
    PCI addresses of hotplugged network, disk, and hostdevs in the domain
    status with this XML element:
    
       <state devaddr='domain:bus:slot'/>
    
    This was added in commits 4e21a95a, 01654107, in v0.7.0, and 0c5b7b93
    in v0.7.1.
    
    Then just a few months later, in November 2009, The code that actually
    formatted the "devaddr='blah'" into the status XML was removed by
    commit 1b0cce7d (which "introduced a standardized data structure for
    device addresses"). The code to *parse* the devaddr from the status
    was left in for backward compatibility though (it just parses it into
    the "standard" PCI address).
    
    At the time the devaddr attribute was added, a few other attributes
    already existed in the <state> element for network devices, and these
    were removed over time (I haven't checked the exact dates of this),
    but 10 years later, in libvirt v5.8.0, we *still* maintain code to
    parse <state devaddr='blah'/> from the domain status.
    
    In the meantime, even distros so old that we no longer support them in
    upstream libvirt are using a libvirt new enough that it doesn't ever
    write <state devaddr='blah'/> to the domain status XML.
    
    Since the only way a current libvirt would ever encounter this element
    would be if someone was upgrading directly from libvirt <= v0.7.5 with
    running guests, it seems safe to finally remove the code that parses it.
    Signed-off-by: NLaine Stump <laine@redhat.com>
    Reviewed-by: NJán Tomko <jtomko@redhat.com>
    382c762c
domain_conf.c 995.1 KB