• J
    Perform disk config validity checking for attach-device config · 33188c9f
    John Ferlan 提交于
    https://bugzilla.redhat.com/show_bug.cgi?id=1078126
    
    Using 'virsh attach-device --config' (or --persistent) to attach a
    file backed lun device will succeed; however, subsequent domain restarts
    will result in failure because the configuration of a file backed lun
    is not supported.
    
    Although allowing 'illegal configurations' is something that can be
    allowed, it may not be practical in this case. Generally, when attaching
    a device to a domain means the domain must be running. A way around
    this is using the --config (or --persistent) option. When an attach
    is done to a running domain, a temporary configuration is modified
    first followed by the live update. The live update will make a number
    of disk validity checks when building the qemu command to attach the
    disk. If any fail, then change is rejected.
    
    Rather than allow a potentially illegal combination, adjust the code
    in the configuration path to make the same checks as the running path
    will make with respect to disk validity checks. This way we avoid
    having the potential for some subsequent start/reboot to fail because
    an illegal combination was allowed.
    
    NB: The live path still checks the configuration since it is possible
    to just do --live guest modification...
    33188c9f
qemu_driver.c 551.7 KB