• E
    Revert "admin: Rename virAdmConnect to virAdmDaemon" · 3245e178
    Erik Skultety 提交于
    Commmit df8192aa introduced admin related rename and some minor
    (caused by automated approach, aka sed) and some more severe isues along with
    it. First reason to revert is the inconsistency with libvirt library.
    Although we deal with the daemon directly rather than with a specific
    hypervisor, we still do have a connection. That being said, contributors might
    get under the impression that AdmDaemonNew would spawn/start a new daemon
    (since it's admin API, why not...), or AdmDaemonClose would do the exact
    opposite or they might expect DaemonIsAlive report overall status of the daemon
    which definitely isn't the case.
    The second reason to revert this patch is renaming virt-admin client. The
    client tool does not necessarily have to reflect the names of the API's it's
    using in his internals. An example would be 's/vshAdmConnect/vshAdmDaemon'
    where noone can be certain of what the latter function really does. The former
    is quite expressive about some connection magic it performs, but the latter does
    not say anything, especially when vshAdmReconnect and vshAdmDisconnect were
    left untouched.
    3245e178
virsh.c 27.2 KB