• N
    qemu: don't log error for missing optional storage sources on stats · 318d807a
    Nikolay Shirokovskiy 提交于
    Every time we call all domain stats for inactive domain with
    unavailable storage source we get error message in logs [1]. It's a bit noisy.
    While it's arguable whether we need such message or not for mandatory
    disks we would like not to see messages for optional disks. Let's
    filter at least for cases of local files. Fixing other cases would
    require passing flag down the stack to .backendInit of storage
    which is ugly.
    
    Stats for active domain are fine because we either drop disks
    with unavailable sources or clean source which is handled
    by virStorageSourceIsEmpty in qemuDomainGetStatsOneBlockFallback.
    
    We have these logs for successful stats since 25aa7035 (version 1.2.15)
    which in turn fixes 596a1371 (version 1.2.12 )which added substantial
    stats for offline disks.
    
    [1] error message example:
    qemuOpenFileAs:3324 : Failed to open file '/path/to/optional/disk': No such file or directory
    Signed-off-by: NNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
    318d807a
qemu_driver.c 710.8 KB