• D
    rpc: always pass "-T -e none" args to ssh · 1939bcd5
    Daniel P. Berrangé 提交于
    Way back in the past, the "no_tty=1" option was added for the remote
    driver to disable local password prompting by disabling use of the local
    tty:
    
      commit b32f4298
      Author: Daniel P. Berrange <berrange@redhat.com>
      Date:   Fri Sep 21 20:17:09 2007 +0000
    
        Added a no_tty param to remote URIs to stop SSH prompting for password
    
    This was done by adding "-T -o BatchMode=yes -e none" args to ssh. This
    achieved the desired results but is none the less semantically flawed
    because it is mixing up config parameters for the local tty vs the
    remote tty.
    
    The "-T" arg stops allocation of a TTY on the remote host. This is good
    for all libvirt SSH tunnels as we never require a TTY for our usage
    model, so we should have just passed this unconditionally.
    
    The "-e none" option disables the escape character for sessions with a
    TTY. If we pass "-T" this is not required, but it also not harmful to
    add it, so we should just pass it unconditionally too.
    
    Only the "-o BatchMode=yes" option is related to disabling local
    password prompts and thus needs control via the no_tty URI param.
    Reviewed-by: NAndrea Bolognani <abologna@redhat.com>
    Signed-off-by: NDaniel P. Berrangé <berrange@redhat.com>
    1939bcd5
virnetsockettest.c 18.0 KB