• J
    conf: Return the vHBA name from virNodeDeviceCreateVport · 08c0ea16
    John Ferlan 提交于
    Rather than returning true/false and having the caller check if the
    vHBA was actually created, let's do that check within the CreateVport
    function. That way the caller can faithfully assume success based
    on a name start the thread looking for the LUNs. Prior to this change
    it's possible that the vHBA wasn't really created (e.g if the call to
    virVHBAGetHostByWWN returned NULL), we'd claim success, but in reality
    there'd be no vHBA for the pool. This also fixes a second yet seen
    issue that if the nodedev was present, but the parent by name wasn't
    provided (perhaps parent by wwnn/wwpn or by fabric_name), then a failure
    would be returned. For this path it shouldn't be an error - we should
    just be happy that something else is managing the device and we don't
    have to create/delete it.
    
    The end result is that the createVport code can now just start the
    refresh thread once it gets a non NULL name back.
    Signed-off-by: NJohn Ferlan <jferlan@redhat.com>
    08c0ea16
node_device_conf.c 69.9 KB