• E
    build: avoid ATTRIBUTE_UNUSED in headers · 088473b2
    Eric Blake 提交于
    The compiler might optimize based on our declaration that something
    is unused.  Putting that declaration in the header risks getting
    out of sync with the actual implementation, so it belongs better
    only in the .c files.  We were mostly compliant, and a new syntax
    check will help us in the future.
    
    * cfg.mk (sc_avoid_attribute_unused_in_header): New syntax check.
    * src/nodeinfo.h (nodeGetCPUStats, nodeGetMemoryStats): Delete
    attribute already present in .c file.
    * src/qemu/qemu_domain.h (qemuDomainEventFlush): Likewise.
    * src/util/virterror_internal.h (virReportErrorHelper): Parameters
    are actually used by .c file.
    * src/xenxs/xen_sxpr.h (xenFormatSxprDisk): Adjust prototype.
    * src/xenxs/xen_sxpr.c (xenFormatSxprDisk): Delete unused argument.
    (xenFormatSxpr): Adjust caller.
    * src/xen/xend_internal.c (xenDaemonAttachDeviceFlags)
    (xenDaemonUpdateDeviceFlags): Likewise.
    Suggested by Daniel Veillard.
    088473b2
nodeinfo.h 1.8 KB