• A
    virsh: plug memory leaks on failure path · 03ca3317
    Alex Jia 提交于
    Leaks are introduced in commit 1cf0e3db and fe383bb5.
    
    Fixing memory leaks, in addition, the patch also fixes a potential missing
    return value issue in 'if (from)' statement, without the fixing, although
    the programming met a error, the subsequent codes will be executed
    continually.
    
    * tools/virsh.c (cmdSnapshotList): fix memory leaks and missing return value.
    
    * How to reproduce?
    
    % virsh snapshot-list <domain> --parent --roots
    % virsh snapshot-list <domain> --parent --tree
    % virsh snapshot-list <domain> --roots --tree
    
    actual result:
    error: --parent and --roots are mutually exclusive
    error: Failed to disconnect from the hypervisor, 1 leaked reference(s)
    
    error: --parent and --tree are mutually exclusive
    error: Failed to disconnect from the hypervisor, 1 leaked reference(s)
    
    error: --roots and --tree are mutually exclusive
    error: Failed to disconnect from the hypervisor, 1 leaked reference(s)
    
    % virsh snapshot-create-as <domain> --name "hello"
    % virsh snapshot-create-as <domain> --name "libvirt"
    % virsh snapshot-list <domain> --roots --from "hello"
    
    actual result:
    error: --roots and --from are mutually exclusive
     Name                 Creation Time             State
    ------------------------------------------------------------
     libvirt              2012-03-28 13:46:51 +0800 running
    Signed-off-by: NAlex Jia <ajia@redhat.com>
    03ca3317
virsh.c 581.5 KB