bridge.c 18.9 KB
Newer Older
1
/*
J
Jim Meyering 已提交
2
 * Copyright (C) 2007, 2009 Red Hat, Inc.
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
 *
 * Authors:
 *     Mark McLoughlin <markmc@redhat.com>
 */

#include <config.h>

24
#if defined(WITH_BRIDGE)
25

26 27 28 29 30 31 32 33 34 35 36 37
#include "bridge.h"

#include <stdlib.h>
#include <stdio.h>
#include <string.h>
#include <unistd.h>
#include <fcntl.h>
#include <errno.h>
#include <arpa/inet.h>
#include <sys/types.h>
#include <sys/socket.h>
#include <sys/ioctl.h>
38 39
#include <paths.h>
#include <sys/wait.h>
40 41 42 43 44

#include <linux/param.h>     /* HZ                 */
#include <linux/sockios.h>   /* SIOCBRADDBR etc.   */
#include <linux/if_bridge.h> /* SYSFS_BRIDGE_ATTR  */
#include <linux/if_tun.h>    /* IFF_TUN, IFF_NO_PI */
45
#include <net/if_arp.h>    /* ARPHRD_ETHER */
46 47

#include "internal.h"
48
#include "memory.h"
49
#include "util.h"
50
#include "logging.h"
51 52 53 54 55 56 57 58

#define JIFFIES_TO_MS(j) (((j)*1000)/HZ)
#define MS_TO_JIFFIES(ms) (((ms)*HZ)/1000)

struct _brControl {
    int fd;
};

59 60 61 62 63 64 65 66 67
/**
 * brInit:
 * @ctlp: pointer to bridge control return value
 *
 * Initialize a new bridge layer. In case of success
 * @ctlp will contain a pointer to the new bridge structure.
 *
 * Returns 0 in case of success, an error code otherwise.
 */
68 69 70 71
int
brInit(brControl **ctlp)
{
    int fd;
72
    int flags;
73 74 75 76 77 78 79 80

    if (!ctlp || *ctlp)
        return EINVAL;

    fd = socket(AF_INET, SOCK_STREAM, 0);
    if (fd < 0)
        return errno;

81 82 83 84 85 86 87
    if ((flags = fcntl(fd, F_GETFD)) < 0 ||
        fcntl(fd, F_SETFD, flags | FD_CLOEXEC) < 0) {
        int err = errno;
        close(fd);
        return err;
    }

88
    if (VIR_ALLOC(*ctlp) < 0) {
89
        close(fd);
90
        return ENOMEM;
91
    }
92 93 94 95 96 97

    (*ctlp)->fd = fd;

    return 0;
}

98 99 100 101 102 103
/**
 * brShutdown:
 * @ctl: pointer to a bridge control
 *
 * Shutdown the bridge layer and deallocate the associated structures
 */
104 105 106 107 108 109 110 111 112
void
brShutdown(brControl *ctl)
{
    if (!ctl)
        return;

    close(ctl->fd);
    ctl->fd = 0;

113
    VIR_FREE(ctl);
114 115
}

116 117 118
/**
 * brAddBridge:
 * @ctl: bridge control pointer
119
 * @name: the bridge name
120
 *
121
 * This function register a new bridge
122 123 124
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
125
#ifdef SIOCBRADDBR
126 127
int
brAddBridge(brControl *ctl,
128
            const char *name)
129
{
130
    if (!ctl || !ctl->fd || !name)
131 132
        return EINVAL;

133 134
    if (ioctl(ctl->fd, SIOCBRADDBR, name) == 0)
        return 0;
135 136 137

    return errno;
}
138 139
#else
int brAddBridge (brControl *ctl ATTRIBUTE_UNUSED,
140
                 const char *name ATTRIBUTE_UNUSED)
141 142 143 144
{
    return EINVAL;
}
#endif
145

146 147 148 149 150 151 152 153 154 155 156 157
#ifdef SIOCBRDELBR
int
brHasBridge(brControl *ctl,
            const char *name)
{
    struct ifreq ifr;

    if (!ctl || !name) {
        errno = EINVAL;
        return -1;
    }

C
Chris Lalancette 已提交
158 159 160
    memset(&ifr, 0, sizeof(struct ifreq));

    if (virStrcpyStatic(ifr.ifr_name, name) == NULL) {
161 162 163 164 165 166 167 168 169 170 171
        errno = EINVAL;
        return -1;
    }

    if (ioctl(ctl->fd, SIOCGIFFLAGS, &ifr))
        return -1;

    return 0;
}
#else
int
172 173
brHasBridge(brControl *ctl ATTRIBUTE_UNUSED,
            const char *name ATTRIBUTE_UNUSED)
174 175 176 177 178
{
    return EINVAL;
}
#endif

179 180 181 182 183 184 185 186 187
/**
 * brDeleteBridge:
 * @ctl: bridge control pointer
 * @name: the bridge name
 *
 * Remove a bridge from the layer.
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
188
#ifdef SIOCBRDELBR
189 190 191 192 193 194 195 196 197
int
brDeleteBridge(brControl *ctl,
               const char *name)
{
    if (!ctl || !ctl->fd || !name)
        return EINVAL;

    return ioctl(ctl->fd, SIOCBRDELBR, name) == 0 ? 0 : errno;
}
198 199 200 201 202 203 204 205
#else
int
brDeleteBridge(brControl *ctl ATTRIBUTE_UNUSED,
               const char *name ATTRIBUTE_UNUSED)
{
    return EINVAL;
}
#endif
206

207
#if defined(SIOCBRADDIF) && defined(SIOCBRDELIF)
208 209 210 211 212 213 214 215 216 217 218 219 220
static int
brAddDelInterface(brControl *ctl,
                  int cmd,
                  const char *bridge,
                  const char *iface)
{
    struct ifreq ifr;

    if (!ctl || !ctl->fd || !bridge || !iface)
        return EINVAL;

    memset(&ifr, 0, sizeof(struct ifreq));

C
Chris Lalancette 已提交
221 222
    if (virStrcpyStatic(ifr.ifr_name, bridge) == NULL)
        return EINVAL;
223 224 225 226 227 228

    if (!(ifr.ifr_ifindex = if_nametoindex(iface)))
        return ENODEV;

    return ioctl(ctl->fd, cmd, &ifr) == 0 ? 0 : errno;
}
229
#endif
230

231 232 233 234 235
/**
 * brAddInterface:
 * @ctl: bridge control pointer
 * @bridge: the bridge name
 * @iface: the network interface name
236
 *
237 238 239 240
 * Adds an interface to a bridge
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
241
#ifdef SIOCBRADDIF
242 243 244 245 246 247 248
int
brAddInterface(brControl *ctl,
               const char *bridge,
               const char *iface)
{
    return brAddDelInterface(ctl, SIOCBRADDIF, bridge, iface);
}
249 250 251 252 253 254 255 256 257
#else
int
brAddInterface(brControl *ctl ATTRIBUTE_UNUSED,
               const char *bridge ATTRIBUTE_UNUSED,
               const char *iface ATTRIBUTE_UNUSED)
{
    return EINVAL;
}
#endif
258

259 260 261 262 263
/**
 * brDeleteInterface:
 * @ctl: bridge control pointer
 * @bridge: the bridge name
 * @iface: the network interface name
264
 *
265 266 267 268
 * Removes an interface from a bridge
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
269
#ifdef SIOCBRDELIF
270 271 272 273 274 275 276
int
brDeleteInterface(brControl *ctl,
                  const char *bridge,
                  const char *iface)
{
    return brAddDelInterface(ctl, SIOCBRDELIF, bridge, iface);
}
277 278 279 280 281 282 283 284 285
#else
int
brDeleteInterface(brControl *ctl ATTRIBUTE_UNUSED,
                  const char *bridge ATTRIBUTE_UNUSED,
                  const char *iface ATTRIBUTE_UNUSED)
{
    return EINVAL;
}
#endif
286

287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305
/**
 * ifGetMtu
 * @ctl: bridge control pointer
 * @ifname: interface name get MTU for
 *
 * This function gets the @mtu value set for a given interface @ifname.
 *
 * Returns the MTU value in case of success.
 * On error, returns -1 and sets errno accordingly
 */
static int ifGetMtu(brControl *ctl, const char *ifname)
{
    struct ifreq ifr;

    if (!ctl || !ifname) {
        errno = EINVAL;
        return -1;
    }

C
Chris Lalancette 已提交
306 307 308
    memset(&ifr, 0, sizeof(struct ifreq));

    if (virStrcpyStatic(ifr.ifr_name, ifname) == NULL) {
309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339
        errno = EINVAL;
        return -1;
    }

    if (ioctl(ctl->fd, SIOCGIFMTU, &ifr))
        return -1;

    return ifr.ifr_mtu;

}

/**
 * ifSetMtu:
 * @ctl: bridge control pointer
 * @ifname: interface name to set MTU for
 * @mtu: MTU value
 *
 * This function sets the @mtu for a given interface @ifname.  Typically
 * used on a tap device to set up for Jumbo Frames.
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
static int ifSetMtu(brControl *ctl, const char *ifname, int mtu)
{
    struct ifreq ifr;

    if (!ctl || !ifname)
        return EINVAL;

    memset(&ifr, 0, sizeof(struct ifreq));

C
Chris Lalancette 已提交
340 341
    if (virStrcpyStatic(ifr.ifr_name, ifname) == NULL)
        return EINVAL;
342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368
    ifr.ifr_mtu = mtu;

    return ioctl(ctl->fd, SIOCSIFMTU, &ifr) == 0 ? 0 : errno;
}

/**
 * brSetInterfaceMtu
 * @ctl: bridge control pointer
 * @bridge: name of the bridge interface
 * @ifname: name of the interface whose MTU we want to set
 *
 * Sets the interface mtu to the same MTU of the bridge
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
static int brSetInterfaceMtu(brControl *ctl,
                             const char *bridge,
                             const char *ifname)
{
    int mtu = ifGetMtu(ctl, bridge);

    if (mtu < 0)
        return errno;

    return ifSetMtu(ctl, ifname, mtu);
}

369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387
/**
 * brProbeVnetHdr:
 * @tapfd: a tun/tap file descriptor
 *
 * Check whether it is safe to enable the IFF_VNET_HDR flag on the
 * tap interface.
 *
 * Setting IFF_VNET_HDR enables QEMU's virtio_net driver to allow
 * guests to pass larger (GSO) packets, with partial checksums, to
 * the host. This greatly increases the achievable throughput.
 *
 * It is only useful to enable this when we're setting up a virtio
 * interface. And it is only *safe* to enable it when we know for
 * sure that a) qemu has support for IFF_VNET_HDR and b) the running
 * kernel implements the TUNGETIFF ioctl(), which qemu needs to query
 * the supplied tapfd.
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
388
#ifdef IFF_VNET_HDR
389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420
static int
brProbeVnetHdr(int tapfd)
{
#if defined(IFF_VNET_HDR) && defined(TUNGETFEATURES) && defined(TUNGETIFF)
    unsigned int features;
    struct ifreq dummy;

    if (ioctl(tapfd, TUNGETFEATURES, &features) != 0) {
        VIR_INFO0(_("Not enabling IFF_VNET_HDR; "
                    "TUNGETFEATURES ioctl() not implemented"));
        return 0;
    }

    if (!(features & IFF_VNET_HDR)) {
        VIR_INFO0(_("Not enabling IFF_VNET_HDR; "
                    "TUNGETFEATURES ioctl() reports no IFF_VNET_HDR"));
        return 0;
    }

    /* The kernel will always return -1 at this point.
     * If TUNGETIFF is not implemented then errno == EBADFD.
     */
    if (ioctl(tapfd, TUNGETIFF, &dummy) != -1 || errno != EBADFD) {
        VIR_INFO0(_("Not enabling IFF_VNET_HDR; "
                    "TUNGETIFF ioctl() not implemented"));
        return 0;
    }

    VIR_INFO0(_("Enabling IFF_VNET_HDR"));

    return 1;
#else
421
    (void) tapfd;
422 423 424 425
    VIR_INFO0(_("Not enabling IFF_VNET_HDR; disabled at build time"));
    return 0;
#endif
}
426
#endif
427

428 429 430 431 432
/**
 * brAddTap:
 * @ctl: bridge control pointer
 * @bridge: the bridge name
 * @ifname: the interface name (or name template)
433
 * @vnet_hdr: whether to try enabling IFF_VNET_HDR
434 435
 * @tapfd: file descriptor return value for the new tap device
 *
D
typo  
Daniel Veillard 已提交
436
 * This function creates a new tap device on a bridge. @ifname can be either
437
 * a fixed name or a name template with '%d' for dynamic name allocation.
438 439 440 441 442
 * in either case the final name for the bridge will be stored in @ifname.
 * If the @tapfd parameter is supplied, the open tap device file
 * descriptor will be returned, otherwise the TAP device will be made
 * persistent and closed. The caller must use brDeleteTap to remove
 * a persistent TAP devices when it is no longer needed.
443 444 445
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
446 447 448
int
brAddTap(brControl *ctl,
         const char *bridge,
449
         char **ifname,
450
         int vnet_hdr,
451 452
         int *tapfd)
{
C
Chris Lalancette 已提交
453
    int fd;
454
    struct ifreq ifr;
455

456
    if (!ctl || !ctl->fd || !bridge || !ifname)
457 458 459 460 461
        return EINVAL;

    if ((fd = open("/dev/net/tun", O_RDWR)) < 0)
      return errno;

462 463
    memset(&ifr, 0, sizeof(ifr));

464
    ifr.ifr_flags = IFF_TAP|IFF_NO_PI;
465

466 467 468
#ifdef IFF_VNET_HDR
    if (vnet_hdr && brProbeVnetHdr(fd))
        ifr.ifr_flags |= IFF_VNET_HDR;
469 470
#else
    (void) vnet_hdr;
471
#endif
472

C
Chris Lalancette 已提交
473
    if (virStrcpyStatic(ifr.ifr_name, *ifname) == NULL) {
474 475 476
        errno = EINVAL;
        goto error;
    }
477

C
Chris Lalancette 已提交
478 479 480
    if (ioctl(fd, TUNSETIFF, &ifr) < 0)
        goto error;

481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499
    /* We need to set the interface MTU before adding it
     * to the bridge, because the bridge will have its
     * MTU adjusted automatically when we add the new interface.
     */
    if ((errno = brSetInterfaceMtu(ctl, bridge, ifr.ifr_name)))
        goto error;
    if ((errno = brAddInterface(ctl, bridge, ifr.ifr_name)))
        goto error;
    if ((errno = brSetInterfaceUp(ctl, ifr.ifr_name, 1)))
        goto error;
    if (!tapfd &&
        (errno = ioctl(fd, TUNSETPERSIST, 1)))
        goto error;
    VIR_FREE(*ifname);
    if (!(*ifname = strdup(ifr.ifr_name)))
        goto error;
    if (tapfd)
        *tapfd = fd;
    return 0;
500 501 502 503 504 505 506

 error:
    close(fd);

    return errno;
}

507 508 509 510 511 512 513 514 515 516 517 518 519 520 521
int brDeleteTap(brControl *ctl,
                const char *ifname)
{
    struct ifreq try;
    int fd;

    if (!ctl || !ctl->fd || !ifname)
        return EINVAL;

    if ((fd = open("/dev/net/tun", O_RDWR)) < 0)
        return errno;

    memset(&try, 0, sizeof(struct ifreq));
    try.ifr_flags = IFF_TAP|IFF_NO_PI;

C
Chris Lalancette 已提交
522
    if (virStrcpyStatic(try.ifr_name, ifname) == NULL) {
523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538
        errno = EINVAL;
        goto error;
    }

    if (ioctl(fd, TUNSETIFF, &try) == 0) {
        if ((errno = ioctl(fd, TUNSETPERSIST, 0)))
            goto error;
    }

 error:
    close(fd);

    return errno;
}


539 540 541 542 543 544 545 546 547 548
/**
 * brSetInterfaceUp:
 * @ctl: bridge control pointer
 * @ifname: the interface name
 * @up: 1 for up, 0 for down
 *
 * Function to control if an interface is activated (up, 1) or not (down, 0)
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
549 550 551 552 553 554 555 556 557 558 559 560 561
int
brSetInterfaceUp(brControl *ctl,
                 const char *ifname,
                 int up)
{
    struct ifreq ifr;
    int flags;

    if (!ctl || !ifname)
        return EINVAL;

    memset(&ifr, 0, sizeof(struct ifreq));

C
Chris Lalancette 已提交
562 563
    if (virStrcpyStatic(ifr.ifr_name, ifname) == NULL)
        return EINVAL;
564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579

    if (ioctl(ctl->fd, SIOCGIFFLAGS, &ifr) < 0)
        return errno;

    flags = up ? (ifr.ifr_flags | IFF_UP) : (ifr.ifr_flags & ~IFF_UP);

    if (ifr.ifr_flags != flags) {
        ifr.ifr_flags = flags;

        if (ioctl(ctl->fd, SIOCSIFFLAGS, &ifr) < 0)
            return errno;
    }

    return 0;
}

580 581 582 583 584 585 586 587 588 589
/**
 * brGetInterfaceUp:
 * @ctl: bridge control pointer
 * @ifname: the interface name
 * @up: where to store the status
 *
 * Function to query if an interface is activated (1) or not (0)
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
590 591 592 593 594 595 596
int
brGetInterfaceUp(brControl *ctl,
                 const char *ifname,
                 int *up)
{
    struct ifreq ifr;

597
    if (!ctl || !ifname || !up)
598 599 600 601
        return EINVAL;

    memset(&ifr, 0, sizeof(struct ifreq));

C
Chris Lalancette 已提交
602 603
    if (virStrcpyStatic(ifr.ifr_name, ifname) == NULL)
        return EINVAL;
604 605 606 607 608 609 610 611 612 613 614 615 616 617 618

    if (ioctl(ctl->fd, SIOCGIFFLAGS, &ifr) < 0)
        return errno;

    *up = (ifr.ifr_flags & IFF_UP) ? 1 : 0;

    return 0;
}

static int
brSetInetAddr(brControl *ctl,
              const char *ifname,
              int cmd,
              const char *addr)
{
619 620 621 622
    union {
        struct sockaddr sa;
        struct sockaddr_in sa_in;
    } s;
623 624
    struct ifreq ifr;
    struct in_addr inaddr;
C
Chris Lalancette 已提交
625
    int ret;
626 627 628 629 630 631

    if (!ctl || !ctl->fd || !ifname || !addr)
        return EINVAL;

    memset(&ifr, 0, sizeof(struct ifreq));

C
Chris Lalancette 已提交
632 633
    if (virStrcpyStatic(ifr.ifr_name, ifname) == NULL)
        return EINVAL;
634 635 636 637 638 639

    if ((ret = inet_pton(AF_INET, addr, &inaddr)) < 0)
        return errno;
    else if (ret == 0)
        return EINVAL;

640 641 642 643
    s.sa_in.sin_family = AF_INET;
    s.sa_in.sin_addr   = inaddr;

    ifr.ifr_addr = s.sa;
644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665

    if (ioctl(ctl->fd, cmd, &ifr) < 0)
        return errno;

    return 0;
}

static int
brGetInetAddr(brControl *ctl,
              const char *ifname,
              int cmd,
              char *addr,
              int maxlen)
{
    struct ifreq ifr;
    struct in_addr *inaddr;

    if (!ctl || !ctl->fd || !ifname || !addr)
        return EINVAL;

    memset(&ifr, 0, sizeof(struct ifreq));

C
Chris Lalancette 已提交
666 667
    if (virStrcpyStatic(ifr.ifr_name, ifname) == NULL)
        return EINVAL;
668 669 670 671 672 673 674

    if (ioctl(ctl->fd, cmd, &ifr) < 0)
        return errno;

    if (maxlen < BR_INET_ADDR_MAXLEN || ifr.ifr_addr.sa_family != AF_INET)
        return EFAULT;

675
    inaddr = &((struct sockaddr_in *)&ifr.ifr_data)->sin_addr;
676 677 678 679 680 681 682

    if (!inet_ntop(AF_INET, inaddr, addr, maxlen))
        return errno;

    return 0;
}

683 684 685 686
/**
 * brSetInetAddress:
 * @ctl: bridge control pointer
 * @ifname: the interface name
687
 * @addr: the string representation of the IP address
688 689 690 691 692 693 694 695
 *
 * Function to bind the interface to an IP address, it should handle
 * IPV4 and IPv6. The string for addr would be of the form
 * "ddd.ddd.ddd.ddd" assuming the common IPv4 format.
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */

696 697 698 699 700 701 702 703
int
brSetInetAddress(brControl *ctl,
                 const char *ifname,
                 const char *addr)
{
    return brSetInetAddr(ctl, ifname, SIOCSIFADDR, addr);
}

704 705 706 707
/**
 * brGetInetAddress:
 * @ctl: bridge control pointer
 * @ifname: the interface name
708
 * @addr: the array for the string representation of the IP address
709 710 711 712 713 714 715 716 717
 * @maxlen: size of @addr in bytes
 *
 * Function to get the IP address of an interface, it should handle
 * IPV4 and IPv6. The returned string for addr would be of the form
 * "ddd.ddd.ddd.ddd" assuming the common IPv4 format.
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */

718 719 720 721 722 723 724 725 726
int
brGetInetAddress(brControl *ctl,
                 const char *ifname,
                 char *addr,
                 int maxlen)
{
    return brGetInetAddr(ctl, ifname, SIOCGIFADDR, addr, maxlen);
}

727 728 729 730 731 732 733 734 735 736 737 738 739
/**
 * brSetInetNetmask:
 * @ctl: bridge control pointer
 * @ifname: the interface name
 * @addr: the string representation of the netmask
 *
 * Function to set the netmask of an interface, it should handle
 * IPV4 and IPv6 forms. The string for addr would be of the form
 * "ddd.ddd.ddd.ddd" assuming the common IPv4 format.
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */

740 741 742 743 744 745 746 747
int
brSetInetNetmask(brControl *ctl,
                 const char *ifname,
                 const char *addr)
{
    return brSetInetAddr(ctl, ifname, SIOCSIFNETMASK, addr);
}

748 749 750 751 752 753 754 755 756 757 758 759 760 761
/**
 * brGetInetNetmask:
 * @ctl: bridge control pointer
 * @ifname: the interface name
 * @addr: the array for the string representation of the netmask
 * @maxlen: size of @addr in bytes
 *
 * Function to get the netmask of an interface, it should handle
 * IPV4 and IPv6. The returned string for addr would be of the form
 * "ddd.ddd.ddd.ddd" assuming the common IPv4 format.
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */

762 763 764 765 766 767 768 769 770 771
int
brGetInetNetmask(brControl *ctl,
                 const char *ifname,
                 char *addr,
                 int maxlen)
{
    return brGetInetAddr(ctl, ifname, SIOCGIFNETMASK, addr, maxlen);
}


772 773 774 775 776 777 778 779
/**
 * brSetForwardDelay:
 * @ctl: bridge control pointer
 * @bridge: the bridge name
 * @delay: delay in seconds
 *
 * Set the bridge forward delay
 *
780
 * Returns 0 in case of success or -1 on failure
781
 */
782

783
int
784
brSetForwardDelay(brControl *ctl ATTRIBUTE_UNUSED,
785 786 787
                  const char *bridge,
                  int delay)
{
788
    char delayStr[30];
789 790 791
    const char *const progargv[] = {
        BRCTL, "setfd", bridge, delayStr, NULL
    };
792

793
    snprintf(delayStr, sizeof(delayStr), "%d", delay);
794

795
    if (virRun(progargv, NULL) < 0)
796
        return -1;
797

798
    return 0;
799 800
}

801 802 803 804 805 806 807 808 809
/**
 * brSetEnableSTP:
 * @ctl: bridge control pointer
 * @bridge: the bridge name
 * @enable: 1 to enable, 0 to disable
 *
 * Control whether the bridge participates in the spanning tree protocol,
 * in general don't disable it without good reasons.
 *
810
 * Returns 0 in case of success or -1 on failure
811
 */
812
int
813
brSetEnableSTP(brControl *ctl ATTRIBUTE_UNUSED,
814 815 816
               const char *bridge,
               int enable)
{
817 818 819 820
    const char *setting = enable ? "on" : "off";
    const char *const progargv[] = {
        BRCTL, "stp", bridge, setting, NULL
    };
821

822
    if (virRun(progargv, NULL) < 0)
823
        return -1;
824

825
    return 0;
826 827
}

828
#endif /* WITH_BRIDGE */