bridge.c 18.7 KB
Newer Older
1
/*
J
Jim Meyering 已提交
2
 * Copyright (C) 2007, 2009 Red Hat, Inc.
3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
 *
 * Authors:
 *     Mark McLoughlin <markmc@redhat.com>
 */

#include <config.h>

24
#if defined(WITH_BRIDGE)
25

26
# include "bridge.h"
27
# include "files.h"
28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48

# include <stdlib.h>
# include <stdio.h>
# include <string.h>
# include <unistd.h>
# include <fcntl.h>
# include <errno.h>
# include <arpa/inet.h>
# include <sys/types.h>
# include <sys/socket.h>
# include <sys/ioctl.h>
# include <paths.h>
# include <sys/wait.h>

# include <linux/param.h>     /* HZ                 */
# include <linux/sockios.h>   /* SIOCBRADDBR etc.   */
# include <linux/if_bridge.h> /* SYSFS_BRIDGE_ATTR  */
# include <linux/if_tun.h>    /* IFF_TUN, IFF_NO_PI */
# include <net/if_arp.h>    /* ARPHRD_ETHER */

# include "internal.h"
49
# include "command.h"
50 51 52
# include "memory.h"
# include "util.h"
# include "logging.h"
53
# include "network.h"
54 55 56

# define JIFFIES_TO_MS(j) (((j)*1000)/HZ)
# define MS_TO_JIFFIES(ms) (((ms)*HZ)/1000)
57 58 59 60 61

struct _brControl {
    int fd;
};

62 63 64 65 66 67 68 69 70
/**
 * brInit:
 * @ctlp: pointer to bridge control return value
 *
 * Initialize a new bridge layer. In case of success
 * @ctlp will contain a pointer to the new bridge structure.
 *
 * Returns 0 in case of success, an error code otherwise.
 */
71 72 73 74
int
brInit(brControl **ctlp)
{
    int fd;
75
    int flags;
76 77 78 79 80 81 82 83

    if (!ctlp || *ctlp)
        return EINVAL;

    fd = socket(AF_INET, SOCK_STREAM, 0);
    if (fd < 0)
        return errno;

84 85 86
    if ((flags = fcntl(fd, F_GETFD)) < 0 ||
        fcntl(fd, F_SETFD, flags | FD_CLOEXEC) < 0) {
        int err = errno;
87
        VIR_FORCE_CLOSE(fd);
88 89 90
        return err;
    }

91
    if (VIR_ALLOC(*ctlp) < 0) {
92
        VIR_FORCE_CLOSE(fd);
93
        return ENOMEM;
94
    }
95 96 97 98 99 100

    (*ctlp)->fd = fd;

    return 0;
}

101 102 103 104 105 106
/**
 * brShutdown:
 * @ctl: pointer to a bridge control
 *
 * Shutdown the bridge layer and deallocate the associated structures
 */
107 108 109 110 111 112
void
brShutdown(brControl *ctl)
{
    if (!ctl)
        return;

113
    VIR_FORCE_CLOSE(ctl->fd);
114

115
    VIR_FREE(ctl);
116 117
}

118 119 120
/**
 * brAddBridge:
 * @ctl: bridge control pointer
121
 * @name: the bridge name
122
 *
123
 * This function register a new bridge
124 125 126
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
127
# ifdef SIOCBRADDBR
128 129
int
brAddBridge(brControl *ctl,
130
            const char *name)
131
{
132
    if (!ctl || !ctl->fd || !name)
133 134
        return EINVAL;

135 136
    if (ioctl(ctl->fd, SIOCBRADDBR, name) == 0)
        return 0;
137 138 139

    return errno;
}
140
# else
141
int brAddBridge (brControl *ctl ATTRIBUTE_UNUSED,
142
                 const char *name ATTRIBUTE_UNUSED)
143 144 145
{
    return EINVAL;
}
146
# endif
147

148
# ifdef SIOCBRDELBR
149 150 151 152 153 154 155 156 157 158 159
int
brHasBridge(brControl *ctl,
            const char *name)
{
    struct ifreq ifr;

    if (!ctl || !name) {
        errno = EINVAL;
        return -1;
    }

C
Chris Lalancette 已提交
160 161 162
    memset(&ifr, 0, sizeof(struct ifreq));

    if (virStrcpyStatic(ifr.ifr_name, name) == NULL) {
163 164 165 166 167 168 169 170 171
        errno = EINVAL;
        return -1;
    }

    if (ioctl(ctl->fd, SIOCGIFFLAGS, &ifr))
        return -1;

    return 0;
}
172
# else
173
int
174 175
brHasBridge(brControl *ctl ATTRIBUTE_UNUSED,
            const char *name ATTRIBUTE_UNUSED)
176 177 178
{
    return EINVAL;
}
179
# endif
180

181 182 183 184 185 186 187 188 189
/**
 * brDeleteBridge:
 * @ctl: bridge control pointer
 * @name: the bridge name
 *
 * Remove a bridge from the layer.
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
190
# ifdef SIOCBRDELBR
191 192 193 194 195 196 197 198 199
int
brDeleteBridge(brControl *ctl,
               const char *name)
{
    if (!ctl || !ctl->fd || !name)
        return EINVAL;

    return ioctl(ctl->fd, SIOCBRDELBR, name) == 0 ? 0 : errno;
}
200
# else
201 202 203 204 205 206
int
brDeleteBridge(brControl *ctl ATTRIBUTE_UNUSED,
               const char *name ATTRIBUTE_UNUSED)
{
    return EINVAL;
}
207
# endif
208

209
# if defined(SIOCBRADDIF) && defined(SIOCBRDELIF)
210 211 212 213 214 215 216 217 218 219 220 221 222
static int
brAddDelInterface(brControl *ctl,
                  int cmd,
                  const char *bridge,
                  const char *iface)
{
    struct ifreq ifr;

    if (!ctl || !ctl->fd || !bridge || !iface)
        return EINVAL;

    memset(&ifr, 0, sizeof(struct ifreq));

C
Chris Lalancette 已提交
223 224
    if (virStrcpyStatic(ifr.ifr_name, bridge) == NULL)
        return EINVAL;
225 226 227 228 229 230

    if (!(ifr.ifr_ifindex = if_nametoindex(iface)))
        return ENODEV;

    return ioctl(ctl->fd, cmd, &ifr) == 0 ? 0 : errno;
}
231
# endif
232

233 234 235 236 237
/**
 * brAddInterface:
 * @ctl: bridge control pointer
 * @bridge: the bridge name
 * @iface: the network interface name
238
 *
239 240 241 242
 * Adds an interface to a bridge
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
243
# ifdef SIOCBRADDIF
244 245 246 247 248 249 250
int
brAddInterface(brControl *ctl,
               const char *bridge,
               const char *iface)
{
    return brAddDelInterface(ctl, SIOCBRADDIF, bridge, iface);
}
251
# else
252 253 254 255 256 257 258
int
brAddInterface(brControl *ctl ATTRIBUTE_UNUSED,
               const char *bridge ATTRIBUTE_UNUSED,
               const char *iface ATTRIBUTE_UNUSED)
{
    return EINVAL;
}
259
# endif
260

261 262 263 264 265
/**
 * brDeleteInterface:
 * @ctl: bridge control pointer
 * @bridge: the bridge name
 * @iface: the network interface name
266
 *
267 268 269 270
 * Removes an interface from a bridge
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
271
# ifdef SIOCBRDELIF
272 273 274 275 276 277 278
int
brDeleteInterface(brControl *ctl,
                  const char *bridge,
                  const char *iface)
{
    return brAddDelInterface(ctl, SIOCBRDELIF, bridge, iface);
}
279
# else
280 281 282 283 284 285 286
int
brDeleteInterface(brControl *ctl ATTRIBUTE_UNUSED,
                  const char *bridge ATTRIBUTE_UNUSED,
                  const char *iface ATTRIBUTE_UNUSED)
{
    return EINVAL;
}
287
# endif
288

289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320
/**
 * ifSetInterfaceMac:
 * @ctl: bridge control pointer
 * @ifname: interface name to set MTU for
 * @macaddr: MAC address (VIR_MAC_BUFLEN in size)
 *
 * This function sets the @macaddr for a given interface @ifname. This
 * gets rid of the kernel's automatically assigned random MAC.
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
static int ifSetInterfaceMac(brControl *ctl, const char *ifname,
                             const unsigned char *macaddr)
{
    struct ifreq ifr;

    if (!ctl || !ifname)
        return EINVAL;

    memset(&ifr, 0, sizeof(struct ifreq));
    if (virStrcpyStatic(ifr.ifr_name, ifname) == NULL)
        return EINVAL;

    /* To fill ifr.ifr_hdaddr.sa_family field */
    if (ioctl(ctl->fd, SIOCGIFHWADDR, &ifr) != 0)
        return errno;

    memcpy(ifr.ifr_hwaddr.sa_data, macaddr, VIR_MAC_BUFLEN);

    return ioctl(ctl->fd, SIOCSIFHWADDR, &ifr) == 0 ? 0 : errno;
}

321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339
/**
 * ifGetMtu
 * @ctl: bridge control pointer
 * @ifname: interface name get MTU for
 *
 * This function gets the @mtu value set for a given interface @ifname.
 *
 * Returns the MTU value in case of success.
 * On error, returns -1 and sets errno accordingly
 */
static int ifGetMtu(brControl *ctl, const char *ifname)
{
    struct ifreq ifr;

    if (!ctl || !ifname) {
        errno = EINVAL;
        return -1;
    }

C
Chris Lalancette 已提交
340 341 342
    memset(&ifr, 0, sizeof(struct ifreq));

    if (virStrcpyStatic(ifr.ifr_name, ifname) == NULL) {
343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373
        errno = EINVAL;
        return -1;
    }

    if (ioctl(ctl->fd, SIOCGIFMTU, &ifr))
        return -1;

    return ifr.ifr_mtu;

}

/**
 * ifSetMtu:
 * @ctl: bridge control pointer
 * @ifname: interface name to set MTU for
 * @mtu: MTU value
 *
 * This function sets the @mtu for a given interface @ifname.  Typically
 * used on a tap device to set up for Jumbo Frames.
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
static int ifSetMtu(brControl *ctl, const char *ifname, int mtu)
{
    struct ifreq ifr;

    if (!ctl || !ifname)
        return EINVAL;

    memset(&ifr, 0, sizeof(struct ifreq));

C
Chris Lalancette 已提交
374 375
    if (virStrcpyStatic(ifr.ifr_name, ifname) == NULL)
        return EINVAL;
376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402
    ifr.ifr_mtu = mtu;

    return ioctl(ctl->fd, SIOCSIFMTU, &ifr) == 0 ? 0 : errno;
}

/**
 * brSetInterfaceMtu
 * @ctl: bridge control pointer
 * @bridge: name of the bridge interface
 * @ifname: name of the interface whose MTU we want to set
 *
 * Sets the interface mtu to the same MTU of the bridge
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
static int brSetInterfaceMtu(brControl *ctl,
                             const char *bridge,
                             const char *ifname)
{
    int mtu = ifGetMtu(ctl, bridge);

    if (mtu < 0)
        return errno;

    return ifSetMtu(ctl, ifname, mtu);
}

403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421
/**
 * brProbeVnetHdr:
 * @tapfd: a tun/tap file descriptor
 *
 * Check whether it is safe to enable the IFF_VNET_HDR flag on the
 * tap interface.
 *
 * Setting IFF_VNET_HDR enables QEMU's virtio_net driver to allow
 * guests to pass larger (GSO) packets, with partial checksums, to
 * the host. This greatly increases the achievable throughput.
 *
 * It is only useful to enable this when we're setting up a virtio
 * interface. And it is only *safe* to enable it when we know for
 * sure that a) qemu has support for IFF_VNET_HDR and b) the running
 * kernel implements the TUNGETIFF ioctl(), which qemu needs to query
 * the supplied tapfd.
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
422
# ifdef IFF_VNET_HDR
423 424 425
static int
brProbeVnetHdr(int tapfd)
{
426
#  if defined(IFF_VNET_HDR) && defined(TUNGETFEATURES) && defined(TUNGETIFF)
427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453
    unsigned int features;
    struct ifreq dummy;

    if (ioctl(tapfd, TUNGETFEATURES, &features) != 0) {
        VIR_INFO0(_("Not enabling IFF_VNET_HDR; "
                    "TUNGETFEATURES ioctl() not implemented"));
        return 0;
    }

    if (!(features & IFF_VNET_HDR)) {
        VIR_INFO0(_("Not enabling IFF_VNET_HDR; "
                    "TUNGETFEATURES ioctl() reports no IFF_VNET_HDR"));
        return 0;
    }

    /* The kernel will always return -1 at this point.
     * If TUNGETIFF is not implemented then errno == EBADFD.
     */
    if (ioctl(tapfd, TUNGETIFF, &dummy) != -1 || errno != EBADFD) {
        VIR_INFO0(_("Not enabling IFF_VNET_HDR; "
                    "TUNGETIFF ioctl() not implemented"));
        return 0;
    }

    VIR_INFO0(_("Enabling IFF_VNET_HDR"));

    return 1;
454
#  else
455
    (void) tapfd;
456 457
    VIR_INFO0(_("Not enabling IFF_VNET_HDR; disabled at build time"));
    return 0;
458
#  endif
459
}
460
# endif
461

462 463 464 465 466
/**
 * brAddTap:
 * @ctl: bridge control pointer
 * @bridge: the bridge name
 * @ifname: the interface name (or name template)
467
 * @macaddr: desired MAC address (VIR_MAC_BUFLEN long)
468
 * @vnet_hdr: whether to try enabling IFF_VNET_HDR
469 470
 * @tapfd: file descriptor return value for the new tap device
 *
D
typo  
Daniel Veillard 已提交
471
 * This function creates a new tap device on a bridge. @ifname can be either
472
 * a fixed name or a name template with '%d' for dynamic name allocation.
473 474 475 476 477
 * in either case the final name for the bridge will be stored in @ifname.
 * If the @tapfd parameter is supplied, the open tap device file
 * descriptor will be returned, otherwise the TAP device will be made
 * persistent and closed. The caller must use brDeleteTap to remove
 * a persistent TAP devices when it is no longer needed.
478 479 480
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
481 482 483
int
brAddTap(brControl *ctl,
         const char *bridge,
484
         char **ifname,
485
         const unsigned char *macaddr,
486
         int vnet_hdr,
487 488
         int *tapfd)
{
C
Chris Lalancette 已提交
489
    int fd;
490
    struct ifreq ifr;
491

492
    if (!ctl || !ctl->fd || !bridge || !ifname)
493 494 495 496 497
        return EINVAL;

    if ((fd = open("/dev/net/tun", O_RDWR)) < 0)
      return errno;

498 499
    memset(&ifr, 0, sizeof(ifr));

500
    ifr.ifr_flags = IFF_TAP|IFF_NO_PI;
501

502
# ifdef IFF_VNET_HDR
503 504
    if (vnet_hdr && brProbeVnetHdr(fd))
        ifr.ifr_flags |= IFF_VNET_HDR;
505
# else
506
    (void) vnet_hdr;
507
# endif
508

C
Chris Lalancette 已提交
509
    if (virStrcpyStatic(ifr.ifr_name, *ifname) == NULL) {
510 511 512
        errno = EINVAL;
        goto error;
    }
513

C
Chris Lalancette 已提交
514 515 516
    if (ioctl(fd, TUNSETIFF, &ifr) < 0)
        goto error;

517 518 519 520 521 522 523 524
    /* We need to set the interface MAC before adding it
     * to the bridge, because the bridge assumes the lowest
     * MAC of all enslaved interfaces & we don't want it
     * seeing the kernel allocate random MAC for the TAP
     * device before we set our static MAC.
     */
    if ((errno = ifSetInterfaceMac(ctl, ifr.ifr_name, macaddr)))
        goto error;
525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542
    /* We need to set the interface MTU before adding it
     * to the bridge, because the bridge will have its
     * MTU adjusted automatically when we add the new interface.
     */
    if ((errno = brSetInterfaceMtu(ctl, bridge, ifr.ifr_name)))
        goto error;
    if ((errno = brAddInterface(ctl, bridge, ifr.ifr_name)))
        goto error;
    if ((errno = brSetInterfaceUp(ctl, ifr.ifr_name, 1)))
        goto error;
    if (!tapfd &&
        (errno = ioctl(fd, TUNSETPERSIST, 1)))
        goto error;
    VIR_FREE(*ifname);
    if (!(*ifname = strdup(ifr.ifr_name)))
        goto error;
    if (tapfd)
        *tapfd = fd;
543
    else
544
        VIR_FORCE_CLOSE(fd);
545
    return 0;
546 547

 error:
548
    VIR_FORCE_CLOSE(fd);
549 550 551 552

    return errno;
}

553 554 555 556 557 558 559 560 561 562 563 564 565 566 567
int brDeleteTap(brControl *ctl,
                const char *ifname)
{
    struct ifreq try;
    int fd;

    if (!ctl || !ctl->fd || !ifname)
        return EINVAL;

    if ((fd = open("/dev/net/tun", O_RDWR)) < 0)
        return errno;

    memset(&try, 0, sizeof(struct ifreq));
    try.ifr_flags = IFF_TAP|IFF_NO_PI;

C
Chris Lalancette 已提交
568
    if (virStrcpyStatic(try.ifr_name, ifname) == NULL) {
569 570 571 572 573 574 575 576 577 578
        errno = EINVAL;
        goto error;
    }

    if (ioctl(fd, TUNSETIFF, &try) == 0) {
        if ((errno = ioctl(fd, TUNSETPERSIST, 0)))
            goto error;
    }

 error:
579
    VIR_FORCE_CLOSE(fd);
580 581 582 583 584

    return errno;
}


585 586 587 588 589 590 591 592 593 594
/**
 * brSetInterfaceUp:
 * @ctl: bridge control pointer
 * @ifname: the interface name
 * @up: 1 for up, 0 for down
 *
 * Function to control if an interface is activated (up, 1) or not (down, 0)
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
595 596 597 598 599 600 601 602 603 604 605 606 607
int
brSetInterfaceUp(brControl *ctl,
                 const char *ifname,
                 int up)
{
    struct ifreq ifr;
    int flags;

    if (!ctl || !ifname)
        return EINVAL;

    memset(&ifr, 0, sizeof(struct ifreq));

C
Chris Lalancette 已提交
608 609
    if (virStrcpyStatic(ifr.ifr_name, ifname) == NULL)
        return EINVAL;
610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625

    if (ioctl(ctl->fd, SIOCGIFFLAGS, &ifr) < 0)
        return errno;

    flags = up ? (ifr.ifr_flags | IFF_UP) : (ifr.ifr_flags & ~IFF_UP);

    if (ifr.ifr_flags != flags) {
        ifr.ifr_flags = flags;

        if (ioctl(ctl->fd, SIOCSIFFLAGS, &ifr) < 0)
            return errno;
    }

    return 0;
}

626 627 628 629 630 631 632 633 634 635
/**
 * brGetInterfaceUp:
 * @ctl: bridge control pointer
 * @ifname: the interface name
 * @up: where to store the status
 *
 * Function to query if an interface is activated (1) or not (0)
 *
 * Returns 0 in case of success or an errno code in case of failure.
 */
636 637 638 639 640 641 642
int
brGetInterfaceUp(brControl *ctl,
                 const char *ifname,
                 int *up)
{
    struct ifreq ifr;

643
    if (!ctl || !ifname || !up)
644 645 646 647
        return EINVAL;

    memset(&ifr, 0, sizeof(struct ifreq));

C
Chris Lalancette 已提交
648 649
    if (virStrcpyStatic(ifr.ifr_name, ifname) == NULL)
        return EINVAL;
650 651 652 653 654 655 656 657 658

    if (ioctl(ctl->fd, SIOCGIFFLAGS, &ifr) < 0)
        return errno;

    *up = (ifr.ifr_flags & IFF_UP) ? 1 : 0;

    return 0;
}

659
/**
660
 * brAddInetAddress:
661 662
 * @ctl: bridge control pointer
 * @ifname: the interface name
663 664
 * @addr: the IP address (IPv4 or IPv6)
 * @prefix: number of 1 bits in the netmask
665
 *
666 667 668
 * Add an IP address to an interface. This function *does not* remove
 * any previously added IP addresses - that must be done separately with
 * brDelInetAddress.
669
 *
670
 * Returns 0 in case of success or -1 in case of error.
671 672
 */

673
int
674
brAddInetAddress(brControl *ctl ATTRIBUTE_UNUSED,
675
                 const char *ifname,
676 677
                 virSocketAddr *addr,
                 unsigned int prefix)
678
{
679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697
    virCommandPtr cmd;
    char *addrstr;
    int ret = -1;

    if (!(addrstr = virSocketFormatAddr(addr)))
        goto cleanup;
    cmd = virCommandNew(IP_PATH);
    virCommandAddArgList(cmd, "addr", "add", NULL);
    virCommandAddArgFormat(cmd, "%s/%u", addrstr, prefix);
    virCommandAddArgList(cmd, "dev", ifname, NULL);

    if (virCommandRun(cmd, NULL) < 0)
        goto cleanup;

    ret = 0;
cleanup:
    VIR_FREE(addrstr);
    virCommandFree(cmd);
    return ret;
698 699
}

700
/**
701
 * brDelInetAddress:
702 703
 * @ctl: bridge control pointer
 * @ifname: the interface name
704 705
 * @addr: the IP address (IPv4 or IPv6)
 * @prefix: number of 1 bits in the netmask
706
 *
707
 * Delete an IP address from an interface.
708
 *
709
 * Returns 0 in case of success or -1 in case of error.
710 711
 */

712
int
713
brDelInetAddress(brControl *ctl ATTRIBUTE_UNUSED,
714
                 const char *ifname,
715 716
                 virSocketAddr *addr,
                 unsigned int prefix)
717
{
718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736
    virCommandPtr cmd;
    char *addrstr;
    int ret = -1;

    if (!(addrstr = virSocketFormatAddr(addr)))
        goto cleanup;
    cmd = virCommandNew(IP_PATH);
    virCommandAddArgList(cmd, "addr", "del", NULL);
    virCommandAddArgFormat(cmd, "%s/%u", addrstr, prefix);
    virCommandAddArgList(cmd, "dev", ifname, NULL);

    if (virCommandRun(cmd, NULL) < 0)
        goto cleanup;

    ret = 0;
cleanup:
    VIR_FREE(addrstr);
    virCommandFree(cmd);
    return ret;
737 738
}

739 740 741 742 743 744 745 746
/**
 * brSetForwardDelay:
 * @ctl: bridge control pointer
 * @bridge: the bridge name
 * @delay: delay in seconds
 *
 * Set the bridge forward delay
 *
747
 * Returns 0 in case of success or -1 on failure
748
 */
749

750
int
751
brSetForwardDelay(brControl *ctl ATTRIBUTE_UNUSED,
752 753 754
                  const char *bridge,
                  int delay)
{
755 756
    virCommandPtr cmd;
    int ret = -1;
757

758 759 760
    cmd = virCommandNew(BRCTL);
    virCommandAddArgList(cmd, "setfd", bridge, NULL);
    virCommandAddArgFormat(cmd, "%d", delay);
761

762 763
    if (virCommandRun(cmd, NULL) < 0)
        goto cleanup;
764

765 766 767 768
    ret = 0;
cleanup:
    virCommandFree(cmd);
    return ret;
769 770
}

771 772 773 774 775 776 777 778 779
/**
 * brSetEnableSTP:
 * @ctl: bridge control pointer
 * @bridge: the bridge name
 * @enable: 1 to enable, 0 to disable
 *
 * Control whether the bridge participates in the spanning tree protocol,
 * in general don't disable it without good reasons.
 *
780
 * Returns 0 in case of success or -1 on failure
781
 */
782
int
783
brSetEnableSTP(brControl *ctl ATTRIBUTE_UNUSED,
784 785 786
               const char *bridge,
               int enable)
{
787 788
    virCommandPtr cmd;
    int ret = -1;
789

790 791 792 793
    cmd = virCommandNew(BRCTL);
    virCommandAddArgList(cmd, "stp", bridge,
                         enable ? "on" : "off",
                         NULL);
794

795 796 797 798 799 800 801
    if (virCommandRun(cmd, NULL) < 0)
        goto cleanup;

    ret = 0;
cleanup:
    virCommandFree(cmd);
    return ret;
802 803
}

804
#endif /* WITH_BRIDGE */