vircommand.c 83.4 KB
Newer Older
1
/*
2
 * vircommand.c: Child command execution
3
 *
4
 * Copyright (C) 2010-2014 Red Hat, Inc.
5 6 7 8 9 10 11 12 13 14 15 16
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
17
 * License along with this library.  If not, see
O
Osier Yang 已提交
18
 * <http://www.gnu.org/licenses/>.
19 20 21 22 23 24
 *
 */

#include <config.h>

#include <poll.h>
25
#include <regex.h>
26
#include <signal.h>
27 28
#include <stdarg.h>
#include <stdlib.h>
29
#include <sys/stat.h>
30
#include <sys/wait.h>
31 32
#include <fcntl.h>

33
#if WITH_CAPNG
34 35
# include <cap-ng.h>
#endif
36

37 38 39 40 41 42 43
#if defined(WITH_SECDRIVER_SELINUX)
# include <selinux/selinux.h>
#endif
#if defined(WITH_SECDRIVER_APPARMOR)
# include <sys/apparmor.h>
#endif

44 45
#define __VIR_COMMAND_PRIV_H_ALLOW__
#include "vircommandpriv.h"
46
#include "viralloc.h"
47
#include "virerror.h"
48
#include "virutil.h"
49
#include "virlog.h"
E
Eric Blake 已提交
50
#include "virfile.h"
51
#include "virpidfile.h"
52
#include "virprocess.h"
53
#include "virbuffer.h"
54
#include "virthread.h"
55
#include "virstring.h"
56

57 58
#define VIR_FROM_THIS VIR_FROM_NONE

59 60
VIR_LOG_INIT("util.command");

61
/* Flags for virExec */
62
enum {
63 64 65
    VIR_EXEC_NONE       = 0,
    VIR_EXEC_NONBLOCK   = (1 << 0),
    VIR_EXEC_DAEMON     = (1 << 1),
66
    VIR_EXEC_CLEAR_CAPS = (1 << 2),
67 68
    VIR_EXEC_RUN_SYNC   = (1 << 3),
    VIR_EXEC_ASYNC_IO   = (1 << 4),
69
    VIR_EXEC_LISTEN_FDS = (1 << 5),
70 71
};

72 73 74 75 76 77 78 79
typedef struct _virCommandFD virCommandFD;
typedef virCommandFD *virCommandFDPtr;

struct _virCommandFD {
    int fd;
    unsigned int flags;
};

80 81 82 83 84 85 86 87 88 89 90 91 92
struct _virCommand {
    int has_error; /* ENOMEM on allocation failure, -1 for anything else.  */

    char **args;
    size_t nargs;
    size_t maxargs;

    char **env;
    size_t nenv;
    size_t maxenv;

    char *pwd;

93 94
    size_t npassfd;
    virCommandFDPtr passfd;
95 96 97 98 99 100 101 102

    unsigned int flags;

    char *inbuf;
    char **outbuf;
    char **errbuf;

    int infd;
103
    int inpipe;
104 105 106 107 108
    int outfd;
    int errfd;
    int *outfdptr;
    int *errfdptr;

109
    virThreadPtr asyncioThread;
110

111 112 113 114
    bool handshake;
    int handshakeWait[2];
    int handshakeNotify[2];

115 116 117 118 119
    virExecHook hook;
    void *opaque;

    pid_t pid;
    char *pidfile;
120
    bool reap;
121
    bool rawStatus;
122

123 124 125 126
    unsigned long long maxMemLock;
    unsigned int maxProcesses;
    unsigned int maxFiles;

127 128
    uid_t uid;
    gid_t gid;
129
    unsigned long long capabilities;
130 131 132 133 134 135
#if defined(WITH_SECDRIVER_SELINUX)
    char *seLinuxLabel;
#endif
#if defined(WITH_SECDRIVER_APPARMOR)
    char *appArmorProfile;
#endif
136
    int mask;
137 138
};

139 140
/* See virCommandSetDryRun for description for this variable */
static virBufferPtr dryRunBuffer;
141 142 143
static virCommandDryRunCallback dryRunCallback;
static void *dryRunOpaque;
static int dryRunStatus;
144

145 146 147 148 149 150 151 152 153 154 155 156
/*
 * virCommandFDIsSet:
 * @fd: FD to test
 * @set: the set
 * @set_size: actual size of @set
 *
 * Check if FD is already in @set or not.
 *
 * Returns true if @set contains @fd,
 * false otherwise.
 */
static bool
157 158
virCommandFDIsSet(virCommandPtr cmd,
                  int fd)
159
{
160
    size_t i = 0;
161 162
    if (!cmd)
        return false;
163

164 165
    while (i < cmd->npassfd)
        if (cmd->passfd[i++].fd == fd)
166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185
            return true;

    return false;
}

/*
 * virCommandFDSet:
 * @fd: FD to be put into @set
 * @set: the set
 * @set_size: actual size of @set
 *
 * This is practically generalized implementation
 * of FD_SET() as we do not want to be limited
 * by FD_SETSIZE.
 *
 * Returns: 0 on success,
 *          -1 on usage error,
 *          ENOMEM on OOM
 */
static int
186 187 188
virCommandFDSet(virCommandPtr cmd,
                int fd,
                unsigned int flags)
189
{
190
    if (!cmd || fd < 0)
191 192
        return -1;

193
    if (virCommandFDIsSet(cmd, fd))
194 195
        return 0;

196
    if (VIR_EXPAND_N(cmd->passfd, cmd->npassfd, 1) < 0)
197 198
        return ENOMEM;

199 200
    cmd->passfd[cmd->npassfd - 1].fd = fd;
    cmd->passfd[cmd->npassfd - 1].flags = flags;
201 202 203

    return 0;
}
204

205 206
#ifndef WIN32

207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278
static void
virCommandReorderFDs(virCommandPtr cmd)
{
    int maxfd = 0;
    int openmax = 0;
    size_t i = 0;

    if (!cmd || cmd->has_error || !cmd->npassfd)
        return;

    for (i = 0; i < cmd->npassfd; i++)
        maxfd = MAX(cmd->passfd[i].fd, maxfd);

    openmax = sysconf(_SC_OPEN_MAX);
    if (openmax < 0 ||
        maxfd + cmd->npassfd > openmax)
        goto error;

    /*
     * Simple two-pass sort, nothing fancy.  This is not designed for
     * anything else than passing around 2 FDs into the child.
     *
     * So first dup2() them somewhere else.
     */
    for (i = 0; i < cmd->npassfd; i++) {
        int newfd = maxfd + i + 1;
        int oldfd = cmd->passfd[i].fd;
        if (dup2(oldfd, newfd) != newfd) {
            virReportSystemError(errno,
                                 _("Cannot dup2() fd %d before "
                                   "passing it to the child"),
                                 oldfd);
            goto error;
        }
        VIR_FORCE_CLOSE(cmd->passfd[i].fd);
    }

    VIR_DEBUG("First reorder pass done");

    /*
     * And then dup2() them in orderly manner.
     */
    for (i = 0; i < cmd->npassfd; i++) {
        int newfd = STDERR_FILENO + i + 1;
        int oldfd = maxfd + i + 1;
        if (dup2(oldfd, newfd) != newfd) {
            virReportSystemError(errno,
                                 _("Cannot dup2() fd %d before "
                                   "passing it to the child"),
                                 oldfd);
            goto error;
        }
        if (virSetInherit(newfd, true) < 0) {
            virReportSystemError(errno,
                                 _("Cannot set O_CLOEXEC on fd %d before "
                                   "passing it to the child"),
                                 newfd);
            goto error;
        }
        VIR_FORCE_CLOSE(oldfd);
        cmd->passfd[i].fd = newfd;
    }

    VIR_DEBUG("Second reorder pass done");

    return;

 error:
    cmd->has_error = -1;
    return;
}

E
Eric Blake 已提交
279 280 281
/**
 * virFork:
 *
282
 * Wrapper around fork() that avoids various race/deadlock conditions.
E
Eric Blake 已提交
283
 *
E
Eric Blake 已提交
284 285 286 287 288 289 290 291 292 293 294
 * Like fork(), there are several return possibilities:
 * 1. No child was created: the return is -1, errno is set, and an error
 * message has been reported.  The semantics of virWaitProcess() recognize
 * this to avoid clobbering the error message from here.
 * 2. This is the parent: the return is > 0.  The parent can now attempt
 * to interact with the child (but be aware that unlike raw fork(), the
 * child may not return - some failures in the child result in this
 * function calling _exit(EXIT_CANCELED) if the child cannot be set up
 * correctly).
 * 3. This is the child: the return is 0.  If this happens, the parent
 * is also guaranteed to return.
295
 */
E
Eric Blake 已提交
296 297
pid_t
virFork(void)
E
Eric Blake 已提交
298
{
299 300
    sigset_t oldmask, newmask;
    struct sigaction sig_action;
E
Eric Blake 已提交
301 302
    int saved_errno;
    pid_t pid;
303 304 305 306 307 308 309 310 311

    /*
     * Need to block signals now, so that child process can safely
     * kill off caller's signal handlers without a race.
     */
    sigfillset(&newmask);
    if (pthread_sigmask(SIG_SETMASK, &newmask, &oldmask) != 0) {
        virReportSystemError(errno,
                             "%s", _("cannot block signals"));
E
Eric Blake 已提交
312
        return -1;
313 314 315 316 317 318
    }

    /* Ensure we hold the logging lock, to protect child processes
     * from deadlocking on another thread's inherited mutex state */
    virLogLock();

E
Eric Blake 已提交
319
    pid = fork();
320 321 322 323 324
    saved_errno = errno; /* save for caller */

    /* Unlock for both parent and child process */
    virLogUnlock();

E
Eric Blake 已提交
325
    if (pid < 0) {
326
        /* attempt to restore signal mask, but ignore failure, to
E
Eric Blake 已提交
327
         * avoid obscuring the fork failure */
328
        ignore_value(pthread_sigmask(SIG_SETMASK, &oldmask, NULL));
329 330
        virReportSystemError(saved_errno,
                             "%s", _("cannot fork child process"));
E
Eric Blake 已提交
331
        errno = saved_errno;
332

E
Eric Blake 已提交
333
    } else if (pid) {
334 335 336
        /* parent process */

        /* Restore our original signal mask now that the child is
E
Eric Blake 已提交
337 338 339 340
         * safely running. Only documented failures are EFAULT (not
         * possible, since we are using just-grabbed mask) or EINVAL
         * (not possible, since we are using correct arguments).  */
        ignore_value(pthread_sigmask(SIG_SETMASK, &oldmask, NULL));
341 342 343 344 345

    } else {
        /* child process */

        int logprio;
346
        size_t i;
347

E
Eric Blake 已提交
348 349 350
        /* Remove any error callback so errors in child now get sent
         * to stderr where they stand a fighting chance of being seen
         * and logged */
351 352 353 354 355 356 357 358 359 360
        virSetErrorFunc(NULL, NULL);
        virSetErrorLogPriorityFunc(NULL);

        /* Make sure any hook logging is sent to stderr, since child
         * process may close the logfile FDs */
        logprio = virLogGetDefaultPriority();
        virLogReset();
        virLogSetDefaultPriority(logprio);

        /* Clear out all signal handlers from parent so nothing
E
Eric Blake 已提交
361 362
         * unexpected can happen in our child once we unblock
         * signals */
363 364 365 366 367
        sig_action.sa_handler = SIG_DFL;
        sig_action.sa_flags = 0;
        sigemptyset(&sig_action.sa_mask);

        for (i = 1; i < NSIG; i++) {
E
Eric Blake 已提交
368 369 370 371
            /* Only possible errors are EFAULT or EINVAL The former
             * won't happen, the latter we expect, so no need to check
             * return value */
            ignore_value(sigaction(i, &sig_action, NULL));
372 373
        }

E
Eric Blake 已提交
374 375 376
        /* Unmask all signals in child, since we've no idea what the
         * caller's done with their signal mask and don't want to
         * propagate that to children */
377 378 379
        sigemptyset(&newmask);
        if (pthread_sigmask(SIG_SETMASK, &newmask, NULL) != 0) {
            virReportSystemError(errno, "%s", _("cannot unblock signals"));
380 381
            virDispatchError(NULL);
            _exit(EXIT_CANCELED);
382 383
        }
    }
E
Eric Blake 已提交
384
    return pid;
385 386
}

E
Eric Blake 已提交
387 388 389 390 391 392 393 394
/*
 * Ensure that *null is an fd visiting /dev/null.  Return 0 on
 * success, -1 on failure.  Allows for lazy opening of shared
 * /dev/null fd only as required.
 */
static int
getDevNull(int *null)
{
395
    if (*null == -1 && (*null = open("/dev/null", O_RDWR|O_CLOEXEC)) < 0) {
E
Eric Blake 已提交
396 397 398 399 400 401 402 403
        virReportSystemError(errno,
                             _("cannot open %s"),
                             "/dev/null");
        return -1;
    }
    return 0;
}

404 405 406 407 408 409 410 411 412 413 414 415
/* Ensure that STD is an inheritable copy of FD.  Return 0 on success,
 * -1 on failure.  */
static int
prepareStdFd(int fd, int std)
{
    if (fd == std)
        return virSetInherit(fd, true);
    if (dup2(fd, std) != std)
        return -1;
    return 0;
}

416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463
/* virCommandHandshakeChild:
 *
 *   child side of handshake - called by child process in virExec() to
 *   indicate to parent that the child process has successfully
 *   completed its pre-exec initialization.
 */
static int
virCommandHandshakeChild(virCommandPtr cmd)
{
    char c = '1';
    int rv;

    if (!cmd->handshake)
       return true;

    VIR_DEBUG("Notifying parent for handshake start on %d",
              cmd->handshakeWait[1]);
    if (safewrite(cmd->handshakeWait[1], &c, sizeof(c)) != sizeof(c)) {
        virReportSystemError(errno, "%s",
                             _("Unable to notify parent process"));
        return -1;
    }

    VIR_DEBUG("Waiting on parent for handshake complete on %d",
              cmd->handshakeNotify[0]);
    if ((rv = saferead(cmd->handshakeNotify[0], &c,
                       sizeof(c))) != sizeof(c)) {
        if (rv < 0)
            virReportSystemError(errno, "%s",
                                 _("Unable to wait on parent process"));
        else
            virReportSystemError(EIO, "%s",
                                 _("libvirtd quit during handshake"));
        return -1;
    }
    if (c != '1') {
        virReportSystemError(EINVAL,
                             _("Unexpected confirm code '%c' from parent"),
                             c);
        return -1;
    }
    VIR_FORCE_CLOSE(cmd->handshakeWait[1]);
    VIR_FORCE_CLOSE(cmd->handshakeNotify[0]);

    VIR_DEBUG("Handshake with parent is done");
    return 0;
}

464
/*
465 466 467
 * virExec:
 * @cmd virCommandPtr containing all information about the program to
 *      exec.
468 469
 */
static int
470
virExec(virCommandPtr cmd)
471 472
{
    pid_t pid;
473
    int null = -1, fd, openmax;
E
Eric Blake 已提交
474 475
    int pipeout[2] = {-1, -1};
    int pipeerr[2] = {-1, -1};
476
    int childin = cmd->infd;
477 478 479
    int childout = -1;
    int childerr = -1;
    int tmpfd;
480
    char *binarystr = NULL;
481
    const char *binary = NULL;
E
Eric Blake 已提交
482
    int ret;
483
    struct sigaction waxon, waxoff;
484 485
    gid_t *groups = NULL;
    int ngroups;
486

487
    if (cmd->args[0][0] != '/') {
488
        if (!(binary = binarystr = virFindFileInPath(cmd->args[0]))) {
489 490
            virReportSystemError(ENOENT,
                                 _("Cannot find '%s' in path"),
491
                                 cmd->args[0]);
492 493 494
            return -1;
        }
    } else {
495
        binary = cmd->args[0];
496 497
    }

498
    if (childin < 0) {
E
Eric Blake 已提交
499 500
        if (getDevNull(&null) < 0)
            goto cleanup;
501
        childin = null;
502 503
    }

504 505
    if (cmd->outfdptr != NULL) {
        if (*cmd->outfdptr == -1) {
506
            if (pipe2(pipeout, O_CLOEXEC) < 0) {
507 508 509 510 511
                virReportSystemError(errno,
                                     "%s", _("cannot create pipe"));
                goto cleanup;
            }

512
            if ((cmd->flags & VIR_EXEC_NONBLOCK) &&
513
                virSetNonBlock(pipeout[0]) == -1) {
514 515
                virReportSystemError(errno, "%s",
                                     _("Failed to set non-blocking file descriptor flag"));
516 517 518 519 520
                goto cleanup;
            }

            childout = pipeout[1];
        } else {
521
            childout = *cmd->outfdptr;
522 523
        }
    } else {
E
Eric Blake 已提交
524 525
        if (getDevNull(&null) < 0)
            goto cleanup;
526 527 528
        childout = null;
    }

529 530
    if (cmd->errfdptr != NULL) {
        if (cmd->errfdptr == cmd->outfdptr) {
531
            childerr = childout;
532
        } else if (*cmd->errfdptr == -1) {
533
            if (pipe2(pipeerr, O_CLOEXEC) < 0) {
534 535 536 537 538
                virReportSystemError(errno,
                                     "%s", _("Failed to create pipe"));
                goto cleanup;
            }

539
            if ((cmd->flags & VIR_EXEC_NONBLOCK) &&
540
                virSetNonBlock(pipeerr[0]) == -1) {
541 542
                virReportSystemError(errno, "%s",
                                     _("Failed to set non-blocking file descriptor flag"));
543 544 545 546 547
                goto cleanup;
            }

            childerr = pipeerr[1];
        } else {
548
            childerr = *cmd->errfdptr;
549 550
        }
    } else {
E
Eric Blake 已提交
551 552
        if (getDevNull(&null) < 0)
            goto cleanup;
553 554 555
        childerr = null;
    }

556 557 558
    if ((ngroups = virGetGroupList(cmd->uid, cmd->gid, &groups)) < 0)
        goto cleanup;

E
Eric Blake 已提交
559
    pid = virFork();
560 561 562 563 564 565 566

    if (pid < 0) {
        goto cleanup;
    }

    if (pid) { /* parent */
        VIR_FORCE_CLOSE(null);
567
        if (cmd->outfdptr && *cmd->outfdptr == -1) {
568
            VIR_FORCE_CLOSE(pipeout[1]);
569
            *cmd->outfdptr = pipeout[0];
570
        }
571
        if (cmd->errfdptr && *cmd->errfdptr == -1) {
572
            VIR_FORCE_CLOSE(pipeerr[1]);
573
            *cmd->errfdptr = pipeerr[0];
574 575
        }

576
        cmd->pid = pid;
577

578
        VIR_FREE(binarystr);
579
        VIR_FREE(groups);
580 581 582 583 584 585

        return 0;
    }

    /* child */

586 587
    if (cmd->mask)
        umask(cmd->mask);
588
    ret = EXIT_CANCELED;
589
    openmax = sysconf(_SC_OPEN_MAX);
J
John Ferlan 已提交
590 591 592 593 594
    if (openmax < 0) {
        virReportSystemError(errno,  "%s",
                             _("sysconf(_SC_OPEN_MAX) failed"));
        goto fork_error;
    }
595 596
    for (fd = 3; fd < openmax; fd++) {
        if (fd == childin || fd == childout || fd == childerr)
597
            continue;
598
        if (!virCommandFDIsSet(cmd, fd)) {
599
            tmpfd = fd;
600
            VIR_MASS_CLOSE(tmpfd);
601 602
        } else if (virSetInherit(fd, true) < 0) {
            virReportSystemError(errno, _("failed to preserve fd %d"), fd);
603
            goto fork_error;
604
        }
605
    }
606

607
    if (prepareStdFd(childin, STDIN_FILENO) < 0) {
608 609 610 611
        virReportSystemError(errno,
                             "%s", _("failed to setup stdin file handle"));
        goto fork_error;
    }
612
    if (childout > 0 && prepareStdFd(childout, STDOUT_FILENO) < 0) {
613 614 615 616
        virReportSystemError(errno,
                             "%s", _("failed to setup stdout file handle"));
        goto fork_error;
    }
617
    if (childerr > 0 && prepareStdFd(childerr, STDERR_FILENO) < 0) {
618 619 620 621 622
        virReportSystemError(errno,
                             "%s", _("failed to setup stderr file handle"));
        goto fork_error;
    }

623 624 625
    if (childin != STDIN_FILENO && childin != null &&
        childin != childerr && childin != childout)
        VIR_FORCE_CLOSE(childin);
626 627 628
    if (childout > STDERR_FILENO && childout != null && childout != childerr)
        VIR_FORCE_CLOSE(childout);
    if (childerr > STDERR_FILENO && childerr != null)
629
        VIR_FORCE_CLOSE(childerr);
E
Eric Blake 已提交
630
    VIR_FORCE_CLOSE(null);
631 632 633 634 635 636

    /* Initialize full logging for a while */
    virLogSetFromEnv();

    /* Daemonize as late as possible, so the parent process can detect
     * the above errors with wait* */
637
    if (cmd->flags & VIR_EXEC_DAEMON) {
638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657
        if (setsid() < 0) {
            virReportSystemError(errno,
                                 "%s", _("cannot become session leader"));
            goto fork_error;
        }

        if (chdir("/") < 0) {
            virReportSystemError(errno,
                                 "%s", _("cannot change to root directory"));
            goto fork_error;
        }

        pid = fork();
        if (pid < 0) {
            virReportSystemError(errno,
                                 "%s", _("cannot fork child process"));
            goto fork_error;
        }

        if (pid > 0) {
658
            if (cmd->pidfile && (virPidFileWritePath(cmd->pidfile, pid) < 0)) {
E
Eric Blake 已提交
659 660 661 662
                if (virProcessKillPainfully(pid, true) >= 0)
                    virReportSystemError(errno,
                                         _("could not write pidfile %s for %d"),
                                         cmd->pidfile, pid);
663 664
                goto fork_error;
            }
665
            _exit(EXIT_SUCCESS);
666 667 668
        }
    }

669 670 671 672 673 674 675 676 677 678 679 680 681 682
    /* virFork reset all signal handlers to the defaults.
     * This is good for the child process, but our hook
     * risks running something that generates SIGPIPE,
     * so we need to temporarily block that again
     */
    memset(&waxoff, 0, sizeof(waxoff));
    waxoff.sa_handler = SIG_IGN;
    sigemptyset(&waxoff.sa_mask);
    memset(&waxon, 0, sizeof(waxon));
    if (sigaction(SIGPIPE, &waxoff, &waxon) < 0) {
        virReportSystemError(errno, "%s",
                             _("Could not disable SIGPIPE"));
        goto fork_error;
    }
683

684 685 686 687 688 689 690
    if (virProcessSetMaxMemLock(0, cmd->maxMemLock) < 0)
        goto fork_error;
    if (virProcessSetMaxProcesses(0, cmd->maxProcesses) < 0)
        goto fork_error;
    if (virProcessSetMaxFiles(0, cmd->maxFiles) < 0)
        goto fork_error;

691 692 693 694 695 696
    if (cmd->hook) {
        VIR_DEBUG("Run hook %p %p", cmd->hook, cmd->opaque);
        ret = cmd->hook(cmd->opaque);
        VIR_DEBUG("Done hook %d", ret);
        if (ret < 0)
           goto fork_error;
697
    }
698

699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724
# if defined(WITH_SECDRIVER_SELINUX)
    if (cmd->seLinuxLabel) {
        VIR_DEBUG("Setting child security label to %s", cmd->seLinuxLabel);
        if (setexeccon_raw(cmd->seLinuxLabel) == -1) {
            virReportSystemError(errno,
                                 _("unable to set SELinux security context "
                                   "'%s' for '%s'"),
                                 cmd->seLinuxLabel, cmd->args[0]);
            if (security_getenforce() == 1)
                goto fork_error;
        }
    }
# endif
# if defined(WITH_SECDRIVER_APPARMOR)
    if (cmd->appArmorProfile) {
        VIR_DEBUG("Setting child AppArmor profile to %s", cmd->appArmorProfile);
        if (aa_change_profile(cmd->appArmorProfile) < 0) {
            virReportSystemError(errno,
                                 _("unable to set AppArmor profile '%s' "
                                   "for '%s'"),
                                 cmd->appArmorProfile, cmd->args[0]);
            goto fork_error;
        }
    }
# endif

725 726 727 728 729 730 731
    /* The steps above may need to do something privileged, so we delay
     * setuid and clearing capabilities until the last minute.
     */
    if (cmd->uid != (uid_t)-1 || cmd->gid != (gid_t)-1 ||
        cmd->capabilities || (cmd->flags & VIR_EXEC_CLEAR_CAPS)) {
        VIR_DEBUG("Setting child uid:gid to %d:%d with caps %llx",
                  (int)cmd->uid, (int)cmd->gid, cmd->capabilities);
732 733
        if (virSetUIDGIDWithCaps(cmd->uid, cmd->gid, groups, ngroups,
                                 cmd->capabilities,
734
                                 !!(cmd->flags & VIR_EXEC_CLEAR_CAPS)) < 0) {
735
            goto fork_error;
736
        }
737 738
    }

739 740 741 742 743 744 745 746 747 748 749 750
    if (cmd->pwd) {
        VIR_DEBUG("Running child in %s", cmd->pwd);
        if (chdir(cmd->pwd) < 0) {
            virReportSystemError(errno,
                                 _("Unable to change to %s"), cmd->pwd);
            goto fork_error;
        }
    }

    if (virCommandHandshakeChild(cmd) < 0)
       goto fork_error;

751 752 753 754
    if (sigaction(SIGPIPE, &waxon, NULL) < 0) {
        virReportSystemError(errno, "%s",
                             _("Could not re-enable SIGPIPE"));
        goto fork_error;
755 756
    }

757 758 759 760 761 762 763 764 765
    if (cmd->flags & VIR_EXEC_LISTEN_FDS) {
        virCommandReorderFDs(cmd);
        virCommandAddEnvFormat(cmd, "LISTEN_PID=%u", getpid());
        virCommandAddEnvFormat(cmd, "LISTEN_FDS=%zu", cmd->npassfd);

        if (cmd->has_error)
            goto fork_error;
    }

766 767 768
    /* Close logging again to ensure no FDs leak to child */
    virLogReset();

769 770
    if (cmd->env)
        execve(binary, cmd->args, cmd->env);
771
    else
772
        execv(binary, cmd->args);
773

774
    ret = errno == ENOENT ? EXIT_ENOENT : EXIT_CANNOT_INVOKE;
775 776
    virReportSystemError(errno,
                         _("cannot execute binary %s"),
777
                         cmd->args[0]);
778 779 780

 fork_error:
    virDispatchError(NULL);
781
    _exit(ret);
782 783 784 785 786

 cleanup:
    /* This is cleanup of parent process only - child
       should never jump here on error */

787
    VIR_FREE(groups);
788
    VIR_FREE(binarystr);
789

790 791
    /* NB we don't virReportError() on any failures here
       because the code which jumped here already raised
792 793 794 795 796 797 798 799 800 801
       an error condition which we must not overwrite */
    VIR_FORCE_CLOSE(pipeerr[0]);
    VIR_FORCE_CLOSE(pipeerr[1]);
    VIR_FORCE_CLOSE(pipeout[0]);
    VIR_FORCE_CLOSE(pipeout[1]);
    VIR_FORCE_CLOSE(null);
    return -1;
}

/**
E
Eric Blake 已提交
802
 * virRun:
803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835
 * @argv NULL terminated argv to run
 * @status optional variable to return exit status in
 *
 * Run a command without using the shell.
 *
 * If status is NULL, then return 0 if the command run and
 * exited with 0 status; Otherwise return -1
 *
 * If status is not-NULL, then return 0 if the command ran.
 * The status variable is filled with the command exit status
 * and should be checked by caller for success. Return -1
 * only if the command could not be run.
 */
int
virRun(const char *const*argv, int *status)
{
    int ret;
    virCommandPtr cmd = virCommandNewArgs(argv);

    ret = virCommandRun(cmd, status);
    virCommandFree(cmd);
    return ret;
}

#else /* WIN32 */

int
virRun(const char *const *argv ATTRIBUTE_UNUSED,
       int *status)
{
    if (status)
        *status = ENOTSUP;
    else
836 837
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       "%s", _("virRun is not implemented for WIN32"));
838 839 840 841
    return -1;
}

static int
842
virExec(virCommandPtr cmd ATTRIBUTE_UNUSED)
843 844 845 846
{
    /* XXX: Some day we can implement pieces of virCommand/virExec on
     * top of _spawn() or CreateProcess(), but we can't implement
     * everything, since mingw completely lacks fork(), so we cannot
847
     * run our own code in the child process.  */
848 849
    virReportError(VIR_ERR_INTERNAL_ERROR,
                   "%s", _("virExec is not implemented for WIN32"));
850 851 852
    return -1;
}

E
Eric Blake 已提交
853 854
pid_t
virFork(void)
855 856 857 858 859 860 861 862 863
{
    errno = ENOTSUP;

    return -1;
}

#endif /* WIN32 */


E
Eric Blake 已提交
864 865 866 867 868 869 870
/**
 * virCommandNew:
 * @binary: program to run
 *
 * Create a new command for named binary.  If @binary is relative,
 * it will be found via a PATH search of the parent's PATH (and not
 * any altered PATH set by virCommandAddEnv* commands).
871 872 873 874 875 876 877 878 879
 */
virCommandPtr
virCommandNew(const char *binary)
{
    const char *const args[] = { binary, NULL };

    return virCommandNewArgs(args);
}

E
Eric Blake 已提交
880 881 882 883
/**
 * virCommandNewArgs:
 * @args: array of arguments
 *
884
 * Create a new command with a NULL terminated
E
Eric Blake 已提交
885 886
 * set of args, taking binary from args[0].  More arguments can
 * be added later.  @args[0] is handled like @binary of virCommandNew.
887 888 889 890 891 892 893 894 895
 */
virCommandPtr
virCommandNewArgs(const char *const*args)
{
    virCommandPtr cmd;

    if (VIR_ALLOC(cmd) < 0)
        return NULL;

896 897 898 899 900
    cmd->handshakeWait[0] = -1;
    cmd->handshakeWait[1] = -1;
    cmd->handshakeNotify[0] = -1;
    cmd->handshakeNotify[1] = -1;

901
    cmd->infd = cmd->inpipe = cmd->outfd = cmd->errfd = -1;
902
    cmd->pid = -1;
903 904
    cmd->uid = -1;
    cmd->gid = -1;
905 906 907 908 909 910

    virCommandAddArgSet(cmd, args);

    return cmd;
}

E
Eric Blake 已提交
911 912 913 914 915
/**
 * virCommandNewArgList:
 * @binary: program to run
 * @...: additional arguments
 *
916
 * Create a new command with a NULL terminated
E
Eric Blake 已提交
917 918
 * list of args, starting with the binary to run.  More arguments can
 * be added later.  @binary is handled as in virCommandNew.
919 920 921 922 923 924 925 926 927
 */
virCommandPtr
virCommandNewArgList(const char *binary, ...)
{
    virCommandPtr cmd = virCommandNew(binary);
    va_list list;
    const char *arg;

    if (!cmd || cmd->has_error)
E
Eric Blake 已提交
928
        return cmd;
929 930 931 932 933 934 935 936

    va_start(list, binary);
    while ((arg = va_arg(list, const char *)) != NULL)
        virCommandAddArg(cmd, arg);
    va_end(list);
    return cmd;
}

937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958
/**
 * virCommandNewVAList:
 * @binary: program to run
 * @va_list: additional arguments
 *
 * Create a new command with a NULL terminated
 * variable argument list.  @binary is handled as in virCommandNew.
 */
virCommandPtr
virCommandNewVAList(const char *binary, va_list list)
{
    virCommandPtr cmd = virCommandNew(binary);
    const char *arg;

    if (!cmd || cmd->has_error)
        return cmd;

    while ((arg = va_arg(list, const char *)) != NULL)
        virCommandAddArg(cmd, arg);
    return cmd;
}

959

960 961 962 963
#define VIR_COMMAND_MAYBE_CLOSE_FD(fd, flags)       \
    if ((fd > STDERR_FILENO) &&                     \
        (flags & VIR_COMMAND_PASS_FD_CLOSE_PARENT)) \
        VIR_FORCE_CLOSE(fd)
964

E
Eric Blake 已提交
965
/**
966
 * virCommandPassFD:
E
Eric Blake 已提交
967 968
 * @cmd: the command to modify
 * @fd: fd to reassign to the child
969
 * @flags: the flags
E
Eric Blake 已提交
970
 *
971 972 973 974 975 976 977
 * Transfer the specified file descriptor to the child, instead
 * of closing it on exec. @fd must not be one of the three
 * standard streams.
 *
 * If the flag VIR_COMMAND_PASS_FD_CLOSE_PARENT is set then fd will
 * be closed in the parent no later than Run/RunAsync/Free. The parent
 * should cease using the @fd when this call completes
978 979
 */
void
980
virCommandPassFD(virCommandPtr cmd, int fd, unsigned int flags)
981
{
982 983 984 985 986 987 988 989 990 991 992 993 994 995
    int ret = 0;

    if (!cmd) {
        VIR_COMMAND_MAYBE_CLOSE_FD(fd, flags);
        return;
    }

    if (fd <= STDERR_FILENO) {
        VIR_DEBUG("invalid fd %d", fd);
        VIR_COMMAND_MAYBE_CLOSE_FD(fd, flags);
        if (!cmd->has_error)
            cmd->has_error = -1;
        return;
    }
996

997 998 999 1000 1001 1002 1003 1004
    if ((ret = virCommandFDSet(cmd, fd, flags)) != 0) {
        if (!cmd->has_error)
            cmd->has_error = ret;
        VIR_DEBUG("cannot preserve %d", fd);
        VIR_COMMAND_MAYBE_CLOSE_FD(fd, flags);
        return;
    }
}
1005

1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022
/**
 * virCommandPassListenFDs:
 * @cmd: the command to modify
 *
 * Pass LISTEN_FDS and LISTEN_PID environment variables into the
 * child.  LISTEN_PID has the value of the child's PID and LISTEN_FDS
 * is a number of passed file descriptors starting from 3.
 */
void
virCommandPassListenFDs(virCommandPtr cmd)
{
    if (!cmd || cmd->has_error)
        return;

    cmd->flags |= VIR_EXEC_LISTEN_FDS;
}

E
Eric Blake 已提交
1023 1024 1025 1026 1027 1028 1029
/**
 * virCommandSetPidFile:
 * @cmd: the command to modify
 * @pidfile: filename to use
 *
 * Save the child PID in a pidfile.  The pidfile will be populated
 * before the exec of the child.
1030 1031 1032 1033 1034 1035 1036 1037
 */
void
virCommandSetPidFile(virCommandPtr cmd, const char *pidfile)
{
    if (!cmd || cmd->has_error)
        return;

    VIR_FREE(cmd->pidfile);
1038
    if (VIR_STRDUP_QUIET(cmd->pidfile, pidfile) < 0)
1039 1040 1041 1042
        cmd->has_error = ENOMEM;
}


1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060
void
virCommandSetGID(virCommandPtr cmd, gid_t gid)
{
    if (!cmd || cmd->has_error)
        return;

    cmd->gid = gid;
}

void
virCommandSetUID(virCommandPtr cmd, uid_t uid)
{
    if (!cmd || cmd->has_error)
        return;

    cmd->uid = uid;
}

1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087
void
virCommandSetMaxMemLock(virCommandPtr cmd, unsigned long long bytes)
{
    if (!cmd || cmd->has_error)
        return;

    cmd->maxMemLock = bytes;
}

void
virCommandSetMaxProcesses(virCommandPtr cmd, unsigned int procs)
{
    if (!cmd || cmd->has_error)
        return;

    cmd->maxProcesses = procs;
}

void
virCommandSetMaxFiles(virCommandPtr cmd, unsigned int files)
{
    if (!cmd || cmd->has_error)
        return;

    cmd->maxFiles = files;
}

1088
void virCommandSetUmask(virCommandPtr cmd, int mask)
1089 1090 1091 1092
{
    if (!cmd || cmd->has_error)
        return;

1093
    cmd->mask = mask;
1094 1095
}

E
Eric Blake 已提交
1096 1097 1098 1099 1100
/**
 * virCommandClearCaps:
 * @cmd: the command to modify
 *
 * Remove all capabilities from the child, after any hooks have been run.
1101 1102 1103 1104 1105 1106 1107 1108 1109 1110
 */
void
virCommandClearCaps(virCommandPtr cmd)
{
    if (!cmd || cmd->has_error)
        return;

    cmd->flags |= VIR_EXEC_CLEAR_CAPS;
}

E
Eric Blake 已提交
1111 1112 1113 1114 1115
/**
 * virCommandAllowCap:
 * @cmd: the command to modify
 * @capability: what to allow
 *
1116
 * Allow specific capabilities
1117 1118 1119
 */
void
virCommandAllowCap(virCommandPtr cmd,
1120
                   int capability)
1121 1122 1123 1124
{
    if (!cmd || cmd->has_error)
        return;

1125
    cmd->capabilities |= (1ULL << capability);
1126 1127 1128
}


1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147
/**
 * virCommandSetSELinuxLabel:
 * @cmd: the command to modify
 * @label: the SELinux label to use for the child process
 *
 * Saves a copy of @label to use when setting the SELinux context
 * label (with setexeccon_raw()) after the child process has been
 * started. If SELinux isn't compiled into libvirt, or if label is
 * NULL, nothing will be done.
 */
void
virCommandSetSELinuxLabel(virCommandPtr cmd,
                          const char *label ATTRIBUTE_UNUSED)
{
    if (!cmd || cmd->has_error)
        return;

#if defined(WITH_SECDRIVER_SELINUX)
    VIR_FREE(cmd->seLinuxLabel);
1148
    if (VIR_STRDUP_QUIET(cmd->seLinuxLabel, label) < 0)
1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172
        cmd->has_error = ENOMEM;
#endif
    return;
}


/**
 * virCommandSetAppArmorProfile:
 * @cmd: the command to modify
 * @profile: the AppArmor profile to use
 *
 * Saves a copy of @profile to use when aa_change_profile() after the
 * child process has been started. If AppArmor support isn't
 * configured into libvirt, or if profile is NULL, nothing will be done.
 */
void
virCommandSetAppArmorProfile(virCommandPtr cmd,
                             const char *profile ATTRIBUTE_UNUSED)
{
    if (!cmd || cmd->has_error)
        return;

#if defined(WITH_SECDRIVER_APPARMOR)
    VIR_FREE(cmd->appArmorProfile);
1173
    if (VIR_STRDUP_QUIET(cmd->appArmorProfile, profile) < 0)
1174 1175 1176 1177 1178
        cmd->has_error = ENOMEM;
#endif
    return;
}

1179

E
Eric Blake 已提交
1180 1181 1182 1183 1184 1185 1186
/**
 * virCommandDaemonize:
 * @cmd: the command to modify
 *
 * Daemonize the child process.  The child will have a current working
 * directory of /, and must be started with virCommandRun, which will
 * complete as soon as the daemon grandchild has started.
1187 1188 1189 1190 1191 1192 1193 1194 1195 1196
 */
void
virCommandDaemonize(virCommandPtr cmd)
{
    if (!cmd || cmd->has_error)
        return;

    cmd->flags |= VIR_EXEC_DAEMON;
}

E
Eric Blake 已提交
1197 1198 1199 1200
/**
 * virCommandNonblockingFDs:
 * @cmd: the command to modify
 *
1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212
 * Set FDs created by virCommandSetOutputFD and virCommandSetErrorFD
 * as non-blocking in the parent.
 */
void
virCommandNonblockingFDs(virCommandPtr cmd)
{
    if (!cmd || cmd->has_error)
        return;

    cmd->flags |= VIR_EXEC_NONBLOCK;
}

1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231
/**
 * virCommandRawStatus:
 * @cmd: the command to modify
 *
 * Mark this command as returning raw exit status via virCommandRun() or
 * virCommandWait() (caller must use WIFEXITED() and friends, and can
 * detect death from signals) instead of the default of only allowing
 * normal exit status (caller must not use WEXITSTATUS(), and death from
 * signals returns -1).
 */
void
virCommandRawStatus(virCommandPtr cmd)
{
    if (!cmd || cmd->has_error)
        return;

    cmd->rawStatus = true;
}

1232
/* Add an environment variable to the cmd->env list.  'env' is a
1233 1234
 * string like "name=value".  If the named environment variable is
 * already set, then it is replaced in the list.
1235 1236 1237 1238
 */
static inline void
virCommandAddEnv(virCommandPtr cmd, char *env)
{
1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252
    size_t namelen;
    size_t i;

    /* Search for the name in the existing environment. */
    namelen = strcspn(env, "=");
    for (i = 0; i < cmd->nenv; ++i) {
        /* + 1 because we want to match the '=' character too. */
        if (STREQLEN(cmd->env[i], env, namelen + 1)) {
            VIR_FREE(cmd->env[i]);
            cmd->env[i] = env;
            return;
        }
    }

1253 1254 1255 1256 1257 1258 1259 1260 1261 1262
    /* Arg plus trailing NULL. */
    if (VIR_RESIZE_N(cmd->env, cmd->maxenv, cmd->nenv, 1 + 1) < 0) {
        VIR_FREE(env);
        cmd->has_error = ENOMEM;
        return;
    }

    cmd->env[cmd->nenv++] = env;
}

E
Eric Blake 已提交
1263 1264 1265 1266 1267 1268 1269
/**
 * virCommandAddEnvFormat:
 * @cmd: the command to modify
 * @format: format of arguments, end result must be in name=value format
 * @...: arguments to be formatted
 *
 * Add an environment variable to the child created by a printf-style format.
1270 1271
 */
void
1272
virCommandAddEnvFormat(virCommandPtr cmd, const char *format, ...)
1273 1274
{
    char *env;
1275
    va_list list;
1276 1277 1278 1279

    if (!cmd || cmd->has_error)
        return;

1280 1281
    va_start(list, format);
    if (virVasprintf(&env, format, list) < 0) {
1282
        cmd->has_error = ENOMEM;
1283
        va_end(list);
1284 1285
        return;
    }
1286
    va_end(list);
1287

1288
    virCommandAddEnv(cmd, env);
1289 1290
}

E
Eric Blake 已提交
1291 1292 1293 1294 1295 1296
/**
 * virCommandAddEnvPair:
 * @cmd: the command to modify
 * @name: variable name, must not contain =
 * @value: value to assign to name
 *
1297 1298 1299 1300 1301 1302 1303 1304 1305
 * Add an environment variable to the child
 * using separate name & value strings
 */
void
virCommandAddEnvPair(virCommandPtr cmd, const char *name, const char *value)
{
    virCommandAddEnvFormat(cmd, "%s=%s", name, value);
}

1306

E
Eric Blake 已提交
1307 1308 1309 1310 1311
/**
 * virCommandAddEnvString:
 * @cmd: the command to modify
 * @str: name=value format
 *
1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322
 * Add an environment variable to the child
 * using a preformatted env string FOO=BAR
 */
void
virCommandAddEnvString(virCommandPtr cmd, const char *str)
{
    char *env;

    if (!cmd || cmd->has_error)
        return;

1323
    if (VIR_STRDUP_QUIET(env, str) < 0) {
1324 1325 1326 1327
        cmd->has_error = ENOMEM;
        return;
    }

1328
    virCommandAddEnv(cmd, env);
1329 1330 1331
}


E
Eric Blake 已提交
1332 1333 1334 1335 1336
/**
 * virCommandAddEnvBuffer:
 * @cmd: the command to modify
 * @buf: buffer that contains name=value string, which will be reset on return
 *
1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348
 * Convert a buffer containing preformatted name=value into an
 * environment variable of the child.
 * Correctly transfers memory errors or contents from buf to cmd.
 */
void
virCommandAddEnvBuffer(virCommandPtr cmd, virBufferPtr buf)
{
    if (!cmd || cmd->has_error) {
        virBufferFreeAndReset(buf);
        return;
    }

1349
    if (virBufferError(buf)) {
1350 1351 1352 1353
        cmd->has_error = ENOMEM;
        virBufferFreeAndReset(buf);
        return;
    }
1354 1355 1356 1357
    if (!virBufferUse(buf)) {
        cmd->has_error = EINVAL;
        return;
    }
1358

1359
    virCommandAddEnv(cmd, virBufferContentAndReset(buf));
1360 1361 1362
}


E
Eric Blake 已提交
1363
/**
1364
 * virCommandAddEnvPassAllowSUID:
E
Eric Blake 已提交
1365 1366 1367
 * @cmd: the command to modify
 * @name: the name to look up in current environment
 *
1368 1369
 * Pass an environment variable to the child
 * using current process' value
1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395
 *
 * Allow to be passed even if setuid
 */
void
virCommandAddEnvPassAllowSUID(virCommandPtr cmd, const char *name)
{
    const char *value;
    if (!cmd || cmd->has_error)
        return;

    value = virGetEnvAllowSUID(name);
    if (value)
        virCommandAddEnvPair(cmd, name, value);
}


/**
 * virCommandAddEnvPassBlockSUID:
 * @cmd: the command to modify
 * @name: the name to look up in current environment
 * @defvalue: value to return if running setuid, may be NULL
 *
 * Pass an environment variable to the child
 * using current process' value.
 *
 * Do not pass if running setuid
1396 1397
 */
void
1398
virCommandAddEnvPassBlockSUID(virCommandPtr cmd, const char *name, const char *defvalue)
1399
{
1400
    const char *value;
1401 1402 1403
    if (!cmd || cmd->has_error)
        return;

1404 1405 1406
    value = virGetEnvBlockSUID(name);
    if (!value)
        value = defvalue;
1407 1408 1409 1410 1411
    if (value)
        virCommandAddEnvPair(cmd, name, value);
}


E
Eric Blake 已提交
1412 1413 1414 1415
/**
 * virCommandAddEnvPassCommon:
 * @cmd: the command to modify
 *
1416
 * Set LC_ALL to C, and propagate other essential environment
E
Eric Blake 已提交
1417
 * variables (such as PATH) from the parent process.
1418 1419 1420 1421
 */
void
virCommandAddEnvPassCommon(virCommandPtr cmd)
{
1422 1423 1424
    if (!cmd || cmd->has_error)
        return;

1425 1426 1427 1428
    if (VIR_RESIZE_N(cmd->env, cmd->maxenv, cmd->nenv, 9) < 0) {
        cmd->has_error = ENOMEM;
        return;
    }
1429 1430 1431

    virCommandAddEnvPair(cmd, "LC_ALL", "C");

1432 1433 1434 1435 1436 1437 1438
    virCommandAddEnvPassBlockSUID(cmd, "LD_PRELOAD", NULL);
    virCommandAddEnvPassBlockSUID(cmd, "LD_LIBRARY_PATH", NULL);
    virCommandAddEnvPassBlockSUID(cmd, "PATH", "/bin:/usr/bin");
    virCommandAddEnvPassBlockSUID(cmd, "HOME", NULL);
    virCommandAddEnvPassAllowSUID(cmd, "USER");
    virCommandAddEnvPassAllowSUID(cmd, "LOGNAME");
    virCommandAddEnvPassBlockSUID(cmd, "TMPDIR", NULL);
1439 1440
}

E
Eric Blake 已提交
1441 1442 1443 1444 1445
/**
 * virCommandAddArg:
 * @cmd: the command to modify
 * @val: the argument to add
 *
1446 1447 1448 1449 1450 1451 1452 1453 1454 1455
 * Add a command line argument to the child
 */
void
virCommandAddArg(virCommandPtr cmd, const char *val)
{
    char *arg;

    if (!cmd || cmd->has_error)
        return;

1456
    if (VIR_STRDUP_QUIET(arg, val) < 0) {
1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471
        cmd->has_error = ENOMEM;
        return;
    }

    /* Arg plus trailing NULL. */
    if (VIR_RESIZE_N(cmd->args, cmd->maxargs, cmd->nargs, 1 + 1) < 0) {
        VIR_FREE(arg);
        cmd->has_error = ENOMEM;
        return;
    }

    cmd->args[cmd->nargs++] = arg;
}


E
Eric Blake 已提交
1472 1473 1474 1475 1476
/**
 * virCommandAddArgBuffer:
 * @cmd: the command to modify
 * @buf: buffer that contains argument string, which will be reset on return
 *
1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495
 * Convert a buffer into a command line argument to the child.
 * Correctly transfers memory errors or contents from buf to cmd.
 */
void
virCommandAddArgBuffer(virCommandPtr cmd, virBufferPtr buf)
{
    if (!cmd || cmd->has_error) {
        virBufferFreeAndReset(buf);
        return;
    }

    /* Arg plus trailing NULL. */
    if (virBufferError(buf) ||
        VIR_RESIZE_N(cmd->args, cmd->maxargs, cmd->nargs, 1 + 1) < 0) {
        cmd->has_error = ENOMEM;
        virBufferFreeAndReset(buf);
        return;
    }

1496 1497
    cmd->args[cmd->nargs] = virBufferContentAndReset(buf);
    if (!cmd->args[cmd->nargs]) {
1498 1499 1500 1501
        if (VIR_STRDUP_QUIET(cmd->args[cmd->nargs], "") < 0) {
            cmd->has_error = ENOMEM;
            return;
        }
1502 1503
    }
    cmd->nargs++;
1504 1505 1506
}


E
Eric Blake 已提交
1507 1508 1509 1510 1511 1512 1513
/**
 * virCommandAddArgFormat:
 * @cmd: the command to modify
 * @format: format of arguments, end result must be in name=value format
 * @...: arguments to be formatted
 *
 * Add a command line argument created by a printf-style format.
1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541
 */
void
virCommandAddArgFormat(virCommandPtr cmd, const char *format, ...)
{
    char *arg;
    va_list list;

    if (!cmd || cmd->has_error)
        return;

    va_start(list, format);
    if (virVasprintf(&arg, format, list) < 0) {
        cmd->has_error = ENOMEM;
        va_end(list);
        return;
    }
    va_end(list);

    /* Arg plus trailing NULL. */
    if (VIR_RESIZE_N(cmd->args, cmd->maxargs, cmd->nargs, 1 + 1) < 0) {
        VIR_FREE(arg);
        cmd->has_error = ENOMEM;
        return;
    }

    cmd->args[cmd->nargs++] = arg;
}

E
Eric Blake 已提交
1542 1543 1544 1545 1546 1547
/**
 * virCommandAddArgPair:
 * @cmd: the command to modify
 * @name: left half of argument
 * @value: right half of argument
 *
1548 1549 1550 1551 1552 1553 1554 1555
 * Add "NAME=VAL" as a single command line argument to the child
 */
void
virCommandAddArgPair(virCommandPtr cmd, const char *name, const char *val)
{
    virCommandAddArgFormat(cmd, "%s=%s", name, val);
}

E
Eric Blake 已提交
1556 1557 1558 1559 1560
/**
 * virCommandAddArgSet:
 * @cmd: the command to modify
 * @vals: array of arguments to add
 *
1561 1562 1563 1564 1565 1566 1567 1568 1569 1570
 * Add a NULL terminated list of args
 */
void
virCommandAddArgSet(virCommandPtr cmd, const char *const*vals)
{
    int narg = 0;

    if (!cmd || cmd->has_error)
        return;

1571 1572 1573 1574 1575
    if (vals[0] == NULL) {
        cmd->has_error = EINVAL;
        return;
    }

1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586
    while (vals[narg] != NULL)
        narg++;

    /* narg plus trailing NULL. */
    if (VIR_RESIZE_N(cmd->args, cmd->maxargs, cmd->nargs, narg + 1) < 0) {
        cmd->has_error = ENOMEM;
        return;
    }

    narg = 0;
    while (vals[narg] != NULL) {
1587 1588 1589
        char *arg;

        if (VIR_STRDUP_QUIET(arg, vals[narg++]) < 0) {
1590 1591 1592 1593 1594 1595 1596
            cmd->has_error = ENOMEM;
            return;
        }
        cmd->args[cmd->nargs++] = arg;
    }
}

E
Eric Blake 已提交
1597 1598 1599 1600 1601 1602
/**
 * virCommandAddArgList:
 * @cmd: the command to modify
 * @...: list of arguments to add
 *
 * Add a NULL terminated list of args.
1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628
 */
void
virCommandAddArgList(virCommandPtr cmd, ...)
{
    va_list list;
    int narg = 0;

    if (!cmd || cmd->has_error)
        return;

    va_start(list, cmd);
    while (va_arg(list, const char *) != NULL)
        narg++;
    va_end(list);

    /* narg plus trailing NULL. */
    if (VIR_RESIZE_N(cmd->args, cmd->maxargs, cmd->nargs, narg + 1) < 0) {
        cmd->has_error = ENOMEM;
        return;
    }

    va_start(list, cmd);
    while (1) {
        char *arg = va_arg(list, char *);
        if (!arg)
            break;
1629
        if (VIR_STRDUP_QUIET(arg, arg) < 0) {
1630 1631 1632 1633 1634 1635 1636 1637 1638
            cmd->has_error = ENOMEM;
            va_end(list);
            return;
        }
        cmd->args[cmd->nargs++] = arg;
    }
    va_end(list);
}

E
Eric Blake 已提交
1639 1640 1641 1642 1643
/**
 * virCommandSetWorkingDirectory:
 * @cmd: the command to modify
 * @pwd: directory to use
 *
1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655
 * Set the working directory of a non-daemon child process, rather
 * than the parent's working directory.  Daemons automatically get /
 * without using this call.
 */
void
virCommandSetWorkingDirectory(virCommandPtr cmd, const char *pwd)
{
    if (!cmd || cmd->has_error)
        return;

    if (cmd->pwd) {
        cmd->has_error = -1;
1656
        VIR_DEBUG("cannot set directory twice");
1657
    } else {
1658
        if (VIR_STRDUP_QUIET(cmd->pwd, pwd) < 0)
1659 1660 1661 1662 1663
            cmd->has_error = ENOMEM;
    }
}


E
Eric Blake 已提交
1664 1665 1666 1667 1668
/**
 * virCommandSetInputBuffer:
 * @cmd: the command to modify
 * @inbuf: string to feed to stdin
 *
1669 1670 1671
 * Feed the child's stdin from a string buffer.  This requires the
 * use of virCommandRun() or combination of virCommandDoAsyncIO and
 * virCommandRunAsync. The buffer is forgotten after each @cmd run.
1672 1673 1674 1675 1676 1677 1678 1679 1680
 */
void
virCommandSetInputBuffer(virCommandPtr cmd, const char *inbuf)
{
    if (!cmd || cmd->has_error)
        return;

    if (cmd->infd != -1 || cmd->inbuf) {
        cmd->has_error = -1;
1681
        VIR_DEBUG("cannot specify input twice");
1682 1683 1684
        return;
    }

1685
    if (VIR_STRDUP_QUIET(cmd->inbuf, inbuf) < 0)
1686 1687 1688 1689
        cmd->has_error = ENOMEM;
}


E
Eric Blake 已提交
1690 1691 1692 1693 1694
/**
 * virCommandSetOutputBuffer:
 * @cmd: the command to modify
 * @outbuf: address of variable to store malloced result buffer
 *
1695 1696 1697
 * Capture the child's stdout to a string buffer.  *outbuf is
 * guaranteed to be allocated after successful virCommandRun or
 * virCommandWait, and is best-effort allocated after failed
1698 1699 1700 1701
 * virCommandRun or virCommandRunAsync; caller is responsible for
 * freeing *outbuf. This requires the use of virCommandRun() or
 * combination of virCommandDoAsyncIO and virCommandRunAsync. The
 * buffer is forgotten after each @cmd run.
1702 1703 1704 1705
 */
void
virCommandSetOutputBuffer(virCommandPtr cmd, char **outbuf)
{
1706
    *outbuf = NULL;
1707 1708 1709 1710 1711
    if (!cmd || cmd->has_error)
        return;

    if (cmd->outfdptr) {
        cmd->has_error = -1;
1712
        VIR_DEBUG("cannot specify output twice");
1713 1714 1715 1716 1717 1718 1719 1720
        return;
    }

    cmd->outbuf = outbuf;
    cmd->outfdptr = &cmd->outfd;
}


E
Eric Blake 已提交
1721 1722 1723 1724 1725
/**
 * virCommandSetErrorBuffer:
 * @cmd: the command to modify
 * @errbuf: address of variable to store malloced result buffer
 *
1726 1727 1728
 * Capture the child's stderr to a string buffer.  *errbuf is
 * guaranteed to be allocated after successful virCommandRun or
 * virCommandWait, and is best-effort allocated after failed
1729 1730 1731 1732 1733 1734 1735
 * virCommandRun or virCommandRunAsync; caller is responsible for
 * freeing *errbuf. It is possible to pass the same pointer as
 * for virCommandSetOutputBuffer(), in which case the child
 * process will interleave all output into a single string.  This
 * requires the use of virCommandRun() or combination of
 * virCommandDoAsyncIO and virCommandRunAsync.The buffer is
 * forgotten after each @cmd run.
1736 1737 1738 1739
 */
void
virCommandSetErrorBuffer(virCommandPtr cmd, char **errbuf)
{
1740
    *errbuf = NULL;
1741 1742 1743 1744 1745
    if (!cmd || cmd->has_error)
        return;

    if (cmd->errfdptr) {
        cmd->has_error = -1;
1746
        VIR_DEBUG("cannot specify stderr twice");
1747 1748 1749 1750 1751 1752 1753 1754
        return;
    }

    cmd->errbuf = errbuf;
    cmd->errfdptr = &cmd->errfd;
}


E
Eric Blake 已提交
1755 1756 1757 1758 1759
/**
 * virCommandSetInputFD:
 * @cmd: the command to modify
 * @infd: the descriptor to use
 *
1760 1761 1762 1763 1764 1765 1766 1767 1768 1769
 * Attach a file descriptor to the child's stdin
 */
void
virCommandSetInputFD(virCommandPtr cmd, int infd)
{
    if (!cmd || cmd->has_error)
        return;

    if (cmd->infd != -1 || cmd->inbuf) {
        cmd->has_error = -1;
1770
        VIR_DEBUG("cannot specify input twice");
1771 1772 1773 1774
        return;
    }
    if (infd < 0) {
        cmd->has_error = -1;
1775
        VIR_DEBUG("cannot specify invalid input fd");
1776 1777 1778 1779 1780 1781 1782
        return;
    }

    cmd->infd = infd;
}


E
Eric Blake 已提交
1783 1784 1785 1786 1787 1788 1789 1790
/**
 * virCommandSetOutputFD:
 * @cmd: the command to modify
 * @outfd: location of output fd
 *
 * Attach a file descriptor to the child's stdout.  If *@outfd is -1 on
 * entry, then a pipe will be created and returned in this variable when
 * the child is run.  Otherwise, *@outfd is used as the output.
1791 1792 1793 1794 1795 1796 1797 1798 1799
 */
void
virCommandSetOutputFD(virCommandPtr cmd, int *outfd)
{
    if (!cmd || cmd->has_error)
        return;

    if (cmd->outfdptr) {
        cmd->has_error = -1;
1800
        VIR_DEBUG("cannot specify output twice");
1801 1802 1803 1804 1805 1806 1807
        return;
    }

    cmd->outfdptr = outfd;
}


E
Eric Blake 已提交
1808 1809 1810 1811 1812 1813 1814 1815 1816
/**
 * virCommandSetErrorFD:
 * @cmd: the command to modify
 * @errfd: location of error fd
 *
 * Attach a file descriptor to the child's stderr.  If *@errfd is -1 on
 * entry, then a pipe will be created and returned in this variable when
 * the child is run.  Otherwise, *@errfd is used for error collection,
 * and may be the same as outfd given to virCommandSetOutputFD().
1817 1818 1819 1820 1821 1822 1823 1824 1825
 */
void
virCommandSetErrorFD(virCommandPtr cmd, int *errfd)
{
    if (!cmd || cmd->has_error)
        return;

    if (cmd->errfdptr) {
        cmd->has_error = -1;
1826
        VIR_DEBUG("cannot specify stderr twice");
1827 1828 1829 1830 1831 1832 1833
        return;
    }

    cmd->errfdptr = errfd;
}


E
Eric Blake 已提交
1834 1835 1836 1837 1838 1839
/**
 * virCommandSetPreExecHook:
 * @cmd: the command to modify
 * @hook: the hook to run
 * @opaque: argument to pass to the hook
 *
1840 1841 1842
 * Run HOOK(OPAQUE) in the child as the last thing before changing
 * directories, dropping capabilities, and executing the new process.
 * Force the child to fail if HOOK does not return zero.
E
Eric Blake 已提交
1843 1844 1845
 *
 * Since @hook runs in the child, it should be careful to avoid
 * any functions that are not async-signal-safe.
1846 1847 1848 1849 1850 1851 1852 1853 1854
 */
void
virCommandSetPreExecHook(virCommandPtr cmd, virExecHook hook, void *opaque)
{
    if (!cmd || cmd->has_error)
        return;

    if (cmd->hook) {
        cmd->has_error = -1;
1855
        VIR_DEBUG("cannot specify hook twice");
1856 1857 1858 1859 1860 1861 1862
        return;
    }
    cmd->hook = hook;
    cmd->opaque = opaque;
}


E
Eric Blake 已提交
1863 1864 1865 1866 1867
/**
 * virCommandWriteArgLog:
 * @cmd: the command to log
 * @logfd: where to log the results
 *
1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883
 * Call after adding all arguments and environment settings, but before
 * Run/RunAsync, to immediately output the environment and arguments of
 * cmd to logfd.  If virCommandRun cannot succeed (because of an
 * out-of-memory condition while building cmd), nothing will be logged.
 */
void
virCommandWriteArgLog(virCommandPtr cmd, int logfd)
{
    int ioError = 0;
    size_t i;

    /* Any errors will be reported later by virCommandRun, which means
     * no command will be run, so there is nothing to log. */
    if (!cmd || cmd->has_error)
        return;

1884
    for (i = 0; i < cmd->nenv; i++) {
1885 1886 1887 1888 1889
        if (safewrite(logfd, cmd->env[i], strlen(cmd->env[i])) < 0)
            ioError = errno;
        if (safewrite(logfd, " ", 1) < 0)
            ioError = errno;
    }
1890
    for (i = 0; i < cmd->nargs; i++) {
1891 1892 1893 1894 1895 1896 1897 1898 1899
        if (safewrite(logfd, cmd->args[i], strlen(cmd->args[i])) < 0)
            ioError = errno;
        if (safewrite(logfd, i == cmd->nargs - 1 ? "\n" : " ", 1) < 0)
            ioError = errno;
    }

    if (ioError) {
        char ebuf[1024];
        VIR_WARN("Unable to write command %s args to logfile: %s",
1900
                 cmd->args[0], virStrerror(ioError, ebuf, sizeof(ebuf)));
1901 1902 1903 1904
    }
}


E
Eric Blake 已提交
1905 1906 1907 1908
/**
 * virCommandToString:
 * @cmd: the command to convert
 *
1909 1910 1911 1912
 * Call after adding all arguments and environment settings, but
 * before Run/RunAsync, to return a string representation of the
 * environment and arguments of cmd, suitably quoted for pasting into
 * a shell.  If virCommandRun cannot succeed (because of an
1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923
 * out-of-memory condition while building cmd), NULL will be returned.
 * Caller is responsible for freeing the resulting string.
 */
char *
virCommandToString(virCommandPtr cmd)
{
    size_t i;
    virBuffer buf = VIR_BUFFER_INITIALIZER;

    /* Cannot assume virCommandRun will be called; so report the error
     * now.  If virCommandRun is called, it will report the same error. */
1924 1925
    if (!cmd ||cmd->has_error == ENOMEM) {
        virReportOOMError();
1926 1927
        return NULL;
    }
1928
    if (cmd->has_error) {
1929 1930
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("invalid use of command API"));
1931 1932 1933 1934
        return NULL;
    }

    for (i = 0; i < cmd->nenv; i++) {
1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947
        /* In shell, a='b c' has a different meaning than 'a=b c', so
         * we must determine where the '=' lives.  */
        char *eq = strchr(cmd->env[i], '=');

        if (!eq) {
            virBufferFreeAndReset(&buf);
            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                           _("invalid use of command API"));
            return NULL;
        }
        eq++;
        virBufferAdd(&buf, cmd->env[i], eq - cmd->env[i]);
        virBufferEscapeShell(&buf, eq);
1948 1949
        virBufferAddChar(&buf, ' ');
    }
1950
    virBufferEscapeShell(&buf, cmd->args[0]);
1951 1952
    for (i = 1; i < cmd->nargs; i++) {
        virBufferAddChar(&buf, ' ');
1953
        virBufferEscapeShell(&buf, cmd->args[i]);
1954 1955
    }

1956
    if (virBufferCheckError(&buf) < 0)
1957 1958 1959 1960 1961 1962 1963 1964 1965 1966
        return NULL;

    return virBufferContentAndReset(&buf);
}


/*
 * Manage input and output to the child process.
 */
static int
1967
virCommandProcessIO(virCommandPtr cmd)
1968
{
1969
    int outfd = -1, errfd = -1;
1970 1971
    size_t inlen = 0, outlen = 0, errlen = 0;
    size_t inoff = 0;
1972
    int ret = 0;
1973

1974 1975 1976 1977 1978
    if (dryRunBuffer || dryRunCallback) {
        VIR_DEBUG("Dry run requested, skipping I/O processing");
        return 0;
    }

1979 1980
    /* With an input buffer, feed data to child
     * via pipe */
1981
    if (cmd->inbuf)
1982 1983
        inlen = strlen(cmd->inbuf);

1984 1985 1986 1987 1988
    /* With out/err buffer, the outfd/errfd have been filled with an
     * FD for us.  Guarantee an allocated string with partial results
     * even if we encounter a later failure, as well as freeing any
     * results accumulated over a prior run of the same command.  */
    if (cmd->outbuf) {
1989
        outfd = cmd->outfd;
1990
        if (VIR_REALLOC_N(*cmd->outbuf, 1) < 0)
1991 1992 1993
            ret = -1;
    }
    if (cmd->errbuf) {
1994
        errfd = cmd->errfd;
1995
        if (VIR_REALLOC_N(*cmd->errbuf, 1) < 0)
1996 1997 1998 1999 2000
            ret = -1;
    }
    if (ret == -1)
        goto cleanup;
    ret = -1;
2001 2002

    for (;;) {
2003
        size_t i;
2004 2005 2006
        struct pollfd fds[3];
        int nfds = 0;

2007 2008
        if (cmd->inpipe != -1) {
            fds[nfds].fd = cmd->inpipe;
2009
            fds[nfds].events = POLLOUT;
2010
            fds[nfds].revents = 0;
2011 2012 2013 2014 2015
            nfds++;
        }
        if (outfd != -1) {
            fds[nfds].fd = outfd;
            fds[nfds].events = POLLIN;
2016
            fds[nfds].revents = 0;
2017 2018 2019 2020 2021
            nfds++;
        }
        if (errfd != -1) {
            fds[nfds].fd = errfd;
            fds[nfds].events = POLLIN;
2022
            fds[nfds].revents = 0;
2023 2024 2025 2026 2027 2028 2029
            nfds++;
        }

        if (nfds == 0)
            break;

        if (poll(fds, nfds, -1) < 0) {
2030
            if (errno == EAGAIN || errno == EINTR)
2031 2032 2033
                continue;
            virReportSystemError(errno, "%s",
                                 _("unable to poll on child"));
2034
            goto cleanup;
2035 2036
        }

2037
        for (i = 0; i < nfds; i++) {
2038
            if (fds[i].revents & (POLLIN | POLLHUP | POLLERR) &&
2039
                (fds[i].fd == errfd || fds[i].fd == outfd)) {
2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050
                char data[1024];
                char **buf;
                size_t *len;
                int done;
                if (fds[i].fd == outfd) {
                    buf = cmd->outbuf;
                    len = &outlen;
                } else {
                    buf = cmd->errbuf;
                    len = &errlen;
                }
2051 2052
                /* Silence a false positive from clang. */
                sa_assert(buf);
2053 2054 2055 2056 2057 2058

                done = read(fds[i].fd, data, sizeof(data));
                if (done < 0) {
                    if (errno != EINTR &&
                        errno != EAGAIN) {
                        virReportSystemError(errno, "%s",
2059 2060 2061
                                             (fds[i].fd == outfd) ?
                                             _("unable to read child stdout") :
                                             _("unable to read child stderr"));
2062
                        goto cleanup;
2063 2064 2065 2066 2067 2068 2069
                    }
                } else if (done == 0) {
                    if (fds[i].fd == outfd)
                        outfd = -1;
                    else
                        errfd = -1;
                } else {
2070
                    if (VIR_REALLOC_N(*buf, *len + done + 1) < 0)
2071
                        goto cleanup;
2072 2073 2074
                    memcpy(*buf + *len, data, done);
                    *len += done;
                }
2075 2076
            }

2077
            if (fds[i].revents & (POLLOUT | POLLERR) &&
2078
                fds[i].fd == cmd->inpipe) {
2079 2080
                int done;

2081
                done = write(cmd->inpipe, cmd->inbuf + inoff,
2082 2083
                             inlen - inoff);
                if (done < 0) {
2084 2085
                    if (errno == EPIPE) {
                        VIR_DEBUG("child closed stdin early, ignoring EPIPE "
2086 2087
                                  "on fd %d", cmd->inpipe);
                        VIR_FORCE_CLOSE(cmd->inpipe);
2088
                    } else if (errno != EINTR && errno != EAGAIN) {
2089 2090
                        virReportSystemError(errno, "%s",
                                             _("unable to write to child input"));
2091
                        goto cleanup;
2092 2093 2094
                    }
                } else {
                    inoff += done;
2095 2096
                    if (inoff == inlen)
                        VIR_FORCE_CLOSE(cmd->inpipe);
2097 2098 2099 2100 2101
                }
            }
        }
    }

2102
    ret = 0;
2103
 cleanup:
2104
    if (cmd->outbuf && *cmd->outbuf)
2105
        (*cmd->outbuf)[outlen] = '\0';
2106
    if (cmd->errbuf && *cmd->errbuf)
2107 2108
        (*cmd->errbuf)[errlen] = '\0';
    return ret;
2109 2110
}

E
Eric Blake 已提交
2111 2112 2113 2114
/**
 * virCommandExec:
 * @cmd: command to run
 *
2115
 * Exec the command, replacing the current process. Meant to be called
E
Eric Blake 已提交
2116 2117
 * in the hook after already forking / cloning, so does not attempt to
 * daemonize or preserve any FDs.
2118 2119 2120 2121
 *
 * Returns -1 on any error executing the command.
 * Will not return on success.
 */
2122
#ifndef WIN32
2123 2124 2125 2126 2127 2128 2129
int virCommandExec(virCommandPtr cmd)
{
    if (!cmd ||cmd->has_error == ENOMEM) {
        virReportOOMError();
        return -1;
    }
    if (cmd->has_error) {
2130 2131
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("invalid use of command API"));
2132 2133 2134 2135 2136
        return -1;
    }

    return execve(cmd->args[0], cmd->args, cmd->env);
}
2137 2138 2139 2140 2141 2142 2143 2144 2145 2146 2147 2148
#else
int virCommandExec(virCommandPtr cmd ATTRIBUTE_UNUSED)
{
    /* Mingw execve() has a broken signature. Disable this
     * function until gnulib fixes the signature, since we
     * don't really need this on Win32 anyway.
     */
    virReportSystemError(ENOSYS, "%s",
                         _("Executing new processes is not supported on Win32 platform"));
    return -1;
}
#endif
2149

E
Eric Blake 已提交
2150 2151 2152 2153 2154
/**
 * virCommandRun:
 * @cmd: command to run
 * @exitstatus: optional status collection
 *
2155 2156 2157
 * Run the command and wait for completion.
 * Returns -1 on any error executing the
 * command. Returns 0 if the command executed,
E
Eric Blake 已提交
2158
 * with the exit status set.  If @exitstatus is NULL, then the
2159 2160 2161 2162 2163
 * child must exit with status 0 for this to succeed.  By default,
 * a non-NULL @exitstatus contains the normal exit status of the child
 * (death from a signal is treated as execution error); but if
 * virCommandRawStatus() was used, it instead contains the raw exit
 * status that the caller must then decipher using WIFEXITED() and friends.
2164 2165 2166 2167 2168 2169 2170
 */
int
virCommandRun(virCommandPtr cmd, int *exitstatus)
{
    int ret = 0;
    char *outbuf = NULL;
    char *errbuf = NULL;
2171 2172 2173
    struct stat st;
    bool string_io;
    bool async_io = false;
2174
    char *str;
2175
    int tmpfd;
2176

2177 2178
    if (!cmd ||cmd->has_error == ENOMEM) {
        virReportOOMError();
2179 2180
        return -1;
    }
2181
    if (cmd->has_error) {
2182 2183
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("invalid use of command API"));
2184 2185 2186
        return -1;
    }

2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203
    /* Avoid deadlock, by requiring that any open fd not under our
     * control must be visiting a regular file, or that we are
     * daemonized and no string io is required.  */
    string_io = cmd->inbuf || cmd->outbuf || cmd->errbuf;
    if (cmd->infd != -1 &&
        (fstat(cmd->infd, &st) < 0 || !S_ISREG(st.st_mode)))
        async_io = true;
    if (cmd->outfdptr && cmd->outfdptr != &cmd->outfd &&
        (*cmd->outfdptr == -1 ||
         fstat(*cmd->outfdptr, &st) < 0 || !S_ISREG(st.st_mode)))
        async_io = true;
    if (cmd->errfdptr && cmd->errfdptr != &cmd->errfd &&
        (*cmd->errfdptr == -1 ||
         fstat(*cmd->errfdptr, &st) < 0 || !S_ISREG(st.st_mode)))
        async_io = true;
    if (async_io) {
        if (!(cmd->flags & VIR_EXEC_DAEMON) || string_io) {
2204 2205
            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                           _("cannot mix caller fds with blocking execution"));
2206 2207 2208 2209
            return -1;
        }
    } else {
        if ((cmd->flags & VIR_EXEC_DAEMON) && string_io) {
2210 2211
            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                           _("cannot mix string I/O with daemon"));
2212 2213 2214 2215
            return -1;
        }
    }

2216 2217 2218 2219 2220 2221 2222
    /* If caller requested the same string for stdout and stderr, then
     * merge those into one string.  */
    if (cmd->outbuf && cmd->outbuf == cmd->errbuf) {
        cmd->errfdptr = &cmd->outfd;
        cmd->errbuf = NULL;
    }

2223
    /* If caller hasn't requested capture of stdout/err, then capture
2224 2225 2226
     * it ourselves so we can log it.  But the intermediate child for
     * a daemon has no expected output, and we don't want our
     * capturing pipes passed on to the daemon grandchild.
2227
     */
2228 2229 2230 2231 2232 2233 2234 2235 2236 2237 2238
    if (!(cmd->flags & VIR_EXEC_DAEMON)) {
        if (!cmd->outfdptr) {
            cmd->outfdptr = &cmd->outfd;
            cmd->outbuf = &outbuf;
            string_io = true;
        }
        if (!cmd->errfdptr) {
            cmd->errfdptr = &cmd->errfd;
            cmd->errbuf = &errbuf;
            string_io = true;
        }
2239 2240
    }

2241
    cmd->flags |= VIR_EXEC_RUN_SYNC;
2242 2243 2244 2245 2246
    if (virCommandRunAsync(cmd, NULL) < 0) {
        cmd->has_error = -1;
        return -1;
    }

2247 2248 2249 2250
    if (string_io) {
        VIR_FORCE_CLOSE(cmd->infd);
        ret = virCommandProcessIO(cmd);
    }
2251 2252 2253 2254

    if (virCommandWait(cmd, exitstatus) < 0)
        ret = -1;

2255
    str = (exitstatus ? virProcessTranslateStatus(*exitstatus)
2256 2257 2258
           : (char *) "status 0");
    VIR_DEBUG("Result %s, stdout: '%s' stderr: '%s'",
              NULLSTR(str),
2259 2260
              cmd->outbuf ? NULLSTR(*cmd->outbuf) : "(null)",
              cmd->errbuf ? NULLSTR(*cmd->errbuf) : "(null)");
2261 2262
    if (exitstatus)
        VIR_FREE(str);
2263 2264 2265

    /* Reset any capturing, in case caller runs
     * this identical command again */
2266
    VIR_FORCE_CLOSE(cmd->inpipe);
2267
    if (cmd->outbuf == &outbuf) {
2268
        tmpfd = cmd->outfd;
2269 2270 2271 2272
        if (VIR_CLOSE(cmd->outfd) < 0)
            VIR_DEBUG("ignoring failed close on fd %d", tmpfd);
        cmd->outfdptr = NULL;
        cmd->outbuf = NULL;
E
Eric Blake 已提交
2273
        VIR_FREE(outbuf);
2274 2275
    }
    if (cmd->errbuf == &errbuf) {
2276
        tmpfd = cmd->errfd;
2277 2278 2279 2280
        if (VIR_CLOSE(cmd->errfd) < 0)
            VIR_DEBUG("ignoring failed close on fd %d", tmpfd);
        cmd->errfdptr = NULL;
        cmd->errbuf = NULL;
E
Eric Blake 已提交
2281
        VIR_FREE(errbuf);
2282 2283 2284 2285 2286 2287
    }

    return ret;
}


2288
static void
2289
virCommandDoAsyncIOHelper(void *opaque)
2290
{
2291 2292 2293 2294
    virCommandPtr cmd = opaque;
    if (virCommandProcessIO(cmd) < 0) {
        /* If something went wrong, save errno or -1*/
        cmd->has_error = errno ? errno : -1;
2295 2296 2297 2298
    }
}


E
Eric Blake 已提交
2299 2300 2301 2302 2303
/**
 * virCommandRunAsync:
 * @cmd: command to start
 * @pid: optional variable to track child pid
 *
2304 2305 2306
 * Run the command asynchronously
 * Returns -1 on any error executing the
 * command. Returns 0 if the command executed.
2307 2308 2309 2310 2311 2312 2313 2314 2315 2316
 *
 * There are two approaches to child process cleanup.
 * 1. Use auto-cleanup, by passing NULL for pid.  The child will be
 * auto-reaped by virCommandFree, unless you reap it earlier via
 * virCommandWait or virCommandAbort.  Good for where cmd is in
 * scope for the duration of the child process.
 * 2. Use manual cleanup, by passing the address of a pid_t variable
 * for pid.  While cmd is still in scope, you may reap the child via
 * virCommandWait or virCommandAbort.  But after virCommandFree, if
 * you have not yet reaped the child, then it continues to run until
2317
 * you call virProcessWait or virProcessAbort.
2318 2319 2320 2321
 */
int
virCommandRunAsync(virCommandPtr cmd, pid_t *pid)
{
2322
    int ret = -1;
2323
    char *str = NULL;
2324
    size_t i;
2325
    bool synchronous = false;
2326
    int infd[2] = {-1, -1};
2327

2328 2329
    if (!cmd || cmd->has_error == ENOMEM) {
        virReportOOMError();
2330 2331
        return -1;
    }
2332
    if (cmd->has_error) {
2333 2334
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("invalid use of command API"));
2335 2336 2337
        return -1;
    }

2338 2339 2340
    synchronous = cmd->flags & VIR_EXEC_RUN_SYNC;
    cmd->flags &= ~VIR_EXEC_RUN_SYNC;

2341 2342 2343 2344 2345 2346 2347 2348 2349
    /* Buffer management can only be requested via virCommandRun or
     * virCommandDoAsyncIO. */
    if (cmd->inbuf && cmd->infd == -1 &&
        (synchronous || cmd->flags & VIR_EXEC_ASYNC_IO)) {
        if (pipe2(infd, O_CLOEXEC) < 0) {
            virReportSystemError(errno, "%s",
                                 _("unable to open pipe"));
            cmd->has_error = -1;
            return -1;
2350
        }
2351 2352
        cmd->infd = infd[0];
        cmd->inpipe = infd[1];
2353
    } else if ((cmd->inbuf && cmd->infd == -1) ||
2354 2355
               (cmd->outbuf && cmd->outfdptr != &cmd->outfd) ||
               (cmd->errbuf && cmd->errfdptr != &cmd->errfd)) {
2356 2357
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("cannot mix string I/O with asynchronous command"));
2358 2359 2360
        return -1;
    }

2361
    if (cmd->pid != -1) {
2362 2363 2364
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("command is already running as pid %lld"),
                       (long long) cmd->pid);
2365
        goto cleanup;
2366 2367
    }

2368
    if (!synchronous && (cmd->flags & VIR_EXEC_DAEMON)) {
2369 2370
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("daemonized command cannot use virCommandRunAsync"));
2371
        goto cleanup;
2372
    }
2373
    if (cmd->pwd && (cmd->flags & VIR_EXEC_DAEMON)) {
2374 2375 2376
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("daemonized command cannot set working directory %s"),
                       cmd->pwd);
2377
        goto cleanup;
2378
    }
2379
    if (cmd->pidfile && !(cmd->flags & VIR_EXEC_DAEMON)) {
2380 2381
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("creation of pid file requires daemonized command"));
2382
        goto cleanup;
2383
    }
2384 2385

    str = virCommandToString(cmd);
2386 2387
    if (dryRunBuffer || dryRunCallback) {
        dryRunStatus = 0;
2388 2389 2390 2391 2392
        if (!str) {
            /* error already reported by virCommandToString */
            goto cleanup;
        }

2393 2394 2395 2396 2397 2398 2399 2400 2401 2402 2403 2404
        if (dryRunBuffer) {
            VIR_DEBUG("Dry run requested, appending stringified "
                      "command to dryRunBuffer=%p", dryRunBuffer);
            virBufferAdd(dryRunBuffer, str, -1);
            virBufferAddChar(dryRunBuffer, '\n');
        }
        if (dryRunCallback) {
            dryRunCallback((const char *const*)cmd->args,
                           (const char *const*)cmd->env,
                           cmd->inbuf, cmd->outbuf, cmd->errbuf,
                           &dryRunStatus, dryRunOpaque);
        }
2405 2406 2407
        ret = 0;
        goto cleanup;
    }
2408

2409
    VIR_DEBUG("About to run %s", str ? str : cmd->args[0]);
2410
    ret = virExec(cmd);
2411 2412 2413
    VIR_DEBUG("Command result %d, with PID %d",
              ret, (int)cmd->pid);

2414 2415 2416
    for (i = 0; i < cmd->npassfd; i++) {
        if (cmd->passfd[i].flags & VIR_COMMAND_PASS_FD_CLOSE_PARENT)
            VIR_FORCE_CLOSE(cmd->passfd[i].fd);
2417
    }
2418 2419
    cmd->npassfd = 0;
    VIR_FREE(cmd->passfd);
2420 2421 2422

    if (ret == 0 && pid)
        *pid = cmd->pid;
2423 2424
    else
        cmd->reap = true;
2425

2426
    if (ret == 0 && cmd->flags & VIR_EXEC_ASYNC_IO) {
2427
        if (cmd->inbuf)
2428
            VIR_FORCE_CLOSE(cmd->infd);
2429 2430 2431 2432 2433 2434 2435 2436 2437 2438 2439
        /* clear any error so we can catch if the helper thread reports one */
        cmd->has_error = 0;
        if (VIR_ALLOC(cmd->asyncioThread) < 0 ||
            virThreadCreate(cmd->asyncioThread, true,
                            virCommandDoAsyncIOHelper, cmd) < 0) {
            virReportSystemError(errno, "%s",
                                 _("Unable to create thread "
                                   "to process command's IO"));
            VIR_FREE(cmd->asyncioThread);
            virCommandAbort(cmd);
            ret = -1;
2440 2441 2442
        }
    }

2443
 cleanup:
2444 2445 2446 2447
    if (ret < 0) {
        VIR_FORCE_CLOSE(cmd->infd);
        VIR_FORCE_CLOSE(cmd->inpipe);
    }
2448
    VIR_FREE(str);
2449 2450 2451 2452
    return ret;
}


E
Eric Blake 已提交
2453 2454 2455 2456 2457 2458 2459
/**
 * virCommandWait:
 * @cmd: command to wait on
 * @exitstatus: optional status collection
 *
 * Wait for the command previously started with virCommandRunAsync()
 * to complete. Return -1 on any error waiting for
2460
 * completion. Returns 0 if the command
E
Eric Blake 已提交
2461
 * finished with the exit status set.  If @exitstatus is NULL, then the
2462 2463 2464 2465 2466
 * child must exit with status 0 for this to succeed.  By default,
 * a non-NULL @exitstatus contains the normal exit status of the child
 * (death from a signal is treated as execution error); but if
 * virCommandRawStatus() was used, it instead contains the raw exit
 * status that the caller must then decipher using WIFEXITED() and friends.
2467 2468 2469 2470 2471
 */
int
virCommandWait(virCommandPtr cmd, int *exitstatus)
{
    int ret;
2472
    int status = 0;
2473

2474 2475
    if (!cmd ||cmd->has_error == ENOMEM) {
        virReportOOMError();
2476 2477
        return -1;
    }
2478
    if (cmd->has_error) {
2479 2480
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("invalid use of command API"));
2481 2482 2483
        return -1;
    }

2484 2485 2486
    if (dryRunBuffer || dryRunCallback) {
        VIR_DEBUG("Dry run requested, returning status %d",
                  dryRunStatus);
2487
        if (exitstatus)
2488
            *exitstatus = dryRunStatus;
2489 2490 2491
        return 0;
    }

2492
    if (cmd->pid == -1) {
2493 2494
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("command is not yet running"));
2495 2496 2497
        return -1;
    }

2498
    /* If virProcessWait reaps pid but then returns failure because
2499 2500 2501
     * exitstatus was NULL, then a second virCommandWait would risk
     * calling waitpid on an unrelated process.  Besides, that error
     * message is not as detailed as what we can provide.  So, we
2502
     * guarantee that virProcessWait only fails due to failure to wait,
2503
     * and repeat the exitstatus check code ourselves.  */
2504
    ret = virProcessWait(cmd->pid, &status, true);
2505 2506 2507 2508 2509 2510 2511 2512 2513 2514 2515 2516 2517
    if (cmd->flags & VIR_EXEC_ASYNC_IO) {
        cmd->flags &= ~VIR_EXEC_ASYNC_IO;
        virThreadJoin(cmd->asyncioThread);
        VIR_FREE(cmd->asyncioThread);
        VIR_FORCE_CLOSE(cmd->inpipe);
        if (cmd->has_error) {
            const char *msg = _("Error while processing command's IO");
            if (cmd->has_error < 0)
                virReportError(VIR_ERR_INTERNAL_ERROR, "%s", msg);
            else
                virReportSystemError(cmd->has_error, "%s", msg);
            ret = -1;
        }
2518
    }
2519 2520 2521
    if (ret == 0) {
        cmd->pid = -1;
        cmd->reap = false;
2522 2523 2524
        if (exitstatus && (cmd->rawStatus || WIFEXITED(status))) {
            *exitstatus = cmd->rawStatus ? status : WEXITSTATUS(status);
        } else if (status) {
2525
            char *str = virCommandToString(cmd);
2526
            char *st = virProcessTranslateStatus(status);
2527 2528
            bool haveErrMsg = cmd->errbuf && *cmd->errbuf && (*cmd->errbuf)[0];

2529
            virReportError(VIR_ERR_INTERNAL_ERROR,
2530 2531 2532 2533
                           _("Child process (%s) unexpected %s%s%s"),
                           str ? str : cmd->args[0], NULLSTR(st),
                           haveErrMsg ? ": " : "",
                           haveErrMsg ? *cmd->errbuf : "");
2534
            VIR_FREE(str);
2535
            VIR_FREE(st);
2536 2537 2538 2539
            return -1;
        }
    }

2540
    return ret;
2541 2542 2543
}


E
Eric Blake 已提交
2544
#ifndef WIN32
E
Eric Blake 已提交
2545 2546 2547 2548
/**
 * virCommandAbort:
 * @cmd: command to abort
 *
2549 2550 2551 2552 2553 2554 2555 2556 2557 2558
 * Abort an async command if it is running, without issuing
 * any errors or affecting errno.  Designed for error paths
 * where some but not all paths to the cleanup code might
 * have started the child process.
 */
void
virCommandAbort(virCommandPtr cmd)
{
    if (!cmd || cmd->pid == -1)
        return;
2559
    virProcessAbort(cmd->pid);
2560 2561 2562
    cmd->pid = -1;
    cmd->reap = false;
}
E
Eric Blake 已提交
2563 2564 2565 2566 2567
#else /* WIN32 */
void
virCommandAbort(virCommandPtr cmd ATTRIBUTE_UNUSED)
{
    /* Mingw lacks WNOHANG and kill().  But since we haven't ported
2568
     * virExec to mingw yet, there's no process to be killed,
E
Eric Blake 已提交
2569 2570 2571
     * making this implementation trivially correct for now :)  */
}
#endif
2572

2573

E
Eric Blake 已提交
2574 2575 2576 2577 2578 2579 2580 2581 2582
/**
 * virCommandRequireHandshake:
 * @cmd: command to modify
 *
 * Request that the child perform a handshake with
 * the parent when the hook function has completed
 * execution. The child will not exec() until the
 * parent has notified
 */
2583 2584 2585 2586 2587 2588 2589 2590 2591 2592 2593
void virCommandRequireHandshake(virCommandPtr cmd)
{
    if (!cmd || cmd->has_error)
        return;

    if (cmd->handshake) {
        cmd->has_error = -1;
        VIR_DEBUG("Cannot require handshake twice");
        return;
    }

2594
    if (pipe2(cmd->handshakeWait, O_CLOEXEC) < 0) {
2595 2596 2597
        cmd->has_error = errno;
        return;
    }
2598
    if (pipe2(cmd->handshakeNotify, O_CLOEXEC) < 0) {
2599 2600 2601 2602 2603 2604
        VIR_FORCE_CLOSE(cmd->handshakeWait[0]);
        VIR_FORCE_CLOSE(cmd->handshakeWait[1]);
        cmd->has_error = errno;
        return;
    }

2605 2606 2607 2608
    VIR_DEBUG("Transfer handshake wait=%d notify=%d, "
              "keep handshake wait=%d notify=%d",
              cmd->handshakeWait[1], cmd->handshakeNotify[0],
              cmd->handshakeWait[0], cmd->handshakeNotify[1]);
2609 2610 2611 2612
    virCommandPassFD(cmd, cmd->handshakeWait[1],
                     VIR_COMMAND_PASS_FD_CLOSE_PARENT);
    virCommandPassFD(cmd, cmd->handshakeNotify[0],
                     VIR_COMMAND_PASS_FD_CLOSE_PARENT);
2613 2614 2615
    cmd->handshake = true;
}

E
Eric Blake 已提交
2616 2617 2618 2619 2620 2621 2622
/**
 * virCommandHandshakeWait:
 * @cmd: command to wait on
 *
 * Wait for the child to complete execution of its
 * hook function.  To be called in the parent.
 */
2623 2624 2625 2626 2627 2628 2629 2630 2631
int virCommandHandshakeWait(virCommandPtr cmd)
{
    char c;
    int rv;
    if (!cmd ||cmd->has_error == ENOMEM) {
        virReportOOMError();
        return -1;
    }
    if (cmd->has_error || !cmd->handshake) {
2632 2633
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("invalid use of command API"));
2634 2635 2636 2637
        return -1;
    }

    if (cmd->handshakeWait[0] == -1) {
2638 2639
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("Handshake is already complete"));
2640 2641 2642 2643 2644 2645
        return -1;
    }

    VIR_DEBUG("Wait for handshake on %d", cmd->handshakeWait[0]);
    if ((rv = saferead(cmd->handshakeWait[0], &c, sizeof(c))) != sizeof(c)) {
        if (rv < 0)
2646 2647
            virReportSystemError(errno, "%s",
                                 _("Unable to wait for child process"));
2648
        else
2649 2650
            virReportSystemError(EIO, "%s",
                                 _("Child quit during startup handshake"));
2651 2652 2653 2654 2655 2656 2657 2658 2659 2660
        VIR_FORCE_CLOSE(cmd->handshakeWait[0]);
        return -1;
    }
    if (c != '1') {
        char *msg;
        ssize_t len;
        if (VIR_ALLOC_N(msg, 1024) < 0) {
            VIR_FORCE_CLOSE(cmd->handshakeWait[0]);
            return -1;
        }
2661 2662 2663 2664 2665
        /* Close the handshakeNotify fd before trying to read anything
         * further on the handshakeWait pipe; so that a child waiting
         * on our acknowledgment will die rather than deadlock.  */
        VIR_FORCE_CLOSE(cmd->handshakeNotify[1]);

2666 2667 2668
        if ((len = saferead(cmd->handshakeWait[0], msg, 1024)) < 0) {
            VIR_FORCE_CLOSE(cmd->handshakeWait[0]);
            VIR_FREE(msg);
2669 2670
            virReportSystemError(errno, "%s",
                                 _("No error message from child failure"));
2671 2672 2673 2674
            return -1;
        }
        VIR_FORCE_CLOSE(cmd->handshakeWait[0]);
        msg[len-1] = '\0';
2675
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", msg);
2676 2677 2678 2679 2680 2681 2682
        VIR_FREE(msg);
        return -1;
    }
    VIR_FORCE_CLOSE(cmd->handshakeWait[0]);
    return 0;
}

E
Eric Blake 已提交
2683 2684 2685 2686 2687 2688 2689
/**
 * virCommandHandshakeNotify:
 * @cmd: command to resume
 *
 * Notify the child that it is OK to exec() the
 * real binary now.  To be called in the parent.
 */
2690 2691 2692 2693 2694 2695 2696 2697
int virCommandHandshakeNotify(virCommandPtr cmd)
{
    char c = '1';
    if (!cmd ||cmd->has_error == ENOMEM) {
        virReportOOMError();
        return -1;
    }
    if (cmd->has_error || !cmd->handshake) {
2698 2699
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("invalid use of command API"));
2700 2701 2702 2703
        return -1;
    }

    if (cmd->handshakeNotify[1] == -1) {
2704 2705
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("Handshake is already complete"));
2706 2707 2708
        return -1;
    }

2709
    VIR_DEBUG("Notify handshake on %d", cmd->handshakeNotify[1]);
2710 2711 2712 2713 2714 2715 2716 2717 2718 2719
    if (safewrite(cmd->handshakeNotify[1], &c, sizeof(c)) != sizeof(c)) {
        virReportSystemError(errno, "%s", _("Unable to notify child process"));
        VIR_FORCE_CLOSE(cmd->handshakeNotify[1]);
        return -1;
    }
    VIR_FORCE_CLOSE(cmd->handshakeNotify[1]);
    return 0;
}


E
Eric Blake 已提交
2720 2721 2722 2723
/**
 * virCommandFree:
 * @cmd: optional command to free
 *
2724 2725
 * Release all resources.  The only exception is that if you called
 * virCommandRunAsync with a non-null pid, then the asynchronous child
2726
 * is not reaped, and you must call virProcessWait() or virProcessAbort() yourself.
2727 2728 2729 2730
 */
void
virCommandFree(virCommandPtr cmd)
{
2731
    size_t i;
2732 2733 2734
    if (!cmd)
        return;

2735 2736 2737
    for (i = 0; i < cmd->npassfd; i++) {
        if (cmd->passfd[i].flags & VIR_COMMAND_PASS_FD_CLOSE_PARENT)
            VIR_FORCE_CLOSE(cmd->passfd[i].fd);
2738
    }
2739 2740
    cmd->npassfd = 0;
    VIR_FREE(cmd->passfd);
2741

2742 2743 2744 2745
    if (cmd->asyncioThread) {
        virThreadJoin(cmd->asyncioThread);
        VIR_FREE(cmd->asyncioThread);
    }
E
Eric Blake 已提交
2746
    VIR_FREE(cmd->inbuf);
2747 2748 2749
    VIR_FORCE_CLOSE(cmd->outfd);
    VIR_FORCE_CLOSE(cmd->errfd);

2750
    for (i = 0; i < cmd->nargs; i++)
2751 2752 2753
        VIR_FREE(cmd->args[i]);
    VIR_FREE(cmd->args);

2754
    for (i = 0; i < cmd->nenv; i++)
2755 2756 2757 2758 2759
        VIR_FREE(cmd->env[i]);
    VIR_FREE(cmd->env);

    VIR_FREE(cmd->pwd);

2760 2761
    if (cmd->handshake) {
        /* The other 2 fds in these arrays are closed
2762
         * due to use with virCommandPassFD
2763 2764 2765 2766 2767
         */
        VIR_FORCE_CLOSE(cmd->handshakeWait[0]);
        VIR_FORCE_CLOSE(cmd->handshakeNotify[1]);
    }

2768 2769
    VIR_FREE(cmd->pidfile);

2770 2771 2772
    if (cmd->reap)
        virCommandAbort(cmd);

2773 2774 2775 2776 2777 2778
#if defined(WITH_SECDRIVER_SELINUX)
    VIR_FREE(cmd->seLinuxLabel);
#endif
#if defined(WITH_SECDRIVER_APPARMOR)
    VIR_FREE(cmd->appArmorProfile);
#endif
2779

2780 2781
    VIR_FREE(cmd);
}
2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828

/**
 * virCommandDoAsyncIO:
 * @cmd: command to do async IO on
 *
 * This requests asynchronous string IO on @cmd. It is useful in
 * combination with virCommandRunAsync():
 *
 *      virCommandPtr cmd = virCommandNew*(...);
 *      char *buf = NULL;
 *
 *      ...
 *
 *      virCommandSetOutputBuffer(cmd, &buf);
 *      virCommandDoAsyncIO(cmd);
 *
 *      if (virCommandRunAsync(cmd, NULL) < 0)
 *          goto cleanup;
 *
 *      ...
 *
 *      if (virCommandWait(cmd, NULL) < 0)
 *          goto cleanup;
 *
 *      // @buf now contains @cmd's stdout
 *      VIR_DEBUG("STDOUT: %s", NULLSTR(buf));
 *
 *      ...
 *
 *  cleanup:
 *      VIR_FREE(buf);
 *      virCommandFree(cmd);
 *
 * The libvirt's event loop is used for handling stdios of @cmd.
 * Since current implementation uses strlen to determine length
 * of data to be written to @cmd's stdin, don't pass any binary
 * data. If you want to re-run command, you need to call this and
 * buffer setting functions (virCommandSet.*Buffer) prior each run.
 */
void
virCommandDoAsyncIO(virCommandPtr cmd)
{
   if (!cmd || cmd->has_error)
       return;

   cmd->flags |= VIR_EXEC_ASYNC_IO | VIR_EXEC_NONBLOCK;
}
2829 2830 2831 2832

/**
 * virCommandSetDryRun:
 * @buf: buffer to store stringified commands
2833
 * @callback: callback to process input/output/args
2834 2835 2836 2837 2838 2839 2840 2841
 *
 * Sometimes it's desired to not actually run given command, but
 * see its string representation without having to change the
 * callee. Unit testing serves as a great example. In such cases,
 * the callee constructs the command and calls it via
 * virCommandRun* API. The virCommandSetDryRun allows you to
 * modify this behavior: once called, every call to
 * virCommandRun* results in command string representation being
2842 2843 2844 2845 2846 2847 2848
 * appended to @buf instead of being executed. If @callback is
 * provided, then it is invoked with the argv, env and stdin
 * data string for the command. It is expected to fill the stdout
 * and stderr data strings and exit status variables.
 *
 * The strings stored in @buf are escaped for a shell and
 * separated by a newline. For example:
2849 2850 2851 2852 2853 2854 2855 2856 2857 2858 2859
 *
 * virBuffer buffer = VIR_BUFFER_INITIALIZER;
 * virCommandSetDryRun(&buffer);
 *
 * virCommandPtr echocmd = virCommandNewArgList("/bin/echo", "Hello world", NULL);
 * virCommandRun(echocmd, NULL);
 *
 * After this, the @buffer should contain:
 *
 * /bin/echo 'Hello world'\n
 *
2860
 * To cancel this effect pass NULL for @buf and @callback.
2861 2862
 */
void
2863 2864 2865
virCommandSetDryRun(virBufferPtr buf,
                    virCommandDryRunCallback cb,
                    void *opaque)
2866 2867
{
    dryRunBuffer = buf;
2868 2869
    dryRunCallback = cb;
    dryRunOpaque = opaque;
2870
}
2871 2872 2873 2874 2875 2876 2877 2878 2879 2880 2881 2882 2883 2884 2885 2886 2887 2888

#ifndef WIN32
/*
 * Run an external program.
 *
 * Read its output and apply a series of regexes to each line
 * When the entire set of regexes has matched consecutively
 * then run a callback passing in all the matches
 */
int
virCommandRunRegex(virCommandPtr cmd,
                   int nregex,
                   const char **regex,
                   int *nvars,
                   virCommandRunRegexFunc func,
                   void *data,
                   const char *prefix)
{
2889
    int err;
2890 2891
    regex_t *reg;
    regmatch_t *vars = NULL;
2892
    size_t i, j, k;
2893 2894
    int totgroups = 0, ngroup = 0, maxvars = 0;
    char **groups;
2895 2896 2897
    char *outbuf = NULL;
    char **lines = NULL;
    int ret = -1;
2898 2899 2900 2901 2902 2903 2904 2905 2906 2907 2908 2909 2910 2911 2912 2913 2914 2915 2916 2917 2918 2919 2920 2921 2922 2923 2924 2925 2926 2927

    /* Compile all regular expressions */
    if (VIR_ALLOC_N(reg, nregex) < 0)
        return -1;

    for (i = 0; i < nregex; i++) {
        err = regcomp(&reg[i], regex[i], REG_EXTENDED);
        if (err != 0) {
            char error[100];
            regerror(err, &reg[i], error, sizeof(error));
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           _("Failed to compile regex %s"), error);
            for (j = 0; j < i; j++)
                regfree(&reg[j]);
            VIR_FREE(reg);
            return -1;
        }

        totgroups += nvars[i];
        if (nvars[i] > maxvars)
            maxvars = nvars[i];

    }

    /* Storage for matched variables */
    if (VIR_ALLOC_N(groups, totgroups) < 0)
        goto cleanup;
    if (VIR_ALLOC_N(vars, maxvars+1) < 0)
        goto cleanup;

2928 2929
    virCommandSetOutputBuffer(cmd, &outbuf);
    if (virCommandRun(cmd, NULL) < 0)
2930 2931
        goto cleanup;

2932 2933 2934
    if (!outbuf) {
        /* no output */
        ret = 0;
2935 2936 2937
        goto cleanup;
    }

2938 2939 2940 2941
    if (!(lines = virStringSplit(outbuf, "\n", 0)))
        goto cleanup;

    for (k = 0; lines[k]; k++) {
2942
        const char *p = NULL;
2943 2944 2945

        /* ignore any command prefix */
        if (prefix)
2946
            p = STRSKIP(lines[k], prefix);
2947
        if (!p)
2948
            p = lines[k];
2949

2950
        ngroup = 0;
J
Ján Tomko 已提交
2951 2952 2953
        for (i = 0; i < nregex; i++) {
            if (regexec(&reg[i], p, nvars[i]+1, vars, 0) != 0)
                break;
2954

2955 2956 2957 2958
            /* NB vars[0] is the full pattern, so we offset j by 1 */
            for (j = 1; j <= nvars[i]; j++) {
                if (VIR_STRNDUP(groups[ngroup++], p + vars[j].rm_so,
                                vars[j].rm_eo - vars[j].rm_so) < 0)
J
Ján Tomko 已提交
2959 2960
                    goto cleanup;
            }
2961

2962 2963 2964 2965 2966
        }
        /* We've matched on the last regex, so callback time */
        if (i == nregex) {
            if (((*func)(groups, data)) < 0)
                goto cleanup;
2967
        }
2968 2969 2970

        for (j = 0; j < ngroup; j++)
            VIR_FREE(groups[j]);
2971 2972
    }

2973
    ret = 0;
2974
 cleanup:
2975 2976
    virStringFreeList(lines);
    VIR_FREE(outbuf);
2977 2978 2979 2980 2981 2982 2983 2984 2985 2986 2987 2988 2989 2990 2991 2992 2993 2994 2995 2996 2997 2998 2999 3000 3001 3002 3003 3004 3005 3006 3007 3008 3009 3010 3011 3012 3013 3014 3015 3016 3017 3018 3019 3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041 3042 3043 3044 3045 3046 3047 3048 3049 3050 3051 3052 3053 3054 3055 3056 3057 3058 3059 3060 3061 3062 3063 3064 3065 3066 3067 3068 3069 3070 3071 3072 3073 3074 3075 3076 3077 3078 3079 3080 3081 3082 3083 3084 3085 3086 3087 3088 3089 3090 3091 3092 3093 3094 3095 3096 3097 3098 3099 3100 3101 3102 3103
    if (groups) {
        for (j = 0; j < totgroups; j++)
            VIR_FREE(groups[j]);
        VIR_FREE(groups);
    }
    VIR_FREE(vars);

    for (i = 0; i < nregex; i++)
        regfree(&reg[i]);

    VIR_FREE(reg);
    return ret;
}

/*
 * Run an external program and read from its standard output
 * a stream of tokens from IN_STREAM, applying FUNC to
 * each successive sequence of N_COLUMNS tokens.
 * If FUNC returns < 0, stop processing input and return -1.
 * Return -1 if N_COLUMNS == 0.
 * Return -1 upon memory allocation error.
 * If the number of input tokens is not a multiple of N_COLUMNS,
 * then the final FUNC call will specify a number smaller than N_COLUMNS.
 * If there are no input tokens (empty input), call FUNC with N_COLUMNS == 0.
 */
int
virCommandRunNul(virCommandPtr cmd,
                 size_t n_columns,
                 virCommandRunNulFunc func,
                 void *data)
{
    size_t n_tok = 0;
    int fd = -1;
    FILE *fp = NULL;
    char **v;
    int ret = -1;
    size_t i;

    if (n_columns == 0)
        return -1;

    if (VIR_ALLOC_N(v, n_columns) < 0)
        return -1;
    for (i = 0; i < n_columns; i++)
        v[i] = NULL;

    virCommandSetOutputFD(cmd, &fd);
    if (virCommandRunAsync(cmd, NULL) < 0) {
        goto cleanup;
    }

    if ((fp = VIR_FDOPEN(fd, "r")) == NULL) {
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       "%s", _("cannot open file using fd"));
        goto cleanup;
    }

    while (1) {
        char *buf = NULL;
        size_t buf_len = 0;
        /* Be careful: even when it returns -1,
           this use of getdelim allocates memory.  */
        ssize_t tok_len = getdelim(&buf, &buf_len, 0, fp);
        v[n_tok] = buf;
        if (tok_len < 0) {
            /* Maybe EOF, maybe an error.
               If n_tok > 0, then we know it's an error.  */
            if (n_tok && func(n_tok, v, data) < 0)
                goto cleanup;
            break;
        }
        ++n_tok;
        if (n_tok == n_columns) {
            if (func(n_tok, v, data) < 0)
                goto cleanup;
            n_tok = 0;
            for (i = 0; i < n_columns; i++) {
                VIR_FREE(v[i]);
            }
        }
    }

    if (feof(fp) < 0) {
        virReportSystemError(errno, "%s",
                             _("read error on pipe"));
        goto cleanup;
    }

    ret = virCommandWait(cmd, NULL);
 cleanup:
    for (i = 0; i < n_columns; i++)
        VIR_FREE(v[i]);
    VIR_FREE(v);

    VIR_FORCE_FCLOSE(fp);
    VIR_FORCE_CLOSE(fd);

    return ret;
}

#else /* WIN32 */

int
virCommandRunRegex(virCommandPtr cmd ATTRIBUTE_UNUSED,
                   int nregex ATTRIBUTE_UNUSED,
                   const char **regex ATTRIBUTE_UNUSED,
                   int *nvars ATTRIBUTE_UNUSED,
                   virCommandRunRegexFunc func ATTRIBUTE_UNUSED,
                   void *data ATTRIBUTE_UNUSED,
                   const char *prefix ATTRIBUTE_UNUSED)
{
    virReportError(VIR_ERR_INTERNAL_ERROR,
                   _("%s not implemented on Win32"), __FUNCTION__);
    return -1;
}

int
virCommandRunNul(virCommandPtr cmd ATTRIBUTE_UNUSED,
                 size_t n_columns ATTRIBUTE_UNUSED,
                 virCommandRunNulFunc func ATTRIBUTE_UNUSED,
                 void *data ATTRIBUTE_UNUSED)
{
    virReportError(VIR_ERR_INTERNAL_ERROR,
                   _("%s not implemented on Win32"), __FUNCTION__);
    return -1;
}
#endif /* WIN32 */