qemu_domain.c 72.0 KB
Newer Older
1 2 3
/*
 * qemu_domain.h: QEMU domain private state
 *
4
 * Copyright (C) 2006-2013 Red Hat, Inc.
5 6 7 8 9 10 11 12 13 14 15 16 17
 * Copyright (C) 2006 Daniel P. Berrange
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
18
 * License along with this library.  If not, see
O
Osier Yang 已提交
19
 * <http://www.gnu.org/licenses/>.
20 21 22 23 24 25 26 27
 *
 * Author: Daniel P. Berrange <berrange@redhat.com>
 */

#include <config.h>

#include "qemu_domain.h"
#include "qemu_command.h"
28
#include "qemu_capabilities.h"
29
#include "qemu_migration.h"
30
#include "viralloc.h"
31
#include "virlog.h"
32
#include "virerror.h"
33
#include "c-ctype.h"
34
#include "cpu/cpu.h"
35
#include "viruuid.h"
E
Eric Blake 已提交
36
#include "virfile.h"
37
#include "domain_event.h"
38
#include "virtime.h"
39
#include "virstoragefile.h"
40
#include "virstring.h"
41

42
#include <sys/time.h>
43
#include <fcntl.h>
44

45 46 47 48 49 50
#include <libxml/xpathInternals.h>

#define VIR_FROM_THIS VIR_FROM_QEMU

#define QEMU_NAMESPACE_HREF "http://libvirt.org/schemas/domain/qemu/1.0"

51 52 53 54 55 56
VIR_ENUM_IMPL(qemuDomainJob, QEMU_JOB_LAST,
              "none",
              "query",
              "destroy",
              "suspend",
              "modify",
57
              "abort",
58
              "migration operation",
59 60 61 62 63 64 65 66 67 68
              "none",   /* async job is never stored in job.active */
              "async nested",
);

VIR_ENUM_IMPL(qemuDomainAsyncJob, QEMU_ASYNC_JOB_LAST,
              "none",
              "migration out",
              "migration in",
              "save",
              "dump",
69
              "snapshot",
70 71
);

72

J
Jiri Denemark 已提交
73 74 75 76 77 78 79
const char *
qemuDomainAsyncJobPhaseToString(enum qemuDomainAsyncJob job,
                                int phase ATTRIBUTE_UNUSED)
{
    switch (job) {
    case QEMU_ASYNC_JOB_MIGRATION_OUT:
    case QEMU_ASYNC_JOB_MIGRATION_IN:
80 81
        return qemuMigrationJobPhaseTypeToString(phase);

J
Jiri Denemark 已提交
82 83
    case QEMU_ASYNC_JOB_SAVE:
    case QEMU_ASYNC_JOB_DUMP:
84
    case QEMU_ASYNC_JOB_SNAPSHOT:
J
Jiri Denemark 已提交
85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102
    case QEMU_ASYNC_JOB_NONE:
    case QEMU_ASYNC_JOB_LAST:
        ; /* fall through */
    }

    return "none";
}

int
qemuDomainAsyncJobPhaseFromString(enum qemuDomainAsyncJob job,
                                  const char *phase)
{
    if (!phase)
        return 0;

    switch (job) {
    case QEMU_ASYNC_JOB_MIGRATION_OUT:
    case QEMU_ASYNC_JOB_MIGRATION_IN:
103 104
        return qemuMigrationJobPhaseTypeFromString(phase);

J
Jiri Denemark 已提交
105 106
    case QEMU_ASYNC_JOB_SAVE:
    case QEMU_ASYNC_JOB_DUMP:
107
    case QEMU_ASYNC_JOB_SNAPSHOT:
J
Jiri Denemark 已提交
108 109 110 111 112 113 114 115 116 117 118
    case QEMU_ASYNC_JOB_NONE:
    case QEMU_ASYNC_JOB_LAST:
        ; /* fall through */
    }

    if (STREQ(phase, "none"))
        return 0;
    else
        return -1;
}

119

120
void qemuDomainEventQueue(virQEMUDriverPtr driver,
121
                          virObjectEventPtr event)
122
{
123
    virObjectEventStateQueue(driver->domainEventState, event);
124 125 126
}


127 128 129 130 131 132 133 134
static int
qemuDomainObjInitJob(qemuDomainObjPrivatePtr priv)
{
    memset(&priv->job, 0, sizeof(priv->job));

    if (virCondInit(&priv->job.cond) < 0)
        return -1;

135
    if (virCondInit(&priv->job.asyncCond) < 0) {
136
        virCondDestroy(&priv->job.cond);
137 138 139
        return -1;
    }

140 141 142 143 144 145 146 147 148
    return 0;
}

static void
qemuDomainObjResetJob(qemuDomainObjPrivatePtr priv)
{
    struct qemuDomainJobObj *job = &priv->job;

    job->active = QEMU_JOB_NONE;
149
    job->owner = 0;
150 151 152 153 154 155 156 157
}

static void
qemuDomainObjResetAsyncJob(qemuDomainObjPrivatePtr priv)
{
    struct qemuDomainJobObj *job = &priv->job;

    job->asyncJob = QEMU_ASYNC_JOB_NONE;
158
    job->asyncOwner = 0;
J
Jiri Denemark 已提交
159
    job->phase = 0;
160
    job->mask = DEFAULT_JOB_MASK;
161
    job->start = 0;
162
    job->dump_memory_only = false;
163
    job->asyncAbort = false;
164
    memset(&job->status, 0, sizeof(job->status));
165 166 167
    memset(&job->info, 0, sizeof(job->info));
}

168 169 170 171 172 173 174 175
void
qemuDomainObjRestoreJob(virDomainObjPtr obj,
                        struct qemuDomainJobObj *job)
{
    qemuDomainObjPrivatePtr priv = obj->privateData;

    memset(job, 0, sizeof(*job));
    job->active = priv->job.active;
176
    job->owner = priv->job.owner;
177
    job->asyncJob = priv->job.asyncJob;
178
    job->asyncOwner = priv->job.asyncOwner;
J
Jiri Denemark 已提交
179
    job->phase = priv->job.phase;
180 181 182 183 184

    qemuDomainObjResetJob(priv);
    qemuDomainObjResetAsyncJob(priv);
}

185 186 187 188 189
void
qemuDomainObjTransferJob(virDomainObjPtr obj)
{
    qemuDomainObjPrivatePtr priv = obj->privateData;

190
    VIR_DEBUG("Changing job owner from %llu to %llu",
191 192 193 194
              priv->job.owner, virThreadSelfID());
    priv->job.owner = virThreadSelfID();
}

195 196 197
static void
qemuDomainObjFreeJob(qemuDomainObjPrivatePtr priv)
{
198 199
    virCondDestroy(&priv->job.cond);
    virCondDestroy(&priv->job.asyncCond);
200 201
}

202 203 204 205 206 207
static bool
qemuDomainTrackJob(enum qemuDomainJob job)
{
    return (QEMU_DOMAIN_TRACK_JOBS & JOB_MASK(job)) != 0;
}

208

209 210
static void *
qemuDomainObjPrivateAlloc(void)
211 212 213 214 215 216
{
    qemuDomainObjPrivatePtr priv;

    if (VIR_ALLOC(priv) < 0)
        return NULL;

217 218 219
    if (qemuDomainObjInitJob(priv) < 0) {
        virReportSystemError(errno, "%s",
                             _("Unable to init qemu driver mutexes"));
220
        goto error;
221
    }
222

223 224 225
    if (virCondInit(&priv->unplugFinished) < 0)
        goto error;

226
    if (!(priv->devs = virChrdevAlloc()))
227 228
        goto error;

229
    priv->migMaxBandwidth = QEMU_DOMAIN_MIG_BANDWIDTH_MAX;
230

231
    return priv;
232 233 234 235

error:
    VIR_FREE(priv);
    return NULL;
236 237
}

238 239
static void
qemuDomainObjPrivateFree(void *data)
240 241 242
{
    qemuDomainObjPrivatePtr priv = data;

243
    virObjectUnref(priv->qemuCaps);
244

245
    virCgroupFree(&priv->cgroup);
246
    qemuDomainPCIAddressSetFree(priv->pciaddrs);
247
    qemuDomainCCWAddressSetFree(priv->ccwaddrs);
248
    virDomainChrSourceDefFree(priv->monConfig);
249
    qemuDomainObjFreeJob(priv);
250
    VIR_FREE(priv->vcpupids);
251
    VIR_FREE(priv->lockState);
J
Jiri Denemark 已提交
252
    VIR_FREE(priv->origname);
253

254
    virCondDestroy(&priv->unplugFinished);
255
    virChrdevFree(priv->devs);
256

257 258
    /* This should never be non-NULL if we get here, but just in case... */
    if (priv->mon) {
259
        VIR_ERROR(_("Unexpected QEMU monitor still active during domain deletion"));
260 261
        qemuMonitorClose(priv->mon);
    }
D
Daniel P. Berrange 已提交
262 263 264 265
    if (priv->agent) {
        VIR_ERROR(_("Unexpected QEMU agent still active during domain deletion"));
        qemuAgentClose(priv->agent);
    }
266
    VIR_FREE(priv->cleanupCallbacks);
267 268 269 270
    VIR_FREE(priv);
}


271 272
static int
qemuDomainObjPrivateXMLFormat(virBufferPtr buf, void *data)
273 274 275
{
    qemuDomainObjPrivatePtr priv = data;
    const char *monitorpath;
276
    enum qemuDomainJob job;
277 278 279

    /* priv->monitor_chr is set only for qemu */
    if (priv->monConfig) {
280
        switch (priv->monConfig->type) {
281
        case VIR_DOMAIN_CHR_TYPE_UNIX:
282
            monitorpath = priv->monConfig->data.nix.path;
283 284 285
            break;
        default:
        case VIR_DOMAIN_CHR_TYPE_PTY:
286
            monitorpath = priv->monConfig->data.file.path;
287 288 289 290 291 292
            break;
        }

        virBufferEscapeString(buf, "  <monitor path='%s'", monitorpath);
        if (priv->monJSON)
            virBufferAddLit(buf, " json='1'");
293
        virBufferAsprintf(buf, " type='%s'/>\n",
294
                          virDomainChrTypeToString(priv->monConfig->type));
295 296 297 298
    }


    if (priv->nvcpupids) {
299
        size_t i;
300
        virBufferAddLit(buf, "  <vcpus>\n");
301
        for (i = 0; i < priv->nvcpupids; i++) {
302
            virBufferAsprintf(buf, "    <vcpu pid='%d'/>\n", priv->vcpupids[i]);
303 304 305 306
        }
        virBufferAddLit(buf, "  </vcpus>\n");
    }

307
    if (priv->qemuCaps) {
308
        size_t i;
309
        virBufferAddLit(buf, "  <qemuCaps>\n");
310
        for (i = 0; i < QEMU_CAPS_LAST; i++) {
311
            if (virQEMUCapsGet(priv->qemuCaps, i)) {
312
                virBufferAsprintf(buf, "    <flag name='%s'/>\n",
313
                                  virQEMUCapsTypeToString(i));
314 315 316 317 318
            }
        }
        virBufferAddLit(buf, "  </qemuCaps>\n");
    }

319 320 321
    if (priv->lockState)
        virBufferAsprintf(buf, "  <lockstate>%s</lockstate>\n", priv->lockState);

322 323 324 325
    job = priv->job.active;
    if (!qemuDomainTrackJob(job))
        priv->job.active = QEMU_JOB_NONE;

326
    if (priv->job.active || priv->job.asyncJob) {
J
Jiri Denemark 已提交
327
        virBufferAsprintf(buf, "  <job type='%s' async='%s'",
328 329
                          qemuDomainJobTypeToString(priv->job.active),
                          qemuDomainAsyncJobTypeToString(priv->job.asyncJob));
J
Jiri Denemark 已提交
330 331 332 333 334 335
        if (priv->job.phase) {
            virBufferAsprintf(buf, " phase='%s'",
                              qemuDomainAsyncJobPhaseToString(
                                    priv->job.asyncJob, priv->job.phase));
        }
        virBufferAddLit(buf, "/>\n");
336
    }
337
    priv->job.active = job;
338

339
    if (priv->fakeReboot)
340
        virBufferAddLit(buf, "  <fakereboot/>\n");
341

342 343 344 345 346 347 348 349 350 351
    if (priv->qemuDevices && *priv->qemuDevices) {
        char **tmp = priv->qemuDevices;
        virBufferAddLit(buf, "  <devices>\n");
        while (*tmp) {
            virBufferAsprintf(buf, "    <device alias='%s'/>\n", *tmp);
            tmp++;
        }
        virBufferAddLit(buf, "  </devices>\n");
    }

352 353 354
    return 0;
}

355 356
static int
qemuDomainObjPrivateXMLParse(xmlXPathContextPtr ctxt, void *data)
357 358 359 360
{
    qemuDomainObjPrivatePtr priv = data;
    char *monitorpath;
    char *tmp;
361 362
    int n;
    size_t i;
363
    xmlNodePtr *nodes = NULL;
364
    virQEMUCapsPtr qemuCaps = NULL;
365

366
    if (VIR_ALLOC(priv->monConfig) < 0)
367 368 369 370
        goto error;

    if (!(monitorpath =
          virXPathString("string(./monitor[1]/@path)", ctxt))) {
371 372
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       "%s", _("no monitor path"));
373 374 375 376 377
        goto error;
    }

    tmp = virXPathString("string(./monitor[1]/@type)", ctxt);
    if (tmp)
378
        priv->monConfig->type = virDomainChrTypeFromString(tmp);
379
    else
380
        priv->monConfig->type = VIR_DOMAIN_CHR_TYPE_PTY;
381 382
    VIR_FREE(tmp);

E
Eric Blake 已提交
383 384
    priv->monJSON = virXPathBoolean("count(./monitor[@json = '1']) > 0",
                                    ctxt) > 0;
385

386
    switch (priv->monConfig->type) {
387
    case VIR_DOMAIN_CHR_TYPE_PTY:
388
        priv->monConfig->data.file.path = monitorpath;
389 390
        break;
    case VIR_DOMAIN_CHR_TYPE_UNIX:
391
        priv->monConfig->data.nix.path = monitorpath;
392 393 394
        break;
    default:
        VIR_FREE(monitorpath);
395 396 397
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("unsupported monitor type '%s'"),
                       virDomainChrTypeToString(priv->monConfig->type));
398 399 400 401 402 403 404 405
        goto error;
    }

    n = virXPathNodeSet("./vcpus/vcpu", ctxt, &nodes);
    if (n < 0)
        goto error;
    if (n) {
        priv->nvcpupids = n;
406
        if (VIR_REALLOC_N(priv->vcpupids, priv->nvcpupids) < 0)
407 408
            goto error;

409
        for (i = 0; i < n; i++) {
410 411 412 413 414 415 416 417 418 419 420 421 422
            char *pidstr = virXMLPropString(nodes[i], "pid");
            if (!pidstr)
                goto error;

            if (virStrToLong_i(pidstr, NULL, 10, &(priv->vcpupids[i])) < 0) {
                VIR_FREE(pidstr);
                goto error;
            }
            VIR_FREE(pidstr);
        }
        VIR_FREE(nodes);
    }

423
    if ((n = virXPathNodeSet("./qemuCaps/flag", ctxt, &nodes)) < 0) {
424 425
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       "%s", _("failed to parse qemu capabilities flags"));
426 427 428
        goto error;
    }
    if (n > 0) {
429
        if (!(qemuCaps = virQEMUCapsNew()))
430 431
            goto error;

432
        for (i = 0; i < n; i++) {
433 434
            char *str = virXMLPropString(nodes[i], "name");
            if (str) {
435
                int flag = virQEMUCapsTypeFromString(str);
436
                if (flag < 0) {
437 438
                    virReportError(VIR_ERR_INTERNAL_ERROR,
                                   _("Unknown qemu capabilities flag %s"), str);
439
                    VIR_FREE(str);
440 441
                    goto error;
                }
442
                VIR_FREE(str);
443
                virQEMUCapsSet(qemuCaps, flag);
444 445 446
            }
        }

447
        priv->qemuCaps = qemuCaps;
448 449 450
    }
    VIR_FREE(nodes);

451
    priv->lockState = virXPathString("string(./lockstate)", ctxt);
452

453 454 455 456
    if ((tmp = virXPathString("string(./job[1]/@type)", ctxt))) {
        int type;

        if ((type = qemuDomainJobTypeFromString(tmp)) < 0) {
457 458
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           _("Unknown job type %s"), tmp);
459 460 461 462 463 464 465 466 467 468 469
            VIR_FREE(tmp);
            goto error;
        }
        VIR_FREE(tmp);
        priv->job.active = type;
    }

    if ((tmp = virXPathString("string(./job[1]/@async)", ctxt))) {
        int async;

        if ((async = qemuDomainAsyncJobTypeFromString(tmp)) < 0) {
470 471
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           _("Unknown async job type %s"), tmp);
472 473 474 475 476
            VIR_FREE(tmp);
            goto error;
        }
        VIR_FREE(tmp);
        priv->job.asyncJob = async;
J
Jiri Denemark 已提交
477 478 479 480

        if ((tmp = virXPathString("string(./job[1]/@phase)", ctxt))) {
            priv->job.phase = qemuDomainAsyncJobPhaseFromString(async, tmp);
            if (priv->job.phase < 0) {
481 482
                virReportError(VIR_ERR_INTERNAL_ERROR,
                               _("Unknown job phase %s"), tmp);
J
Jiri Denemark 已提交
483 484 485 486 487
                VIR_FREE(tmp);
                goto error;
            }
            VIR_FREE(tmp);
        }
488 489
    }

490 491
    priv->fakeReboot = virXPathBoolean("boolean(./fakereboot)", ctxt) == 1;

492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512
    if ((n = virXPathNodeSet("./devices/device", ctxt, &nodes)) < 0) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("failed to parse qemu device list"));
        goto error;
    }
    if (n > 0) {
        /* NULL-terminated list */
        if (VIR_ALLOC_N(priv->qemuDevices, n + 1) < 0)
            goto error;

        for (i = 0; i < n; i++) {
            priv->qemuDevices[i] = virXMLPropString(nodes[i], "alias");
            if (!priv->qemuDevices[i]) {
                virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                               _("failed to parse qemu device list"));
                goto error;
            }
        }
    }
    VIR_FREE(nodes);

513 514 515
    return 0;

error:
516
    virDomainChrSourceDefFree(priv->monConfig);
517 518
    priv->monConfig = NULL;
    VIR_FREE(nodes);
519 520
    virStringFreeList(priv->qemuDevices);
    priv->qemuDevices = NULL;
521
    virObjectUnref(qemuCaps);
522 523 524 525
    return -1;
}


526 527 528 529 530 531 532 533
virDomainXMLPrivateDataCallbacks virQEMUDriverPrivateDataCallbacks = {
    .alloc = qemuDomainObjPrivateAlloc,
    .free = qemuDomainObjPrivateFree,
    .parse = qemuDomainObjPrivateXMLParse,
    .format = qemuDomainObjPrivateXMLFormat,
};


534 535 536 537 538
static void
qemuDomainDefNamespaceFree(void *nsdata)
{
    qemuDomainCmdlineDefPtr cmd = nsdata;

539
    qemuDomainCmdlineDefFree(cmd);
540 541 542
}

static int
P
Philipp Hahn 已提交
543 544
qemuDomainDefNamespaceParse(xmlDocPtr xml ATTRIBUTE_UNUSED,
                            xmlNodePtr root ATTRIBUTE_UNUSED,
545 546 547 548
                            xmlXPathContextPtr ctxt,
                            void **data)
{
    qemuDomainCmdlineDefPtr cmd = NULL;
P
Philipp Hahn 已提交
549
    bool uses_qemu_ns = false;
550
    xmlNodePtr *nodes = NULL;
551 552
    int n;
    size_t i;
553

P
Philipp Hahn 已提交
554
    if (xmlXPathRegisterNs(ctxt, BAD_CAST "qemu", BAD_CAST QEMU_NAMESPACE_HREF) < 0) {
555 556 557
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("Failed to register xml namespace '%s'"),
                       QEMU_NAMESPACE_HREF);
558 559 560
        return -1;
    }

561
    if (VIR_ALLOC(cmd) < 0)
562 563 564 565 566 567
        return -1;

    /* first handle the extra command-line arguments */
    n = virXPathNodeSet("./qemu:commandline/qemu:arg", ctxt, &nodes);
    if (n < 0)
        goto error;
P
Philipp Hahn 已提交
568
    uses_qemu_ns |= n > 0;
569 570

    if (n && VIR_ALLOC_N(cmd->args, n) < 0)
571
        goto error;
572 573 574 575

    for (i = 0; i < n; i++) {
        cmd->args[cmd->num_args] = virXMLPropString(nodes[i], "value");
        if (cmd->args[cmd->num_args] == NULL) {
576 577
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           "%s", _("No qemu command-line argument specified"));
578 579 580 581 582 583 584 585 586 587 588
            goto error;
        }
        cmd->num_args++;
    }

    VIR_FREE(nodes);

    /* now handle the extra environment variables */
    n = virXPathNodeSet("./qemu:commandline/qemu:env", ctxt, &nodes);
    if (n < 0)
        goto error;
P
Philipp Hahn 已提交
589
    uses_qemu_ns |= n > 0;
590 591

    if (n && VIR_ALLOC_N(cmd->env_name, n) < 0)
592
        goto error;
593 594

    if (n && VIR_ALLOC_N(cmd->env_value, n) < 0)
595
        goto error;
596 597 598 599 600 601

    for (i = 0; i < n; i++) {
        char *tmp;

        tmp = virXMLPropString(nodes[i], "name");
        if (tmp == NULL) {
602 603
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           "%s", _("No qemu environment name specified"));
604 605 606
            goto error;
        }
        if (tmp[0] == '\0') {
607 608
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           "%s", _("Empty qemu environment name specified"));
609 610 611
            goto error;
        }
        if (!c_isalpha(tmp[0]) && tmp[0] != '_') {
612 613
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           "%s", _("Invalid environment name, it must begin with a letter or underscore"));
614 615 616
            goto error;
        }
        if (strspn(tmp, "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789_") != strlen(tmp)) {
617 618
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           "%s", _("Invalid environment name, it must contain only alphanumerics and underscore"));
619 620 621 622 623 624 625 626 627 628 629 630
            goto error;
        }

        cmd->env_name[cmd->num_env] = tmp;

        cmd->env_value[cmd->num_env] = virXMLPropString(nodes[i], "value");
        /* a NULL value for command is allowed, since it might be empty */
        cmd->num_env++;
    }

    VIR_FREE(nodes);

P
Philipp Hahn 已提交
631 632 633 634
    if (uses_qemu_ns)
        *data = cmd;
    else
        VIR_FREE(cmd);
635 636 637 638 639 640 641 642 643 644 645 646 647 648

    return 0;

error:
    VIR_FREE(nodes);
    qemuDomainDefNamespaceFree(cmd);
    return -1;
}

static int
qemuDomainDefNamespaceFormatXML(virBufferPtr buf,
                                void *nsdata)
{
    qemuDomainCmdlineDefPtr cmd = nsdata;
649
    size_t i;
650 651 652 653 654 655 656 657 658

    if (!cmd->num_args && !cmd->num_env)
        return 0;

    virBufferAddLit(buf, "  <qemu:commandline>\n");
    for (i = 0; i < cmd->num_args; i++)
        virBufferEscapeString(buf, "    <qemu:arg value='%s'/>\n",
                              cmd->args[i]);
    for (i = 0; i < cmd->num_env; i++) {
659
        virBufferAsprintf(buf, "    <qemu:env name='%s'", cmd->env_name[i]);
660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675
        if (cmd->env_value[i])
            virBufferEscapeString(buf, " value='%s'", cmd->env_value[i]);
        virBufferAddLit(buf, "/>\n");
    }
    virBufferAddLit(buf, "  </qemu:commandline>\n");

    return 0;
}

static const char *
qemuDomainDefNamespaceHref(void)
{
    return "xmlns:qemu='" QEMU_NAMESPACE_HREF "'";
}


676 677 678 679 680 681
virDomainXMLNamespace virQEMUDriverDomainXMLNamespace = {
    .parse = qemuDomainDefNamespaceParse,
    .free = qemuDomainDefNamespaceFree,
    .format = qemuDomainDefNamespaceFormatXML,
    .href = qemuDomainDefNamespaceHref,
};
682

683

684 685 686 687 688
static int
qemuDomainDefPostParse(virDomainDefPtr def,
                       virCapsPtr caps,
                       void *opaque ATTRIBUTE_UNUSED)
{
689
    bool addDefaultUSB = true;
690
    bool addImplicitSATA = false;
691
    bool addPCIRoot = false;
L
Laine Stump 已提交
692
    bool addPCIeRoot = false;
693
    bool addDefaultMemballoon = true;
694 695
    bool addDefaultUSBKBD = false;
    bool addDefaultUSBMouse = false;
696

697 698 699 700 701
    /* check for emulator and create a default one if needed */
    if (!def->emulator &&
        !(def->emulator = virDomainDefGetDefaultEmulator(def, caps)))
        return -1;

702 703 704 705 706 707
    /* Add implicit PCI root controller if the machine has one */
    switch (def->os.arch) {
    case VIR_ARCH_I686:
    case VIR_ARCH_X86_64:
        if (!def->os.machine)
            break;
L
Laine Stump 已提交
708
        if (STREQ(def->os.machine, "isapc")) {
709
            addDefaultUSB = false;
710
            break;
711
        }
L
Laine Stump 已提交
712 713 714 715
        if (STRPREFIX(def->os.machine, "pc-q35") ||
            STREQ(def->os.machine, "q35")) {
           addPCIeRoot = true;
           addDefaultUSB = false;
716
           addImplicitSATA = true;
L
Laine Stump 已提交
717 718
           break;
        }
719 720
        if (!STRPREFIX(def->os.machine, "pc-0.") &&
            !STRPREFIX(def->os.machine, "pc-1.") &&
721
            !STRPREFIX(def->os.machine, "pc-i440") &&
722 723 724 725 726 727
            !STREQ(def->os.machine, "pc") &&
            !STRPREFIX(def->os.machine, "rhel"))
            break;
        addPCIRoot = true;
        break;

728 729
    case VIR_ARCH_ARMV7L:
       addDefaultUSB = false;
730
       addDefaultMemballoon = false;
731
       break;
732 733 734 735
    case VIR_ARCH_AARCH64:
       addDefaultUSB = false;
       addDefaultMemballoon = false;
       break;
736

737 738 739 740 741 742
    case VIR_ARCH_PPC64:
        addPCIRoot = true;
        addDefaultUSBKBD = true;
        addDefaultUSBMouse = true;
        break;

743 744 745 746 747 748 749 750 751 752 753
    case VIR_ARCH_ALPHA:
    case VIR_ARCH_PPC:
    case VIR_ARCH_PPCEMB:
    case VIR_ARCH_SH4:
    case VIR_ARCH_SH4EB:
        addPCIRoot = true;
        break;
    default:
        break;
    }

754 755 756 757 758
    if (addDefaultUSB &&
        virDomainDefMaybeAddController(
            def, VIR_DOMAIN_CONTROLLER_TYPE_USB, 0, -1) < 0)
        return -1;

759 760 761 762 763
    if (addImplicitSATA &&
        virDomainDefMaybeAddController(
            def, VIR_DOMAIN_CONTROLLER_TYPE_SATA, 0, -1) < 0)
        return -1;

764 765 766 767 768 769
    if (addPCIRoot &&
        virDomainDefMaybeAddController(
            def, VIR_DOMAIN_CONTROLLER_TYPE_PCI, 0,
            VIR_DOMAIN_CONTROLLER_MODEL_PCI_ROOT) < 0)
        return -1;

770 771 772 773 774 775 776 777 778 779 780 781 782 783
    /* When a machine has a pcie-root, make sure that there is always
     * a dmi-to-pci-bridge controller added as bus 1, and a pci-bridge
     * as bus 2, so that standard PCI devices can be connected
     */
    if (addPCIeRoot) {
        if (virDomainDefMaybeAddController(
                def, VIR_DOMAIN_CONTROLLER_TYPE_PCI, 0,
                VIR_DOMAIN_CONTROLLER_MODEL_PCIE_ROOT) < 0 ||
            virDomainDefMaybeAddController(
                def, VIR_DOMAIN_CONTROLLER_TYPE_PCI, 1,
                VIR_DOMAIN_CONTROLLER_MODEL_DMI_TO_PCI_BRIDGE) < 0 ||
            virDomainDefMaybeAddController(
                def, VIR_DOMAIN_CONTROLLER_TYPE_PCI, 2,
                VIR_DOMAIN_CONTROLLER_MODEL_PCI_BRIDGE) < 0) {
L
Laine Stump 已提交
784
        return -1;
785 786
        }
    }
787

788
    if (addDefaultMemballoon && !def->memballoon) {
789 790 791 792 793 794 795 796
        virDomainMemballoonDefPtr memballoon;
        if (VIR_ALLOC(memballoon) < 0)
            return -1;

        memballoon->model = VIR_DOMAIN_MEMBALLOON_MODEL_VIRTIO;
        def->memballoon = memballoon;
    }

797 798 799 800 801 802 803 804 805 806 807 808 809 810
    if (addDefaultUSBKBD &&
        def->ngraphics > 0 &&
        virDomainDefMaybeAddInput(def,
                                  VIR_DOMAIN_INPUT_TYPE_KBD,
                                  VIR_DOMAIN_INPUT_BUS_USB) < 0)
        return -1;

    if (addDefaultUSBMouse &&
        def->ngraphics > 0 &&
        virDomainDefMaybeAddInput(def,
                                  VIR_DOMAIN_INPUT_TYPE_MOUSE,
                                  VIR_DOMAIN_INPUT_BUS_USB) < 0)
        return -1;

811 812 813
    return 0;
}

814
static const char *
815 816
qemuDomainDefaultNetModel(const virDomainDef *def)
{
817 818 819 820
    if (def->os.arch == VIR_ARCH_S390 ||
        def->os.arch == VIR_ARCH_S390X)
        return "virtio";

821 822
    if (def->os.arch == VIR_ARCH_ARMV7L ||
        def->os.arch == VIR_ARCH_AARCH64) {
823 824 825
        if (STREQ(def->os.machine, "versatilepb"))
            return "smc91c111";

826 827 828
        if (STREQ(def->os.machine, "virt"))
            return "virtio";

829 830 831 832 833 834 835
        /* Incomplete. vexpress (and a few others) use this, but not all
         * arm boards */
        return "lan9118";
    }

    return "rtl8139";
}
836

837 838
static int
qemuDomainDeviceDefPostParse(virDomainDeviceDefPtr dev,
839
                             const virDomainDef *def,
840
                             virCapsPtr caps ATTRIBUTE_UNUSED,
841
                             void *opaque)
842
{
843 844 845 846
    int ret = -1;
    virQEMUDriverPtr driver = opaque;
    virQEMUDriverConfigPtr cfg = NULL;

847
    if (dev->type == VIR_DOMAIN_DEVICE_NET &&
848 849
        dev->data.net->type != VIR_DOMAIN_NET_TYPE_HOSTDEV &&
        !dev->data.net->model) {
850
        if (VIR_STRDUP(dev->data.net->model,
851
                       qemuDomainDefaultNetModel(def)) < 0)
852
            goto cleanup;
853
    }
854

855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875
    /* set default disk types and drivers */
    if (dev->type == VIR_DOMAIN_DEVICE_DISK) {
        virDomainDiskDefPtr disk = dev->data.disk;

        /* both of these require data from the driver config */
        if (driver && (cfg = virQEMUDriverGetConfig(driver))) {
            /* assign default storage format and driver according to config */
            if (cfg->allowDiskFormatProbing) {
                /* default disk format for drives */
                if (disk->format == VIR_STORAGE_FILE_NONE &&
                    (disk->type == VIR_DOMAIN_DISK_TYPE_FILE ||
                     disk->type == VIR_DOMAIN_DISK_TYPE_BLOCK))
                    disk->format = VIR_STORAGE_FILE_AUTO;

                 /* default disk format for mirrored drive */
                if (disk->mirror &&
                    disk->mirrorFormat == VIR_STORAGE_FILE_NONE)
                    disk->mirrorFormat = VIR_STORAGE_FILE_AUTO;
            } else {
                /* default driver if probing is forbidden */
                if (!disk->driverName &&
876 877
                    VIR_STRDUP(disk->driverName, "qemu") < 0)
                        goto cleanup;
878 879 880 881 882 883 884 885 886 887 888 889

                /* default disk format for drives */
                if (disk->format == VIR_STORAGE_FILE_NONE &&
                    (disk->type == VIR_DOMAIN_DISK_TYPE_FILE ||
                     disk->type == VIR_DOMAIN_DISK_TYPE_BLOCK))
                    disk->format = VIR_STORAGE_FILE_RAW;

                 /* default disk format for mirrored drive */
                if (disk->mirror &&
                    disk->mirrorFormat == VIR_STORAGE_FILE_NONE)
                    disk->mirrorFormat = VIR_STORAGE_FILE_RAW;
            }
890 891 892
        }
    }

893 894 895 896 897 898 899
    /* set the default console type for S390 arches */
    if (dev->type == VIR_DOMAIN_DEVICE_CHR &&
        dev->data.chr->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_CONSOLE &&
        dev->data.chr->targetType == VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_NONE &&
        (def->os.arch == VIR_ARCH_S390 || def->os.arch == VIR_ARCH_S390X))
        dev->data.chr->targetType = VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_VIRTIO;

900 901 902 903 904 905 906 907
    /* set the default USB model to none for s390 unless an address is found */
    if (dev->type == VIR_DOMAIN_DEVICE_CONTROLLER &&
        dev->data.controller->type == VIR_DOMAIN_CONTROLLER_TYPE_USB &&
        dev->data.controller->model == -1 &&
        dev->data.controller->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE &&
        (def->os.arch == VIR_ARCH_S390 || def->os.arch == VIR_ARCH_S390X))
        dev->data.controller->model = VIR_DOMAIN_CONTROLLER_MODEL_USB_NONE;

908 909 910 911 912 913 914 915 916 917 918
    /* auto generate unix socket path */
    if (dev->type == VIR_DOMAIN_DEVICE_CHR &&
        dev->data.chr->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_CHANNEL &&
        dev->data.chr->targetType == VIR_DOMAIN_CHR_CHANNEL_TARGET_TYPE_VIRTIO &&
        dev->data.chr->source.type == VIR_DOMAIN_CHR_TYPE_UNIX &&
        !dev->data.chr->source.data.nix.path &&
        (driver && (cfg = virQEMUDriverGetConfig(driver)))) {

        if (virAsprintf(&dev->data.chr->source.data.nix.path,
                        "%s/channel/target/%s.%s",
                        cfg->libDir, def->name,
919
                        dev->data.chr->target.name) < 0)
920
            goto cleanup;
921 922 923
        dev->data.chr->source.data.nix.listen = true;
    }

924 925 926 927 928
    ret = 0;

cleanup:
    virObjectUnref(cfg);
    return ret;
929 930 931 932 933
}


virDomainDefParserConfig virQEMUDriverDomainDefParserConfig = {
    .devicesPostParseCallback = qemuDomainDeviceDefPostParse,
934
    .domainPostParseCallback = qemuDomainDefPostParse,
935 936 937
};


938
static void
939
qemuDomainObjSaveJob(virQEMUDriverPtr driver, virDomainObjPtr obj)
940
{
941 942 943
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);

    if (virDomainObjIsActive(obj)) {
944
        if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, obj) < 0)
945
            VIR_WARN("Failed to save status on vm %s", obj->def->name);
946
    }
947

948
    virObjectUnref(cfg);
949 950
}

J
Jiri Denemark 已提交
951
void
952
qemuDomainObjSetJobPhase(virQEMUDriverPtr driver,
J
Jiri Denemark 已提交
953 954 955 956
                         virDomainObjPtr obj,
                         int phase)
{
    qemuDomainObjPrivatePtr priv = obj->privateData;
957
    unsigned long long me = virThreadSelfID();
J
Jiri Denemark 已提交
958 959 960 961

    if (!priv->job.asyncJob)
        return;

962 963 964 965 966
    VIR_DEBUG("Setting '%s' phase to '%s'",
              qemuDomainAsyncJobTypeToString(priv->job.asyncJob),
              qemuDomainAsyncJobPhaseToString(priv->job.asyncJob, phase));

    if (priv->job.asyncOwner && me != priv->job.asyncOwner) {
967
        VIR_WARN("'%s' async job is owned by thread %llu",
968 969 970 971
                 qemuDomainAsyncJobTypeToString(priv->job.asyncJob),
                 priv->job.asyncOwner);
    }

J
Jiri Denemark 已提交
972
    priv->job.phase = phase;
973
    priv->job.asyncOwner = me;
J
Jiri Denemark 已提交
974 975 976
    qemuDomainObjSaveJob(driver, obj);
}

977
void
978 979
qemuDomainObjSetAsyncJobMask(virDomainObjPtr obj,
                             unsigned long long allowedJobs)
980 981 982
{
    qemuDomainObjPrivatePtr priv = obj->privateData;

983 984 985 986 987 988 989
    if (!priv->job.asyncJob)
        return;

    priv->job.mask = allowedJobs | JOB_MASK(QEMU_JOB_DESTROY);
}

void
990
qemuDomainObjDiscardAsyncJob(virQEMUDriverPtr driver, virDomainObjPtr obj)
991 992 993 994 995 996
{
    qemuDomainObjPrivatePtr priv = obj->privateData;

    if (priv->job.active == QEMU_JOB_ASYNC_NESTED)
        qemuDomainObjResetJob(priv);
    qemuDomainObjResetAsyncJob(priv);
997
    qemuDomainObjSaveJob(driver, obj);
998 999
}

1000 1001 1002 1003 1004 1005 1006 1007 1008
void
qemuDomainObjReleaseAsyncJob(virDomainObjPtr obj)
{
    qemuDomainObjPrivatePtr priv = obj->privateData;

    VIR_DEBUG("Releasing ownership of '%s' async job",
              qemuDomainAsyncJobTypeToString(priv->job.asyncJob));

    if (priv->job.asyncOwner != virThreadSelfID()) {
1009
        VIR_WARN("'%s' async job is owned by thread %llu",
1010 1011 1012 1013 1014 1015
                 qemuDomainAsyncJobTypeToString(priv->job.asyncJob),
                 priv->job.asyncOwner);
    }
    priv->job.asyncOwner = 0;
}

1016
static bool
1017
qemuDomainNestedJobAllowed(qemuDomainObjPrivatePtr priv, enum qemuDomainJob job)
1018 1019
{
    return !priv->job.asyncJob || (priv->job.mask & JOB_MASK(job)) != 0;
1020 1021
}

1022 1023 1024 1025 1026 1027
bool
qemuDomainJobAllowed(qemuDomainObjPrivatePtr priv, enum qemuDomainJob job)
{
    return !priv->job.active && qemuDomainNestedJobAllowed(priv, job);
}

1028 1029 1030
/* Give up waiting for mutex after 30 seconds */
#define QEMU_JOB_WAIT_TIME (1000ull * 30)

1031
/*
1032
 * obj must be locked before calling
1033
 */
1034
static int ATTRIBUTE_NONNULL(1)
1035
qemuDomainObjBeginJobInternal(virQEMUDriverPtr driver,
1036 1037 1038
                              virDomainObjPtr obj,
                              enum qemuDomainJob job,
                              enum qemuDomainAsyncJob asyncJob)
1039 1040
{
    qemuDomainObjPrivatePtr priv = obj->privateData;
J
Jiri Denemark 已提交
1041
    unsigned long long now;
1042
    unsigned long long then;
1043
    bool nested = job == QEMU_JOB_ASYNC_NESTED;
1044
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
1045

1046 1047 1048 1049 1050 1051
    VIR_DEBUG("Starting %s: %s (async=%s vm=%p name=%s)",
              job == QEMU_JOB_ASYNC ? "async job" : "job",
              qemuDomainJobTypeToString(job),
              qemuDomainAsyncJobTypeToString(priv->job.asyncJob),
              obj, obj->def->name);

1052 1053
    priv->jobs_queued++;

1054 1055
    if (virTimeMillisNow(&now) < 0) {
        virObjectUnref(cfg);
1056
        return -1;
1057 1058
    }

J
Jiri Denemark 已提交
1059
    then = now + QEMU_JOB_WAIT_TIME;
1060

1061
    virObjectRef(obj);
1062

1063
retry:
1064 1065
    if (cfg->maxQueuedJobs &&
        priv->jobs_queued > cfg->maxQueuedJobs) {
1066 1067 1068
        goto error;
    }

1069
    while (!nested && !qemuDomainNestedJobAllowed(priv, job)) {
1070
        VIR_DEBUG("Waiting for async job (vm=%p name=%s)", obj, obj->def->name);
1071
        if (virCondWaitUntil(&priv->job.asyncCond, &obj->parent.lock, then) < 0)
1072 1073 1074
            goto error;
    }

1075
    while (priv->job.active) {
1076
        VIR_DEBUG("Waiting for job (vm=%p name=%s)", obj, obj->def->name);
1077
        if (virCondWaitUntil(&priv->job.cond, &obj->parent.lock, then) < 0)
1078
            goto error;
1079
    }
1080 1081 1082

    /* No job is active but a new async job could have been started while obj
     * was unlocked, so we need to recheck it. */
1083
    if (!nested && !qemuDomainNestedJobAllowed(priv, job))
1084 1085
        goto retry;

1086
    qemuDomainObjResetJob(priv);
1087 1088

    if (job != QEMU_JOB_ASYNC) {
1089
        VIR_DEBUG("Started job: %s (async=%s vm=%p name=%s)",
1090
                   qemuDomainJobTypeToString(job),
1091 1092
                  qemuDomainAsyncJobTypeToString(priv->job.asyncJob),
                  obj, obj->def->name);
1093
        priv->job.active = job;
1094
        priv->job.owner = virThreadSelfID();
1095
    } else {
1096 1097 1098
        VIR_DEBUG("Started async job: %s (vm=%p name=%s)",
                  qemuDomainAsyncJobTypeToString(asyncJob),
                  obj, obj->def->name);
1099 1100
        qemuDomainObjResetAsyncJob(priv);
        priv->job.asyncJob = asyncJob;
1101
        priv->job.asyncOwner = virThreadSelfID();
1102 1103
        priv->job.start = now;
    }
1104

1105 1106
    if (qemuDomainTrackJob(job))
        qemuDomainObjSaveJob(driver, obj);
1107

1108
    virObjectUnref(cfg);
1109
    return 0;
1110 1111

error:
1112
    VIR_WARN("Cannot start job (%s, %s) for domain %s;"
1113
             " current job is (%s, %s) owned by (%llu, %llu)",
1114 1115 1116 1117 1118 1119 1120
             qemuDomainJobTypeToString(job),
             qemuDomainAsyncJobTypeToString(asyncJob),
             obj->def->name,
             qemuDomainJobTypeToString(priv->job.active),
             qemuDomainAsyncJobTypeToString(priv->job.asyncJob),
             priv->job.owner, priv->job.asyncOwner);

1121
    if (errno == ETIMEDOUT)
1122 1123
        virReportError(VIR_ERR_OPERATION_TIMEOUT,
                       "%s", _("cannot acquire state change lock"));
1124 1125
    else if (cfg->maxQueuedJobs &&
             priv->jobs_queued > cfg->maxQueuedJobs)
1126 1127 1128
        virReportError(VIR_ERR_OPERATION_FAILED,
                       "%s", _("cannot acquire state change lock "
                               "due to max_queued limit"));
1129 1130 1131
    else
        virReportSystemError(errno,
                             "%s", _("cannot acquire job mutex"));
1132
    priv->jobs_queued--;
1133
    virObjectUnref(obj);
1134
    virObjectUnref(cfg);
1135
    return -1;
1136 1137 1138
}

/*
1139
 * obj must be locked before calling
1140 1141 1142 1143 1144 1145 1146
 *
 * This must be called by anything that will change the VM state
 * in any way, or anything that will use the QEMU monitor.
 *
 * Upon successful return, the object will have its ref count increased,
 * successful calls must be followed by EndJob eventually
 */
1147
int qemuDomainObjBeginJob(virQEMUDriverPtr driver,
1148 1149
                          virDomainObjPtr obj,
                          enum qemuDomainJob job)
1150
{
1151
    return qemuDomainObjBeginJobInternal(driver, obj, job,
1152 1153 1154
                                         QEMU_ASYNC_JOB_NONE);
}

1155
int qemuDomainObjBeginAsyncJob(virQEMUDriverPtr driver,
1156
                               virDomainObjPtr obj,
1157
                               enum qemuDomainAsyncJob asyncJob)
1158
{
1159
    return qemuDomainObjBeginJobInternal(driver, obj, QEMU_JOB_ASYNC,
1160
                                         asyncJob);
1161 1162
}

1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176
int
qemuDomainObjBeginNestedJob(virQEMUDriverPtr driver,
                            virDomainObjPtr obj,
                            enum qemuDomainAsyncJob asyncJob)
{
    qemuDomainObjPrivatePtr priv = obj->privateData;

    if (asyncJob != priv->job.asyncJob) {
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("unexpected async job %d"), asyncJob);
        return -1;
    }

    if (priv->job.asyncOwner != virThreadSelfID()) {
1177
        VIR_WARN("This thread doesn't seem to be the async job owner: %llu",
1178 1179 1180 1181 1182 1183 1184 1185
                 priv->job.asyncOwner);
    }

    return qemuDomainObjBeginJobInternal(driver, obj,
                                         QEMU_JOB_ASYNC_NESTED,
                                         QEMU_ASYNC_JOB_NONE);
}

1186

1187
/*
1188
 * obj must be locked before calling
1189 1190 1191 1192
 *
 * To be called after completing the work associated with the
 * earlier qemuDomainBeginJob() call
 *
1193 1194
 * Returns true if @obj was still referenced, false if it was
 * disposed of.
1195
 */
1196
bool qemuDomainObjEndJob(virQEMUDriverPtr driver, virDomainObjPtr obj)
1197 1198
{
    qemuDomainObjPrivatePtr priv = obj->privateData;
1199
    enum qemuDomainJob job = priv->job.active;
1200

1201 1202
    priv->jobs_queued--;

1203
    VIR_DEBUG("Stopping job: %s (async=%s vm=%p name=%s)",
1204
              qemuDomainJobTypeToString(job),
1205 1206
              qemuDomainAsyncJobTypeToString(priv->job.asyncJob),
              obj, obj->def->name);
1207

1208
    qemuDomainObjResetJob(priv);
1209 1210
    if (qemuDomainTrackJob(job))
        qemuDomainObjSaveJob(driver, obj);
1211
    virCondSignal(&priv->job.cond);
1212

1213
    return virObjectUnref(obj);
1214 1215
}

1216
bool
1217
qemuDomainObjEndAsyncJob(virQEMUDriverPtr driver, virDomainObjPtr obj)
1218 1219
{
    qemuDomainObjPrivatePtr priv = obj->privateData;
1220

1221 1222
    priv->jobs_queued--;

1223 1224 1225
    VIR_DEBUG("Stopping async job: %s (vm=%p name=%s)",
              qemuDomainAsyncJobTypeToString(priv->job.asyncJob),
              obj, obj->def->name);
1226

1227
    qemuDomainObjResetAsyncJob(priv);
1228
    qemuDomainObjSaveJob(driver, obj);
1229 1230
    virCondBroadcast(&priv->job.asyncCond);

1231
    return virObjectUnref(obj);
1232 1233
}

1234 1235 1236 1237 1238
void
qemuDomainObjAbortAsyncJob(virDomainObjPtr obj)
{
    qemuDomainObjPrivatePtr priv = obj->privateData;

1239 1240 1241
    VIR_DEBUG("Requesting abort of async job: %s (vm=%p name=%s)",
              qemuDomainAsyncJobTypeToString(priv->job.asyncJob),
              obj, obj->def->name);
1242 1243 1244 1245

    priv->job.asyncAbort = true;
}

1246 1247 1248 1249 1250 1251 1252 1253 1254
/*
 * obj must be locked before calling
 *
 * To be called immediately before any QEMU monitor API call
 * Must have already either called qemuDomainObjBeginJob() and checked
 * that the VM is still active; may not be used for nested async jobs.
 *
 * To be followed with qemuDomainObjExitMonitor() once complete
 */
1255
static int
1256
qemuDomainObjEnterMonitorInternal(virQEMUDriverPtr driver,
1257 1258
                                  virDomainObjPtr obj,
                                  enum qemuDomainAsyncJob asyncJob)
1259 1260 1261
{
    qemuDomainObjPrivatePtr priv = obj->privateData;

1262
    if (asyncJob != QEMU_ASYNC_JOB_NONE) {
1263
        if (qemuDomainObjBeginNestedJob(driver, obj, asyncJob) < 0)
1264 1265
            return -1;
        if (!virDomainObjIsActive(obj)) {
1266 1267
            virReportError(VIR_ERR_OPERATION_FAILED, "%s",
                           _("domain is no longer running"));
1268 1269
            /* Still referenced by the containing async job.  */
            ignore_value(qemuDomainObjEndJob(driver, obj));
1270 1271
            return -1;
        }
1272 1273 1274
    } else if (priv->job.asyncOwner == virThreadSelfID()) {
        VIR_WARN("This thread seems to be the async job owner; entering"
                 " monitor without asking for a nested job is dangerous");
1275 1276
    }

1277 1278
    VIR_DEBUG("Entering monitor (mon=%p vm=%p name=%s)",
              priv->mon, obj, obj->def->name);
1279
    virObjectLock(priv->mon);
1280
    virObjectRef(priv->mon);
1281
    ignore_value(virTimeMillisNow(&priv->monStart));
1282
    virObjectUnlock(obj);
1283 1284

    return 0;
1285 1286
}

1287
static void ATTRIBUTE_NONNULL(1)
1288
qemuDomainObjExitMonitorInternal(virQEMUDriverPtr driver,
1289
                                 virDomainObjPtr obj)
1290 1291
{
    qemuDomainObjPrivatePtr priv = obj->privateData;
1292
    bool hasRefs;
1293

1294
    hasRefs = virObjectUnref(priv->mon);
1295

1296
    if (hasRefs)
1297
        virObjectUnlock(priv->mon);
1298

1299
    virObjectLock(obj);
1300 1301
    VIR_DEBUG("Exited monitor (mon=%p vm=%p name=%s)",
              priv->mon, obj, obj->def->name);
1302

1303
    priv->monStart = 0;
1304
    if (!hasRefs)
1305
        priv->mon = NULL;
1306

1307 1308 1309 1310 1311
    if (priv->job.active == QEMU_JOB_ASYNC_NESTED) {
        qemuDomainObjResetJob(priv);
        qemuDomainObjSaveJob(driver, obj);
        virCondSignal(&priv->job.cond);

1312
        virObjectUnref(obj);
1313
    }
1314 1315
}

1316
void qemuDomainObjEnterMonitor(virQEMUDriverPtr driver,
1317
                               virDomainObjPtr obj)
1318
{
1319
    ignore_value(qemuDomainObjEnterMonitorInternal(driver, obj,
1320
                                                   QEMU_ASYNC_JOB_NONE));
1321 1322
}

1323
/* obj must NOT be locked before calling
1324 1325 1326
 *
 * Should be paired with an earlier qemuDomainObjEnterMonitor() call
 */
1327
void qemuDomainObjExitMonitor(virQEMUDriverPtr driver,
1328
                              virDomainObjPtr obj)
1329
{
1330
    qemuDomainObjExitMonitorInternal(driver, obj);
1331
}
1332 1333

/*
1334
 * obj must be locked before calling
1335 1336
 *
 * To be called immediately before any QEMU monitor API call.
1337
 * Must have already either called qemuDomainObjBeginJob()
1338 1339 1340 1341 1342
 * and checked that the VM is still active, with asyncJob of
 * QEMU_ASYNC_JOB_NONE; or already called qemuDomainObjBeginAsyncJob,
 * with the same asyncJob.
 *
 * Returns 0 if job was started, in which case this must be followed with
1343
 * qemuDomainObjExitMonitor(); or -1 if the job could not be
1344 1345 1346
 * started (probably because the vm exited in the meantime).
 */
int
1347
qemuDomainObjEnterMonitorAsync(virQEMUDriverPtr driver,
1348 1349
                               virDomainObjPtr obj,
                               enum qemuDomainAsyncJob asyncJob)
1350
{
1351
    return qemuDomainObjEnterMonitorInternal(driver, obj, asyncJob);
1352 1353
}

D
Daniel P. Berrange 已提交
1354 1355


1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366
/*
 * obj must be locked before calling
 *
 * To be called immediately before any QEMU agent API call.
 * Must have already called qemuDomainObjBeginJob() and checked
 * that the VM is still active.
 *
 * To be followed with qemuDomainObjExitAgent() once complete
 */
void
qemuDomainObjEnterAgent(virDomainObjPtr obj)
D
Daniel P. Berrange 已提交
1367 1368 1369
{
    qemuDomainObjPrivatePtr priv = obj->privateData;

1370 1371
    VIR_DEBUG("Entering agent (agent=%p vm=%p name=%s)",
              priv->agent, obj, obj->def->name);
1372
    virObjectLock(priv->agent);
1373
    virObjectRef(priv->agent);
D
Daniel P. Berrange 已提交
1374
    ignore_value(virTimeMillisNow(&priv->agentStart));
1375
    virObjectUnlock(obj);
D
Daniel P. Berrange 已提交
1376 1377
}

1378 1379 1380 1381 1382 1383 1384

/* obj must NOT be locked before calling
 *
 * Should be paired with an earlier qemuDomainObjEnterAgent() call
 */
void
qemuDomainObjExitAgent(virDomainObjPtr obj)
D
Daniel P. Berrange 已提交
1385 1386
{
    qemuDomainObjPrivatePtr priv = obj->privateData;
1387
    bool hasRefs;
D
Daniel P. Berrange 已提交
1388

1389
    hasRefs = virObjectUnref(priv->agent);
D
Daniel P. Berrange 已提交
1390

1391
    if (hasRefs)
1392
        virObjectUnlock(priv->agent);
D
Daniel P. Berrange 已提交
1393

1394
    virObjectLock(obj);
1395 1396
    VIR_DEBUG("Exited agent (agent=%p vm=%p name=%s)",
              priv->agent, obj, obj->def->name);
D
Daniel P. Berrange 已提交
1397 1398

    priv->agentStart = 0;
1399
    if (!hasRefs)
D
Daniel P. Berrange 已提交
1400 1401 1402
        priv->agent = NULL;
}

1403
void qemuDomainObjEnterRemote(virDomainObjPtr obj)
1404
{
1405 1406
    VIR_DEBUG("Entering remote (vm=%p name=%s)",
              obj, obj->def->name);
1407
    virObjectRef(obj);
1408
    virObjectUnlock(obj);
1409 1410
}

1411
void qemuDomainObjExitRemote(virDomainObjPtr obj)
1412
{
1413
    virObjectLock(obj);
1414 1415
    VIR_DEBUG("Exited remote (vm=%p name=%s)",
              obj, obj->def->name);
1416
    virObjectUnref(obj);
1417
}
1418 1419


1420 1421 1422 1423 1424 1425 1426 1427
virDomainDefPtr
qemuDomainDefCopy(virQEMUDriverPtr driver,
                  virDomainDefPtr src,
                  unsigned int flags)
{
    virBuffer buf = VIR_BUFFER_INITIALIZER;
    virDomainDefPtr ret = NULL;
    virCapsPtr caps = NULL;
1428
    char *xml = NULL;
1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448

    if (qemuDomainDefFormatBuf(driver, src, flags, &buf) < 0)
        goto cleanup;

    xml = virBufferContentAndReset(&buf);

    if (!(caps = virQEMUDriverGetCapabilities(driver, false)))
        goto cleanup;

    if (!(ret = virDomainDefParseString(xml, caps, driver->xmlopt,
                                        QEMU_EXPECTED_VIRT_TYPES,
                                        VIR_DOMAIN_XML_INACTIVE)))
        goto cleanup;

cleanup:
    VIR_FREE(xml);
    virObjectUnref(caps);
    return ret;
}

1449
int
1450
qemuDomainDefFormatBuf(virQEMUDriverPtr driver,
1451 1452 1453
                       virDomainDefPtr def,
                       unsigned int flags,
                       virBuffer *buf)
1454
{
1455
    int ret = -1;
1456
    virCPUDefPtr cpu = NULL;
1457
    virCPUDefPtr def_cpu = def->cpu;
1458 1459
    virDomainControllerDefPtr *controllers = NULL;
    int ncontrollers = 0;
1460 1461 1462 1463
    virCapsPtr caps = NULL;

    if (!(caps = virQEMUDriverGetCapabilities(driver, false)))
        goto cleanup;
1464 1465

    /* Update guest CPU requirements according to host CPU */
1466 1467 1468
    if ((flags & VIR_DOMAIN_XML_UPDATE_CPU) &&
        def_cpu &&
        (def_cpu->mode != VIR_CPU_MODE_CUSTOM || def_cpu->model)) {
1469 1470
        if (!caps->host.cpu ||
            !caps->host.cpu->model) {
1471 1472
            virReportError(VIR_ERR_OPERATION_FAILED,
                           "%s", _("cannot get host CPU capabilities"));
1473 1474 1475
            goto cleanup;
        }

1476
        if (!(cpu = virCPUDefCopy(def_cpu)) ||
1477
            cpuUpdate(cpu, caps->host.cpu) < 0)
1478 1479 1480 1481
            goto cleanup;
        def->cpu = cpu;
    }

1482
    if ((flags & VIR_DOMAIN_XML_MIGRATABLE)) {
1483
        size_t i;
1484
        int toremove = 0;
1485
        virDomainControllerDefPtr usb = NULL, pci = NULL;
1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503

        /* If only the default USB controller is present, we can remove it
         * and make the XML compatible with older versions of libvirt which
         * didn't support USB controllers in the XML but always added the
         * default one to qemu anyway.
         */
        for (i = 0; i < def->ncontrollers; i++) {
            if (def->controllers[i]->type == VIR_DOMAIN_CONTROLLER_TYPE_USB) {
                if (usb) {
                    usb = NULL;
                    break;
                }
                usb = def->controllers[i];
            }
        }
        if (usb && usb->idx == 0 && usb->model == -1) {
            VIR_DEBUG("Removing default USB controller from domain '%s'"
                      " for migration compatibility", def->name);
1504
            toremove++;
1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522
        } else {
            usb = NULL;
        }

        /* Remove the default PCI controller if there is only one present
         * and its model is pci-root */
        for (i = 0; i < def->ncontrollers; i++) {
            if (def->controllers[i]->type == VIR_DOMAIN_CONTROLLER_TYPE_PCI) {
                if (pci) {
                    pci = NULL;
                    break;
                }
                pci = def->controllers[i];
            }
        }

        if (pci && pci->idx == 0 &&
            pci->model == VIR_DOMAIN_CONTROLLER_MODEL_PCI_ROOT) {
L
Laine Stump 已提交
1523
            VIR_DEBUG("Removing default pci-root from domain '%s'"
1524
                      " for migration compatibility", def->name);
1525
            toremove++;
1526 1527 1528 1529
        } else {
            pci = NULL;
        }

1530
        if (toremove) {
1531 1532
            controllers = def->controllers;
            ncontrollers = def->ncontrollers;
1533
            if (VIR_ALLOC_N(def->controllers, ncontrollers - toremove) < 0) {
1534 1535 1536 1537 1538 1539
                controllers = NULL;
                goto cleanup;
            }

            def->ncontrollers = 0;
            for (i = 0; i < ncontrollers; i++) {
1540
                if (controllers[i] != usb && controllers[i] != pci)
1541 1542 1543
                    def->controllers[def->ncontrollers++] = controllers[i];
            }
        }
1544 1545


1546 1547
    }

1548
    ret = virDomainDefFormatInternal(def, flags, buf);
1549 1550 1551 1552

cleanup:
    def->cpu = def_cpu;
    virCPUDefFree(cpu);
1553 1554 1555 1556 1557
    if (controllers) {
        VIR_FREE(def->controllers);
        def->controllers = controllers;
        def->ncontrollers = ncontrollers;
    }
1558
    virObjectUnref(caps);
1559 1560
    return ret;
}
1561

1562
char *qemuDomainDefFormatXML(virQEMUDriverPtr driver,
1563
                             virDomainDefPtr def,
1564
                             unsigned int flags)
1565 1566 1567
{
    virBuffer buf = VIR_BUFFER_INITIALIZER;

1568
    if (qemuDomainDefFormatBuf(driver, def, flags, &buf) < 0) {
1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581
        virBufferFreeAndReset(&buf);
        return NULL;
    }

    if (virBufferError(&buf)) {
        virReportOOMError();
        virBufferFreeAndReset(&buf);
        return NULL;
    }

    return virBufferContentAndReset(&buf);
}

1582
char *qemuDomainFormatXML(virQEMUDriverPtr driver,
1583
                          virDomainObjPtr vm,
1584
                          unsigned int flags)
1585 1586 1587 1588 1589 1590 1591 1592
{
    virDomainDefPtr def;

    if ((flags & VIR_DOMAIN_XML_INACTIVE) && vm->newDef)
        def = vm->newDef;
    else
        def = vm->def;

1593
    return qemuDomainDefFormatXML(driver, def, flags);
1594 1595
}

1596
char *
1597
qemuDomainDefFormatLive(virQEMUDriverPtr driver,
1598
                        virDomainDefPtr def,
1599 1600
                        bool inactive,
                        bool compatible)
1601 1602 1603 1604 1605
{
    unsigned int flags = QEMU_DOMAIN_FORMAT_LIVE_FLAGS;

    if (inactive)
        flags |= VIR_DOMAIN_XML_INACTIVE;
1606 1607
    if (compatible)
        flags |= VIR_DOMAIN_XML_MIGRATABLE;
1608

1609
    return qemuDomainDefFormatXML(driver, def, flags);
1610 1611
}

1612

1613
void qemuDomainObjTaint(virQEMUDriverPtr driver,
1614
                        virDomainObjPtr obj,
1615 1616
                        enum virDomainTaintFlags taint,
                        int logFD)
1617
{
1618 1619
    virErrorPtr orig_err = NULL;

1620 1621 1622 1623 1624 1625 1626 1627 1628
    if (virDomainObjTaint(obj, taint)) {
        char uuidstr[VIR_UUID_STRING_BUFLEN];
        virUUIDFormat(obj->def->uuid, uuidstr);

        VIR_WARN("Domain id=%d name='%s' uuid=%s is tainted: %s",
                 obj->def->id,
                 obj->def->name,
                 uuidstr,
                 virDomainTaintTypeToString(taint));
1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642

        /* We don't care about errors logging taint info, so
         * preserve original error, and clear any error that
         * is raised */
        orig_err = virSaveLastError();
        if (qemuDomainAppendLog(driver, obj, logFD,
                                "Domain id=%d is tainted: %s\n",
                                obj->def->id,
                                virDomainTaintTypeToString(taint)) < 0)
            virResetLastError();
        if (orig_err) {
            virSetError(orig_err);
            virFreeError(orig_err);
        }
1643 1644 1645 1646
    }
}


1647
void qemuDomainObjCheckTaint(virQEMUDriverPtr driver,
1648 1649
                             virDomainObjPtr obj,
                             int logFD)
1650
{
1651
    size_t i;
1652
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
1653
    qemuDomainObjPrivatePtr priv = obj->privateData;
1654

1655 1656 1657 1658
    if (cfg->privileged &&
        (!cfg->clearEmulatorCapabilities ||
         cfg->user == 0 ||
         cfg->group == 0))
1659
        qemuDomainObjTaint(driver, obj, VIR_DOMAIN_TAINT_HIGH_PRIVILEGES, logFD);
1660

1661 1662 1663
    if (priv->hookRun)
        qemuDomainObjTaint(driver, obj, VIR_DOMAIN_TAINT_HOOK, logFD);

1664 1665 1666
    if (obj->def->namespaceData) {
        qemuDomainCmdlineDefPtr qemucmd = obj->def->namespaceData;
        if (qemucmd->num_args || qemucmd->num_env)
1667
            qemuDomainObjTaint(driver, obj, VIR_DOMAIN_TAINT_CUSTOM_ARGV, logFD);
1668 1669
    }

1670 1671 1672
    if (obj->def->cpu && obj->def->cpu->mode == VIR_CPU_MODE_HOST_PASSTHROUGH)
        qemuDomainObjTaint(driver, obj, VIR_DOMAIN_TAINT_HOST_CPU, logFD);

1673
    for (i = 0; i < obj->def->ndisks; i++)
1674
        qemuDomainObjCheckDiskTaint(driver, obj, obj->def->disks[i], logFD);
1675

1676
    for (i = 0; i < obj->def->nnets; i++)
1677
        qemuDomainObjCheckNetTaint(driver, obj, obj->def->nets[i], logFD);
1678 1679

    virObjectUnref(cfg);
1680 1681 1682
}


1683
void qemuDomainObjCheckDiskTaint(virQEMUDriverPtr driver,
1684
                                 virDomainObjPtr obj,
1685 1686
                                 virDomainDiskDefPtr disk,
                                 int logFD)
1687
{
1688 1689
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);

1690
    if ((!disk->format || disk->format == VIR_STORAGE_FILE_AUTO) &&
1691
        cfg->allowDiskFormatProbing)
1692
        qemuDomainObjTaint(driver, obj, VIR_DOMAIN_TAINT_DISK_PROBING, logFD);
1693

1694
    if (disk->rawio == 1)
1695
        qemuDomainObjTaint(driver, obj, VIR_DOMAIN_TAINT_HIGH_PRIVILEGES, logFD);
1696 1697

    virObjectUnref(cfg);
1698 1699 1700
}


1701
void qemuDomainObjCheckNetTaint(virQEMUDriverPtr driver,
1702
                                virDomainObjPtr obj,
1703 1704
                                virDomainNetDefPtr net,
                                int logFD)
1705
{
1706 1707 1708 1709 1710 1711
    /* script is only useful for NET_TYPE_ETHERNET (qemu) and
     * NET_TYPE_BRIDGE (xen), but could be (incorrectly) specified for
     * any interface type. In any case, it's adding user sauce into
     * the soup, so it should taint the domain.
     */
    if (net->script != NULL)
1712
        qemuDomainObjTaint(driver, obj, VIR_DOMAIN_TAINT_SHELL_SCRIPTS, logFD);
1713
}
1714 1715 1716


static int
1717
qemuDomainOpenLogHelper(virQEMUDriverConfigPtr cfg,
1718
                        virDomainObjPtr vm,
E
Eric Blake 已提交
1719
                        int oflags,
1720 1721 1722 1723
                        mode_t mode)
{
    char *logfile;
    int fd = -1;
1724
    bool trunc = false;
1725

1726
    if (virAsprintf(&logfile, "%s/%s.log", cfg->logDir, vm->def->name) < 0)
1727 1728
        return -1;

1729 1730 1731 1732 1733 1734 1735 1736 1737
    /* To make SELinux happy we always need to open in append mode.
     * So we fake O_TRUNC by calling ftruncate after open instead
     */
    if (oflags & O_TRUNC) {
        oflags &= ~O_TRUNC;
        oflags |= O_APPEND;
        trunc = true;
    }

E
Eric Blake 已提交
1738
    if ((fd = open(logfile, oflags, mode)) < 0) {
1739 1740 1741 1742 1743 1744 1745
        virReportSystemError(errno, _("failed to create logfile %s"),
                             logfile);
        goto cleanup;
    }
    if (virSetCloseExec(fd) < 0) {
        virReportSystemError(errno, _("failed to set close-on-exec flag on %s"),
                             logfile);
1746 1747 1748 1749 1750 1751 1752
        VIR_FORCE_CLOSE(fd);
        goto cleanup;
    }
    if (trunc &&
        ftruncate(fd, 0) < 0) {
        virReportSystemError(errno, _("failed to truncate %s"),
                             logfile);
1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763
        VIR_FORCE_CLOSE(fd);
        goto cleanup;
    }

cleanup:
    VIR_FREE(logfile);
    return fd;
}


int
1764
qemuDomainCreateLog(virQEMUDriverPtr driver, virDomainObjPtr vm,
E
Eric Blake 已提交
1765
                    bool append)
1766
{
1767
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
E
Eric Blake 已提交
1768
    int oflags;
1769
    int ret;
1770

E
Eric Blake 已提交
1771
    oflags = O_CREAT | O_WRONLY;
1772
    /* Only logrotate files in /var/log, so only append if running privileged */
1773
    if (cfg->privileged || append)
E
Eric Blake 已提交
1774
        oflags |= O_APPEND;
1775
    else
E
Eric Blake 已提交
1776
        oflags |= O_TRUNC;
1777

1778 1779 1780
    ret = qemuDomainOpenLogHelper(cfg, vm, oflags, S_IRUSR | S_IWUSR);
    virObjectUnref(cfg);
    return ret;
1781 1782 1783 1784
}


int
1785
qemuDomainOpenLog(virQEMUDriverPtr driver, virDomainObjPtr vm, off_t pos)
1786
{
1787
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
1788 1789 1790 1791
    int fd;
    off_t off;
    int whence;

1792 1793 1794
    fd = qemuDomainOpenLogHelper(cfg, vm, O_RDONLY, 0);
    virObjectUnref(cfg);
    if (fd < 0)
1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820
        return -1;

    if (pos < 0) {
        off = 0;
        whence = SEEK_END;
    } else {
        off = pos;
        whence = SEEK_SET;
    }

    if (lseek(fd, off, whence) < 0) {
        if (whence == SEEK_END)
            virReportSystemError(errno,
                                 _("unable to seek to end of log for %s"),
                                 vm->def->name);
        else
            virReportSystemError(errno,
                                 _("unable to seek to %lld from start for %s"),
                                 (long long)off, vm->def->name);
        VIR_FORCE_CLOSE(fd);
    }

    return fd;
}


1821
int qemuDomainAppendLog(virQEMUDriverPtr driver,
1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836
                        virDomainObjPtr obj,
                        int logFD,
                        const char *fmt, ...)
{
    int fd = logFD;
    va_list argptr;
    char *message = NULL;
    int ret = -1;

    va_start(argptr, fmt);

    if ((fd == -1) &&
        (fd = qemuDomainCreateLog(driver, obj, true)) < 0)
        goto cleanup;

1837
    if (virVasprintf(&message, fmt, argptr) < 0)
1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852
        goto cleanup;
    if (safewrite(fd, message, strlen(message)) < 0) {
        virReportSystemError(errno, _("Unable to write to domain logfile %s"),
                             obj->def->name);
        goto cleanup;
    }

    ret = 0;

cleanup:
    va_end(argptr);

    if (fd != logFD)
        VIR_FORCE_CLOSE(fd);

O
Osier Yang 已提交
1853
    VIR_FREE(message);
1854 1855
    return ret;
}
1856 1857 1858

/* Locate an appropriate 'qemu-img' binary.  */
const char *
1859
qemuFindQemuImgBinary(virQEMUDriverPtr driver)
1860
{
1861 1862 1863
    if (!driver->qemuImgBinary)
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       "%s", _("unable to find kvm-img or qemu-img"));
1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880

    return driver->qemuImgBinary;
}

int
qemuDomainSnapshotWriteMetadata(virDomainObjPtr vm,
                                virDomainSnapshotObjPtr snapshot,
                                char *snapshotDir)
{
    char *newxml = NULL;
    int ret = -1;
    char *snapDir = NULL;
    char *snapFile = NULL;
    char uuidstr[VIR_UUID_STRING_BUFLEN];

    virUUIDFormat(vm->def->uuid, uuidstr);
    newxml = virDomainSnapshotDefFormat(uuidstr, snapshot->def,
1881 1882
                                        QEMU_DOMAIN_FORMAT_LIVE_FLAGS, 1);
    if (newxml == NULL)
1883 1884
        return -1;

1885
    if (virAsprintf(&snapDir, "%s/%s", snapshotDir, vm->def->name) < 0)
1886 1887 1888 1889 1890 1891 1892
        goto cleanup;
    if (virFileMakePath(snapDir) < 0) {
        virReportSystemError(errno, _("cannot create snapshot directory '%s'"),
                             snapDir);
        goto cleanup;
    }

1893
    if (virAsprintf(&snapFile, "%s/%s.xml", snapDir, snapshot->def->name) < 0)
1894 1895
        goto cleanup;

J
Ján Tomko 已提交
1896
    ret = virXMLSaveFile(snapFile, NULL, "snapshot-edit", newxml);
1897 1898 1899 1900 1901 1902 1903 1904 1905 1906

cleanup:
    VIR_FREE(snapFile);
    VIR_FREE(snapDir);
    VIR_FREE(newxml);
    return ret;
}

/* The domain is expected to be locked and inactive. Return -1 on normal
 * failure, 1 if we skipped a disk due to try_all.  */
1907
static int
1908
qemuDomainSnapshotForEachQcow2Raw(virQEMUDriverPtr driver,
1909 1910 1911 1912 1913
                                  virDomainDefPtr def,
                                  const char *name,
                                  const char *op,
                                  bool try_all,
                                  int ndisks)
1914 1915
{
    const char *qemuimgarg[] = { NULL, "snapshot", NULL, NULL, NULL, NULL };
1916
    size_t i;
1917 1918 1919 1920 1921 1922 1923 1924 1925
    bool skipped = false;

    qemuimgarg[0] = qemuFindQemuImgBinary(driver);
    if (qemuimgarg[0] == NULL) {
        /* qemuFindQemuImgBinary set the error */
        return -1;
    }

    qemuimgarg[2] = op;
1926
    qemuimgarg[3] = name;
1927

1928
    for (i = 0; i < ndisks; i++) {
1929
        /* FIXME: we also need to handle LVM here */
1930
        if (def->disks[i]->device == VIR_DOMAIN_DISK_DEVICE_DISK) {
1931 1932
            if (def->disks[i]->format > 0 &&
                def->disks[i]->format != VIR_STORAGE_FILE_QCOW2) {
1933 1934 1935 1936 1937
                if (try_all) {
                    /* Continue on even in the face of error, since other
                     * disks in this VM may have the same snapshot name.
                     */
                    VIR_WARN("skipping snapshot action on %s",
1938
                             def->disks[i]->dst);
1939 1940
                    skipped = true;
                    continue;
1941 1942 1943 1944 1945
                } else if (STREQ(op, "-c") && i) {
                    /* We must roll back partial creation by deleting
                     * all earlier snapshots.  */
                    qemuDomainSnapshotForEachQcow2Raw(driver, def, name,
                                                      "-d", false, i);
1946
                }
1947 1948 1949 1950
                virReportError(VIR_ERR_OPERATION_INVALID,
                               _("Disk device '%s' does not support"
                                 " snapshotting"),
                               def->disks[i]->dst);
1951 1952 1953
                return -1;
            }

1954
            qemuimgarg[4] = def->disks[i]->src;
1955 1956 1957 1958

            if (virRun(qemuimgarg, NULL) < 0) {
                if (try_all) {
                    VIR_WARN("skipping snapshot action on %s",
1959
                             def->disks[i]->dst);
1960 1961
                    skipped = true;
                    continue;
1962 1963 1964 1965 1966
                } else if (STREQ(op, "-c") && i) {
                    /* We must roll back partial creation by deleting
                     * all earlier snapshots.  */
                    qemuDomainSnapshotForEachQcow2Raw(driver, def, name,
                                                      "-d", false, i);
1967 1968 1969 1970 1971 1972 1973 1974 1975
                }
                return -1;
            }
        }
    }

    return skipped ? 1 : 0;
}

1976 1977 1978
/* The domain is expected to be locked and inactive. Return -1 on normal
 * failure, 1 if we skipped a disk due to try_all.  */
int
1979
qemuDomainSnapshotForEachQcow2(virQEMUDriverPtr driver,
1980 1981 1982 1983 1984 1985 1986 1987 1988 1989 1990 1991 1992 1993 1994 1995
                               virDomainObjPtr vm,
                               virDomainSnapshotObjPtr snap,
                               const char *op,
                               bool try_all)
{
    /* Prefer action on the disks in use at the time the snapshot was
     * created; but fall back to current definition if dealing with a
     * snapshot created prior to libvirt 0.9.5.  */
    virDomainDefPtr def = snap->def->dom;

    if (!def)
        def = vm->def;
    return qemuDomainSnapshotForEachQcow2Raw(driver, def, snap->def->name,
                                             op, try_all, def->ndisks);
}

1996 1997
/* Discard one snapshot (or its metadata), without reparenting any children.  */
int
1998
qemuDomainSnapshotDiscard(virQEMUDriverPtr driver,
1999 2000 2001 2002 2003 2004 2005 2006 2007
                          virDomainObjPtr vm,
                          virDomainSnapshotObjPtr snap,
                          bool update_current,
                          bool metadata_only)
{
    char *snapFile = NULL;
    int ret = -1;
    qemuDomainObjPrivatePtr priv;
    virDomainSnapshotObjPtr parentsnap = NULL;
2008
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
2009 2010 2011 2012 2013 2014 2015 2016 2017

    if (!metadata_only) {
        if (!virDomainObjIsActive(vm)) {
            /* Ignore any skipped disks */
            if (qemuDomainSnapshotForEachQcow2(driver, vm, snap, "-d",
                                               true) < 0)
                goto cleanup;
        } else {
            priv = vm->privateData;
2018
            qemuDomainObjEnterMonitor(driver, vm);
2019 2020
            /* we continue on even in the face of error */
            qemuMonitorDeleteSnapshot(priv->mon, snap->def->name);
2021
            qemuDomainObjExitMonitor(driver, vm);
2022 2023 2024
        }
    }

2025
    if (virAsprintf(&snapFile, "%s/%s/%s.xml", cfg->snapshotDir,
2026
                    vm->def->name, snap->def->name) < 0)
2027 2028 2029 2030
        goto cleanup;

    if (snap == vm->current_snapshot) {
        if (update_current && snap->def->parent) {
2031
            parentsnap = virDomainSnapshotFindByName(vm->snapshots,
2032 2033 2034 2035 2036 2037 2038
                                                     snap->def->parent);
            if (!parentsnap) {
                VIR_WARN("missing parent snapshot matching name '%s'",
                         snap->def->parent);
            } else {
                parentsnap->def->current = true;
                if (qemuDomainSnapshotWriteMetadata(vm, parentsnap,
2039
                                                    cfg->snapshotDir) < 0) {
2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051
                    VIR_WARN("failed to set parent snapshot '%s' as current",
                             snap->def->parent);
                    parentsnap->def->current = false;
                    parentsnap = NULL;
                }
            }
        }
        vm->current_snapshot = parentsnap;
    }

    if (unlink(snapFile) < 0)
        VIR_WARN("Failed to unlink %s", snapFile);
2052
    virDomainSnapshotObjListRemove(vm->snapshots, snap);
2053 2054 2055 2056 2057

    ret = 0;

cleanup:
    VIR_FREE(snapFile);
2058
    virObjectUnref(cfg);
2059 2060 2061 2062 2063 2064 2065 2066 2067
    return ret;
}

/* Hash iterator callback to discard multiple snapshots.  */
void qemuDomainSnapshotDiscardAll(void *payload,
                                  const void *name ATTRIBUTE_UNUSED,
                                  void *data)
{
    virDomainSnapshotObjPtr snap = payload;
2068
    virQEMUSnapRemovePtr curr = data;
2069 2070 2071 2072 2073 2074 2075 2076 2077 2078 2079
    int err;

    if (snap->def->current)
        curr->current = true;
    err = qemuDomainSnapshotDiscard(curr->driver, curr->vm, snap, false,
                                    curr->metadata_only);
    if (err && !curr->err)
        curr->err = err;
}

int
2080
qemuDomainSnapshotDiscardAllMetadata(virQEMUDriverPtr driver,
2081 2082
                                     virDomainObjPtr vm)
{
2083
    virQEMUSnapRemove rem;
2084 2085 2086 2087 2088

    rem.driver = driver;
    rem.vm = vm;
    rem.metadata_only = true;
    rem.err = 0;
2089 2090
    virDomainSnapshotForEach(vm->snapshots, qemuDomainSnapshotDiscardAll,
                             &rem);
2091 2092 2093 2094 2095

    return rem.err;
}

/*
2096
 * The caller must hold a lock the vm and there must
2097 2098 2099
 * be no remaining references to vm.
 */
void
2100
qemuDomainRemoveInactive(virQEMUDriverPtr driver,
2101 2102
                         virDomainObjPtr vm)
{
2103
    char *snapDir;
2104
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
2105

2106 2107 2108 2109 2110
    /* Remove any snapshot metadata prior to removing the domain */
    if (qemuDomainSnapshotDiscardAllMetadata(driver, vm) < 0) {
        VIR_WARN("unable to remove all snapshots for domain %s",
                 vm->def->name);
    }
2111
    else if (virAsprintf(&snapDir, "%s/%s", cfg->snapshotDir,
2112 2113
                         vm->def->name) < 0) {
        VIR_WARN("unable to remove snapshot directory %s/%s",
2114
                 cfg->snapshotDir, vm->def->name);
2115 2116 2117 2118 2119
    } else {
        if (rmdir(snapDir) < 0 && errno != ENOENT)
            VIR_WARN("unable to remove snapshot directory %s", snapDir);
        VIR_FREE(snapDir);
    }
2120
    virDomainObjListRemove(driver->domains, vm);
2121
    virObjectUnref(cfg);
2122
}
2123 2124

void
2125
qemuDomainSetFakeReboot(virQEMUDriverPtr driver,
2126 2127 2128 2129
                        virDomainObjPtr vm,
                        bool value)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
2130
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
2131 2132

    if (priv->fakeReboot == value)
2133
        goto cleanup;
2134 2135 2136

    priv->fakeReboot = value;

2137
    if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm) < 0)
2138
        VIR_WARN("Failed to save status on vm %s", vm->def->name);
2139

2140
cleanup:
2141
    virObjectUnref(cfg);
2142
}
M
Michal Privoznik 已提交
2143

2144 2145 2146 2147 2148 2149
static int
qemuDomainCheckRemoveOptionalDisk(virQEMUDriverPtr driver,
                                  virDomainObjPtr vm,
                                  virDomainDiskDefPtr disk)
{
    char uuid[VIR_UUID_STRING_BUFLEN];
2150
    virObjectEventPtr event = NULL;
2151 2152 2153 2154 2155 2156 2157 2158 2159 2160 2161 2162 2163 2164 2165 2166 2167 2168 2169 2170 2171 2172 2173 2174 2175 2176 2177 2178 2179 2180 2181 2182 2183 2184
    virDomainDiskDefPtr del_disk = NULL;

    virUUIDFormat(vm->def->uuid, uuid);

    VIR_DEBUG("Dropping disk '%s' on domain '%s' (UUID '%s') "
              "due to inaccessible source '%s'",
              disk->dst, vm->def->name, uuid, disk->src);

    if (disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM ||
        disk->device == VIR_DOMAIN_DISK_DEVICE_FLOPPY) {

        event = virDomainEventDiskChangeNewFromObj(vm, disk->src, NULL,
                                                   disk->info.alias,
                                                   VIR_DOMAIN_EVENT_DISK_CHANGE_MISSING_ON_START);
        VIR_FREE(disk->src);
    } else {
        event = virDomainEventDiskChangeNewFromObj(vm, disk->src, NULL,
                                                   disk->info.alias,
                                                   VIR_DOMAIN_EVENT_DISK_DROP_MISSING_ON_START);

        if (!(del_disk = virDomainDiskRemoveByName(vm->def, disk->src))) {
            virReportError(VIR_ERR_INVALID_ARG,
                           _("no source device %s"), disk->src);
            return -1;
        }
        virDomainDiskDefFree(del_disk);
    }

    if (event)
        qemuDomainEventQueue(driver, event);

    return 0;
}

2185 2186 2187 2188 2189 2190 2191 2192 2193 2194 2195 2196 2197 2198 2199 2200 2201 2202 2203
static int
qemuDomainCheckDiskStartupPolicy(virQEMUDriverPtr driver,
                                 virDomainObjPtr vm,
                                 virDomainDiskDefPtr disk,
                                 bool cold_boot)
{
    char uuid[VIR_UUID_STRING_BUFLEN];
    int startupPolicy = disk->startupPolicy;

    virUUIDFormat(vm->def->uuid, uuid);

    switch ((enum virDomainStartupPolicy) startupPolicy) {
        case VIR_DOMAIN_STARTUP_POLICY_OPTIONAL:
            break;

        case VIR_DOMAIN_STARTUP_POLICY_MANDATORY:
            goto error;

        case VIR_DOMAIN_STARTUP_POLICY_REQUISITE:
2204
            if (cold_boot)
2205 2206 2207 2208 2209 2210 2211 2212 2213
                goto error;
            break;

        case VIR_DOMAIN_STARTUP_POLICY_DEFAULT:
        case VIR_DOMAIN_STARTUP_POLICY_LAST:
            /* this should never happen */
            break;
    }

2214 2215
    if (qemuDomainCheckRemoveOptionalDisk(driver, vm, disk) < 0)
        goto error;
2216 2217 2218 2219 2220 2221 2222

    return 0;

error:
    return -1;
}

M
Michal Privoznik 已提交
2223
int
2224
qemuDomainCheckDiskPresence(virQEMUDriverPtr driver,
M
Michal Privoznik 已提交
2225
                            virDomainObjPtr vm,
2226
                            bool cold_boot)
M
Michal Privoznik 已提交
2227 2228
{
    int ret = -1;
2229
    size_t i;
M
Michal Privoznik 已提交
2230 2231
    virDomainDiskDefPtr disk;

2232
    VIR_DEBUG("Checking for disk presence");
2233 2234
    for (i = vm->def->ndisks; i > 0; i--) {
        disk = vm->def->disks[i - 1];
M
Michal Privoznik 已提交
2235

2236
        if (!disk->src)
M
Michal Privoznik 已提交
2237 2238
            continue;

2239
        if (qemuDomainDetermineDiskChain(driver, vm, disk, false) >= 0 &&
2240
            qemuDiskChainCheckBroken(disk) >= 0)
M
Michal Privoznik 已提交
2241
            continue;
2242

2243 2244 2245 2246 2247
        if (disk->startupPolicy &&
            qemuDomainCheckDiskStartupPolicy(driver, vm, disk,
                                             cold_boot) >= 0) {
            virResetLastError();
            continue;
M
Michal Privoznik 已提交
2248 2249
        }

2250
        goto error;
M
Michal Privoznik 已提交
2251 2252 2253 2254
    }

    ret = 0;

2255
error:
M
Michal Privoznik 已提交
2256 2257
    return ret;
}
2258 2259 2260 2261 2262 2263 2264 2265 2266 2267

/*
 * The vm must be locked when any of the following cleanup functions is
 * called.
 */
int
qemuDomainCleanupAdd(virDomainObjPtr vm,
                     qemuDomainCleanupCallback cb)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
2268
    size_t i;
2269 2270 2271 2272 2273 2274 2275 2276 2277 2278

    VIR_DEBUG("vm=%s, cb=%p", vm->def->name, cb);

    for (i = 0; i < priv->ncleanupCallbacks; i++) {
        if (priv->cleanupCallbacks[i] == cb)
            return 0;
    }

    if (VIR_RESIZE_N(priv->cleanupCallbacks,
                     priv->ncleanupCallbacks_max,
2279
                     priv->ncleanupCallbacks, 1) < 0)
2280 2281 2282 2283 2284 2285 2286 2287 2288 2289 2290
        return -1;

    priv->cleanupCallbacks[priv->ncleanupCallbacks++] = cb;
    return 0;
}

void
qemuDomainCleanupRemove(virDomainObjPtr vm,
                        qemuDomainCleanupCallback cb)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
2291
    size_t i;
2292 2293 2294 2295

    VIR_DEBUG("vm=%s, cb=%p", vm->def->name, cb);

    for (i = 0; i < priv->ncleanupCallbacks; i++) {
2296 2297 2298
        if (priv->cleanupCallbacks[i] == cb)
            VIR_DELETE_ELEMENT_INPLACE(priv->cleanupCallbacks,
                                       i, priv->ncleanupCallbacks);
2299 2300 2301 2302 2303 2304 2305 2306
    }

    VIR_SHRINK_N(priv->cleanupCallbacks,
                 priv->ncleanupCallbacks_max,
                 priv->ncleanupCallbacks_max - priv->ncleanupCallbacks);
}

void
2307
qemuDomainCleanupRun(virQEMUDriverPtr driver,
2308 2309 2310
                     virDomainObjPtr vm)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
2311
    size_t i;
2312 2313 2314 2315

    VIR_DEBUG("driver=%p, vm=%s", driver, vm->def->name);

    /* run cleanup callbacks in reverse order */
2316 2317
    for (i = 0; i < priv->ncleanupCallbacks; i++) {
        if (priv->cleanupCallbacks[priv->ncleanupCallbacks - (i + 1)])
2318 2319 2320 2321 2322 2323 2324
            priv->cleanupCallbacks[i](driver, vm);
    }

    VIR_FREE(priv->cleanupCallbacks);
    priv->ncleanupCallbacks = 0;
    priv->ncleanupCallbacks_max = 0;
}
2325

2326 2327 2328 2329 2330 2331 2332 2333 2334 2335 2336 2337 2338 2339 2340 2341 2342 2343 2344 2345 2346 2347
int
qemuDiskChainCheckBroken(virDomainDiskDefPtr disk)
{
    char *brokenFile = NULL;

    if (!disk->src || !disk->backingChain)
        return 0;

    if (virStorageFileChainGetBroken(disk->backingChain, &brokenFile) < 0)
        return -1;

    if (brokenFile) {
        virReportError(VIR_ERR_INVALID_ARG,
                       _("Backing file '%s' of image '%s' is missing."),
                       brokenFile, disk->src);
        VIR_FREE(brokenFile);
        return -1;
    }

    return 0;
}

2348 2349 2350 2351 2352 2353 2354 2355 2356 2357 2358 2359 2360 2361 2362 2363 2364 2365 2366 2367 2368 2369 2370 2371 2372 2373 2374 2375 2376 2377
static void
qemuDomainGetImageIds(virQEMUDriverConfigPtr cfg,
                      virDomainObjPtr vm,
                      virDomainDiskDefPtr disk,
                      uid_t *uid, gid_t *gid)
{
    virSecurityLabelDefPtr vmlabel;
    virSecurityDeviceLabelDefPtr disklabel;

    if (uid)
        *uid = -1;
    if (gid)
        *gid = -1;

    if (cfg) {
        if (uid)
            *uid = cfg->user;

        if (gid)
            *gid = cfg->group;
    }

    if (vm && (vmlabel = virDomainDefGetSecurityLabelDef(vm->def, "dac")))
        virParseOwnershipIds(vmlabel->label, uid, gid);

    if ((disklabel = virDomainDiskDefGetSecurityLabelDef(disk, "dac")))
        virParseOwnershipIds(disklabel->label, uid, gid);
}


2378
int
2379
qemuDomainDetermineDiskChain(virQEMUDriverPtr driver,
2380
                             virDomainObjPtr vm,
2381 2382 2383
                             virDomainDiskDefPtr disk,
                             bool force)
{
2384 2385
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
    int ret = 0;
2386 2387
    uid_t uid;
    gid_t gid;
2388

2389 2390 2391
    if (!disk->src ||
        disk->type == VIR_DOMAIN_DISK_TYPE_NETWORK ||
        disk->type == VIR_DOMAIN_DISK_TYPE_VOLUME)
2392
        goto cleanup;
2393 2394 2395 2396 2397 2398

    if (disk->backingChain) {
        if (force) {
            virStorageFileFreeMetadata(disk->backingChain);
            disk->backingChain = NULL;
        } else {
2399
            goto cleanup;
2400 2401
        }
    }
2402 2403 2404

    qemuDomainGetImageIds(cfg, vm, disk, &uid, &gid);

2405
    disk->backingChain = virStorageFileGetMetadata(disk->src, disk->format,
2406
                                                   uid, gid,
2407
                                                   cfg->allowDiskFormatProbing);
2408
    if (!disk->backingChain)
2409 2410 2411 2412 2413
        ret = -1;

cleanup:
    virObjectUnref(cfg);
    return ret;
2414
}
2415

2416 2417 2418 2419 2420 2421 2422 2423 2424 2425 2426 2427 2428 2429 2430 2431 2432 2433 2434 2435 2436
int
qemuDomainUpdateDeviceList(virQEMUDriverPtr driver,
                           virDomainObjPtr vm)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    char **aliases;

    if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DEVICE_DEL_EVENT))
        return 0;

    qemuDomainObjEnterMonitor(driver, vm);
    if (qemuMonitorGetDeviceAliases(priv->mon, &aliases) < 0) {
        qemuDomainObjExitMonitor(driver, vm);
        return -1;
    }
    qemuDomainObjExitMonitor(driver, vm);

    virStringFreeList(priv->qemuDevices);
    priv->qemuDevices = aliases;
    return 0;
}
2437 2438 2439 2440 2441 2442 2443 2444 2445 2446 2447 2448 2449 2450 2451 2452 2453 2454 2455 2456 2457 2458

bool
qemuDomainDefCheckABIStability(virQEMUDriverPtr driver,
                               virDomainDefPtr src,
                               virDomainDefPtr dst)
{
    virDomainDefPtr migratableDefSrc = NULL;
    virDomainDefPtr migratableDefDst = NULL;
    const int flags = VIR_DOMAIN_XML_SECURE | VIR_DOMAIN_XML_UPDATE_CPU | VIR_DOMAIN_XML_MIGRATABLE;
    bool ret = false;

    if (!(migratableDefSrc = qemuDomainDefCopy(driver, src, flags)) ||
        !(migratableDefDst = qemuDomainDefCopy(driver, dst, flags)))
        goto cleanup;

    ret = virDomainDefCheckABIStability(migratableDefSrc, migratableDefDst);

cleanup:
    virDomainDefFree(migratableDefSrc);
    virDomainDefFree(migratableDefDst);
    return ret;
}