qemu_conf.c 19.5 KB
Newer Older
D
Daniel P. Berrange 已提交
1
/*
2
 * qemu_conf.c: QEMU configuration management
D
Daniel P. Berrange 已提交
3
 *
4
 * Copyright (C) 2006-2012 Red Hat, Inc.
D
Daniel P. Berrange 已提交
5 6 7 8 9 10 11 12 13 14 15 16 17
 * Copyright (C) 2006 Daniel P. Berrange
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
18
 * License along with this library.  If not, see
O
Osier Yang 已提交
19
 * <http://www.gnu.org/licenses/>.
D
Daniel P. Berrange 已提交
20 21 22 23
 *
 * Author: Daniel P. Berrange <berrange@redhat.com>
 */

24
#include <config.h>
25

D
Daniel P. Berrange 已提交
26 27 28 29
#include <string.h>
#include <limits.h>
#include <sys/types.h>
#include <sys/stat.h>
30
#include <stdlib.h>
D
Daniel P. Berrange 已提交
31 32 33
#include <unistd.h>
#include <errno.h>
#include <fcntl.h>
34
#include <sys/wait.h>
35
#include <arpa/inet.h>
D
Daniel P. Berrange 已提交
36

37
#include "virerror.h"
38
#include "qemu_conf.h"
39
#include "qemu_command.h"
40
#include "qemu_capabilities.h"
41
#include "qemu_bridge_filter.h"
42
#include "viruuid.h"
43
#include "virbuffer.h"
44
#include "virconf.h"
45
#include "virutil.h"
46
#include "viralloc.h"
47
#include "datatypes.h"
48
#include "virxml.h"
49
#include "nodeinfo.h"
50
#include "virlog.h"
51
#include "cpu/cpu.h"
52
#include "domain_nwfilter.h"
E
Eric Blake 已提交
53
#include "virfile.h"
54
#include "configmake.h"
55

56 57
#define VIR_FROM_THIS VIR_FROM_QEMU

58 59 60 61 62
struct _qemuDriverCloseDef {
    virConnectPtr conn;
    qemuDriverCloseCallback cb;
};

63
void qemuDriverLock(virQEMUDriverPtr driver)
64 65 66
{
    virMutexLock(&driver->lock);
}
67
void qemuDriverUnlock(virQEMUDriverPtr driver)
68 69 70 71 72
{
    virMutexUnlock(&driver->lock);
}


73
int qemuLoadDriverConfig(virQEMUDriverPtr driver,
74
                         const char *filename) {
75
    virConfPtr conf = NULL;
D
Daniel P. Berrange 已提交
76
    virConfValuePtr p;
77 78 79
    char *user = NULL;
    char *group = NULL;
    int ret = -1;
80
    int i;
D
Daniel P. Berrange 已提交
81

82
    /* Setup critical defaults */
83 84
    driver->securityDefaultConfined = true;
    driver->securityRequireConfined = false;
85
    driver->dynamicOwnership = 1;
86
    driver->clearEmulatorCapabilities = 1;
87

88 89
    if (!(driver->vncListen = strdup("127.0.0.1")))
        goto no_memory;
90 91 92 93

    driver->remotePortMin = QEMU_REMOTE_PORT_MIN;
    driver->remotePortMax = QEMU_REMOTE_PORT_MAX;

94 95 96 97 98
    if (!(driver->vncTLSx509certdir = strdup(SYSCONFDIR "/pki/libvirt-vnc")))
        goto no_memory;

    if (!(driver->spiceListen = strdup("127.0.0.1")))
        goto no_memory;
D
Daniel P. Berrange 已提交
99

100
    if (!(driver->spiceTLSx509certdir
101 102
          = strdup(SYSCONFDIR "/pki/libvirt-spice")))
        goto no_memory;
103

104
#if defined HAVE_MNTENT_H && defined HAVE_GETMNTENT_R
105 106 107 108 109 110
    /* For privileged driver, try and find hugepage mount automatically.
     * Non-privileged driver requires admin to create a dir for the
     * user, chown it, and then let user configure it manually */
    if (driver->privileged &&
        !(driver->hugetlbfs_mount = virFileFindMountPoint("hugetlbfs"))) {
        if (errno != ENOENT) {
111
            virReportSystemError(errno, "%s",
112
                                 _("unable to find hugetlbfs mountpoint"));
113
            goto cleanup;
114 115 116 117
        }
    }
#endif

118 119 120 121
    if (!(driver->lockManager = virLockManagerPluginNew("nop",
                                                        "qemu",
                                                        driver->configBaseDir,
                                                        0)))
122
        goto cleanup;
123

124 125
    driver->keepAliveInterval = 5;
    driver->keepAliveCount = 5;
126
    driver->seccompSandbox = -1;
127

D
Daniel P. Berrange 已提交
128 129 130
    /* Just check the file is readable before opening it, otherwise
     * libvirt emits an error.
     */
131
    if (access(filename, R_OK) == -1) {
132
        VIR_INFO("Could not read qemu config file %s", filename);
133 134
        ret = 0;
        goto cleanup;
135
    }
D
Daniel P. Berrange 已提交
136

137 138
    if (!(conf = virConfReadFile(filename, 0)))
        goto cleanup;
D
Daniel P. Berrange 已提交
139

140 141 142 143 144
#define CHECK_TYPE(name,typ)                          \
    if (p && p->type != (typ)) {                      \
        virReportError(VIR_ERR_INTERNAL_ERROR,        \
                       "%s: %s: expected type " #typ, \
                       filename, (name));             \
145
        goto cleanup;                                 \
146 147 148 149 150 151 152 153 154 155 156 157 158
    }

#define GET_VALUE_LONG(NAME, VAR)     \
    p = virConfGetValue(conf, NAME);  \
    CHECK_TYPE(NAME, VIR_CONF_LONG);  \
    if (p)                            \
        VAR = p->l;

#define GET_VALUE_STR(NAME, VAR)           \
    p = virConfGetValue(conf, NAME);       \
    CHECK_TYPE(NAME, VIR_CONF_STRING);     \
    if (p && p->str) {                     \
        VIR_FREE(VAR);                     \
159 160
        if (!(VAR = strdup(p->str)))       \
            goto no_memory;                \
161 162 163 164 165 166 167 168 169 170 171
    }

    GET_VALUE_LONG("vnc_auto_unix_socket", driver->vncAutoUnixSocket);
    GET_VALUE_LONG("vnc_tls", driver->vncTLS);
    GET_VALUE_LONG("vnc_tls_x509_verify", driver->vncTLSx509verify);
    GET_VALUE_STR("vnc_tls_x509_cert_dir", driver->vncTLSx509certdir);
    GET_VALUE_STR("vnc_listen", driver->vncListen);
    GET_VALUE_STR("vnc_password", driver->vncPassword);
    GET_VALUE_LONG("vnc_sasl", driver->vncSASL);
    GET_VALUE_STR("vnc_sasl_dir", driver->vncSASLdir);
    GET_VALUE_LONG("vnc_allow_host_audio", driver->vncAllowHostAudio);
172

173
    p = virConfGetValue(conf, "security_driver");
174 175 176 177
    if (p && p->type == VIR_CONF_LIST) {
        size_t len;
        virConfValuePtr pp;

J
Ján Tomko 已提交
178
        /* Calc length and check items */
179 180
        for (len = 0, pp = p->list; pp; len++, pp = pp->next) {
            if (pp->type != VIR_CONF_STRING) {
181 182 183
                virReportError(VIR_ERR_CONF_SYNTAX, "%s",
                               _("security_driver must be a list of strings"));
                goto cleanup;
184 185 186
            }
        }

187 188
        if (VIR_ALLOC_N(driver->securityDriverNames, len + 1) < 0)
            goto no_memory;
189 190

        for (i = 0, pp = p->list; pp; i++, pp = pp->next) {
191 192
            if (!(driver->securityDriverNames[i] = strdup(pp->str)))
                goto no_memory;
193 194 195
        }
        driver->securityDriverNames[len] = NULL;
    } else {
196
        CHECK_TYPE("security_driver", VIR_CONF_STRING);
197 198
        if (p && p->str) {
            if (VIR_ALLOC_N(driver->securityDriverNames, 2) < 0 ||
199 200 201
                !(driver->securityDriverNames[0] = strdup(p->str)))
                goto no_memory;

202 203
            driver->securityDriverNames[1] = NULL;
        }
204 205
    }

206 207
    GET_VALUE_LONG("security_default_confined", driver->securityDefaultConfined);
    GET_VALUE_LONG("security_require_confined", driver->securityRequireConfined);
208

209 210 211 212
    GET_VALUE_LONG("spice_tls", driver->spiceTLS);
    GET_VALUE_STR("spice_tls_x509_cert_dir", driver->spiceTLSx509certdir);
    GET_VALUE_STR("spice_listen", driver->spiceListen);
    GET_VALUE_STR("spice_password", driver->spicePassword);
213 214


215 216 217 218 219 220 221 222 223
    GET_VALUE_LONG("remote_display_port_min", driver->remotePortMin);
    if (driver->remotePortMin < QEMU_REMOTE_PORT_MIN) {
        /* if the port is too low, we can't get the display name
         * to tell to vnc (usually subtract 5900, e.g. localhost:1
         * for port 5901) */
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("%s: remote_display_port_min: port must be greater "
                         "than or equal to %d"),
                        filename, QEMU_REMOTE_PORT_MIN);
224
        goto cleanup;
225 226
    }

227 228 229 230 231 232 233
    GET_VALUE_LONG("remote_display_port_max", driver->remotePortMax);
    if (driver->remotePortMax > QEMU_REMOTE_PORT_MAX ||
        driver->remotePortMax < driver->remotePortMin) {
        virReportError(VIR_ERR_INTERNAL_ERROR,
                        _("%s: remote_display_port_max: port must be between "
                          "the minimal port and %d"),
                       filename, QEMU_REMOTE_PORT_MAX);
234
        goto cleanup;
235 236 237 238
    }

    if (driver->remotePortMin > driver->remotePortMax) {
        virReportError(VIR_ERR_INTERNAL_ERROR,
239 240
                        _("%s: remote_display_port_min: min port must not be "
                          "greater than max port"), filename);
241
        goto cleanup;
242 243
    }

244 245
    p = virConfGetValue(conf, "user");
    CHECK_TYPE("user", VIR_CONF_STRING);
246 247
    if (!(user = strdup(p && p->str ? p->str : QEMU_USER)))
        goto no_memory;
248

249 250
    if (virGetUserID(user, &driver->user) < 0)
        goto cleanup;
251

252 253
    p = virConfGetValue(conf, "group");
    CHECK_TYPE("group", VIR_CONF_STRING);
254 255 256 257 258
    if (!(group = strdup(p && p->str ? p->str : QEMU_GROUP)))
        goto no_memory;

    if (virGetGroupID(group, &driver->group) < 0)
        goto cleanup;
259

260
    GET_VALUE_LONG("dynamic_ownership", driver->dynamicOwnership);
261

262 263
    p = virConfGetValue(conf, "cgroup_controllers");
    CHECK_TYPE("cgroup_controllers", VIR_CONF_LIST);
264 265 266 267 268
    if (p) {
        virConfValuePtr pp;
        for (i = 0, pp = p->list; pp; ++i, pp = pp->next) {
            int ctl;
            if (pp->type != VIR_CONF_STRING) {
269 270 271 272
                virReportError(VIR_ERR_CONF_SYNTAX, "%s",
                               _("cgroup_controllers must be a "
                                 "list of strings"));
                goto cleanup;
273
            }
274 275 276 277 278

            if ((ctl = virCgroupControllerTypeFromString(pp->str)) < 0) {
                virReportError(VIR_ERR_CONF_SYNTAX,
                               _("Unknown cgroup controller '%s'"), pp->str);
                goto cleanup;
279 280 281 282 283 284
            }
            driver->cgroupControllers |= (1 << ctl);
        }
    } else {
        driver->cgroupControllers =
            (1 << VIR_CGROUP_CONTROLLER_CPU) |
285
            (1 << VIR_CGROUP_CONTROLLER_DEVICES) |
286
            (1 << VIR_CGROUP_CONTROLLER_MEMORY) |
H
Hu Tao 已提交
287
            (1 << VIR_CGROUP_CONTROLLER_BLKIO) |
288 289
            (1 << VIR_CGROUP_CONTROLLER_CPUSET) |
            (1 << VIR_CGROUP_CONTROLLER_CPUACCT);
290 291 292 293 294 295 296 297
    }
    for (i = 0 ; i < VIR_CGROUP_CONTROLLER_LAST ; i++) {
        if (driver->cgroupControllers & (1 << i)) {
            VIR_INFO("Configured cgroup controller '%s'",
                     virCgroupControllerTypeToString(i));
        }
    }

298 299
    p = virConfGetValue(conf, "cgroup_device_acl");
    CHECK_TYPE("cgroup_device_acl", VIR_CONF_LIST);
300 301 302 303 304
    if (p) {
        int len = 0;
        virConfValuePtr pp;
        for (pp = p->list; pp; pp = pp->next)
            len++;
305 306 307
        if (VIR_ALLOC_N(driver->cgroupDeviceACL, 1+len) < 0)
            goto no_memory;

308 309
        for (i = 0, pp = p->list; pp; ++i, pp = pp->next) {
            if (pp->type != VIR_CONF_STRING) {
310 311 312 313
                virReportError(VIR_ERR_CONF_SYNTAX, "%s",
                               _("cgroup_device_acl must be a "
                                 "list of strings"));
                goto cleanup;
314
            }
315 316
            if (!(driver->cgroupDeviceACL[i] = strdup(pp->str)))
                goto no_memory;
317 318 319 320
        }
        driver->cgroupDeviceACL[i] = NULL;
    }

321 322 323 324 325
    GET_VALUE_STR("save_image_format", driver->saveImageFormat);
    GET_VALUE_STR("dump_image_format", driver->dumpImageFormat);
    GET_VALUE_STR("auto_dump_path", driver->autoDumpPath);
    GET_VALUE_LONG("auto_dump_bypass_cache", driver->autoDumpBypassCache);
    GET_VALUE_LONG("auto_start_bypass_cache", driver->autoStartBypassCache);
326

327
    GET_VALUE_STR("hugetlbfs_mount", driver->hugetlbfs_mount);
328

329 330
    p = virConfGetValue(conf, "mac_filter");
    CHECK_TYPE("mac_filter", VIR_CONF_LONG);
331
    if (p && p->l) {
332 333 334
        driver->macFilter = p->l;
        if (!(driver->ebtables = ebtablesContextNew("qemu"))) {
            driver->macFilter = 0;
335
            virReportSystemError(errno,
S
Stefan Berger 已提交
336
                                 _("failed to enable mac filter in '%s'"),
337
                                 __FILE__);
338
            goto cleanup;
339 340 341
        }

        if ((errno = networkDisableAllFrames(driver))) {
342
            virReportSystemError(errno,
343 344
                         _("failed to add rule to drop all frames in '%s'"),
                                 __FILE__);
345
            goto cleanup;
346 347 348
        }
    }

349 350 351 352 353 354
    GET_VALUE_LONG("relaxed_acs_check", driver->relaxedACS);
    GET_VALUE_LONG("clear_emulator_capabilities", driver->clearEmulatorCapabilities);
    GET_VALUE_LONG("allow_disk_format_probing", driver->allowDiskFormatProbing);
    GET_VALUE_LONG("set_process_name", driver->setProcessName);
    GET_VALUE_LONG("max_processes", driver->maxProcesses);
    GET_VALUE_LONG("max_files", driver->maxFiles);
355

356 357
    p = virConfGetValue(conf, "lock_manager");
    CHECK_TYPE("lock_manager", VIR_CONF_STRING);
358 359 360
    if (p && p->str) {
        virLockManagerPluginUnref(driver->lockManager);
        if (!(driver->lockManager =
361
              virLockManagerPluginNew(p->str, "qemu", driver->configBaseDir, 0)))
362 363 364
            VIR_ERROR(_("Failed to load lock manager %s"), p->str);
    }

365 366 367 368
    GET_VALUE_LONG("max_queued", driver->max_queued);
    GET_VALUE_LONG("keepalive_interval", driver->keepAliveInterval);
    GET_VALUE_LONG("keepalive_count", driver->keepAliveCount);
    GET_VALUE_LONG("seccomp_sandbox", driver->seccompSandbox);
369

370 371 372 373 374
    ret = 0;

cleanup:
    VIR_FREE(user);
    VIR_FREE(group);
375
    virConfFree(conf);
376 377 378 379 380
    return ret;

no_memory:
    virReportOOMError();
    goto cleanup;
D
Daniel P. Berrange 已提交
381
}
382 383
#undef GET_VALUE_LONG
#undef GET_VALUE_STRING
384 385 386 387 388 389 390 391 392

static void
qemuDriverCloseCallbackFree(void *payload,
                            const void *name ATTRIBUTE_UNUSED)
{
    VIR_FREE(payload);
}

int
393
qemuDriverCloseCallbackInit(virQEMUDriverPtr driver)
394 395 396 397 398 399 400 401 402
{
    driver->closeCallbacks = virHashCreate(5, qemuDriverCloseCallbackFree);
    if (!driver->closeCallbacks)
        return -1;

    return 0;
}

void
403
qemuDriverCloseCallbackShutdown(virQEMUDriverPtr driver)
404 405 406 407 408
{
    virHashFree(driver->closeCallbacks);
}

int
409
qemuDriverCloseCallbackSet(virQEMUDriverPtr driver,
410 411 412 413 414 415 416 417 418 419 420 421 422 423
                           virDomainObjPtr vm,
                           virConnectPtr conn,
                           qemuDriverCloseCallback cb)
{
    char uuidstr[VIR_UUID_STRING_BUFLEN];
    qemuDriverCloseDefPtr closeDef;

    virUUIDFormat(vm->def->uuid, uuidstr);
    VIR_DEBUG("vm=%s, uuid=%s, conn=%p, cb=%p",
              vm->def->name, uuidstr, conn, cb);

    closeDef = virHashLookup(driver->closeCallbacks, uuidstr);
    if (closeDef) {
        if (closeDef->conn != conn) {
424 425 426 427
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           _("Close callback for domain %s already registered"
                             " with another connection %p"),
                           vm->def->name, closeDef->conn);
428 429 430
            return -1;
        }
        if (closeDef->cb && closeDef->cb != cb) {
431 432 433
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           _("Another close callback is already defined for"
                             " domain %s"), vm->def->name);
434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454
            return -1;
        }

        closeDef->cb = cb;
    } else {
        if (VIR_ALLOC(closeDef) < 0) {
            virReportOOMError();
            return -1;
        }

        closeDef->conn = conn;
        closeDef->cb = cb;
        if (virHashAddEntry(driver->closeCallbacks, uuidstr, closeDef) < 0) {
            VIR_FREE(closeDef);
            return -1;
        }
    }
    return 0;
}

int
455
qemuDriverCloseCallbackUnset(virQEMUDriverPtr driver,
456 457 458 459 460 461 462 463 464 465 466 467 468 469 470
                             virDomainObjPtr vm,
                             qemuDriverCloseCallback cb)
{
    char uuidstr[VIR_UUID_STRING_BUFLEN];
    qemuDriverCloseDefPtr closeDef;

    virUUIDFormat(vm->def->uuid, uuidstr);
    VIR_DEBUG("vm=%s, uuid=%s, cb=%p",
              vm->def->name, uuidstr, cb);

    closeDef = virHashLookup(driver->closeCallbacks, uuidstr);
    if (!closeDef)
        return -1;

    if (closeDef->cb && closeDef->cb != cb) {
471 472 473
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("Trying to remove mismatching close callback for"
                         " domain %s"), vm->def->name);
474 475 476 477 478 479 480
        return -1;
    }

    return virHashRemoveEntry(driver->closeCallbacks, uuidstr);
}

qemuDriverCloseCallback
481
qemuDriverCloseCallbackGet(virQEMUDriverPtr driver,
482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501
                           virDomainObjPtr vm,
                           virConnectPtr conn)
{
    char uuidstr[VIR_UUID_STRING_BUFLEN];
    qemuDriverCloseDefPtr closeDef;
    qemuDriverCloseCallback cb = NULL;

    virUUIDFormat(vm->def->uuid, uuidstr);
    VIR_DEBUG("vm=%s, uuid=%s, conn=%p",
              vm->def->name, uuidstr, conn);

    closeDef = virHashLookup(driver->closeCallbacks, uuidstr);
    if (closeDef && (!conn || closeDef->conn == conn))
        cb = closeDef->cb;

    VIR_DEBUG("cb=%p", cb);
    return cb;
}

struct qemuDriverCloseCallbackData {
502
    virQEMUDriverPtr driver;
503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534
    virConnectPtr conn;
};

static void
qemuDriverCloseCallbackRun(void *payload,
                           const void *name,
                           void *opaque)
{
    struct qemuDriverCloseCallbackData *data = opaque;
    qemuDriverCloseDefPtr closeDef = payload;
    const char *uuidstr = name;
    unsigned char uuid[VIR_UUID_BUFLEN];
    virDomainObjPtr dom;

    VIR_DEBUG("conn=%p, thisconn=%p, uuid=%s, cb=%p",
              closeDef->conn, data->conn, uuidstr, closeDef->cb);

    if (data->conn != closeDef->conn || !closeDef->cb)
        return;

    if (virUUIDParse(uuidstr, uuid) < 0) {
        VIR_WARN("Failed to parse %s", uuidstr);
        return;
    }

    if (!(dom = virDomainFindByUUID(&data->driver->domains, uuid))) {
        VIR_DEBUG("No domain object with UUID %s", uuidstr);
        return;
    }

    dom = closeDef->cb(data->driver, dom, data->conn);
    if (dom)
535
        virObjectUnlock(dom);
536 537 538 539 540

    virHashRemoveEntry(data->driver->closeCallbacks, uuidstr);
}

void
541
qemuDriverCloseCallbackRunAll(virQEMUDriverPtr driver,
542 543 544 545 546 547 548 549 550
                              virConnectPtr conn)
{
    struct qemuDriverCloseCallbackData data = {
        driver, conn
    };
    VIR_DEBUG("conn=%p", conn);

    virHashForEach(driver->closeCallbacks, qemuDriverCloseCallbackRun, &data);
}
551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636

/* Construct the hash key for sharedDisks as "major:minor" */
char *
qemuGetSharedDiskKey(const char *disk_path)
{
    int maj, min;
    char *key = NULL;
    int rc;

    if ((rc = virGetDeviceID(disk_path, &maj, &min)) < 0) {
        virReportSystemError(-rc,
                             _("Unable to get minor number of device '%s'"),
                             disk_path);
        return NULL;
    }

    if (virAsprintf(&key, "%d:%d", maj, min) < 0) {
        virReportOOMError();
        return NULL;
    }

    return key;
}

/* Increase ref count if the entry already exists, otherwise
 * add a new entry.
 */
int
qemuAddSharedDisk(virHashTablePtr sharedDisks,
                  const char *disk_path)
{
    size_t *ref = NULL;
    char *key = NULL;

    if (!(key = qemuGetSharedDiskKey(disk_path)))
        return -1;

    if ((ref = virHashLookup(sharedDisks, key))) {
        if (virHashUpdateEntry(sharedDisks, key, ++ref) < 0) {
             VIR_FREE(key);
             return -1;
        }
    } else {
        if (virHashAddEntry(sharedDisks, key, (void *)0x1)) {
            VIR_FREE(key);
            return -1;
        }
    }

    VIR_FREE(key);
    return 0;
}

/* Decrease the ref count if the entry already exists, otherwise
 * remove the entry.
 */
int
qemuRemoveSharedDisk(virHashTablePtr sharedDisks,
                     const char *disk_path)
{
    size_t *ref = NULL;
    char *key = NULL;

    if (!(key = qemuGetSharedDiskKey(disk_path)))
        return -1;

    if (!(ref = virHashLookup(sharedDisks, key))) {
        VIR_FREE(key);
        return -1;
    }

    if (ref != (void *)0x1) {
        if (virHashUpdateEntry(sharedDisks, key, --ref) < 0) {
             VIR_FREE(key);
             return -1;
        }
    } else {
        if (virHashRemoveEntry(sharedDisks, key) < 0) {
            VIR_FREE(key);
            return -1;
        }
    }

    VIR_FREE(key);
    return 0;
}