libxl_conf.c 51.9 KB
Newer Older
1 2 3
/*
 * libxl_conf.c: libxl configuration management
 *
4
 * Copyright (C) 2012-2014 Red Hat, Inc.
5
 * Copyright (c) 2011-2013 SUSE LINUX Products GmbH, Nuernberg, Germany.
E
Eric Blake 已提交
6
 * Copyright (C) 2011 Univention GmbH.
J
Jim Fehlig 已提交
7 8 9 10 11 12 13 14 15 16 17 18
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
19
 * License along with this library.  If not, see
O
Osier Yang 已提交
20
 * <http://www.gnu.org/licenses/>.
M
Markus Groß 已提交
21 22 23
 *
 * Authors:
 *     Jim Fehlig <jfehlig@novell.com>
24
 *     Markus Groß <gross@univention.de>
J
Jim Fehlig 已提交
25 26 27 28 29 30 31 32 33 34
 */

#include <config.h>

#include <regex.h>
#include <libxl.h>
#include <sys/types.h>
#include <sys/socket.h>

#include "internal.h"
35
#include "virlog.h"
36
#include "virerror.h"
J
Jim Fehlig 已提交
37
#include "datatypes.h"
E
Eric Blake 已提交
38
#include "virfile.h"
J
Jim Fehlig 已提交
39
#include "virstring.h"
40
#include "viralloc.h"
41
#include "viruuid.h"
J
Jim Fehlig 已提交
42
#include "capabilities.h"
43
#include "vircommand.h"
J
Jim Fehlig 已提交
44
#include "libxl_domain.h"
J
Jim Fehlig 已提交
45
#include "libxl_conf.h"
J
Jim Fehlig 已提交
46
#include "libxl_utils.h"
47
#include "virstoragefile.h"
J
Jim Fehlig 已提交
48 49 50 51


#define VIR_FROM_THIS VIR_FROM_LIBXL

52 53
VIR_LOG_INIT("libxl.libxl_conf");

J
Jim Fehlig 已提交
54 55 56 57 58
/* see xen-unstable.hg/xen/include/asm-x86/cpufeature.h */
#define LIBXL_X86_FEATURE_PAE_MASK 0x40


struct guest_arch {
59
    virArch arch;
J
Jim Fehlig 已提交
60 61 62 63 64 65 66
    int bits;
    int hvm;
    int pae;
    int nonpae;
    int ia64_be;
};

67
#define XEN_CAP_REGEX "(xen|hvm)-[[:digit:]]+\\.[[:digit:]]+-(aarch64|armv7l|x86_32|x86_64|ia64|powerpc64)(p|be)?"
J
Jim Fehlig 已提交
68 69


70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102
static virClassPtr libxlDriverConfigClass;
static void libxlDriverConfigDispose(void *obj);

static int libxlConfigOnceInit(void)
{
    if (!(libxlDriverConfigClass = virClassNew(virClassForObject(),
                                               "libxlDriverConfig",
                                               sizeof(libxlDriverConfig),
                                               libxlDriverConfigDispose)))
        return -1;

    return 0;
}

VIR_ONCE_GLOBAL_INIT(libxlConfig)

static void
libxlDriverConfigDispose(void *obj)
{
    libxlDriverConfigPtr cfg = obj;

    virObjectUnref(cfg->caps);
    libxl_ctx_free(cfg->ctx);
    xtl_logger_destroy(cfg->logger);
    if (cfg->logger_file)
        VIR_FORCE_FCLOSE(cfg->logger_file);

    VIR_FREE(cfg->configDir);
    VIR_FREE(cfg->autostartDir);
    VIR_FREE(cfg->logDir);
    VIR_FREE(cfg->stateDir);
    VIR_FREE(cfg->libDir);
    VIR_FREE(cfg->saveDir);
103
    VIR_FREE(cfg->autoDumpDir);
104 105
}

106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161

static libxl_action_on_shutdown
libxlActionFromVirLifecycle(virDomainLifecycleAction action)
{
    switch (action) {
    case VIR_DOMAIN_LIFECYCLE_DESTROY:
        return LIBXL_ACTION_ON_SHUTDOWN_DESTROY;

    case VIR_DOMAIN_LIFECYCLE_RESTART:
        return  LIBXL_ACTION_ON_SHUTDOWN_RESTART;

    case VIR_DOMAIN_LIFECYCLE_RESTART_RENAME:
        return LIBXL_ACTION_ON_SHUTDOWN_RESTART_RENAME;

    case VIR_DOMAIN_LIFECYCLE_PRESERVE:
        return LIBXL_ACTION_ON_SHUTDOWN_PRESERVE;

    case VIR_DOMAIN_LIFECYCLE_LAST:
        break;
    }

    return 0;
}


static libxl_action_on_shutdown
libxlActionFromVirLifecycleCrash(virDomainLifecycleCrashAction action)
{

    switch (action) {
    case VIR_DOMAIN_LIFECYCLE_CRASH_DESTROY:
        return LIBXL_ACTION_ON_SHUTDOWN_DESTROY;

    case VIR_DOMAIN_LIFECYCLE_CRASH_RESTART:
        return  LIBXL_ACTION_ON_SHUTDOWN_RESTART;

    case VIR_DOMAIN_LIFECYCLE_CRASH_RESTART_RENAME:
        return LIBXL_ACTION_ON_SHUTDOWN_RESTART_RENAME;

    case VIR_DOMAIN_LIFECYCLE_CRASH_PRESERVE:
        return LIBXL_ACTION_ON_SHUTDOWN_PRESERVE;

    case VIR_DOMAIN_LIFECYCLE_CRASH_COREDUMP_DESTROY:
        return LIBXL_ACTION_ON_SHUTDOWN_COREDUMP_DESTROY;

    case VIR_DOMAIN_LIFECYCLE_CRASH_COREDUMP_RESTART:
        return LIBXL_ACTION_ON_SHUTDOWN_COREDUMP_RESTART;

    case VIR_DOMAIN_LIFECYCLE_CRASH_LAST:
        break;
    }

    return 0;
}


J
Jim Fehlig 已提交
162 163
static int
libxlCapsInitHost(libxl_ctx *ctx, virCapsPtr caps)
J
Jim Fehlig 已提交
164
{
J
Jim Fehlig 已提交
165 166
    libxl_physinfo phy_info;
    int host_pae;
J
Jim Fehlig 已提交
167

J
Jim Fehlig 已提交
168 169 170 171
    if (libxl_get_physinfo(ctx, &phy_info) != 0) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("Failed to get node physical info from libxenlight"));
        return -1;
J
Jim Fehlig 已提交
172 173
    }

J
Jim Fehlig 已提交
174 175 176 177 178 179 180 181 182
    /* hw_caps is an array of 32-bit words whose meaning is listed in
     * xen-unstable.hg/xen/include/asm-x86/cpufeature.h.  Each feature
     * is defined in the form X*32+Y, corresponding to the Y'th bit in
     * the X'th 32-bit word of hw_cap.
     */
    host_pae = phy_info.hw_cap[0] & LIBXL_X86_FEATURE_PAE_MASK;
    if (host_pae &&
        virCapabilitiesAddHostFeature(caps, "pae") < 0)
        return -1;
J
Jim Fehlig 已提交
183

J
Jim Fehlig 已提交
184
    return 0;
J
Jim Fehlig 已提交
185 186
}

187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266
static int
libxlCapsInitNuma(libxl_ctx *ctx, virCapsPtr caps)
{
    libxl_numainfo *numa_info = NULL;
    libxl_cputopology *cpu_topo = NULL;
    int nr_nodes = 0, nr_cpus = 0;
    virCapsHostNUMACellCPUPtr *cpus = NULL;
    int *nr_cpus_node = NULL;
    size_t i;
    int ret = -1;

    /* Let's try to fetch all the topology information */
    numa_info = libxl_get_numainfo(ctx, &nr_nodes);
    if (numa_info == NULL || nr_nodes == 0) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("libxl_get_numainfo failed"));
        goto cleanup;
    } else {
        cpu_topo = libxl_get_cpu_topology(ctx, &nr_cpus);
        if (cpu_topo == NULL || nr_cpus == 0) {
            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                           _("libxl_get_cpu_topology failed"));
            goto cleanup;
        }
    }

    if (VIR_ALLOC_N(cpus, nr_nodes) < 0)
        goto cleanup;

    if (VIR_ALLOC_N(nr_cpus_node, nr_nodes) < 0)
        goto cleanup;

    /* For each node, prepare a list of CPUs belonging to that node */
    for (i = 0; i < nr_cpus; i++) {
        int node = cpu_topo[i].node;

        if (cpu_topo[i].core == LIBXL_CPUTOPOLOGY_INVALID_ENTRY)
            continue;

        nr_cpus_node[node]++;

        if (nr_cpus_node[node] == 1) {
            if (VIR_ALLOC(cpus[node]) < 0)
                goto cleanup;
        } else {
            if (VIR_REALLOC_N(cpus[node], nr_cpus_node[node]) < 0)
                goto cleanup;
        }

        /* Mapping between what libxl tells and what libvirt wants */
        cpus[node][nr_cpus_node[node]-1].id = i;
        cpus[node][nr_cpus_node[node]-1].socket_id = cpu_topo[i].socket;
        cpus[node][nr_cpus_node[node]-1].core_id = cpu_topo[i].core;
        /* Allocate the siblings maps. We will be filling them later */
        cpus[node][nr_cpus_node[node]-1].siblings = virBitmapNew(nr_cpus);
        if (!cpus[node][nr_cpus_node[node]-1].siblings) {
            virReportOOMError();
            goto cleanup;
        }
    }

    /* Let's now populate the siblings bitmaps */
    for (i = 0; i < nr_cpus; i++) {
        int node = cpu_topo[i].node;
        size_t j;

        if (cpu_topo[i].core == LIBXL_CPUTOPOLOGY_INVALID_ENTRY)
            continue;

        for (j = 0; j < nr_cpus_node[node]; j++) {
            if (cpus[node][j].socket_id == cpu_topo[i].socket &&
                cpus[node][j].core_id == cpu_topo[i].core)
                ignore_value(virBitmapSetBit(cpus[node][j].siblings, i));
        }
    }

    for (i = 0; i < nr_nodes; i++) {
        if (numa_info[i].size == LIBXL_NUMAINFO_INVALID_ENTRY)
            continue;

267
        if (virCapabilitiesAddHostNUMACell(caps, i,
268
                                           numa_info[i].size / 1024,
269
                                           nr_cpus_node[i], cpus[i],
M
Michal Privoznik 已提交
270
                                           0, NULL,
271
                                           0, NULL) < 0) {
272 273 274 275 276 277 278 279 280 281 282 283 284
            virCapabilitiesClearHostNUMACellCPUTopology(cpus[i],
                                                        nr_cpus_node[i]);
            goto cleanup;
        }

        /* This is safe, as the CPU list is now stored in the NUMA cell */
        cpus[i] = NULL;
    }

    ret = 0;

 cleanup:
    if (ret != 0) {
285
        for (i = 0; cpus && i < nr_nodes; i++)
286 287 288 289 290 291 292 293 294 295 296 297
            VIR_FREE(cpus[i]);
        virCapabilitiesFreeNUMAInfo(caps);
    }

    VIR_FREE(cpus);
    VIR_FREE(nr_cpus_node);
    libxl_cputopology_list_free(cpu_topo, nr_cpus);
    libxl_numainfo_list_free(numa_info, nr_nodes);

    return ret;
}

J
Jim Fehlig 已提交
298 299
static int
libxlCapsInitGuests(libxl_ctx *ctx, virCapsPtr caps)
J
Jim Fehlig 已提交
300
{
J
Jim Fehlig 已提交
301
    const libxl_version_info *ver_info;
302 303
    int err;
    regex_t regex;
J
Jim Fehlig 已提交
304 305 306
    char *str, *token;
    regmatch_t subs[4];
    char *saveptr = NULL;
307
    size_t i;
J
Jim Fehlig 已提交
308
    virArch hostarch = caps->host.arch;
J
Jim Fehlig 已提交
309 310 311 312 313 314

    struct guest_arch guest_archs[32];
    int nr_guest_archs = 0;

    memset(guest_archs, 0, sizeof(guest_archs));

J
Jim Fehlig 已提交
315 316 317 318 319
    if ((ver_info = libxl_get_version_info(ctx)) == NULL) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("Failed to get version info from libxenlight"));
        return -1;
    }
320 321 322 323 324 325 326 327 328 329

    err = regcomp(&regex, XEN_CAP_REGEX, REG_EXTENDED);
    if (err != 0) {
        char error[100];
        regerror(err, &regex, error, sizeof(error));
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("Failed to compile regex %s"), error);
        return -1;
    }

J
Jim Fehlig 已提交
330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354
    /* Format of capabilities string is documented in the code in
     * xen-unstable.hg/xen/arch/.../setup.c.
     *
     * It is a space-separated list of supported guest architectures.
     *
     * For x86:
     *    TYP-VER-ARCH[p]
     *    ^   ^   ^    ^
     *    |   |   |    +-- PAE supported
     *    |   |   +------- x86_32 or x86_64
     *    |   +----------- the version of Xen, eg. "3.0"
     *    +--------------- "xen" or "hvm" for para or full virt respectively
     *
     * For IA64:
     *    TYP-VER-ARCH[be]
     *    ^   ^   ^    ^
     *    |   |   |    +-- Big-endian supported
     *    |   |   +------- always "ia64"
     *    |   +----------- the version of Xen, eg. "3.0"
     *    +--------------- "xen" or "hvm" for para or full virt respectively
     */

    /* Split capabilities string into tokens. strtok_r is OK here because
     * we "own" the buffer.  Parse out the features from each token.
     */
J
Jim Fehlig 已提交
355
    for (str = ver_info->capabilities, nr_guest_archs = 0;
J
Jim Fehlig 已提交
356 357 358
         nr_guest_archs < sizeof(guest_archs) / sizeof(guest_archs[0])
                 && (token = strtok_r(str, " ", &saveptr)) != NULL;
         str = NULL) {
359
        if (regexec(&regex, token, sizeof(subs) / sizeof(subs[0]),
J
Jim Fehlig 已提交
360 361
                    subs, 0) == 0) {
            int hvm = STRPREFIX(&token[subs[1].rm_so], "hvm");
362 363
            virArch arch;
            int pae = 0, nonpae = 0, ia64_be = 0;
J
Jim Fehlig 已提交
364 365

            if (STRPREFIX(&token[subs[2].rm_so], "x86_32")) {
366
                arch = VIR_ARCH_I686;
J
Jim Fehlig 已提交
367 368 369 370 371
                if (subs[3].rm_so != -1 &&
                    STRPREFIX(&token[subs[3].rm_so], "p"))
                    pae = 1;
                else
                    nonpae = 1;
372
            } else if (STRPREFIX(&token[subs[2].rm_so], "x86_64")) {
373
                arch = VIR_ARCH_X86_64;
374
            } else if (STRPREFIX(&token[subs[2].rm_so], "ia64")) {
375
                arch = VIR_ARCH_ITANIUM;
J
Jim Fehlig 已提交
376 377 378
                if (subs[3].rm_so != -1 &&
                    STRPREFIX(&token[subs[3].rm_so], "be"))
                    ia64_be = 1;
379
            } else if (STRPREFIX(&token[subs[2].rm_so], "powerpc64")) {
380
                arch = VIR_ARCH_PPC64;
381 382 383 384
            } else if (STRPREFIX(&token[subs[2].rm_so], "armv7l")) {
                arch = VIR_ARCH_ARMV7L;
            } else if (STRPREFIX(&token[subs[2].rm_so], "aarch64")) {
                arch = VIR_ARCH_AARCH64;
J
Jim Fehlig 已提交
385 386 387 388 389
            } else {
                continue;
            }

            /* Search for existing matching (model,hvm) tuple */
390
            for (i = 0; i < nr_guest_archs; i++) {
391
                if ((guest_archs[i].arch == arch) &&
392
                    guest_archs[i].hvm == hvm)
J
Jim Fehlig 已提交
393 394 395 396 397 398 399 400 401 402
                    break;
            }

            /* Too many arch flavours - highly unlikely ! */
            if (i >= ARRAY_CARDINALITY(guest_archs))
                continue;
            /* Didn't find a match, so create a new one */
            if (i == nr_guest_archs)
                nr_guest_archs++;

403
            guest_archs[i].arch = arch;
J
Jim Fehlig 已提交
404 405 406 407 408 409 410 411 412 413 414 415 416 417
            guest_archs[i].hvm = hvm;

            /* Careful not to overwrite a previous positive
               setting with a negative one here - some archs
               can do both pae & non-pae, but Xen reports
               separately capabilities so we're merging archs */
            if (pae)
                guest_archs[i].pae = pae;
            if (nonpae)
                guest_archs[i].nonpae = nonpae;
            if (ia64_be)
                guest_archs[i].ia64_be = ia64_be;
        }
    }
418
    regfree(&regex);
J
Jim Fehlig 已提交
419

J
Jim Fehlig 已提交
420 421 422 423
    for (i = 0; i < nr_guest_archs; ++i) {
        virCapsGuestPtr guest;
        char const *const xen_machines[] = {guest_archs[i].hvm ? "xenfv" : "xenpv"};
        virCapsGuestMachinePtr *machines;
J
Jim Fehlig 已提交
424

J
Jim Fehlig 已提交
425 426
        if ((machines = virCapabilitiesAllocMachines(xen_machines, 1)) == NULL)
            return -1;
J
Jim Fehlig 已提交
427

J
Jim Fehlig 已提交
428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493
        if ((guest = virCapabilitiesAddGuest(caps,
                                             guest_archs[i].hvm ? "hvm" : "xen",
                                             guest_archs[i].arch,
                                             ((hostarch == VIR_ARCH_X86_64) ?
                                              "/usr/lib64/xen/bin/qemu-dm" :
                                              "/usr/lib/xen/bin/qemu-dm"),
                                             (guest_archs[i].hvm ?
                                              "/usr/lib/xen/boot/hvmloader" :
                                              NULL),
                                             1,
                                             machines)) == NULL) {
            virCapabilitiesFreeMachines(machines, 1);
            return -1;
        }
        machines = NULL;

        if (virCapabilitiesAddGuestDomain(guest,
                                          "xen",
                                          NULL,
                                          NULL,
                                          0,
                                          NULL) == NULL)
            return -1;

        if (guest_archs[i].pae &&
            virCapabilitiesAddGuestFeature(guest,
                                           "pae",
                                           1,
                                           0) == NULL)
            return -1;

        if (guest_archs[i].nonpae &&
            virCapabilitiesAddGuestFeature(guest,
                                           "nonpae",
                                           1,
                                           0) == NULL)
            return -1;

        if (guest_archs[i].ia64_be &&
            virCapabilitiesAddGuestFeature(guest,
                                           "ia64_be",
                                           1,
                                           0) == NULL)
            return -1;

        if (guest_archs[i].hvm) {
            if (virCapabilitiesAddGuestFeature(guest,
                                               "acpi",
                                               1,
                                               1) == NULL)
                return -1;

            if (virCapabilitiesAddGuestFeature(guest, "apic",
                                               1,
                                               0) == NULL)
                return -1;

            if (virCapabilitiesAddGuestFeature(guest,
                                               "hap",
                                               0,
                                               1) == NULL)
                return -1;
        }
    }

    return 0;
J
Jim Fehlig 已提交
494 495 496
}

static int
497
libxlMakeDomCreateInfo(libxl_ctx *ctx,
J
Jim Fehlig 已提交
498 499
                       virDomainDefPtr def,
                       libxl_domain_create_info *c_info)
J
Jim Fehlig 已提交
500 501 502
{
    char uuidstr[VIR_UUID_STRING_BUFLEN];

J
Jim Fehlig 已提交
503 504 505 506 507 508
    libxl_domain_create_info_init(c_info);

    if (STREQ(def->os.type, "hvm"))
        c_info->type = LIBXL_DOMAIN_TYPE_HVM;
    else
        c_info->type = LIBXL_DOMAIN_TYPE_PV;
J
Jim Fehlig 已提交
509

510
    if (VIR_STRDUP(c_info->name, def->name) < 0)
J
Jim Fehlig 已提交
511 512
        goto error;

J
Jim Fehlig 已提交
513 514
    if (def->nseclabels &&
        def->seclabels[0]->type == VIR_DOMAIN_SECLABEL_STATIC) {
515
        if (libxl_flask_context_to_sid(ctx,
J
Jim Fehlig 已提交
516 517 518 519 520 521 522 523 524
                                       def->seclabels[0]->label,
                                       strlen(def->seclabels[0]->label),
                                       &c_info->ssidref)) {
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           _("libxenlight failed to resolve security label '%s'"),
                           def->seclabels[0]->label);
        }
    }

J
Jim Fehlig 已提交
525
    virUUIDFormat(def->uuid, uuidstr);
526
    if (libxl_uuid_from_string(&c_info->uuid, uuidstr)) {
527 528
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("libxenlight failed to parse UUID '%s'"), uuidstr);
J
Jim Fehlig 已提交
529 530 531 532 533
        goto error;
    }

    return 0;

534
 error:
J
Jim Fehlig 已提交
535
    libxl_domain_create_info_dispose(c_info);
J
Jim Fehlig 已提交
536 537 538
    return -1;
}

B
Bamvor Jian Zhang 已提交
539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624
static int
libxlMakeChrdevStr(virDomainChrDefPtr def, char **buf)
{
    virDomainChrSourceDef srcdef = def->source;
    const char *type = virDomainChrTypeToString(srcdef.type);

    if (!type) {
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                       "%s", _("unknown chrdev type"));
        return -1;
    }

    switch (srcdef.type) {
    case VIR_DOMAIN_CHR_TYPE_NULL:
    case VIR_DOMAIN_CHR_TYPE_STDIO:
    case VIR_DOMAIN_CHR_TYPE_VC:
    case VIR_DOMAIN_CHR_TYPE_PTY:
        if (VIR_STRDUP(*buf, type) < 0)
            return -1;
        break;

    case VIR_DOMAIN_CHR_TYPE_FILE:
    case VIR_DOMAIN_CHR_TYPE_PIPE:
        if (virAsprintf(buf, "%s:%s", type, srcdef.data.file.path) < 0)
            return -1;
        break;

    case VIR_DOMAIN_CHR_TYPE_DEV:
        if (VIR_STRDUP(*buf, srcdef.data.file.path) < 0)
            return -1;
        break;

    case VIR_DOMAIN_CHR_TYPE_UDP: {
        const char *connectHost = srcdef.data.udp.connectHost;
        const char *bindHost = srcdef.data.udp.bindHost;
        const char *bindService  = srcdef.data.udp.bindService;

        if (connectHost == NULL)
            connectHost = "";
        if (bindHost == NULL)
            bindHost = "";
        if (bindService == NULL)
            bindService = "0";

        if (virAsprintf(buf, "udp:%s:%s@%s:%s",
                        connectHost,
                        srcdef.data.udp.connectService,
                        bindHost,
                        bindService) < 0)
            return -1;
        break;
    }

    case VIR_DOMAIN_CHR_TYPE_TCP: {
        const char *prefix;

        if (srcdef.data.tcp.protocol == VIR_DOMAIN_CHR_TCP_PROTOCOL_TELNET)
            prefix = "telnet";
        else
            prefix = "tcp";

        if (virAsprintf(buf, "%s:%s:%s%s",
                        prefix,
                        srcdef.data.tcp.host,
                        srcdef.data.tcp.service,
                        srcdef.data.tcp.listen ? ",server,nowait" : "") < 0)
            return -1;
        break;
    }

    case VIR_DOMAIN_CHR_TYPE_UNIX:
        if (virAsprintf(buf, "unix:%s%s",
                        srcdef.data.nix.path,
                        srcdef.data.nix.listen ? ",server,nowait" : "") < 0)
            return -1;
        break;

    default:
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                       _("unsupported chardev '%s'"), type);
        return -1;
    }

    return 0;
}

J
Jim Fehlig 已提交
625
static int
626 627 628
libxlMakeDomBuildInfo(virDomainDefPtr def,
                      libxl_ctx *ctx,
                      libxl_domain_config *d_config)
J
Jim Fehlig 已提交
629 630 631
{
    libxl_domain_build_info *b_info = &d_config->b_info;
    int hvm = STREQ(def->os.type, "hvm");
632
    size_t i;
J
Jim Fehlig 已提交
633

J
Jim Fehlig 已提交
634
    libxl_domain_build_info_init(b_info);
J
Jim Fehlig 已提交
635

J
Jim Fehlig 已提交
636 637
    if (hvm)
        libxl_domain_build_info_init_type(b_info, LIBXL_DOMAIN_TYPE_HVM);
638
    else
J
Jim Fehlig 已提交
639
        libxl_domain_build_info_init_type(b_info, LIBXL_DOMAIN_TYPE_PV);
640

J
Jim Fehlig 已提交
641
    b_info->max_vcpus = def->maxvcpus;
642
    if (libxl_cpu_bitmap_alloc(ctx, &b_info->avail_vcpus, def->maxvcpus))
643
        return -1;
644 645 646 647
    libxl_bitmap_set_none(&b_info->avail_vcpus);
    for (i = 0; i < def->vcpus; i++)
        libxl_bitmap_set((&b_info->avail_vcpus), i);

J
Jim Fehlig 已提交
648 649 650 651 652 653 654 655 656 657 658 659 660
    if (def->clock.ntimers > 0 &&
        def->clock.timers[0]->name == VIR_DOMAIN_TIMER_NAME_TSC) {
        switch (def->clock.timers[0]->mode) {
            case VIR_DOMAIN_TIMER_MODE_NATIVE:
                b_info->tsc_mode = 2;
                break;
            case VIR_DOMAIN_TIMER_MODE_PARAVIRT:
                b_info->tsc_mode = 3;
                break;
            default:
                b_info->tsc_mode = 1;
        }
    }
J
Jim Fehlig 已提交
661
    b_info->sched_params.weight = 1000;
J
Jim Fehlig 已提交
662 663 664
    b_info->max_memkb = def->mem.max_balloon;
    b_info->target_memkb = def->mem.cur_balloon;
    if (hvm) {
665 666
        char bootorder[VIR_DOMAIN_BOOT_LAST + 1];

J
Jim Fehlig 已提交
667
        libxl_defbool_set(&b_info->u.hvm.pae,
668
                          def->features[VIR_DOMAIN_FEATURE_PAE] ==
J
Ján Tomko 已提交
669
                          VIR_TRISTATE_SWITCH_ON);
J
Jim Fehlig 已提交
670
        libxl_defbool_set(&b_info->u.hvm.apic,
671
                          def->features[VIR_DOMAIN_FEATURE_APIC] ==
J
Ján Tomko 已提交
672
                          VIR_TRISTATE_SWITCH_ON);
J
Jim Fehlig 已提交
673
        libxl_defbool_set(&b_info->u.hvm.acpi,
674
                          def->features[VIR_DOMAIN_FEATURE_ACPI] ==
J
Ján Tomko 已提交
675
                          VIR_TRISTATE_SWITCH_ON);
P
Paolo Bonzini 已提交
676 677 678
        for (i = 0; i < def->clock.ntimers; i++) {
            if (def->clock.timers[i]->name == VIR_DOMAIN_TIMER_NAME_HPET &&
                def->clock.timers[i]->present == 1) {
J
Jim Fehlig 已提交
679
                libxl_defbool_set(&b_info->u.hvm.hpet, 1);
P
Paolo Bonzini 已提交
680 681
            }
        }
682
        for (i = 0; i < def->os.nBootDevs; i++) {
683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701
            switch (def->os.bootDevs[i]) {
                case VIR_DOMAIN_BOOT_FLOPPY:
                    bootorder[i] = 'a';
                    break;
                default:
                case VIR_DOMAIN_BOOT_DISK:
                    bootorder[i] = 'c';
                    break;
                case VIR_DOMAIN_BOOT_CDROM:
                    bootorder[i] = 'd';
                    break;
                case VIR_DOMAIN_BOOT_NET:
                    bootorder[i] = 'n';
                    break;
            }
        }
        if (def->os.nBootDevs == 0) {
            bootorder[0] = 'c';
            bootorder[1] = '\0';
702
        } else {
703 704
            bootorder[def->os.nBootDevs] = '\0';
        }
705
        if (VIR_STRDUP(b_info->u.hvm.boot, bootorder) < 0)
706
            return -1;
P
Paolo Bonzini 已提交
707

708 709 710 711 712
        if (def->emulator) {
            if (!virFileExists(def->emulator)) {
                virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                               _("emulator '%s' not found"),
                               def->emulator);
713
                return -1;
714 715 716 717 718 719
            }

            if (!virFileIsExecutable(def->emulator)) {
                virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                               _("emulator '%s' is not executable"),
                               def->emulator);
720
                return -1;
721 722 723 724
            }

            VIR_FREE(b_info->device_model);
            if (VIR_STRDUP(b_info->device_model, def->emulator) < 0)
725
                return -1;
726 727 728 729

            b_info->device_model_version = libxlDomainGetEmulatorType(def);
        }

B
Bamvor Jian Zhang 已提交
730 731 732 733 734
        if (def->nserials) {
            if (def->nserials > 1) {
                virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                               "%s",
                               _("Only one serial device is supported by libxl"));
735
                return -1;
B
Bamvor Jian Zhang 已提交
736 737
            }
            if (libxlMakeChrdevStr(def->serials[0], &b_info->u.hvm.serial) < 0)
738
                return -1;
B
Bamvor Jian Zhang 已提交
739 740 741 742 743 744
        }

        if (def->nparallels) {
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                           "%s",
                           _("Parallel devices are not supported by libxl"));
745
            return -1;
B
Bamvor Jian Zhang 已提交
746 747
        }

748 749 750 751
        /* Disable VNC and SDL until explicitly enabled */
        libxl_defbool_set(&b_info->u.hvm.vnc.enable, 0);
        libxl_defbool_set(&b_info->u.hvm.sdl.enable, 0);

J
Jim Fehlig 已提交
752 753 754 755 756 757 758
        /*
         * The following comment and calculation were taken directly from
         * libxenlight's internal function libxl_get_required_shadow_memory():
         *
         * 256 pages (1MB) per vcpu, plus 1 page per MiB of RAM for the P2M map,
         * plus 1 page per MiB of RAM to shadow the resident processes.
         */
J
Jim Fehlig 已提交
759
        b_info->shadow_memkb = 4 * (256 * libxl_bitmap_count_set(&b_info->avail_vcpus) +
J
Jim Fehlig 已提交
760 761
                                    2 * (b_info->max_memkb / 1024));
    } else {
762 763 764 765 766 767
        /*
         * For compatibility with the legacy xen toolstack, default to pygrub
         * if bootloader is not specified AND direct kernel boot is not specified.
         */
        if (def->os.bootloader) {
            if (VIR_STRDUP(b_info->u.pv.bootloader, def->os.bootloader) < 0)
768
                return -1;
769 770
        } else if (def->os.kernel == NULL) {
            if (VIR_STRDUP(b_info->u.pv.bootloader, LIBXL_BOOTLOADER_PATH) < 0)
771
                return -1;
772
        }
J
Jim Fehlig 已提交
773
        if (def->os.bootloaderArgs) {
J
Jim Fehlig 已提交
774 775
            if (!(b_info->u.pv.bootloader_args =
                  virStringSplit(def->os.bootloaderArgs, " \t\n", 0)))
776
                return -1;
J
Jim Fehlig 已提交
777
        }
778
        if (VIR_STRDUP(b_info->u.pv.cmdline, def->os.cmdline) < 0)
779
            return -1;
J
Jim Fehlig 已提交
780
        if (def->os.kernel) {
781
            /* libxl_init_build_info() sets VIR_STRDUP(kernel.path, "hvmloader") */
J
Jim Fehlig 已提交
782
            VIR_FREE(b_info->u.pv.kernel);
783
            if (VIR_STRDUP(b_info->u.pv.kernel, def->os.kernel) < 0)
784
                return -1;
J
Jim Fehlig 已提交
785
        }
786
        if (VIR_STRDUP(b_info->u.pv.ramdisk, def->os.initrd) < 0)
787
            return -1;
J
Jim Fehlig 已提交
788 789 790 791 792
    }

    return 0;
}

793 794 795 796 797 798
static int
libxlDiskSetDiscard(libxl_device_disk *x_disk, int discard)
{
    if (!x_disk->readwrite)
        return 0;
#if defined(LIBXL_HAVE_LIBXL_DEVICE_DISK_DISCARD_ENABLE)
799
    switch ((virDomainDiskDiscard)discard) {
800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821
    case VIR_DOMAIN_DISK_DISCARD_DEFAULT:
    case VIR_DOMAIN_DISK_DISCARD_LAST:
        break;
    case VIR_DOMAIN_DISK_DISCARD_UNMAP:
        libxl_defbool_set(&x_disk->discard_enable, true);
        break;
    case VIR_DOMAIN_DISK_DISCARD_IGNORE:
        libxl_defbool_set(&x_disk->discard_enable, false);
        break;
    }
    return 0;
#else
    if (discard == VIR_DOMAIN_DISK_DISCARD_DEFAULT)
        return 0;
    virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                   _("This version of libxenlight does not support "
                     "disk 'discard' option passing"));
    return -1;
#endif
}


822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852
#define LIBXL_QEMU_DM_STR  "Options specific to the Xen version:"

int
libxlDomainGetEmulatorType(const virDomainDef *def)
{
    int ret = LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN;
    virCommandPtr cmd = NULL;
    char *output = NULL;

    if (STREQ(def->os.type, "hvm")) {
        if (def->emulator) {
            cmd = virCommandNew(def->emulator);

            virCommandAddArgList(cmd, "-help", NULL);
            virCommandSetOutputBuffer(cmd, &output);

            if (virCommandRun(cmd, NULL) < 0)
                goto cleanup;

            if (strstr(output, LIBXL_QEMU_DM_STR))
                ret = LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL;
        }
    }

 cleanup:
    VIR_FREE(output);
    virCommandFree(cmd);
    return ret;
}


853
int
J
Jim Fehlig 已提交
854
libxlMakeDisk(virDomainDiskDefPtr l_disk, libxl_device_disk *x_disk)
855
{
856 857 858
    const char *driver;
    int format;

859 860
    libxl_device_disk_init(x_disk);

861
    if (VIR_STRDUP(x_disk->pdev_path, virDomainDiskGetSource(l_disk)) < 0)
862 863
        return -1;

864
    if (VIR_STRDUP(x_disk->vdev, l_disk->dst) < 0)
865 866
        return -1;

867 868 869 870 871
    driver = virDomainDiskGetDriver(l_disk);
    format = virDomainDiskGetFormat(l_disk);
    if (driver) {
        if (STREQ(driver, "tap") || STREQ(driver, "tap2")) {
            switch (format) {
872
            case VIR_STORAGE_FILE_QCOW:
J
Jim Fehlig 已提交
873 874
                x_disk->format = LIBXL_DISK_FORMAT_QCOW;
                x_disk->backend = LIBXL_DISK_BACKEND_QDISK;
875 876
                break;
            case VIR_STORAGE_FILE_QCOW2:
J
Jim Fehlig 已提交
877 878
                x_disk->format = LIBXL_DISK_FORMAT_QCOW2;
                x_disk->backend = LIBXL_DISK_BACKEND_QDISK;
879 880
                break;
            case VIR_STORAGE_FILE_VHD:
J
Jim Fehlig 已提交
881 882
                x_disk->format = LIBXL_DISK_FORMAT_VHD;
                x_disk->backend = LIBXL_DISK_BACKEND_TAP;
883 884
                break;
            case VIR_STORAGE_FILE_NONE:
885
                /* No subtype specified, default to raw/tap */
886
            case VIR_STORAGE_FILE_RAW:
J
Jim Fehlig 已提交
887 888
                x_disk->format = LIBXL_DISK_FORMAT_RAW;
                x_disk->backend = LIBXL_DISK_BACKEND_TAP;
889 890 891
                break;
            default:
                virReportError(VIR_ERR_INTERNAL_ERROR,
892 893
                               _("libxenlight does not support disk format %s "
                                 "with disk driver %s"),
894 895
                               virStorageFileFormatTypeToString(format),
                               driver);
896
                return -1;
897
            }
898
        } else if (STREQ(driver, "qemu")) {
J
Jim Fehlig 已提交
899
            x_disk->backend = LIBXL_DISK_BACKEND_QDISK;
900
            switch (format) {
J
Jim Fehlig 已提交
901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918
            case VIR_STORAGE_FILE_QCOW:
                x_disk->format = LIBXL_DISK_FORMAT_QCOW;
                break;
            case VIR_STORAGE_FILE_QCOW2:
                x_disk->format = LIBXL_DISK_FORMAT_QCOW2;
                break;
            case VIR_STORAGE_FILE_VHD:
                x_disk->format = LIBXL_DISK_FORMAT_VHD;
                break;
            case VIR_STORAGE_FILE_NONE:
                /* No subtype specified, default to raw */
            case VIR_STORAGE_FILE_RAW:
                x_disk->format = LIBXL_DISK_FORMAT_RAW;
                break;
            default:
                virReportError(VIR_ERR_INTERNAL_ERROR,
                               _("libxenlight does not support disk format %s "
                                 "with disk driver %s"),
919 920
                               virStorageFileFormatTypeToString(format),
                               driver);
J
Jim Fehlig 已提交
921 922
                return -1;
            }
923 924 925
        } else if (STREQ(driver, "file")) {
            if (format != VIR_STORAGE_FILE_NONE &&
                format != VIR_STORAGE_FILE_RAW) {
926 927 928
                virReportError(VIR_ERR_INTERNAL_ERROR,
                               _("libxenlight does not support disk format %s "
                                 "with disk driver %s"),
929 930
                               virStorageFileFormatTypeToString(format),
                               driver);
931 932
                return -1;
            }
J
Jim Fehlig 已提交
933
            x_disk->format = LIBXL_DISK_FORMAT_RAW;
934
            x_disk->backend = LIBXL_DISK_BACKEND_QDISK;
935 936 937
        } else if (STREQ(driver, "phy")) {
            if (format != VIR_STORAGE_FILE_NONE &&
                format != VIR_STORAGE_FILE_RAW) {
938 939 940
                virReportError(VIR_ERR_INTERNAL_ERROR,
                               _("libxenlight does not support disk format %s "
                                 "with disk driver %s"),
941 942
                               virStorageFileFormatTypeToString(format),
                               driver);
943 944
                return -1;
            }
J
Jim Fehlig 已提交
945 946
            x_disk->format = LIBXL_DISK_FORMAT_RAW;
            x_disk->backend = LIBXL_DISK_BACKEND_PHY;
947
        } else {
948 949
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           _("libxenlight does not support disk driver %s"),
950
                           driver);
951 952 953
            return -1;
        }
    } else {
J
Jim Fehlig 已提交
954 955 956 957 958
        /*
         * If driverName is not specified, default to raw as per
         * xl-disk-configuration.txt in the xen documentation and let
         * libxl pick a suitable backend.
         */
J
Jim Fehlig 已提交
959
        x_disk->format = LIBXL_DISK_FORMAT_RAW;
J
Jim Fehlig 已提交
960
        x_disk->backend = LIBXL_DISK_BACKEND_UNKNOWN;
961 962
    }

J
Jim Fehlig 已提交
963 964
    /* XXX is this right? */
    x_disk->removable = 1;
965
    x_disk->readwrite = !l_disk->src->readonly;
966
    x_disk->is_cdrom = l_disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM ? 1 : 0;
967 968
    if (libxlDiskSetDiscard(x_disk, l_disk->discard) < 0)
        return -1;
969 970 971
    /* An empty CDROM must have the empty format, otherwise libxl fails. */
    if (x_disk->is_cdrom && !x_disk->pdev_path)
        x_disk->format = LIBXL_DISK_FORMAT_EMPTY;
972
    if (l_disk->transient) {
973 974
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("libxenlight does not support transient disks"));
975 976
        return -1;
    }
977

978 979 980 981 982 983 984 985 986 987 988 989
    if (l_disk->domain_name) {
#ifdef LIBXL_HAVE_DEVICE_BACKEND_DOMNAME
        if (VIR_STRDUP(x_disk->backend_domname, l_disk->domain_name) < 0)
            return -1;
#else
        virReportError(VIR_ERR_XML_DETAIL, "%s",
                _("this version of libxenlight does not "
                  "support backend domain name"));
        return -1;
#endif
    }

990 991 992
    return 0;
}

J
Jim Fehlig 已提交
993 994 995 996 997 998
static int
libxlMakeDiskList(virDomainDefPtr def, libxl_domain_config *d_config)
{
    virDomainDiskDefPtr *l_disks = def->disks;
    int ndisks = def->ndisks;
    libxl_device_disk *x_disks;
999
    size_t i;
J
Jim Fehlig 已提交
1000

1001
    if (VIR_ALLOC_N(x_disks, ndisks) < 0)
J
Jim Fehlig 已提交
1002 1003 1004
        return -1;

    for (i = 0; i < ndisks; i++) {
J
Jim Fehlig 已提交
1005
        if (libxlMakeDisk(l_disks[i], &x_disks[i]) < 0)
J
Jim Fehlig 已提交
1006 1007 1008 1009 1010 1011 1012 1013
            goto error;
    }

    d_config->disks = x_disks;
    d_config->num_disks = ndisks;

    return 0;

1014
 error:
J
Jim Fehlig 已提交
1015
    for (i = 0; i < ndisks; i++)
J
Jim Fehlig 已提交
1016
        libxl_device_disk_dispose(&x_disks[i]);
J
Jim Fehlig 已提交
1017 1018 1019 1020
    VIR_FREE(x_disks);
    return -1;
}

1021
int
1022 1023 1024
libxlMakeNic(virDomainDefPtr def,
             virDomainNetDefPtr l_nic,
             libxl_device_nic *x_nic)
1025
{
1026
    bool ioemu_nic = STREQ(def->os.type, "hvm");
1027
    virDomainNetType actual_type = virDomainNetGetActualType(l_nic);
1028

J
Jim Fehlig 已提交
1029 1030 1031 1032
    /* TODO: Where is mtu stored?
     *
     * x_nics[i].mtu = 1492;
     */
1033

1034 1035 1036 1037 1038 1039 1040 1041
    if (l_nic->script && !(actual_type == VIR_DOMAIN_NET_TYPE_BRIDGE ||
                           actual_type == VIR_DOMAIN_NET_TYPE_ETHERNET)) {
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("specifying a script is only supported with "
                         "interface types bridge and ethernet"));
        return -1;
    }

1042 1043
    libxl_device_nic_init(x_nic);

1044
    virMacAddrGetRaw(&l_nic->mac, x_nic->mac);
1045

1046
    if (ioemu_nic)
J
Jim Fehlig 已提交
1047
        x_nic->nictype = LIBXL_NIC_TYPE_VIF_IOEMU;
1048
    else
J
Jim Fehlig 已提交
1049
        x_nic->nictype = LIBXL_NIC_TYPE_VIF;
1050 1051 1052 1053 1054 1055

    if (l_nic->model) {
        if (VIR_STRDUP(x_nic->model, l_nic->model) < 0)
            return -1;
        if (STREQ(l_nic->model, "netfront"))
            x_nic->nictype = LIBXL_NIC_TYPE_VIF;
1056 1057
    }

1058
    if (VIR_STRDUP(x_nic->ifname, l_nic->ifname) < 0)
1059 1060
        return -1;

1061
    switch (actual_type) {
1062
        case VIR_DOMAIN_NET_TYPE_BRIDGE:
1063 1064
            if (VIR_STRDUP(x_nic->bridge,
                           virDomainNetGetActualBridgeName(l_nic)) < 0)
1065 1066 1067 1068 1069
                return -1;
            /* fallthrough */
        case VIR_DOMAIN_NET_TYPE_ETHERNET:
            if (VIR_STRDUP(x_nic->script, l_nic->script) < 0)
                return -1;
1070 1071 1072 1073 1074
            if (l_nic->nips > 0) {
                x_nic->ip = virSocketAddrFormat(&l_nic->ips[0]->address);
                if (!x_nic->ip)
                    return -1;
            }
1075
            break;
1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091
        case VIR_DOMAIN_NET_TYPE_NETWORK:
        {
            bool fail = false;
            char *brname = NULL;
            virNetworkPtr network;
            virConnectPtr conn;

            if (!(conn = virConnectOpen("xen:///system")))
                return -1;

            if (!(network =
                  virNetworkLookupByName(conn, l_nic->data.network.name))) {
                virObjectUnref(conn);
                return -1;
            }

1092 1093 1094 1095 1096 1097
            if (l_nic->nips > 0) {
                x_nic->ip = virSocketAddrFormat(&l_nic->ips[0]->address);
                if (!x_nic->ip)
                    return -1;
            }

1098 1099 1100 1101 1102 1103 1104 1105 1106
            if ((brname = virNetworkGetBridgeName(network))) {
                if (VIR_STRDUP(x_nic->bridge, brname) < 0)
                    fail = true;
            } else {
                fail = true;
            }

            VIR_FREE(brname);

1107
            virObjectUnref(network);
1108 1109 1110 1111 1112
            virObjectUnref(conn);
            if (fail)
                return -1;
            break;
        }
M
Michele Paolino 已提交
1113
        case VIR_DOMAIN_NET_TYPE_VHOSTUSER:
1114 1115 1116 1117 1118 1119 1120 1121
        case VIR_DOMAIN_NET_TYPE_USER:
        case VIR_DOMAIN_NET_TYPE_SERVER:
        case VIR_DOMAIN_NET_TYPE_CLIENT:
        case VIR_DOMAIN_NET_TYPE_MCAST:
        case VIR_DOMAIN_NET_TYPE_INTERNAL:
        case VIR_DOMAIN_NET_TYPE_DIRECT:
        case VIR_DOMAIN_NET_TYPE_HOSTDEV:
        case VIR_DOMAIN_NET_TYPE_LAST:
1122 1123
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                    _("unsupported interface type %s"),
1124
                    virDomainNetTypeToString(l_nic->type));
1125
            return -1;
1126 1127
    }

1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139
    if (l_nic->domain_name) {
#ifdef LIBXL_HAVE_DEVICE_BACKEND_DOMNAME
        if (VIR_STRDUP(x_nic->backend_domname, l_nic->domain_name) < 0)
            return -1;
#else
        virReportError(VIR_ERR_XML_DETAIL, "%s",
                _("this version of libxenlight does not "
                  "support backend domain name"));
        return -1;
#endif
    }

1140 1141 1142
    return 0;
}

J
Jim Fehlig 已提交
1143 1144 1145 1146
static int
libxlMakeNicList(virDomainDefPtr def,  libxl_domain_config *d_config)
{
    virDomainNetDefPtr *l_nics = def->nets;
1147
    size_t nnics = def->nnets;
J
Jim Fehlig 已提交
1148
    libxl_device_nic *x_nics;
1149
    size_t i, nvnics = 0;
J
Jim Fehlig 已提交
1150

1151
    if (VIR_ALLOC_N(x_nics, nnics) < 0)
J
Jim Fehlig 已提交
1152 1153 1154
        return -1;

    for (i = 0; i < nnics; i++) {
1155 1156 1157 1158
        if (l_nics[i]->type == VIR_DOMAIN_NET_TYPE_HOSTDEV)
            continue;

        if (libxlMakeNic(def, l_nics[i], &x_nics[nvnics]))
J
Jim Fehlig 已提交
1159
            goto error;
1160 1161 1162 1163 1164
        /*
         * The devid (at least right now) will not get initialized by
         * libxl in the setup case but is required for starting the
         * device-model.
         */
1165 1166 1167 1168
        if (x_nics[nvnics].devid < 0)
            x_nics[nvnics].devid = nvnics;

        nvnics++;
J
Jim Fehlig 已提交
1169 1170
    }

1171
    VIR_SHRINK_N(x_nics, nnics, nnics - nvnics);
J
Jim Fehlig 已提交
1172 1173
    d_config->nics = x_nics;
    d_config->num_nics = nnics;
J
Jim Fehlig 已提交
1174 1175 1176

    return 0;

1177
 error:
J
Jim Fehlig 已提交
1178
    for (i = 0; i < nnics; i++)
J
Jim Fehlig 已提交
1179
        libxl_device_nic_dispose(&x_nics[i]);
J
Jim Fehlig 已提交
1180 1181 1182 1183
    VIR_FREE(x_nics);
    return -1;
}

1184
int
1185
libxlMakeVfb(virPortAllocatorPtr graphicsports,
J
Jim Fehlig 已提交
1186 1187
             virDomainGraphicsDefPtr l_vfb,
             libxl_device_vfb *x_vfb)
1188
{
1189
    unsigned short port;
1190
    const char *listenAddr;
1191

1192 1193
    libxl_device_vfb_init(x_vfb);

1194 1195
    switch (l_vfb->type) {
        case VIR_DOMAIN_GRAPHICS_TYPE_SDL:
J
Jim Fehlig 已提交
1196
            libxl_defbool_set(&x_vfb->sdl.enable, 1);
1197
            if (VIR_STRDUP(x_vfb->sdl.display, l_vfb->data.sdl.display) < 0)
1198
                return -1;
1199
            if (VIR_STRDUP(x_vfb->sdl.xauthority, l_vfb->data.sdl.xauth) < 0)
1200 1201 1202
                return -1;
            break;
        case  VIR_DOMAIN_GRAPHICS_TYPE_VNC:
J
Jim Fehlig 已提交
1203
            libxl_defbool_set(&x_vfb->vnc.enable, 1);
1204
            /* driver handles selection of free port */
J
Jim Fehlig 已提交
1205
            libxl_defbool_set(&x_vfb->vnc.findunused, 0);
1206
            if (l_vfb->data.vnc.autoport) {
1207

1208
                if (virPortAllocatorAcquire(graphicsports, &port) < 0)
1209
                    return -1;
1210 1211
                l_vfb->data.vnc.port = port;
            }
J
Jim Fehlig 已提交
1212
            x_vfb->vnc.display = l_vfb->data.vnc.port - LIBXL_VNC_PORT_MIN;
1213

1214 1215
            listenAddr = virDomainGraphicsListenGetAddress(l_vfb, 0);
            if (listenAddr) {
1216
                /* libxl_device_vfb_init() does VIR_STRDUP("127.0.0.1") */
J
Jim Fehlig 已提交
1217
                VIR_FREE(x_vfb->vnc.listen);
1218
                if (VIR_STRDUP(x_vfb->vnc.listen, listenAddr) < 0)
1219 1220
                    return -1;
            }
1221
            if (VIR_STRDUP(x_vfb->keymap, l_vfb->data.vnc.keymap) < 0)
1222 1223 1224
                return -1;
            break;
    }
J
Jim Fehlig 已提交
1225

1226 1227 1228
    return 0;
}

J
Jim Fehlig 已提交
1229
static int
1230
libxlMakeVfbList(virPortAllocatorPtr graphicsports,
J
Jim Fehlig 已提交
1231 1232
                 virDomainDefPtr def,
                 libxl_domain_config *d_config)
J
Jim Fehlig 已提交
1233 1234 1235 1236 1237
{
    virDomainGraphicsDefPtr *l_vfbs = def->graphics;
    int nvfbs = def->ngraphics;
    libxl_device_vfb *x_vfbs;
    libxl_device_vkb *x_vkbs;
1238
    size_t i;
J
Jim Fehlig 已提交
1239 1240 1241 1242

    if (nvfbs == 0)
        return 0;

1243
    if (VIR_ALLOC_N(x_vfbs, nvfbs) < 0)
J
Jim Fehlig 已提交
1244 1245 1246 1247 1248 1249 1250
        return -1;
    if (VIR_ALLOC_N(x_vkbs, nvfbs) < 0) {
        VIR_FREE(x_vfbs);
        return -1;
    }

    for (i = 0; i < nvfbs; i++) {
J
Jim Fehlig 已提交
1251
        libxl_device_vkb_init(&x_vkbs[i]);
J
Jim Fehlig 已提交
1252

1253
        if (libxlMakeVfb(graphicsports, l_vfbs[i], &x_vfbs[i]) < 0)
1254
            goto error;
J
Jim Fehlig 已提交
1255 1256 1257 1258 1259 1260
    }

    d_config->vfbs = x_vfbs;
    d_config->vkbs = x_vkbs;
    d_config->num_vfbs = d_config->num_vkbs = nvfbs;

1261 1262 1263 1264 1265 1266 1267 1268
    /*
     * VNC or SDL info must also be set in libxl_domain_build_info
     * for HVM domains.  Use the first vfb device.
     */
    if (STREQ(def->os.type, "hvm")) {
        libxl_domain_build_info *b_info = &d_config->b_info;
        libxl_device_vfb vfb = d_config->vfbs[0];

1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286
        if (libxl_defbool_val(vfb.vnc.enable)) {
            libxl_defbool_set(&b_info->u.hvm.vnc.enable, true);
            if (VIR_STRDUP(b_info->u.hvm.vnc.listen, vfb.vnc.listen) < 0)
                goto error;
            if (VIR_STRDUP(b_info->u.hvm.vnc.passwd, vfb.vnc.passwd) < 0)
                goto error;
            b_info->u.hvm.vnc.display = vfb.vnc.display;
            libxl_defbool_set(&b_info->u.hvm.vnc.findunused,
                              libxl_defbool_val(vfb.vnc.findunused));
        } else if (libxl_defbool_val(vfb.sdl.enable)) {
            libxl_defbool_set(&b_info->u.hvm.sdl.enable, true);
            libxl_defbool_set(&b_info->u.hvm.sdl.opengl,
                              libxl_defbool_val(vfb.sdl.opengl));
            if (VIR_STRDUP(b_info->u.hvm.sdl.display, vfb.sdl.display) < 0)
                goto error;
            if (VIR_STRDUP(b_info->u.hvm.sdl.xauthority, vfb.sdl.xauthority) < 0)
                goto error;
        }
1287 1288 1289

        if (VIR_STRDUP(b_info->u.hvm.keymap, vfb.keymap) < 0)
            goto error;
1290 1291
    }

J
Jim Fehlig 已提交
1292 1293
    return 0;

1294
 error:
J
Jim Fehlig 已提交
1295
    for (i = 0; i < nvfbs; i++) {
J
Jim Fehlig 已提交
1296 1297
        libxl_device_vfb_dispose(&x_vfbs[i]);
        libxl_device_vkb_dispose(&x_vkbs[i]);
J
Jim Fehlig 已提交
1298 1299 1300 1301 1302 1303
    }
    VIR_FREE(x_vfbs);
    VIR_FREE(x_vkbs);
    return -1;
}

J
Jim Fehlig 已提交
1304 1305
static int
libxlGetAutoballoonConf(libxlDriverConfigPtr cfg, bool *autoballoon)
1306 1307
{
    regex_t regex;
J
Jim Fehlig 已提交
1308 1309 1310 1311 1312 1313 1314 1315 1316 1317
    int res;

    if ((res = regcomp(&regex,
                      "(^| )dom0_mem=((|min:|max:)[0-9]+[bBkKmMgG]?,?)+($| )",
                       REG_NOSUB | REG_EXTENDED)) != 0) {
        char error[100];
        regerror(res, &regex, error, sizeof(error));
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("Failed to compile regex %s"),
                       error);
1318

J
Jim Fehlig 已提交
1319 1320
        return -1;
    }
1321

J
Jim Fehlig 已提交
1322
    res = regexec(&regex, cfg->verInfo->commandline, 0, NULL, 0);
1323
    regfree(&regex);
J
Jim Fehlig 已提交
1324 1325
    *autoballoon = res == REG_NOMATCH;
    return 0;
1326 1327
}

1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353
libxlDriverConfigPtr
libxlDriverConfigNew(void)
{
    libxlDriverConfigPtr cfg;
    char *log_file = NULL;
    char ebuf[1024];
    unsigned int free_mem;

    if (libxlConfigInitialize() < 0)
        return NULL;

    if (!(cfg = virObjectNew(libxlDriverConfigClass)))
        return NULL;

    if (VIR_STRDUP(cfg->configDir, LIBXL_CONFIG_DIR) < 0)
        goto error;
    if (VIR_STRDUP(cfg->autostartDir, LIBXL_AUTOSTART_DIR) < 0)
        goto error;
    if (VIR_STRDUP(cfg->logDir, LIBXL_LOG_DIR) < 0)
        goto error;
    if (VIR_STRDUP(cfg->stateDir, LIBXL_STATE_DIR) < 0)
        goto error;
    if (VIR_STRDUP(cfg->libDir, LIBXL_LIB_DIR) < 0)
        goto error;
    if (VIR_STRDUP(cfg->saveDir, LIBXL_SAVE_DIR) < 0)
        goto error;
1354 1355
    if (VIR_STRDUP(cfg->autoDumpDir, LIBXL_DUMP_DIR) < 0)
        goto error;
1356 1357 1358 1359

    if (virAsprintf(&log_file, "%s/libxl-driver.log", cfg->logDir) < 0)
        goto error;

1360 1361 1362 1363 1364 1365 1366 1367
    if (virFileMakePath(cfg->logDir) < 0) {
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("failed to create log dir '%s': %s"),
                       cfg->logDir,
                       virStrerror(errno, ebuf, sizeof(ebuf)));
        goto error;
    }

1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404
    if ((cfg->logger_file = fopen(log_file, "a")) == NULL)  {
        VIR_ERROR(_("Failed to create log file '%s': %s"),
                  log_file, virStrerror(errno, ebuf, sizeof(ebuf)));
        goto error;
    }
    VIR_FREE(log_file);

    cfg->logger =
        (xentoollog_logger *)xtl_createlogger_stdiostream(cfg->logger_file,
                                                          XTL_DEBUG, 0);
    if (!cfg->logger) {
        VIR_ERROR(_("cannot create logger for libxenlight, disabling driver"));
        goto error;
    }

    if (libxl_ctx_alloc(&cfg->ctx, LIBXL_VERSION, 0, cfg->logger)) {
        VIR_ERROR(_("cannot initialize libxenlight context, probably not "
                    "running in a Xen Dom0, disabling driver"));
        goto error;
    }

    if ((cfg->verInfo = libxl_get_version_info(cfg->ctx)) == NULL) {
        VIR_ERROR(_("cannot version information from libxenlight, "
                    "disabling driver"));
        goto error;
    }
    cfg->version = (cfg->verInfo->xen_version_major * 1000000) +
        (cfg->verInfo->xen_version_minor * 1000);

    /* This will fill xenstore info about free and dom0 memory if missing,
     * should be called before starting first domain */
    if (libxl_get_free_memory(cfg->ctx, &free_mem)) {
        VIR_ERROR(_("Unable to configure libxl's memory management parameters"));
        goto error;
    }

    /* setup autoballoon */
J
Jim Fehlig 已提交
1405 1406
    if (libxlGetAutoballoonConf(cfg, &cfg->autoballoon) < 0)
        goto error;
1407 1408 1409

    return cfg;

1410
 error:
1411 1412 1413 1414 1415 1416 1417 1418
    VIR_FREE(log_file);
    virObjectUnref(cfg);
    return NULL;
}

libxlDriverConfigPtr
libxlDriverConfigGet(libxlDriverPrivatePtr driver)
{
1419 1420 1421 1422 1423 1424
    libxlDriverConfigPtr cfg;

    libxlDriverLock(driver);
    cfg = virObjectRef(driver->config);
    libxlDriverUnlock(driver);
    return cfg;
1425 1426
}

1427
int
1428
libxlMakePCI(virDomainHostdevDefPtr hostdev, libxl_device_pci *pcidev)
1429
{
1430
    virDomainHostdevSubsysPCIPtr pcisrc = &hostdev->source.subsys.u.pci;
1431 1432 1433 1434 1435
    if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS)
        return -1;
    if (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI)
        return -1;

1436 1437 1438 1439
    pcidev->domain = pcisrc->addr.domain;
    pcidev->bus = pcisrc->addr.bus;
    pcidev->dev = pcisrc->addr.slot;
    pcidev->func = pcisrc->addr.function;
1440 1441 1442 1443 1444

    return 0;
}

static int
1445
libxlMakePCIList(virDomainDefPtr def, libxl_domain_config *d_config)
1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466
{
    virDomainHostdevDefPtr *l_hostdevs = def->hostdevs;
    size_t nhostdevs = def->nhostdevs;
    size_t npcidevs = 0;
    libxl_device_pci *x_pcidevs;
    size_t i, j;

    if (nhostdevs == 0)
        return 0;

    if (VIR_ALLOC_N(x_pcidevs, nhostdevs) < 0)
        return -1;

    for (i = 0, j = 0; i < nhostdevs; i++) {
        if (l_hostdevs[i]->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS)
            continue;
        if (l_hostdevs[i]->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI)
            continue;

        libxl_device_pci_init(&x_pcidevs[j]);

1467
        if (libxlMakePCI(l_hostdevs[i], &x_pcidevs[j]) < 0)
1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479
            goto error;

        npcidevs++;
        j++;
    }

    VIR_SHRINK_N(x_pcidevs, nhostdevs, nhostdevs - npcidevs);
    d_config->pcidevs = x_pcidevs;
    d_config->num_pcidevs = npcidevs;

    return 0;

1480
 error:
1481 1482 1483 1484 1485 1486 1487
    for (i = 0; i < npcidevs; i++)
        libxl_device_pci_dispose(&x_pcidevs[i]);

    VIR_FREE(x_pcidevs);
    return -1;
}

1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553
static int
libxlMakeVideo(virDomainDefPtr def, libxl_domain_config *d_config)

{
    libxl_domain_build_info *b_info = &d_config->b_info;
    int dm_type = libxlDomainGetEmulatorType(def);

    if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_HVM)
        return 0;

    /*
     * Take the first defined video device (graphics card) to display
     * on the first graphics device (display).
     */
    if (def->nvideos) {
        switch (def->videos[0]->type) {
        case VIR_DOMAIN_VIDEO_TYPE_VGA:
        case VIR_DOMAIN_VIDEO_TYPE_XEN:
            b_info->u.hvm.vga.kind = LIBXL_VGA_INTERFACE_TYPE_STD;
            if (dm_type == LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
                if (def->videos[0]->vram < 16 * 1024) {
                    virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                                   _("videoram must be at least 16MB for VGA"));
                    return -1;
                }
            } else {
                if (def->videos[0]->vram < 8 * 1024) {
                    virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                                   _("videoram must be at least 8MB for VGA"));
                    return -1;
                }
            }
            break;

        case VIR_DOMAIN_VIDEO_TYPE_CIRRUS:
            b_info->u.hvm.vga.kind = LIBXL_VGA_INTERFACE_TYPE_CIRRUS;
            if (dm_type == LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
                if (def->videos[0]->vram < 8 * 1024) {
                    virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                                   _("videoram must be at least 8MB for CIRRUS"));
                    return -1;
                }
            } else {
                if (def->videos[0]->vram < 4 * 1024) {
                    virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                                   _("videoram must be at least 4MB for CIRRUS"));
                    return -1;
                }
            }
            break;

        default:
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                           _("video type %s is not supported by libxl"),
                           virDomainVideoTypeToString(def->videos[0]->type));
            return -1;
        }
        /* vram validated for each video type, now set it */
        b_info->video_memkb = def->videos[0]->vram;
    } else {
        libxl_defbool_set(&b_info->u.hvm.nographic, 1);
    }

    return 0;
}

1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584
int
libxlDriverNodeGetInfo(libxlDriverPrivatePtr driver, virNodeInfoPtr info)
{
    libxl_physinfo phy_info;
    virArch hostarch = virArchFromHost();
    libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver);
    int ret = -1;

    if (libxl_get_physinfo(cfg->ctx, &phy_info)) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("libxl_get_physinfo_info failed"));
        goto cleanup;
    }

    if (virStrcpyStatic(info->model, virArchToString(hostarch)) == NULL) {
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("machine type %s too big for destination"),
                       virArchToString(hostarch));
        goto cleanup;
    }

    info->memory = phy_info.total_pages * (cfg->verInfo->pagesize / 1024);
    info->cpus = phy_info.nr_cpus;
    info->nodes = phy_info.nr_nodes;
    info->cores = phy_info.cores_per_socket;
    info->threads = phy_info.threads_per_core;
    info->sockets = 1;
    info->mhz = phy_info.cpu_khz / 1000;

    ret = 0;

1585
 cleanup:
1586 1587 1588 1589
    virObjectUnref(cfg);
    return ret;
}

J
Jim Fehlig 已提交
1590 1591 1592
virCapsPtr
libxlMakeCapabilities(libxl_ctx *ctx)
{
J
Jim Fehlig 已提交
1593
    virCapsPtr caps;
J
Jim Fehlig 已提交
1594

1595
#ifdef LIBXL_HAVE_NO_SUSPEND_RESUME
1596
    if ((caps = virCapabilitiesNew(virArchFromHost(), false, false)) == NULL)
1597
#else
1598
    if ((caps = virCapabilitiesNew(virArchFromHost(), true, true)) == NULL)
1599
#endif
1600
        return NULL;
J
Jim Fehlig 已提交
1601

J
Jim Fehlig 已提交
1602 1603
    if (libxlCapsInitHost(ctx, caps) < 0)
        goto error;
J
Jim Fehlig 已提交
1604

1605 1606 1607
    if (libxlCapsInitNuma(ctx, caps) < 0)
        goto error;

J
Jim Fehlig 已提交
1608 1609 1610 1611
    if (libxlCapsInitGuests(ctx, caps) < 0)
        goto error;

    return caps;
J
Jim Fehlig 已提交
1612

1613
 error:
J
Jim Fehlig 已提交
1614 1615
    virObjectUnref(caps);
    return NULL;
J
Jim Fehlig 已提交
1616 1617 1618
}

int
1619
libxlBuildDomainConfig(virPortAllocatorPtr graphicsports,
1620 1621 1622
                       virDomainDefPtr def,
                       libxl_ctx *ctx,
                       libxl_domain_config *d_config)
J
Jim Fehlig 已提交
1623
{
1624
    libxl_domain_config_init(d_config);
J
Jim Fehlig 已提交
1625

1626
    if (libxlMakeDomCreateInfo(ctx, def, &d_config->c_info) < 0)
J
Jim Fehlig 已提交
1627 1628
        return -1;

1629
    if (libxlMakeDomBuildInfo(def, ctx, d_config) < 0)
1630
        return -1;
J
Jim Fehlig 已提交
1631

1632
    if (libxlMakeDiskList(def, d_config) < 0)
1633
        return -1;
J
Jim Fehlig 已提交
1634

1635
    if (libxlMakeNicList(def, d_config) < 0)
1636
        return -1;
J
Jim Fehlig 已提交
1637

1638
    if (libxlMakeVfbList(graphicsports, def, d_config) < 0)
1639
        return -1;
J
Jim Fehlig 已提交
1640

1641
    if (libxlMakePCIList(def, d_config) < 0)
1642 1643
        return -1;

1644 1645 1646 1647 1648 1649 1650 1651
    /*
     * Now that any potential VFBs are defined, update the build info with
     * the data of the primary display. Some day libxl might implicitely do
     * so but as it does not right now, better be explicit.
     */
    if (libxlMakeVideo(def, d_config) < 0)
        return -1;

1652 1653 1654
    d_config->on_reboot = libxlActionFromVirLifecycle(def->onReboot);
    d_config->on_poweroff = libxlActionFromVirLifecycle(def->onPoweroff);
    d_config->on_crash = libxlActionFromVirLifecycleCrash(def->onCrash);
J
Jim Fehlig 已提交
1655 1656 1657

    return 0;
}
1658 1659 1660 1661 1662 1663 1664 1665

virDomainXMLOptionPtr
libxlCreateXMLConf(void)
{
    return virDomainXMLOptionNew(&libxlDomainDefParserConfig,
                                 &libxlDomainXMLPrivateDataCallbacks,
                                 NULL);
}