virsh-optparse 9.9 KB
Newer Older
1 2 3
#!/bin/sh
# Ensure that virsh option parsing doesn't regress

4
# Copyright (C) 2011-2012, 2014 Red Hat, Inc.
5 6 7 8 9 10 11 12 13 14 15 16

# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 2 of the License, or
# (at your option) any later version.

# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.

# You should have received a copy of the GNU General Public License
17 18
# along with this program.  If not, see
# <http://www.gnu.org/licenses/>.
19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67

: ${srcdir=$(pwd)}
: ${abs_top_srcdir=$(pwd)/..}
: ${abs_top_builddir=$(pwd)/..}

# If $abs_top_builddir/tools is not early in $PATH, put it there,
# so that we can safely invoke "virsh" simply with its name.
case $PATH in
  $abs_top_builddir/tools/src:$abs_top_builddir/tools:*) ;;
  $abs_top_builddir/tools:*) ;;
  *) PATH=$abs_top_builddir/tools:$PATH; export PATH ;;
esac

if test "$VERBOSE" = yes; then
  set -x
  virsh --version
fi

. "$srcdir/test-lib.sh"

cat <<\EOF > exp-out || framework_failure

setvcpus: <domain> trying as domain NAME
setvcpus: count(optdata): 2
setvcpus: domain(optdata): test
setvcpus: found option <domain>: test
EOF

fail=0

test_url=test:///default

for args in \
    'test 2' \
    '--domain test 2' \
    '--domain=test 2' \
    'test --count 2' \
    'test --count=2' \
    '--domain test --count 2' \
    '--domain=test --count 2' \
    '--domain test --count=2' \
    '--domain=test --count=2' \
    '--count 2 --domain test' \
    '--count 2 --domain=test' \
    '--count=2 --domain test' \
    '--count=2 --domain=test' \
    '--count 2 test' \
    '--count=2 test' \
; do
68
  virsh -k0 -d0 -c $test_url setvcpus $args >out 2>>err || fail=1
E
Eric Blake 已提交
69
  LC_ALL=C sort out | compare exp-out - || fail=1
70
done
71 72 73 74 75

# Another complex parsing example
cat <<\EOF > exp-out || framework_failure
<domainsnapshot>
  <description>1&lt;2</description>
76
  <memory file='d,e'/>
77 78 79 80 81 82 83 84 85
  <disks>
    <disk name='vda' snapshot='external'>
      <source file='a&amp;b,c'/>
    </disk>
    <disk name='vdb'/>
  </disks>
</domainsnapshot>

EOF
86
virsh -q -c $test_url snapshot-create-as --print-xml test \
87
  --diskspec 'vda,file=a&b,,c,snapshot=external' --description '1<2' \
88
  --diskspec vdb --memspec file=d,,e >out 2>>err || fail=1
E
Eric Blake 已提交
89
compare exp-out out || fail=1
90

91 92 93 94 95 96 97 98 99 100 101 102
cat <<\EOF > exp-out || framework_failure
<domainsnapshot>
  <name>name</name>
  <description>vda</description>
  <disks>
    <disk name='vdb'/>
  </disks>
</domainsnapshot>

EOF
virsh -q -c $test_url snapshot-create-as  --print-xml test name vda vdb \
  >out 2>>err || fail=1
E
Eric Blake 已提交
103
compare exp-out out || fail=1
104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122

cat <<\EOF > exp-out || framework_failure
<domainsnapshot>
  <name>name</name>
  <description>desc</description>
  <disks>
    <disk name='vda'/>
    <disk name='vdb'/>
  </disks>
</domainsnapshot>

EOF
for args in \
    'test name desc vda vdb' \
    'test name desc --diskspec vda vdb' \
    'test name desc --diskspec vda --diskspec vdb' \
    'test name desc vda vdb' \
    'test --diskspec vda name --diskspec vdb desc' \
    '--description desc --name name --domain test vda vdb' \
123
    '--description desc --diskspec vda --name name --domain test vdb' \
124 125 126
; do
  virsh -q -c $test_url snapshot-create-as --print-xml $args \
    >out 2>>err || fail=1
E
Eric Blake 已提交
127
  compare exp-out out || fail=1
128 129
done

130 131
test -s err && fail=1

132 133 134 135 136 137
# Test a required argv
cat <<\EOF > exp-err || framework_failure
error: this function is not supported by the connection driver: virDomainQemuMonitorCommand
EOF
virsh -q -c $test_url qemu-monitor-command test a >out 2>err && fail=1
test -s out && fail=1
E
Eric Blake 已提交
138
compare exp-err err || fail=1
139

140 141 142 143
### Test a regular numeric option

# Non-numeric value
cat <<\EOF > exp-err || framework_failure
144
error: Numeric value 'abc' for <start> option is malformed or out of range
145 146 147 148 149 150 151
EOF
virsh -q -c $test_url cpu-stats test --start abc >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Numeric value with invalid suffix
cat <<\EOF > exp-err || framework_failure
152
error: Numeric value '42WB' for <start> option is malformed or out of range
153 154 155 156 157 158 159 160
EOF
virsh -q -c $test_url cpu-stats test --start 42WB >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Numeric value with valid suffix. Suffixes are not supported for
# regular numeric options, so this value is rejected
cat <<\EOF > exp-err || framework_failure
161
error: Numeric value '42MB' for <start> option is malformed or out of range
162 163 164 165 166 167 168
EOF
virsh -q -c $test_url cpu-stats test --start 42MB >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Numeric value bigger than INT_MAX
cat <<\EOF > exp-err || framework_failure
169
error: Numeric value '2147483648' for <start> option is malformed or out of range
170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207
EOF
virsh -q -c $test_url cpu-stats test --start 2147483648 >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Negative numeric value. The value is not valid for the command
# we're testing, but it has been parsed correctly
cat <<\EOF > exp-err || framework_failure
error: Invalid value for start CPU
EOF
virsh -q -c $test_url cpu-stats test --start -1 >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Zero. The test driver doesn't support the operation so the command
# fails, but the value has been parsed correctly
cat <<\EOF > exp-err || framework_failure
error: Failed to retrieve CPU statistics for domain 'test'
error: this function is not supported by the connection driver: virDomainGetCPUStats
EOF
virsh -q -c $test_url cpu-stats test --start 0 >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Valid numeric value. The test driver doesn't support the operation
# so the command fails, but the value has been parsed correctly
cat <<\EOF > exp-err || framework_failure
error: Failed to retrieve CPU statistics for domain 'test'
error: this function is not supported by the connection driver: virDomainGetCPUStats
EOF
virsh -q -c $test_url cpu-stats test --start 42 >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

### Test a scaled numeric option

# Non-numeric value
cat <<\EOF > exp-err || framework_failure
208
error: Scaled numeric value 'abc' for <size> option is malformed or out of range
209 210 211 212 213 214 215
EOF
virsh -q -c $test_url setmaxmem test abc >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Numeric value with invalid suffix
cat <<\EOF > exp-err || framework_failure
216
error: Scaled numeric value '42WB' for <size> option is malformed or out of range
217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234
EOF
virsh -q -c $test_url setmaxmem test 42WB >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Numeric value with valid suffix
virsh -q -c $test_url setmaxmem test 42MB >out 2>err || fail=1
test -s out && fail=1
test -s err && fail=1

# Numeric value bigger than INT_MAX. No failure here because
# scaled numeric values are unsigned long long
virsh -q -c $test_url setmaxmem test 2147483648 >out 2>err || fail=1
test -s out && fail=1
test -s err && fail=1

# Negative numeric value
cat <<\EOF > exp-err || framework_failure
235
error: Scaled numeric value '-1' for <size> option is malformed or out of range
236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259
EOF
virsh -q -c $test_url setmaxmem test -1 >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Zero. The value is not valid for the command we're testing, but
# it has been parsed correctly
cat <<\EOF > exp-err || framework_failure
error: Unable to change MaxMemorySize
error: memory in virDomainSetMaxMemory must not be zero
EOF
virsh -q -c $test_url setmaxmem test 0 >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Numeric value
virsh -q -c $test_url setmaxmem test 42 >out 2>err || fail=1
test -s out && fail=1
test -s err && fail=1

### Test the <timeout> option (numeric option converted to ms)

# Non-numeric value
cat <<\EOF > exp-err || framework_failure
260
error: Numeric value 'abc' for <timeout> option is malformed or out of range
261 262 263 264 265 266 267 268
EOF
virsh -q -c $test_url event --all --timeout abc >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Numeric value that's too big to be converted to ms and still
# fit inside an int
cat <<\EOF > exp-err || framework_failure
269
error: Numeric value '2147484' for <timeout> option is malformed or out of range
270 271 272 273 274 275 276
EOF
virsh -q -c $test_url event --all --timeout 2147484 >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Numeric value with invalid suffix
cat <<\EOF > exp-err || framework_failure
277
error: Numeric value '42WB' for <timeout> option is malformed or out of range
278 279 280 281 282 283 284 285
EOF
virsh -q -c $test_url event --all --timeout 42WB >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Numeric value with valid suffix. Suffixes are not supported for
# the <timeout> option, so this value is rejected
cat <<\EOF > exp-err || framework_failure
286
error: Numeric value '42MB' for <timeout> option is malformed or out of range
287 288 289 290 291 292 293
EOF
virsh -q -c $test_url event --all --timeout 42MB >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Negative value
cat <<\EOF > exp-err || framework_failure
294
error: Numeric value '-1' for <timeout> option is malformed or out of range
295 296 297 298 299 300 301 302
EOF
virsh -q -c $test_url event --all --timeout -1 >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Zero. This is not a valid timeout, but the value is parsed
# correctly
cat <<\EOF > exp-err || framework_failure
303
error: Numeric value '0' for <timeout> option is malformed or out of range
304 305 306 307 308 309 310 311 312 313 314 315 316 317 318
EOF
virsh -q -c $test_url event --all --timeout 0 >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Numeric value. No events will be received and the command will
# fail after a second, but the value has been parsed correctly
cat <<\EOF > exp-out || framework_failure
event loop timed out
events received: 0
EOF
virsh -q -c $test_url event --all --timeout 1 >out 2>err && fail=1
test -s err && fail=1
compare exp-out out || fail=1

319
(exit $fail); exit $fail