libxl_conf.c 68.4 KB
Newer Older
1 2 3
/*
 * libxl_conf.c: libxl configuration management
 *
4
 * Copyright (C) 2012-2014, 2016 Red Hat, Inc.
5
 * Copyright (c) 2011-2013 SUSE LINUX Products GmbH, Nuernberg, Germany.
E
Eric Blake 已提交
6
 * Copyright (C) 2011 Univention GmbH.
J
Jim Fehlig 已提交
7 8 9 10 11 12 13 14 15 16 17 18
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
19
 * License along with this library.  If not, see
O
Osier Yang 已提交
20
 * <http://www.gnu.org/licenses/>.
M
Markus Groß 已提交
21 22 23
 *
 * Authors:
 *     Jim Fehlig <jfehlig@novell.com>
24
 *     Markus Groß <gross@univention.de>
J
Jim Fehlig 已提交
25 26 27 28 29 30 31 32 33 34
 */

#include <config.h>

#include <regex.h>
#include <libxl.h>
#include <sys/types.h>
#include <sys/socket.h>

#include "internal.h"
35
#include "virlog.h"
36
#include "virerror.h"
37
#include "c-ctype.h"
J
Jim Fehlig 已提交
38
#include "datatypes.h"
39
#include "virconf.h"
E
Eric Blake 已提交
40
#include "virfile.h"
J
Jim Fehlig 已提交
41
#include "virstring.h"
42
#include "viralloc.h"
43
#include "viruuid.h"
44
#include "vircommand.h"
J
Jim Fehlig 已提交
45
#include "libxl_domain.h"
J
Jim Fehlig 已提交
46
#include "libxl_conf.h"
J
Jim Fehlig 已提交
47
#include "libxl_utils.h"
48
#include "virstoragefile.h"
49
#include "secret_util.h"
50
#include "cpu/cpu.h"
J
Jim Fehlig 已提交
51 52 53 54


#define VIR_FROM_THIS VIR_FROM_LIBXL

55 56
VIR_LOG_INIT("libxl.libxl_conf");

J
Jim Fehlig 已提交
57

58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80
static virClassPtr libxlDriverConfigClass;
static void libxlDriverConfigDispose(void *obj);

static int libxlConfigOnceInit(void)
{
    if (!(libxlDriverConfigClass = virClassNew(virClassForObject(),
                                               "libxlDriverConfig",
                                               sizeof(libxlDriverConfig),
                                               libxlDriverConfigDispose)))
        return -1;

    return 0;
}

VIR_ONCE_GLOBAL_INIT(libxlConfig)

static void
libxlDriverConfigDispose(void *obj)
{
    libxlDriverConfigPtr cfg = obj;

    virObjectUnref(cfg->caps);
    libxl_ctx_free(cfg->ctx);
81
    libxlLoggerFree(cfg->logger);
82 83 84 85 86 87 88

    VIR_FREE(cfg->configDir);
    VIR_FREE(cfg->autostartDir);
    VIR_FREE(cfg->logDir);
    VIR_FREE(cfg->stateDir);
    VIR_FREE(cfg->libDir);
    VIR_FREE(cfg->saveDir);
89
    VIR_FREE(cfg->autoDumpDir);
90
    VIR_FREE(cfg->lockManagerName);
J
Joao Martins 已提交
91
    VIR_FREE(cfg->channelDir);
92
    virFirmwareFreeList(cfg->firmwares, cfg->nfirmwares);
93 94
}

95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150

static libxl_action_on_shutdown
libxlActionFromVirLifecycle(virDomainLifecycleAction action)
{
    switch (action) {
    case VIR_DOMAIN_LIFECYCLE_DESTROY:
        return LIBXL_ACTION_ON_SHUTDOWN_DESTROY;

    case VIR_DOMAIN_LIFECYCLE_RESTART:
        return  LIBXL_ACTION_ON_SHUTDOWN_RESTART;

    case VIR_DOMAIN_LIFECYCLE_RESTART_RENAME:
        return LIBXL_ACTION_ON_SHUTDOWN_RESTART_RENAME;

    case VIR_DOMAIN_LIFECYCLE_PRESERVE:
        return LIBXL_ACTION_ON_SHUTDOWN_PRESERVE;

    case VIR_DOMAIN_LIFECYCLE_LAST:
        break;
    }

    return 0;
}


static libxl_action_on_shutdown
libxlActionFromVirLifecycleCrash(virDomainLifecycleCrashAction action)
{

    switch (action) {
    case VIR_DOMAIN_LIFECYCLE_CRASH_DESTROY:
        return LIBXL_ACTION_ON_SHUTDOWN_DESTROY;

    case VIR_DOMAIN_LIFECYCLE_CRASH_RESTART:
        return  LIBXL_ACTION_ON_SHUTDOWN_RESTART;

    case VIR_DOMAIN_LIFECYCLE_CRASH_RESTART_RENAME:
        return LIBXL_ACTION_ON_SHUTDOWN_RESTART_RENAME;

    case VIR_DOMAIN_LIFECYCLE_CRASH_PRESERVE:
        return LIBXL_ACTION_ON_SHUTDOWN_PRESERVE;

    case VIR_DOMAIN_LIFECYCLE_CRASH_COREDUMP_DESTROY:
        return LIBXL_ACTION_ON_SHUTDOWN_COREDUMP_DESTROY;

    case VIR_DOMAIN_LIFECYCLE_CRASH_COREDUMP_RESTART:
        return LIBXL_ACTION_ON_SHUTDOWN_COREDUMP_RESTART;

    case VIR_DOMAIN_LIFECYCLE_CRASH_LAST:
        break;
    }

    return 0;
}


J
Jim Fehlig 已提交
151
static int
152
libxlMakeDomCreateInfo(libxl_ctx *ctx,
J
Jim Fehlig 已提交
153 154
                       virDomainDefPtr def,
                       libxl_domain_create_info *c_info)
J
Jim Fehlig 已提交
155 156 157
{
    char uuidstr[VIR_UUID_STRING_BUFLEN];

J
Jim Fehlig 已提交
158 159
    libxl_domain_create_info_init(c_info);

160
    if (def->os.type == VIR_DOMAIN_OSTYPE_HVM) {
J
Jim Fehlig 已提交
161
        c_info->type = LIBXL_DOMAIN_TYPE_HVM;
162 163 164 165 166 167 168 169 170 171 172 173 174 175
        switch ((virTristateSwitch) def->features[VIR_DOMAIN_FEATURE_HAP]) {
        case VIR_TRISTATE_SWITCH_OFF:
            libxl_defbool_set(&c_info->hap, false);
            break;

        case VIR_TRISTATE_SWITCH_ON:
            libxl_defbool_set(&c_info->hap, true);
            break;

        case VIR_TRISTATE_SWITCH_ABSENT:
        case VIR_TRISTATE_SWITCH_LAST:
            break;
        }
    } else {
J
Jim Fehlig 已提交
176
        c_info->type = LIBXL_DOMAIN_TYPE_PV;
177
    }
J
Jim Fehlig 已提交
178

179
    if (VIR_STRDUP(c_info->name, def->name) < 0)
J
Jim Fehlig 已提交
180 181
        goto error;

J
Jim Fehlig 已提交
182 183
    if (def->nseclabels &&
        def->seclabels[0]->type == VIR_DOMAIN_SECLABEL_STATIC) {
184
        if (libxl_flask_context_to_sid(ctx,
J
Jim Fehlig 已提交
185 186 187 188 189 190 191 192 193
                                       def->seclabels[0]->label,
                                       strlen(def->seclabels[0]->label),
                                       &c_info->ssidref)) {
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           _("libxenlight failed to resolve security label '%s'"),
                           def->seclabels[0]->label);
        }
    }

J
Jim Fehlig 已提交
194
    virUUIDFormat(def->uuid, uuidstr);
195
    if (libxl_uuid_from_string(&c_info->uuid, uuidstr)) {
196 197
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("libxenlight failed to parse UUID '%s'"), uuidstr);
J
Jim Fehlig 已提交
198 199 200 201 202
        goto error;
    }

    return 0;

203
 error:
J
Jim Fehlig 已提交
204
    libxl_domain_create_info_dispose(c_info);
J
Jim Fehlig 已提交
205 206 207
    return -1;
}

B
Bamvor Jian Zhang 已提交
208 209 210
static int
libxlMakeChrdevStr(virDomainChrDefPtr def, char **buf)
{
211 212
    virDomainChrSourceDefPtr srcdef = def->source;
    const char *type = virDomainChrTypeToString(srcdef->type);
B
Bamvor Jian Zhang 已提交
213 214 215 216 217 218 219

    if (!type) {
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                       "%s", _("unknown chrdev type"));
        return -1;
    }

220
    switch (srcdef->type) {
B
Bamvor Jian Zhang 已提交
221 222 223 224 225 226 227 228 229 230
    case VIR_DOMAIN_CHR_TYPE_NULL:
    case VIR_DOMAIN_CHR_TYPE_STDIO:
    case VIR_DOMAIN_CHR_TYPE_VC:
    case VIR_DOMAIN_CHR_TYPE_PTY:
        if (VIR_STRDUP(*buf, type) < 0)
            return -1;
        break;

    case VIR_DOMAIN_CHR_TYPE_FILE:
    case VIR_DOMAIN_CHR_TYPE_PIPE:
231
        if (virAsprintf(buf, "%s:%s", type, srcdef->data.file.path) < 0)
B
Bamvor Jian Zhang 已提交
232 233 234 235
            return -1;
        break;

    case VIR_DOMAIN_CHR_TYPE_DEV:
236
        if (VIR_STRDUP(*buf, srcdef->data.file.path) < 0)
B
Bamvor Jian Zhang 已提交
237 238 239 240
            return -1;
        break;

    case VIR_DOMAIN_CHR_TYPE_UDP: {
241 242 243
        const char *connectHost = srcdef->data.udp.connectHost;
        const char *bindHost = srcdef->data.udp.bindHost;
        const char *bindService  = srcdef->data.udp.bindService;
B
Bamvor Jian Zhang 已提交
244 245 246 247 248 249 250 251 252 253

        if (connectHost == NULL)
            connectHost = "";
        if (bindHost == NULL)
            bindHost = "";
        if (bindService == NULL)
            bindService = "0";

        if (virAsprintf(buf, "udp:%s:%s@%s:%s",
                        connectHost,
254
                        srcdef->data.udp.connectService,
B
Bamvor Jian Zhang 已提交
255 256 257 258 259 260 261 262 263
                        bindHost,
                        bindService) < 0)
            return -1;
        break;
    }

    case VIR_DOMAIN_CHR_TYPE_TCP: {
        const char *prefix;

264
        if (srcdef->data.tcp.protocol == VIR_DOMAIN_CHR_TCP_PROTOCOL_TELNET)
B
Bamvor Jian Zhang 已提交
265 266 267 268 269 270
            prefix = "telnet";
        else
            prefix = "tcp";

        if (virAsprintf(buf, "%s:%s:%s%s",
                        prefix,
271 272 273
                        srcdef->data.tcp.host,
                        srcdef->data.tcp.service,
                        srcdef->data.tcp.listen ? ",server,nowait" : "") < 0)
B
Bamvor Jian Zhang 已提交
274 275 276 277 278 279
            return -1;
        break;
    }

    case VIR_DOMAIN_CHR_TYPE_UNIX:
        if (virAsprintf(buf, "unix:%s%s",
280 281
                        srcdef->data.nix.path,
                        srcdef->data.nix.listen ? ",server,nowait" : "") < 0)
B
Bamvor Jian Zhang 已提交
282 283 284 285 286 287 288 289 290 291 292 293
            return -1;
        break;

    default:
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                       _("unsupported chardev '%s'"), type);
        return -1;
    }

    return 0;
}

J
Jim Fehlig 已提交
294
static int
295 296
libxlMakeDomBuildInfo(virDomainDefPtr def,
                      libxl_ctx *ctx,
297
                      virCapsPtr caps,
298
                      libxl_domain_config *d_config)
J
Jim Fehlig 已提交
299 300
{
    libxl_domain_build_info *b_info = &d_config->b_info;
301
    int hvm = def->os.type == VIR_DOMAIN_OSTYPE_HVM;
302
    size_t i;
303
    size_t nusbdevice = 0;
J
Jim Fehlig 已提交
304

J
Jim Fehlig 已提交
305
    libxl_domain_build_info_init(b_info);
J
Jim Fehlig 已提交
306

J
Jim Fehlig 已提交
307 308
    if (hvm)
        libxl_domain_build_info_init_type(b_info, LIBXL_DOMAIN_TYPE_HVM);
309
    else
J
Jim Fehlig 已提交
310
        libxl_domain_build_info_init_type(b_info, LIBXL_DOMAIN_TYPE_PV);
311

312 313
    b_info->max_vcpus = virDomainDefGetVcpusMax(def);
    if (libxl_cpu_bitmap_alloc(ctx, &b_info->avail_vcpus, b_info->max_vcpus))
314
        return -1;
315
    libxl_bitmap_set_none(&b_info->avail_vcpus);
316
    for (i = 0; i < virDomainDefGetVcpus(def); i++)
317 318
        libxl_bitmap_set((&b_info->avail_vcpus), i);

J
Jim Fehlig 已提交
319 320 321 322
    for (i = 0; i < def->clock.ntimers; i++) {
        switch ((virDomainTimerNameType) def->clock.timers[i]->name) {
        case VIR_DOMAIN_TIMER_NAME_TSC:
            switch (def->clock.timers[i]->mode) {
J
Jim Fehlig 已提交
323
            case VIR_DOMAIN_TIMER_MODE_NATIVE:
324
                b_info->tsc_mode = LIBXL_TSC_MODE_NATIVE;
J
Jim Fehlig 已提交
325 326
                break;
            case VIR_DOMAIN_TIMER_MODE_PARAVIRT:
327 328 329 330
                b_info->tsc_mode = LIBXL_TSC_MODE_NATIVE_PARAVIRT;
                break;
            case VIR_DOMAIN_TIMER_MODE_EMULATE:
                b_info->tsc_mode = LIBXL_TSC_MODE_ALWAYS_EMULATE;
J
Jim Fehlig 已提交
331 332
                break;
            default:
333
                b_info->tsc_mode = LIBXL_TSC_MODE_DEFAULT;
J
Jim Fehlig 已提交
334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359
            }
            break;

        case VIR_DOMAIN_TIMER_NAME_HPET:
            if (!hvm) {
                virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                               _("unsupported timer type (name) '%s'"),
                               virDomainTimerNameTypeToString(def->clock.timers[i]->name));
                return -1;
            }
            if (def->clock.timers[i]->present == 1)
                libxl_defbool_set(&b_info->u.hvm.hpet, 1);
            break;

        case VIR_DOMAIN_TIMER_NAME_PLATFORM:
        case VIR_DOMAIN_TIMER_NAME_KVMCLOCK:
        case VIR_DOMAIN_TIMER_NAME_HYPERVCLOCK:
        case VIR_DOMAIN_TIMER_NAME_RTC:
        case VIR_DOMAIN_TIMER_NAME_PIT:
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                           _("unsupported timer type (name) '%s'"),
                           virDomainTimerNameTypeToString(def->clock.timers[i]->name));
            return -1;

        case VIR_DOMAIN_TIMER_NAME_LAST:
            break;
J
Jim Fehlig 已提交
360 361
        }
    }
J
Jim Fehlig 已提交
362

J
Jim Fehlig 已提交
363
    b_info->sched_params.weight = 1000;
364
    b_info->max_memkb = virDomainDefGetMemoryInitial(def);
J
Jim Fehlig 已提交
365 366
    b_info->target_memkb = def->mem.cur_balloon;
    if (hvm) {
367 368
        char bootorder[VIR_DOMAIN_BOOT_LAST + 1];

J
Jim Fehlig 已提交
369
        libxl_defbool_set(&b_info->u.hvm.pae,
370
                          def->features[VIR_DOMAIN_FEATURE_PAE] ==
J
Ján Tomko 已提交
371
                          VIR_TRISTATE_SWITCH_ON);
J
Jim Fehlig 已提交
372
        libxl_defbool_set(&b_info->u.hvm.apic,
373
                          def->features[VIR_DOMAIN_FEATURE_APIC] ==
J
Ján Tomko 已提交
374
                          VIR_TRISTATE_SWITCH_ON);
J
Jim Fehlig 已提交
375
        libxl_defbool_set(&b_info->u.hvm.acpi,
376
                          def->features[VIR_DOMAIN_FEATURE_ACPI] ==
J
Ján Tomko 已提交
377
                          VIR_TRISTATE_SWITCH_ON);
378

379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412
        if (caps &&
            def->cpu && def->cpu->mode == (VIR_CPU_MODE_HOST_PASSTHROUGH)) {
            bool hasHwVirt = false;
            bool svm = false, vmx = false;

            if (ARCH_IS_X86(def->os.arch)) {
                vmx = virCPUCheckFeature(caps->host.arch, caps->host.cpu, "vmx");
                svm = virCPUCheckFeature(caps->host.arch, caps->host.cpu, "svm");
                hasHwVirt = vmx | svm;
            }

            if (def->cpu->nfeatures) {
                for (i = 0; i < def->cpu->nfeatures; i++) {

                    switch (def->cpu->features[i].policy) {

                        case VIR_CPU_FEATURE_DISABLE:
                        case VIR_CPU_FEATURE_FORBID:
                            if ((vmx && STREQ(def->cpu->features[i].name, "vmx")) ||
                                (svm && STREQ(def->cpu->features[i].name, "svm")))
                                hasHwVirt = false;
                            break;

                        case VIR_CPU_FEATURE_FORCE:
                        case VIR_CPU_FEATURE_REQUIRE:
                        case VIR_CPU_FEATURE_OPTIONAL:
                        case VIR_CPU_FEATURE_LAST:
                            break;
                    }
                }
            }
            libxl_defbool_set(&b_info->u.hvm.nested_hvm, hasHwVirt);
        }

413 414 415 416 417 418 419 420 421 422 423 424
        if (def->nsounds > 0) {
            /*
             * Use first sound device.  man xl.cfg(5) describes soundhw as
             * a single device.  From the man page: soundhw=DEVICE
             */
            virDomainSoundDefPtr snd = def->sounds[0];

            if (VIR_STRDUP(b_info->u.hvm.soundhw,
                           virDomainSoundModelTypeToString(snd->model)) < 0)
                return -1;
        }

425
        for (i = 0; i < def->os.nBootDevs; i++) {
426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444
            switch (def->os.bootDevs[i]) {
                case VIR_DOMAIN_BOOT_FLOPPY:
                    bootorder[i] = 'a';
                    break;
                default:
                case VIR_DOMAIN_BOOT_DISK:
                    bootorder[i] = 'c';
                    break;
                case VIR_DOMAIN_BOOT_CDROM:
                    bootorder[i] = 'd';
                    break;
                case VIR_DOMAIN_BOOT_NET:
                    bootorder[i] = 'n';
                    break;
            }
        }
        if (def->os.nBootDevs == 0) {
            bootorder[0] = 'c';
            bootorder[1] = '\0';
445
        } else {
446 447
            bootorder[def->os.nBootDevs] = '\0';
        }
448
        if (VIR_STRDUP(b_info->u.hvm.boot, bootorder) < 0)
449
            return -1;
P
Paolo Bonzini 已提交
450

451 452 453 454 455 456 457 458 459
#ifdef LIBXL_HAVE_BUILDINFO_KERNEL
        if (VIR_STRDUP(b_info->cmdline, def->os.cmdline) < 0)
            return -1;
        if (VIR_STRDUP(b_info->kernel, def->os.kernel) < 0)
            return -1;
        if (VIR_STRDUP(b_info->ramdisk, def->os.initrd) < 0)
            return -1;
#endif

460 461 462 463 464 465 466 467 468 469 470 471 472
        /*
         * Currently libxl only allows specifying the type of BIOS.
         * If the type is PFLASH, we assume OVMF and set libxl_bios_type
         * to LIBXL_BIOS_TYPE_OVMF. The path to the OVMF firmware is
         * configured when building Xen using '--with-system-ovmf='. If
         * not specified, LIBXL_FIRMWARE_DIR/ovmf.bin is used. In the
         * future, Xen will support a user-specified firmware path. See
         * http://lists.xenproject.org/archives/html/xen-devel/2016-03/msg01628.html
         */
        if (def->os.loader &&
            def->os.loader->type == VIR_DOMAIN_LOADER_TYPE_PFLASH)
            b_info->u.hvm.bios = LIBXL_BIOS_TYPE_OVMF;

473 474 475 476 477
        if (def->emulator) {
            if (!virFileExists(def->emulator)) {
                virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                               _("emulator '%s' not found"),
                               def->emulator);
478
                return -1;
479 480 481 482 483 484
            }

            if (!virFileIsExecutable(def->emulator)) {
                virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                               _("emulator '%s' is not executable"),
                               def->emulator);
485
                return -1;
486 487 488 489
            }

            VIR_FREE(b_info->device_model);
            if (VIR_STRDUP(b_info->device_model, def->emulator) < 0)
490
                return -1;
491 492 493 494

            b_info->device_model_version = libxlDomainGetEmulatorType(def);
        }

B
Bamvor Jian Zhang 已提交
495
        if (def->nserials) {
B
Bob Liu 已提交
496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514
            if (def->nserials == 1) {
                if (libxlMakeChrdevStr(def->serials[0], &b_info->u.hvm.serial) <
                    0)
                    return -1;
            } else {
#ifdef LIBXL_HAVE_BUILDINFO_SERIAL_LIST
                if (VIR_ALLOC_N(b_info->u.hvm.serial_list, def->nserials + 1) <
                    0)
                    return -1;
                for (i = 0; i < def->nserials; i++) {
                    if (libxlMakeChrdevStr(def->serials[i],
                                           &b_info->u.hvm.serial_list[i]) < 0)
                    {
                        libxl_string_list_dispose(&b_info->u.hvm.serial_list);
                        return -1;
                    }
                }
                b_info->u.hvm.serial_list[i] = NULL;
#else
B
Bamvor Jian Zhang 已提交
515 516 517
                virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                               "%s",
                               _("Only one serial device is supported by libxl"));
518
                return -1;
B
Bob Liu 已提交
519
#endif
B
Bamvor Jian Zhang 已提交
520 521 522 523 524 525 526
            }
        }

        if (def->nparallels) {
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                           "%s",
                           _("Parallel devices are not supported by libxl"));
527
            return -1;
B
Bamvor Jian Zhang 已提交
528 529
        }

530 531 532 533
        /* Disable VNC and SDL until explicitly enabled */
        libxl_defbool_set(&b_info->u.hvm.vnc.enable, 0);
        libxl_defbool_set(&b_info->u.hvm.sdl.enable, 0);

534 535 536 537 538 539
        for (i = 0; i < def->ninputs; i++) {
            char **usbdevice;

            if (def->inputs[i]->bus != VIR_DOMAIN_INPUT_BUS_USB)
                continue;

540
#ifdef LIBXL_HAVE_BUILDINFO_USBDEVICE_LIST
541
            if (VIR_EXPAND_N(b_info->u.hvm.usbdevice_list, nusbdevice, 1) < 0)
542 543
                return -1;
#else
544 545
            nusbdevice++;
            if (nusbdevice > 1) {
546 547 548 549 550
                virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                        _("libxenlight supports only one input device"));
                return -1;
            }
#endif
551

552
#ifdef LIBXL_HAVE_BUILDINFO_USBDEVICE_LIST
553
            usbdevice = &b_info->u.hvm.usbdevice_list[nusbdevice - 1];
554
#else
555
            usbdevice = &b_info->u.hvm.usbdevice;
556
#endif
557 558 559 560
            switch (def->inputs[i]->type) {
                case VIR_DOMAIN_INPUT_TYPE_MOUSE:
                    VIR_FREE(*usbdevice);
                    if (VIR_STRDUP(*usbdevice, "mouse") < 0)
561
                        return -1;
562 563 564 565 566 567 568 569 570 571
                    break;
                case VIR_DOMAIN_INPUT_TYPE_TABLET:
                    VIR_FREE(*usbdevice);
                    if (VIR_STRDUP(*usbdevice, "tablet") < 0)
                        return -1;
                    break;
                default:
                    virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                            _("Unknown input device type"));
                    return -1;
572 573 574
            }
        }

575 576 577 578 579 580 581 582 583
#ifdef LIBXL_HAVE_BUILDINFO_USBDEVICE_LIST
        /* NULL-terminate usbdevice_list */
        if (nusbdevice > 0 &&
            VIR_EXPAND_N(b_info->u.hvm.usbdevice_list, nusbdevice, 1) < 0) {
            VIR_DISPOSE_N(b_info->u.hvm.usbdevice_list, nusbdevice);
            return -1;
        }
#endif

584 585 586 587
        /* Allow libxl to calculate shadow memory requirements */
        b_info->shadow_memkb =
            libxl_get_required_shadow_memory(b_info->max_memkb,
                                             b_info->max_vcpus);
J
Jim Fehlig 已提交
588
    } else {
589 590 591 592 593 594
        /*
         * For compatibility with the legacy xen toolstack, default to pygrub
         * if bootloader is not specified AND direct kernel boot is not specified.
         */
        if (def->os.bootloader) {
            if (VIR_STRDUP(b_info->u.pv.bootloader, def->os.bootloader) < 0)
595
                return -1;
596 597
        } else if (def->os.kernel == NULL) {
            if (VIR_STRDUP(b_info->u.pv.bootloader, LIBXL_BOOTLOADER_PATH) < 0)
598
                return -1;
599
        }
J
Jim Fehlig 已提交
600
        if (def->os.bootloaderArgs) {
J
Jim Fehlig 已提交
601 602
            if (!(b_info->u.pv.bootloader_args =
                  virStringSplit(def->os.bootloaderArgs, " \t\n", 0)))
603
                return -1;
J
Jim Fehlig 已提交
604
        }
605
        if (VIR_STRDUP(b_info->u.pv.cmdline, def->os.cmdline) < 0)
606
            return -1;
J
Jim Fehlig 已提交
607
        if (def->os.kernel) {
608
            /* libxl_init_build_info() sets VIR_STRDUP(kernel.path, "hvmloader") */
J
Jim Fehlig 已提交
609
            VIR_FREE(b_info->u.pv.kernel);
610
            if (VIR_STRDUP(b_info->u.pv.kernel, def->os.kernel) < 0)
611
                return -1;
J
Jim Fehlig 已提交
612
        }
613
        if (VIR_STRDUP(b_info->u.pv.ramdisk, def->os.initrd) < 0)
614
            return -1;
J
Jim Fehlig 已提交
615 616 617 618 619
    }

    return 0;
}

620 621 622 623 624 625
static int
libxlDiskSetDiscard(libxl_device_disk *x_disk, int discard)
{
    if (!x_disk->readwrite)
        return 0;
#if defined(LIBXL_HAVE_LIBXL_DEVICE_DISK_DISCARD_ENABLE)
626
    switch ((virDomainDiskDiscard)discard) {
627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647
    case VIR_DOMAIN_DISK_DISCARD_DEFAULT:
    case VIR_DOMAIN_DISK_DISCARD_LAST:
        break;
    case VIR_DOMAIN_DISK_DISCARD_UNMAP:
        libxl_defbool_set(&x_disk->discard_enable, true);
        break;
    case VIR_DOMAIN_DISK_DISCARD_IGNORE:
        libxl_defbool_set(&x_disk->discard_enable, false);
        break;
    }
    return 0;
#else
    if (discard == VIR_DOMAIN_DISK_DISCARD_DEFAULT)
        return 0;
    virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                   _("This version of libxenlight does not support "
                     "disk 'discard' option passing"));
    return -1;
#endif
}

J
Jim Fehlig 已提交
648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666
static char *
libxlMakeNetworkDiskSrcStr(virStorageSourcePtr src,
                           const char *username,
                           const char *secret)
{
    char *ret = NULL;
    virBuffer buf = VIR_BUFFER_INITIALIZER;
    size_t i;

    switch ((virStorageNetProtocol) src->protocol) {
    case VIR_STORAGE_NET_PROTOCOL_NBD:
    case VIR_STORAGE_NET_PROTOCOL_HTTP:
    case VIR_STORAGE_NET_PROTOCOL_HTTPS:
    case VIR_STORAGE_NET_PROTOCOL_FTP:
    case VIR_STORAGE_NET_PROTOCOL_FTPS:
    case VIR_STORAGE_NET_PROTOCOL_TFTP:
    case VIR_STORAGE_NET_PROTOCOL_ISCSI:
    case VIR_STORAGE_NET_PROTOCOL_GLUSTER:
    case VIR_STORAGE_NET_PROTOCOL_SHEEPDOG:
667
    case VIR_STORAGE_NET_PROTOCOL_SSH:
J
Jim Fehlig 已提交
668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730
    case VIR_STORAGE_NET_PROTOCOL_LAST:
    case VIR_STORAGE_NET_PROTOCOL_NONE:
        virReportError(VIR_ERR_NO_SUPPORT,
                       _("Unsupported network block protocol '%s'"),
                       virStorageNetProtocolTypeToString(src->protocol));
        goto cleanup;

    case VIR_STORAGE_NET_PROTOCOL_RBD:
        if (strchr(src->path, ':')) {
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                           _("':' not allowed in RBD source volume name '%s'"),
                           src->path);
            goto cleanup;
        }

        virBufferStrcat(&buf, "rbd:", src->path, NULL);

        if (username) {
            virBufferEscape(&buf, '\\', ":", ":id=%s", username);
            virBufferEscape(&buf, '\\', ":",
                            ":key=%s:auth_supported=cephx\\;none",
                            secret);
        } else {
            virBufferAddLit(&buf, ":auth_supported=none");
        }

        if (src->nhosts > 0) {
            virBufferAddLit(&buf, ":mon_host=");
            for (i = 0; i < src->nhosts; i++) {
                if (i)
                    virBufferAddLit(&buf, "\\;");

                /* assume host containing : is ipv6 */
                if (strchr(src->hosts[i].name, ':'))
                    virBufferEscape(&buf, '\\', ":", "[%s]",
                                    src->hosts[i].name);
                else
                    virBufferAsprintf(&buf, "%s", src->hosts[i].name);

                if (src->hosts[i].port)
                    virBufferAsprintf(&buf, "\\:%s", src->hosts[i].port);
            }
        }

        if (src->configFile)
            virBufferEscape(&buf, '\\', ":", ":conf=%s", src->configFile);

        if (virBufferCheckError(&buf) < 0)
            goto cleanup;

        ret = virBufferContentAndReset(&buf);
        break;
    }

 cleanup:
    virBufferFreeAndReset(&buf);
    return ret;
}

static int
libxlMakeNetworkDiskSrc(virStorageSourcePtr src, char **srcstr)
{
    virConnectPtr conn = NULL;
731 732 733
    uint8_t *secret = NULL;
    char *base64secret = NULL;
    size_t secretlen = 0;
J
Jim Fehlig 已提交
734 735 736 737 738 739 740 741 742
    char *username = NULL;
    int ret = -1;

    *srcstr = NULL;
    if (src->auth && src->protocol == VIR_STORAGE_NET_PROTOCOL_RBD) {
        username = src->auth->username;
        if (!(conn = virConnectOpen("xen:///system")))
            goto cleanup;

743
        if (virSecretGetSecretString(conn, &src->auth->seclookupdef,
744 745 746 747 748 749
                                     VIR_SECRET_USAGE_TYPE_CEPH,
                                     &secret, &secretlen) < 0)
            goto cleanup;

        /* RBD expects an encoded secret */
        if (!(base64secret = virStringEncodeBase64(secret, secretlen)))
J
Jim Fehlig 已提交
750 751 752
            goto cleanup;
    }

753
    if (!(*srcstr = libxlMakeNetworkDiskSrcStr(src, username, base64secret)))
754
        goto cleanup;
J
Jim Fehlig 已提交
755 756 757 758

    ret = 0;

 cleanup:
759 760
    VIR_DISPOSE_N(secret, secretlen);
    VIR_DISPOSE_STRING(base64secret);
J
Jim Fehlig 已提交
761 762 763
    virObjectUnref(conn);
    return ret;
}
764

765
int
J
Jim Fehlig 已提交
766
libxlMakeDisk(virDomainDiskDefPtr l_disk, libxl_device_disk *x_disk)
767
{
768 769
    const char *driver = virDomainDiskGetDriver(l_disk);
    int format = virDomainDiskGetFormat(l_disk);
J
Jim Fehlig 已提交
770
    int actual_type = virStorageSourceGetActualType(l_disk->src);
771

772 773
    libxl_device_disk_init(x_disk);

J
Jim Fehlig 已提交
774
    if (actual_type == VIR_STORAGE_TYPE_NETWORK) {
775 776 777 778 779
        if (STRNEQ_NULLABLE(driver, "qemu")) {
            virReportError(VIR_ERR_OPERATION_INVALID, "%s",
                           _("only the 'qemu' driver can be used with network disks"));
            return -1;
        }
J
Jim Fehlig 已提交
780 781 782 783
        if (libxlMakeNetworkDiskSrc(l_disk->src, &x_disk->pdev_path) < 0)
            return -1;
    } else {
        if (VIR_STRDUP(x_disk->pdev_path, virDomainDiskGetSource(l_disk)) < 0)
784
        return -1;
J
Jim Fehlig 已提交
785
    }
786

787
    if (VIR_STRDUP(x_disk->vdev, l_disk->dst) < 0)
788 789
        return -1;

790 791 792
    if (driver) {
        if (STREQ(driver, "tap") || STREQ(driver, "tap2")) {
            switch (format) {
793
            case VIR_STORAGE_FILE_QCOW:
J
Jim Fehlig 已提交
794 795
                x_disk->format = LIBXL_DISK_FORMAT_QCOW;
                x_disk->backend = LIBXL_DISK_BACKEND_QDISK;
796 797
                break;
            case VIR_STORAGE_FILE_QCOW2:
J
Jim Fehlig 已提交
798 799
                x_disk->format = LIBXL_DISK_FORMAT_QCOW2;
                x_disk->backend = LIBXL_DISK_BACKEND_QDISK;
800 801
                break;
            case VIR_STORAGE_FILE_VHD:
J
Jim Fehlig 已提交
802 803
                x_disk->format = LIBXL_DISK_FORMAT_VHD;
                x_disk->backend = LIBXL_DISK_BACKEND_TAP;
804 805
                break;
            case VIR_STORAGE_FILE_RAW:
J
Jim Fehlig 已提交
806 807
                x_disk->format = LIBXL_DISK_FORMAT_RAW;
                x_disk->backend = LIBXL_DISK_BACKEND_TAP;
808
                break;
809 810 811 812 813 814
#ifdef LIBXL_HAVE_QED
            case VIR_STORAGE_FILE_QED:
                x_disk->format = LIBXL_DISK_FORMAT_QED;
                x_disk->backend = LIBXL_DISK_BACKEND_QDISK;
                break;
#endif
815 816
            default:
                virReportError(VIR_ERR_INTERNAL_ERROR,
817 818
                               _("libxenlight does not support disk format %s "
                                 "with disk driver %s"),
819 820
                               virStorageFileFormatTypeToString(format),
                               driver);
821
                return -1;
822
            }
823
        } else if (STREQ(driver, "qemu")) {
J
Jim Fehlig 已提交
824
            x_disk->backend = LIBXL_DISK_BACKEND_QDISK;
825
            switch (format) {
J
Jim Fehlig 已提交
826 827 828 829 830 831
            case VIR_STORAGE_FILE_QCOW:
                x_disk->format = LIBXL_DISK_FORMAT_QCOW;
                break;
            case VIR_STORAGE_FILE_QCOW2:
                x_disk->format = LIBXL_DISK_FORMAT_QCOW2;
                break;
832 833 834 835 836
#ifdef LIBXL_HAVE_QED
            case VIR_STORAGE_FILE_QED:
                x_disk->format = LIBXL_DISK_FORMAT_QED;
                break;
#endif
J
Jim Fehlig 已提交
837 838 839 840 841 842 843 844 845 846
            case VIR_STORAGE_FILE_VHD:
                x_disk->format = LIBXL_DISK_FORMAT_VHD;
                break;
            case VIR_STORAGE_FILE_RAW:
                x_disk->format = LIBXL_DISK_FORMAT_RAW;
                break;
            default:
                virReportError(VIR_ERR_INTERNAL_ERROR,
                               _("libxenlight does not support disk format %s "
                                 "with disk driver %s"),
847 848
                               virStorageFileFormatTypeToString(format),
                               driver);
J
Jim Fehlig 已提交
849 850
                return -1;
            }
851
        } else if (STREQ(driver, "file")) {
852
            if (format != VIR_STORAGE_FILE_RAW) {
853 854 855
                virReportError(VIR_ERR_INTERNAL_ERROR,
                               _("libxenlight does not support disk format %s "
                                 "with disk driver %s"),
856 857
                               virStorageFileFormatTypeToString(format),
                               driver);
858 859
                return -1;
            }
J
Jim Fehlig 已提交
860
            x_disk->format = LIBXL_DISK_FORMAT_RAW;
861
            x_disk->backend = LIBXL_DISK_BACKEND_QDISK;
862
        } else if (STREQ(driver, "phy")) {
863
            if (format != VIR_STORAGE_FILE_RAW) {
864 865 866
                virReportError(VIR_ERR_INTERNAL_ERROR,
                               _("libxenlight does not support disk format %s "
                                 "with disk driver %s"),
867 868
                               virStorageFileFormatTypeToString(format),
                               driver);
869 870
                return -1;
            }
J
Jim Fehlig 已提交
871 872
            x_disk->format = LIBXL_DISK_FORMAT_RAW;
            x_disk->backend = LIBXL_DISK_BACKEND_PHY;
873
        } else {
874 875
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           _("libxenlight does not support disk driver %s"),
876
                           driver);
877 878 879
            return -1;
        }
    } else {
J
Jim Fehlig 已提交
880 881 882 883 884
        /*
         * If driverName is not specified, default to raw as per
         * xl-disk-configuration.txt in the xen documentation and let
         * libxl pick a suitable backend.
         */
J
Jim Fehlig 已提交
885
        x_disk->format = LIBXL_DISK_FORMAT_RAW;
J
Jim Fehlig 已提交
886
        x_disk->backend = LIBXL_DISK_BACKEND_UNKNOWN;
887 888
    }

J
Jim Fehlig 已提交
889 890
    /* XXX is this right? */
    x_disk->removable = 1;
891
    x_disk->readwrite = !l_disk->src->readonly;
892
    x_disk->is_cdrom = l_disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM ? 1 : 0;
893 894
    if (libxlDiskSetDiscard(x_disk, l_disk->discard) < 0)
        return -1;
895 896 897
    /* An empty CDROM must have the empty format, otherwise libxl fails. */
    if (x_disk->is_cdrom && !x_disk->pdev_path)
        x_disk->format = LIBXL_DISK_FORMAT_EMPTY;
898
    if (l_disk->transient) {
899 900
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("libxenlight does not support transient disks"));
901 902
        return -1;
    }
903

904 905 906 907 908 909 910 911 912 913 914 915
    if (l_disk->domain_name) {
#ifdef LIBXL_HAVE_DEVICE_BACKEND_DOMNAME
        if (VIR_STRDUP(x_disk->backend_domname, l_disk->domain_name) < 0)
            return -1;
#else
        virReportError(VIR_ERR_XML_DETAIL, "%s",
                _("this version of libxenlight does not "
                  "support backend domain name"));
        return -1;
#endif
    }

916 917 918
    return 0;
}

J
Jim Fehlig 已提交
919 920 921 922 923 924
static int
libxlMakeDiskList(virDomainDefPtr def, libxl_domain_config *d_config)
{
    virDomainDiskDefPtr *l_disks = def->disks;
    int ndisks = def->ndisks;
    libxl_device_disk *x_disks;
925
    size_t i;
J
Jim Fehlig 已提交
926

927
    if (VIR_ALLOC_N(x_disks, ndisks) < 0)
J
Jim Fehlig 已提交
928 929 930
        return -1;

    for (i = 0; i < ndisks; i++) {
J
Jim Fehlig 已提交
931
        if (libxlMakeDisk(l_disks[i], &x_disks[i]) < 0)
J
Jim Fehlig 已提交
932 933 934 935 936 937 938 939
            goto error;
    }

    d_config->disks = x_disks;
    d_config->num_disks = ndisks;

    return 0;

940
 error:
J
Jim Fehlig 已提交
941
    for (i = 0; i < ndisks; i++)
J
Jim Fehlig 已提交
942
        libxl_device_disk_dispose(&x_disks[i]);
J
Jim Fehlig 已提交
943 944 945 946
    VIR_FREE(x_disks);
    return -1;
}

947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978
/*
 * Update libvirt disk config with libxl disk config.
 *
 * This function can be used to update the libvirt disk config with default
 * values selected by libxl. Currently only the backend type is selected by
 * libxl when not explicitly specified by the user.
 */
void
libxlUpdateDiskDef(virDomainDiskDefPtr l_disk, libxl_device_disk *x_disk)
{
    const char *driver = NULL;

    if (virDomainDiskGetDriver(l_disk))
        return;

    switch (x_disk->backend) {
    case LIBXL_DISK_BACKEND_QDISK:
        driver = "qemu";
        break;
    case LIBXL_DISK_BACKEND_TAP:
        driver = "tap";
        break;
    case LIBXL_DISK_BACKEND_PHY:
        driver = "phy";
        break;
    case LIBXL_DISK_BACKEND_UNKNOWN:
        break;
    }
    if (driver)
        ignore_value(virDomainDiskSetDriver(l_disk, driver));
}

979
int
980 981
libxlMakeNic(virDomainDefPtr def,
             virDomainNetDefPtr l_nic,
982 983
             libxl_device_nic *x_nic,
             bool attach)
984
{
985
    virDomainNetType actual_type = virDomainNetGetActualType(l_nic);
J
Jim Fehlig 已提交
986 987
    virNetworkPtr network = NULL;
    virConnectPtr conn = NULL;
988
    virNetDevBandwidthPtr actual_bw;
J
Jim Fehlig 已提交
989
    int ret = -1;
990

J
Jim Fehlig 已提交
991 992 993 994
    /* TODO: Where is mtu stored?
     *
     * x_nics[i].mtu = 1492;
     */
995

996 997 998 999 1000 1001 1002 1003
    if (l_nic->script && !(actual_type == VIR_DOMAIN_NET_TYPE_BRIDGE ||
                           actual_type == VIR_DOMAIN_NET_TYPE_ETHERNET)) {
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("specifying a script is only supported with "
                         "interface types bridge and ethernet"));
        return -1;
    }

1004 1005
    libxl_device_nic_init(x_nic);

1006
    virMacAddrGetRaw(&l_nic->mac, x_nic->mac);
1007

1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021
    /*
     * The nictype field of libxl_device_nic structure tells Xen which type of
     * NIC device to create for the domain. LIBXL_NIC_TYPE_VIF specifies a
     * PV NIC. LIBXL_NIC_TYPE_VIF_IOEMU specifies a PV and emulated NIC,
     * allowing the domain to choose which NIC to use and unplug the unused
     * one. LIBXL_NIC_TYPE_VIF_IOEMU is only valid for HVM domains. Further,
     * if hotplugging the NIC, emulated NICs are currently not supported.
     * Alternatively one could set LIBXL_NIC_TYPE_UNKNOWN and let libxl decide,
     * but its behaviour might not be consistent across all libvirt supported
     * versions. The other nictype values are well established already, hence
     * we manually select our own default and mimic xl/libxl behaviour starting
     * xen commit 32e9d0f ("libxl: nic type defaults to vif in hotplug for
     * hvm guest").
     */
1022
    if (l_nic->model) {
1023 1024 1025 1026 1027 1028 1029
        if (def->os.type == VIR_DOMAIN_OSTYPE_XEN &&
            STRNEQ(l_nic->model, "netfront")) {
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                           _("only model 'netfront' is supported for "
                             "Xen PV domains"));
            return -1;
        }
1030
        if (VIR_STRDUP(x_nic->model, l_nic->model) < 0)
J
Jim Fehlig 已提交
1031
            goto cleanup;
1032 1033
        if (STREQ(l_nic->model, "netfront"))
            x_nic->nictype = LIBXL_NIC_TYPE_VIF;
1034 1035 1036 1037 1038 1039 1040
        else
            x_nic->nictype = LIBXL_NIC_TYPE_VIF_IOEMU;
    } else {
        if (def->os.type == VIR_DOMAIN_OSTYPE_HVM && !attach)
            x_nic->nictype = LIBXL_NIC_TYPE_VIF_IOEMU;
        else
            x_nic->nictype = LIBXL_NIC_TYPE_VIF;
1041 1042
    }

1043
    if (VIR_STRDUP(x_nic->ifname, l_nic->ifname) < 0)
J
Jim Fehlig 已提交
1044
        goto cleanup;
1045

1046
    switch (actual_type) {
1047
        case VIR_DOMAIN_NET_TYPE_BRIDGE:
1048 1049
            if (VIR_STRDUP(x_nic->bridge,
                           virDomainNetGetActualBridgeName(l_nic)) < 0)
J
Jim Fehlig 已提交
1050
                goto cleanup;
1051 1052 1053
            /* fallthrough */
        case VIR_DOMAIN_NET_TYPE_ETHERNET:
            if (VIR_STRDUP(x_nic->script, l_nic->script) < 0)
J
Jim Fehlig 已提交
1054
                goto cleanup;
1055 1056
            if (l_nic->guestIP.nips > 0) {
                x_nic->ip = virSocketAddrFormat(&l_nic->guestIP.ips[0]->address);
1057
                if (!x_nic->ip)
J
Jim Fehlig 已提交
1058
                    goto cleanup;
1059
            }
1060
            break;
1061 1062 1063
        case VIR_DOMAIN_NET_TYPE_NETWORK:
        {
            if (!(conn = virConnectOpen("xen:///system")))
J
Jim Fehlig 已提交
1064
                goto cleanup;
1065 1066 1067

            if (!(network =
                  virNetworkLookupByName(conn, l_nic->data.network.name))) {
J
Jim Fehlig 已提交
1068
                goto cleanup;
1069 1070
            }

1071 1072
            if (l_nic->guestIP.nips > 0) {
                x_nic->ip = virSocketAddrFormat(&l_nic->guestIP.ips[0]->address);
1073
                if (!x_nic->ip)
J
Jim Fehlig 已提交
1074
                    goto cleanup;
1075 1076
            }

J
Jim Fehlig 已提交
1077 1078
            if (!(x_nic->bridge = virNetworkGetBridgeName(network)))
                goto cleanup;
1079 1080
            break;
        }
M
Michele Paolino 已提交
1081
        case VIR_DOMAIN_NET_TYPE_VHOSTUSER:
1082 1083 1084 1085
        case VIR_DOMAIN_NET_TYPE_USER:
        case VIR_DOMAIN_NET_TYPE_SERVER:
        case VIR_DOMAIN_NET_TYPE_CLIENT:
        case VIR_DOMAIN_NET_TYPE_MCAST:
1086
        case VIR_DOMAIN_NET_TYPE_UDP:
1087 1088 1089 1090
        case VIR_DOMAIN_NET_TYPE_INTERNAL:
        case VIR_DOMAIN_NET_TYPE_DIRECT:
        case VIR_DOMAIN_NET_TYPE_HOSTDEV:
        case VIR_DOMAIN_NET_TYPE_LAST:
1091 1092
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                    _("unsupported interface type %s"),
1093
                    virDomainNetTypeToString(l_nic->type));
J
Jim Fehlig 已提交
1094
            goto cleanup;
1095 1096
    }

1097 1098 1099
    if (l_nic->domain_name) {
#ifdef LIBXL_HAVE_DEVICE_BACKEND_DOMNAME
        if (VIR_STRDUP(x_nic->backend_domname, l_nic->domain_name) < 0)
J
Jim Fehlig 已提交
1100
            goto cleanup;
1101 1102 1103 1104
#else
        virReportError(VIR_ERR_XML_DETAIL, "%s",
                _("this version of libxenlight does not "
                  "support backend domain name"));
J
Jim Fehlig 已提交
1105
        goto cleanup;
1106 1107 1108
#endif
    }

1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146
    /*
     * Set bandwidth.
     * From $xen-sources/docs/misc/xl-network-configuration.markdown:
     *
     *
     * Specifies the rate at which the outgoing traffic will be limited to.
     * The default if this keyword is not specified is unlimited.
     *
     * The rate may be specified as "<RATE>/s" or optionally "<RATE>/s@<INTERVAL>".
     *
     * `RATE` is in bytes and can accept suffixes:
     *     GB, MB, KB, B for bytes.
     *     Gb, Mb, Kb, b for bits.
     * `INTERVAL` is in microseconds and can accept suffixes: ms, us, s.
     *     It determines the frequency at which the vif transmission credit
     *     is replenished. The default is 50ms.

     * Vif rate limiting is credit-based. It means that for "1MB/s@20ms",
     * the available credit will be equivalent of the traffic you would have
     * done at "1MB/s" during 20ms. This will results in a credit of 20,000
     * bytes replenished every 20,000 us.
     *
     *
     * libvirt doesn't support the notion of rate limiting over an interval.
     * Similar to xl's behavior when interval is not specified, set a default
     * interval of 50ms and calculate the number of bytes per interval based
     * on the specified average bandwidth.
     */
    actual_bw = virDomainNetGetActualBandwidth(l_nic);
    if (actual_bw && actual_bw->out && actual_bw->out->average) {
        uint64_t bytes_per_sec = actual_bw->out->average * 1024;
        uint64_t bytes_per_interval =
            (((uint64_t) bytes_per_sec * 50000UL) / 1000000UL);

        x_nic->rate_bytes_per_interval = bytes_per_interval;
        x_nic->rate_interval_usecs =  50000UL;
    }

J
Jim Fehlig 已提交
1147 1148 1149 1150 1151 1152 1153
    ret = 0;

 cleanup:
    virObjectUnref(network);
    virObjectUnref(conn);

    return ret;
1154 1155
}

J
Jim Fehlig 已提交
1156 1157 1158 1159
static int
libxlMakeNicList(virDomainDefPtr def,  libxl_domain_config *d_config)
{
    virDomainNetDefPtr *l_nics = def->nets;
1160
    size_t nnics = def->nnets;
J
Jim Fehlig 已提交
1161
    libxl_device_nic *x_nics;
1162
    size_t i, nvnics = 0;
J
Jim Fehlig 已提交
1163

1164
    if (VIR_ALLOC_N(x_nics, nnics) < 0)
J
Jim Fehlig 已提交
1165 1166 1167
        return -1;

    for (i = 0; i < nnics; i++) {
1168
        if (virDomainNetGetActualType(l_nics[i]) == VIR_DOMAIN_NET_TYPE_HOSTDEV)
1169 1170
            continue;

1171
        if (libxlMakeNic(def, l_nics[i], &x_nics[nvnics], false))
J
Jim Fehlig 已提交
1172
            goto error;
1173 1174 1175 1176 1177
        /*
         * The devid (at least right now) will not get initialized by
         * libxl in the setup case but is required for starting the
         * device-model.
         */
1178 1179 1180 1181
        if (x_nics[nvnics].devid < 0)
            x_nics[nvnics].devid = nvnics;

        nvnics++;
J
Jim Fehlig 已提交
1182 1183
    }

1184
    VIR_SHRINK_N(x_nics, nnics, nnics - nvnics);
J
Jim Fehlig 已提交
1185
    d_config->nics = x_nics;
1186
    d_config->num_nics = nvnics;
J
Jim Fehlig 已提交
1187 1188 1189

    return 0;

1190
 error:
J
Jim Fehlig 已提交
1191
    for (i = 0; i < nnics; i++)
J
Jim Fehlig 已提交
1192
        libxl_device_nic_dispose(&x_nics[i]);
J
Jim Fehlig 已提交
1193 1194 1195 1196
    VIR_FREE(x_nics);
    return -1;
}

1197
int
1198
libxlMakeVfb(virPortAllocatorPtr graphicsports,
J
Jim Fehlig 已提交
1199 1200
             virDomainGraphicsDefPtr l_vfb,
             libxl_device_vfb *x_vfb)
1201
{
1202
    unsigned short port;
1203
    virDomainGraphicsListenDefPtr glisten = NULL;
1204

1205 1206
    libxl_device_vfb_init(x_vfb);

1207 1208
    switch (l_vfb->type) {
        case VIR_DOMAIN_GRAPHICS_TYPE_SDL:
J
Jim Fehlig 已提交
1209
            libxl_defbool_set(&x_vfb->sdl.enable, 1);
1210
            libxl_defbool_set(&x_vfb->vnc.enable, 0);
1211
            libxl_defbool_set(&x_vfb->sdl.opengl, 0);
1212
            if (VIR_STRDUP(x_vfb->sdl.display, l_vfb->data.sdl.display) < 0)
1213
                return -1;
1214
            if (VIR_STRDUP(x_vfb->sdl.xauthority, l_vfb->data.sdl.xauth) < 0)
1215 1216 1217
                return -1;
            break;
        case  VIR_DOMAIN_GRAPHICS_TYPE_VNC:
J
Jim Fehlig 已提交
1218
            libxl_defbool_set(&x_vfb->vnc.enable, 1);
1219
            libxl_defbool_set(&x_vfb->sdl.enable, 0);
1220
            /* driver handles selection of free port */
J
Jim Fehlig 已提交
1221
            libxl_defbool_set(&x_vfb->vnc.findunused, 0);
1222
            if (l_vfb->data.vnc.autoport) {
1223

1224
                if (virPortAllocatorAcquire(graphicsports, &port) < 0)
1225
                    return -1;
1226 1227
                l_vfb->data.vnc.port = port;
            }
J
Jim Fehlig 已提交
1228
            x_vfb->vnc.display = l_vfb->data.vnc.port - LIBXL_VNC_PORT_MIN;
1229

1230 1231
            if ((glisten = virDomainGraphicsGetListen(l_vfb, 0)) &&
                glisten->address) {
1232
                /* libxl_device_vfb_init() does VIR_STRDUP("127.0.0.1") */
J
Jim Fehlig 已提交
1233
                VIR_FREE(x_vfb->vnc.listen);
1234
                if (VIR_STRDUP(x_vfb->vnc.listen, glisten->address) < 0)
1235 1236
                    return -1;
            }
J
Jim Fehlig 已提交
1237 1238
            if (VIR_STRDUP(x_vfb->vnc.passwd, l_vfb->data.vnc.auth.passwd) < 0)
                return -1;
1239
            if (VIR_STRDUP(x_vfb->keymap, l_vfb->data.vnc.keymap) < 0)
1240 1241
                return -1;
            break;
1242 1243 1244 1245 1246 1247

        case VIR_DOMAIN_GRAPHICS_TYPE_RDP:
        case VIR_DOMAIN_GRAPHICS_TYPE_DESKTOP:
        case VIR_DOMAIN_GRAPHICS_TYPE_SPICE:
        case VIR_DOMAIN_GRAPHICS_TYPE_LAST:
            break;
1248
    }
J
Jim Fehlig 已提交
1249

1250 1251 1252
    return 0;
}

J
Jim Fehlig 已提交
1253
static int
1254
libxlMakeVfbList(virPortAllocatorPtr graphicsports,
J
Jim Fehlig 已提交
1255 1256
                 virDomainDefPtr def,
                 libxl_domain_config *d_config)
J
Jim Fehlig 已提交
1257 1258 1259 1260 1261
{
    virDomainGraphicsDefPtr *l_vfbs = def->graphics;
    int nvfbs = def->ngraphics;
    libxl_device_vfb *x_vfbs;
    libxl_device_vkb *x_vkbs;
1262
    size_t i;
J
Jim Fehlig 已提交
1263 1264 1265 1266

    if (nvfbs == 0)
        return 0;

1267
    if (VIR_ALLOC_N(x_vfbs, nvfbs) < 0)
J
Jim Fehlig 已提交
1268 1269 1270 1271 1272 1273 1274
        return -1;
    if (VIR_ALLOC_N(x_vkbs, nvfbs) < 0) {
        VIR_FREE(x_vfbs);
        return -1;
    }

    for (i = 0; i < nvfbs; i++) {
J
Jim Fehlig 已提交
1275
        libxl_device_vkb_init(&x_vkbs[i]);
J
Jim Fehlig 已提交
1276

1277
        if (libxlMakeVfb(graphicsports, l_vfbs[i], &x_vfbs[i]) < 0)
1278
            goto error;
J
Jim Fehlig 已提交
1279 1280 1281 1282 1283 1284 1285 1286
    }

    d_config->vfbs = x_vfbs;
    d_config->vkbs = x_vkbs;
    d_config->num_vfbs = d_config->num_vkbs = nvfbs;

    return 0;

1287
 error:
J
Jim Fehlig 已提交
1288
    for (i = 0; i < nvfbs; i++) {
J
Jim Fehlig 已提交
1289 1290
        libxl_device_vfb_dispose(&x_vfbs[i]);
        libxl_device_vkb_dispose(&x_vkbs[i]);
J
Jim Fehlig 已提交
1291 1292 1293 1294 1295 1296
    }
    VIR_FREE(x_vfbs);
    VIR_FREE(x_vkbs);
    return -1;
}

1297 1298 1299 1300 1301 1302
/*
 * Populate vfb info in libxl_domain_build_info struct for HVM domains.
 * Prior to calling this function, libxlMakeVfbList must be called to
 * populate libxl_domain_config->vfbs.
 */
static int
1303 1304 1305
libxlMakeBuildInfoVfb(virPortAllocatorPtr graphicsports,
                      virDomainDefPtr def,
                      libxl_domain_config *d_config)
1306 1307 1308
{
    libxl_domain_build_info *b_info = &d_config->b_info;
    libxl_device_vfb x_vfb;
1309
    size_t i;
1310 1311 1312 1313

    if (def->os.type != VIR_DOMAIN_OSTYPE_HVM)
        return 0;

1314 1315 1316 1317 1318 1319 1320 1321 1322 1323
    if (def->ngraphics == 0)
        return 0;

    /*
     * Prefer SPICE, otherwise use first libxl_device_vfb device in
     * libxl_domain_config->vfbs. Prior to calling this function,
     */
    for (i = 0; i < def->ngraphics; i++) {
        virDomainGraphicsDefPtr l_vfb = def->graphics[i];
        unsigned short port;
1324
        virDomainGraphicsListenDefPtr glisten = NULL;
1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337

        if (l_vfb->type != VIR_DOMAIN_GRAPHICS_TYPE_SPICE)
            continue;

        libxl_defbool_set(&b_info->u.hvm.spice.enable, true);

        if (l_vfb->data.spice.autoport) {
            if (virPortAllocatorAcquire(graphicsports, &port) < 0)
                return -1;
            l_vfb->data.spice.port = port;
        }
        b_info->u.hvm.spice.port = l_vfb->data.spice.port;

1338 1339 1340
        if ((glisten = virDomainGraphicsGetListen(l_vfb, 0)) &&
            glisten->address &&
            VIR_STRDUP(b_info->u.hvm.spice.host, glisten->address) < 0)
1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363
            return -1;

        if (VIR_STRDUP(b_info->u.hvm.keymap, l_vfb->data.spice.keymap) < 0)
            return -1;

        if (l_vfb->data.spice.auth.passwd) {
            if (VIR_STRDUP(b_info->u.hvm.spice.passwd,
                           l_vfb->data.spice.auth.passwd) < 0)
                return -1;
            libxl_defbool_set(&b_info->u.hvm.spice.disable_ticketing, false);
        } else {
            libxl_defbool_set(&b_info->u.hvm.spice.disable_ticketing, true);
        }

        switch (l_vfb->data.spice.mousemode) {
            /* client mouse mode is default in xl.cfg */
        case VIR_DOMAIN_GRAPHICS_SPICE_MOUSE_MODE_DEFAULT:
        case VIR_DOMAIN_GRAPHICS_SPICE_MOUSE_MODE_CLIENT:
            libxl_defbool_set(&b_info->u.hvm.spice.agent_mouse, true);
            break;
        case VIR_DOMAIN_GRAPHICS_SPICE_MOUSE_MODE_SERVER:
            libxl_defbool_set(&b_info->u.hvm.spice.agent_mouse, false);
            break;
1364 1365
        case VIR_DOMAIN_GRAPHICS_SPICE_MOUSE_MODE_LAST:
            break;
1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377
        }

#ifdef LIBXL_HAVE_SPICE_VDAGENT
        if (l_vfb->data.spice.copypaste == VIR_TRISTATE_BOOL_YES) {
            libxl_defbool_set(&b_info->u.hvm.spice.vdagent, true);
            libxl_defbool_set(&b_info->u.hvm.spice.clipboard_sharing, true);
        } else {
            libxl_defbool_set(&b_info->u.hvm.spice.vdagent, false);
            libxl_defbool_set(&b_info->u.hvm.spice.clipboard_sharing, false);
        }
#endif

1378
        return 0;
1379
    }
1380 1381 1382 1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407

    x_vfb = d_config->vfbs[0];

    if (libxl_defbool_val(x_vfb.vnc.enable)) {
        libxl_defbool_set(&b_info->u.hvm.vnc.enable, true);
        if (VIR_STRDUP(b_info->u.hvm.vnc.listen, x_vfb.vnc.listen) < 0)
            return -1;
        if (VIR_STRDUP(b_info->u.hvm.vnc.passwd, x_vfb.vnc.passwd) < 0)
            return -1;
        b_info->u.hvm.vnc.display = x_vfb.vnc.display;
        libxl_defbool_set(&b_info->u.hvm.vnc.findunused,
                          libxl_defbool_val(x_vfb.vnc.findunused));
    } else if (libxl_defbool_val(x_vfb.sdl.enable)) {
        libxl_defbool_set(&b_info->u.hvm.sdl.enable, true);
        libxl_defbool_set(&b_info->u.hvm.sdl.opengl,
                          libxl_defbool_val(x_vfb.sdl.opengl));
        if (VIR_STRDUP(b_info->u.hvm.sdl.display, x_vfb.sdl.display) < 0)
            return -1;
        if (VIR_STRDUP(b_info->u.hvm.sdl.xauthority, x_vfb.sdl.xauthority) < 0)
            return -1;
    }

    if (VIR_STRDUP(b_info->u.hvm.keymap, x_vfb.keymap) < 0)
        return -1;

    return 0;
}

1408 1409 1410 1411 1412 1413
/*
 * Get domain0 autoballoon configuration.  Honor user-specified
 * setting in libxl.conf first.  If not specified, autoballooning
 * is disabled when domain0's memory is set with 'dom0_mem'.
 * Otherwise autoballooning is enabled.
 */
J
Jim Fehlig 已提交
1414
static int
1415 1416
libxlGetAutoballoonConf(libxlDriverConfigPtr cfg,
                        virConfPtr conf)
1417 1418
{
    regex_t regex;
J
Jim Fehlig 已提交
1419 1420
    int res;

1421 1422
    res = virConfGetValueBool(conf, "autoballoon", &cfg->autoballoon);
    if (res < 0)
1423
        return -1;
1424 1425
    else if (res == 1)
        return 0;
1426

J
Jim Fehlig 已提交
1427 1428 1429 1430 1431 1432 1433 1434
    if ((res = regcomp(&regex,
                      "(^| )dom0_mem=((|min:|max:)[0-9]+[bBkKmMgG]?,?)+($| )",
                       REG_NOSUB | REG_EXTENDED)) != 0) {
        char error[100];
        regerror(res, &regex, error, sizeof(error));
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("Failed to compile regex %s"),
                       error);
1435

J
Jim Fehlig 已提交
1436 1437
        return -1;
    }
1438

J
Jim Fehlig 已提交
1439
    res = regexec(&regex, cfg->verInfo->commandline, 0, NULL, 0);
1440
    regfree(&regex);
1441
    cfg->autoballoon = res == REG_NOMATCH;
J
Jim Fehlig 已提交
1442
    return 0;
1443 1444
}

1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457
libxlDriverConfigPtr
libxlDriverConfigNew(void)
{
    libxlDriverConfigPtr cfg;
    char ebuf[1024];
    unsigned int free_mem;

    if (libxlConfigInitialize() < 0)
        return NULL;

    if (!(cfg = virObjectNew(libxlDriverConfigClass)))
        return NULL;

1458 1459
    if (VIR_STRDUP(cfg->configBaseDir, LIBXL_CONFIG_BASE_DIR) < 0)
        goto error;
1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471
    if (VIR_STRDUP(cfg->configDir, LIBXL_CONFIG_DIR) < 0)
        goto error;
    if (VIR_STRDUP(cfg->autostartDir, LIBXL_AUTOSTART_DIR) < 0)
        goto error;
    if (VIR_STRDUP(cfg->logDir, LIBXL_LOG_DIR) < 0)
        goto error;
    if (VIR_STRDUP(cfg->stateDir, LIBXL_STATE_DIR) < 0)
        goto error;
    if (VIR_STRDUP(cfg->libDir, LIBXL_LIB_DIR) < 0)
        goto error;
    if (VIR_STRDUP(cfg->saveDir, LIBXL_SAVE_DIR) < 0)
        goto error;
1472 1473
    if (VIR_STRDUP(cfg->autoDumpDir, LIBXL_DUMP_DIR) < 0)
        goto error;
J
Joao Martins 已提交
1474 1475
    if (VIR_STRDUP(cfg->channelDir, LIBXL_CHANNEL_DIR) < 0)
        goto error;
1476

1477 1478 1479 1480 1481 1482 1483 1484
    if (virFileMakePath(cfg->logDir) < 0) {
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("failed to create log dir '%s': %s"),
                       cfg->logDir,
                       virStrerror(errno, ebuf, sizeof(ebuf)));
        goto error;
    }

1485
    cfg->logger = libxlLoggerNew(cfg->logDir, virLogGetDefaultPriority());
1486 1487 1488 1489 1490
    if (!cfg->logger) {
        VIR_ERROR(_("cannot create logger for libxenlight, disabling driver"));
        goto error;
    }

1491
    if (libxl_ctx_alloc(&cfg->ctx, LIBXL_VERSION, 0, (xentoollog_logger *)cfg->logger)) {
1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511
        VIR_ERROR(_("cannot initialize libxenlight context, probably not "
                    "running in a Xen Dom0, disabling driver"));
        goto error;
    }

    if ((cfg->verInfo = libxl_get_version_info(cfg->ctx)) == NULL) {
        VIR_ERROR(_("cannot version information from libxenlight, "
                    "disabling driver"));
        goto error;
    }
    cfg->version = (cfg->verInfo->xen_version_major * 1000000) +
        (cfg->verInfo->xen_version_minor * 1000);

    /* This will fill xenstore info about free and dom0 memory if missing,
     * should be called before starting first domain */
    if (libxl_get_free_memory(cfg->ctx, &free_mem)) {
        VIR_ERROR(_("Unable to configure libxl's memory management parameters"));
        goto error;
    }

1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538
#ifdef DEFAULT_LOADER_NVRAM
    if (virFirmwareParseList(DEFAULT_LOADER_NVRAM,
                             &cfg->firmwares,
                             &cfg->nfirmwares) < 0)
        goto error;

#else
    if (VIR_ALLOC_N(cfg->firmwares, 1) < 0)
        goto error;
    cfg->nfirmwares = 1;
    if (VIR_ALLOC(cfg->firmwares[0]) < 0)
        goto error;
    if (VIR_STRDUP(cfg->firmwares[0]->name,
                   LIBXL_FIRMWARE_DIR "/ovmf.bin") < 0)
        goto error;
#endif

    /* Always add hvmloader to firmwares */
    if (VIR_REALLOC_N(cfg->firmwares, cfg->nfirmwares + 1) < 0)
        goto error;
    cfg->nfirmwares++;
    if (VIR_ALLOC(cfg->firmwares[cfg->nfirmwares - 1]) < 0)
        goto error;
    if (VIR_STRDUP(cfg->firmwares[cfg->nfirmwares - 1]->name,
                   LIBXL_FIRMWARE_DIR "/hvmloader") < 0)
        goto error;

1539 1540
    return cfg;

1541
 error:
1542 1543 1544 1545 1546 1547 1548
    virObjectUnref(cfg);
    return NULL;
}

libxlDriverConfigPtr
libxlDriverConfigGet(libxlDriverPrivatePtr driver)
{
1549 1550 1551 1552 1553 1554
    libxlDriverConfigPtr cfg;

    libxlDriverLock(driver);
    cfg = virObjectRef(driver->config);
    libxlDriverUnlock(driver);
    return cfg;
1555 1556
}

1557 1558 1559 1560 1561 1562
int libxlDriverConfigLoadFile(libxlDriverConfigPtr cfg,
                              const char *filename)
{
    virConfPtr conf = NULL;
    int ret = -1;

J
Joao Martins 已提交
1563 1564 1565 1566
    /* defaults for keepalive messages */
    cfg->keepAliveInterval = 5;
    cfg->keepAliveCount = 5;

1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581
    /* Check the file is readable before opening it, otherwise
     * libvirt emits an error.
     */
    if (access(filename, R_OK) == -1) {
        VIR_INFO("Could not read libxl config file %s", filename);
        return 0;
    }

    if (!(conf = virConfReadFile(filename, 0)))
        goto cleanup;

    /* setup autoballoon */
    if (libxlGetAutoballoonConf(cfg, conf) < 0)
        goto cleanup;

1582 1583
    if (virConfGetValueString(conf, "lock_manager", &cfg->lockManagerName) < 0)
        goto cleanup;
J
Joao Martins 已提交
1584

1585 1586
    if (virConfGetValueInt(conf, "keepalive_interval", &cfg->keepAliveInterval) < 0)
        goto cleanup;
J
Joao Martins 已提交
1587

1588 1589
    if (virConfGetValueUInt(conf, "keepalive_count", &cfg->keepAliveCount) < 0)
        goto cleanup;
J
Joao Martins 已提交
1590

1591 1592 1593 1594 1595 1596 1597 1598
    ret = 0;

 cleanup:
    virConfFree(conf);
    return ret;

}

1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660
/*
 * dom0's maximum memory can be controled by the user with the 'dom0_mem' Xen
 * command line parameter. E.g. to set dom0's initial memory to 4G and max
 * memory to 8G: dom0_mem=4G,max:8G
 * Supported unit suffixes are [bBkKmMgGtT]. If not specified the default
 * unit is kilobytes.
 *
 * If not constrained by the user, dom0 can effectively use all host memory.
 * This function returns the configured maximum memory for dom0 in kilobytes,
 * either the user-specified value or total physical memory as a default.
 */
int
libxlDriverGetDom0MaxmemConf(libxlDriverConfigPtr cfg,
                             unsigned long long *maxmem)
{
    char **cmd_tokens = NULL;
    char **mem_tokens = NULL;
    size_t i;
    size_t j;
    libxl_physinfo physinfo;
    int ret = -1;

    if (cfg->verInfo->commandline == NULL ||
        !(cmd_tokens = virStringSplit(cfg->verInfo->commandline, " ", 0)))
        goto physmem;

    for (i = 0; cmd_tokens[i] != NULL; i++) {
        if (!STRPREFIX(cmd_tokens[i], "dom0_mem="))
            continue;

        if (!(mem_tokens = virStringSplit(cmd_tokens[i], ",", 0)))
            break;
        for (j = 0; mem_tokens[j] != NULL; j++) {
            if (STRPREFIX(mem_tokens[j], "max:")) {
                char *p = mem_tokens[j] + 4;
                unsigned long long multiplier = 1;

                while (c_isdigit(*p))
                    p++;
                if (virStrToLong_ull(mem_tokens[j] + 4, &p, 10, maxmem) < 0)
                    break;
                if (*p) {
                    switch (*p) {
                    case 'm':
                    case 'M':
                        multiplier = 1024;
                        break;
                    case 'g':
                    case 'G':
                        multiplier = 1024 * 1024;
                        break;
                    case 't':
                    case 'T':
                        multiplier = 1024 * 1024 * 1024;
                        break;
                    }
                }
                *maxmem = *maxmem * multiplier;
                ret = 0;
                goto cleanup;
            }
        }
1661
        virStringListFree(mem_tokens);
1662
        mem_tokens = NULL;
1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682
    }

 physmem:
    /* No 'max' specified in dom0_mem, so dom0 can use all physical memory */
    libxl_physinfo_init(&physinfo);
    if (libxl_get_physinfo(cfg->ctx, &physinfo)) {
        VIR_WARN("libxl_get_physinfo failed");
        goto cleanup;
    }
    *maxmem = (physinfo.total_pages * cfg->verInfo->pagesize) / 1024;
    libxl_physinfo_dispose(&physinfo);
    ret = 0;

 cleanup:
    virStringListFree(cmd_tokens);
    virStringListFree(mem_tokens);
    return ret;
}


J
Joao Martins 已提交
1683 1684 1685 1686 1687 1688 1689
#ifdef LIBXL_HAVE_DEVICE_CHANNEL
static int
libxlPrepareChannel(virDomainChrDefPtr channel,
                    const char *channelDir,
                    const char *domainName)
{
    if (channel->targetType == VIR_DOMAIN_CHR_CHANNEL_TARGET_TYPE_XEN &&
1690 1691 1692
        channel->source->type == VIR_DOMAIN_CHR_TYPE_UNIX &&
        !channel->source->data.nix.path) {
        if (virAsprintf(&channel->source->data.nix.path,
J
Joao Martins 已提交
1693 1694 1695 1696 1697
                        "%s/%s-%s", channelDir, domainName,
                        channel->target.name ? channel->target.name
                        : "unknown.sock") < 0)
            return -1;

1698
        channel->source->data.nix.listen = true;
J
Joao Martins 已提交
1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715
    }

    return 0;
}

static int
libxlMakeChannel(virDomainChrDefPtr l_channel,
                 libxl_device_channel *x_channel)
{
    libxl_device_channel_init(x_channel);

    if (l_channel->targetType != VIR_DOMAIN_CHR_CHANNEL_TARGET_TYPE_XEN) {
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("channel target type not supported"));
        return -1;
    }

1716
    switch (l_channel->source->type) {
J
Joao Martins 已提交
1717 1718 1719 1720 1721 1722
    case VIR_DOMAIN_CHR_TYPE_PTY:
        x_channel->connection = LIBXL_CHANNEL_CONNECTION_PTY;
        break;
    case VIR_DOMAIN_CHR_TYPE_UNIX:
        x_channel->connection = LIBXL_CHANNEL_CONNECTION_SOCKET;
        if (VIR_STRDUP(x_channel->u.socket.path,
1723
                       l_channel->source->data.nix.path) < 0)
J
Joao Martins 已提交
1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783
            return -1;
        break;
    default:
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("channel source type not supported"));
        break;
    }

    if (!l_channel->target.name) {
        virReportError(VIR_ERR_OPERATION_INVALID, "%s",
                       _("channel target name missing"));
        return -1;
    }

    if (VIR_STRDUP(x_channel->name, l_channel->target.name) < 0)
        return -1;

    return 0;
}

static int
libxlMakeChannelList(const char *channelDir,
                     virDomainDefPtr def,
                     libxl_domain_config *d_config)
{
    virDomainChrDefPtr *l_channels = def->channels;
    size_t nchannels = def->nchannels;
    libxl_device_channel *x_channels;
    size_t i, nvchannels = 0;

    if (VIR_ALLOC_N(x_channels, nchannels) < 0)
        return -1;

    for (i = 0; i < nchannels; i++) {
        if (l_channels[i]->deviceType != VIR_DOMAIN_CHR_DEVICE_TYPE_CHANNEL)
            continue;

        if (libxlPrepareChannel(l_channels[i], channelDir, def->name) < 0)
            goto error;

        if (libxlMakeChannel(l_channels[i], &x_channels[nvchannels]) < 0)
            goto error;

        nvchannels++;
    }

    VIR_SHRINK_N(x_channels, nchannels, nchannels - nvchannels);
    d_config->channels = x_channels;
    d_config->num_channels = nvchannels;

    return 0;

 error:
    for (i = 0; i < nchannels; i++)
        libxl_device_channel_dispose(&x_channels[i]);
    VIR_FREE(x_channels);
    return -1;
}
#endif

1784
#ifdef LIBXL_HAVE_PVUSB
1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865
int
libxlMakeUSBController(virDomainControllerDefPtr controller,
                       libxl_device_usbctrl *usbctrl)
{
    usbctrl->devid = controller->idx;

    if (controller->type != VIR_DOMAIN_CONTROLLER_TYPE_USB)
        return -1;

    if (controller->model == -1) {
        usbctrl->version = 2;
        usbctrl->type = LIBXL_USBCTRL_TYPE_QUSB;
    } else {
        switch (controller->model) {
        case VIR_DOMAIN_CONTROLLER_MODEL_USB_QUSB1:
            usbctrl->version = 1;
            usbctrl->type = LIBXL_USBCTRL_TYPE_QUSB;
            break;

        case VIR_DOMAIN_CONTROLLER_MODEL_USB_QUSB2:
            usbctrl->version = 2;
            usbctrl->type = LIBXL_USBCTRL_TYPE_QUSB;
            break;

        default:
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                           _("unsupported usb model"));
            return -1;
        }
    }

    if (controller->opts.usbopts.ports == -1)
        usbctrl->ports = 8;
    else
        usbctrl->ports = controller->opts.usbopts.ports;

    return 0;
}

static int
libxlMakeUSBControllerList(virDomainDefPtr def, libxl_domain_config *d_config)
{
    virDomainControllerDefPtr *l_controllers = def->controllers;
    size_t ncontrollers = def->ncontrollers;
    size_t nusbctrls = 0;
    libxl_device_usbctrl *x_usbctrls;
    size_t i;

    if (ncontrollers == 0)
        return 0;

    if (VIR_ALLOC_N(x_usbctrls, ncontrollers) < 0)
        return -1;

    for (i = 0; i < ncontrollers; i++) {
        if (l_controllers[i]->type != VIR_DOMAIN_CONTROLLER_TYPE_USB)
            continue;

        libxl_device_usbctrl_init(&x_usbctrls[nusbctrls]);

        if (libxlMakeUSBController(l_controllers[i],
                                   &x_usbctrls[nusbctrls]) < 0)
            goto error;

        nusbctrls++;
    }

    VIR_SHRINK_N(x_usbctrls, ncontrollers, ncontrollers - nusbctrls);
    d_config->usbctrls = x_usbctrls;
    d_config->num_usbctrls = nusbctrls;

    return 0;

 error:
    for (i = 0; i < nusbctrls; i++)
        libxl_device_usbctrl_dispose(&x_usbctrls[i]);

    VIR_FREE(x_usbctrls);
    return -1;
}

1866 1867 1868 1869
int
libxlMakeUSB(virDomainHostdevDefPtr hostdev, libxl_device_usbdev *usbdev)
{
    virDomainHostdevSubsysUSBPtr usbsrc = &hostdev->source.subsys.u.usb;
1870 1871
    virUSBDevicePtr usb = NULL;
    int ret = -1;
1872 1873

    if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS)
1874
        return ret;
1875
    if (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB)
1876
        return ret;
1877

1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891
    if (usbsrc->bus > 0 && usbsrc->device > 0) {
        usbdev->u.hostdev.hostbus = usbsrc->bus;
        usbdev->u.hostdev.hostaddr = usbsrc->device;
    } else {
        if (virHostdevFindUSBDevice(hostdev, true, &usb) < 0) {
            virReportError(VIR_ERR_OPERATION_FAILED,
                           _("failed to find USB device busnum:devnum "
                             "for %x:%x"),
                           usbsrc->vendor, usbsrc->product);
            goto cleanup;
        }

        usbdev->u.hostdev.hostbus = virUSBDeviceGetBus(usb);
        usbdev->u.hostdev.hostaddr = virUSBDeviceGetDevno(usb);
1892 1893
    }

1894
    ret = 0;
1895

1896 1897 1898 1899
 cleanup:
    virUSBDeviceFree(usb);

    return ret;
1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913 1914 1915 1916 1917 1918 1919 1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939 1940 1941 1942 1943 1944 1945 1946
}

static int
libxlMakeUSBList(virDomainDefPtr def, libxl_domain_config *d_config)
{
    virDomainHostdevDefPtr *l_hostdevs = def->hostdevs;
    size_t nhostdevs = def->nhostdevs;
    size_t nusbdevs = 0;
    libxl_device_usbdev *x_usbdevs;
    size_t i, j;

    if (nhostdevs == 0)
        return 0;

    if (VIR_ALLOC_N(x_usbdevs, nhostdevs) < 0)
        return -1;

    for (i = 0, j = 0; i < nhostdevs; i++) {
        if (l_hostdevs[i]->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS)
            continue;
        if (l_hostdevs[i]->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB)
            continue;

        libxl_device_usbdev_init(&x_usbdevs[j]);

        if (libxlMakeUSB(l_hostdevs[i], &x_usbdevs[j]) < 0)
            goto error;

        nusbdevs++;
        j++;
    }

    VIR_SHRINK_N(x_usbdevs, nhostdevs, nhostdevs - nusbdevs);
    d_config->usbdevs = x_usbdevs;
    d_config->num_usbdevs = nusbdevs;

    return 0;

 error:
    for (i = 0; i < nusbdevs; i++)
        libxl_device_usbdev_dispose(&x_usbdevs[i]);

    VIR_FREE(x_usbdevs);
    return -1;
}
#endif

1947
int
1948
libxlMakePCI(virDomainHostdevDefPtr hostdev, libxl_device_pci *pcidev)
1949
{
1950
    virDomainHostdevSubsysPCIPtr pcisrc = &hostdev->source.subsys.u.pci;
1951 1952 1953 1954 1955
    if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS)
        return -1;
    if (hostdev->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI)
        return -1;

1956 1957 1958 1959
    pcidev->domain = pcisrc->addr.domain;
    pcidev->bus = pcisrc->addr.bus;
    pcidev->dev = pcisrc->addr.slot;
    pcidev->func = pcisrc->addr.function;
1960 1961 1962 1963 1964

    return 0;
}

static int
1965
libxlMakePCIList(virDomainDefPtr def, libxl_domain_config *d_config)
1966 1967 1968 1969 1970 1971 1972 1973 1974 1975 1976 1977 1978 1979 1980 1981 1982 1983 1984 1985 1986
{
    virDomainHostdevDefPtr *l_hostdevs = def->hostdevs;
    size_t nhostdevs = def->nhostdevs;
    size_t npcidevs = 0;
    libxl_device_pci *x_pcidevs;
    size_t i, j;

    if (nhostdevs == 0)
        return 0;

    if (VIR_ALLOC_N(x_pcidevs, nhostdevs) < 0)
        return -1;

    for (i = 0, j = 0; i < nhostdevs; i++) {
        if (l_hostdevs[i]->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS)
            continue;
        if (l_hostdevs[i]->source.subsys.type != VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI)
            continue;

        libxl_device_pci_init(&x_pcidevs[j]);

1987
        if (libxlMakePCI(l_hostdevs[i], &x_pcidevs[j]) < 0)
1988 1989 1990 1991 1992 1993 1994 1995 1996 1997 1998 1999
            goto error;

        npcidevs++;
        j++;
    }

    VIR_SHRINK_N(x_pcidevs, nhostdevs, nhostdevs - npcidevs);
    d_config->pcidevs = x_pcidevs;
    d_config->num_pcidevs = npcidevs;

    return 0;

2000
 error:
2001 2002 2003 2004 2005 2006 2007
    for (i = 0; i < npcidevs; i++)
        libxl_device_pci_dispose(&x_pcidevs[i]);

    VIR_FREE(x_pcidevs);
    return -1;
}

2008 2009 2010 2011 2012 2013 2014 2015 2016 2017 2018 2019 2020 2021 2022 2023 2024 2025 2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037 2038 2039 2040 2041 2042 2043 2044 2045 2046 2047 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058
static int
libxlMakeVideo(virDomainDefPtr def, libxl_domain_config *d_config)

{
    libxl_domain_build_info *b_info = &d_config->b_info;
    int dm_type = libxlDomainGetEmulatorType(def);

    if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_HVM)
        return 0;

    /*
     * Take the first defined video device (graphics card) to display
     * on the first graphics device (display).
     */
    if (def->nvideos) {
        switch (def->videos[0]->type) {
        case VIR_DOMAIN_VIDEO_TYPE_VGA:
        case VIR_DOMAIN_VIDEO_TYPE_XEN:
            b_info->u.hvm.vga.kind = LIBXL_VGA_INTERFACE_TYPE_STD;
            if (dm_type == LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
                if (def->videos[0]->vram < 16 * 1024) {
                    virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                                   _("videoram must be at least 16MB for VGA"));
                    return -1;
                }
            } else {
                if (def->videos[0]->vram < 8 * 1024) {
                    virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                                   _("videoram must be at least 8MB for VGA"));
                    return -1;
                }
            }
            break;

        case VIR_DOMAIN_VIDEO_TYPE_CIRRUS:
            b_info->u.hvm.vga.kind = LIBXL_VGA_INTERFACE_TYPE_CIRRUS;
            if (dm_type == LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) {
                if (def->videos[0]->vram < 8 * 1024) {
                    virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                                   _("videoram must be at least 8MB for CIRRUS"));
                    return -1;
                }
            } else {
                if (def->videos[0]->vram < 4 * 1024) {
                    virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                                   _("videoram must be at least 4MB for CIRRUS"));
                    return -1;
                }
            }
            break;

J
Jim Fehlig 已提交
2059 2060 2061 2062 2063 2064 2065 2066 2067 2068 2069
#ifdef LIBXL_HAVE_QXL
        case VIR_DOMAIN_VIDEO_TYPE_QXL:
            b_info->u.hvm.vga.kind = LIBXL_VGA_INTERFACE_TYPE_QXL;
            if (def->videos[0]->vram < 128 * 1024) {
                virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                               _("videoram must be at least 128MB for QXL"));
                return -1;
            }
            break;
#endif

2070 2071 2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084
        default:
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                           _("video type %s is not supported by libxl"),
                           virDomainVideoTypeToString(def->videos[0]->type));
            return -1;
        }
        /* vram validated for each video type, now set it */
        b_info->video_memkb = def->videos[0]->vram;
    } else {
        libxl_defbool_set(&b_info->u.hvm.nographic, 1);
    }

    return 0;
}

2085 2086 2087 2088 2089 2090 2091 2092
int
libxlDriverNodeGetInfo(libxlDriverPrivatePtr driver, virNodeInfoPtr info)
{
    libxl_physinfo phy_info;
    virArch hostarch = virArchFromHost();
    libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver);
    int ret = -1;

2093
    libxl_physinfo_init(&phy_info);
2094 2095 2096 2097 2098 2099 2100 2101 2102 2103 2104 2105 2106 2107 2108 2109 2110 2111 2112 2113 2114 2115 2116
    if (libxl_get_physinfo(cfg->ctx, &phy_info)) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("libxl_get_physinfo_info failed"));
        goto cleanup;
    }

    if (virStrcpyStatic(info->model, virArchToString(hostarch)) == NULL) {
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("machine type %s too big for destination"),
                       virArchToString(hostarch));
        goto cleanup;
    }

    info->memory = phy_info.total_pages * (cfg->verInfo->pagesize / 1024);
    info->cpus = phy_info.nr_cpus;
    info->nodes = phy_info.nr_nodes;
    info->cores = phy_info.cores_per_socket;
    info->threads = phy_info.threads_per_core;
    info->sockets = 1;
    info->mhz = phy_info.cpu_khz / 1000;

    ret = 0;

2117
 cleanup:
2118
    libxl_physinfo_dispose(&phy_info);
2119 2120 2121 2122
    virObjectUnref(cfg);
    return ret;
}

J
Jim Fehlig 已提交
2123
int
2124
libxlBuildDomainConfig(virPortAllocatorPtr graphicsports,
2125
                       virDomainDefPtr def,
J
Joao Martins 已提交
2126
                       const char *channelDir LIBXL_ATTR_UNUSED,
2127
                       libxl_ctx *ctx,
2128
                       virCapsPtr caps,
2129
                       libxl_domain_config *d_config)
J
Jim Fehlig 已提交
2130
{
2131
    libxl_domain_config_init(d_config);
J
Jim Fehlig 已提交
2132

2133
    if (libxlMakeDomCreateInfo(ctx, def, &d_config->c_info) < 0)
J
Jim Fehlig 已提交
2134 2135
        return -1;

2136
    if (libxlMakeDomBuildInfo(def, ctx, caps, d_config) < 0)
2137
        return -1;
J
Jim Fehlig 已提交
2138

2139
    if (libxlMakeDiskList(def, d_config) < 0)
2140
        return -1;
J
Jim Fehlig 已提交
2141

2142
    if (libxlMakeNicList(def, d_config) < 0)
2143
        return -1;
J
Jim Fehlig 已提交
2144

2145
    if (libxlMakeVfbList(graphicsports, def, d_config) < 0)
2146
        return -1;
J
Jim Fehlig 已提交
2147

2148
    if (libxlMakeBuildInfoVfb(graphicsports, def, d_config) < 0)
2149 2150
        return -1;

2151
    if (libxlMakePCIList(def, d_config) < 0)
2152 2153
        return -1;

2154
#ifdef LIBXL_HAVE_PVUSB
2155 2156 2157
    if (libxlMakeUSBControllerList(def, d_config) < 0)
        return -1;

2158 2159 2160 2161
    if (libxlMakeUSBList(def, d_config) < 0)
        return -1;
#endif

J
Joao Martins 已提交
2162 2163 2164 2165 2166
#ifdef LIBXL_HAVE_DEVICE_CHANNEL
    if (libxlMakeChannelList(channelDir, def, d_config) < 0)
        return -1;
#endif

2167 2168 2169 2170 2171 2172 2173 2174
    /*
     * Now that any potential VFBs are defined, update the build info with
     * the data of the primary display. Some day libxl might implicitely do
     * so but as it does not right now, better be explicit.
     */
    if (libxlMakeVideo(def, d_config) < 0)
        return -1;

2175 2176 2177
    d_config->on_reboot = libxlActionFromVirLifecycle(def->onReboot);
    d_config->on_poweroff = libxlActionFromVirLifecycle(def->onPoweroff);
    d_config->on_crash = libxlActionFromVirLifecycleCrash(def->onCrash);
J
Jim Fehlig 已提交
2178 2179 2180

    return 0;
}
2181 2182 2183 2184 2185 2186 2187 2188

virDomainXMLOptionPtr
libxlCreateXMLConf(void)
{
    return virDomainXMLOptionNew(&libxlDomainDefParserConfig,
                                 &libxlDomainXMLPrivateDataCallbacks,
                                 NULL);
}