virt-aa-helper.c 45.5 KB
Newer Older
J
Jamie Strandboge 已提交
1 2
/*
 * virt-aa-helper: wrapper program used by AppArmor security driver.
3
 *
4
 * Copyright (C) 2010-2014 Red Hat, Inc.
5
 * Copyright (C) 2009-2011 Canonical Ltd.
J
Jamie Strandboge 已提交
6
 *
O
Osier Yang 已提交
7 8 9 10 11 12 13 14 15 16 17
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
18
 * License along with this library.  If not, see
O
Osier Yang 已提交
19
 * <http://www.gnu.org/licenses/>.
J
Jamie Strandboge 已提交
20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38
 *
 * Author:
 *   Jamie Strandboge <jamie@canonical.com>
 *
 */

#include <config.h>

#include <stdlib.h>
#include <string.h>
#include <stdarg.h>
#include <unistd.h>
#include <errno.h>
#include <sys/types.h>
#include <fcntl.h>
#include <getopt.h>
#include <sys/utsname.h>

#include "internal.h"
39
#include "virbuffer.h"
40
#include "viralloc.h"
41
#include "vircommand.h"
42
#include "virlog.h"
43
#include "dirname.h"
44
#include "driver.h"
J
Jamie Strandboge 已提交
45 46 47 48

#include "security_driver.h"
#include "security_apparmor.h"
#include "domain_conf.h"
49
#include "virxml.h"
50
#include "viruuid.h"
51
#include "virusb.h"
52
#include "virpci.h"
E
Eric Blake 已提交
53
#include "virfile.h"
54
#include "configmake.h"
55
#include "virrandom.h"
56
#include "virstring.h"
57
#include "virgettext.h"
58
#include "virhostdev.h"
J
Jamie Strandboge 已提交
59

60 61
#define VIR_FROM_THIS VIR_FROM_SECURITY

J
Jamie Strandboge 已提交
62 63 64 65 66 67 68 69 70 71 72 73
static char *progname;

typedef struct {
    char uuid[PROFILE_NAME_SIZE];       /* UUID of vm */
    bool dryrun;                /* dry run */
    char cmd;                   /* 'c'   create
                                 * 'a'   add (load)
                                 * 'r'   replace
                                 * 'R'   remove */
    char *files;                /* list of files */
    virDomainDefPtr def;        /* VM definition */
    virCapsPtr caps;            /* VM capabilities */
74
    virDomainXMLOptionPtr xmlopt; /* XML parser data */
75
    char *virtType;                  /* type of hypervisor (eg qemu, xen, lxc) */
76
    char *os;                   /* type of os (eg hvm, xen, exe) */
77
    virArch arch;               /* machine architecture */
78 79
    char *newfile;              /* newly added file */
    bool append;                /* append to .files instead of rewrite */
J
Jamie Strandboge 已提交
80 81 82 83 84 85 86 87 88
} vahControl;

static int
vahDeinit(vahControl * ctl)
{
    if (ctl == NULL)
        return -1;

    VIR_FREE(ctl->def);
89
    virObjectUnref(ctl->caps);
90
    virObjectUnref(ctl->xmlopt);
91
    VIR_FREE(ctl->files);
92
    VIR_FREE(ctl->virtType);
93
    VIR_FREE(ctl->os);
94
    VIR_FREE(ctl->newfile);
J
Jamie Strandboge 已提交
95 96 97 98 99 100 101 102 103 104

    return 0;
}

/*
 * Print usage
 */
static void
vah_usage(void)
{
105 106 107 108
    printf(_("\n%s [options] [< def.xml]\n\n"
            "  Options:\n"
            "    -a | --add                     load profile\n"
            "    -c | --create                  create profile from template\n"
109
            "    -d | --dryrun                  dry run\n"
110 111 112 113 114 115 116 117 118 119 120
            "    -D | --delete                  unload and delete profile\n"
            "    -f | --add-file <file>         add file to profile\n"
            "    -F | --append-file <file>      append file to profile\n"
            "    -r | --replace                 reload profile\n"
            "    -R | --remove                  unload profile\n"
            "    -h | --help                    this help\n"
            "    -u | --uuid <uuid>             uuid (profile name)\n"
            "\n"), progname);

    puts(_("This command is intended to be used by libvirtd "
           "and not used directly.\n"));
J
Jamie Strandboge 已提交
121 122 123 124 125 126
    return;
}

static void
vah_error(vahControl * ctl, int doexit, const char *str)
{
127
    fprintf(stderr, _("%s: error: %s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
128 129 130 131 132 133 134 135 136 137 138

    if (doexit) {
        if (ctl != NULL)
            vahDeinit(ctl);
        exit(EXIT_FAILURE);
    }
}

static void
vah_warning(const char *str)
{
139
    fprintf(stderr, _("%s: warning: %s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
140 141 142 143 144
}

static void
vah_info(const char *str)
{
145
    fprintf(stderr, _("%s:\n%s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
146 147 148 149 150 151 152 153
}

/*
 * run an apparmor_parser command
 */
static int
parserCommand(const char *profile_name, const char cmd)
{
154
    int result = -1;
J
Jamie Strandboge 已提交
155
    char flag[3];
156
    char *profile;
157 158
    int status;
    int ret;
J
Jamie Strandboge 已提交
159 160

    if (strchr("arR", cmd) == NULL) {
161
        vah_error(NULL, 0, _("invalid flag"));
J
Jamie Strandboge 已提交
162 163 164 165 166
        return -1;
    }

    snprintf(flag, 3, "-%c", cmd);

167 168
    if (virAsprintfQuiet(&profile, "%s/%s",
                         APPARMOR_DIR "/libvirt", profile_name) < 0) {
169
        vah_error(NULL, 0, _("profile name exceeds maximum length"));
J
Jamie Strandboge 已提交
170 171 172 173
        return -1;
    }

    if (!virFileExists(profile)) {
174
        vah_error(NULL, 0, _("profile does not exist"));
175
        goto cleanup;
J
Jamie Strandboge 已提交
176 177 178 179
    } else {
        const char * const argv[] = {
            "/sbin/apparmor_parser", flag, profile, NULL
        };
180 181 182
        if ((ret = virRun(argv, &status)) != 0 ||
            (WIFEXITED(status) && WEXITSTATUS(status) != 0)) {
            if (ret != 0) {
183
                vah_error(NULL, 0, _("failed to run apparmor_parser"));
184
                goto cleanup;
185 186 187
            } else if (cmd == 'R' && WIFEXITED(status) &&
                       WEXITSTATUS(status) == 234) {
                vah_warning(_("unable to unload already unloaded profile"));
188
            } else {
189
                vah_error(NULL, 0, _("apparmor_parser exited with error"));
190
                goto cleanup;
191
            }
J
Jamie Strandboge 已提交
192 193 194
        }
    }

195 196
    result = 0;

197
 cleanup:
198 199 200
    VIR_FREE(profile);

    return result;
J
Jamie Strandboge 已提交
201 202 203 204 205 206
}

/*
 * Update the dynamic files
 */
static int
207 208
update_include_file(const char *include_file, const char *included_files,
                    bool append)
J
Jamie Strandboge 已提交
209 210
{
    int rc = -1;
211
    int plen, flen = 0;
J
Jamie Strandboge 已提交
212 213
    int fd;
    char *pcontent = NULL;
214
    char *existing = NULL;
J
Jamie Strandboge 已提交
215 216 217
    const char *warning =
         "# DO NOT EDIT THIS FILE DIRECTLY. IT IS MANAGED BY LIBVIRT.\n";

218 219 220 221 222 223 224
    if (virFileExists(include_file)) {
        flen = virFileReadAll(include_file, MAX_FILE_LEN, &existing);
        if (flen < 0)
            return rc;
    }

    if (append && virFileExists(include_file)) {
225
        if (virAsprintfQuiet(&pcontent, "%s%s", existing, included_files) == -1) {
226
            vah_error(NULL, 0, _("could not allocate memory for profile"));
227
            goto cleanup;
228 229
        }
    } else {
230
        if (virAsprintfQuiet(&pcontent, "%s%s", warning, included_files) == -1) {
231
            vah_error(NULL, 0, _("could not allocate memory for profile"));
232
            goto cleanup;
233
        }
J
Jamie Strandboge 已提交
234 235 236 237
    }

    plen = strlen(pcontent);
    if (plen > MAX_FILE_LEN) {
238
        vah_error(NULL, 0, _("invalid length for new profile"));
239
        goto cleanup;
J
Jamie Strandboge 已提交
240 241 242
    }

    /* only update the disk profile if it is different */
243 244
    if (flen > 0 && flen == plen && STREQLEN(existing, pcontent, plen)) {
        rc = 0;
245
        goto cleanup;
J
Jamie Strandboge 已提交
246 247 248 249
    }

    /* write the file */
    if ((fd = open(include_file, O_CREAT | O_TRUNC | O_WRONLY, 0644)) == -1) {
250
        vah_error(NULL, 0, _("failed to create include file"));
251
        goto cleanup;
J
Jamie Strandboge 已提交
252 253 254
    }

    if (safewrite(fd, pcontent, plen) < 0) { /* don't write the '\0' */
255
        VIR_FORCE_CLOSE(fd);
256
        vah_error(NULL, 0, _("failed to write to profile"));
257
        goto cleanup;
J
Jamie Strandboge 已提交
258 259
    }

260
    if (VIR_CLOSE(fd) != 0) {
261
        vah_error(NULL, 0, _("failed to close or write to profile"));
262
        goto cleanup;
J
Jamie Strandboge 已提交
263 264 265
    }
    rc = 0;

266
 cleanup:
J
Jamie Strandboge 已提交
267
    VIR_FREE(pcontent);
268
    VIR_FREE(existing);
J
Jamie Strandboge 已提交
269 270 271 272 273 274 275 276 277

    return rc;
}

/*
 * Create a profile based on a template
 */
static int
create_profile(const char *profile, const char *profile_name,
278
               const char *profile_files, int virtType)
J
Jamie Strandboge 已提交
279
{
280
    char *template;
J
Jamie Strandboge 已提交
281 282 283 284
    char *tcontent = NULL;
    char *pcontent = NULL;
    char *replace_name = NULL;
    char *replace_files = NULL;
285
    char *tmp = NULL;
J
Jamie Strandboge 已提交
286 287 288 289 290
    const char *template_name = "\nprofile LIBVIRT_TEMPLATE";
    const char *template_end = "\n}";
    int tlen, plen;
    int fd;
    int rc = -1;
291
    const char *driver_name = NULL;
J
Jamie Strandboge 已提交
292 293

    if (virFileExists(profile)) {
294
        vah_error(NULL, 0, _("profile exists"));
J
Jamie Strandboge 已提交
295 296 297
        goto end;
    }

298 299 300 301 302 303 304 305 306
    switch (virtType) {
    case VIR_DOMAIN_VIRT_QEMU:
    case VIR_DOMAIN_VIRT_KQEMU:
    case VIR_DOMAIN_VIRT_KVM:
        driver_name = "qemu";
        break;
    default:
        driver_name = virDomainVirtTypeToString(virtType);
    }
C
Cédric Bosdonnat 已提交
307 308

    if (virAsprintfQuiet(&template, "%s/TEMPLATE.%s", APPARMOR_DIR "/libvirt",
309
                         driver_name) < 0) {
310
        vah_error(NULL, 0, _("template name exceeds maximum length"));
J
Jamie Strandboge 已提交
311 312 313 314
        goto end;
    }

    if (!virFileExists(template)) {
315
        vah_error(NULL, 0, _("template does not exist"));
J
Jamie Strandboge 已提交
316 317 318 319
        goto end;
    }

    if ((tlen = virFileReadAll(template, MAX_FILE_LEN, &tcontent)) < 0) {
320
        vah_error(NULL, 0, _("failed to read AppArmor template"));
J
Jamie Strandboge 已提交
321 322 323 324
        goto end;
    }

    if (strstr(tcontent, template_name) == NULL) {
325
        vah_error(NULL, 0, _("no replacement string in template"));
J
Jamie Strandboge 已提交
326 327 328 329
        goto clean_tcontent;
    }

    if (strstr(tcontent, template_end) == NULL) {
330
        vah_error(NULL, 0, _("no replacement string in template"));
J
Jamie Strandboge 已提交
331 332 333 334
        goto clean_tcontent;
    }

    /* '\nprofile <profile_name>\0' */
335
    if (virAsprintfQuiet(&replace_name, "\nprofile %s", profile_name) == -1) {
336
        vah_error(NULL, 0, _("could not allocate memory for profile name"));
J
Jamie Strandboge 已提交
337 338 339 340
        goto clean_tcontent;
    }

    /* '\n<profile_files>\n}\0' */
341 342
    if ((virtType != VIR_DOMAIN_VIRT_LXC) &&
            virAsprintfQuiet(&replace_files, "\n%s\n}", profile_files) == -1) {
343
        vah_error(NULL, 0, _("could not allocate memory for profile files"));
J
Jamie Strandboge 已提交
344 345 346 347
        VIR_FREE(replace_name);
        goto clean_tcontent;
    }

C
Cédric Bosdonnat 已提交
348
    plen = tlen + strlen(replace_name) - strlen(template_name) + 1;
349 350 351 352

    if (virtType != VIR_DOMAIN_VIRT_LXC)
        plen += strlen(replace_files) - strlen(template_end);

J
Jamie Strandboge 已提交
353
    if (plen > MAX_FILE_LEN || plen < tlen) {
354
        vah_error(NULL, 0, _("invalid length for new profile"));
J
Jamie Strandboge 已提交
355 356 357
        goto clean_replace;
    }

358
    if (!(pcontent = virStringReplace(tcontent, template_name, replace_name)))
J
Jamie Strandboge 已提交
359 360
        goto clean_all;

361 362 363 364 365 366 367
    if (virtType != VIR_DOMAIN_VIRT_LXC) {
        if (!(tmp = virStringReplace(pcontent, template_end, replace_files)))
            goto clean_all;
        VIR_FREE(pcontent);
        pcontent = tmp;
        tmp = NULL;
    }
J
Jamie Strandboge 已提交
368 369 370

    /* write the file */
    if ((fd = open(profile, O_CREAT | O_EXCL | O_WRONLY, 0644)) == -1) {
371
        vah_error(NULL, 0, _("failed to create profile"));
J
Jamie Strandboge 已提交
372 373 374 375
        goto clean_all;
    }

    if (safewrite(fd, pcontent, plen - 1) < 0) { /* don't write the '\0' */
376
        VIR_FORCE_CLOSE(fd);
377
        vah_error(NULL, 0, _("failed to write to profile"));
J
Jamie Strandboge 已提交
378 379 380
        goto clean_all;
    }

381
    if (VIR_CLOSE(fd) != 0) {
382
        vah_error(NULL, 0, _("failed to close or write to profile"));
J
Jamie Strandboge 已提交
383 384 385 386
        goto clean_all;
    }
    rc = 0;

387
 clean_all:
J
Jamie Strandboge 已提交
388
    VIR_FREE(pcontent);
389
 clean_replace:
J
Jamie Strandboge 已提交
390 391
    VIR_FREE(replace_name);
    VIR_FREE(replace_files);
392
 clean_tcontent:
J
Jamie Strandboge 已提交
393
    VIR_FREE(tcontent);
394
 end:
395
    VIR_FREE(template);
J
Jamie Strandboge 已提交
396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447
    return rc;
}

/*
 * Load an existing profile
 */
static int
parserLoad(const char *profile_name)
{
    return parserCommand(profile_name, 'a');
}

/*
 * Remove an existing profile
 */
static int
parserRemove(const char *profile_name)
{
    return parserCommand(profile_name, 'R');
}

/*
 * Replace an existing profile
 */
static int
parserReplace(const char *profile_name)
{
    return parserCommand(profile_name, 'r');
}

static int
valid_uuid(const char *uuid)
{
    unsigned char rawuuid[VIR_UUID_BUFLEN];

    if (strlen(uuid) != PROFILE_NAME_SIZE - 1)
        return -1;

    if (!STRPREFIX(uuid, AA_PREFIX))
        return -1;

    if (virUUIDParse(uuid + strlen(AA_PREFIX), rawuuid) < 0)
        return -1;

    return 0;
}

static int
valid_name(const char *name)
{
    /* just try to filter out any dangerous characters in the name that can be
     * used to subvert the profile */
448
    const char *bad = "/[]{}?^,\"*";
J
Jamie Strandboge 已提交
449

450
    if (strlen(name) == 0)
J
Jamie Strandboge 已提交
451 452 453 454 455 456 457 458 459 460 461 462
        return -1;

    if (strcspn(name, bad) != strlen(name))
        return -1;

    return 0;
}

/* see if one of the strings in arr starts with str */
static int
array_starts_with(const char *str, const char * const *arr, const long size)
{
463
    size_t i;
J
Jamie Strandboge 已提交
464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511
    for (i = 0; i < size; i++) {
        if (strlen(str) < strlen(arr[i]))
            continue;

        if (STRPREFIX(str, arr[i]))
            return 0;
    }
    return 1;
}

/*
 * Don't allow access to special files or restricted paths such as /bin, /sbin,
 * /usr/bin, /usr/sbin and /etc. This is in an effort to prevent read/write
 * access to system files which could be used to elevate privileges. This is a
 * safety measure in case libvirtd is under a restrictive profile and is
 * subverted and trying to escape confinement.
 *
 * Note that we cannot exclude block devices because they are valid devices.
 * The TEMPLATE file can be adjusted to explicitly disallow these if needed.
 *
 * RETURN: -1 on error, 0 if ok, 1 if blocked
 */
static int
valid_path(const char *path, const bool readonly)
{
    const char * const restricted[] = {
        "/bin/",
        "/etc/",
        "/lib",
        "/lost+found/",
        "/proc/",
        "/sbin/",
        "/selinux/",
        "/sys/",
        "/usr/bin/",
        "/usr/lib",
        "/usr/sbin/",
        "/usr/share/",
        "/usr/local/bin/",
        "/usr/local/etc/",
        "/usr/local/lib",
        "/usr/local/sbin/"
    };
    /* these paths are ok for readonly, but not read/write */
    const char * const restricted_rw[] = {
        "/boot/",
        "/vmlinuz",
        "/initrd",
512
        "/initrd.img",
513
        "/usr/share/OVMF/",              /* for OVMF images */
514 515
        "/usr/share/ovmf/",              /* for OVMF images */
        "/usr/share/AAVMF/",             /* for AAVMF images */
516 517
        "/usr/share/qemu-efi/",          /* for AAVMF images */
        "/usr/share/qemu-efi-aarch64/"   /* for AAVMF images */
J
Jamie Strandboge 已提交
518
    };
519 520
    /* override the above with these */
    const char * const override[] = {
J
John Ferlan 已提交
521
        "/sys/devices/pci",              /* for hostdev pci devices */
522
        "/etc/libvirt-sandbox/services/" /* for virt-sandbox service config */
523
    };
J
Jamie Strandboge 已提交
524

525 526 527 528
    const int nropaths = ARRAY_CARDINALITY(restricted);
    const int nrwpaths = ARRAY_CARDINALITY(restricted_rw);
    const int nopaths = ARRAY_CARDINALITY(override);

529
    if (path == NULL) {
530
        vah_error(NULL, 0, _("bad pathname"));
J
Jamie Strandboge 已提交
531 532 533 534 535 536 537 538 539
        return -1;
    }

    /* Don't allow double quotes, since we use them to quote the filename
     * and this will confuse the apparmor parser.
     */
    if (strchr(path, '"') != NULL)
        return 1;

J
Jamie Strandboge 已提交
540 541 542 543
    /* Require an absolute path */
    if (STRNEQLEN(path, "/", 1))
        return 1;

544
    if (!virFileExists(path))
545
        vah_warning(_("path does not exist, skipping file type checks"));
J
Jamie Strandboge 已提交
546

547
    /* overrides are always allowed */
548
    if (array_starts_with(path, override, nopaths) == 0)
549
        return 0;
J
Jamie Strandboge 已提交
550

551 552
    /* allow read only paths upfront */
    if (readonly) {
553
        if (array_starts_with(path, restricted_rw, nrwpaths) == 0)
554
            return 0;
J
Jamie Strandboge 已提交
555 556
    }

557
    /* disallow RW acess to all paths in restricted and restriced_rw */
558 559
    if ((array_starts_with(path, restricted, nropaths) == 0 ||
         array_starts_with(path, restricted_rw, nrwpaths) == 0))
560 561
        return 1;

J
Jamie Strandboge 已提交
562 563 564
    return 0;
}

565 566 567 568 569 570 571
static int
verify_xpath_context(xmlXPathContextPtr ctxt)
{
    int rc = -1;
    char *tmp = NULL;

    if (!ctxt) {
572
        vah_warning(_("Invalid context"));
573 574 575 576 577
        goto error;
    }

    /* check if have <name> */
    if (!(tmp = virXPathString("string(./name[1])", ctxt))) {
578
        vah_warning(_("Could not find <name>"));
579 580 581 582 583 584
        goto error;
    }
    VIR_FREE(tmp);

    /* check if have <uuid> */
    if (!(tmp = virXPathString("string(./uuid[1])", ctxt))) {
585
        vah_warning(_("Could not find <uuid>"));
586 587 588 589 590 591
        goto error;
    }
    VIR_FREE(tmp);

    rc = 0;

592
 error:
593 594 595
    return rc;
}

596 597
/*
 * Parse the xml we received to fill in the following:
598
 * ctl->virtType
599
 * ctl->os
600 601 602 603 604 605 606 607 608 609
 * ctl->arch
 *
 * These are suitable for setting up a virCapsPtr
 */
static int
caps_mockup(vahControl * ctl, const char *xmlStr)
{
    int rc = -1;
    xmlDocPtr xml = NULL;
    xmlXPathContextPtr ctxt = NULL;
610
    char *arch;
611

612
    if (!(xml = virXMLParseStringCtxt(xmlStr, _("(domain_definition)"),
613
                                      &ctxt))) {
614 615 616
        goto cleanup;
    }

617
    if (!virXMLNodeNameEqual(ctxt->node, "domain")) {
618
        vah_error(NULL, 0, _("unexpected root element, expecting <domain>"));
619 620 621
        goto cleanup;
    }

622 623 624 625
    /* Quick sanity check for some required elements */
    if (verify_xpath_context(ctxt) != 0)
        goto cleanup;

626 627 628 629 630
    ctl->virtType = virXPathString("string(./@type)", ctxt);
    if (!ctl->virtType) {
        vah_error(ctl, 0, _("domain type is not defined"));
        goto cleanup;
    }
631 632
    ctl->os = virXPathString("string(./os/type[1])", ctxt);
    if (!ctl->os) {
633
        vah_error(ctl, 0, _("os.type is not defined"));
634 635
        goto cleanup;
    }
636 637 638 639 640 641
    arch = virXPathString("string(./os/type[1]/@arch)", ctxt);
    if (!arch) {
        ctl->arch = virArchFromHost();
    } else {
        ctl->arch = virArchFromString(arch);
        VIR_FREE(arch);
642 643 644 645
    }

    rc = 0;

646
 cleanup:
647
    xmlFreeDoc(xml);
648 649 650 651 652
    xmlXPathFreeContext(ctxt);

    return rc;
}

653 654 655 656 657
virDomainDefParserConfig virAAHelperDomainDefParserConfig = {
    .features = VIR_DOMAIN_DEF_FEATURE_MEMORY_HOTPLUG |
                VIR_DOMAIN_DEF_FEATURE_OFFLINE_VCPUPIN |
                VIR_DOMAIN_DEF_FEATURE_INDIVIDUAL_VCPUS,
};
658

J
Jamie Strandboge 已提交
659 660 661
static int
get_definition(vahControl * ctl, const char *xmlStr)
{
662
    int rc = -1, ostype, virtType;
J
Jamie Strandboge 已提交
663 664 665 666 667 668
    virCapsGuestPtr guest;  /* this is freed when caps is freed */

    /*
     * mock up some capabilities. We don't currently use these explicitly,
     * but need them for virDomainDefParseString().
     */
669 670
    if (caps_mockup(ctl, xmlStr) != 0)
        goto exit;
J
Jamie Strandboge 已提交
671

672
    if ((ctl->caps = virCapabilitiesNew(ctl->arch, true, true)) == NULL) {
673
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
674 675 676
        goto exit;
    }

677 678
    if (!(ctl->xmlopt = virDomainXMLOptionNew(&virAAHelperDomainDefParserConfig,
                                              NULL, NULL, NULL, NULL))) {
679 680 681 682
        vah_error(ctl, 0, _("Failed to create XML config object"));
        goto exit;
    }

683
    if ((ostype = virDomainOSTypeFromString(ctl->os)) < 0) {
684 685 686 687
        vah_error(ctl, 0, _("unknown OS type"));
        goto exit;
    }

J
Jamie Strandboge 已提交
688
    if ((guest = virCapabilitiesAddGuest(ctl->caps,
689
                                         ostype,
690
                                         ctl->arch,
J
Jamie Strandboge 已提交
691 692 693 694
                                         NULL,
                                         NULL,
                                         0,
                                         NULL)) == NULL) {
695
        vah_error(ctl, 0, _("could not allocate memory"));
696 697 698 699 700 701 702 703 704 705 706 707 708 709 710
        goto exit;
    }

    if ((virtType = virDomainVirtTypeFromString(ctl->virtType)) < 0) {
        vah_error(ctl, 0, _("unknown virtualization type"));
        goto exit;
    }

    if (virCapabilitiesAddGuestDomain(guest,
                                      virtType,
                                      NULL,
                                      NULL,
                                      0,
                                      NULL) == NULL) {
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
711 712 713
        goto exit;
    }

714
    ctl->def = virDomainDefParseString(xmlStr,
715
                                       ctl->caps, ctl->xmlopt, NULL,
716
                                       VIR_DOMAIN_DEF_PARSE_SKIP_SECLABEL |
717
                                       VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE);
718

J
Jamie Strandboge 已提交
719
    if (ctl->def == NULL) {
720
        vah_error(ctl, 0, _("could not parse XML"));
J
Jamie Strandboge 已提交
721 722 723 724
        goto exit;
    }

    if (!ctl->def->name) {
725
        vah_error(ctl, 0, _("could not find name in XML"));
J
Jamie Strandboge 已提交
726 727 728 729
        goto exit;
    }

    if (valid_name(ctl->def->name) != 0) {
730
        vah_error(ctl, 0, _("bad name"));
J
Jamie Strandboge 已提交
731 732 733 734 735
        goto exit;
    }

    rc = 0;

736
 exit:
J
Jamie Strandboge 已提交
737 738 739
    return rc;
}

740 741 742 743
/**
  * The permissions allowed are apparmor valid permissions and 'R'. 'R' stands for
  * read with no explicit deny rule.
  */
J
Jamie Strandboge 已提交
744
static int
F
Felix Geyer 已提交
745
vah_add_path(virBufferPtr buf, const char *path, const char *perms, bool recursive)
J
Jamie Strandboge 已提交
746 747 748 749
{
    char *tmp = NULL;
    int rc = -1;
    bool readonly = true;
750 751
    bool explicit_deny_rule = true;
    char *sub = NULL;
752
    char *perms_new = NULL;
753 754 755
    char *pathdir = NULL;
    char *pathtmp = NULL;
    char *pathreal = NULL;
J
Jamie Strandboge 已提交
756 757 758 759

    if (path == NULL)
        return rc;

J
Jamie Strandboge 已提交
760 761 762 763 764 765
    /* Skip files without an absolute path. Not having one confuses the
     * apparmor parser and this also ensures things like tcp consoles don't
     * get added to the profile.
     */
    if (STRNEQLEN(path, "/", 1)) {
        vah_warning(path);
766
        vah_warning(_("skipped non-absolute path"));
J
Jamie Strandboge 已提交
767 768 769
        return 0;
    }

770 771 772 773 774 775 776
    /* files might be created by qemu later on and not exist right now.
     * But realpath needs a valid path to work on, therefore:
     * 1. walk the path to find longest valid path
     * 2. get the realpath of that valid path
     * 3. re-combine the realpath with the remaining suffix
     * Note: A totally non existent path is used as-is
     */
777
     if (VIR_STRDUP_QUIET(pathdir, path) < 0)
778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796
         goto cleanup;
     while (!virFileExists(pathdir)) {
         if ((pathtmp = mdir_name(pathdir)) == NULL)
             goto cleanup;
         VIR_FREE(pathdir);
         VIR_STEAL_PTR(pathdir, pathtmp);
     }

    if (strlen(pathdir) == 1) {
        /* nothing of the path does exist yet */
        if (VIR_STRDUP_QUIET(tmp, path) < 0)
            goto cleanup;
    } else {
        if (VIR_STRDUP_QUIET(pathtmp, path+strlen(pathdir)) < 0)
            goto cleanup;
        if ((pathreal = realpath(pathdir, NULL)) == NULL) {
            vah_error(NULL, 0, pathdir);
            vah_error(NULL, 0, _("could not find realpath"));
            goto cleanup;
J
Jamie Strandboge 已提交
797
        }
798 799
        if (virAsprintfQuiet(&tmp, "%s%s", pathreal, pathtmp) < 0)
            goto cleanup;
800
    }
J
Jamie Strandboge 已提交
801

802
    if (VIR_STRDUP_QUIET(perms_new, perms) < 0)
803
        goto cleanup;
804 805

    if (strchr(perms_new, 'w') != NULL) {
J
Jamie Strandboge 已提交
806
        readonly = false;
807 808 809
        explicit_deny_rule = false;
    }

810
    if ((sub = strchr(perms_new, 'R')) != NULL) {
811 812 813 814
        /* Don't write the invalid R permission, replace it with 'r' */
        sub[0] = 'r';
        explicit_deny_rule = false;
    }
J
Jamie Strandboge 已提交
815 816 817 818 819

    rc = valid_path(tmp, readonly);
    if (rc != 0) {
        if (rc > 0) {
            vah_error(NULL, 0, path);
820
            vah_error(NULL, 0, _("skipped restricted file"));
J
Jamie Strandboge 已提交
821
        }
822
        goto cleanup;
J
Jamie Strandboge 已提交
823 824
    }

825 826 827
    if (tmp[strlen(tmp) - 1] == '/')
        tmp[strlen(tmp) - 1] = '\0';

828 829
    virBufferAsprintf(buf, "  \"%s%s\" %s,\n", tmp, recursive ? "/**" : "",
                      perms_new);
830
    if (explicit_deny_rule) {
831
        virBufferAddLit(buf, "  # don't audit writes to readonly files\n");
F
Felix Geyer 已提交
832 833 834 835 836
        virBufferAsprintf(buf, "  deny \"%s%s\" w,\n", tmp, recursive ? "/**" : "");
    }
    if (recursive) {
        /* allow reading (but not creating) the dir */
        virBufferAsprintf(buf, "  \"%s/\" r,\n", tmp);
837
    }
J
Jamie Strandboge 已提交
838

839
 cleanup:
840 841 842
    VIR_FREE(pathdir);
    VIR_FREE(pathtmp);
    VIR_FREE(pathreal);
843
    VIR_FREE(perms_new);
844
    VIR_FREE(tmp);
J
Jamie Strandboge 已提交
845 846 847 848

    return rc;
}

F
Felix Geyer 已提交
849 850 851 852 853 854
static int
vah_add_file(virBufferPtr buf, const char *path, const char *perms)
{
    return vah_add_path(buf, path, perms, false);
}

855 856 857 858 859 860 861 862 863 864 865 866
static int
vah_add_file_chardev(virBufferPtr buf,
                     const char *path,
                     const char *perms,
                     const int type)
{
    char *pipe_in;
    char *pipe_out;
    int rc = -1;

    if (type == VIR_DOMAIN_CHR_TYPE_PIPE) {
        /* add the pipe input */
867
        if (virAsprintfQuiet(&pipe_in, "%s.in", path) == -1) {
868
            vah_error(NULL, 0, _("could not allocate memory"));
869
            goto cleanup;
870 871 872 873 874 875
        }

        if (vah_add_file(buf, pipe_in, perms) != 0)
            goto clean_pipe_in;

        /* add the pipe output */
876
        if (virAsprintfQuiet(&pipe_out, "%s.out", path) == -1) {
877 878 879 880 881 882 883 884 885 886 887 888 889 890 891
            vah_error(NULL, 0, _("could not allocate memory"));
            goto clean_pipe_in;
        }

        if (vah_add_file(buf, pipe_out, perms) != 0)
            goto clean_pipe_out;

        rc = 0;
      clean_pipe_out:
        VIR_FREE(pipe_out);
      clean_pipe_in:
        VIR_FREE(pipe_in);
    } else {
        /* add the file */
        if (vah_add_file(buf, path, perms) != 0)
892
            goto cleanup;
893 894 895
        rc = 0;
    }

896
 cleanup:
897 898 899
    return rc;
}

J
Jamie Strandboge 已提交
900
static int
901
file_iterate_hostdev_cb(virUSBDevicePtr dev ATTRIBUTE_UNUSED,
902 903 904 905 906 907 908
                        const char *file, void *opaque)
{
    virBufferPtr buf = opaque;
    return vah_add_file(buf, file, "rw");
}

static int
909 910
file_iterate_pci_cb(virPCIDevicePtr dev ATTRIBUTE_UNUSED,
                    const char *file, void *opaque)
J
Jamie Strandboge 已提交
911 912 913 914 915
{
    virBufferPtr buf = opaque;
    return vah_add_file(buf, file, "rw");
}

916 917 918 919 920 921 922 923 924 925
static int
add_file_path(virDomainDiskDefPtr disk,
              const char *path,
              size_t depth,
              void *opaque)
{
    virBufferPtr buf = opaque;
    int ret;

    if (depth == 0) {
926
        if (disk->src->readonly)
927
            ret = vah_add_file(buf, path, "rk");
928
        else
929
            ret = vah_add_file(buf, path, "rwk");
930
    } else {
931
        ret = vah_add_file(buf, path, "rk");
932 933
    }

934 935 936
    if (ret != 0)
        ret = -1;

937 938 939
    return ret;
}

J
Jamie Strandboge 已提交
940 941 942 943 944
static int
get_files(vahControl * ctl)
{
    virBuffer buf = VIR_BUFFER_INITIALIZER;
    int rc = -1;
945
    size_t i;
J
Jamie Strandboge 已提交
946 947
    char *uuid;
    char uuidstr[VIR_UUID_STRING_BUFLEN];
948
    bool needsVfio = false, needsvhost = false;
J
Jamie Strandboge 已提交
949 950 951

    /* verify uuid is same as what we were given on the command line */
    virUUIDFormat(ctl->def->uuid, uuidstr);
952
    if (virAsprintfQuiet(&uuid, "%s%s", AA_PREFIX, uuidstr) == -1) {
953
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
954 955 956 957
        return rc;
    }

    if (STRNEQ(uuid, ctl->uuid)) {
958
        vah_error(ctl, 0, _("given uuid does not match XML uuid"));
959
        goto cleanup;
J
Jamie Strandboge 已提交
960 961
    }

962 963
    /* load the storage driver so that backing store can be accessed */
#ifdef WITH_STORAGE
964
    virDriverLoadModule("storage", "storageRegister", false);
965
#endif
966

967
    for (i = 0; i < ctl->def->ndisks; i++) {
968 969
        virDomainDiskDefPtr disk = ctl->def->disks[i];

970
        if (!virDomainDiskGetSource(disk))
E
Eric Blake 已提交
971
            continue;
972 973 974
        /* XXX - if we knew the qemu user:group here we could send it in
         *        so that the open could be re-tried as that user:group.
         */
975
        if (!virStorageSourceHasBacking(disk->src))
976
            virStorageFileGetMetadata(disk->src, -1, -1, false);
977

978 979 980
        /* XXX passing ignoreOpenFailure = true to get back to the behavior
         * from before using virDomainDiskDefForeachPath. actually we should
         * be passing ignoreOpenFailure = false and handle open errors more
981 982
         * careful than just ignoring them.
         */
983
        if (virDomainDiskDefForeachPath(disk, true, add_file_path, &buf) < 0)
984
            goto cleanup;
985
    }
J
Jamie Strandboge 已提交
986 987

    for (i = 0; i < ctl->def->nserials; i++)
988
        if (ctl->def->serials[i] &&
989 990 991 992 993 994 995
            (ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->serials[i]->source->data.file.path &&
            ctl->def->serials[i]->source->data.file.path[0] != '\0')
996
            if (vah_add_file_chardev(&buf,
997
                                     ctl->def->serials[i]->source->data.file.path,
998
                                     "rw",
999
                                     ctl->def->serials[i]->source->type) != 0)
1000
                goto cleanup;
J
Jamie Strandboge 已提交
1001

1002 1003
    for (i = 0; i < ctl->def->nconsoles; i++)
        if (ctl->def->consoles[i] &&
1004 1005 1006 1007 1008 1009 1010
            (ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->consoles[i]->source->data.file.path &&
            ctl->def->consoles[i]->source->data.file.path[0] != '\0')
1011
            if (vah_add_file(&buf,
1012
                             ctl->def->consoles[i]->source->data.file.path, "rw") != 0)
1013
                goto cleanup;
J
Jamie Strandboge 已提交
1014

1015
    for (i = 0; i < ctl->def->nparallels; i++)
1016
        if (ctl->def->parallels[i] &&
1017 1018 1019 1020 1021 1022 1023
            (ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->parallels[i]->source->data.file.path &&
            ctl->def->parallels[i]->source->data.file.path[0] != '\0')
1024
            if (vah_add_file_chardev(&buf,
1025
                                     ctl->def->parallels[i]->source->data.file.path,
1026
                                     "rw",
1027
                                     ctl->def->parallels[i]->source->type) != 0)
1028
                goto cleanup;
1029

1030
    for (i = 0; i < ctl->def->nchannels; i++)
1031
        if (ctl->def->channels[i] &&
1032 1033 1034 1035 1036 1037 1038
            (ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->channels[i]->source->data.file.path &&
            ctl->def->channels[i]->source->data.file.path[0] != '\0')
1039
            if (vah_add_file_chardev(&buf,
1040
                                     ctl->def->channels[i]->source->data.file.path,
1041
                                     "rw",
1042
                                     ctl->def->channels[i]->source->type) != 0)
1043
                goto cleanup;
1044

1045
    if (ctl->def->os.kernel)
J
Jamie Strandboge 已提交
1046
        if (vah_add_file(&buf, ctl->def->os.kernel, "r") != 0)
1047
            goto cleanup;
J
Jamie Strandboge 已提交
1048

1049
    if (ctl->def->os.initrd)
J
Jamie Strandboge 已提交
1050
        if (vah_add_file(&buf, ctl->def->os.initrd, "r") != 0)
1051
            goto cleanup;
O
Olivia Yin 已提交
1052 1053 1054

    if (ctl->def->os.dtb)
        if (vah_add_file(&buf, ctl->def->os.dtb, "r") != 0)
1055
            goto cleanup;
J
Jamie Strandboge 已提交
1056

J
Ján Tomko 已提交
1057 1058 1059 1060
    if (ctl->def->os.slic_table)
        if (vah_add_file(&buf, ctl->def->os.slic_table, "r") != 0)
            goto cleanup;

1061
    if (ctl->def->os.loader && ctl->def->os.loader->path)
1062
        if (vah_add_file(&buf, ctl->def->os.loader->path, "rk") != 0)
1063
            goto cleanup;
1064

1065
    if (ctl->def->os.loader && ctl->def->os.loader->nvram)
1066
        if (vah_add_file(&buf, ctl->def->os.loader->nvram, "rwk") != 0)
1067 1068
            goto cleanup;

1069
    for (i = 0; i < ctl->def->ngraphics; i++) {
1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080
        virDomainGraphicsDefPtr graphics = ctl->def->graphics[i];
        size_t n;

        for (n = 0; n < graphics->nListens; n++) {
            virDomainGraphicsListenDef listenObj = graphics->listens[n];

            if (listenObj.type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET &&
                listenObj.socket &&
                vah_add_file(&buf, listenObj.socket, "rw"))
                goto cleanup;
        }
1081 1082
    }

1083 1084 1085 1086
    if (ctl->def->ngraphics == 1 &&
        ctl->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL)
        if (vah_add_file(&buf, ctl->def->graphics[0]->data.sdl.xauth,
                         "r") != 0)
1087
            goto cleanup;
J
Jamie Strandboge 已提交
1088 1089 1090 1091

    for (i = 0; i < ctl->def->nhostdevs; i++)
        if (ctl->def->hostdevs[i]) {
            virDomainHostdevDefPtr dev = ctl->def->hostdevs[i];
1092
            virDomainHostdevSubsysUSBPtr usbsrc = &dev->source.subsys.u.usb;
J
Jamie Strandboge 已提交
1093 1094
            switch (dev->source.subsys.type) {
            case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB: {
1095
                virUSBDevicePtr usb =
1096
                    virUSBDeviceNew(usbsrc->bus, usbsrc->device, NULL);
1097 1098 1099 1100

                if (usb == NULL)
                    continue;

1101 1102 1103
                if (virHostdevFindUSBDevice(dev, true, &usb) < 0)
                    continue;

1104 1105
                rc = virUSBDeviceFileIterate(usb, file_iterate_hostdev_cb, &buf);
                virUSBDeviceFree(usb);
1106
                if (rc != 0)
1107
                    goto cleanup;
J
Jamie Strandboge 已提交
1108 1109
                break;
            }
1110

J
Jamie Strandboge 已提交
1111
            case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI: {
1112
                virPCIDevicePtr pci = virPCIDeviceNew(
1113 1114 1115 1116
                           dev->source.subsys.u.pci.addr.domain,
                           dev->source.subsys.u.pci.addr.bus,
                           dev->source.subsys.u.pci.addr.slot,
                           dev->source.subsys.u.pci.addr.function);
J
Jamie Strandboge 已提交
1117

1118
                virDomainHostdevSubsysPCIBackendType backend = dev->source.subsys.u.pci.backend;
1119 1120 1121 1122 1123
                if (backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO ||
                        backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT) {
                    needsVfio = true;
                }

J
Jamie Strandboge 已提交
1124 1125 1126
                if (pci == NULL)
                    continue;

1127 1128
                rc = virPCIDeviceFileIterate(pci, file_iterate_pci_cb, &buf);
                virPCIDeviceFree(pci);
J
Jamie Strandboge 已提交
1129 1130 1131

                break;
            }
1132

J
Jamie Strandboge 已提交
1133 1134 1135 1136 1137 1138
            default:
                rc = 0;
                break;
            } /* switch */
        }

F
Felix Geyer 已提交
1139 1140 1141 1142 1143
    for (i = 0; i < ctl->def->nfss; i++) {
        if (ctl->def->fss[i] &&
                ctl->def->fss[i]->type == VIR_DOMAIN_FS_TYPE_MOUNT &&
                (ctl->def->fss[i]->fsdriver == VIR_DOMAIN_FS_DRIVER_TYPE_PATH ||
                 ctl->def->fss[i]->fsdriver == VIR_DOMAIN_FS_DRIVER_TYPE_DEFAULT) &&
1144
                ctl->def->fss[i]->src) {
F
Felix Geyer 已提交
1145 1146
            virDomainFSDefPtr fs = ctl->def->fss[i];

1147 1148 1149
            /* We don't need to add deny rw rules for readonly mounts,
             * this can only lead to troubles when mounting / readonly.
             */
1150
            if (vah_add_path(&buf, fs->src->path, fs->readonly ? "R" : "rw", true) != 0)
F
Felix Geyer 已提交
1151 1152 1153 1154
                goto cleanup;
        }
    }

1155 1156 1157 1158 1159 1160 1161 1162
    for (i = 0; i < ctl->def->ninputs; i++) {
        if (ctl->def->inputs[i] &&
                ctl->def->inputs[i]->type == VIR_DOMAIN_INPUT_TYPE_PASSTHROUGH) {
            if (vah_add_file(&buf, ctl->def->inputs[i]->source.evdev, "rw") != 0)
                goto cleanup;
        }
    }

1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174
    for (i = 0; i < ctl->def->nnets; i++) {
        if (ctl->def->nets[i] &&
                ctl->def->nets[i]->type == VIR_DOMAIN_NET_TYPE_VHOSTUSER &&
                ctl->def->nets[i]->data.vhostuser) {
            virDomainChrSourceDefPtr vhu = ctl->def->nets[i]->data.vhostuser;

            if (vah_add_file_chardev(&buf, vhu->data.nix.path, "rw",
                       vhu->type) != 0)
                goto cleanup;
        }
    }

1175 1176 1177 1178 1179 1180 1181 1182
    for (i = 0; i < ctl->def->nmems; i++) {
        if (ctl->def->mems[i] &&
                ctl->def->mems[i]->model == VIR_DOMAIN_MEMORY_MODEL_NVDIMM) {
            if (vah_add_file(&buf, ctl->def->mems[i]->nvdimmPath, "rw") != 0)
                goto cleanup;
        }
    }

1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227
    if (ctl->def->tpm) {
        char *shortName = NULL;
        const char *tpmpath = NULL;

        switch (ctl->def->tpm->type) {
        case VIR_DOMAIN_TPM_TYPE_EMULATOR:
            shortName = virDomainDefGetShortName(ctl->def);

            switch (ctl->def->tpm->version) {
            case VIR_DOMAIN_TPM_VERSION_1_2:
                tpmpath = "tpm1.2";
                break;
            case VIR_DOMAIN_TPM_VERSION_2_0:
                tpmpath = "tpm2";
                break;
            case VIR_DOMAIN_TPM_VERSION_DEFAULT:
            case VIR_DOMAIN_TPM_VERSION_LAST:
                break;
            }

            /* Unix socket for QEMU and swtpm to use */
            virBufferAsprintf(&buf,
                "  \"/run/libvirt/qemu/swtpm/%s-swtpm.sock\" rw,\n",
                shortName);
            /* Paths for swtpm to use: give it access to its state
             * directory, log, and PID files.
             */
            virBufferAsprintf(&buf,
                "  \"%s/lib/libvirt/swtpm/%s/%s/**\" rw,\n",
                LOCALSTATEDIR, uuidstr, tpmpath);
            virBufferAsprintf(&buf,
                "  \"%s/log/swtpm/libvirt/qemu/%s-swtpm.log\" a,\n",
                LOCALSTATEDIR, ctl->def->name);
            virBufferAsprintf(&buf,
                "  \"/run/libvirt/qemu/swtpm/%s-swtpm.pid\" rw,\n",
                shortName);

            VIR_FREE(shortName);
            break;
        case VIR_DOMAIN_TPM_TYPE_PASSTHROUGH:
        case VIR_DOMAIN_TPM_TYPE_LAST:
            break;
        }
    }

1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240
    if (ctl->def->virtType == VIR_DOMAIN_VIRT_KVM) {
        for (i = 0; i < ctl->def->nnets; i++) {
            virDomainNetDefPtr net = ctl->def->nets[i];
            if (net && net->model) {
                if (net->driver.virtio.name == VIR_DOMAIN_NET_BACKEND_TYPE_QEMU)
                    continue;
                if (STRNEQ(net->model, "virtio"))
                    continue;
            }
            needsvhost = true;
        }
    }
    if (needsvhost)
1241
        virBufferAddLit(&buf, "  \"/dev/vhost-net\" rw,\n");
1242

1243
    if (needsVfio) {
1244 1245
        virBufferAddLit(&buf, "  \"/dev/vfio/vfio\" rw,\n");
        virBufferAddLit(&buf, "  \"/dev/vfio/[0-9]*\" rw,\n");
1246 1247
    }

1248
    if (ctl->newfile)
1249
        if (vah_add_file(&buf, ctl->newfile, "rwk") != 0)
1250
            goto cleanup;
J
Jamie Strandboge 已提交
1251 1252

    if (virBufferError(&buf)) {
1253
        virBufferFreeAndReset(&buf);
1254
        vah_error(NULL, 0, _("failed to allocate file buffer"));
1255
        goto cleanup;
J
Jamie Strandboge 已提交
1256 1257 1258 1259 1260
    }

    rc = 0;
    ctl->files = virBufferContentAndReset(&buf);

1261
 cleanup:
J
Jamie Strandboge 已提交
1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275
    VIR_FREE(uuid);
    return rc;
}

static int
vahParseArgv(vahControl * ctl, int argc, char **argv)
{
    int arg, idx = 0;
    struct option opt[] = {
        {"add", 0, 0, 'a'},
        {"create", 0, 0, 'c'},
        {"dryrun", 0, 0, 'd'},
        {"delete", 0, 0, 'D'},
        {"add-file", 0, 0, 'f'},
1276
        {"append-file", 0, 0, 'F'},
J
Jamie Strandboge 已提交
1277 1278 1279 1280 1281 1282 1283
        {"help", 0, 0, 'h'},
        {"replace", 0, 0, 'r'},
        {"remove", 0, 0, 'R'},
        {"uuid", 1, 0, 'u'},
        {0, 0, 0, 0}
    };

1284
    while ((arg = getopt_long(argc, argv, "acdDhrRH:b:u:p:f:F:", opt,
J
Jamie Strandboge 已提交
1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299
            &idx)) != -1) {
        switch (arg) {
            case 'a':
                ctl->cmd = 'a';
                break;
            case 'c':
                ctl->cmd = 'c';
                break;
            case 'd':
                ctl->dryrun = true;
                break;
            case 'D':
                ctl->cmd = 'D';
                break;
            case 'f':
1300
            case 'F':
1301
                if (VIR_STRDUP_QUIET(ctl->newfile, optarg) < 0)
1302
                    vah_error(ctl, 1, _("could not allocate memory for disk"));
1303
                ctl->append = arg == 'F';
J
Jamie Strandboge 已提交
1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316
                break;
            case 'h':
                vah_usage();
                exit(EXIT_SUCCESS);
                break;
            case 'r':
                ctl->cmd = 'r';
                break;
            case 'R':
                ctl->cmd = 'R';
                break;
            case 'u':
                if (strlen(optarg) > PROFILE_NAME_SIZE - 1)
1317
                    vah_error(ctl, 1, _("invalid UUID"));
1318
                if (virStrcpy((char *)ctl->uuid, optarg,
1319
                    PROFILE_NAME_SIZE) < 0)
1320
                    vah_error(ctl, 1, _("error copying UUID"));
J
Jamie Strandboge 已提交
1321 1322
                break;
            default:
1323
                vah_error(ctl, 1, _("unsupported option"));
J
Jamie Strandboge 已提交
1324 1325 1326 1327
                break;
        }
    }
    if (strchr("acDrR", ctl->cmd) == NULL)
1328
        vah_error(ctl, 1, _("bad command"));
J
Jamie Strandboge 已提交
1329 1330

    if (valid_uuid(ctl->uuid) != 0)
1331
        vah_error(ctl, 1, _("invalid UUID"));
J
Jamie Strandboge 已提交
1332 1333 1334 1335 1336 1337 1338 1339 1340

    if (!ctl->cmd) {
        vah_usage();
        exit(EXIT_FAILURE);
    }

    if (ctl->cmd == 'c' || ctl->cmd == 'r') {
        char *xmlStr = NULL;
        if (virFileReadLimFD(STDIN_FILENO, MAX_FILE_LEN, &xmlStr) < 0)
1341
            vah_error(ctl, 1, _("could not read xml file"));
J
Jamie Strandboge 已提交
1342 1343 1344

        if (get_definition(ctl, xmlStr) != 0 || ctl->def == NULL) {
            VIR_FREE(xmlStr);
1345
            vah_error(ctl, 1, _("could not get VM definition"));
J
Jamie Strandboge 已提交
1346 1347 1348 1349
        }
        VIR_FREE(xmlStr);

        if (get_files(ctl) != 0)
1350
            vah_error(ctl, 1, _("invalid VM definition"));
J
Jamie Strandboge 已提交
1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368
    }
    return 0;
}


/*
 * virt-aa-helper -c -u UUID < file.xml
 * virt-aa-helper -r -u UUID [-f <file>] < file.xml
 * virt-aa-helper -a -u UUID
 * virt-aa-helper -R -u UUID
 * virt-aa-helper -D -u UUID
 */
int
main(int argc, char **argv)
{
    vahControl _ctl, *ctl = &_ctl;
    virBuffer buf = VIR_BUFFER_INITIALIZER;
    int rc = -1;
1369 1370
    char *profile = NULL;
    char *include_file = NULL;
J
Jamie Strandboge 已提交
1371

1372 1373
    if (virGettextInitialize() < 0 ||
        virThreadInitialize() < 0 ||
1374 1375 1376 1377 1378
        virErrorInitialize() < 0) {
        fprintf(stderr, _("%s: initialization failed\n"), argv[0]);
        exit(EXIT_FAILURE);
    }

1379 1380
    virFileActivateDirOverride(argv[0]);

1381 1382 1383
    /* Initialize the log system */
    virLogSetFromEnv();

J
Jamie Strandboge 已提交
1384 1385
    /* clear the environment */
    environ = NULL;
1386
    if (setenv("PATH", "/sbin:/usr/sbin", 1) != 0)
1387 1388
        vah_error(ctl, 1, _("could not set PATH"));

1389
    /* ensure the traditional IFS setting */
1390
    if (setenv("IFS", " \t\n", 1) != 0)
1391
        vah_error(ctl, 1, _("could not set IFS"));
J
Jamie Strandboge 已提交
1392 1393 1394 1395 1396 1397 1398 1399 1400

    if (!(progname = strrchr(argv[0], '/')))
        progname = argv[0];
    else
        progname++;

    memset(ctl, 0, sizeof(vahControl));

    if (vahParseArgv(ctl, argc, argv) != 0)
1401
        vah_error(ctl, 1, _("could not parse arguments"));
J
Jamie Strandboge 已提交
1402

1403 1404
    if (virAsprintfQuiet(&profile, "%s/%s",
                         APPARMOR_DIR "/libvirt", ctl->uuid) < 0)
1405
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
1406

1407 1408
    if (virAsprintfQuiet(&include_file, "%s/%s.files",
                         APPARMOR_DIR "/libvirt", ctl->uuid) < 0)
1409
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
1410

1411
    if (ctl->cmd == 'a') {
J
Jamie Strandboge 已提交
1412
        rc = parserLoad(ctl->uuid);
1413
    } else if (ctl->cmd == 'R' || ctl->cmd == 'D') {
J
Jamie Strandboge 已提交
1414 1415 1416 1417 1418 1419 1420 1421
        rc = parserRemove(ctl->uuid);
        if (ctl->cmd == 'D') {
            unlink(include_file);
            unlink(profile);
        }
    } else if (ctl->cmd == 'c' || ctl->cmd == 'r') {
        char *included_files = NULL;

1422
        if (ctl->cmd == 'c' && virFileExists(profile))
1423
            vah_error(ctl, 1, _("profile exists"));
J
Jamie Strandboge 已提交
1424

1425
        if (ctl->append && ctl->newfile) {
1426
            if (vah_add_file(&buf, ctl->newfile, "rwk") != 0)
1427
                goto cleanup;
1428
        } else {
1429 1430 1431
            if (ctl->def->virtType == VIR_DOMAIN_VIRT_QEMU ||
                ctl->def->virtType == VIR_DOMAIN_VIRT_KQEMU ||
                ctl->def->virtType == VIR_DOMAIN_VIRT_KVM) {
1432 1433
                virBufferAsprintf(&buf, "  \"%s/log/libvirt/**/%s.log\" w,\n",
                                  LOCALSTATEDIR, ctl->def->name);
1434
                virBufferAsprintf(&buf, "  \"%s/lib/libvirt/qemu/domain-%s/monitor.sock\" rw,\n",
1435
                                  LOCALSTATEDIR, ctl->def->name);
1436 1437
                virBufferAsprintf(&buf, "  \"%s/lib/libvirt/qemu/domain-%d-%.*s/*\" rw,\n",
                                  LOCALSTATEDIR, ctl->def->id, 20, ctl->def->name);
1438 1439 1440 1441 1442 1443 1444 1445 1446
                virBufferAsprintf(&buf, "  \"%s/run/libvirt/**/%s.pid\" rwk,\n",
                                  LOCALSTATEDIR, ctl->def->name);
                virBufferAsprintf(&buf, "  \"/run/libvirt/**/%s.pid\" rwk,\n",
                                  ctl->def->name);
                virBufferAsprintf(&buf, "  \"%s/run/libvirt/**/*.tunnelmigrate.dest.%s\" rw,\n",
                                  LOCALSTATEDIR, ctl->def->name);
                virBufferAsprintf(&buf, "  \"/run/libvirt/**/*.tunnelmigrate.dest.%s\" rw,\n",
                                  ctl->def->name);
            }
1447
            if (ctl->files)
1448
                virBufferAdd(&buf, ctl->files, -1);
1449
        }
J
Jamie Strandboge 已提交
1450

1451 1452
        if (virBufferError(&buf)) {
            virBufferFreeAndReset(&buf);
1453
            vah_error(ctl, 1, _("failed to allocate buffer"));
1454
        }
J
Jamie Strandboge 已提交
1455 1456 1457 1458 1459 1460 1461 1462

        included_files = virBufferContentAndReset(&buf);

        /* (re)create the include file using included_files */
        if (ctl->dryrun) {
            vah_info(include_file);
            vah_info(included_files);
            rc = 0;
1463 1464 1465
        } else if (ctl->def->virtType == VIR_DOMAIN_VIRT_LXC) {
            rc = 0;
        } else if ((rc = update_include_file(include_file,
1466
                                             included_files,
1467
                                             ctl->append)) != 0) {
1468
            goto cleanup;
1469
        }
J
Jamie Strandboge 已提交
1470 1471 1472 1473 1474


        /* create the profile from TEMPLATE */
        if (ctl->cmd == 'c') {
            char *tmp = NULL;
1475 1476
            if (virAsprintfQuiet(&tmp, "  #include <libvirt/%s.files>\n",
                                 ctl->uuid) == -1) {
1477
                vah_error(ctl, 0, _("could not allocate memory"));
1478
                goto cleanup;
J
Jamie Strandboge 已提交
1479 1480 1481 1482 1483 1484 1485
            }

            if (ctl->dryrun) {
                vah_info(profile);
                vah_info(ctl->uuid);
                vah_info(tmp);
                rc = 0;
1486 1487
            } else if ((rc = create_profile(profile, ctl->uuid, tmp,
                                            ctl->def->virtType)) != 0) {
1488
                vah_error(ctl, 0, _("could not create profile"));
J
Jamie Strandboge 已提交
1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506
                unlink(include_file);
            }
            VIR_FREE(tmp);
        }

        if (rc == 0 && !ctl->dryrun) {
            if (ctl->cmd == 'c')
                rc = parserLoad(ctl->uuid);
            else
                rc = parserReplace(ctl->uuid);

            /* cleanup */
            if (rc != 0) {
                unlink(include_file);
                if (ctl->cmd == 'c')
                    unlink(profile);
            }
        }
1507
      cleanup:
J
Jamie Strandboge 已提交
1508 1509 1510 1511
        VIR_FREE(included_files);
    }

    vahDeinit(ctl);
1512 1513 1514 1515

    VIR_FREE(profile);
    VIR_FREE(include_file);

J
Jamie Strandboge 已提交
1516 1517
    exit(rc == 0 ? EXIT_SUCCESS : EXIT_FAILURE);
}