network_conf.c 39.7 KB
Newer Older
1 2 3
/*
 * network_conf.c: network XML handling
 *
E
Eric Blake 已提交
4
 * Copyright (C) 2006-2011 Red Hat, Inc.
5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25
 * Copyright (C) 2006-2008 Daniel P. Berrange
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
 *
 * Author: Daniel P. Berrange <berrange@redhat.com>
 */

#include <config.h>

26
#include <unistd.h>
27 28
#include <arpa/inet.h>
#include <sys/types.h>
A
Atsushi SAKAI 已提交
29
#include <sys/stat.h>
30
#include <fcntl.h>
31
#include <string.h>
32 33
#include <dirent.h>

34
#include "virterror_internal.h"
35
#include "datatypes.h"
36
#include "network_conf.h"
37
#include "network.h"
38 39 40 41 42
#include "memory.h"
#include "xml.h"
#include "uuid.h"
#include "util.h"
#include "buf.h"
43
#include "c-ctype.h"
44
#include "files.h"
45

46
#define MAX_BRIDGE_ID 256
47 48
#define VIR_FROM_THIS VIR_FROM_NETWORK

49 50 51 52 53 54
VIR_ENUM_DECL(virNetworkForward)

VIR_ENUM_IMPL(virNetworkForward,
              VIR_NETWORK_FORWARD_LAST,
              "none", "nat", "route" )

55
#define virNetworkReportError(code, ...)                                \
56
    virReportErrorHelper(VIR_FROM_NETWORK, code, __FILE__,              \
57
                         __FUNCTION__, __LINE__, __VA_ARGS__)
58

59
virNetworkObjPtr virNetworkFindByUUID(const virNetworkObjListPtr nets,
60 61
                                      const unsigned char *uuid)
{
62 63
    unsigned int i;

64 65
    for (i = 0 ; i < nets->count ; i++) {
        virNetworkObjLock(nets->objs[i]);
66 67
        if (!memcmp(nets->objs[i]->def->uuid, uuid, VIR_UUID_BUFLEN))
            return nets->objs[i];
68 69
        virNetworkObjUnlock(nets->objs[i]);
    }
70 71 72 73

    return NULL;
}

74
virNetworkObjPtr virNetworkFindByName(const virNetworkObjListPtr nets,
75 76
                                      const char *name)
{
77 78
    unsigned int i;

79 80
    for (i = 0 ; i < nets->count ; i++) {
        virNetworkObjLock(nets->objs[i]);
81 82
        if (STREQ(nets->objs[i]->def->name, name))
            return nets->objs[i];
83 84
        virNetworkObjUnlock(nets->objs[i]);
    }
85 86 87 88 89

    return NULL;
}


90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106
static void virNetworkIpDefClear(virNetworkIpDefPtr def)
{
    int ii;

    VIR_FREE(def->family);
    VIR_FREE(def->ranges);

    for (ii = 0 ; ii < def->nhosts && def->hosts ; ii++) {
        VIR_FREE(def->hosts[ii].mac);
        VIR_FREE(def->hosts[ii].name);
    }

    VIR_FREE(def->hosts);
    VIR_FREE(def->tftproot);
    VIR_FREE(def->bootfile);
}

107 108 109 110 111 112 113 114 115 116 117 118 119 120
static void virNetworkDNSDefFree(virNetworkDNSDefPtr def)
{
    if (def) {
        if (def->txtrecords) {
            while (def->ntxtrecords--) {
                VIR_FREE(def->txtrecords[def->ntxtrecords].name);
                VIR_FREE(def->txtrecords[def->ntxtrecords].value);
            }
            VIR_FREE(def->txtrecords);
        }
        VIR_FREE(def);
    }
}

121 122
void virNetworkDefFree(virNetworkDefPtr def)
{
123
    int ii;
124 125 126 127 128 129 130

    if (!def)
        return;

    VIR_FREE(def->name);
    VIR_FREE(def->bridge);
    VIR_FREE(def->forwardDev);
131
    VIR_FREE(def->domain);
132

133 134
    for (ii = 0 ; ii < def->nips && def->ips ; ii++) {
        virNetworkIpDefClear(&def->ips[ii]);
135
    }
136
    VIR_FREE(def->ips);
137

138 139
    virNetworkDNSDefFree(def->dns);

140 141 142 143 144 145 146 147 148 149 150
    VIR_FREE(def);
}

void virNetworkObjFree(virNetworkObjPtr net)
{
    if (!net)
        return;

    virNetworkDefFree(net->def);
    virNetworkDefFree(net->newDef);

151 152
    virMutexDestroy(&net->lock);

153 154 155
    VIR_FREE(net);
}

156 157 158 159 160 161 162 163 164 165 166
void virNetworkObjListFree(virNetworkObjListPtr nets)
{
    unsigned int i;

    for (i = 0 ; i < nets->count ; i++)
        virNetworkObjFree(nets->objs[i]);

    VIR_FREE(nets->objs);
    nets->count = 0;
}

167
virNetworkObjPtr virNetworkAssignDef(virNetworkObjListPtr nets,
168 169 170 171
                                     const virNetworkDefPtr def)
{
    virNetworkObjPtr network;

172
    if ((network = virNetworkFindByName(nets, def->name))) {
D
Daniel P. Berrange 已提交
173
        if (!virNetworkObjIsActive(network)) {
174 175 176
            virNetworkDefFree(network->def);
            network->def = def;
        } else {
177
            virNetworkDefFree(network->newDef);
178 179 180 181 182 183 184
            network->newDef = def;
        }

        return network;
    }

    if (VIR_ALLOC(network) < 0) {
185
        virReportOOMError();
186 187
        return NULL;
    }
188
    if (virMutexInit(&network->lock) < 0) {
189
        virNetworkReportError(VIR_ERR_INTERNAL_ERROR,
190 191 192 193
                              "%s", _("cannot initialize mutex"));
        VIR_FREE(network);
        return NULL;
    }
194
    virNetworkObjLock(network);
195 196
    network->def = def;

197
    if (VIR_REALLOC_N(nets->objs, nets->count + 1) < 0) {
198
        virReportOOMError();
199 200 201 202 203 204
        VIR_FREE(network);
        return NULL;
    }

    nets->objs[nets->count] = network;
    nets->count++;
205 206 207 208 209

    return network;

}

210
void virNetworkRemoveInactive(virNetworkObjListPtr nets,
211 212
                              const virNetworkObjPtr net)
{
213
    unsigned int i;
214

215
    virNetworkObjUnlock(net);
216
    for (i = 0 ; i < nets->count ; i++) {
217
        virNetworkObjLock(nets->objs[i]);
218
        if (nets->objs[i] == net) {
219
            virNetworkObjUnlock(nets->objs[i]);
220
            virNetworkObjFree(nets->objs[i]);
221

222 223 224
            if (i < (nets->count - 1))
                memmove(nets->objs + i, nets->objs + i + 1,
                        sizeof(*(nets->objs)) * (nets->count - (i + 1)));
225

226 227 228 229 230 231 232
            if (VIR_REALLOC_N(nets->objs, nets->count - 1) < 0) {
                ; /* Failure to reduce memory allocation isn't fatal */
            }
            nets->count--;

            break;
        }
233
        virNetworkObjUnlock(nets->objs[i]);
234
    }
235 236
}

237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261
/* return ips[index], or NULL if there aren't enough ips */
virNetworkIpDefPtr
virNetworkDefGetIpByIndex(const virNetworkDefPtr def,
                          int family, size_t n)
{
    int ii;

    if (!def->ips || n >= def->nips)
        return NULL;

    if (family == AF_UNSPEC) {
        return &def->ips[n];
    }

    /* find the nth ip of type "family" */
    for (ii = 0; ii < def->nips; ii++) {
        if (VIR_SOCKET_IS_FAMILY(&def->ips[ii].address, family)
            && (n-- <= 0)) {
            return &def->ips[ii];
        }
    }
    /* failed to find enough of the right family */
    return NULL;
}

L
Laine Stump 已提交
262 263 264
/* return number of 1 bits in netmask for the network's ipAddress,
 * or -1 on error
 */
265
int virNetworkIpDefPrefix(const virNetworkIpDefPtr def)
L
Laine Stump 已提交
266
{
267 268 269
    if (def->prefix > 0) {
        return def->prefix;
    } else if (VIR_SOCKET_HAS_ADDR(&def->netmask)) {
L
Laine Stump 已提交
270
        return virSocketGetNumNetmaskBits(&def->netmask);
271
    } else if (VIR_SOCKET_IS_FAMILY(&def->address, AF_INET)) {
L
Laine Stump 已提交
272 273 274 275 276 277
        /* Return the natural prefix for the network's ip address.
         * On Linux we could use the IN_CLASSx() macros, but those
         * aren't guaranteed on all platforms, so we just deal with
         * the bits ourselves.
         */
        unsigned char octet
278
            = ntohl(def->address.data.inet4.sin_addr.s_addr) >> 24;
L
Laine Stump 已提交
279 280 281 282 283 284 285 286 287 288 289
        if ((octet & 0x80) == 0) {
            /* Class A network */
            return 8;
        } else if ((octet & 0xC0) == 0x80) {
            /* Class B network */
            return 16;
        } else if ((octet & 0xE0) == 0xC0) {
            /* Class C network */
            return 24;
        }
        return -1;
290 291
    } else if (VIR_SOCKET_IS_FAMILY(&def->address, AF_INET6)) {
        return 64;
L
Laine Stump 已提交
292 293 294 295 296 297 298 299
    }
    return -1;
}

/* Fill in a virSocketAddr with the proper netmask for this
 * definition, based on either the definition's netmask, or its
 * prefix. Return -1 on error (and set the netmask family to AF_UNSPEC)
 */
300 301
int virNetworkIpDefNetmask(const virNetworkIpDefPtr def,
                           virSocketAddrPtr netmask)
L
Laine Stump 已提交
302 303 304 305 306 307
{
    if (VIR_SOCKET_IS_FAMILY(&def->netmask, AF_INET)) {
        *netmask = def->netmask;
        return 0;
    }

308 309
    return virSocketAddrPrefixToNetmask(virNetworkIpDefPrefix(def), netmask,
                                        VIR_SOCKET_FAMILY(&def->address));
L
Laine Stump 已提交
310 311
}

312 313

static int
314 315
virNetworkDHCPRangeDefParseXML(const char *networkName,
                               virNetworkIpDefPtr def,
316 317
                               xmlNodePtr node)
{
318 319 320 321 322

    xmlNodePtr cur;

    cur = node->children;
    while (cur != NULL) {
323 324
        if (cur->type == XML_ELEMENT_NODE &&
            xmlStrEqual(cur->name, BAD_CAST "range")) {
325 326 327
            char *start, *end;
            virSocketAddr saddr, eaddr;
            int range;
328

329
            if (!(start = virXMLPropString(cur, "start"))) {
330 331 332
                cur = cur->next;
                continue;
            }
333 334
            if (!(end = virXMLPropString(cur, "end"))) {
                VIR_FREE(start);
335
                cur = cur->next;
336 337 338
                continue;
            }

339
            if (virSocketParseAddr(start, &saddr, AF_UNSPEC) < 0) {
340 341
                VIR_FREE(start);
                VIR_FREE(end);
342
                return -1;
343
            }
344
            if (virSocketParseAddr(end, &eaddr, AF_UNSPEC) < 0) {
345 346
                VIR_FREE(start);
                VIR_FREE(end);
347
                return -1;
348 349 350 351
            }

            range = virSocketGetRange(&saddr, &eaddr);
            if (range < 0) {
352
                virNetworkReportError(VIR_ERR_XML_ERROR,
353 354
                                      _("Invalid dhcp range '%s' to '%s' in network '%s'"),
                                      start, end, networkName);
355 356
                VIR_FREE(start);
                VIR_FREE(end);
357
                return -1;
358
            }
E
Eric Blake 已提交
359 360
            VIR_FREE(start);
            VIR_FREE(end);
361

362
            if (VIR_REALLOC_N(def->ranges, def->nranges + 1) < 0) {
363
                virReportOOMError();
364 365
                return -1;
            }
366 367
            def->ranges[def->nranges].start = saddr;
            def->ranges[def->nranges].end = eaddr;
368 369 370
            def->nranges++;
        } else if (cur->type == XML_ELEMENT_NODE &&
            xmlStrEqual(cur->name, BAD_CAST "host")) {
371
            char *mac, *name, *ip;
372
            unsigned char addr[6];
373
            virSocketAddr inaddr;
374

375
            mac = virXMLPropString(cur, "mac");
376
            if ((mac != NULL) &&
377
                (virParseMacAddr(mac, &addr[0]) != 0)) {
378
                virNetworkReportError(VIR_ERR_INTERNAL_ERROR,
379 380
                                      _("Cannot parse MAC address '%s' in network '%s'"),
                                      mac, networkName);
381 382
                VIR_FREE(mac);
            }
383
            name = virXMLPropString(cur, "name");
384
            if ((name != NULL) && (!c_isalpha(name[0]))) {
385
                virNetworkReportError(VIR_ERR_INTERNAL_ERROR,
386 387
                                      _("Cannot use name address '%s' in network '%s'"),
                                      name, networkName);
388 389 390 391 392 393
                VIR_FREE(name);
            }
            /*
             * You need at least one MAC address or one host name
             */
            if ((mac == NULL) && (name == NULL)) {
394 395 396 397
                virNetworkReportError(VIR_ERR_XML_ERROR,
                                      _("Static host definition in network '%s' must have mac or name attribute"),
                                      networkName);
                return -1;
398
            }
399
            ip = virXMLPropString(cur, "ip");
400 401 402 403 404
            if ((ip == NULL) ||
                (virSocketParseAddr(ip, &inaddr, AF_UNSPEC) < 0)) {
                virNetworkReportError(VIR_ERR_XML_ERROR,
                                      _("Missing IP address in static host definition for network '%s'"),
                                      networkName);
405 406 407
                VIR_FREE(ip);
                VIR_FREE(mac);
                VIR_FREE(name);
408
                return -1;
409
            }
E
Eric Blake 已提交
410
            VIR_FREE(ip);
411 412 413
            if (VIR_REALLOC_N(def->hosts, def->nhosts + 1) < 0) {
                VIR_FREE(mac);
                VIR_FREE(name);
414
                virReportOOMError();
415 416
                return -1;
            }
417 418
            def->hosts[def->nhosts].mac = mac;
            def->hosts[def->nhosts].name = name;
419
            def->hosts[def->nhosts].ip = inaddr;
420
            def->nhosts++;
421 422 423

        } else if (cur->type == XML_ELEMENT_NODE &&
            xmlStrEqual(cur->name, BAD_CAST "bootp")) {
424 425
            char *file;
            char *server;
426
            virSocketAddr inaddr;
427
            memset(&inaddr, 0, sizeof(inaddr));
428

429
            if (!(file = virXMLPropString(cur, "file"))) {
430 431 432
                cur = cur->next;
                continue;
            }
433
            server = virXMLPropString(cur, "server");
434

435
            if (server &&
E
Eric Blake 已提交
436 437 438
                virSocketParseAddr(server, &inaddr, AF_UNSPEC) < 0) {
                VIR_FREE(file);
                VIR_FREE(server);
439
                return -1;
E
Eric Blake 已提交
440
            }
441

442
            def->bootfile = file;
443
            def->bootserver = inaddr;
E
Eric Blake 已提交
444
            VIR_FREE(server);
445 446 447 448 449 450 451 452
        }

        cur = cur->next;
    }

    return 0;
}

453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515
static int
virNetworkDNSDefParseXML(virNetworkDNSDefPtr *dnsdef,
                         xmlNodePtr node)
{
    xmlNodePtr cur;
    int ret = -1;
    char *name = NULL;
    char *value = NULL;
    virNetworkDNSDefPtr def = NULL;

    if (VIR_ALLOC(def) < 0) {
        virReportOOMError();
        goto error;
    }

    cur = node->children;
    while (cur != NULL) {
        if (cur->type == XML_ELEMENT_NODE &&
            xmlStrEqual(cur->name, BAD_CAST "txt")) {
            if (!(name = virXMLPropString(cur, "name"))) {
                virNetworkReportError(VIR_ERR_XML_DETAIL,
                                      "%s", _("Missing required name attribute in dns txt record"));
                goto error;
            }
            if (!(value = virXMLPropString(cur, "value"))) {
                virNetworkReportError(VIR_ERR_XML_DETAIL,
                                      _("Missing required value attribute in dns txt record '%s'"), name);
                goto error;
            }

            if (strchr(name, ' ') != NULL) {
                virNetworkReportError(VIR_ERR_XML_DETAIL,
                                      _("spaces are not allowed in DNS TXT record names (name is '%s')"), name);
                goto error;
            }

            if (VIR_REALLOC_N(def->txtrecords, def->ntxtrecords + 1) < 0) {
                virReportOOMError();
                goto error;
            }

            def->txtrecords[def->ntxtrecords].name = name;
            def->txtrecords[def->ntxtrecords].value = value;
            def->ntxtrecords++;
            name = NULL;
            value = NULL;
        }

        cur = cur->next;
    }

    ret = 0;
error:
    if (ret < 0) {
        VIR_FREE(name);
        VIR_FREE(value);
        virNetworkDNSDefFree(def);
    } else {
        *dnsdef = def;
    }
    return ret;
}

516
static int
517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551
virNetworkIPParseXML(const char *networkName,
                     virNetworkIpDefPtr def,
                     xmlNodePtr node,
                     xmlXPathContextPtr ctxt)
{
    /*
     * virNetworkIpDef object is already allocated as part of an array.
     * On failure clear it out, but don't free it.
     */

    xmlNodePtr cur, save;
    char *address = NULL, *netmask = NULL;
    unsigned long prefix;
    int result = -1;

    save = ctxt->node;
    ctxt->node = node;

    /* grab raw data from XML */
    def->family = virXPathString("string(./@family)", ctxt);
    address = virXPathString("string(./@address)", ctxt);
    if (virXPathULong("string(./@prefix)", ctxt, &prefix) < 0)
        def->prefix = 0;
    else
        def->prefix = prefix;

    netmask = virXPathString("string(./@netmask)", ctxt);

    if (address) {
        if (virSocketParseAddr(address, &def->address, AF_UNSPEC) < 0) {
            virNetworkReportError(VIR_ERR_XML_ERROR,
                                  _("Bad address '%s' in definition of network '%s'"),
                                  address, networkName);
            goto error;
        }
552

553
    }
554

555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583
    /* validate family vs. address */
    if (def->family == NULL) {
        if (!(VIR_SOCKET_IS_FAMILY(&def->address, AF_INET) ||
              VIR_SOCKET_IS_FAMILY(&def->address, AF_UNSPEC))) {
            virNetworkReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                                  _("no family specified for non-IPv4 address address '%s' in network '%s'"),
                                  address, networkName);
            goto error;
        }
    } else if (STREQ(def->family, "ipv4")) {
        if (!VIR_SOCKET_IS_FAMILY(&def->address, AF_INET)) {
            virNetworkReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                                  _("family 'ipv4' specified for non-IPv4 address '%s' in network '%s'"),
                                  address, networkName);
            goto error;
        }
    } else if (STREQ(def->family, "ipv6")) {
        if (!VIR_SOCKET_IS_FAMILY(&def->address, AF_INET6)) {
            virNetworkReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                                  _("family 'ipv6' specified for non-IPv6 address '%s' in network '%s'"),
                                  address, networkName);
            goto error;
        }
    } else {
        virNetworkReportError(VIR_ERR_XML_ERROR,
                              _("Unrecognized family '%s' in definition of network '%s'"),
                              def->family, networkName);
        goto error;
    }
584

585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626
    /* parse/validate netmask */
    if (netmask) {
        if (address == NULL) {
            /* netmask is meaningless without an address */
            virNetworkReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                                  _("netmask specified without address in network '%s'"),
                                  networkName);
            goto error;
        }

        if (!VIR_SOCKET_IS_FAMILY(&def->address, AF_INET)) {
            virNetworkReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                                  _("netmask not supported for address '%s' in network '%s' (IPv4 only)"),
                                  address, networkName);
            goto error;
        }

        if (def->prefix > 0) {
            /* can't have both netmask and prefix at the same time */
            virNetworkReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                                  _("network '%s' cannot have both prefix='%u' and a netmask"),
                                  networkName, def->prefix);
            goto error;
        }

        if (virSocketParseAddr(netmask, &def->netmask, AF_UNSPEC) < 0)
            goto error;

        if (!VIR_SOCKET_IS_FAMILY(&def->netmask, AF_INET)) {
            virNetworkReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                                  _("network '%s' has invalid netmask '%s' for address '%s' (both must be IPv4)"),
                                  networkName, netmask, address);
            goto error;
        }
    }

    if (VIR_SOCKET_IS_FAMILY(&def->address, AF_INET)) {
        /* parse IPv4-related info */
        cur = node->children;
        while (cur != NULL) {
            if (cur->type == XML_ELEMENT_NODE &&
                xmlStrEqual(cur->name, BAD_CAST "dhcp")) {
627
                result = virNetworkDHCPRangeDefParseXML(networkName, def, cur);
628 629 630 631 632 633 634 635 636 637 638 639 640
                if (result)
                    goto error;

            } else if (cur->type == XML_ELEMENT_NODE &&
                       xmlStrEqual(cur->name, BAD_CAST "tftp")) {
                char *root;

                if (!(root = virXMLPropString(cur, "root"))) {
                    cur = cur->next;
                    continue;
                }

                def->tftproot = (char *)root;
641 642
            }

643
            cur = cur->next;
644
        }
645
    }
646

647 648 649 650 651
    result = 0;

error:
    if (result < 0) {
        virNetworkIpDefClear(def);
652
    }
653 654 655 656 657
    VIR_FREE(address);
    VIR_FREE(netmask);

    ctxt->node = save;
    return result;
658 659
}

660
static virNetworkDefPtr
661
virNetworkDefParseXML(xmlXPathContextPtr ctxt)
662 663 664
{
    virNetworkDefPtr def;
    char *tmp;
665
    xmlNodePtr *ipNodes = NULL;
666
    xmlNodePtr dnsNode = NULL;
667
    int nIps;
668 669

    if (VIR_ALLOC(def) < 0) {
670
        virReportOOMError();
671 672 673 674
        return NULL;
    }

    /* Extract network name */
675
    def->name = virXPathString("string(./name[1])", ctxt);
676
    if (!def->name) {
677
        virNetworkReportError(VIR_ERR_NO_NAME, NULL);
678 679 680 681
        goto error;
    }

    /* Extract network uuid */
682
    tmp = virXPathString("string(./uuid[1])", ctxt);
683
    if (!tmp) {
684
        if (virUUIDGenerate(def->uuid)) {
685
            virNetworkReportError(VIR_ERR_INTERNAL_ERROR,
686
                                  "%s", _("Failed to generate UUID"));
687 688 689 690 691
            goto error;
        }
    } else {
        if (virUUIDParse(tmp, def->uuid) < 0) {
            VIR_FREE(tmp);
692
            virNetworkReportError(VIR_ERR_INTERNAL_ERROR,
693 694 695 696 697 698
                                  "%s", _("malformed uuid element"));
            goto error;
        }
        VIR_FREE(tmp);
    }

699
    /* Parse network domain information */
700
    def->domain = virXPathString("string(./domain[1]/@name)", ctxt);
701

702
    /* Parse bridge information */
703 704
    def->bridge = virXPathString("string(./bridge[1]/@name)", ctxt);
    tmp = virXPathString("string(./bridge[1]/@stp)", ctxt);
705 706 707
    def->stp = (tmp && STREQ(tmp, "off")) ? 0 : 1;
    VIR_FREE(tmp);

708
    if (virXPathULong("string(./bridge[1]/@delay)", ctxt, &def->delay) < 0)
709 710
        def->delay = 0;

711 712 713 714 715 716 717 718 719 720 721 722 723
    tmp = virXPathString("string(./mac[1]/@address)", ctxt);
    if (tmp) {
        if (virParseMacAddr(tmp, def->mac) < 0) {
            virNetworkReportError(VIR_ERR_XML_ERROR,
                                  _("Invalid bridge mac address '%s' in network '%s'"),
                                  tmp, def->name);
            VIR_FREE(tmp);
            goto error;
        }
        VIR_FREE(tmp);
        def->mac_specified = true;
    }

724 725 726 727 728 729
    dnsNode = virXPathNode("./dns", ctxt);
    if (dnsNode != NULL) {
        if (virNetworkDNSDefParseXML(&def->dns, dnsNode) < 0)
            goto error;
    }

730
    nIps = virXPathNodeSet("./ip", ctxt, &ipNodes);
731 732 733
    if (nIps < 0)
        goto error;

734 735
    if (nIps > 0) {
        int ii;
736

737 738 739
        /* allocate array to hold all the addrs */
        if (VIR_ALLOC_N(def->ips, nIps) < 0) {
            virReportOOMError();
740 741
            goto error;
        }
742 743 744 745 746 747 748
        /* parse each addr */
        for (ii = 0; ii < nIps; ii++) {
            int ret = virNetworkIPParseXML(def->name, &def->ips[ii],
                                           ipNodes[ii], ctxt);
            if (ret < 0)
                goto error;
            def->nips++;
749
        }
750
    }
E
Eric Blake 已提交
751
    VIR_FREE(ipNodes);
752

753 754
    /* IPv4 forwarding setup */
    if (virXPathBoolean("count(./forward) > 0", ctxt)) {
755 756 757 758 759
        if (def->nips == 0) {
            virNetworkReportError(VIR_ERR_INTERNAL_ERROR,
                                  "%s", _("Forwarding requested, but no IP address provided"));
            goto error;
        }
760
        tmp = virXPathString("string(./forward[1]/@mode)", ctxt);
761 762
        if (tmp) {
            if ((def->forwardType = virNetworkForwardTypeFromString(tmp)) < 0) {
763
                virNetworkReportError(VIR_ERR_INTERNAL_ERROR,
764 765 766 767 768 769 770 771 772 773
                                      _("unknown forwarding type '%s'"), tmp);
                VIR_FREE(tmp);
                goto error;
            }
            VIR_FREE(tmp);
        } else {
            def->forwardType = VIR_NETWORK_FORWARD_NAT;
        }


774
        def->forwardDev = virXPathString("string(./forward[1]/@dev)", ctxt);
775 776 777 778 779 780 781 782
    } else {
        def->forwardType = VIR_NETWORK_FORWARD_NONE;
    }

    return def;

 error:
    virNetworkDefFree(def);
E
Eric Blake 已提交
783
    VIR_FREE(ipNodes);
784 785 786
    return NULL;
}

J
Jiri Denemark 已提交
787 788 789
static virNetworkDefPtr
virNetworkDefParse(const char *xmlStr,
                   const char *filename)
790
{
J
Jiri Denemark 已提交
791
    xmlDocPtr xml;
792
    virNetworkDefPtr def = NULL;
793

J
Jiri Denemark 已提交
794 795 796
    if ((xml = virXMLParse(filename, xmlStr, "network.xml"))) {
        def = virNetworkDefParseNode(xml, xmlDocGetRootElement(xml));
        xmlFreeDoc(xml);
797 798 799 800 801
    }

    return def;
}

J
Jiri Denemark 已提交
802
virNetworkDefPtr virNetworkDefParseString(const char *xmlStr)
803
{
J
Jiri Denemark 已提交
804 805
    return virNetworkDefParse(xmlStr, NULL);
}
806

J
Jiri Denemark 已提交
807 808 809
virNetworkDefPtr virNetworkDefParseFile(const char *filename)
{
    return virNetworkDefParse(NULL, filename);
810 811 812
}


813
virNetworkDefPtr virNetworkDefParseNode(xmlDocPtr xml,
814 815 816 817 818 819
                                        xmlNodePtr root)
{
    xmlXPathContextPtr ctxt = NULL;
    virNetworkDefPtr def = NULL;

    if (!xmlStrEqual(root->name, BAD_CAST "network")) {
820
        virNetworkReportError(VIR_ERR_INTERNAL_ERROR,
821 822 823 824 825 826
                              "%s", _("incorrect root element"));
        return NULL;
    }

    ctxt = xmlXPathNewContext(xml);
    if (ctxt == NULL) {
827
        virReportOOMError();
828 829 830 831
        goto cleanup;
    }

    ctxt->node = root;
832
    def = virNetworkDefParseXML(ctxt);
833 834 835 836 837 838

cleanup:
    xmlXPathFreeContext(ctxt);
    return def;
}

839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861
static int
virNetworkDNSDefFormat(virBufferPtr buf,
                       virNetworkDNSDefPtr def)
{
    int result = 0;
    int i;

    if (def == NULL)
        goto out;

    virBufferAddLit(buf, "  <dns>\n");

    for (i = 0 ; i < def->ntxtrecords ; i++) {
        virBufferAsprintf(buf, "    <txt name='%s' value='%s' />\n",
                              def->txtrecords[i].name,
                              def->txtrecords[i].value);
    }

    virBufferAddLit(buf, "  </dns>\n");
out:
    return result;
}

862 863 864 865 866 867 868 869 870
static int
virNetworkIpDefFormat(virBufferPtr buf,
                      const virNetworkIpDefPtr def)
{
    int result = -1;

    virBufferAddLit(buf, "  <ip");

    if (def->family) {
871
        virBufferAsprintf(buf, " family='%s'", def->family);
872 873 874 875 876
    }
    if (VIR_SOCKET_HAS_ADDR(&def->address)) {
        char *addr = virSocketFormatAddr(&def->address);
        if (!addr)
            goto error;
877
        virBufferAsprintf(buf, " address='%s'", addr);
878 879 880 881 882 883
        VIR_FREE(addr);
    }
    if (VIR_SOCKET_HAS_ADDR(&def->netmask)) {
        char *addr = virSocketFormatAddr(&def->netmask);
        if (!addr)
            goto error;
884
        virBufferAsprintf(buf, " netmask='%s'", addr);
885 886 887
        VIR_FREE(addr);
    }
    if (def->prefix > 0) {
888
        virBufferAsprintf(buf," prefix='%u'", def->prefix);
889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907
    }
    virBufferAddLit(buf, ">\n");

    if (def->tftproot) {
        virBufferEscapeString(buf, "    <tftp root='%s' />\n",
                              def->tftproot);
    }
    if ((def->nranges || def->nhosts)) {
        int ii;
        virBufferAddLit(buf, "    <dhcp>\n");
        for (ii = 0 ; ii < def->nranges ; ii++) {
            char *saddr = virSocketFormatAddr(&def->ranges[ii].start);
            if (!saddr)
                goto error;
            char *eaddr = virSocketFormatAddr(&def->ranges[ii].end);
            if (!eaddr) {
                VIR_FREE(saddr);
                goto error;
            }
908
            virBufferAsprintf(buf, "      <range start='%s' end='%s' />\n",
909 910 911 912 913 914 915
                              saddr, eaddr);
            VIR_FREE(saddr);
            VIR_FREE(eaddr);
        }
        for (ii = 0 ; ii < def->nhosts ; ii++) {
            virBufferAddLit(buf, "      <host ");
            if (def->hosts[ii].mac)
916
                virBufferAsprintf(buf, "mac='%s' ", def->hosts[ii].mac);
917
            if (def->hosts[ii].name)
918
                virBufferAsprintf(buf, "name='%s' ", def->hosts[ii].name);
919 920 921 922
            if (VIR_SOCKET_HAS_ADDR(&def->hosts[ii].ip)) {
                char *ipaddr = virSocketFormatAddr(&def->hosts[ii].ip);
                if (!ipaddr)
                    goto error;
923
                virBufferAsprintf(buf, "ip='%s' ", ipaddr);
924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950
                VIR_FREE(ipaddr);
            }
            virBufferAddLit(buf, "/>\n");
        }
        if (def->bootfile) {
            virBufferEscapeString(buf, "      <bootp file='%s' ",
                                  def->bootfile);
            if (VIR_SOCKET_HAS_ADDR(&def->bootserver)) {
                char *ipaddr = virSocketFormatAddr(&def->bootserver);
                if (!ipaddr)
                    goto error;
                virBufferEscapeString(buf, "server='%s' ", ipaddr);
                VIR_FREE(ipaddr);
            }
            virBufferAddLit(buf, "/>\n");
        }

        virBufferAddLit(buf, "    </dhcp>\n");
    }

    virBufferAddLit(buf, "  </ip>\n");

    result = 0;
error:
    return result;
}

951
char *virNetworkDefFormat(const virNetworkDefPtr def)
952 953 954 955
{
    virBuffer buf = VIR_BUFFER_INITIALIZER;
    unsigned char *uuid;
    char uuidstr[VIR_UUID_STRING_BUFLEN];
956
    int ii;
957 958 959 960 961 962

    virBufferAddLit(&buf, "<network>\n");
    virBufferEscapeString(&buf, "  <name>%s</name>\n", def->name);

    uuid = def->uuid;
    virUUIDFormat(uuid, uuidstr);
963
    virBufferAsprintf(&buf, "  <uuid>%s</uuid>\n", uuidstr);
964 965 966 967 968 969 970 971 972 973

    if (def->forwardType != VIR_NETWORK_FORWARD_NONE) {
        const char *mode = virNetworkForwardTypeToString(def->forwardType);
        if (mode) {
            if (def->forwardDev) {
                virBufferEscapeString(&buf, "  <forward dev='%s'",
                                      def->forwardDev);
            } else {
                virBufferAddLit(&buf, "  <forward");
            }
974
            virBufferAsprintf(&buf, " mode='%s'/>\n", mode);
975 976 977 978 979 980
        }
    }

    virBufferAddLit(&buf, "  <bridge");
    if (def->bridge)
        virBufferEscapeString(&buf, " name='%s'", def->bridge);
981
    virBufferAsprintf(&buf, " stp='%s' delay='%ld' />\n",
982 983
                      def->stp ? "on" : "off",
                      def->delay);
984 985 986
    if (def->mac_specified) {
        char macaddr[VIR_MAC_STRING_BUFLEN];
        virFormatMacAddr(def->mac, macaddr);
987
        virBufferAsprintf(&buf, "  <mac address='%s'/>\n", macaddr);
988
    }
989

990
    if (def->domain)
991
        virBufferAsprintf(&buf, "  <domain name='%s'/>\n", def->domain);
992

993 994 995
    if (virNetworkDNSDefFormat(&buf, def->dns) < 0)
        goto error;

996 997 998
    for (ii = 0; ii < def->nips; ii++) {
        if (virNetworkIpDefFormat(&buf, &def->ips[ii]) < 0)
            goto error;
999 1000 1001 1002 1003 1004 1005 1006 1007 1008
    }

    virBufferAddLit(&buf, "</network>\n");

    if (virBufferError(&buf))
        goto no_memory;

    return virBufferContentAndReset(&buf);

 no_memory:
1009
    virReportOOMError();
1010
  error:
1011
    virBufferFreeAndReset(&buf);
1012 1013 1014
    return NULL;
}

1015
int virNetworkSaveXML(const char *configDir,
1016 1017
                      virNetworkDefPtr def,
                      const char *xml)
1018
{
1019
    char *configFile = NULL;
1020 1021 1022 1023
    int fd = -1, ret = -1;
    size_t towrite;
    int err;

1024
    if ((configFile = virNetworkConfigFile(configDir, def->name)) == NULL)
1025 1026 1027
        goto cleanup;

    if ((err = virFileMakePath(configDir))) {
1028
        virReportSystemError(err,
1029 1030
                             _("cannot create config directory '%s'"),
                             configDir);
1031 1032 1033
        goto cleanup;
    }

1034
    if ((fd = open(configFile,
1035 1036
                   O_WRONLY | O_CREAT | O_TRUNC,
                   S_IRUSR | S_IWUSR )) < 0) {
1037
        virReportSystemError(errno,
1038
                             _("cannot create config file '%s'"),
1039
                             configFile);
1040 1041 1042
        goto cleanup;
    }

1043 1044
    virEmitXMLWarning(fd, def->name, "net-edit");

1045 1046
    towrite = strlen(xml);
    if (safewrite(fd, xml, towrite) < 0) {
1047
        virReportSystemError(errno,
1048
                             _("cannot write config file '%s'"),
1049
                             configFile);
1050 1051 1052
        goto cleanup;
    }

1053
    if (VIR_CLOSE(fd) < 0) {
1054
        virReportSystemError(errno,
1055
                             _("cannot save config file '%s'"),
1056
                             configFile);
1057 1058 1059 1060 1061 1062
        goto cleanup;
    }

    ret = 0;

 cleanup:
1063
    VIR_FORCE_CLOSE(fd);
1064

1065 1066 1067 1068 1069
    VIR_FREE(configFile);

    return ret;
}

1070
int virNetworkSaveConfig(const char *configDir,
1071 1072 1073 1074 1075
                         virNetworkDefPtr def)
{
    int ret = -1;
    char *xml;

1076
    if (!(xml = virNetworkDefFormat(def)))
1077 1078
        goto cleanup;

1079
    if (virNetworkSaveXML(configDir, def, xml))
1080 1081 1082 1083 1084
        goto cleanup;

    ret = 0;
cleanup:
    VIR_FREE(xml);
1085 1086 1087
    return ret;
}

1088

1089
virNetworkObjPtr virNetworkLoadConfig(virNetworkObjListPtr nets,
1090 1091
                                      const char *configDir,
                                      const char *autostartDir,
1092
                                      const char *name)
1093 1094 1095 1096 1097 1098
{
    char *configFile = NULL, *autostartLink = NULL;
    virNetworkDefPtr def = NULL;
    virNetworkObjPtr net;
    int autostart;

1099
    if ((configFile = virNetworkConfigFile(configDir, name)) == NULL)
1100
        goto error;
1101
    if ((autostartLink = virNetworkConfigFile(autostartDir, name)) == NULL)
1102 1103 1104 1105 1106
        goto error;

    if ((autostart = virFileLinkPointsTo(autostartLink, configFile)) < 0)
        goto error;

1107
    if (!(def = virNetworkDefParseFile(configFile)))
1108 1109
        goto error;

1110
    if (!STREQ(name, def->name)) {
1111
        virNetworkReportError(VIR_ERR_INTERNAL_ERROR,
1112 1113 1114 1115 1116 1117
                              _("Network config filename '%s'"
                                " does not match network name '%s'"),
                              configFile, def->name);
        goto error;
    }

1118
    /* Generate a bridge if none is specified, but don't check for collisions
1119 1120
     * if a bridge is hardcoded, so the network is at least defined
     */
1121
    if (virNetworkSetBridgeName(nets, def, 0))
1122 1123
        goto error;

1124
    if (!(net = virNetworkAssignDef(nets, def)))
1125 1126 1127
        goto error;

    net->autostart = autostart;
1128
    net->persistent = 1;
1129

1130 1131 1132
    VIR_FREE(configFile);
    VIR_FREE(autostartLink);

1133 1134 1135 1136 1137 1138 1139 1140 1141
    return net;

error:
    VIR_FREE(configFile);
    VIR_FREE(autostartLink);
    virNetworkDefFree(def);
    return NULL;
}

1142
int virNetworkLoadAllConfigs(virNetworkObjListPtr nets,
1143 1144 1145 1146 1147 1148 1149 1150 1151
                             const char *configDir,
                             const char *autostartDir)
{
    DIR *dir;
    struct dirent *entry;

    if (!(dir = opendir(configDir))) {
        if (errno == ENOENT)
            return 0;
1152
        virReportSystemError(errno,
1153 1154
                             _("Failed to open dir '%s'"),
                             configDir);
1155 1156 1157 1158
        return -1;
    }

    while ((entry = readdir(dir))) {
1159 1160
        virNetworkObjPtr net;

1161 1162 1163
        if (entry->d_name[0] == '.')
            continue;

1164
        if (!virFileStripSuffix(entry->d_name, ".xml"))
1165 1166 1167 1168
            continue;

        /* NB: ignoring errors, so one malformed config doesn't
           kill the whole process */
1169
        net = virNetworkLoadConfig(nets,
1170 1171 1172 1173 1174
                                   configDir,
                                   autostartDir,
                                   entry->d_name);
        if (net)
            virNetworkObjUnlock(net);
1175 1176 1177 1178 1179 1180 1181
    }

    closedir(dir);

    return 0;
}

1182
int virNetworkDeleteConfig(const char *configDir,
1183
                           const char *autostartDir,
1184 1185
                           virNetworkObjPtr net)
{
1186 1187
    char *configFile = NULL;
    char *autostartLink = NULL;
R
Ryota Ozaki 已提交
1188
    int ret = -1;
1189

1190
    if ((configFile = virNetworkConfigFile(configDir, net->def->name)) == NULL)
1191
        goto error;
1192
    if ((autostartLink = virNetworkConfigFile(autostartDir, net->def->name)) == NULL)
1193
        goto error;
1194 1195

    /* Not fatal if this doesn't work */
1196
    unlink(autostartLink);
1197

1198
    if (unlink(configFile) < 0) {
1199
        virReportSystemError(errno,
1200
                             _("cannot remove config file '%s'"),
1201 1202
                             configFile);
        goto error;
1203 1204
    }

R
Ryota Ozaki 已提交
1205
    ret = 0;
1206 1207 1208 1209

error:
    VIR_FREE(configFile);
    VIR_FREE(autostartLink);
R
Ryota Ozaki 已提交
1210
    return ret;
1211 1212
}

1213
char *virNetworkConfigFile(const char *dir,
1214 1215 1216 1217 1218
                           const char *name)
{
    char *ret = NULL;

    if (virAsprintf(&ret, "%s/%s.xml", dir, name) < 0) {
1219
        virReportOOMError();
1220 1221 1222 1223
        return NULL;
    }

    return ret;
1224
}
D
Daniel P. Berrange 已提交
1225

1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244
int virNetworkBridgeInUse(const virNetworkObjListPtr nets,
                          const char *bridge,
                          const char *skipname)
{
    unsigned int i;
    unsigned int ret = 0;

    for (i = 0 ; i < nets->count ; i++) {
        virNetworkObjLock(nets->objs[i]);
        if (nets->objs[i]->def->bridge &&
            STREQ(nets->objs[i]->def->bridge, bridge) &&
            !(skipname && STREQ(nets->objs[i]->def->name, skipname)))
                ret = 1;
        virNetworkObjUnlock(nets->objs[i]);
    }

    return ret;
}

1245
char *virNetworkAllocateBridge(const virNetworkObjListPtr nets,
1246
                               const char *template)
1247 1248 1249 1250 1251
{

    int id = 0;
    char *newname;

1252 1253 1254
    if (!template)
        template = "virbr%d";

1255
    do {
1256 1257 1258 1259 1260
        if (virAsprintf(&newname, template, id) < 0) {
            virReportOOMError();
            return NULL;
        }
        if (!virNetworkBridgeInUse(nets, newname, NULL)) {
1261 1262
            return newname;
        }
1263
        VIR_FREE(newname);
1264 1265

        id++;
1266
    } while (id <= MAX_BRIDGE_ID);
1267

1268
    virNetworkReportError(VIR_ERR_INTERNAL_ERROR,
1269 1270 1271 1272 1273
                          _("Bridge generation exceeded max id %d"),
                          MAX_BRIDGE_ID);
    return NULL;
}

1274
int virNetworkSetBridgeName(const virNetworkObjListPtr nets,
1275 1276
                            virNetworkDefPtr def,
                            int check_collision) {
1277 1278 1279

    int ret = -1;

1280
    if (def->bridge && !strstr(def->bridge, "%d")) {
1281 1282 1283 1284 1285
        /* We may want to skip collision detection in this case (ex. when
         * loading configs at daemon startup, so the network is at least
         * defined. */
        if (check_collision &&
            virNetworkBridgeInUse(nets, def->bridge, def->name)) {
1286 1287 1288
            virNetworkReportError(VIR_ERR_INTERNAL_ERROR,
                                  _("bridge name '%s' already in use."),
                                  def->bridge);
1289 1290 1291 1292
            goto error;
        }
    } else {
        /* Allocate a bridge name */
1293
        if (!(def->bridge = virNetworkAllocateBridge(nets, def->bridge)))
1294 1295 1296 1297 1298 1299 1300
            goto error;
    }

    ret = 0;
error:
    return ret;
}
1301

1302

1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314
void virNetworkSetBridgeMacAddr(virNetworkDefPtr def)
{
    if (!def->mac_specified) {
        /* if the bridge doesn't have a mac address explicitly defined,
         * autogenerate a random one.
         */
        virGenerateMacAddr((unsigned char[]){ 0x52, 0x54, 0 },
                           def->mac);
        def->mac_specified = true;
    }
}

1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378
/*
 * virNetworkObjIsDuplicate:
 * @doms : virNetworkObjListPtr to search
 * @def  : virNetworkDefPtr definition of network to lookup
 * @check_active: If true, ensure that network is not active
 *
 * Returns: -1 on error
 *          0 if network is new
 *          1 if network is a duplicate
 */
int
virNetworkObjIsDuplicate(virNetworkObjListPtr doms,
                         virNetworkDefPtr def,
                         unsigned int check_active)
{
    int ret = -1;
    int dupVM = 0;
    virNetworkObjPtr vm = NULL;

    /* See if a VM with matching UUID already exists */
    vm = virNetworkFindByUUID(doms, def->uuid);
    if (vm) {
        /* UUID matches, but if names don't match, refuse it */
        if (STRNEQ(vm->def->name, def->name)) {
            char uuidstr[VIR_UUID_STRING_BUFLEN];
            virUUIDFormat(vm->def->uuid, uuidstr);
            virNetworkReportError(VIR_ERR_OPERATION_FAILED,
                                  _("network '%s' is already defined with uuid %s"),
                                  vm->def->name, uuidstr);
            goto cleanup;
        }

        if (check_active) {
            /* UUID & name match, but if VM is already active, refuse it */
            if (virNetworkObjIsActive(vm)) {
                virNetworkReportError(VIR_ERR_OPERATION_INVALID,
                                      _("network is already active as '%s'"),
                                      vm->def->name);
                goto cleanup;
            }
        }

        dupVM = 1;
    } else {
        /* UUID does not match, but if a name matches, refuse it */
        vm = virNetworkFindByName(doms, def->name);
        if (vm) {
            char uuidstr[VIR_UUID_STRING_BUFLEN];
            virUUIDFormat(vm->def->uuid, uuidstr);
            virNetworkReportError(VIR_ERR_OPERATION_FAILED,
                                  _("network '%s' already exists with uuid %s"),
                                  def->name, uuidstr);
            goto cleanup;
        }
    }

    ret = dupVM;
cleanup:
    if (vm)
        virNetworkObjUnlock(vm);
    return ret;
}


1379 1380
void virNetworkObjLock(virNetworkObjPtr obj)
{
1381
    virMutexLock(&obj->lock);
1382 1383 1384 1385
}

void virNetworkObjUnlock(virNetworkObjPtr obj)
{
1386
    virMutexUnlock(&obj->lock);
D
Daniel P. Berrange 已提交
1387
}