qemu_hotplug.c 193.5 KB
Newer Older
1
/*
2
 * qemu_hotplug.c: QEMU device hotplug management
3
 *
4
 * Copyright (C) 2006-2016 Red Hat, Inc.
5 6 7 8 9 10 11 12 13 14 15 16 17
 * Copyright (C) 2006 Daniel P. Berrange
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
18
 * License along with this library.  If not, see
O
Osier Yang 已提交
19
 * <http://www.gnu.org/licenses/>.
20 21 22 23 24 25 26 27
 *
 * Author: Daniel P. Berrange <berrange@redhat.com>
 */


#include <config.h>

#include "qemu_hotplug.h"
28
#include "qemu_hotplugpriv.h"
29
#include "qemu_alias.h"
30 31
#include "qemu_capabilities.h"
#include "qemu_domain.h"
32
#include "qemu_domain_address.h"
33 34
#include "qemu_command.h"
#include "qemu_hostdev.h"
35
#include "qemu_interface.h"
36
#include "qemu_process.h"
37
#include "qemu_security.h"
38
#include "domain_audit.h"
39
#include "netdev_bandwidth_conf.h"
40
#include "domain_nwfilter.h"
41
#include "virlog.h"
42
#include "datatypes.h"
43
#include "virerror.h"
44
#include "viralloc.h"
45
#include "virpci.h"
E
Eric Blake 已提交
46
#include "virfile.h"
47
#include "virprocess.h"
48
#include "qemu_cgroup.h"
49
#include "locking/domain_lock.h"
50
#include "network/bridge_driver.h"
51 52
#include "virnetdev.h"
#include "virnetdevbridge.h"
A
Ansis Atteka 已提交
53
#include "virnetdevtap.h"
54
#include "virnetdevopenvswitch.h"
55
#include "virnetdevmidonet.h"
56
#include "device_conf.h"
57
#include "virstoragefile.h"
58
#include "virstring.h"
59
#include "virtime.h"
60
#include "storage/storage_driver.h"
61 62

#define VIR_FROM_THIS VIR_FROM_QEMU
63 64 65

VIR_LOG_INIT("qemu.qemu_hotplug");

66
#define CHANGE_MEDIA_TIMEOUT 5000
67

68 69 70 71
/* Wait up to 5 seconds for device removal to finish. */
unsigned long long qemuDomainRemoveDeviceWaitTime = 1000ull * 5;


72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112
/**
 * qemuDomainPrepareDisk:
 * @driver: qemu driver struct
 * @vm: domain object
 * @disk: disk to prepare
 * @overridesrc: Source different than @disk->src when necessary
 * @teardown: Teardown the disk instead of adding it to a vm
 *
 * Setup the locks, cgroups and security permissions on a disk of a VM.
 * If @overridesrc is specified the source struct is used instead of the
 * one present in @disk. If @teardown is true, then the labels and cgroups
 * are removed instead.
 *
 * Returns 0 on success and -1 on error. Reports libvirt error.
 */
static int
qemuDomainPrepareDisk(virQEMUDriverPtr driver,
                      virDomainObjPtr vm,
                      virDomainDiskDefPtr disk,
                      virStorageSourcePtr overridesrc,
                      bool teardown)
{
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
    int ret = -1;
    virStorageSourcePtr origsrc = NULL;

    if (overridesrc) {
        origsrc = disk->src;
        disk->src = overridesrc;
    }

    /* just tear down the disk access */
    if (teardown) {
        ret = 0;
        goto rollback_cgroup;
    }

    if (virDomainLockDiskAttach(driver->lockManager, cfg->uri,
                                vm, disk) < 0)
        goto cleanup;

113
    if (qemuDomainNamespaceSetupDisk(driver, vm, disk->src) < 0)
114 115
        goto rollback_lock;

116 117
    if (qemuSecuritySetDiskLabel(driver, vm, disk) < 0)
        goto rollback_namespace;
118

119
    if (qemuSetupDiskCgroup(vm, disk) < 0)
120
        goto rollback_label;
121

122 123 124 125 126 127 128 129
    ret = 0;
    goto cleanup;

 rollback_cgroup:
    if (qemuTeardownDiskCgroup(vm, disk) < 0)
        VIR_WARN("Unable to tear down cgroup access on %s",
                 virDomainDiskGetSource(disk));
 rollback_label:
130
    if (qemuSecurityRestoreDiskLabel(driver, vm, disk) < 0)
131 132 133
        VIR_WARN("Unable to restore security label on %s",
                 virDomainDiskGetSource(disk));

134
 rollback_namespace:
135
    if (qemuDomainNamespaceTeardownDisk(driver, vm, disk->src) < 0)
136 137 138
        VIR_WARN("Unable to remove /dev entry for %s",
                 virDomainDiskGetSource(disk));

139 140 141 142 143 144 145 146 147 148 149 150 151 152 153
 rollback_lock:
    if (virDomainLockDiskDetach(driver->lockManager, vm, disk) < 0)
        VIR_WARN("Unable to release lock on %s",
                 virDomainDiskGetSource(disk));

 cleanup:
    if (origsrc)
        disk->src = origsrc;

    virObjectUnref(cfg);

    return ret;
}


154 155 156 157
static int
qemuHotplugWaitForTrayEject(virQEMUDriverPtr driver,
                            virDomainObjPtr vm,
                            virDomainDiskDefPtr disk,
158
                            const char *driveAlias)
159 160 161 162 163 164 165 166 167 168 169 170
{
    unsigned long long now;
    int rc;

    if (virTimeMillisNow(&now) < 0)
        return -1;

    while (disk->tray_status != VIR_DOMAIN_DISK_TRAY_OPEN) {
        if ((rc = virDomainObjWaitUntil(vm, now + CHANGE_MEDIA_TIMEOUT)) < 0)
            return -1;

        if (rc > 0) {
171 172 173 174 175 176
            /* the caller called qemuMonitorEjectMedia which usually reports an
             * error. Report the failure in an off-chance that it didn't. */
            if (!virGetLastError()) {
                virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                               _("timed out waiting for disk tray status update"));
            }
177 178 179 180 181 182
            return -1;
        }
    }

    /* re-issue ejection command to pop out the media */
    qemuDomainObjEnterMonitor(driver, vm);
183
    rc = qemuMonitorEjectMedia(qemuDomainGetMonitor(vm), driveAlias, false);
184 185 186 187 188 189 190
    if (qemuDomainObjExitMonitor(driver, vm) < 0 || rc < 0)
        return -1;

    return 0;
}


191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211
/**
 * qemuDomainChangeEjectableMedia:
 * @driver: qemu driver structure
 * @vm: domain definition
 * @disk: disk definition to change the source of
 * @newsrc: new disk source to change to
 * @force: force the change of media
 *
 * Change the media in an ejectable device to the one described by
 * @newsrc. This function also removes the old source from the
 * shared device table if appropriate. Note that newsrc is consumed
 * on success and the old source is freed on success.
 *
 * Returns 0 on success, -1 on error and reports libvirt error
 */
int
qemuDomainChangeEjectableMedia(virQEMUDriverPtr driver,
                               virDomainObjPtr vm,
                               virDomainDiskDefPtr disk,
                               virStorageSourcePtr newsrc,
                               bool force)
212
{
213
    int ret = -1, rc;
214
    char *driveAlias = NULL;
215
    qemuDomainObjPrivatePtr priv = vm->privateData;
216
    qemuDomainDiskPrivatePtr diskPriv = QEMU_DOMAIN_DISK_PRIVATE(disk);
217
    const char *format = NULL;
218
    char *sourcestr = NULL;
219

220
    if (!disk->info.alias) {
221
        virReportError(VIR_ERR_INTERNAL_ERROR,
222
                       _("missing disk device alias name for %s"), disk->dst);
223
        goto cleanup;
224 225
    }

226 227
    if (disk->device != VIR_DOMAIN_DISK_DEVICE_FLOPPY &&
        disk->device != VIR_DOMAIN_DISK_DEVICE_CDROM) {
228 229
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("Removable media not supported for %s device"),
230
                       virDomainDiskDeviceTypeToString(disk->device));
231
        goto cleanup;
232 233
    }

234
    if (qemuDomainPrepareDisk(driver, vm, disk, newsrc, false) < 0)
235
        goto cleanup;
236

237
    if (!(driveAlias = qemuAliasFromDisk(disk)))
238 239
        goto error;

240 241 242 243
    qemuDomainObjEnterMonitor(driver, vm);
    rc = qemuMonitorEjectMedia(priv->mon, driveAlias, force);
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        goto cleanup;
244

245
    /* If the tray is present and tray change event is supported wait for it to open. */
246
    if (!force && diskPriv->tray &&
247
        virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DEVICE_TRAY_MOVED)) {
248
        rc = qemuHotplugWaitForTrayEject(driver, vm, disk, driveAlias);
249
        if (rc < 0)
250
            goto error;
251 252 253 254 255
    } else  {
        /* otherwise report possible errors from the attempt to eject the media*/
        if (rc < 0)
            goto error;
    }
256

257
    if (!virStorageSourceIsEmpty(newsrc)) {
258
        if (qemuGetDriveSourceString(newsrc, diskPriv->secinfo, &sourcestr) < 0)
259 260
            goto error;

261 262 263
        if (virStorageSourceGetActualType(newsrc) != VIR_STORAGE_TYPE_DIR) {
            if (newsrc->format > 0) {
                format = virStorageFileFormatTypeToString(newsrc->format);
264
            } else {
265 266
                if (disk->src->format > 0)
                    format = virStorageFileFormatTypeToString(disk->src->format);
267
            }
268
        }
269
        qemuDomainObjEnterMonitor(driver, vm);
270 271 272 273 274
        rc = qemuMonitorChangeMedia(priv->mon,
                                    driveAlias,
                                    sourcestr,
                                    format);
        if (qemuDomainObjExitMonitor(driver, vm) < 0)
275
            goto cleanup;
276
    }
277

278
    virDomainAuditDisk(vm, disk->src, newsrc, "update", rc >= 0);
279

280
    if (rc < 0)
281 282
        goto error;

283 284
    /* remove the old source from shared device list */
    ignore_value(qemuRemoveSharedDisk(driver, disk, vm->def->name));
285
    ignore_value(qemuDomainPrepareDisk(driver, vm, disk, NULL, true));
286

287 288 289
    virStorageSourceFree(disk->src);
    disk->src = newsrc;
    newsrc = NULL;
290
    ret = 0;
291

292
 cleanup:
293
    VIR_FREE(driveAlias);
294
    VIR_FREE(sourcestr);
295 296
    return ret;

297
 error:
298 299
    virDomainAuditDisk(vm, disk->src, newsrc, "update", false);
    ignore_value(qemuDomainPrepareDisk(driver, vm, disk, newsrc, true));
300
    goto cleanup;
301 302
}

303

304 305 306 307 308
static int
qemuDomainAttachVirtioDiskDevice(virConnectPtr conn,
                                 virQEMUDriverPtr driver,
                                 virDomainObjPtr vm,
                                 virDomainDiskDefPtr disk)
309
{
310
    int ret = -1;
311
    int rv;
312
    qemuDomainObjPrivatePtr priv = vm->privateData;
313
    virDomainDeviceDef dev = { VIR_DOMAIN_DEVICE_DISK, { .disk = disk } };
314
    virErrorPtr orig_err;
315 316
    char *devstr = NULL;
    char *drivestr = NULL;
317
    char *drivealias = NULL;
318
    bool releaseaddr = false;
319
    bool driveAdded = false;
320
    bool secobjAdded = false;
321
    bool encobjAdded = false;
322
    virDomainCCWAddressSetPtr ccwaddrs = NULL;
323
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
324
    const char *src = virDomainDiskGetSource(disk);
325
    virJSONValuePtr secobjProps = NULL;
326
    virJSONValuePtr encobjProps = NULL;
327 328
    qemuDomainDiskPrivatePtr diskPriv;
    qemuDomainSecretInfoPtr secinfo;
329
    qemuDomainSecretInfoPtr encinfo;
330

331
    if (!disk->info.type) {
332
        if (qemuDomainIsS390CCW(vm->def) &&
333 334 335 336
            virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_VIRTIO_CCW))
            disk->info.type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW;
        else if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_VIRTIO_S390))
            disk->info.type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_S390;
337 338 339 340
    } else {
        if (!qemuCheckCCWS390AddressSupport(vm->def, disk->info, priv->qemuCaps,
                                            disk->dst))
            goto cleanup;
341 342
    }

343
    if (qemuDomainPrepareDisk(driver, vm, disk, NULL, false) < 0)
344
        goto cleanup;
345

346
    if (disk->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) {
347 348 349
        if (!(ccwaddrs = qemuDomainCCWAddrSetCreateFromDomain(vm->def)))
            goto error;
        if (virDomainCCWAddressAssign(&disk->info, ccwaddrs,
350
                                      !disk->info.addr.ccw.assigned) < 0)
351
            goto error;
352 353
    } else if (!disk->info.type ||
                disk->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) {
354
        if (qemuDomainEnsurePCIAddress(vm, &dev, driver) < 0)
355
            goto error;
356 357 358 359
    }
    releaseaddr = true;
    if (qemuAssignDeviceDiskAlias(vm->def, disk, priv->qemuCaps) < 0)
        goto error;
360

J
John Ferlan 已提交
361
    if (qemuDomainSecretDiskPrepare(conn, priv, disk) < 0)
362 363
        goto error;

364 365 366 367 368 369 370
    diskPriv = QEMU_DOMAIN_DISK_PRIVATE(disk);
    secinfo = diskPriv->secinfo;
    if (secinfo && secinfo->type == VIR_DOMAIN_SECRET_INFO_TYPE_AES) {
        if (qemuBuildSecretInfoProps(secinfo, &secobjProps) < 0)
            goto error;
    }

371 372 373 374
    encinfo = diskPriv->encinfo;
    if (encinfo && qemuBuildSecretInfoProps(encinfo, &encobjProps) < 0)
        goto error;

375
    if (!(drivestr = qemuBuildDriveStr(disk, cfg, false, priv->qemuCaps)))
376
        goto error;
377

378
    if (!(drivealias = qemuAliasFromDisk(disk)))
379 380 381 382
        goto error;

    if (!(devstr = qemuBuildDriveDevStr(vm->def, disk, 0, priv->qemuCaps)))
        goto error;
383

384
    if (VIR_REALLOC_N(vm->def->disks, vm->def->ndisks+1) < 0)
385 386
        goto error;

387
    qemuDomainObjEnterMonitor(driver, vm);
388

389 390 391 392 393
    if (secobjProps) {
        rv = qemuMonitorAddObject(priv->mon, "secret", secinfo->s.aes.alias,
                                  secobjProps);
        secobjProps = NULL; /* qemuMonitorAddObject consumes */
        if (rv < 0)
394
            goto exit_monitor;
395
        secobjAdded = true;
396 397
    }

398 399 400 401 402 403
    if (encobjProps) {
        rv = qemuMonitorAddObject(priv->mon, "secret", encinfo->s.aes.alias,
                                  encobjProps);
        encobjProps = NULL; /* qemuMonitorAddObject consumes */
        if (rv < 0)
            goto exit_monitor;
404
        encobjAdded = true;
405 406
    }

407
    if (qemuMonitorAddDrive(priv->mon, drivestr) < 0)
408 409
        goto exit_monitor;
    driveAdded = true;
410 411

    if (qemuMonitorAddDevice(priv->mon, devstr) < 0)
412
        goto exit_monitor;
413

414 415
    if (qemuDomainObjExitMonitor(driver, vm) < 0) {
        releaseaddr = false;
416
        goto error;
417
    }
418

419
    virDomainAuditDisk(vm, NULL, disk->src, "attach", true);
420 421

    virDomainDiskInsertPreAlloced(vm->def, disk);
422
    ret = 0;
423

424
 cleanup:
425
    virJSONValueFree(secobjProps);
426
    virJSONValueFree(encobjProps);
427
    qemuDomainSecretDiskDestroy(disk);
428
    virDomainCCWAddressSetFree(ccwaddrs);
429 430
    VIR_FREE(devstr);
    VIR_FREE(drivestr);
431
    VIR_FREE(drivealias);
432 433
    virObjectUnref(cfg);
    return ret;
434

435
 exit_monitor:
436
    orig_err = virSaveLastError();
437
    if (driveAdded && qemuMonitorDriveDel(priv->mon, drivealias) < 0) {
438 439 440
        VIR_WARN("Unable to remove drive %s (%s) after failed "
                 "qemuMonitorAddDevice", drivealias, drivestr);
    }
441 442
    if (secobjAdded)
        ignore_value(qemuMonitorDelObject(priv->mon, secinfo->s.aes.alias));
443 444
    if (encobjAdded)
        ignore_value(qemuMonitorDelObject(priv->mon, encinfo->s.aes.alias));
445 446
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        releaseaddr = false;
447 448 449 450
    if (orig_err) {
        virSetError(orig_err);
        virFreeError(orig_err);
    }
451

452 453 454

    virDomainAuditDisk(vm, NULL, disk->src, "attach", false);

455
 error:
456
    if (releaseaddr)
457
        qemuDomainReleaseDeviceAddress(vm, &disk->info, src);
458

459
    ignore_value(qemuDomainPrepareDisk(driver, vm, disk, NULL, true));
460
    goto cleanup;
461 462 463
}


464 465 466
int qemuDomainAttachControllerDevice(virQEMUDriverPtr driver,
                                     virDomainObjPtr vm,
                                     virDomainControllerDefPtr controller)
467 468 469 470 471
{
    int ret = -1;
    const char* type = virDomainControllerTypeToString(controller->type);
    char *devstr = NULL;
    qemuDomainObjPrivatePtr priv = vm->privateData;
472 473
    virDomainDeviceDef dev = { VIR_DOMAIN_DEVICE_CONTROLLER,
                               { .controller = controller } };
474
    virDomainCCWAddressSetPtr ccwaddrs = NULL;
475
    bool releaseaddr = false;
476

477 478 479 480 481 482 483
    if (controller->type != VIR_DOMAIN_CONTROLLER_TYPE_SCSI) {
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
                       _("'%s' controller cannot be hot plugged."),
                       virDomainControllerTypeToString(controller->type));
        return -1;
    }

484 485 486 487 488 489 490 491
    /* default idx would normally be set by virDomainDefPostParse(),
     * which isn't called in the case of live attach of a single
     * device.
     */
    if (controller->idx == -1)
       controller->idx = virDomainControllerFindUnusedIndex(vm->def,
                                                            controller->type);

492
    if (virDomainControllerFind(vm->def, controller->type, controller->idx) >= 0) {
493 494 495 496
        virReportError(VIR_ERR_OPERATION_FAILED,
                       _("target %s:%d already exists"),
                       type, controller->idx);
        return -1;
497 498
    }

499
    if (controller->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) {
500
        if (qemuDomainIsS390CCW(vm->def) &&
501 502 503 504 505 506 507
            virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_VIRTIO_CCW))
            controller->info.type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW;
        else if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_VIRTIO_S390))
            controller->info.type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_S390;
    } else {
        if (!qemuCheckCCWS390AddressSupport(vm->def, controller->info,
                                            priv->qemuCaps, "controller"))
508
            goto cleanup;
509
    }
510

511 512
    if (controller->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE ||
        controller->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) {
513
        if (qemuDomainEnsurePCIAddress(vm, &dev, driver) < 0)
514 515
            goto cleanup;
    } else if (controller->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) {
516 517 518
        if (!(ccwaddrs = qemuDomainCCWAddrSetCreateFromDomain(vm->def)))
            goto cleanup;
        if (virDomainCCWAddressAssign(&controller->info, ccwaddrs,
519
                                      !controller->info.addr.ccw.assigned) < 0)
520 521
            goto cleanup;
    }
522 523 524 525 526 527
    releaseaddr = true;
    if (qemuAssignDeviceControllerAlias(vm->def, priv->qemuCaps, controller) < 0)
        goto cleanup;

    if (!(devstr = qemuBuildControllerDevStr(vm->def, controller, priv->qemuCaps, NULL)))
        goto cleanup;
528

529
    if (VIR_REALLOC_N(vm->def->controllers, vm->def->ncontrollers+1) < 0)
530 531
        goto cleanup;

532
    qemuDomainObjEnterMonitor(driver, vm);
533
    ret = qemuMonitorAddDevice(priv->mon, devstr);
534 535 536 537 538
    if (qemuDomainObjExitMonitor(driver, vm) < 0) {
        releaseaddr = false;
        ret = -1;
        goto cleanup;
    }
539 540

    if (ret == 0) {
541 542
        if (controller->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE)
            controller->info.type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI;
543 544 545
        virDomainControllerInsertPreAlloced(vm->def, controller);
    }

546
 cleanup:
547 548
    if (ret != 0 && releaseaddr)
        qemuDomainReleaseDeviceAddress(vm, &controller->info, NULL);
549 550

    VIR_FREE(devstr);
551
    virDomainCCWAddressSetFree(ccwaddrs);
552 553 554 555
    return ret;
}

static virDomainControllerDefPtr
556
qemuDomainFindOrCreateSCSIDiskController(virQEMUDriverPtr driver,
557
                                         virDomainObjPtr vm,
558
                                         int controller)
559
{
560
    size_t i;
561
    virDomainControllerDefPtr cont;
562

563
    for (i = 0; i < vm->def->ncontrollers; i++) {
564 565 566 567 568 569 570 571 572 573 574
        cont = vm->def->controllers[i];

        if (cont->type != VIR_DOMAIN_CONTROLLER_TYPE_SCSI)
            continue;

        if (cont->idx == controller)
            return cont;
    }

    /* No SCSI controller present, for backward compatibility we
     * now hotplug a controller */
575
    if (VIR_ALLOC(cont) < 0)
576 577
        return NULL;
    cont->type = VIR_DOMAIN_CONTROLLER_TYPE_SCSI;
578
    cont->idx = controller;
579 580
    cont->model = -1;

581
    VIR_INFO("No SCSI controller present, hotplugging one");
582 583
    if (qemuDomainAttachControllerDevice(driver,
                                         vm, cont) < 0) {
584 585 586 587 588
        VIR_FREE(cont);
        return NULL;
    }

    if (!virDomainObjIsActive(vm)) {
589 590
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("guest unexpectedly quit"));
591 592 593 594 595 596 597 598 599
        /* cont doesn't need freeing here, since the reference
         * now held in def->controllers */
        return NULL;
    }

    return cont;
}


600 601 602 603 604
static int
qemuDomainAttachSCSIDisk(virConnectPtr conn,
                         virQEMUDriverPtr driver,
                         virDomainObjPtr vm,
                         virDomainDiskDefPtr disk)
605
{
606
    size_t i;
607
    qemuDomainObjPrivatePtr priv = vm->privateData;
608
    virErrorPtr orig_err;
609 610
    char *drivestr = NULL;
    char *devstr = NULL;
611
    bool driveAdded = false;
612
    bool encobjAdded = false;
613
    bool secobjAdded = false;
614
    char *drivealias = NULL;
615
    int ret = -1;
616
    int rv;
617
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
618
    virJSONValuePtr encobjProps = NULL;
619
    virJSONValuePtr secobjProps = NULL;
620 621
    qemuDomainDiskPrivatePtr diskPriv;
    qemuDomainSecretInfoPtr encinfo;
622
    qemuDomainSecretInfoPtr secinfo;
623

624
    if (qemuDomainPrepareDisk(driver, vm, disk, NULL, false) < 0)
625
        goto cleanup;
626 627 628

    /* We should have an address already, so make sure */
    if (disk->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_DRIVE) {
629 630 631
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("unexpected disk address type %s"),
                       virDomainDeviceAddressTypeToString(disk->info.type));
632 633 634
        goto error;
    }

635 636 637 638 639 640 641 642 643 644 645 646
    /* Let's make sure the disk has a controller defined and loaded before
     * trying to add it. The controller used by the disk must exist before a
     * qemu command line string is generated.
     *
     * Ensure that the given controller and all controllers with a smaller index
     * exist; there must not be any missing index in between.
     */
    for (i = 0; i <= disk->info.addr.drive.controller; i++) {
        if (!qemuDomainFindOrCreateSCSIDiskController(driver, vm, i))
            goto error;
    }

647 648
    if (qemuAssignDeviceDiskAlias(vm->def, disk, priv->qemuCaps) < 0)
        goto error;
649

J
John Ferlan 已提交
650
    if (qemuDomainSecretDiskPrepare(conn, priv, disk) < 0)
651 652
        goto error;

653
    diskPriv = QEMU_DOMAIN_DISK_PRIVATE(disk);
654 655 656 657 658 659
    secinfo = diskPriv->secinfo;
    if (secinfo && secinfo->type == VIR_DOMAIN_SECRET_INFO_TYPE_AES) {
        if (qemuBuildSecretInfoProps(secinfo, &secobjProps) < 0)
            goto error;
    }

660 661 662 663
    encinfo = diskPriv->encinfo;
    if (encinfo && qemuBuildSecretInfoProps(encinfo, &encobjProps) < 0)
        goto error;

664 665
    if (!(devstr = qemuBuildDriveDevStr(vm->def, disk, 0, priv->qemuCaps)))
        goto error;
666

667
    if (!(drivestr = qemuBuildDriveStr(disk, cfg, false, priv->qemuCaps)))
668 669
        goto error;

670 671 672
    if (!(drivealias = qemuAliasFromDisk(disk)))
        goto error;

673
    if (VIR_REALLOC_N(vm->def->disks, vm->def->ndisks+1) < 0)
674 675
        goto error;

676
    qemuDomainObjEnterMonitor(driver, vm);
677

678 679 680 681 682 683 684 685 686
    if (secobjProps) {
        rv = qemuMonitorAddObject(priv->mon, "secret", secinfo->s.aes.alias,
                                  secobjProps);
        secobjProps = NULL; /* qemuMonitorAddObject consumes */
        if (rv < 0)
            goto exit_monitor;
        secobjAdded = true;
    }

687 688 689 690 691 692
    if (encobjProps) {
        rv = qemuMonitorAddObject(priv->mon, "secret", encinfo->s.aes.alias,
                                  encobjProps);
        encobjProps = NULL; /* qemuMonitorAddObject consumes */
        if (rv < 0)
            goto exit_monitor;
693
        encobjAdded = true;
694 695
    }

696
    if (qemuMonitorAddDrive(priv->mon, drivestr) < 0)
697 698
        goto exit_monitor;
    driveAdded = true;
699

700
    if (qemuMonitorAddDevice(priv->mon, devstr) < 0)
701
        goto exit_monitor;
702

703
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
704
        goto error;
705

706
    virDomainAuditDisk(vm, NULL, disk->src, "attach", true);
707 708

    virDomainDiskInsertPreAlloced(vm->def, disk);
709
    ret = 0;
710

711
 cleanup:
712
    virJSONValueFree(secobjProps);
713
    virJSONValueFree(encobjProps);
714
    qemuDomainSecretDiskDestroy(disk);
715 716
    VIR_FREE(devstr);
    VIR_FREE(drivestr);
717
    VIR_FREE(drivealias);
718 719
    virObjectUnref(cfg);
    return ret;
720

721
 exit_monitor:
722
    orig_err = virSaveLastError();
723 724 725 726
    if (driveAdded && qemuMonitorDriveDel(priv->mon, drivealias) < 0) {
        VIR_WARN("Unable to remove drive %s (%s) after failed "
                 "qemuMonitorAddDevice", drivealias, drivestr);
    }
727 728
    if (secobjAdded)
        ignore_value(qemuMonitorDelObject(priv->mon, secinfo->s.aes.alias));
729 730
    if (encobjAdded)
        ignore_value(qemuMonitorDelObject(priv->mon, encinfo->s.aes.alias));
731
    ignore_value(qemuDomainObjExitMonitor(driver, vm));
732 733 734 735 736
    if (orig_err) {
        virSetError(orig_err);
        virFreeError(orig_err);
    }

737 738
    virDomainAuditDisk(vm, NULL, disk->src, "attach", false);

739
 error:
740
    ignore_value(qemuDomainPrepareDisk(driver, vm, disk, NULL, true));
741
    goto cleanup;
742 743 744
}


745
static int
746
qemuDomainAttachUSBMassStorageDevice(virQEMUDriverPtr driver,
747 748
                                     virDomainObjPtr vm,
                                     virDomainDiskDefPtr disk)
749 750
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
751
    virErrorPtr orig_err;
752
    int ret = -1;
753
    char *drivealias = NULL;
754 755
    char *drivestr = NULL;
    char *devstr = NULL;
756
    bool driveAdded = false;
757
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
758
    const char *src = virDomainDiskGetSource(disk);
759 760 761 762 763 764 765
    bool releaseaddr = false;

    if (priv->usbaddrs) {
        if (virDomainUSBAddressEnsure(priv->usbaddrs, &disk->info) < 0)
            goto cleanup;
        releaseaddr = true;
    }
766

767
    if (qemuDomainPrepareDisk(driver, vm, disk, NULL, false) < 0)
768
        goto cleanup;
769

770
    /* XXX not correct once we allow attaching a USB CDROM */
771
    if (!src) {
772 773
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       "%s", _("disk source path is missing"));
774 775 776
        goto error;
    }

777 778
    if (qemuAssignDeviceDiskAlias(vm->def, disk, priv->qemuCaps) < 0)
        goto error;
779

780
    if (!(drivestr = qemuBuildDriveStr(disk, cfg, false, priv->qemuCaps)))
781
        goto error;
782 783 784 785

    if (!(drivealias = qemuAliasFromDisk(disk)))
        goto error;

786 787
    if (!(devstr = qemuBuildDriveDevStr(vm->def, disk, 0, priv->qemuCaps)))
        goto error;
788

789
    if (VIR_REALLOC_N(vm->def->disks, vm->def->ndisks+1) < 0)
790 791
        goto error;

792
    qemuDomainObjEnterMonitor(driver, vm);
793

794 795 796 797 798 799
    if (qemuMonitorAddDrive(priv->mon, drivestr) < 0)
        goto exit_monitor;
    driveAdded = true;

    if (qemuMonitorAddDevice(priv->mon, devstr) < 0)
        goto exit_monitor;
800

801
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
802 803
        goto error;

804 805
    virDomainAuditDisk(vm, NULL, disk->src, "attach", true);

806
    virDomainDiskInsertPreAlloced(vm->def, disk);
807
    ret = 0;
808

809
 cleanup:
810 811
    if (ret < 0 && releaseaddr)
        virDomainUSBAddressRelease(priv->usbaddrs, &disk->info);
812
    VIR_FREE(devstr);
813
    VIR_FREE(drivealias);
814
    VIR_FREE(drivestr);
815 816
    virObjectUnref(cfg);
    return ret;
817

818
 exit_monitor:
819 820 821 822 823
    orig_err = virSaveLastError();
    if (driveAdded && qemuMonitorDriveDel(priv->mon, drivealias) < 0) {
        VIR_WARN("Unable to remove drive %s (%s) after failed "
                 "qemuMonitorAddDevice", drivealias, drivestr);
    }
824
    ignore_value(qemuDomainObjExitMonitor(driver, vm));
825 826 827
    if (orig_err) {
        virSetError(orig_err);
        virFreeError(orig_err);
828 829 830 831
    }

    virDomainAuditDisk(vm, NULL, disk->src, "attach", false);

832
 error:
833
    ignore_value(qemuDomainPrepareDisk(driver, vm, disk, NULL, true));
834
    goto cleanup;
835 836 837
}


838 839 840 841 842 843
int
qemuDomainAttachDeviceDiskLive(virConnectPtr conn,
                               virQEMUDriverPtr driver,
                               virDomainObjPtr vm,
                               virDomainDeviceDefPtr dev)
{
844
    size_t i;
845 846 847
    virDomainDiskDefPtr disk = dev->data.disk;
    virDomainDiskDefPtr orig_disk = NULL;
    int ret = -1;
848
    const char *src = virDomainDiskGetSource(disk);
849

850
    if (STRNEQ_NULLABLE(virDomainDiskGetDriver(disk), "qemu")) {
851 852
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                       _("unsupported driver name '%s' for disk '%s'"),
853
                       virDomainDiskGetDriver(disk), src);
854
        goto cleanup;
855 856
    }

857
    if (virStorageTranslateDiskSourcePool(conn, disk) < 0)
858
        goto cleanup;
859 860

    if (qemuAddSharedDevice(driver, dev, vm->def->name) < 0)
861
        goto cleanup;
862 863

    if (qemuSetUnprivSGIO(dev) < 0)
864
        goto cleanup;
865

866
    if (qemuDomainDetermineDiskChain(driver, vm, disk, false, true) < 0)
867
        goto cleanup;
868

869
    switch ((virDomainDiskDevice) disk->device)  {
870 871 872 873 874
    case VIR_DOMAIN_DISK_DEVICE_CDROM:
    case VIR_DOMAIN_DISK_DEVICE_FLOPPY:
        if (!(orig_disk = virDomainDiskFindByBusAndDst(vm->def,
                                                       disk->bus, disk->dst))) {
            virReportError(VIR_ERR_INTERNAL_ERROR,
875 876 877
                           _("No device with bus '%s' and target '%s'. "
                             "cdrom and floppy device hotplug isn't supported "
                             "by libvirt"),
878 879
                           virDomainDiskBusTypeToString(disk->bus),
                           disk->dst);
880
            goto cleanup;
881 882
        }

883
        if (qemuDomainChangeEjectableMedia(driver, vm, orig_disk,
884
                                           disk->src, false) < 0)
885
            goto cleanup;
886

887
        disk->src = NULL;
888
        ret = 0;
889
        break;
890

891 892
    case VIR_DOMAIN_DISK_DEVICE_DISK:
    case VIR_DOMAIN_DISK_DEVICE_LUN:
893
        for (i = 0; i < vm->def->ndisks; i++) {
894 895
            if (virDomainDiskDefCheckDuplicateInfo(vm->def->disks[i], disk) < 0)
                goto cleanup;
896 897
        }

898 899
        switch ((virDomainDiskBus) disk->bus) {
        case VIR_DOMAIN_DISK_BUS_USB:
900 901 902 903 904
            if (disk->device == VIR_DOMAIN_DISK_DEVICE_LUN) {
                virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                               _("disk device='lun' is not supported for usb bus"));
                break;
            }
905
            ret = qemuDomainAttachUSBMassStorageDevice(driver, vm, disk);
906 907 908
            break;

        case VIR_DOMAIN_DISK_BUS_VIRTIO:
909
            ret = qemuDomainAttachVirtioDiskDevice(conn, driver, vm, disk);
910 911 912
            break;

        case VIR_DOMAIN_DISK_BUS_SCSI:
913
            ret = qemuDomainAttachSCSIDisk(conn, driver, vm, disk);
914 915 916 917 918 919 920 921 922
            break;

        case VIR_DOMAIN_DISK_BUS_IDE:
        case VIR_DOMAIN_DISK_BUS_FDC:
        case VIR_DOMAIN_DISK_BUS_XEN:
        case VIR_DOMAIN_DISK_BUS_UML:
        case VIR_DOMAIN_DISK_BUS_SATA:
        case VIR_DOMAIN_DISK_BUS_SD:
        case VIR_DOMAIN_DISK_BUS_LAST:
923 924 925 926 927
            virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
                           _("disk bus '%s' cannot be hotplugged."),
                           virDomainDiskBusTypeToString(disk->bus));
        }
        break;
928 929

    case VIR_DOMAIN_DISK_DEVICE_LAST:
930 931 932
        break;
    }

933
 cleanup:
934 935 936 937 938 939
    if (ret != 0)
        ignore_value(qemuRemoveSharedDevice(driver, dev, vm->def->name));
    return ret;
}


940 941 942 943
int
qemuDomainAttachNetDevice(virQEMUDriverPtr driver,
                          virDomainObjPtr vm,
                          virDomainNetDefPtr net)
944 945
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
946
    virDomainDeviceDef dev = { VIR_DOMAIN_DEVICE_NET, { .net = net } };
947
    virErrorPtr originalError = NULL;
948 949
    char **tapfdName = NULL;
    int *tapfd = NULL;
950
    size_t tapfdSize = 0;
951 952
    char **vhostfdName = NULL;
    int *vhostfd = NULL;
953
    size_t vhostfdSize = 0;
954
    size_t queueSize = 0;
955 956
    char *nicstr = NULL;
    char *netstr = NULL;
A
Ansis Atteka 已提交
957
    virNetDevVPortProfilePtr vport = NULL;
958 959
    int ret = -1;
    int vlan;
960
    bool releaseaddr = false;
961
    bool iface_connected = false;
962
    virDomainNetType actualType;
963
    virNetDevBandwidthPtr actualBandwidth;
964
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
965
    virDomainCCWAddressSetPtr ccwaddrs = NULL;
966
    size_t i;
967 968 969 970
    char *charDevAlias = NULL;
    bool charDevPlugged = false;
    bool netdevPlugged = false;
    bool hostPlugged = false;
971
    unsigned int mtu = net->mtu;
972

973
    /* preallocate new slot for device */
974
    if (VIR_REALLOC_N(vm->def->nets, vm->def->nnets + 1) < 0)
975
        goto cleanup;
976

977 978 979 980
    /* If appropriate, grab a physical device from the configured
     * network's pool of devices, or resolve bridge device name
     * to the one defined in the network definition.
     */
981
    if (networkAllocateActualDevice(vm->def, net) < 0)
982
        goto cleanup;
983 984

    actualType = virDomainNetGetActualType(net);
985

986
    /* Currently only TAP/macvtap devices supports multiqueue. */
987 988
    if (net->driver.virtio.queues > 0 &&
        !(actualType == VIR_DOMAIN_NET_TYPE_NETWORK ||
989
          actualType == VIR_DOMAIN_NET_TYPE_BRIDGE ||
990
          actualType == VIR_DOMAIN_NET_TYPE_DIRECT ||
991 992
          actualType == VIR_DOMAIN_NET_TYPE_ETHERNET ||
          actualType == VIR_DOMAIN_NET_TYPE_VHOSTUSER)) {
993 994 995 996 997 998
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                       _("Multiqueue network is not supported for: %s"),
                       virDomainNetTypeToString(actualType));
        return -1;
    }

999 1000 1001
    /* and only TAP devices support nwfilter rules */
    if (net->filter &&
        !(actualType == VIR_DOMAIN_NET_TYPE_NETWORK ||
1002 1003
          actualType == VIR_DOMAIN_NET_TYPE_BRIDGE ||
          actualType == VIR_DOMAIN_NET_TYPE_ETHERNET)) {
1004 1005 1006 1007 1008 1009 1010
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                       _("filterref is not supported for "
                         "network interfaces of type %s"),
                       virDomainNetTypeToString(actualType));
        return -1;
    }

1011 1012 1013
    if (qemuAssignDeviceNetAlias(vm->def, net, -1) < 0)
        goto cleanup;

1014 1015 1016
    switch (actualType) {
    case VIR_DOMAIN_NET_TYPE_BRIDGE:
    case VIR_DOMAIN_NET_TYPE_NETWORK:
1017 1018 1019
        tapfdSize = vhostfdSize = net->driver.virtio.queues;
        if (!tapfdSize)
            tapfdSize = vhostfdSize = 1;
1020
        queueSize = tapfdSize;
1021
        if (VIR_ALLOC_N(tapfd, tapfdSize) < 0)
1022
            goto cleanup;
1023 1024 1025 1026
        memset(tapfd, -1, sizeof(*tapfd) * tapfdSize);
        if (VIR_ALLOC_N(vhostfd, vhostfdSize) < 0)
            goto cleanup;
        memset(vhostfd, -1, sizeof(*vhostfd) * vhostfdSize);
1027
        if (qemuInterfaceBridgeConnect(vm->def, driver, net,
1028
                                       tapfd, &tapfdSize, &mtu) < 0)
1029 1030
            goto cleanup;
        iface_connected = true;
1031 1032
        if (qemuInterfaceOpenVhostNet(vm->def, net, priv->qemuCaps,
                                      vhostfd, &vhostfdSize) < 0)
1033
            goto cleanup;
1034 1035 1036
        break;

    case VIR_DOMAIN_NET_TYPE_DIRECT:
1037 1038 1039
        tapfdSize = vhostfdSize = net->driver.virtio.queues;
        if (!tapfdSize)
            tapfdSize = vhostfdSize = 1;
1040
        queueSize = tapfdSize;
1041
        if (VIR_ALLOC_N(tapfd, tapfdSize) < 0)
1042
            goto cleanup;
1043 1044
        memset(tapfd, -1, sizeof(*tapfd) * tapfdSize);
        if (VIR_ALLOC_N(vhostfd, vhostfdSize) < 0)
1045
            goto cleanup;
1046
        memset(vhostfd, -1, sizeof(*vhostfd) * vhostfdSize);
1047 1048 1049
        if (qemuInterfaceDirectConnect(vm->def, driver, net,
                                       tapfd, tapfdSize,
                                       VIR_NETDEV_VPORT_PROFILE_OP_CREATE) < 0)
1050 1051
            goto cleanup;
        iface_connected = true;
1052 1053
        if (qemuInterfaceOpenVhostNet(vm->def, net, priv->qemuCaps,
                                      vhostfd, &vhostfdSize) < 0)
1054
            goto cleanup;
1055 1056 1057
        break;

    case VIR_DOMAIN_NET_TYPE_ETHERNET:
1058 1059 1060
        tapfdSize = vhostfdSize = net->driver.virtio.queues;
        if (!tapfdSize)
            tapfdSize = vhostfdSize = 1;
1061
        queueSize = tapfdSize;
1062
        if (VIR_ALLOC_N(tapfd, tapfdSize) < 0)
1063
            goto cleanup;
1064 1065 1066 1067 1068
        memset(tapfd, -1, sizeof(*tapfd) * tapfdSize);
        if (VIR_ALLOC_N(vhostfd, vhostfdSize) < 0)
            goto cleanup;
        memset(vhostfd, -1, sizeof(*vhostfd) * vhostfdSize);
        if (qemuInterfaceEthernetConnect(vm->def, driver, net,
1069
                                         tapfd, tapfdSize) < 0)
1070 1071
            goto cleanup;
        iface_connected = true;
1072 1073
        if (qemuInterfaceOpenVhostNet(vm->def, net, priv->qemuCaps,
                                      vhostfd, &vhostfdSize) < 0)
1074
            goto cleanup;
1075 1076 1077
        break;

    case VIR_DOMAIN_NET_TYPE_HOSTDEV:
1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088
        /* This is really a "smart hostdev", so it should be attached
         * as a hostdev (the hostdev code will reach over into the
         * netdev-specific code as appropriate), then also added to
         * the nets list (see cleanup:) if successful.
         *
         * qemuDomainAttachHostDevice uses a connection to resolve
         * a SCSI hostdev secret, which is not this case, so pass NULL.
         */
        ret = qemuDomainAttachHostDevice(NULL, driver, vm,
                                         virDomainNetGetActualHostdev(net));
        goto cleanup;
1089 1090 1091
        break;

    case VIR_DOMAIN_NET_TYPE_VHOSTUSER:
1092 1093 1094
        queueSize = net->driver.virtio.queues;
        if (!queueSize)
            queueSize = 1;
1095 1096 1097 1098 1099 1100
        if (!qemuDomainSupportsNetdev(vm->def, priv->qemuCaps, net)) {
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           "%s", _("Netdev support unavailable"));
            goto cleanup;
        }

1101
        if (!(charDevAlias = qemuAliasChardevFromDevAlias(net->info.alias)))
1102 1103 1104 1105
            goto cleanup;
        break;

    case VIR_DOMAIN_NET_TYPE_USER:
1106 1107 1108
        /* No preparation needed. */
        break;

1109 1110 1111 1112 1113 1114 1115 1116 1117 1118
    case VIR_DOMAIN_NET_TYPE_SERVER:
    case VIR_DOMAIN_NET_TYPE_CLIENT:
    case VIR_DOMAIN_NET_TYPE_MCAST:
    case VIR_DOMAIN_NET_TYPE_INTERNAL:
    case VIR_DOMAIN_NET_TYPE_UDP:
    case VIR_DOMAIN_NET_TYPE_LAST:
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
                       _("hotplug of interface type of %s is not implemented yet"),
                       virDomainNetTypeToString(actualType));
        goto cleanup;
1119 1120
    }

1121 1122
    /* Set device online immediately */
    if (qemuInterfaceStartDevice(net) < 0)
1123
        goto cleanup;
1124

1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136
    /* Set bandwidth or warn if requested and not supported. */
    actualBandwidth = virDomainNetGetActualBandwidth(net);
    if (actualBandwidth) {
        if (virNetDevSupportBandwidth(actualType)) {
            if (virNetDevBandwidthSet(net->ifname, actualBandwidth, false) < 0)
                goto cleanup;
        } else {
            VIR_WARN("setting bandwidth on interfaces of "
                     "type '%s' is not implemented yet",
                     virDomainNetTypeToString(actualType));
        }
    }
1137

M
Michal Privoznik 已提交
1138
    for (i = 0; i < tapfdSize; i++) {
1139 1140
        if (qemuSecuritySetTapFDLabel(driver->securityManager,
                                      vm->def, tapfd[i]) < 0)
M
Michal Privoznik 已提交
1141 1142 1143
            goto cleanup;
    }

1144
    if (qemuDomainIsS390CCW(vm->def) &&
1145 1146
        virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_VIRTIO_CCW)) {
        net->info.type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW;
1147 1148 1149
        if (!(ccwaddrs = qemuDomainCCWAddrSetCreateFromDomain(vm->def)))
            goto cleanup;
        if (virDomainCCWAddressAssign(&net->info, ccwaddrs,
J
Ján Tomko 已提交
1150
                                      !net->info.addr.ccw.assigned) < 0)
1151
            goto cleanup;
1152
    } else if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_VIRTIO_S390)) {
1153
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
1154 1155
                       _("virtio-s390 net device cannot be hotplugged."));
        goto cleanup;
1156
    } else if (qemuDomainEnsurePCIAddress(vm, &dev, driver) < 0) {
1157 1158
        goto cleanup;
    }
1159

1160 1161
    releaseaddr = true;

1162
    if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_NETDEV)) {
1163 1164 1165 1166 1167
        vlan = -1;
    } else {
        vlan = qemuDomainNetVLAN(net);

        if (vlan < 0) {
1168 1169
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                           _("Unable to attach network devices without vlan"));
1170 1171 1172 1173
            goto cleanup;
        }
    }

1174
    if (VIR_ALLOC_N(tapfdName, tapfdSize) < 0 ||
1175
        VIR_ALLOC_N(vhostfdName, vhostfdSize) < 0)
1176 1177 1178
        goto cleanup;

    for (i = 0; i < tapfdSize; i++) {
1179
        if (virAsprintf(&tapfdName[i], "fd-%s%zu", net->info.alias, i) < 0)
1180
            goto cleanup;
1181 1182
    }

1183
    for (i = 0; i < vhostfdSize; i++) {
1184
        if (virAsprintf(&vhostfdName[i], "vhostfd-%s%zu", net->info.alias, i) < 0)
1185
            goto cleanup;
1186 1187
    }

1188
    if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_NETDEV)) {
1189
        if (!(netstr = qemuBuildHostNetStr(net, driver,
1190 1191 1192
                                           ',', -1,
                                           tapfdName, tapfdSize,
                                           vhostfdName, vhostfdSize)))
1193
            goto cleanup;
1194
    } else {
1195
        if (!(netstr = qemuBuildHostNetStr(net, driver,
1196 1197 1198
                                           ' ', vlan,
                                           tapfdName, tapfdSize,
                                           vhostfdName, vhostfdSize)))
1199
            goto cleanup;
1200 1201
    }

1202
    qemuDomainObjEnterMonitor(driver, vm);
1203 1204 1205 1206 1207 1208 1209 1210 1211 1212

    if (actualType == VIR_DOMAIN_NET_TYPE_VHOSTUSER) {
        if (qemuMonitorAttachCharDev(priv->mon, charDevAlias, net->data.vhostuser) < 0) {
            ignore_value(qemuDomainObjExitMonitor(driver, vm));
            virDomainAuditNet(vm, NULL, net, "attach", false);
            goto cleanup;
        }
        charDevPlugged = true;
    }

1213
    if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_NETDEV)) {
1214 1215 1216
        if (qemuMonitorAddNetdev(priv->mon, netstr,
                                 tapfd, tapfdName, tapfdSize,
                                 vhostfd, vhostfdName, vhostfdSize) < 0) {
1217
            ignore_value(qemuDomainObjExitMonitor(driver, vm));
1218
            virDomainAuditNet(vm, NULL, net, "attach", false);
1219
            goto try_remove;
1220
        }
1221
        netdevPlugged = true;
1222
    } else {
1223 1224 1225
        if (qemuMonitorAddHostNetwork(priv->mon, netstr,
                                      tapfd, tapfdName, tapfdSize,
                                      vhostfd, vhostfdName, vhostfdSize) < 0) {
1226
            ignore_value(qemuDomainObjExitMonitor(driver, vm));
1227
            virDomainAuditNet(vm, NULL, net, "attach", false);
1228
            goto try_remove;
1229
        }
1230
        hostPlugged = true;
1231
    }
1232

1233 1234
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        goto cleanup;
1235

1236 1237 1238 1239
    for (i = 0; i < tapfdSize; i++)
        VIR_FORCE_CLOSE(tapfd[i]);
    for (i = 0; i < vhostfdSize; i++)
        VIR_FORCE_CLOSE(vhostfd[i]);
1240

1241
    if (!(nicstr = qemuBuildNicDevStr(vm->def, net, vlan, 0,
1242
                                      queueSize, priv->qemuCaps, mtu)))
1243
        goto try_remove;
1244

1245
    qemuDomainObjEnterMonitor(driver, vm);
1246 1247 1248 1249
    if (qemuMonitorAddDevice(priv->mon, nicstr) < 0) {
        ignore_value(qemuDomainObjExitMonitor(driver, vm));
        virDomainAuditNet(vm, NULL, net, "attach", false);
        goto try_remove;
1250
    }
1251 1252
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        goto cleanup;
1253

1254 1255 1256
    /* set link state */
    if (net->linkstate == VIR_DOMAIN_NET_INTERFACE_LINK_STATE_DOWN) {
        if (!net->info.alias) {
1257 1258
            virReportError(VIR_ERR_OPERATION_FAILED, "%s",
                           _("device alias not found: cannot set link state to down"));
1259
        } else {
1260
            qemuDomainObjEnterMonitor(driver, vm);
1261

1262
            if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_NETDEV)) {
1263
                if (qemuMonitorSetLink(priv->mon, net->info.alias, VIR_DOMAIN_NET_INTERFACE_LINK_STATE_DOWN) < 0) {
1264
                    ignore_value(qemuDomainObjExitMonitor(driver, vm));
1265 1266 1267 1268
                    virDomainAuditNet(vm, NULL, net, "attach", false);
                    goto try_remove;
                }
            } else {
1269
                virReportError(VIR_ERR_OPERATION_FAILED, "%s",
1270
                               _("setting of link state not supported: Link is up"));
1271 1272
            }

1273 1274
            if (qemuDomainObjExitMonitor(driver, vm) < 0)
                goto cleanup;
1275 1276 1277 1278
        }
        /* link set to down */
    }

1279
    virDomainAuditNet(vm, NULL, net, "attach", true);
1280 1281 1282

    ret = 0;

1283
 cleanup:
1284 1285 1286
    if (!ret) {
        vm->def->nets[vm->def->nnets++] = net;
    } else {
1287 1288
        if (releaseaddr)
            qemuDomainReleaseDeviceAddress(vm, &net->info, NULL);
1289

1290
        if (iface_connected) {
1291
            virDomainConfNWFilterTeardown(net);
1292

1293 1294 1295 1296 1297 1298 1299 1300 1301
            if (virDomainNetGetActualType(net) == VIR_DOMAIN_NET_TYPE_DIRECT) {
                ignore_value(virNetDevMacVLanDeleteWithVPortProfile(
                                 net->ifname, &net->mac,
                                 virDomainNetGetActualDirectDev(net),
                                 virDomainNetGetActualDirectMode(net),
                                 virDomainNetGetActualVirtPortProfile(net),
                                 cfg->stateDir));
            }

1302
            vport = virDomainNetGetActualVirtPortProfile(net);
1303 1304 1305 1306 1307 1308 1309 1310 1311
            if (vport) {
                if (vport->virtPortType == VIR_NETDEV_VPORT_PROFILE_MIDONET) {
                    ignore_value(virNetDevMidonetUnbindPort(vport));
                } else if (vport->virtPortType == VIR_NETDEV_VPORT_PROFILE_OPENVSWITCH) {
                    ignore_value(virNetDevOpenvswitchRemovePort(
                                     virDomainNetGetActualBridgeName(net),
                                     net->ifname));
                }
            }
1312
        }
A
Ansis Atteka 已提交
1313

1314 1315
        virDomainNetRemoveHostdev(vm->def, net);

1316
        networkReleaseActualDevice(vm->def, net);
1317
    }
1318 1319 1320

    VIR_FREE(nicstr);
    VIR_FREE(netstr);
1321
    for (i = 0; tapfd && i < tapfdSize; i++) {
1322
        VIR_FORCE_CLOSE(tapfd[i]);
1323 1324
        if (tapfdName)
            VIR_FREE(tapfdName[i]);
1325 1326 1327
    }
    VIR_FREE(tapfd);
    VIR_FREE(tapfdName);
1328
    for (i = 0; vhostfd && i < vhostfdSize; i++) {
1329
        VIR_FORCE_CLOSE(vhostfd[i]);
1330 1331
        if (vhostfdName)
            VIR_FREE(vhostfdName[i]);
1332 1333 1334
    }
    VIR_FREE(vhostfd);
    VIR_FREE(vhostfdName);
1335
    VIR_FREE(charDevAlias);
1336
    virObjectUnref(cfg);
1337
    virDomainCCWAddressSetFree(ccwaddrs);
1338 1339 1340

    return ret;

1341
 try_remove:
1342 1343 1344
    if (!virDomainObjIsActive(vm))
        goto cleanup;

1345
    originalError = virSaveLastError();
1346
    if (vlan < 0) {
1347
        if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_NETDEV)) {
1348
            char *netdev_name;
1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360
            if (virAsprintf(&netdev_name, "host%s", net->info.alias) >= 0) {
                qemuDomainObjEnterMonitor(driver, vm);
                if (charDevPlugged &&
                    qemuMonitorDetachCharDev(priv->mon, charDevAlias) < 0)
                    VIR_WARN("Failed to remove associated chardev %s", charDevAlias);
                if (netdevPlugged &&
                    qemuMonitorRemoveNetdev(priv->mon, netdev_name) < 0)
                    VIR_WARN("Failed to remove network backend for netdev %s",
                             netdev_name);
                ignore_value(qemuDomainObjExitMonitor(driver, vm));
                VIR_FREE(netdev_name);
            }
1361
        } else {
1362
            VIR_WARN("Unable to remove network backend");
1363 1364 1365
        }
    } else {
        char *hostnet_name;
1366 1367 1368 1369 1370 1371 1372 1373 1374
        if (virAsprintf(&hostnet_name, "host%s", net->info.alias) >= 0) {
            qemuDomainObjEnterMonitor(driver, vm);
            if (hostPlugged &&
                qemuMonitorRemoveHostNetwork(priv->mon, vlan, hostnet_name) < 0)
                VIR_WARN("Failed to remove network backend for vlan %d, net %s",
                         vlan, hostnet_name);
            ignore_value(qemuDomainObjExitMonitor(driver, vm));
            VIR_FREE(hostnet_name);
        }
1375
    }
1376 1377
    virSetError(originalError);
    virFreeError(originalError);
1378 1379 1380 1381
    goto cleanup;
}


1382
static int
1383
qemuDomainAttachHostPCIDevice(virQEMUDriverPtr driver,
1384 1385
                              virDomainObjPtr vm,
                              virDomainHostdevDefPtr hostdev)
1386 1387
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
1388 1389
    virDomainDeviceDef dev = { VIR_DOMAIN_DEVICE_HOSTDEV,
                               { .hostdev = hostdev } };
1390 1391 1392 1393
    int ret;
    char *devstr = NULL;
    int configfd = -1;
    char *configfd_name = NULL;
1394
    bool releaseaddr = false;
1395
    bool teardowncgroup = false;
1396
    bool teardownlabel = false;
1397
    bool teardowndevice = false;
1398
    int backend;
1399 1400
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
    unsigned int flags = 0;
1401

1402
    if (VIR_REALLOC_N(vm->def->hostdevs, vm->def->nhostdevs + 1) < 0)
1403
        goto cleanup;
1404

1405 1406
    if (!cfg->relaxedACS)
        flags |= VIR_HOSTDEV_STRICT_ACS_CHECK;
1407
    if (qemuHostdevPreparePCIDevices(driver, vm->def->name, vm->def->uuid,
1408 1409
                                     &hostdev, 1, priv->qemuCaps, flags) < 0)
        goto cleanup;
1410

1411
    /* this could have been changed by qemuHostdevPreparePCIDevices */
1412 1413
    backend = hostdev->source.subsys.u.pci.backend;

1414
    switch ((virDomainHostdevSubsysPCIBackendType) backend) {
1415
    case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO:
1416 1417 1418 1419 1420 1421
        if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DEVICE_VFIO_PCI)) {
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                           _("VFIO PCI device assignment is not "
                             "supported by this version of qemu"));
            goto error;
        }
1422 1423
        break;

1424 1425 1426 1427 1428 1429 1430 1431 1432 1433
    case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT:
    case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_KVM:
        break;

    case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_XEN:
    case VIR_DOMAIN_HOSTDEV_PCI_BACKEND_TYPE_LAST:
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                       _("QEMU does not support device assignment mode '%s'"),
                       virDomainHostdevSubsysPCIBackendTypeToString(backend));
        goto error;
1434
        break;
1435 1436
    }

1437
    /* Temporarily add the hostdev to the domain definition. This is needed
1438 1439 1440 1441
     * because qemuDomainAdjustMaxMemLock() requires the hostdev to be already
     * part of the domain definition, but other functions like
     * qemuAssignDeviceHostdevAlias() used below expect it *not* to be there.
     * A better way to handle this would be nice */
1442
    vm->def->hostdevs[vm->def->nhostdevs++] = hostdev;
1443 1444 1445
    if (qemuDomainAdjustMaxMemLock(vm) < 0) {
        vm->def->hostdevs[--(vm->def->nhostdevs)] = NULL;
        goto error;
1446 1447 1448
    }
    vm->def->hostdevs[--(vm->def->nhostdevs)] = NULL;

1449 1450 1451 1452
    if (qemuDomainNamespaceSetupHostdev(driver, vm, hostdev) < 0)
        goto error;
    teardowndevice = true;

1453
    if (qemuSetupHostdevCgroup(vm, hostdev) < 0)
1454 1455 1456
        goto error;
    teardowncgroup = true;

1457
    if (qemuSecuritySetHostdevLabel(driver, vm, hostdev) < 0)
1458
        goto error;
1459 1460
    if (backend != VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO)
        teardownlabel = true;
1461

1462 1463
    if (qemuAssignDeviceHostdevAlias(vm->def, &hostdev->info->alias, -1) < 0)
        goto error;
1464
    if (qemuDomainEnsurePCIAddress(vm, &dev, driver) < 0)
1465 1466 1467 1468 1469 1470 1471 1472 1473
        goto error;
    releaseaddr = true;
    if (backend != VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO &&
        virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_PCI_CONFIGFD)) {
        configfd = qemuOpenPCIConfig(hostdev);
        if (configfd >= 0) {
            if (virAsprintf(&configfd_name, "fd-%s",
                            hostdev->info->alias) < 0)
                goto error;
1474
        }
1475
    }
1476

1477 1478 1479 1480 1481
    if (!virDomainObjIsActive(vm)) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("guest unexpectedly quit during hotplug"));
        goto error;
    }
1482

1483 1484 1485
    if (!(devstr = qemuBuildPCIHostdevDevStr(vm->def, hostdev, 0,
                                             configfd_name, priv->qemuCaps)))
        goto error;
1486

1487 1488 1489 1490 1491
    qemuDomainObjEnterMonitor(driver, vm);
    ret = qemuMonitorAddDeviceWithFd(priv->mon, devstr,
                                     configfd, configfd_name);
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        goto error;
1492

1493
    virDomainAuditHostdev(vm, hostdev, "attach", ret == 0);
1494 1495 1496 1497 1498 1499 1500 1501
    if (ret < 0)
        goto error;

    vm->def->hostdevs[vm->def->nhostdevs++] = hostdev;

    VIR_FREE(devstr);
    VIR_FREE(configfd_name);
    VIR_FORCE_CLOSE(configfd);
1502
    virObjectUnref(cfg);
1503 1504 1505

    return 0;

1506
 error:
1507 1508
    if (teardowncgroup && qemuTeardownHostdevCgroup(vm, hostdev) < 0)
        VIR_WARN("Unable to remove host device cgroup ACL on hotplug fail");
1509
    if (teardownlabel &&
1510
        qemuSecurityRestoreHostdevLabel(driver, vm, hostdev) < 0)
1511
        VIR_WARN("Unable to restore host device labelling on hotplug fail");
1512 1513 1514
    if (teardowndevice &&
        qemuDomainNamespaceTeardownHostdev(driver, vm, hostdev) < 0)
        VIR_WARN("Unable to remove host device from /dev");
1515

1516 1517
    if (releaseaddr)
        qemuDomainReleaseDeviceAddress(vm, hostdev->info, NULL);
1518

1519
    qemuHostdevReAttachPCIDevices(driver, vm->def->name, &hostdev, 1);
1520 1521 1522 1523 1524

    VIR_FREE(devstr);
    VIR_FREE(configfd_name);
    VIR_FORCE_CLOSE(configfd);

1525
 cleanup:
1526
    virObjectUnref(cfg);
1527 1528 1529 1530
    return -1;
}


1531 1532 1533
void
qemuDomainDelTLSObjects(virQEMUDriverPtr driver,
                        virDomainObjPtr vm,
1534
                        qemuDomainAsyncJob asyncJob,
1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545
                        const char *secAlias,
                        const char *tlsAlias)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    virErrorPtr orig_err;

    if (!tlsAlias && !secAlias)
        return;

    orig_err = virSaveLastError();

1546 1547
    if (qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) < 0)
        goto cleanup;
1548 1549 1550 1551 1552 1553 1554 1555 1556

    if (tlsAlias)
        ignore_value(qemuMonitorDelObject(priv->mon, tlsAlias));

    if (secAlias)
        ignore_value(qemuMonitorDelObject(priv->mon, secAlias));

    ignore_value(qemuDomainObjExitMonitor(driver, vm));

1557
 cleanup:
1558 1559 1560 1561 1562 1563 1564 1565 1566 1567
    if (orig_err) {
        virSetError(orig_err);
        virFreeError(orig_err);
    }
}


int
qemuDomainAddTLSObjects(virQEMUDriverPtr driver,
                        virDomainObjPtr vm,
1568
                        qemuDomainAsyncJob asyncJob,
1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580
                        const char *secAlias,
                        virJSONValuePtr *secProps,
                        const char *tlsAlias,
                        virJSONValuePtr *tlsProps)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int rc;
    virErrorPtr orig_err;

    if (!tlsAlias && !secAlias)
        return 0;

1581 1582
    if (qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) < 0)
        return -1;
1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608

    if (secAlias) {
        rc = qemuMonitorAddObject(priv->mon, "secret",
                                  secAlias, *secProps);
        *secProps = NULL; /* qemuMonitorAddObject consumes */
        if (rc < 0)
            goto error;
    }

    if (tlsAlias) {
        rc = qemuMonitorAddObject(priv->mon, "tls-creds-x509",
                                  tlsAlias, *tlsProps);
        *tlsProps = NULL; /* qemuMonitorAddObject consumes */
        if (rc < 0)
            goto error;
    }

    return qemuDomainObjExitMonitor(driver, vm);

 error:
    orig_err = virSaveLastError();
    ignore_value(qemuDomainObjExitMonitor(driver, vm));
    if (orig_err) {
        virSetError(orig_err);
        virFreeError(orig_err);
    }
1609
    qemuDomainDelTLSObjects(driver, vm, asyncJob, secAlias, tlsAlias);
1610 1611 1612 1613 1614

    return -1;
}


1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625
int
qemuDomainGetTLSObjects(virQEMUCapsPtr qemuCaps,
                        qemuDomainSecretInfoPtr secinfo,
                        const char *tlsCertdir,
                        bool tlsListen,
                        bool tlsVerify,
                        const char *srcAlias,
                        virJSONValuePtr *tlsProps,
                        char **tlsAlias,
                        virJSONValuePtr *secProps,
                        char **secAlias)
1626
{
1627 1628
    /* Add a secret object in order to access the TLS environment.
     * The secinfo will only be created for serial TCP device. */
1629 1630
    if (secinfo) {
        if (qemuBuildSecretInfoProps(secinfo, secProps) < 0)
1631 1632
            return -1;

1633
        if (!(*secAlias = qemuDomainGetSecretAESAlias(srcAlias, false)))
1634 1635 1636
            return -1;
    }

1637 1638
    if (qemuBuildTLSx509BackendProps(tlsCertdir, tlsListen, tlsVerify,
                                     *secAlias, qemuCaps, tlsProps) < 0)
1639 1640
        return -1;

1641
    if (!(*tlsAlias = qemuAliasTLSObjFromSrcAlias(srcAlias)))
1642 1643 1644 1645 1646 1647
        return -1;

    return 0;
}


1648
static int
1649 1650
qemuDomainAddChardevTLSObjects(virConnectPtr conn,
                               virQEMUDriverPtr driver,
1651 1652
                               virDomainObjPtr vm,
                               virDomainChrSourceDefPtr dev,
1653
                               char *devAlias,
1654 1655 1656 1657 1658
                               char *charAlias,
                               char **tlsAlias,
                               char **secAlias)
{
    int ret = -1;
1659
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
1660
    qemuDomainObjPrivatePtr priv = vm->privateData;
1661 1662
    qemuDomainChrSourcePrivatePtr chrSourcePriv;
    qemuDomainSecretInfoPtr secinfo = NULL;
1663 1664 1665
    virJSONValuePtr tlsProps = NULL;
    virJSONValuePtr secProps = NULL;

1666 1667 1668
    /* NB: This may alter haveTLS based on cfg */
    qemuDomainPrepareChardevSourceTLS(dev, cfg);

1669
    if (dev->type != VIR_DOMAIN_CHR_TYPE_TCP ||
1670 1671 1672 1673
        dev->data.tcp.haveTLS != VIR_TRISTATE_BOOL_YES) {
        ret = 0;
        goto cleanup;
    }
1674

1675 1676 1677
    if (qemuDomainSecretChardevPrepare(conn, cfg, priv, devAlias, dev) < 0)
        goto cleanup;

1678 1679 1680 1681 1682 1683 1684 1685 1686
    if ((chrSourcePriv = QEMU_DOMAIN_CHR_SOURCE_PRIVATE(dev)))
        secinfo = chrSourcePriv->secinfo;

    if (qemuDomainGetTLSObjects(priv->qemuCaps, secinfo,
                                cfg->chardevTLSx509certdir,
                                dev->data.tcp.listen,
                                cfg->chardevTLSx509verify,
                                charAlias, &tlsProps, tlsAlias,
                                &secProps, secAlias) < 0)
1687
        goto cleanup;
1688
    dev->data.tcp.tlscreds = true;
1689

1690 1691
    if (qemuDomainAddTLSObjects(driver, vm, QEMU_ASYNC_JOB_NONE,
                                *secAlias, &secProps, *tlsAlias, &tlsProps) < 0)
1692 1693 1694 1695 1696 1697 1698
        goto cleanup;

    ret = 0;

 cleanup:
    virJSONValueFree(tlsProps);
    virJSONValueFree(secProps);
1699
    virObjectUnref(cfg);
1700 1701 1702 1703 1704

    return ret;
}


1705 1706
int qemuDomainAttachRedirdevDevice(virConnectPtr conn,
                                   virQEMUDriverPtr driver,
1707 1708 1709
                                   virDomainObjPtr vm,
                                   virDomainRedirdevDefPtr redirdev)
{
1710
    int ret = -1;
1711
    int rc;
1712
    qemuDomainObjPrivatePtr priv = vm->privateData;
1713
    virDomainDefPtr def = vm->def;
1714
    char *charAlias = NULL;
1715
    char *devstr = NULL;
1716
    bool chardevAdded = false;
1717
    char *tlsAlias = NULL;
1718
    char *secAlias = NULL;
1719
    bool need_release = false;
1720
    virErrorPtr orig_err;
1721

1722
    if (qemuAssignDeviceRedirdevAlias(def, redirdev, -1) < 0)
1723 1724
        goto cleanup;

1725
    if (!(charAlias = qemuAliasChardevFromDevAlias(redirdev->info.alias)))
1726 1727
        goto cleanup;

1728 1729 1730 1731 1732
    if ((rc = virDomainUSBAddressEnsure(priv->usbaddrs, &redirdev->info)) < 0)
        goto cleanup;
    if (rc == 1)
        need_release = true;

1733
    if (!(devstr = qemuBuildRedirdevDevStr(def, redirdev, priv->qemuCaps)))
1734
        goto cleanup;
1735

1736
    if (VIR_REALLOC_N(def->redirdevs, def->nredirdevs+1) < 0)
1737
        goto cleanup;
1738

1739
    if (qemuDomainAddChardevTLSObjects(conn, driver, vm, redirdev->source,
1740 1741
                                       redirdev->info.alias, charAlias,
                                       &tlsAlias, &secAlias) < 0)
1742
        goto audit;
1743

1744
    qemuDomainObjEnterMonitor(driver, vm);
1745

1746 1747
    if (qemuMonitorAttachCharDev(priv->mon,
                                 charAlias,
1748
                                 redirdev->source) < 0)
1749 1750
        goto exit_monitor;
    chardevAdded = true;
1751

1752 1753
    if (qemuMonitorAddDevice(priv->mon, devstr) < 0)
        goto exit_monitor;
1754

1755 1756
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        goto audit;
1757

1758
    def->redirdevs[def->nredirdevs++] = redirdev;
1759 1760 1761 1762
    ret = 0;
 audit:
    virDomainAuditRedirdev(vm, redirdev, "attach", ret == 0);
 cleanup:
1763 1764
    if (ret < 0 && need_release)
        qemuDomainReleaseDeviceAddress(vm, &redirdev->info, NULL);
1765
    VIR_FREE(tlsAlias);
1766
    VIR_FREE(secAlias);
1767
    VIR_FREE(charAlias);
1768
    VIR_FREE(devstr);
1769
    return ret;
1770 1771 1772 1773 1774 1775

 exit_monitor:
    orig_err = virSaveLastError();
    /* detach associated chardev on error */
    if (chardevAdded)
        ignore_value(qemuMonitorDetachCharDev(priv->mon, charAlias));
1776
    ignore_value(qemuDomainObjExitMonitor(driver, vm));
1777 1778 1779 1780
    if (orig_err) {
        virSetError(orig_err);
        virFreeError(orig_err);
    }
1781 1782
    qemuDomainDelTLSObjects(driver, vm, QEMU_ASYNC_JOB_NONE,
                            secAlias, tlsAlias);
1783
    goto audit;
1784 1785
}

1786 1787 1788
static int
qemuDomainChrPreInsert(virDomainDefPtr vmdef,
                       virDomainChrDefPtr chr)
1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802
{
    if (chr->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_CONSOLE &&
        chr->targetType == VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_SERIAL) {
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
                       _("attaching serial console is not supported"));
        return -1;
    }

    if (virDomainChrFind(vmdef, chr)) {
        virReportError(VIR_ERR_OPERATION_INVALID, "%s",
                       _("chardev already exists"));
        return -1;
    }

1803
    if (virDomainChrPreAlloc(vmdef, chr) < 0)
1804 1805 1806 1807 1808
        return -1;

    /* Due to some crazy backcompat stuff, the first serial device is an alias
     * to the first console too. If this is the case, the definition must be
     * duplicated as first console device. */
1809 1810 1811 1812 1813 1814 1815
    if (vmdef->nserials == 0 && vmdef->nconsoles == 0 &&
        chr->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_SERIAL) {
        if (!vmdef->consoles && VIR_ALLOC(vmdef->consoles) < 0)
            return -1;

        if (VIR_ALLOC(vmdef->consoles[0]) < 0) {
            VIR_FREE(vmdef->consoles);
1816 1817
            return -1;
        }
1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829
        vmdef->nconsoles++;
    }
    return 0;
}

static void
qemuDomainChrInsertPreAlloced(virDomainDefPtr vmdef,
                              virDomainChrDefPtr chr)
{
    virDomainChrInsertPreAlloced(vmdef, chr);
    if (vmdef->nserials == 1 && vmdef->nconsoles == 0 &&
        chr->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_SERIAL) {
1830 1831 1832 1833 1834 1835
        vmdef->nconsoles = 1;

        /* Create an console alias for the serial port */
        vmdef->consoles[0]->deviceType = VIR_DOMAIN_CHR_DEVICE_TYPE_CONSOLE;
        vmdef->consoles[0]->targetType = VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_SERIAL;
    }
1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849
}

static void
qemuDomainChrInsertPreAllocCleanup(virDomainDefPtr vmdef,
                                   virDomainChrDefPtr chr)
{
    /* Remove the stub console added by qemuDomainChrPreInsert */
    if (vmdef->nserials == 0 && vmdef->nconsoles == 1 &&
        chr->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_SERIAL) {
        VIR_FREE(vmdef->consoles[0]);
        VIR_FREE(vmdef->consoles);
        vmdef->nconsoles = 0;
    }
}
1850

1851 1852 1853 1854 1855 1856 1857 1858 1859
int
qemuDomainChrInsert(virDomainDefPtr vmdef,
                    virDomainChrDefPtr chr)
{
    if (qemuDomainChrPreInsert(vmdef, chr) < 0) {
        qemuDomainChrInsertPreAllocCleanup(vmdef, chr);
        return -1;
    }
    qemuDomainChrInsertPreAlloced(vmdef, chr);
1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879 1880 1881 1882 1883 1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895
    return 0;
}

virDomainChrDefPtr
qemuDomainChrRemove(virDomainDefPtr vmdef,
                    virDomainChrDefPtr chr)
{
    virDomainChrDefPtr ret;
    bool removeCompat;

    if (chr->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_CONSOLE &&
        chr->targetType == VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_SERIAL) {
        virReportError(VIR_ERR_OPERATION_INVALID, "%s",
                       _("detaching serial console is not supported"));
        return NULL;
    }

    /* Due to some crazy backcompat stuff, the first serial device is an alias
     * to the first console too. If this is the case, the definition must be
     * duplicated as first console device. */
    removeCompat = vmdef->nserials && vmdef->nconsoles &&
        vmdef->consoles[0]->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_CONSOLE &&
        vmdef->consoles[0]->targetType == VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_SERIAL &&
        virDomainChrEquals(vmdef->serials[0], chr);

    if (!(ret = virDomainChrRemove(vmdef, chr))) {
        virReportError(VIR_ERR_INVALID_ARG, "%s",
                       _("device not present in domain configuration"));
            return NULL;
    }

    if (removeCompat)
        VIR_DELETE_ELEMENT(vmdef->consoles, 0, vmdef->nconsoles);

    return ret;
}
1896

1897 1898 1899 1900
/* Returns  1 if the address will need to be released later,
 *         -1 on error
 *          0 otherwise
 */
1901
static int
1902
qemuDomainAttachChrDeviceAssignAddr(virDomainObjPtr vm,
1903 1904
                                    virDomainChrDefPtr chr,
                                    virQEMUDriverPtr driver)
1905
{
1906 1907
    virDomainDefPtr def = vm->def;
    qemuDomainObjPrivatePtr priv = vm->privateData;
1908
    virDomainDeviceDef dev = { VIR_DOMAIN_DEVICE_CHR, { .chr = chr } };
1909

1910 1911
    if (chr->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_CONSOLE &&
        chr->targetType == VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_VIRTIO) {
1912
        if (virDomainVirtioSerialAddrAutoAssign(def, &chr->info, true) < 0)
1913
            return -1;
1914
        return 0;
1915 1916 1917

    } else if (chr->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_SERIAL &&
               chr->targetType == VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_PCI) {
1918
        if (qemuDomainEnsurePCIAddress(vm, &dev, driver) < 0)
1919 1920
            return -1;
        return 1;
1921

J
Ján Tomko 已提交
1922 1923
    } else if (priv->usbaddrs &&
               chr->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_SERIAL &&
1924 1925
               chr->targetType == VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_USB) {
        if (virDomainUSBAddressEnsure(priv->usbaddrs, &chr->info) < 0)
1926 1927
            return -1;
        return 1;
1928

1929 1930
    } else if (chr->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_CHANNEL &&
               chr->targetType == VIR_DOMAIN_CHR_CHANNEL_TARGET_TYPE_VIRTIO) {
1931
        if (virDomainVirtioSerialAddrAutoAssign(def, &chr->info, false) < 0)
1932
            return -1;
1933
        return 0;
1934 1935 1936 1937 1938 1939
    }

    if (chr->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_SERIAL ||
        chr->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) {
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("Unsupported address type for character device"));
1940
        return -1;
1941 1942
    }

1943
    return 0;
1944 1945
}

1946 1947
int qemuDomainAttachChrDevice(virConnectPtr conn,
                              virQEMUDriverPtr driver,
1948 1949 1950
                              virDomainObjPtr vm,
                              virDomainChrDefPtr chr)
{
1951
    int ret = -1, rc;
1952
    qemuDomainObjPrivatePtr priv = vm->privateData;
1953
    virErrorPtr orig_err;
1954 1955
    virDomainDefPtr vmdef = vm->def;
    char *devstr = NULL;
1956
    virDomainChrSourceDefPtr dev = chr->source;
1957
    char *charAlias = NULL;
1958
    bool chardevAttached = false;
1959
    bool teardowncgroup = false;
1960
    bool teardowndevice = false;
1961
    char *tlsAlias = NULL;
1962
    char *secAlias = NULL;
1963
    bool need_release = false;
1964

1965 1966 1967 1968
    if (chr->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_CHANNEL &&
        qemuDomainPrepareChannel(chr, priv->channelTargetDir) < 0)
        goto cleanup;

1969
    if (qemuAssignDeviceChrAlias(vmdef, chr, -1) < 0)
1970
        goto cleanup;
1971

1972
    if ((rc = qemuDomainAttachChrDeviceAssignAddr(vm, chr, driver)) < 0)
1973 1974 1975
        goto cleanup;
    if (rc == 1)
        need_release = true;
1976

1977 1978 1979 1980
    if (qemuDomainNamespaceSetupChardev(driver, vm, chr) < 0)
        goto cleanup;
    teardowndevice = true;

1981 1982 1983 1984
    if (qemuSetupChardevCgroup(vm, chr) < 0)
        goto cleanup;
    teardowncgroup = true;

1985
    if (qemuBuildChrDeviceStr(&devstr, vmdef, chr, priv->qemuCaps) < 0)
1986
        goto cleanup;
1987

1988
    if (!(charAlias = qemuAliasChardevFromDevAlias(chr->info.alias)))
1989 1990
        goto cleanup;

1991
    if (qemuDomainChrPreInsert(vmdef, chr) < 0)
1992 1993
        goto cleanup;

1994
    if (qemuDomainAddChardevTLSObjects(conn, driver, vm, dev,
1995
                                       chr->info.alias, charAlias,
1996
                                       &tlsAlias, &secAlias) < 0)
1997
        goto audit;
1998

1999
    qemuDomainObjEnterMonitor(driver, vm);
2000

2001
    if (qemuMonitorAttachCharDev(priv->mon, charAlias, chr->source) < 0)
2002 2003
        goto exit_monitor;
    chardevAttached = true;
2004 2005

    if (qemuMonitorAddDevice(priv->mon, devstr) < 0)
2006
        goto exit_monitor;
2007

2008 2009
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        goto audit;
2010

2011
    qemuDomainChrInsertPreAlloced(vmdef, chr);
2012
    ret = 0;
2013 2014
 audit:
    virDomainAuditChardev(vm, NULL, chr, "attach", ret == 0);
2015
 cleanup:
2016 2017 2018 2019 2020 2021 2022
    if (ret < 0) {
        if (virDomainObjIsActive(vm))
            qemuDomainChrInsertPreAllocCleanup(vmdef, chr);
        if (need_release)
            qemuDomainReleaseDeviceAddress(vm, &chr->info, NULL);
        if (teardowncgroup && qemuTeardownChardevCgroup(vm, chr) < 0)
            VIR_WARN("Unable to remove chr device cgroup ACL on hotplug fail");
2023 2024
        if (teardowndevice && qemuDomainNamespaceTeardownChardev(driver, vm, chr) < 0)
            VIR_WARN("Unable to remove chr device from /dev");
2025
    }
2026
    VIR_FREE(tlsAlias);
2027
    VIR_FREE(secAlias);
2028 2029 2030
    VIR_FREE(charAlias);
    VIR_FREE(devstr);
    return ret;
2031

2032 2033
 exit_monitor:
    orig_err = virSaveLastError();
2034
    /* detach associated chardev on error */
2035 2036
    if (chardevAttached)
        qemuMonitorDetachCharDev(priv->mon, charAlias);
2037
    ignore_value(qemuDomainObjExitMonitor(driver, vm));
2038 2039 2040 2041 2042
    if (orig_err) {
        virSetError(orig_err);
        virFreeError(orig_err);
    }

2043 2044
    qemuDomainDelTLSObjects(driver, vm, QEMU_ASYNC_JOB_NONE,
                            secAlias, tlsAlias);
2045
    goto audit;
2046 2047
}

2048 2049

int
2050 2051
qemuDomainAttachRNGDevice(virConnectPtr conn,
                          virQEMUDriverPtr driver,
2052 2053 2054 2055
                          virDomainObjPtr vm,
                          virDomainRNGDefPtr rng)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
2056
    virDomainDeviceDef dev = { VIR_DOMAIN_DEVICE_RNG, { .rng = rng } };
2057
    virErrorPtr orig_err;
2058 2059 2060
    char *devstr = NULL;
    char *charAlias = NULL;
    char *objAlias = NULL;
2061
    char *tlsAlias = NULL;
2062
    char *secAlias = NULL;
2063
    bool releaseaddr = false;
2064
    bool teardowncgroup = false;
2065
    bool teardowndevice = false;
2066 2067
    bool chardevAdded = false;
    bool objAdded = false;
2068
    virJSONValuePtr props = NULL;
2069
    virDomainCCWAddressSetPtr ccwaddrs = NULL;
2070 2071
    const char *type;
    int ret = -1;
2072
    int rv;
2073

2074
    if (qemuAssignDeviceRNGAlias(vm->def, rng) < 0)
2075
        goto cleanup;
2076 2077 2078

    /* preallocate space for the device definition */
    if (VIR_REALLOC_N(vm->def->rngs, vm->def->nrngs + 1) < 0)
2079
        goto cleanup;
2080 2081

    if (rng->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) {
2082
        if (qemuDomainIsS390CCW(vm->def) &&
2083 2084 2085 2086 2087
            virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_VIRTIO_CCW)) {
            rng->info.type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW;
        } else if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_VIRTIO_S390)) {
            rng->info.type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_S390;
        }
2088 2089 2090
    } else {
        if (!qemuCheckCCWS390AddressSupport(vm->def, rng->info, priv->qemuCaps,
                                            rng->source.file))
2091
            goto cleanup;
2092
    }
2093
    releaseaddr = true;
2094 2095 2096

    if (rng->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE ||
        rng->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) {
2097
        if (qemuDomainEnsurePCIAddress(vm, &dev, driver) < 0)
2098
            goto cleanup;
2099
    } else if (rng->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) {
2100 2101 2102
        if (!(ccwaddrs = qemuDomainCCWAddrSetCreateFromDomain(vm->def)))
            goto cleanup;
        if (virDomainCCWAddressAssign(&rng->info, ccwaddrs,
2103
                                      !rng->info.addr.ccw.assigned) < 0)
2104
            goto cleanup;
2105 2106
    }

2107 2108 2109 2110
    if (qemuDomainNamespaceSetupRNG(driver, vm, rng) < 0)
        goto cleanup;
    teardowndevice = true;

2111 2112 2113 2114
    if (qemuSetupRNGCgroup(vm, rng) < 0)
        goto cleanup;
    teardowncgroup = true;

2115 2116 2117 2118 2119 2120 2121 2122 2123 2124
    /* build required metadata */
    if (!(devstr = qemuBuildRNGDevStr(vm->def, rng, priv->qemuCaps)))
        goto cleanup;

    if (qemuBuildRNGBackendProps(rng, priv->qemuCaps, &type, &props) < 0)
        goto cleanup;

    if (virAsprintf(&objAlias, "obj%s", rng->info.alias) < 0)
        goto cleanup;

2125
    if (!(charAlias = qemuAliasChardevFromDevAlias(rng->info.alias)))
2126 2127
        goto cleanup;

2128
    if (rng->backend == VIR_DOMAIN_RNG_BACKEND_EGD) {
2129
        if (qemuDomainAddChardevTLSObjects(conn, driver, vm,
2130 2131 2132
                                           rng->source.chardev,
                                           rng->info.alias, charAlias,
                                           &tlsAlias, &secAlias) < 0)
2133
            goto audit;
2134 2135
    }

2136
    qemuDomainObjEnterMonitor(driver, vm);
2137

2138 2139 2140
    if (rng->backend == VIR_DOMAIN_RNG_BACKEND_EGD &&
        qemuMonitorAttachCharDev(priv->mon, charAlias,
                                 rng->source.chardev) < 0)
2141 2142
        goto exit_monitor;
    chardevAdded = true;
2143

2144 2145 2146 2147 2148
    rv = qemuMonitorAddObject(priv->mon, type, objAlias, props);
    props = NULL; /* qemuMonitorAddObject consumes */
    if (rv < 0)
        goto exit_monitor;
    objAdded = true;
2149 2150

    if (qemuMonitorAddDevice(priv->mon, devstr) < 0)
2151
        goto exit_monitor;
2152 2153

    if (qemuDomainObjExitMonitor(driver, vm) < 0) {
2154
        releaseaddr = false;
2155 2156 2157
        goto cleanup;
    }

2158
    VIR_APPEND_ELEMENT_INPLACE(vm->def->rngs, vm->def->nrngs, rng);
2159 2160 2161 2162 2163 2164

    ret = 0;

 audit:
    virDomainAuditRNG(vm, NULL, rng, "attach", ret == 0);
 cleanup:
2165
    virJSONValueFree(props);
2166 2167 2168 2169 2170
    if (ret < 0) {
        if (releaseaddr)
            qemuDomainReleaseDeviceAddress(vm, &rng->info, NULL);
        if (teardowncgroup && qemuTeardownRNGCgroup(vm, rng) < 0)
            VIR_WARN("Unable to remove RNG device cgroup ACL on hotplug fail");
2171 2172
        if (teardowndevice && qemuDomainNamespaceTeardownRNG(driver, vm, rng) < 0)
            VIR_WARN("Unable to remove chr device from /dev");
2173 2174
    }

2175
    VIR_FREE(tlsAlias);
2176
    VIR_FREE(secAlias);
2177 2178 2179
    VIR_FREE(charAlias);
    VIR_FREE(objAlias);
    VIR_FREE(devstr);
2180
    virDomainCCWAddressSetFree(ccwaddrs);
2181 2182
    return ret;

2183 2184 2185 2186 2187
 exit_monitor:
    orig_err = virSaveLastError();
    if (objAdded)
        ignore_value(qemuMonitorDelObject(priv->mon, objAlias));
    if (rng->backend == VIR_DOMAIN_RNG_BACKEND_EGD && chardevAdded)
2188
        ignore_value(qemuMonitorDetachCharDev(priv->mon, charAlias));
2189 2190
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        releaseaddr = false;
2191 2192 2193
    if (orig_err) {
        virSetError(orig_err);
        virFreeError(orig_err);
2194 2195
    }

2196 2197
    qemuDomainDelTLSObjects(driver, vm, QEMU_ASYNC_JOB_NONE,
                            secAlias, tlsAlias);
2198 2199 2200 2201
    goto audit;
}


2202 2203 2204 2205 2206 2207 2208 2209 2210 2211 2212 2213 2214 2215 2216 2217
/**
 * qemuDomainAttachMemory:
 * @driver: qemu driver data
 * @vm: VM object
 * @mem: Definition of the memory device to be attached. @mem is always consumed
 *
 * Attaches memory device described by @mem to domain @vm.
 *
 * Returns 0 on success -1 on error.
 */
int
qemuDomainAttachMemory(virQEMUDriverPtr driver,
                       virDomainObjPtr vm,
                       virDomainMemoryDefPtr mem)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
2218
    virErrorPtr orig_err;
2219
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
2220
    unsigned long long oldmem = virDomainDefGetMemoryTotal(vm->def);
2221
    unsigned long long newmem = oldmem + mem->size;
2222 2223 2224
    char *devstr = NULL;
    char *objalias = NULL;
    const char *backendType;
2225
    bool objAdded = false;
M
Michal Privoznik 已提交
2226
    bool teardownlabel = false;
2227
    bool teardowncgroup = false;
M
Michal Privoznik 已提交
2228
    bool teardowndevice = false;
2229
    virJSONValuePtr props = NULL;
2230
    virObjectEventPtr event;
2231 2232
    int id;
    int ret = -1;
2233
    int rv;
2234

2235 2236 2237
    qemuDomainMemoryDeviceAlignSize(vm->def, mem);

    if (qemuDomainDefValidateMemoryHotplug(vm->def, priv->qemuCaps, mem) < 0)
2238 2239
        goto cleanup;

2240 2241 2242
    if (qemuDomainAssignMemoryDeviceSlot(vm->def, mem) < 0)
        goto cleanup;

2243 2244 2245
    /* in cases where we are using a VM with aliases generated according to the
     * index of the memory device we need to keep continue using that scheme */
    if (qemuAssignDeviceMemoryAlias(vm->def, mem, priv->memAliasOrderMismatch) < 0)
2246 2247 2248 2249 2250
        goto cleanup;

    if (virAsprintf(&objalias, "mem%s", mem->info.alias) < 0)
        goto cleanup;

2251
    if (!(devstr = qemuBuildMemoryDeviceStr(mem)))
2252 2253
        goto cleanup;

2254 2255
    if (qemuBuildMemoryBackendStr(&props, &backendType, cfg,
                                  priv->qemuCaps, vm->def, mem, NULL, true) < 0)
2256 2257
        goto cleanup;

M
Michal Privoznik 已提交
2258 2259 2260 2261
    if (qemuDomainNamespaceSetupMemory(driver, vm, mem) < 0)
        goto cleanup;
    teardowndevice = true;

2262 2263 2264 2265
    if (qemuSetupMemoryDevicesCgroup(vm, mem) < 0)
        goto cleanup;
    teardowncgroup = true;

M
Michal Privoznik 已提交
2266
    if (qemuSecuritySetMemoryLabel(driver, vm, mem) < 0)
2267
        goto cleanup;
M
Michal Privoznik 已提交
2268
    teardownlabel = true;
2269

M
Michal Privoznik 已提交
2270 2271 2272 2273
    if (virDomainMemoryInsert(vm->def, mem) < 0)
        goto cleanup;

    if (qemuDomainAdjustMaxMemLock(vm) < 0)
2274 2275
        goto removedef;

2276
    qemuDomainObjEnterMonitor(driver, vm);
2277 2278 2279
    rv = qemuMonitorAddObject(priv->mon, backendType, objalias, props);
    props = NULL; /* qemuMonitorAddObject consumes */
    if (rv < 0)
2280
        goto exit_monitor;
2281
    objAdded = true;
2282

2283
    if (qemuMonitorAddDevice(priv->mon, devstr) < 0)
2284
        goto exit_monitor;
2285 2286 2287 2288

    if (qemuDomainObjExitMonitor(driver, vm) < 0) {
        /* we shouldn't touch mem now, as the def might be freed */
        mem = NULL;
2289
        goto audit;
2290 2291
    }

2292
    event = virDomainEventDeviceAddedNewFromObj(vm, objalias);
2293
    qemuDomainEventQueue(driver, event);
2294

2295 2296
    /* fix the balloon size */
    ignore_value(qemuProcessRefreshBalloonState(driver, vm, QEMU_ASYNC_JOB_NONE));
2297

2298 2299 2300 2301 2302 2303 2304 2305 2306
    /* mem is consumed by vm->def */
    mem = NULL;

    /* this step is best effort, removing the device would be so much trouble */
    ignore_value(qemuDomainUpdateMemoryDeviceInfo(driver, vm,
                                                  QEMU_ASYNC_JOB_NONE));

    ret = 0;

2307 2308
 audit:
    virDomainAuditMemory(vm, oldmem, newmem, "update", ret == 0);
2309
 cleanup:
M
Michal Privoznik 已提交
2310
    if (mem && ret < 0) {
2311 2312
        if (teardowncgroup && qemuTeardownMemoryDevicesCgroup(vm, mem) < 0)
            VIR_WARN("Unable to remove memory device cgroup ACL on hotplug fail");
M
Michal Privoznik 已提交
2313 2314
        if (teardownlabel && qemuSecurityRestoreMemoryLabel(driver, vm, mem) < 0)
            VIR_WARN("Unable to restore security label on memdev");
M
Michal Privoznik 已提交
2315 2316 2317
        if (teardowndevice &&
            qemuDomainNamespaceTeardownMemory(driver, vm, mem) <  0)
            VIR_WARN("Unable to remove memory device from /dev");
M
Michal Privoznik 已提交
2318 2319 2320
    }

    virJSONValueFree(props);
2321 2322 2323 2324 2325 2326
    virObjectUnref(cfg);
    VIR_FREE(devstr);
    VIR_FREE(objalias);
    virDomainMemoryDefFree(mem);
    return ret;

2327
 exit_monitor:
2328 2329 2330
    orig_err = virSaveLastError();
    if (objAdded)
        ignore_value(qemuMonitorDelObject(priv->mon, objalias));
2331 2332
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        mem = NULL;
2333 2334 2335 2336
    if (orig_err) {
        virSetError(orig_err);
        virFreeError(orig_err);
    }
2337
    if (!mem)
2338
        goto audit;
2339

2340
 removedef:
2341 2342 2343 2344 2345
    if ((id = virDomainMemoryFindByDef(vm->def, mem)) >= 0)
        mem = virDomainMemoryRemove(vm->def, id);
    else
        mem = NULL;

2346
    /* reset the mlock limit */
2347
    orig_err = virSaveLastError();
2348
    ignore_value(qemuDomainAdjustMaxMemLock(vm));
2349 2350
    virSetError(orig_err);
    virFreeError(orig_err);
2351

2352
    goto audit;
2353 2354 2355
}


2356
static int
2357
qemuDomainAttachHostUSBDevice(virQEMUDriverPtr driver,
2358 2359
                              virDomainObjPtr vm,
                              virDomainHostdevDefPtr hostdev)
2360 2361 2362
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    char *devstr = NULL;
2363
    bool releaseaddr = false;
2364
    bool added = false;
2365
    bool teardowncgroup = false;
2366
    bool teardownlabel = false;
2367
    bool teardowndevice = false;
2368 2369
    int ret = -1;

2370 2371 2372 2373 2374 2375
    if (priv->usbaddrs) {
        if (virDomainUSBAddressEnsure(priv->usbaddrs, hostdev->info) < 0)
            goto cleanup;
        releaseaddr = true;
    }

2376
    if (qemuHostdevPrepareUSBDevices(driver, vm->def->name, &hostdev, 1, 0) < 0)
2377 2378 2379
        goto cleanup;

    added = true;
2380

2381 2382 2383 2384
    if (qemuDomainNamespaceSetupHostdev(driver, vm, hostdev) < 0)
        goto cleanup;
    teardowndevice = true;

2385
    if (qemuSetupHostdevCgroup(vm, hostdev) < 0)
2386 2387 2388
        goto cleanup;
    teardowncgroup = true;

2389
    if (qemuSecuritySetHostdevLabel(driver, vm, hostdev) < 0)
2390 2391 2392
        goto cleanup;
    teardownlabel = true;

2393 2394 2395 2396
    if (qemuAssignDeviceHostdevAlias(vm->def, &hostdev->info->alias, -1) < 0)
        goto cleanup;
    if (!(devstr = qemuBuildUSBHostdevDevStr(vm->def, hostdev, priv->qemuCaps)))
        goto cleanup;
2397

2398
    if (VIR_REALLOC_N(vm->def->hostdevs, vm->def->nhostdevs+1) < 0)
2399
        goto cleanup;
2400

2401
    qemuDomainObjEnterMonitor(driver, vm);
2402
    ret = qemuMonitorAddDevice(priv->mon, devstr);
2403 2404 2405 2406
    if (qemuDomainObjExitMonitor(driver, vm) < 0) {
        ret = -1;
        goto cleanup;
    }
2407
    virDomainAuditHostdev(vm, hostdev, "attach", ret == 0);
2408
    if (ret < 0)
2409
        goto cleanup;
2410 2411 2412

    vm->def->hostdevs[vm->def->nhostdevs++] = hostdev;

2413
    ret = 0;
2414
 cleanup:
2415 2416 2417 2418
    if (ret < 0) {
        if (teardowncgroup && qemuTeardownHostdevCgroup(vm, hostdev) < 0)
            VIR_WARN("Unable to remove host device cgroup ACL on hotplug fail");
        if (teardownlabel &&
2419
            qemuSecurityRestoreHostdevLabel(driver, vm, hostdev) < 0)
2420
            VIR_WARN("Unable to restore host device labelling on hotplug fail");
2421 2422 2423
        if (teardowndevice &&
            qemuDomainNamespaceTeardownHostdev(driver, vm, hostdev) < 0)
            VIR_WARN("Unable to remove host device from /dev");
2424
        if (added)
2425
            qemuHostdevReAttachUSBDevices(driver, vm->def->name, &hostdev, 1);
2426 2427
        if (releaseaddr)
            virDomainUSBAddressRelease(priv->usbaddrs, hostdev->info);
2428
    }
2429
    VIR_FREE(devstr);
2430
    return ret;
2431 2432
}

2433

2434
static int
2435 2436
qemuDomainAttachHostSCSIDevice(virConnectPtr conn,
                               virQEMUDriverPtr driver,
2437 2438 2439
                               virDomainObjPtr vm,
                               virDomainHostdevDefPtr hostdev)
{
2440
    size_t i;
2441 2442
    int ret = -1;
    qemuDomainObjPrivatePtr priv = vm->privateData;
2443
    virErrorPtr orig_err;
2444 2445
    char *devstr = NULL;
    char *drvstr = NULL;
2446
    char *drivealias = NULL;
2447
    bool teardowncgroup = false;
2448
    bool teardownlabel = false;
2449
    bool teardowndevice = false;
2450
    bool driveAdded = false;
2451

2452
    if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DEVICE_SCSI_GENERIC)) {
2453 2454 2455 2456 2457
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("SCSI passthrough is not supported by this version of qemu"));
        return -1;
    }

2458 2459 2460 2461 2462 2463 2464 2465 2466 2467 2468
    /* Let's make sure the disk has a controller defined and loaded before
     * trying to add it. The controller used by the disk must exist before a
     * qemu command line string is generated.
     *
     * Ensure that the given controller and all controllers with a smaller index
     * exist; there must not be any missing index in between.
     */
    for (i = 0; i <= hostdev->info->addr.drive.controller; i++) {
        if (!qemuDomainFindOrCreateSCSIDiskController(driver, vm, i))
            return -1;
    }
2469

2470
    if (qemuHostdevPrepareSCSIDevices(driver, vm->def->name,
2471
                                      &hostdev, 1)) {
2472
        virDomainHostdevSubsysSCSIPtr scsisrc = &hostdev->source.subsys.u.scsi;
2473 2474 2475 2476 2477 2478 2479 2480
        if (scsisrc->protocol == VIR_DOMAIN_HOSTDEV_SCSI_PROTOCOL_TYPE_ISCSI) {
            virDomainHostdevSubsysSCSIiSCSIPtr iscsisrc = &scsisrc->u.iscsi;
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           _("Unable to prepare scsi hostdev for iSCSI: %s"),
                           iscsisrc->path);
        } else {
            virDomainHostdevSubsysSCSIHostPtr scsihostsrc = &scsisrc->u.host;
            virReportError(VIR_ERR_INTERNAL_ERROR,
2481
                           _("Unable to prepare scsi hostdev: %s:%u:%u:%llu"),
2482 2483 2484
                           scsihostsrc->adapter, scsihostsrc->bus,
                           scsihostsrc->target, scsihostsrc->unit);
        }
2485 2486 2487
        return -1;
    }

2488 2489 2490 2491
    if (qemuDomainNamespaceSetupHostdev(driver, vm, hostdev) < 0)
        goto cleanup;
    teardowndevice = true;

2492
    if (qemuSetupHostdevCgroup(vm, hostdev) < 0)
2493 2494 2495
        goto cleanup;
    teardowncgroup = true;

2496
    if (qemuSecuritySetHostdevLabel(driver, vm, hostdev) < 0)
2497 2498 2499
        goto cleanup;
    teardownlabel = true;

2500
    if (qemuAssignDeviceHostdevAlias(vm->def, &hostdev->info->alias, -1) < 0)
2501 2502
        goto cleanup;

J
John Ferlan 已提交
2503
    if (qemuDomainSecretHostdevPrepare(conn, priv, hostdev) < 0)
2504 2505
        goto cleanup;

2506
    if (!(drvstr = qemuBuildSCSIHostdevDrvStr(hostdev)))
2507 2508
        goto cleanup;

2509 2510 2511
    if (!(drivealias = qemuAliasFromHostdev(hostdev)))
        goto cleanup;

2512 2513 2514
    if (!(devstr = qemuBuildSCSIHostdevDevStr(vm->def, hostdev, priv->qemuCaps)))
        goto cleanup;

2515
    if (VIR_REALLOC_N(vm->def->hostdevs, vm->def->nhostdevs + 1) < 0)
2516 2517 2518 2519
        goto cleanup;

    qemuDomainObjEnterMonitor(driver, vm);

2520
    if (qemuMonitorAddDrive(priv->mon, drvstr) < 0)
2521 2522
        goto exit_monitor;
    driveAdded = true;
2523 2524

    if (qemuMonitorAddDevice(priv->mon, devstr) < 0)
2525
        goto exit_monitor;
2526 2527

    if (qemuDomainObjExitMonitor(driver, vm) < 0)
2528
        goto cleanup;
2529 2530

    virDomainAuditHostdev(vm, hostdev, "attach", true);
2531 2532 2533 2534

    vm->def->hostdevs[vm->def->nhostdevs++] = hostdev;

    ret = 0;
2535

2536
 cleanup:
2537
    qemuDomainSecretHostdevDestroy(hostdev);
2538
    if (ret < 0) {
2539
        qemuHostdevReAttachSCSIDevices(driver, vm->def->name, &hostdev, 1);
2540 2541
        if (teardowncgroup && qemuTeardownHostdevCgroup(vm, hostdev) < 0)
            VIR_WARN("Unable to remove host device cgroup ACL on hotplug fail");
2542
        if (teardownlabel &&
2543
            qemuSecurityRestoreHostdevLabel(driver, vm, hostdev) < 0)
2544
            VIR_WARN("Unable to restore host device labelling on hotplug fail");
2545 2546 2547
        if (teardowndevice &&
            qemuDomainNamespaceTeardownHostdev(driver, vm, hostdev) < 0)
            VIR_WARN("Unable to remove host device from /dev");
2548
    }
2549
    VIR_FREE(drivealias);
2550 2551 2552
    VIR_FREE(drvstr);
    VIR_FREE(devstr);
    return ret;
2553

2554
 exit_monitor:
2555
    orig_err = virSaveLastError();
2556
    if (driveAdded && qemuMonitorDriveDel(priv->mon, drivealias) < 0) {
2557 2558 2559
        VIR_WARN("Unable to remove drive %s (%s) after failed "
                 "qemuMonitorAddDevice",
                 drvstr, devstr);
2560
    }
2561
    ignore_value(qemuDomainObjExitMonitor(driver, vm));
2562 2563 2564 2565 2566 2567 2568 2569
    if (orig_err) {
        virSetError(orig_err);
        virFreeError(orig_err);
    }

    virDomainAuditHostdev(vm, hostdev, "attach", false);

    goto cleanup;
2570 2571
}

2572 2573 2574 2575 2576 2577 2578 2579 2580 2581 2582 2583 2584 2585 2586
static int
qemuDomainAttachSCSIVHostDevice(virQEMUDriverPtr driver,
                                virDomainObjPtr vm,
                                virDomainHostdevDefPtr hostdev)
{
    int ret = -1;
    qemuDomainObjPrivatePtr priv = vm->privateData;
    virDomainDeviceDef dev = { VIR_DOMAIN_DEVICE_HOSTDEV,
                               { .hostdev = hostdev } };
    virDomainCCWAddressSetPtr ccwaddrs = NULL;
    char *vhostfdName = NULL;
    int vhostfd = -1;
    char *devstr = NULL;
    bool teardowncgroup = false;
    bool teardownlabel = false;
2587
    bool teardowndevice = false;
2588 2589 2590 2591 2592 2593 2594 2595 2596 2597 2598 2599 2600 2601 2602 2603
    bool releaseaddr = false;

    if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DEVICE_SCSI_GENERIC)) {
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("SCSI passthrough is not supported by this version of qemu"));
        return -1;
    }

    if (qemuHostdevPrepareSCSIVHostDevices(driver, vm->def->name, &hostdev, 1) < 0) {
        virDomainHostdevSubsysSCSIVHostPtr hostsrc = &hostdev->source.subsys.u.scsi_host;
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("Unable to prepare scsi_host hostdev: %s"),
                       hostsrc->wwpn);
        return -1;
    }

2604 2605 2606 2607
    if (qemuDomainNamespaceSetupHostdev(driver, vm, hostdev) < 0)
        goto cleanup;
    teardowndevice = true;

2608 2609 2610 2611
    if (qemuSetupHostdevCgroup(vm, hostdev) < 0)
        goto cleanup;
    teardowncgroup = true;

2612
    if (qemuSecuritySetHostdevLabel(driver, vm, hostdev) < 0)
2613 2614 2615 2616 2617 2618 2619 2620 2621 2622
        goto cleanup;
    teardownlabel = true;

    if (virSCSIVHostOpenVhostSCSI(&vhostfd) < 0)
        goto cleanup;

    if (virAsprintf(&vhostfdName, "vhostfd-%d", vhostfd) < 0)
        goto cleanup;

    if (hostdev->info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) {
2623
        if (qemuDomainIsS390CCW(vm->def) &&
2624 2625 2626 2627 2628 2629
            virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_VIRTIO_CCW))
            hostdev->info->type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW;
    }

    if (hostdev->info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE ||
        hostdev->info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) {
2630
        if (qemuDomainEnsurePCIAddress(vm, &dev, driver) < 0)
2631 2632 2633 2634 2635 2636 2637 2638 2639 2640 2641 2642 2643 2644 2645 2646 2647 2648 2649 2650 2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670
            goto cleanup;
    } else if (hostdev->info->type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) {
        if (!(ccwaddrs = qemuDomainCCWAddrSetCreateFromDomain(vm->def)))
            goto cleanup;
        if (virDomainCCWAddressAssign(hostdev->info, ccwaddrs,
                                      !hostdev->info->addr.ccw.assigned) < 0)
            goto cleanup;
    }
    releaseaddr = true;

    if (qemuAssignDeviceHostdevAlias(vm->def, &hostdev->info->alias, -1) < 0)
        goto cleanup;

    if (!(devstr = qemuBuildSCSIVHostHostdevDevStr(vm->def,
                                                   hostdev,
                                                   priv->qemuCaps,
                                                   vhostfdName)))
        goto cleanup;

    if (VIR_REALLOC_N(vm->def->hostdevs, vm->def->nhostdevs + 1) < 0)
        goto cleanup;

    qemuDomainObjEnterMonitor(driver, vm);

    ret = qemuMonitorAddDeviceWithFd(priv->mon, devstr, vhostfd, vhostfdName);

    if (qemuDomainObjExitMonitor(driver, vm) < 0 || ret < 0)
        goto audit;

    vm->def->hostdevs[vm->def->nhostdevs++] = hostdev;
    ret = 0;

 audit:
    virDomainAuditHostdev(vm, hostdev, "attach", (ret == 0));

 cleanup:
    if (ret < 0) {
        if (teardowncgroup && qemuTeardownHostdevCgroup(vm, hostdev) < 0)
            VIR_WARN("Unable to remove host device cgroup ACL on hotplug fail");
        if (teardownlabel &&
2671
            qemuSecurityRestoreHostdevLabel(driver, vm, hostdev) < 0)
2672
            VIR_WARN("Unable to restore host device labelling on hotplug fail");
2673 2674 2675
        if (teardowndevice &&
            qemuDomainNamespaceTeardownHostdev(driver, vm, hostdev) < 0)
            VIR_WARN("Unable to remove host device from /dev");
2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687
        if (releaseaddr)
            qemuDomainReleaseDeviceAddress(vm, hostdev->info, NULL);
    }

    virDomainCCWAddressSetFree(ccwaddrs);

    VIR_FORCE_CLOSE(vhostfd);
    VIR_FREE(vhostfdName);
    VIR_FREE(devstr);
    return ret;
}

2688 2689 2690 2691 2692 2693

int
qemuDomainAttachHostDevice(virConnectPtr conn,
                           virQEMUDriverPtr driver,
                           virDomainObjPtr vm,
                           virDomainHostdevDefPtr hostdev)
2694 2695
{
    if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) {
2696 2697 2698
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                       _("hostdev mode '%s' not supported"),
                       virDomainHostdevModeTypeToString(hostdev->mode));
2699 2700 2701 2702 2703
        return -1;
    }

    switch (hostdev->source.subsys.type) {
    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI:
2704
        if (qemuDomainAttachHostPCIDevice(driver, vm,
2705
                                          hostdev) < 0)
2706 2707 2708 2709
            goto error;
        break;

    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB:
2710
        if (qemuDomainAttachHostUSBDevice(driver, vm,
2711
                                          hostdev) < 0)
2712 2713 2714
            goto error;
        break;

2715
    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI:
2716
        if (qemuDomainAttachHostSCSIDevice(conn, driver, vm,
2717 2718 2719 2720
                                           hostdev) < 0)
            goto error;
        break;

2721 2722 2723 2724 2725
    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI_HOST:
        if (qemuDomainAttachSCSIVHostDevice(driver, vm, hostdev) < 0)
            goto error;
        break;

2726
    default:
2727 2728 2729
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                       _("hostdev subsys type '%s' not supported"),
                       virDomainHostdevSubsysTypeToString(hostdev->source.subsys.type));
2730 2731 2732 2733 2734
        goto error;
    }

    return 0;

2735
 error:
2736 2737 2738
    return -1;
}

2739 2740 2741 2742 2743 2744 2745 2746 2747 2748 2749 2750 2751 2752 2753

int
qemuDomainAttachShmemDevice(virQEMUDriverPtr driver,
                            virDomainObjPtr vm,
                            virDomainShmemDefPtr shmem)
{
    int ret = -1;
    char *shmstr = NULL;
    char *charAlias = NULL;
    char *memAlias = NULL;
    bool release_backing = false;
    bool release_address = true;
    virErrorPtr orig_err = NULL;
    virJSONValuePtr props = NULL;
    qemuDomainObjPrivatePtr priv = vm->privateData;
2754
    virDomainDeviceDef dev = { VIR_DOMAIN_DEVICE_SHMEM, { .shmem = shmem } };
2755 2756 2757 2758 2759 2760 2761 2762 2763 2764 2765 2766 2767 2768 2769 2770 2771 2772 2773 2774 2775 2776 2777 2778 2779 2780

    switch ((virDomainShmemModel)shmem->model) {
    case VIR_DOMAIN_SHMEM_MODEL_IVSHMEM_PLAIN:
    case VIR_DOMAIN_SHMEM_MODEL_IVSHMEM_DOORBELL:
        break;

    case VIR_DOMAIN_SHMEM_MODEL_IVSHMEM:
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
                       _("live attach of shmem model '%s' is not supported"),
                       virDomainShmemModelTypeToString(shmem->model));
        /* fall-through */
    case VIR_DOMAIN_SHMEM_MODEL_LAST:
        return -1;
    }

    if (qemuAssignDeviceShmemAlias(vm->def, shmem, -1) < 0)
        return -1;

    if (qemuDomainPrepareShmemChardev(shmem) < 0)
        return -1;

    if (VIR_REALLOC_N(vm->def->shmems, vm->def->nshmems + 1) < 0)
        return -1;

    if ((shmem->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE ||
         shmem->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) &&
2781
        (qemuDomainEnsurePCIAddress(vm, &dev, driver) < 0))
2782 2783 2784 2785 2786 2787 2788 2789 2790 2791 2792 2793 2794 2795 2796 2797 2798 2799 2800 2801 2802 2803 2804 2805 2806 2807 2808 2809 2810 2811 2812 2813 2814 2815 2816 2817 2818 2819 2820 2821 2822 2823 2824 2825 2826 2827 2828 2829 2830 2831 2832 2833 2834 2835 2836 2837 2838 2839 2840 2841 2842 2843 2844 2845 2846 2847 2848 2849 2850 2851 2852
        return -1;

    if (!(shmstr = qemuBuildShmemDevStr(vm->def, shmem, priv->qemuCaps)))
        goto cleanup;

    if (shmem->server.enabled) {
        if (virAsprintf(&charAlias, "char%s", shmem->info.alias) < 0)
            goto cleanup;
    } else {
        if (!(props = qemuBuildShmemBackendMemProps(shmem)))
            goto cleanup;

        if (virAsprintf(&memAlias, "shmmem-%s", shmem->info.alias) < 0)
            goto cleanup;
    }

    qemuDomainObjEnterMonitor(driver, vm);

    if (shmem->server.enabled) {
        if (qemuMonitorAttachCharDev(priv->mon, charAlias,
                                     &shmem->server.chr) < 0)
            goto exit_monitor;
    } else {
        if (qemuMonitorAddObject(priv->mon, "memory-backend-file",
                                 memAlias, props) < 0) {
            props = NULL;
            goto exit_monitor;
        }
        props = NULL;
    }

    release_backing = true;

    if (qemuMonitorAddDevice(priv->mon, shmstr) < 0)
        goto exit_monitor;

    if (qemuDomainObjExitMonitor(driver, vm) < 0) {
        release_address = false;
        goto cleanup;
    }

    /* Doing a copy here just so the pointer doesn't get nullified
     * because we need it in the audit function */
    VIR_APPEND_ELEMENT_COPY_INPLACE(vm->def->shmems, vm->def->nshmems, shmem);

    ret = 0;
    release_address = false;

 audit:
    virDomainAuditShmem(vm, shmem, "attach", ret == 0);

 cleanup:
    if (release_address)
        qemuDomainReleaseDeviceAddress(vm, &shmem->info, NULL);

    virJSONValueFree(props);
    VIR_FREE(memAlias);
    VIR_FREE(charAlias);
    VIR_FREE(shmstr);

    return ret;

 exit_monitor:
    orig_err = virSaveLastError();
    if (release_backing) {
        if (shmem->server.enabled)
            ignore_value(qemuMonitorDetachCharDev(priv->mon, charAlias));
        else
            ignore_value(qemuMonitorDelObject(priv->mon, memAlias));
    }

2853 2854 2855
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        release_address = false;

2856 2857 2858 2859 2860 2861 2862 2863 2864
    if (orig_err) {
        virSetError(orig_err);
        virFreeError(orig_err);
    }

    goto audit;
}


2865
static int
2866
qemuDomainChangeNetBridge(virDomainObjPtr vm,
2867 2868
                          virDomainNetDefPtr olddev,
                          virDomainNetDefPtr newdev)
2869 2870
{
    int ret = -1;
2871 2872
    const char *oldbridge = virDomainNetGetActualBridgeName(olddev);
    const char *newbridge = virDomainNetGetActualBridgeName(newdev);
2873

2874 2875
    if (!oldbridge || !newbridge) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Missing bridge name"));
2876
        goto cleanup;
2877
    }
2878 2879 2880 2881 2882

    VIR_DEBUG("Change bridge for interface %s: %s -> %s",
              olddev->ifname, oldbridge, newbridge);

    if (virNetDevExists(newbridge) != 1) {
2883 2884
        virReportError(VIR_ERR_OPERATION_FAILED,
                       _("bridge %s doesn't exist"), newbridge);
2885
        goto cleanup;
2886 2887 2888 2889 2890
    }

    if (oldbridge) {
        ret = virNetDevBridgeRemovePort(oldbridge, olddev->ifname);
        virDomainAuditNet(vm, olddev, NULL, "detach", ret == 0);
2891 2892 2893 2894 2895 2896 2897 2898
        if (ret < 0) {
            /* warn but continue - possibly the old network
             * had been destroyed and reconstructed, leaving the
             * tap device orphaned.
             */
            VIR_WARN("Unable to detach device %s from bridge %s",
                     olddev->ifname, oldbridge);
        }
2899 2900 2901
    }

    ret = virNetDevBridgeAddPort(newbridge, olddev->ifname);
2902
    virDomainAuditNet(vm, NULL, newdev, "attach", ret == 0);
2903 2904 2905 2906
    if (ret < 0) {
        ret = virNetDevBridgeAddPort(oldbridge, olddev->ifname);
        virDomainAuditNet(vm, NULL, olddev, "attach", ret == 0);
        if (ret < 0) {
2907
            virReportError(VIR_ERR_OPERATION_FAILED,
2908
                           _("unable to recover former state by adding port "
2909
                             "to bridge %s"), oldbridge);
2910
        }
2911
        goto cleanup;
2912
    }
2913 2914
    /* caller will replace entire olddev with newdev in domain nets list */
    ret = 0;
2915
 cleanup:
2916
    return ret;
2917 2918
}

2919
static int
2920
qemuDomainChangeNetFilter(virDomainObjPtr vm,
2921 2922 2923 2924 2925 2926 2927 2928 2929 2930 2931 2932 2933 2934 2935 2936 2937 2938
                          virDomainNetDefPtr olddev,
                          virDomainNetDefPtr newdev)
{
    /* make sure this type of device supports filters. */
    switch (virDomainNetGetActualType(newdev)) {
    case VIR_DOMAIN_NET_TYPE_ETHERNET:
    case VIR_DOMAIN_NET_TYPE_BRIDGE:
    case VIR_DOMAIN_NET_TYPE_NETWORK:
        break;
    default:
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                       _("filters not supported on interfaces of type %s"),
                       virDomainNetTypeToString(virDomainNetGetActualType(newdev)));
        return -1;
    }

    virDomainConfNWFilterTeardown(olddev);

2939
    if (newdev->filter &&
2940
        virDomainConfNWFilterInstantiate(vm->def->uuid, newdev) < 0) {
2941 2942 2943 2944 2945 2946 2947
        virErrorPtr errobj;

        virReportError(VIR_ERR_OPERATION_FAILED,
                       _("failed to add new filter rules to '%s' "
                         "- attempting to restore old rules"),
                       olddev->ifname);
        errobj = virSaveLastError();
2948
        ignore_value(virDomainConfNWFilterInstantiate(vm->def->uuid, olddev));
2949 2950 2951 2952 2953 2954 2955
        virSetError(errobj);
        virFreeError(errobj);
        return -1;
    }
    return 0;
}

2956
int qemuDomainChangeNetLinkState(virQEMUDriverPtr driver,
2957 2958 2959 2960 2961 2962 2963 2964
                                 virDomainObjPtr vm,
                                 virDomainNetDefPtr dev,
                                 int linkstate)
{
    int ret = -1;
    qemuDomainObjPrivatePtr priv = vm->privateData;

    if (!dev->info.alias) {
2965 2966
        virReportError(VIR_ERR_OPERATION_FAILED, "%s",
                       _("can't change link state: device alias not found"));
2967 2968 2969
        return -1;
    }

2970 2971
    VIR_DEBUG("dev: %s, state: %d", dev->info.alias, linkstate);

2972
    qemuDomainObjEnterMonitor(driver, vm);
2973 2974 2975 2976 2977 2978 2979 2980

    ret = qemuMonitorSetLink(priv->mon, dev->info.alias, linkstate);
    if (ret < 0)
        goto cleanup;

    /* modify the device configuration */
    dev->linkstate = linkstate;

2981
 cleanup:
2982 2983
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        return -1;
2984 2985 2986 2987

    return ret;
}

2988
int
2989
qemuDomainChangeNet(virQEMUDriverPtr driver,
2990 2991
                    virDomainObjPtr vm,
                    virDomainDeviceDefPtr dev)
2992
{
2993
    virDomainNetDefPtr newdev = dev->data.net;
2994
    virDomainNetDefPtr *devslot = NULL;
2995
    virDomainNetDefPtr olddev;
2996
    virDomainNetType oldType, newType;
2997 2998
    bool needReconnect = false;
    bool needBridgeChange = false;
2999
    bool needFilterChange = false;
3000 3001
    bool needLinkStateChange = false;
    bool needReplaceDevDef = false;
3002
    bool needBandwidthSet = false;
3003
    int ret = -1;
3004 3005 3006 3007 3008
    int changeidx = -1;

    if ((changeidx = virDomainNetFindIdx(vm->def, newdev)) < 0)
        goto cleanup;
    devslot = &vm->def->nets[changeidx];
3009

3010
    if (!(olddev = *devslot)) {
3011
        virReportError(VIR_ERR_OPERATION_FAILED, "%s",
3012
                       _("cannot find existing network device to modify"));
3013 3014 3015 3016 3017 3018
        goto cleanup;
    }

    oldType = virDomainNetGetActualType(olddev);
    if (oldType == VIR_DOMAIN_NET_TYPE_HOSTDEV) {
        /* no changes are possible to a type='hostdev' interface */
3019
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
3020 3021 3022 3023 3024 3025 3026 3027 3028 3029 3030 3031 3032 3033 3034 3035 3036 3037 3038 3039 3040 3041
                       _("cannot change config of '%s' network type"),
                       virDomainNetTypeToString(oldType));
        goto cleanup;
    }

    /* Check individual attributes for changes that can't be done to a
     * live netdev. These checks *mostly* go in order of the
     * declarations in virDomainNetDef in order to assure nothing is
     * omitted. (exceptiong where noted in comments - in particular,
     * some things require that a new "actual device" be allocated
     * from the network driver first, but we delay doing that until
     * after we've made as many other checks as possible)
     */

    /* type: this can change (with some restrictions), but the actual
     * type of the new device connection isn't known until after we
     * allocate the "actual" device.
     */

    if (virMacAddrCmp(&olddev->mac, &newdev->mac)) {
        char oldmac[VIR_MAC_STRING_BUFLEN], newmac[VIR_MAC_STRING_BUFLEN];

3042
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
3043 3044 3045 3046 3047 3048 3049 3050
                       _("cannot change network interface mac address "
                         "from %s to %s"),
                       virMacAddrFormat(&olddev->mac, oldmac),
                       virMacAddrFormat(&newdev->mac, newmac));
        goto cleanup;
    }

    if (STRNEQ_NULLABLE(olddev->model, newdev->model)) {
3051
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
3052 3053 3054 3055
                       _("cannot modify network device model from %s to %s"),
                       olddev->model ? olddev->model : "(default)",
                       newdev->model ? newdev->model : "(default)");
        goto cleanup;
3056 3057
    }

3058 3059 3060 3061
    if (olddev->model && STREQ(olddev->model, "virtio") &&
        (olddev->driver.virtio.name != newdev->driver.virtio.name ||
         olddev->driver.virtio.txmode != newdev->driver.virtio.txmode ||
         olddev->driver.virtio.ioeventfd != newdev->driver.virtio.ioeventfd ||
3062
         olddev->driver.virtio.event_idx != newdev->driver.virtio.event_idx ||
3063 3064 3065 3066 3067 3068 3069
         olddev->driver.virtio.queues != newdev->driver.virtio.queues ||
         olddev->driver.virtio.host.csum != newdev->driver.virtio.host.csum ||
         olddev->driver.virtio.host.gso != newdev->driver.virtio.host.gso ||
         olddev->driver.virtio.host.tso4 != newdev->driver.virtio.host.tso4 ||
         olddev->driver.virtio.host.tso6 != newdev->driver.virtio.host.tso6 ||
         olddev->driver.virtio.host.ecn != newdev->driver.virtio.host.ecn ||
         olddev->driver.virtio.host.ufo != newdev->driver.virtio.host.ufo ||
J
Ján Tomko 已提交
3070
         olddev->driver.virtio.host.mrg_rxbuf != newdev->driver.virtio.host.mrg_rxbuf ||
3071 3072 3073 3074 3075
         olddev->driver.virtio.guest.csum != newdev->driver.virtio.guest.csum ||
         olddev->driver.virtio.guest.tso4 != newdev->driver.virtio.guest.tso4 ||
         olddev->driver.virtio.guest.tso6 != newdev->driver.virtio.guest.tso6 ||
         olddev->driver.virtio.guest.ecn != newdev->driver.virtio.guest.ecn ||
         olddev->driver.virtio.guest.ufo != newdev->driver.virtio.guest.ufo)) {
3076
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
3077 3078 3079 3080 3081 3082 3083 3084 3085 3086
                       _("cannot modify virtio network device driver attributes"));
        goto cleanup;
    }

    /* data: this union will be examined later, after allocating new actualdev */
    /* virtPortProfile: will be examined later, after allocating new actualdev */

    if (olddev->tune.sndbuf_specified != newdev->tune.sndbuf_specified ||
        olddev->tune.sndbuf != newdev->tune.sndbuf) {
        needReconnect = true;
3087 3088
    }

3089
    if (STRNEQ_NULLABLE(olddev->script, newdev->script)) {
3090
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
3091 3092
                       _("cannot modify network device script attribute"));
        goto cleanup;
3093 3094
    }

3095
    /* ifname: check if it's set in newdev. If not, retain the autogenerated one */
3096
    if (!newdev->ifname && VIR_STRDUP(newdev->ifname, olddev->ifname) < 0)
3097 3098
        goto cleanup;
    if (STRNEQ_NULLABLE(olddev->ifname, newdev->ifname)) {
3099
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
3100 3101 3102
                       _("cannot modify network device tap name"));
        goto cleanup;
    }
3103

3104 3105 3106 3107 3108 3109 3110 3111 3112 3113 3114
    /* info: if newdev->info is empty, fill it in from olddev,
     * otherwise verify that it matches - nothing is allowed to
     * change. (There is no helper function to do this, so
     * individually check the few feidls of virDomainDeviceInfo that
     * are relevant in this case).
     */
    if (!virDomainDeviceAddressIsValid(&newdev->info,
                                       VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) &&
        virDomainDeviceInfoCopy(&newdev->info, &olddev->info) < 0) {
        goto cleanup;
    }
3115
    if (!virPCIDeviceAddressEqual(&olddev->info.addr.pci,
3116
                                  &newdev->info.addr.pci)) {
3117
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
3118 3119 3120 3121
                       _("cannot modify network device guest PCI address"));
        goto cleanup;
    }
    /* grab alias from olddev if not set in newdev */
3122 3123
    if (!newdev->info.alias &&
        VIR_STRDUP(newdev->info.alias, olddev->info.alias) < 0)
3124 3125
        goto cleanup;
    if (STRNEQ_NULLABLE(olddev->info.alias, newdev->info.alias)) {
3126
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
3127 3128 3129 3130
                       _("cannot modify network device alias"));
        goto cleanup;
    }
    if (olddev->info.rombar != newdev->info.rombar) {
3131
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
3132 3133 3134 3135
                       _("cannot modify network device rom bar setting"));
        goto cleanup;
    }
    if (STRNEQ_NULLABLE(olddev->info.romfile, newdev->info.romfile)) {
3136
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
3137 3138 3139 3140
                       _("cannot modify network rom file"));
        goto cleanup;
    }
    if (olddev->info.bootIndex != newdev->info.bootIndex) {
3141
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
3142 3143 3144 3145
                       _("cannot modify network device boot index setting"));
        goto cleanup;
    }
    /* (end of device info checks) */
3146

3147 3148 3149 3150
    if (STRNEQ_NULLABLE(olddev->filter, newdev->filter) ||
        !virNWFilterHashTableEqual(olddev->filterparams, newdev->filterparams)) {
        needFilterChange = true;
    }
3151

3152 3153 3154 3155 3156 3157 3158 3159
    /* bandwidth can be modified, and will be checked later */
    /* vlan can be modified, and will be checked later */
    /* linkstate can be modified */

    /* allocate new actual device to compare to old - we will need to
     * free it if we fail for any reason
     */
    if (newdev->type == VIR_DOMAIN_NET_TYPE_NETWORK &&
3160
        networkAllocateActualDevice(vm->def, newdev) < 0) {
3161 3162 3163 3164 3165 3166 3167
        goto cleanup;
    }

    newType = virDomainNetGetActualType(newdev);

    if (newType == VIR_DOMAIN_NET_TYPE_HOSTDEV) {
        /* can't turn it into a type='hostdev' interface */
3168
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
3169 3170 3171 3172 3173 3174
                       _("cannot change network interface type to '%s'"),
                       virDomainNetTypeToString(newType));
        goto cleanup;
    }

    if (olddev->type == newdev->type && oldType == newType) {
3175

3176 3177 3178 3179 3180 3181
        /* if type hasn't changed, check the relevant fields for the type */
        switch (newdev->type) {
        case VIR_DOMAIN_NET_TYPE_USER:
            break;

        case VIR_DOMAIN_NET_TYPE_ETHERNET:
3182
            break;
3183

3184 3185 3186
        case VIR_DOMAIN_NET_TYPE_SERVER:
        case VIR_DOMAIN_NET_TYPE_CLIENT:
        case VIR_DOMAIN_NET_TYPE_MCAST:
3187
        case VIR_DOMAIN_NET_TYPE_UDP:
3188 3189 3190 3191 3192 3193 3194 3195 3196 3197 3198 3199 3200 3201 3202 3203 3204 3205 3206 3207 3208 3209 3210 3211 3212 3213 3214 3215 3216 3217 3218 3219 3220
            if (STRNEQ_NULLABLE(olddev->data.socket.address,
                                newdev->data.socket.address) ||
                olddev->data.socket.port != newdev->data.socket.port) {
                needReconnect = true;
            }
            break;

        case VIR_DOMAIN_NET_TYPE_NETWORK:
            if (STRNEQ(olddev->data.network.name, newdev->data.network.name)) {
                if (virDomainNetGetActualVirtPortProfile(newdev))
                    needReconnect = true;
                else
                    needBridgeChange = true;
            }
            /* other things handled in common code directly below this switch */
            break;

        case VIR_DOMAIN_NET_TYPE_BRIDGE:
            /* all handled in bridge name checked in common code below */
            break;

        case VIR_DOMAIN_NET_TYPE_INTERNAL:
            if (STRNEQ_NULLABLE(olddev->data.internal.name,
                                newdev->data.internal.name)) {
                needReconnect = true;
            }
            break;

        case VIR_DOMAIN_NET_TYPE_DIRECT:
            /* all handled in common code directly below this switch */
            break;

        default:
3221
            virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
3222 3223 3224
                           _("unable to change config on '%s' network type"),
                           virDomainNetTypeToString(newdev->type));
            break;
3225

3226
        }
3227 3228 3229 3230 3231 3232 3233 3234 3235 3236 3237 3238 3239 3240 3241 3242 3243 3244 3245 3246 3247 3248 3249 3250 3251 3252 3253 3254 3255 3256 3257
    } else {
        /* interface type has changed. There are a few special cases
         * where this can only require a minor (or even no) change,
         * but in most cases we need to do a full reconnection.
         *
         * If we switch (in either direction) between type='bridge'
         * and type='network' (for a traditional managed virtual
         * network that uses a host bridge, i.e. forward
         * mode='route|nat'), we just need to change the bridge.
         */
        if ((oldType == VIR_DOMAIN_NET_TYPE_NETWORK &&
             newType == VIR_DOMAIN_NET_TYPE_BRIDGE) ||
            (oldType == VIR_DOMAIN_NET_TYPE_BRIDGE &&
             newType == VIR_DOMAIN_NET_TYPE_NETWORK)) {

            needBridgeChange = true;

        } else if (oldType == VIR_DOMAIN_NET_TYPE_DIRECT &&
                   newType == VIR_DOMAIN_NET_TYPE_DIRECT) {

            /* this is the case of switching from type='direct' to
             * type='network' for a network that itself uses direct
             * (macvtap) devices. If the physical device and mode are
             * the same, this doesn't require any actual setup
             * change. If the physical device or mode *does* change,
             * that will be caught in the common section below */

        } else {

            /* for all other combinations, we'll need a full reconnect */
            needReconnect = true;
3258 3259

        }
3260
    }
3261

3262 3263 3264 3265 3266 3267 3268 3269 3270 3271 3272
    /* now several things that are in multiple (but not all)
     * different types, and can be safely compared even for those
     * cases where they don't apply to a particular type.
     */
    if (STRNEQ_NULLABLE(virDomainNetGetActualBridgeName(olddev),
                        virDomainNetGetActualBridgeName(newdev))) {
        if (virDomainNetGetActualVirtPortProfile(newdev))
            needReconnect = true;
        else
            needBridgeChange = true;
    }
3273

3274 3275 3276 3277 3278 3279 3280 3281
    if (STRNEQ_NULLABLE(virDomainNetGetActualDirectDev(olddev),
                        virDomainNetGetActualDirectDev(newdev)) ||
        virDomainNetGetActualDirectMode(olddev) != virDomainNetGetActualDirectMode(olddev) ||
        !virNetDevVPortProfileEqual(virDomainNetGetActualVirtPortProfile(olddev),
                                    virDomainNetGetActualVirtPortProfile(newdev)) ||
        !virNetDevVlanEqual(virDomainNetGetActualVlan(olddev),
                            virDomainNetGetActualVlan(newdev))) {
        needReconnect = true;
3282 3283
    }

3284 3285 3286
    if (olddev->linkstate != newdev->linkstate)
        needLinkStateChange = true;

3287 3288 3289 3290
    if (!virNetDevBandwidthEqual(virDomainNetGetActualBandwidth(olddev),
                                 virDomainNetGetActualBandwidth(newdev)))
        needBandwidthSet = true;

3291 3292 3293
    /* FINALLY - actually perform the required actions */

    if (needReconnect) {
3294
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
3295 3296 3297
                       _("unable to change config on '%s' network type"),
                       virDomainNetTypeToString(newdev->type));
        goto cleanup;
3298 3299
    }

3300 3301 3302
    if (needBandwidthSet) {
        if (virNetDevBandwidthSet(newdev->ifname,
                                  virDomainNetGetActualBandwidth(newdev),
3303
                                  false) < 0)
3304 3305 3306 3307
            goto cleanup;
        needReplaceDevDef = true;
    }

3308
    if (needBridgeChange) {
3309
        if (qemuDomainChangeNetBridge(vm, olddev, newdev) < 0)
3310 3311 3312
            goto cleanup;
        /* we successfully switched to the new bridge, and we've
         * determined that the rest of newdev is equivalent to olddev,
3313 3314 3315 3316 3317
         * so move newdev into place */
        needReplaceDevDef = true;
    }

    if (needFilterChange) {
3318
        if (qemuDomainChangeNetFilter(vm, olddev, newdev) < 0)
3319 3320 3321 3322
            goto cleanup;
        /* we successfully switched to the new filter, and we've
         * determined that the rest of newdev is equivalent to olddev,
         * so move newdev into place */
3323
        needReplaceDevDef = true;
3324 3325
    }

3326 3327 3328
    if (needLinkStateChange &&
        qemuDomainChangeNetLinkState(driver, vm, olddev, newdev->linkstate) < 0) {
        goto cleanup;
3329 3330
    }

3331 3332 3333 3334
    if (needReplaceDevDef) {
        /* the changes above warrant replacing olddev with newdev in
         * the domain's nets list.
         */
3335 3336 3337

        /* this function doesn't work with HOSTDEV networks yet, thus
         * no need to change the pointer in the hostdev structure */
3338
        networkReleaseActualDevice(vm->def, olddev);
3339 3340 3341 3342 3343 3344 3345 3346
        virDomainNetDefFree(olddev);
        /* move newdev into the nets list, and NULL it out from the
         * virDomainDeviceDef that we were given so that the caller
         * won't delete it on return.
         */
        *devslot = newdev;
        newdev = dev->data.net = NULL;
        dev->type = VIR_DOMAIN_DEVICE_NONE;
3347 3348
    }

3349
    ret = 0;
3350
 cleanup:
3351 3352 3353 3354 3355 3356 3357 3358 3359 3360 3361 3362 3363 3364 3365 3366 3367 3368 3369
    /* When we get here, we will be in one of these two states:
     *
     * 1) newdev has been moved into the domain's list of nets and
     *    newdev set to NULL, and dev->data.net will be NULL (and
     *    dev->type is NONE). olddev will have been completely
     *    released and freed. (aka success) In this case no extra
     *    cleanup is needed.
     *
     * 2) newdev has *not* been moved into the domain's list of nets,
     *    and dev->data.net == newdev (and dev->type == NET). In this *
     *    case, we need to at least release the "actual device" from *
     *    newdev (the caller will free dev->data.net a.k.a. newdev, and
     *    the original olddev is still in used)
     *
     * Note that case (2) isn't necessarily a failure. It may just be
     * that the changes were minor enough that we didn't need to
     * replace the entire device object.
     */
    if (newdev)
3370
        networkReleaseActualDevice(vm->def, newdev);
3371

3372 3373 3374
    return ret;
}

3375 3376 3377
static virDomainGraphicsDefPtr
qemuDomainFindGraphics(virDomainObjPtr vm,
                       virDomainGraphicsDefPtr dev)
3378
{
3379
    size_t i;
3380

3381
    for (i = 0; i < vm->def->ngraphics; i++) {
3382 3383 3384 3385 3386 3387 3388
        if (vm->def->graphics[i]->type == dev->type)
            return vm->def->graphics[i];
    }

    return NULL;
}

3389 3390 3391 3392 3393 3394 3395 3396 3397 3398 3399 3400 3401 3402
int
qemuDomainFindGraphicsIndex(virDomainDefPtr def,
                            virDomainGraphicsDefPtr dev)
{
    size_t i;

    for (i = 0; i < def->ngraphics; i++) {
        if (def->graphics[i]->type == dev->type)
            return i;
    }

    return -1;
}

3403
int
3404
qemuDomainChangeGraphics(virQEMUDriverPtr driver,
3405 3406 3407 3408
                         virDomainObjPtr vm,
                         virDomainGraphicsDefPtr dev)
{
    virDomainGraphicsDefPtr olddev = qemuDomainFindGraphics(vm, dev);
3409
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
3410
    const char *type = virDomainGraphicsTypeToString(dev->type);
3411
    size_t i;
3412
    int ret = -1;
3413 3414

    if (!olddev) {
3415 3416
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("cannot find existing graphics device to modify"));
3417
        goto cleanup;
3418 3419
    }

3420
    if (dev->nListens != olddev->nListens) {
3421 3422 3423
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
                       _("cannot change the number of listen addresses "
                         "on '%s' graphics"), type);
3424 3425 3426 3427
        goto cleanup;
    }

    for (i = 0; i < dev->nListens; i++) {
J
Jim Fehlig 已提交
3428
        virDomainGraphicsListenDefPtr newlisten = &dev->listens[i];
3429 3430
        virDomainGraphicsListenDefPtr oldlisten = &olddev->listens[i];

J
Jim Fehlig 已提交
3431
        if (newlisten->type != oldlisten->type) {
3432 3433 3434
            virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
                           _("cannot change the type of listen address "
                             "on '%s' graphics"), type);
3435 3436 3437
            goto cleanup;
        }

3438
        switch (newlisten->type) {
3439
        case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_ADDRESS:
J
Jim Fehlig 已提交
3440
            if (STRNEQ_NULLABLE(newlisten->address, oldlisten->address)) {
3441 3442 3443
                virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
                               _("cannot change listen address setting "
                                 "on '%s' graphics"), type);
3444 3445
                goto cleanup;
            }
3446

3447 3448 3449
            break;

        case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NETWORK:
J
Jim Fehlig 已提交
3450
            if (STRNEQ_NULLABLE(newlisten->network, oldlisten->network)) {
3451 3452 3453
                virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
                               _("cannot change listen address setting "
                                 "on '%s' graphics"), type);
3454 3455
                goto cleanup;
            }
3456

3457 3458
            break;

3459 3460 3461 3462 3463 3464 3465 3466 3467
        case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET:
            if (STRNEQ_NULLABLE(newlisten->socket, oldlisten->socket)) {
                virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
                               _("cannot change listen socket setting "
                                 "on '%s' graphics"), type);
                goto cleanup;
            }
            break;

3468 3469 3470 3471 3472 3473
        case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_NONE:
        case VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_LAST:
            /* nada */
            break;
        }
    }
3474

3475 3476
    switch (dev->type) {
    case VIR_DOMAIN_GRAPHICS_TYPE_VNC:
3477 3478 3479
        if ((olddev->data.vnc.autoport != dev->data.vnc.autoport) ||
            (!dev->data.vnc.autoport &&
             (olddev->data.vnc.port != dev->data.vnc.port))) {
3480
            virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
3481
                           _("cannot change port settings on vnc graphics"));
3482
            goto cleanup;
3483 3484
        }
        if (STRNEQ_NULLABLE(olddev->data.vnc.keymap, dev->data.vnc.keymap)) {
3485
            virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
3486
                           _("cannot change keymap setting on vnc graphics"));
3487
            goto cleanup;
3488 3489
        }

3490 3491 3492
        /* If a password lifetime was, or is set, or action if connected has
         * changed, then we must always run, even if new password matches
         * old password */
3493 3494
        if (olddev->data.vnc.auth.expires ||
            dev->data.vnc.auth.expires ||
3495
            olddev->data.vnc.auth.connected != dev->data.vnc.auth.connected ||
E
Eric Blake 已提交
3496 3497 3498
            STRNEQ_NULLABLE(olddev->data.vnc.auth.passwd,
                            dev->data.vnc.auth.passwd)) {
            VIR_DEBUG("Updating password on VNC server %p %p",
3499
                      dev->data.vnc.auth.passwd, cfg->vncPassword);
E
Eric Blake 已提交
3500 3501 3502
            ret = qemuDomainChangeGraphicsPasswords(driver, vm,
                                                    VIR_DOMAIN_GRAPHICS_TYPE_VNC,
                                                    &dev->data.vnc.auth,
3503 3504
                                                    cfg->vncPassword,
                                                    QEMU_ASYNC_JOB_NONE);
3505
            if (ret < 0)
3506
                goto cleanup;
3507 3508 3509 3510 3511

            /* Steal the new dev's  char * reference */
            VIR_FREE(olddev->data.vnc.auth.passwd);
            olddev->data.vnc.auth.passwd = dev->data.vnc.auth.passwd;
            dev->data.vnc.auth.passwd = NULL;
3512 3513
            olddev->data.vnc.auth.validTo = dev->data.vnc.auth.validTo;
            olddev->data.vnc.auth.expires = dev->data.vnc.auth.expires;
3514
            olddev->data.vnc.auth.connected = dev->data.vnc.auth.connected;
3515 3516 3517 3518 3519
        } else {
            ret = 0;
        }
        break;

3520
    case VIR_DOMAIN_GRAPHICS_TYPE_SPICE:
3521 3522 3523 3524 3525
        if ((olddev->data.spice.autoport != dev->data.spice.autoport) ||
            (!dev->data.spice.autoport &&
             (olddev->data.spice.port != dev->data.spice.port)) ||
            (!dev->data.spice.autoport &&
             (olddev->data.spice.tlsPort != dev->data.spice.tlsPort))) {
3526
            virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
3527
                           _("cannot change port settings on spice graphics"));
3528
            goto cleanup;
3529
        }
E
Eric Blake 已提交
3530 3531
        if (STRNEQ_NULLABLE(olddev->data.spice.keymap,
                            dev->data.spice.keymap)) {
3532
            virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
3533
                            _("cannot change keymap setting on spice graphics"));
3534
            goto cleanup;
3535 3536
        }

3537 3538 3539 3540 3541
        /* We must reset the password if it has changed but also if:
         * - password lifetime is or was set
         * - the requested action has changed
         * - the action is "disconnect"
         */
3542 3543
        if (olddev->data.spice.auth.expires ||
            dev->data.spice.auth.expires ||
3544
            olddev->data.spice.auth.connected != dev->data.spice.auth.connected ||
3545 3546
            dev->data.spice.auth.connected ==
            VIR_DOMAIN_GRAPHICS_AUTH_CONNECTED_DISCONNECT ||
E
Eric Blake 已提交
3547 3548 3549
            STRNEQ_NULLABLE(olddev->data.spice.auth.passwd,
                            dev->data.spice.auth.passwd)) {
            VIR_DEBUG("Updating password on SPICE server %p %p",
3550
                      dev->data.spice.auth.passwd, cfg->spicePassword);
E
Eric Blake 已提交
3551 3552 3553
            ret = qemuDomainChangeGraphicsPasswords(driver, vm,
                                                    VIR_DOMAIN_GRAPHICS_TYPE_SPICE,
                                                    &dev->data.spice.auth,
3554 3555
                                                    cfg->spicePassword,
                                                    QEMU_ASYNC_JOB_NONE);
E
Eric Blake 已提交
3556

3557
            if (ret < 0)
3558
                goto cleanup;
3559

E
Eric Blake 已提交
3560
            /* Steal the new dev's char * reference */
3561 3562 3563 3564 3565
            VIR_FREE(olddev->data.spice.auth.passwd);
            olddev->data.spice.auth.passwd = dev->data.spice.auth.passwd;
            dev->data.spice.auth.passwd = NULL;
            olddev->data.spice.auth.validTo = dev->data.spice.auth.validTo;
            olddev->data.spice.auth.expires = dev->data.spice.auth.expires;
3566
            olddev->data.spice.auth.connected = dev->data.spice.auth.connected;
3567
        } else {
3568
            VIR_DEBUG("Not updating since password didn't change");
3569 3570
            ret = 0;
        }
E
Eric Blake 已提交
3571
        break;
3572

3573
    default:
3574
        virReportError(VIR_ERR_INTERNAL_ERROR,
3575
                       _("unable to change config on '%s' graphics type"), type);
3576 3577 3578
        break;
    }

3579
 cleanup:
3580
    virObjectUnref(cfg);
3581 3582 3583 3584
    return ret;
}


3585
static int qemuComparePCIDevice(virDomainDefPtr def ATTRIBUTE_UNUSED,
3586
                                virDomainDeviceDefPtr device ATTRIBUTE_UNUSED,
3587
                                virDomainDeviceInfoPtr info1,
3588 3589
                                void *opaque)
{
3590
    virDomainDeviceInfoPtr info2 = opaque;
3591

3592 3593
    if (info1->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI ||
        info2->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI)
3594 3595
        return 0;

3596 3597 3598
    if (info1->addr.pci.domain == info2->addr.pci.domain &&
        info1->addr.pci.bus == info2->addr.pci.bus &&
        info1->addr.pci.slot == info2->addr.pci.slot &&
3599
        info1->addr.pci.function != info2->addr.pci.function)
3600 3601 3602 3603 3604 3605 3606 3607 3608 3609 3610 3611
        return -1;
    return 0;
}

static bool qemuIsMultiFunctionDevice(virDomainDefPtr def,
                                      virDomainDeviceInfoPtr dev)
{
    if (virDomainDeviceInfoIterate(def, qemuComparePCIDevice, dev) < 0)
        return true;
    return false;
}

3612

3613
static int
3614 3615 3616 3617 3618
qemuDomainRemoveDiskDevice(virQEMUDriverPtr driver,
                           virDomainObjPtr vm,
                           virDomainDiskDefPtr disk)
{
    virDomainDeviceDef dev;
3619
    virObjectEventPtr event;
3620
    size_t i;
3621
    const char *src = virDomainDiskGetSource(disk);
3622 3623
    qemuDomainObjPrivatePtr priv = vm->privateData;
    char *drivestr;
3624
    char *objAlias = NULL;
3625
    char *encAlias = NULL;
3626 3627 3628 3629

    VIR_DEBUG("Removing disk %s from domain %p %s",
              disk->info.alias, vm, vm->def->name);

3630 3631
    /* build the actual drive id string as the disk->info.alias doesn't
     * contain the QEMU_DRIVE_HOST_PREFIX that is passed to qemu */
3632
    if (!(drivestr = qemuAliasFromDisk(disk)))
3633 3634
        return -1;

3635 3636 3637 3638 3639 3640 3641 3642
    /* Let's look for some markers for a secret object and create an alias
     * object to be used to attempt to delete the object that was created.
     * We cannot just use the disk private secret info since it would have
     * been removed during cleanup of qemuProcessLaunch. Likewise, libvirtd
     * restart wouldn't have them, so no assumption can be made. */
    if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_OBJECT_SECRET) &&
        qemuDomainSecretDiskCapable(disk->src)) {

3643 3644
        if (!(objAlias =
              qemuDomainGetSecretAESAlias(disk->info.alias, false))) {
3645 3646 3647 3648 3649
            VIR_FREE(drivestr);
            return -1;
        }
    }

3650 3651 3652
    /* Similarly, if this is possible a device using LUKS encryption, we
     * can remove the luks object password too
     */
3653
    if (qemuDomainDiskHasEncryptionSecret(disk->src)) {
3654 3655 3656 3657 3658 3659 3660 3661 3662

        if (!(encAlias =
              qemuDomainGetSecretAESAlias(disk->info.alias, true))) {
            VIR_FREE(objAlias);
            VIR_FREE(drivestr);
            return -1;
        }
    }

3663
    qemuDomainObjEnterMonitor(driver, vm);
3664

3665 3666 3667
    qemuMonitorDriveDel(priv->mon, drivestr);
    VIR_FREE(drivestr);

3668 3669 3670 3671 3672
    /* If it fails, then so be it - it was a best shot */
    if (objAlias)
        ignore_value(qemuMonitorDelObject(priv->mon, objAlias));
    VIR_FREE(objAlias);

3673 3674 3675 3676 3677
    /* If it fails, then so be it - it was a best shot */
    if (encAlias)
        ignore_value(qemuMonitorDelObject(priv->mon, encAlias));
    VIR_FREE(encAlias);

3678 3679
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        return -1;
3680

3681
    virDomainAuditDisk(vm, disk->src, NULL, "detach", true);
3682

3683
    event = virDomainEventDeviceRemovedNewFromObj(vm, disk->info.alias);
3684
    qemuDomainEventQueue(driver, event);
3685

3686 3687 3688 3689 3690 3691 3692
    for (i = 0; i < vm->def->ndisks; i++) {
        if (vm->def->disks[i] == disk) {
            virDomainDiskRemove(vm->def, i);
            break;
        }
    }

3693
    qemuDomainReleaseDeviceAddress(vm, &disk->info, src);
3694

3695
    if (qemuSecurityRestoreDiskLabel(driver, vm, disk) < 0)
3696
        VIR_WARN("Unable to restore security label on %s", src);
3697 3698

    if (qemuTeardownDiskCgroup(vm, disk) < 0)
3699
        VIR_WARN("Failed to tear down cgroup for disk path %s", src);
3700 3701

    if (virDomainLockDiskDetach(driver->lockManager, vm, disk) < 0)
3702
        VIR_WARN("Unable to release lock on %s", src);
3703

3704
    if (qemuDomainNamespaceTeardownDisk(driver, vm, disk->src) < 0)
3705 3706
        VIR_WARN("Unable to remove /dev entry for %s", src);

3707 3708 3709
    dev.type = VIR_DOMAIN_DEVICE_DISK;
    dev.data.disk = disk;
    ignore_value(qemuRemoveSharedDevice(driver, &dev, vm->def->name));
3710 3711
    if (priv->usbaddrs)
        virDomainUSBAddressRelease(priv->usbaddrs, &disk->info);
3712 3713

    virDomainDiskDefFree(disk);
3714
    return 0;
3715 3716 3717
}


3718
static int
3719
qemuDomainRemoveControllerDevice(virQEMUDriverPtr driver,
3720 3721 3722
                                 virDomainObjPtr vm,
                                 virDomainControllerDefPtr controller)
{
3723
    virObjectEventPtr event;
3724 3725 3726 3727 3728
    size_t i;

    VIR_DEBUG("Removing controller %s from domain %p %s",
              controller->info.alias, vm, vm->def->name);

3729
    event = virDomainEventDeviceRemovedNewFromObj(vm, controller->info.alias);
3730
    qemuDomainEventQueue(driver, event);
3731

3732 3733 3734 3735 3736 3737 3738 3739 3740
    for (i = 0; i < vm->def->ncontrollers; i++) {
        if (vm->def->controllers[i] == controller) {
            virDomainControllerRemove(vm->def, i);
            break;
        }
    }

    qemuDomainReleaseDeviceAddress(vm, &controller->info, NULL);
    virDomainControllerDefFree(controller);
3741
    return 0;
3742 3743 3744
}


3745 3746 3747 3748 3749 3750
static int
qemuDomainRemoveMemoryDevice(virQEMUDriverPtr driver,
                             virDomainObjPtr vm,
                             virDomainMemoryDefPtr mem)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
3751
    unsigned long long oldmem = virDomainDefGetMemoryTotal(vm->def);
3752
    unsigned long long newmem = oldmem - mem->size;
3753 3754 3755 3756 3757 3758 3759 3760 3761
    virObjectEventPtr event;
    char *backendAlias = NULL;
    int rc;
    int idx;

    VIR_DEBUG("Removing memory device %s from domain %p %s",
              mem->info.alias, vm, vm->def->name);

    if (virAsprintf(&backendAlias, "mem%s", mem->info.alias) < 0)
3762
        return -1;
3763 3764 3765

    qemuDomainObjEnterMonitor(driver, vm);
    rc = qemuMonitorDelObject(priv->mon, backendAlias);
3766 3767 3768 3769 3770 3771 3772 3773
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        rc = -1;

    VIR_FREE(backendAlias);

    virDomainAuditMemory(vm, oldmem, newmem, "update", rc == 0);
    if (rc < 0)
        return -1;
3774

3775 3776 3777
    event = virDomainEventDeviceRemovedNewFromObj(vm, mem->info.alias);
    qemuDomainEventQueue(driver, event);

3778 3779 3780
    if ((idx = virDomainMemoryFindByDef(vm->def, mem)) >= 0)
        virDomainMemoryRemove(vm->def, idx);

M
Michal Privoznik 已提交
3781 3782 3783
    if (qemuSecurityRestoreMemoryLabel(driver, vm, mem) < 0)
        VIR_WARN("Unable to restore security label on memdev");

3784 3785 3786
    if (qemuTeardownMemoryDevicesCgroup(vm, mem) < 0)
        VIR_WARN("Unable to remove memory device cgroup ACL");

M
Michal Privoznik 已提交
3787 3788 3789
    if (qemuDomainNamespaceTeardownMemory(driver, vm, mem) <  0)
        VIR_WARN("Unable to remove memory device from /dev");

3790
    virDomainMemoryDefFree(mem);
3791

3792 3793 3794
    /* fix the balloon size */
    ignore_value(qemuProcessRefreshBalloonState(driver, vm, QEMU_ASYNC_JOB_NONE));

3795
    /* decrease the mlock limit after memory unplug if necessary */
3796
    ignore_value(qemuDomainAdjustMaxMemLock(vm));
3797

3798
    return 0;
3799 3800 3801
}


3802 3803 3804 3805 3806
static void
qemuDomainRemovePCIHostDevice(virQEMUDriverPtr driver,
                              virDomainObjPtr vm,
                              virDomainHostdevDefPtr hostdev)
{
3807
    qemuHostdevReAttachPCIDevices(driver, vm->def->name, &hostdev, 1);
3808 3809 3810 3811 3812
    qemuDomainReleaseDeviceAddress(vm, hostdev->info, NULL);
}

static void
qemuDomainRemoveUSBHostDevice(virQEMUDriverPtr driver,
3813
                              virDomainObjPtr vm,
3814 3815
                              virDomainHostdevDefPtr hostdev)
{
3816
    qemuHostdevReAttachUSBDevices(driver, vm->def->name, &hostdev, 1);
3817
    qemuDomainReleaseDeviceAddress(vm, hostdev->info, NULL);
3818 3819 3820 3821 3822 3823 3824
}

static void
qemuDomainRemoveSCSIHostDevice(virQEMUDriverPtr driver,
                               virDomainObjPtr vm,
                               virDomainHostdevDefPtr hostdev)
{
3825
    qemuHostdevReAttachSCSIDevices(driver, vm->def->name, &hostdev, 1);
3826 3827
}

3828 3829 3830 3831 3832 3833 3834 3835
static void
qemuDomainRemoveSCSIVHostDevice(virQEMUDriverPtr driver,
                                virDomainObjPtr vm,
                                virDomainHostdevDefPtr hostdev)
{
    qemuHostdevReAttachSCSIVHostDevices(driver, vm->def->name, &hostdev, 1);
}

3836
static int
3837 3838 3839 3840
qemuDomainRemoveHostDevice(virQEMUDriverPtr driver,
                           virDomainObjPtr vm,
                           virDomainHostdevDefPtr hostdev)
{
3841
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
3842
    virDomainNetDefPtr net = NULL;
3843
    virObjectEventPtr event;
3844
    size_t i;
3845 3846
    int ret = -1;
    qemuDomainObjPrivatePtr priv = vm->privateData;
J
John Ferlan 已提交
3847
    char *drivealias = NULL;
3848
    bool is_vfio = false;
3849 3850 3851 3852

    VIR_DEBUG("Removing host device %s from domain %p %s",
              hostdev->info->alias, vm, vm->def->name);

3853 3854 3855 3856 3857
    if (hostdev->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) {
        int backend = hostdev->source.subsys.u.pci.backend;
        is_vfio = backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO;
    }

3858
    if (hostdev->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI) {
J
John Ferlan 已提交
3859
        if (!(drivealias = qemuAliasFromHostdev(hostdev)))
3860 3861 3862
            goto cleanup;

        qemuDomainObjEnterMonitor(driver, vm);
J
John Ferlan 已提交
3863
        qemuMonitorDriveDel(priv->mon, drivealias);
3864 3865
        if (qemuDomainObjExitMonitor(driver, vm) < 0)
            goto cleanup;
3866 3867
    }

3868
    event = virDomainEventDeviceRemovedNewFromObj(vm, hostdev->info->alias);
3869
    qemuDomainEventQueue(driver, event);
3870

3871 3872 3873 3874 3875 3876 3877 3878 3879 3880 3881 3882 3883 3884 3885 3886 3887 3888 3889 3890
    if (hostdev->parent.type == VIR_DOMAIN_DEVICE_NET) {
        net = hostdev->parent.data.net;

        for (i = 0; i < vm->def->nnets; i++) {
            if (vm->def->nets[i] == net) {
                virDomainNetRemove(vm->def, i);
                break;
            }
        }
    }

    for (i = 0; i < vm->def->nhostdevs; i++) {
        if (vm->def->hostdevs[i] == hostdev) {
            virDomainHostdevRemove(vm->def, i);
            break;
        }
    }

    virDomainAuditHostdev(vm, hostdev, "detach", true);

3891
    if (!is_vfio &&
3892
        qemuSecurityRestoreHostdevLabel(driver, vm, hostdev) < 0)
3893
        VIR_WARN("Failed to restore host device labelling");
3894

3895 3896 3897
    if (qemuTeardownHostdevCgroup(vm, hostdev) < 0)
        VIR_WARN("Failed to remove host device cgroup ACL");

3898 3899 3900
    if (qemuDomainNamespaceTeardownHostdev(driver, vm, hostdev) < 0)
        VIR_WARN("Unable to remove host device from /dev");

3901
    switch ((virDomainHostdevSubsysType) hostdev->source.subsys.type) {
3902 3903
    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI:
        qemuDomainRemovePCIHostDevice(driver, vm, hostdev);
3904 3905 3906 3907
        /* QEMU might no longer need to lock as much memory, eg. we just
         * detached the last VFIO device, so adjust the limit here */
        if (qemuDomainAdjustMaxMemLock(vm) < 0)
            VIR_WARN("Failed to adjust locked memory limit");
3908 3909 3910 3911 3912 3913 3914
        break;
    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB:
        qemuDomainRemoveUSBHostDevice(driver, vm, hostdev);
        break;
    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI:
        qemuDomainRemoveSCSIHostDevice(driver, vm, hostdev);
        break;
3915
    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI_HOST:
3916
        qemuDomainRemoveSCSIVHostDevice(driver, vm, hostdev);
3917
        break;
3918 3919
    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV:
        break;
3920 3921 3922 3923 3924 3925 3926
    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST:
        break;
    }

    virDomainHostdevDefFree(hostdev);

    if (net) {
3927
        networkReleaseActualDevice(vm->def, net);
3928 3929
        virDomainNetDefFree(net);
    }
3930

3931 3932 3933
    ret = 0;

 cleanup:
J
John Ferlan 已提交
3934
    VIR_FREE(drivealias);
3935
    virObjectUnref(cfg);
3936
    return ret;
3937 3938 3939
}


3940
static int
3941 3942 3943 3944 3945
qemuDomainRemoveNetDevice(virQEMUDriverPtr driver,
                          virDomainObjPtr vm,
                          virDomainNetDefPtr net)
{
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
3946
    qemuDomainObjPrivatePtr priv = vm->privateData;
3947
    virNetDevVPortProfilePtr vport;
3948
    virObjectEventPtr event;
3949
    char *hostnet_name = NULL;
3950
    char *charDevAlias = NULL;
3951
    size_t i;
3952
    int ret = -1;
3953
    int actualType = virDomainNetGetActualType(net);
3954

3955
    if (actualType == VIR_DOMAIN_NET_TYPE_HOSTDEV) {
3956
        /* this function handles all hostdev and netdev cleanup */
3957 3958
        ret = qemuDomainRemoveHostDevice(driver, vm,
                                         virDomainNetGetActualHostdev(net));
3959
        goto cleanup;
3960 3961
    }

3962 3963 3964
    VIR_DEBUG("Removing network interface %s from domain %p %s",
              net->info.alias, vm, vm->def->name);

3965
    if (virAsprintf(&hostnet_name, "host%s", net->info.alias) < 0 ||
3966
        !(charDevAlias = qemuAliasChardevFromDevAlias(net->info.alias)))
3967 3968
        goto cleanup;

3969

3970
    qemuDomainObjEnterMonitor(driver, vm);
3971
    if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_NETDEV)) {
3972
        if (qemuMonitorRemoveNetdev(priv->mon, hostnet_name) < 0) {
3973 3974
            if (qemuDomainObjExitMonitor(driver, vm) < 0)
                goto cleanup;
3975 3976 3977 3978 3979 3980 3981 3982 3983 3984 3985
            virDomainAuditNet(vm, net, NULL, "detach", false);
            goto cleanup;
        }
    } else {
        int vlan;
        if ((vlan = qemuDomainNetVLAN(net)) < 0 ||
            qemuMonitorRemoveHostNetwork(priv->mon, vlan, hostnet_name) < 0) {
            if (vlan < 0) {
                virReportError(VIR_ERR_OPERATION_FAILED, "%s",
                               _("unable to determine original VLAN"));
            }
3986 3987
            if (qemuDomainObjExitMonitor(driver, vm) < 0)
                goto cleanup;
3988 3989 3990 3991
            virDomainAuditNet(vm, net, NULL, "detach", false);
            goto cleanup;
        }
    }
3992 3993 3994 3995 3996 3997 3998 3999 4000 4001 4002

    if (actualType == VIR_DOMAIN_NET_TYPE_VHOSTUSER) {
        /* vhostuser has a chardev too */
        if (qemuMonitorDetachCharDev(priv->mon, charDevAlias) < 0) {
            /* well, this is a messy situation. Guest visible PCI device has
             * been removed, netdev too but chardev not. The best seems to be
             * to just ignore the error and carry on.
             */
        }
    }

4003 4004
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        goto cleanup;
4005

4006 4007 4008
    virDomainAuditNet(vm, net, NULL, "detach", true);

    event = virDomainEventDeviceRemovedNewFromObj(vm, net->info.alias);
4009
    qemuDomainEventQueue(driver, event);
4010 4011 4012 4013 4014 4015 4016 4017 4018 4019 4020

    for (i = 0; i < vm->def->nnets; i++) {
        if (vm->def->nets[i] == net) {
            virDomainNetRemove(vm->def, i);
            break;
        }
    }

    qemuDomainReleaseDeviceAddress(vm, &net->info, NULL);
    virDomainConfNWFilterTeardown(net);

4021 4022 4023 4024 4025 4026
    if (cfg->macFilter && (net->ifname != NULL)) {
        ignore_value(ebtablesRemoveForwardAllowIn(driver->ebtables,
                                                  net->ifname,
                                                  &net->mac));
    }

4027
    if (actualType == VIR_DOMAIN_NET_TYPE_DIRECT) {
4028 4029 4030 4031 4032 4033 4034 4035 4036
        ignore_value(virNetDevMacVLanDeleteWithVPortProfile(
                         net->ifname, &net->mac,
                         virDomainNetGetActualDirectDev(net),
                         virDomainNetGetActualDirectMode(net),
                         virDomainNetGetActualVirtPortProfile(net),
                         cfg->stateDir));
    }

    vport = virDomainNetGetActualVirtPortProfile(net);
4037 4038 4039 4040 4041 4042 4043 4044 4045
    if (vport) {
        if (vport->virtPortType == VIR_NETDEV_VPORT_PROFILE_MIDONET) {
            ignore_value(virNetDevMidonetUnbindPort(vport));
        } else if (vport->virtPortType == VIR_NETDEV_VPORT_PROFILE_OPENVSWITCH) {
            ignore_value(virNetDevOpenvswitchRemovePort(
                             virDomainNetGetActualBridgeName(net),
                             net->ifname));
        }
    }
4046

4047
    networkReleaseActualDevice(vm->def, net);
4048
    virDomainNetDefFree(net);
4049
    ret = 0;
4050 4051

 cleanup:
4052
    virObjectUnref(cfg);
4053
    VIR_FREE(charDevAlias);
4054 4055
    VIR_FREE(hostnet_name);
    return ret;
4056 4057 4058
}


4059
static int
4060
qemuDomainRemoveChrDevice(virQEMUDriverPtr driver,
4061 4062 4063
                          virDomainObjPtr vm,
                          virDomainChrDefPtr chr)
{
4064
    virObjectEventPtr event;
4065
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
4066
    char *charAlias = NULL;
4067
    char *tlsAlias = NULL;
4068
    char *secAlias = NULL;
4069 4070
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int ret = -1;
4071
    int rc;
4072

4073 4074 4075
    VIR_DEBUG("Removing character device %s from domain %p %s",
              chr->info.alias, vm, vm->def->name);

4076
    if (!(charAlias = qemuAliasChardevFromDevAlias(chr->info.alias)))
4077 4078
        goto cleanup;

4079
    if (chr->source->type == VIR_DOMAIN_CHR_TYPE_TCP &&
4080 4081
        chr->source->data.tcp.haveTLS == VIR_TRISTATE_BOOL_YES) {

4082
        if (!(tlsAlias = qemuAliasTLSObjFromSrcAlias(charAlias)))
4083 4084 4085 4086 4087 4088 4089 4090 4091 4092
            goto cleanup;

        /* Best shot at this as the secinfo is destroyed after process launch
         * and this path does not recreate it. Thus, if the config has the
         * secret UUID and we have a serial TCP chardev, then formulate a
         * secAlias which we'll attempt to destroy. */
        if (cfg->chardevTLSx509secretUUID &&
            !(secAlias = qemuDomainGetSecretAESAlias(charAlias, false)))
            goto cleanup;
    }
4093

4094
    qemuDomainObjEnterMonitor(driver, vm);
4095
    rc = qemuMonitorDetachCharDev(priv->mon, charAlias);
4096

4097 4098 4099 4100 4101 4102
    if (rc == 0) {
        if (tlsAlias)
            ignore_value(qemuMonitorDelObject(priv->mon, tlsAlias));
        if (secAlias)
            ignore_value(qemuMonitorDelObject(priv->mon, secAlias));
    }
4103

4104 4105
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        goto cleanup;
4106

4107 4108 4109 4110 4111
    virDomainAuditChardev(vm, chr, NULL, "detach", rc == 0);

    if (rc < 0)
        goto cleanup;

4112 4113 4114
    if (qemuTeardownChardevCgroup(vm, chr) < 0)
        VIR_WARN("Failed to remove chr device cgroup ACL");

4115 4116 4117
    if (qemuDomainNamespaceTeardownChardev(driver, vm, chr) < 0)
        VIR_WARN("Unable to remove chr device from /dev");

4118
    event = virDomainEventDeviceRemovedNewFromObj(vm, chr->info.alias);
4119
    qemuDomainEventQueue(driver, event);
4120

4121 4122
    qemuDomainChrRemove(vm->def, chr);
    virDomainChrDefFree(chr);
4123 4124 4125 4126
    ret = 0;

 cleanup:
    VIR_FREE(charAlias);
4127
    VIR_FREE(tlsAlias);
4128
    VIR_FREE(secAlias);
4129
    virObjectUnref(cfg);
4130
    return ret;
4131 4132 4133
}


4134 4135 4136 4137 4138 4139
static int
qemuDomainRemoveRNGDevice(virQEMUDriverPtr driver,
                          virDomainObjPtr vm,
                          virDomainRNGDefPtr rng)
{
    virObjectEventPtr event;
4140
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
4141 4142
    char *charAlias = NULL;
    char *objAlias = NULL;
4143
    char *tlsAlias = NULL;
4144
    char *secAlias = NULL;
4145 4146 4147 4148 4149 4150 4151 4152
    qemuDomainObjPrivatePtr priv = vm->privateData;
    ssize_t idx;
    int ret = -1;
    int rc;

    VIR_DEBUG("Removing RNG device %s from domain %p %s",
              rng->info.alias, vm, vm->def->name);

4153

4154 4155 4156
    if (virAsprintf(&objAlias, "obj%s", rng->info.alias) < 0)
        goto cleanup;

4157
    if (!(charAlias = qemuAliasChardevFromDevAlias(rng->info.alias)))
4158 4159
        goto cleanup;

4160
    if (rng->backend == VIR_DOMAIN_RNG_BACKEND_EGD) {
4161
        if (!(tlsAlias = qemuAliasTLSObjFromSrcAlias(charAlias)))
4162 4163 4164 4165 4166 4167 4168 4169 4170 4171
            goto cleanup;

        /* Best shot at this as the secinfo is destroyed after process launch
         * and this path does not recreate it. Thus, if the config has the
         * secret UUID and we have a serial TCP chardev, then formulate a
         * secAlias which we'll attempt to destroy. */
        if (cfg->chardevTLSx509secretUUID &&
            !(secAlias = qemuDomainGetSecretAESAlias(charAlias, false)))
            goto cleanup;
    }
4172

4173
    qemuDomainObjEnterMonitor(driver, vm);
4174

4175 4176
    rc = qemuMonitorDelObject(priv->mon, objAlias);

4177
    if (rc == 0 && rng->backend == VIR_DOMAIN_RNG_BACKEND_EGD) {
4178
        ignore_value(qemuMonitorDetachCharDev(priv->mon, charAlias));
4179 4180
        if (tlsAlias)
            ignore_value(qemuMonitorDelObject(priv->mon, tlsAlias));
4181 4182
        if (secAlias)
            ignore_value(qemuMonitorDelObject(priv->mon, secAlias));
4183
    }
4184 4185 4186 4187 4188 4189 4190 4191 4192

    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        goto cleanup;

    virDomainAuditRNG(vm, rng, NULL, "detach", rc == 0);

    if (rc < 0)
        goto cleanup;

4193 4194 4195
    if (qemuTeardownRNGCgroup(vm, rng) < 0)
        VIR_WARN("Failed to remove RNG device cgroup ACL");

4196 4197 4198
    if (qemuDomainNamespaceTeardownRNG(driver, vm, rng) < 0)
        VIR_WARN("Unable to remove RNG device from /dev");

4199 4200
    event = virDomainEventDeviceRemovedNewFromObj(vm, rng->info.alias);
    qemuDomainEventQueue(driver, event);
4201 4202 4203 4204 4205 4206 4207 4208 4209 4210

    if ((idx = virDomainRNGFind(vm->def, rng)) >= 0)
        virDomainRNGRemove(vm->def, idx);
    qemuDomainReleaseDeviceAddress(vm, &rng->info, NULL);
    virDomainRNGDefFree(rng);
    ret = 0;

 cleanup:
    VIR_FREE(charAlias);
    VIR_FREE(objAlias);
4211
    VIR_FREE(tlsAlias);
4212 4213
    VIR_FREE(secAlias);
    virObjectUnref(cfg);
4214 4215 4216 4217
    return ret;
}


4218 4219 4220 4221 4222 4223 4224 4225 4226 4227 4228 4229 4230 4231 4232 4233 4234 4235 4236 4237 4238 4239 4240 4241 4242 4243 4244 4245 4246 4247 4248 4249 4250 4251 4252 4253 4254 4255 4256 4257 4258 4259 4260 4261 4262 4263 4264 4265 4266 4267 4268 4269 4270 4271 4272 4273
static int
qemuDomainRemoveShmemDevice(virQEMUDriverPtr driver,
                            virDomainObjPtr vm,
                            virDomainShmemDefPtr shmem)
{
    int rc;
    int ret = -1;
    ssize_t idx = -1;
    char *charAlias = NULL;
    char *memAlias = NULL;
    qemuDomainObjPrivatePtr priv = vm->privateData;
    virObjectEventPtr event = NULL;

    VIR_DEBUG("Removing shmem device %s from domain %p %s",
              shmem->info.alias, vm, vm->def->name);

    if (shmem->server.enabled) {
        if (virAsprintf(&charAlias, "char%s", shmem->info.alias) < 0)
            return -1;
    } else {
        if (virAsprintf(&memAlias, "shmmem-%s", shmem->info.alias) < 0)
            return -1;
    }

    qemuDomainObjEnterMonitor(driver, vm);

    if (shmem->server.enabled)
        rc = qemuMonitorDetachCharDev(priv->mon, charAlias);
    else
        rc = qemuMonitorDelObject(priv->mon, memAlias);

    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        goto cleanup;

    virDomainAuditShmem(vm, shmem, "detach", rc == 0);

    if (rc < 0)
        goto cleanup;

    event = virDomainEventDeviceRemovedNewFromObj(vm, shmem->info.alias);
    qemuDomainEventQueue(driver, event);

    if ((idx = virDomainShmemDefFind(vm->def, shmem)) >= 0)
        virDomainShmemDefRemove(vm->def, idx);
    qemuDomainReleaseDeviceAddress(vm, &shmem->info, NULL);
    virDomainShmemDefFree(shmem);

    ret = 0;
 cleanup:
    VIR_FREE(charAlias);
    VIR_FREE(memAlias);

    return ret;
}


4274
int
4275 4276 4277 4278
qemuDomainRemoveDevice(virQEMUDriverPtr driver,
                       virDomainObjPtr vm,
                       virDomainDeviceDefPtr dev)
{
4279
    int ret = -1;
4280 4281
    switch ((virDomainDeviceType) dev->type) {
    case VIR_DOMAIN_DEVICE_DISK:
4282
        ret = qemuDomainRemoveDiskDevice(driver, vm, dev->data.disk);
4283 4284
        break;
    case VIR_DOMAIN_DEVICE_CONTROLLER:
4285
        ret = qemuDomainRemoveControllerDevice(driver, vm, dev->data.controller);
4286 4287
        break;
    case VIR_DOMAIN_DEVICE_NET:
4288
        ret = qemuDomainRemoveNetDevice(driver, vm, dev->data.net);
4289 4290
        break;
    case VIR_DOMAIN_DEVICE_HOSTDEV:
4291
        ret = qemuDomainRemoveHostDevice(driver, vm, dev->data.hostdev);
4292 4293 4294
        break;

    case VIR_DOMAIN_DEVICE_CHR:
4295
        ret = qemuDomainRemoveChrDevice(driver, vm, dev->data.chr);
4296
        break;
4297
    case VIR_DOMAIN_DEVICE_RNG:
4298
        ret = qemuDomainRemoveRNGDevice(driver, vm, dev->data.rng);
4299
        break;
4300

4301
    case VIR_DOMAIN_DEVICE_MEMORY:
4302 4303
        ret = qemuDomainRemoveMemoryDevice(driver, vm, dev->data.memory);
        break;
4304

4305 4306 4307 4308
    case VIR_DOMAIN_DEVICE_SHMEM:
        ret = qemuDomainRemoveShmemDevice(driver, vm, dev->data.shmem);
        break;

4309 4310 4311 4312 4313 4314 4315 4316 4317 4318 4319 4320 4321
    case VIR_DOMAIN_DEVICE_NONE:
    case VIR_DOMAIN_DEVICE_LEASE:
    case VIR_DOMAIN_DEVICE_FS:
    case VIR_DOMAIN_DEVICE_INPUT:
    case VIR_DOMAIN_DEVICE_SOUND:
    case VIR_DOMAIN_DEVICE_VIDEO:
    case VIR_DOMAIN_DEVICE_WATCHDOG:
    case VIR_DOMAIN_DEVICE_GRAPHICS:
    case VIR_DOMAIN_DEVICE_HUB:
    case VIR_DOMAIN_DEVICE_REDIRDEV:
    case VIR_DOMAIN_DEVICE_SMARTCARD:
    case VIR_DOMAIN_DEVICE_MEMBALLOON:
    case VIR_DOMAIN_DEVICE_NVRAM:
4322
    case VIR_DOMAIN_DEVICE_TPM:
4323
    case VIR_DOMAIN_DEVICE_PANIC:
J
Ján Tomko 已提交
4324
    case VIR_DOMAIN_DEVICE_IOMMU:
4325 4326 4327 4328 4329 4330
    case VIR_DOMAIN_DEVICE_LAST:
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
                       _("don't know how to remove a %s device"),
                       virDomainDeviceTypeToString(dev->type));
        break;
    }
4331
    return ret;
4332 4333 4334 4335
}


static void
4336 4337
qemuDomainMarkDeviceAliasForRemoval(virDomainObjPtr vm,
                                    const char *alias)
4338 4339 4340
{
    qemuDomainObjPrivatePtr priv = vm->privateData;

4341 4342 4343 4344 4345
    memset(&priv->unplug, 0, sizeof(priv->unplug));

    if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DEVICE_DEL_EVENT))
        return;

4346
    priv->unplug.alias = alias;
4347 4348
}

4349 4350 4351 4352 4353 4354 4355 4356 4357 4358

static void
qemuDomainMarkDeviceForRemoval(virDomainObjPtr vm,
                               virDomainDeviceInfoPtr info)

{
    qemuDomainMarkDeviceAliasForRemoval(vm, info->alias);
}


4359 4360 4361 4362
static void
qemuDomainResetDeviceRemoval(virDomainObjPtr vm)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
4363
    priv->unplug.alias = NULL;
4364 4365 4366
}

/* Returns:
4367 4368
 *  -1 Unplug of the device failed
 *
4369 4370 4371 4372 4373 4374 4375
 *   0 DEVICE_DELETED event is supported and removal of the device did not
 *     finish in qemuDomainRemoveDeviceWaitTime
 *
 *   1 when the caller is responsible for finishing the device removal:
 *      - DEVICE_DELETED event is unsupported
 *      - DEVICE_DELETED event arrived before the timeout time
 *      - we failed to reliably wait for the event and thus use fallback behavior
4376 4377 4378 4379 4380 4381
 */
static int
qemuDomainWaitForDeviceRemoval(virDomainObjPtr vm)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    unsigned long long until;
4382
    int rc;
4383 4384

    if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DEVICE_DEL_EVENT))
4385
        return 1;
4386 4387

    if (virTimeMillisNow(&until) < 0)
4388
        return 1;
4389
    until += qemuDomainRemoveDeviceWaitTime;
4390

4391
    while (priv->unplug.alias) {
4392 4393 4394 4395 4396
        if ((rc = virDomainObjWaitUntil(vm, until)) == 1)
            return 0;

        if (rc < 0) {
            VIR_WARN("Failed to wait on unplug condition for domain '%s' "
4397
                     "device '%s'", vm->def->name, priv->unplug.alias);
4398
            return 1;
4399 4400 4401
        }
    }

4402 4403 4404 4405 4406 4407
    if (priv->unplug.status == QEMU_DOMAIN_UNPLUGGING_DEVICE_STATUS_GUEST_REJECTED) {
        virReportError(VIR_ERR_OPERATION_FAILED, "%s",
                       _("unplug of device was rejected by the guest"));
        return -1;
    }

4408 4409 4410
    return 1;
}

4411 4412 4413 4414 4415 4416 4417
/* Returns:
 *  true    there was a thread waiting for devAlias to be removed and this
 *          thread will take care of finishing the removal
 *  false   the thread that started the removal is already gone and delegate
 *          finishing the removal to a new thread
 */
bool
4418
qemuDomainSignalDeviceRemoval(virDomainObjPtr vm,
4419 4420
                              const char *devAlias,
                              qemuDomainUnpluggingDeviceStatus status)
4421 4422 4423
{
    qemuDomainObjPrivatePtr priv = vm->privateData;

4424
    if (STREQ_NULLABLE(priv->unplug.alias, devAlias)) {
4425
        VIR_DEBUG("Removal of device '%s' continues in waiting thread", devAlias);
4426
        qemuDomainResetDeviceRemoval(vm);
4427
        priv->unplug.status = status;
4428
        virDomainObjBroadcast(vm);
4429
        return true;
4430
    }
4431
    return false;
4432 4433 4434
}


4435 4436 4437 4438
static int
qemuDomainDetachVirtioDiskDevice(virQEMUDriverPtr driver,
                                 virDomainObjPtr vm,
                                 virDomainDiskDefPtr detach)
4439
{
4440
    int ret = -1;
4441 4442
    qemuDomainObjPrivatePtr priv = vm->privateData;

4443
    if (qemuIsMultiFunctionDevice(vm->def, &detach->info)) {
4444 4445
        virReportError(VIR_ERR_OPERATION_FAILED,
                       _("cannot hot unplug multifunction PCI device: %s"),
4446
                       detach->dst);
4447 4448 4449
        goto cleanup;
    }

4450
    if (qemuDomainIsS390CCW(vm->def) &&
4451 4452 4453 4454 4455 4456 4457 4458 4459 4460 4461 4462 4463 4464
        virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_VIRTIO_CCW)) {
        if (!virDomainDeviceAddressIsValid(&detach->info,
                                           VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW)) {
            virReportError(VIR_ERR_OPERATION_FAILED, "%s",
                           _("device cannot be detached without a valid CCW address"));
            goto cleanup;
        }
    } else {
        if (!virDomainDeviceAddressIsValid(&detach->info,
                                           VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI)) {
            virReportError(VIR_ERR_OPERATION_FAILED, "%s",
                           _("device cannot be detached without a valid PCI address"));
            goto cleanup;
        }
4465 4466
    }

4467
    if (!detach->info.alias) {
4468 4469 4470 4471
        if (qemuAssignDeviceDiskAlias(vm->def, detach, priv->qemuCaps) < 0)
            goto cleanup;
    }

4472 4473
    qemuDomainMarkDeviceForRemoval(vm, &detach->info);

4474
    qemuDomainObjEnterMonitor(driver, vm);
4475 4476
    if (qemuMonitorDelDevice(priv->mon, detach->info.alias) < 0) {
        if (qemuDomainObjExitMonitor(driver, vm) < 0)
4477
            goto cleanup;
4478 4479
        virDomainAuditDisk(vm, detach->src, NULL, "detach", false);
        goto cleanup;
4480
    }
4481 4482
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        goto cleanup;
4483

4484
    if ((ret = qemuDomainWaitForDeviceRemoval(vm)) == 1)
4485
        ret = qemuDomainRemoveDiskDevice(driver, vm, detach);
4486

4487
 cleanup:
4488
    qemuDomainResetDeviceRemoval(vm);
4489 4490 4491
    return ret;
}

4492 4493 4494 4495
static int
qemuDomainDetachDiskDevice(virQEMUDriverPtr driver,
                           virDomainObjPtr vm,
                           virDomainDiskDefPtr detach)
4496
{
4497
    int ret = -1;
4498 4499
    qemuDomainObjPrivatePtr priv = vm->privateData;

4500
    if (qemuDomainDiskBlockJobIsActive(detach))
E
Eric Blake 已提交
4501 4502
        goto cleanup;

4503 4504
    qemuDomainMarkDeviceForRemoval(vm, &detach->info);

4505
    qemuDomainObjEnterMonitor(driver, vm);
4506
    if (qemuMonitorDelDevice(priv->mon, detach->info.alias) < 0) {
4507 4508
        if (qemuDomainObjExitMonitor(driver, vm) < 0)
            goto cleanup;
4509
        virDomainAuditDisk(vm, detach->src, NULL, "detach", false);
4510 4511
        goto cleanup;
    }
4512 4513
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        goto cleanup;
4514

4515
    if ((ret = qemuDomainWaitForDeviceRemoval(vm)) == 1)
4516
        ret = qemuDomainRemoveDiskDevice(driver, vm, detach);
4517

4518
 cleanup:
4519
    qemuDomainResetDeviceRemoval(vm);
4520 4521 4522
    return ret;
}

4523 4524 4525 4526 4527 4528
static int
qemuFindDisk(virDomainDefPtr def, const char *dst)
{
    size_t i;

    for (i = 0; i < def->ndisks; i++) {
4529
        if (STREQ(def->disks[i]->dst, dst))
4530 4531 4532 4533 4534 4535 4536 4537 4538 4539 4540 4541 4542 4543 4544 4545 4546 4547 4548 4549 4550 4551 4552 4553 4554 4555 4556 4557 4558 4559 4560 4561 4562 4563 4564 4565 4566 4567 4568 4569 4570 4571 4572 4573 4574
            return i;
    }

    return -1;
}

int
qemuDomainDetachDeviceDiskLive(virQEMUDriverPtr driver,
                               virDomainObjPtr vm,
                               virDomainDeviceDefPtr dev)
{
    virDomainDiskDefPtr disk;
    int ret = -1;
    int idx;

    if ((idx = qemuFindDisk(vm->def, dev->data.disk->dst)) < 0) {
        virReportError(VIR_ERR_OPERATION_FAILED,
                       _("disk %s not found"), dev->data.disk->dst);
        return -1;
    }
    disk = vm->def->disks[idx];

    switch (disk->device) {
    case VIR_DOMAIN_DISK_DEVICE_DISK:
    case VIR_DOMAIN_DISK_DEVICE_LUN:
        if (disk->bus == VIR_DOMAIN_DISK_BUS_VIRTIO)
            ret = qemuDomainDetachVirtioDiskDevice(driver, vm, disk);
        else if (disk->bus == VIR_DOMAIN_DISK_BUS_SCSI ||
                 disk->bus == VIR_DOMAIN_DISK_BUS_USB)
            ret = qemuDomainDetachDiskDevice(driver, vm, disk);
        else
            virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
                           _("This type of disk cannot be hot unplugged"));
        break;
    default:
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
                       _("disk device type '%s' cannot be detached"),
                       virDomainDiskDeviceTypeToString(disk->device));
        break;
    }

    return ret;
}


4575 4576 4577
static bool qemuDomainDiskControllerIsBusy(virDomainObjPtr vm,
                                           virDomainControllerDefPtr detach)
{
4578
    size_t i;
4579
    virDomainDiskDefPtr disk;
4580
    virDomainHostdevDefPtr hostdev;
4581 4582 4583 4584 4585 4586 4587 4588 4589 4590 4591 4592 4593 4594 4595 4596 4597 4598 4599 4600 4601 4602

    for (i = 0; i < vm->def->ndisks; i++) {
        disk = vm->def->disks[i];
        if (disk->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_DRIVE)
            /* the disk does not use disk controller */
            continue;

        /* check whether the disk uses this type controller */
        if (disk->bus == VIR_DOMAIN_DISK_BUS_IDE &&
            detach->type != VIR_DOMAIN_CONTROLLER_TYPE_IDE)
            continue;
        if (disk->bus == VIR_DOMAIN_DISK_BUS_FDC &&
            detach->type != VIR_DOMAIN_CONTROLLER_TYPE_FDC)
            continue;
        if (disk->bus == VIR_DOMAIN_DISK_BUS_SCSI &&
            detach->type != VIR_DOMAIN_CONTROLLER_TYPE_SCSI)
            continue;

        if (disk->info.addr.drive.controller == detach->idx)
            return true;
    }

4603 4604 4605 4606 4607 4608 4609 4610 4611
    for (i = 0; i < vm->def->nhostdevs; i++) {
        hostdev = vm->def->hostdevs[i];
        if (!virHostdevIsSCSIDevice(hostdev) ||
            detach->type != VIR_DOMAIN_CONTROLLER_TYPE_SCSI)
            continue;
        if (hostdev->info->addr.drive.controller == detach->idx)
            return true;
    }

4612 4613 4614 4615 4616 4617 4618 4619 4620 4621 4622 4623 4624 4625 4626 4627 4628 4629 4630 4631 4632 4633 4634
    return false;
}

static bool qemuDomainControllerIsBusy(virDomainObjPtr vm,
                                       virDomainControllerDefPtr detach)
{
    switch (detach->type) {
    case VIR_DOMAIN_CONTROLLER_TYPE_IDE:
    case VIR_DOMAIN_CONTROLLER_TYPE_FDC:
    case VIR_DOMAIN_CONTROLLER_TYPE_SCSI:
        return qemuDomainDiskControllerIsBusy(vm, detach);

    case VIR_DOMAIN_CONTROLLER_TYPE_SATA:
    case VIR_DOMAIN_CONTROLLER_TYPE_VIRTIO_SERIAL:
    case VIR_DOMAIN_CONTROLLER_TYPE_CCID:
    default:
        /* libvirt does not support sata controller, and does not support to
         * detach virtio and smart card controller.
         */
        return true;
    }
}

4635 4636 4637
int qemuDomainDetachControllerDevice(virQEMUDriverPtr driver,
                                     virDomainObjPtr vm,
                                     virDomainDeviceDefPtr dev)
4638
{
4639
    int idx, ret = -1;
4640 4641 4642
    virDomainControllerDefPtr detach = NULL;
    qemuDomainObjPrivatePtr priv = vm->privateData;

4643 4644 4645
    if ((idx = virDomainControllerFind(vm->def,
                                       dev->data.controller->type,
                                       dev->data.controller->idx)) < 0) {
4646
        virReportError(VIR_ERR_OPERATION_FAILED,
4647
                       _("controller %s:%d not found"),
4648 4649
                       virDomainControllerTypeToString(dev->data.controller->type),
                       dev->data.controller->idx);
4650 4651 4652
        goto cleanup;
    }

4653 4654
    detach = vm->def->controllers[idx];

4655 4656 4657 4658 4659 4660
    if (detach->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI &&
        detach->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW &&
        detach->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_S390) {
        virReportError(VIR_ERR_OPERATION_FAILED,
                       _("device with '%s' address cannot be detached"),
                       virDomainDeviceAddressTypeToString(detach->info.type));
4661 4662 4663
        goto cleanup;
    }

4664 4665 4666 4667 4668 4669 4670 4671 4672
    if (!virDomainDeviceAddressIsValid(&detach->info, detach->info.type)) {
        virReportError(VIR_ERR_OPERATION_FAILED,
                       _("device with invalid '%s' address cannot be detached"),
                       virDomainDeviceAddressTypeToString(detach->info.type));
        goto cleanup;
    }

    if (detach->info.type == VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI &&
        qemuIsMultiFunctionDevice(vm->def, &detach->info)) {
4673 4674 4675
        virReportError(VIR_ERR_OPERATION_FAILED,
                       _("cannot hot unplug multifunction PCI device: %s"),
                       dev->data.disk->dst);
4676 4677 4678
        goto cleanup;
    }

4679
    if (qemuDomainControllerIsBusy(vm, detach)) {
4680 4681
        virReportError(VIR_ERR_OPERATION_FAILED, "%s",
                       _("device cannot be detached: device is busy"));
4682 4683 4684
        goto cleanup;
    }

4685
    if (!detach->info.alias) {
4686
        if (qemuAssignDeviceControllerAlias(vm->def, priv->qemuCaps, detach) < 0)
4687 4688 4689
            goto cleanup;
    }

4690 4691
    qemuDomainMarkDeviceForRemoval(vm, &detach->info);

4692
    qemuDomainObjEnterMonitor(driver, vm);
4693 4694 4695
    if (qemuMonitorDelDevice(priv->mon, detach->info.alias)) {
        ignore_value(qemuDomainObjExitMonitor(driver, vm));
        goto cleanup;
4696
    }
4697 4698
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        goto cleanup;
4699

4700
    if ((ret = qemuDomainWaitForDeviceRemoval(vm)) == 1)
4701
        ret = qemuDomainRemoveControllerDevice(driver, vm, detach);
4702

4703
 cleanup:
4704
    qemuDomainResetDeviceRemoval(vm);
4705 4706 4707
    return ret;
}

4708
static int
4709
qemuDomainDetachHostPCIDevice(virQEMUDriverPtr driver,
4710
                              virDomainObjPtr vm,
4711
                              virDomainHostdevDefPtr detach)
4712 4713
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
4714
    virDomainHostdevSubsysPCIPtr pcisrc = &detach->source.subsys.u.pci;
4715
    int ret;
4716

4717
    if (qemuIsMultiFunctionDevice(vm->def, detach->info)) {
4718 4719
        virReportError(VIR_ERR_OPERATION_FAILED,
                       _("cannot hot unplug multifunction PCI device: %.4x:%.2x:%.2x.%.1x"),
4720 4721
                       pcisrc->addr.domain, pcisrc->addr.bus,
                       pcisrc->addr.slot, pcisrc->addr.function);
4722
        return -1;
4723 4724
    }

4725
    if (!virDomainDeviceAddressIsValid(detach->info,
4726
                                       VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI)) {
4727 4728
        virReportError(VIR_ERR_OPERATION_FAILED,
                       "%s", _("device cannot be detached without a PCI address"));
4729
        return -1;
4730 4731
    }

4732 4733
    qemuDomainMarkDeviceForRemoval(vm, detach->info);

4734
    qemuDomainObjEnterMonitor(driver, vm);
4735
    ret = qemuMonitorDelDevice(priv->mon, detach->info->alias);
4736 4737
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        ret = -1;
4738 4739 4740 4741

    return ret;
}

4742
static int
4743
qemuDomainDetachHostUSBDevice(virQEMUDriverPtr driver,
4744
                              virDomainObjPtr vm,
4745
                              virDomainHostdevDefPtr detach)
4746 4747
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
4748
    int ret;
4749

4750
    if (!detach->info->alias) {
4751 4752
        virReportError(VIR_ERR_OPERATION_FAILED,
                       "%s", _("device cannot be detached without a device alias"));
4753 4754 4755
        return -1;
    }

4756 4757
    qemuDomainMarkDeviceForRemoval(vm, detach->info);

4758
    qemuDomainObjEnterMonitor(driver, vm);
4759
    ret = qemuMonitorDelDevice(priv->mon, detach->info->alias);
4760 4761
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        ret = -1;
4762 4763 4764 4765

    return ret;
}

4766
static int
4767
qemuDomainDetachHostSCSIDevice(virQEMUDriverPtr driver,
4768 4769 4770 4771 4772 4773 4774 4775 4776 4777 4778 4779
                               virDomainObjPtr vm,
                               virDomainHostdevDefPtr detach)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int ret = -1;

    if (!detach->info->alias) {
        virReportError(VIR_ERR_OPERATION_FAILED,
                       "%s", _("device cannot be detached without a device alias"));
        return -1;
    }

4780 4781
    qemuDomainMarkDeviceForRemoval(vm, detach->info);

4782
    qemuDomainObjEnterMonitor(driver, vm);
4783 4784 4785 4786
    ret = qemuMonitorDelDevice(priv->mon, detach->info->alias);

    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        return -1;
4787 4788 4789 4790

    return ret;
}

4791 4792 4793 4794 4795 4796 4797 4798 4799 4800 4801 4802 4803 4804 4805 4806 4807 4808 4809 4810 4811 4812 4813 4814 4815
static int
qemuDomainDetachSCSIVHostDevice(virQEMUDriverPtr driver,
                                virDomainObjPtr vm,
                                virDomainHostdevDefPtr detach)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    int ret = -1;

    if (!detach->info->alias) {
        virReportError(VIR_ERR_OPERATION_FAILED,
                       "%s", _("device cannot be detached without a device alias"));
        return -1;
    }

    qemuDomainMarkDeviceForRemoval(vm, detach->info);

    qemuDomainObjEnterMonitor(driver, vm);
    ret = qemuMonitorDelDevice(priv->mon, detach->info->alias);

    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        return -1;

    return ret;
}

4816
static int
4817
qemuDomainDetachThisHostDevice(virQEMUDriverPtr driver,
4818
                               virDomainObjPtr vm,
4819
                               virDomainHostdevDefPtr detach)
4820
{
4821
    int ret = -1;
4822

4823
    if (!detach->info->alias) {
4824
        if (qemuAssignDeviceHostdevAlias(vm->def, &detach->info->alias, -1) < 0)
4825 4826 4827
            return -1;
    }

4828
    switch (detach->source.subsys.type) {
4829
    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI:
4830
        ret = qemuDomainDetachHostPCIDevice(driver, vm, detach);
4831
        break;
4832
    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB:
4833
        ret = qemuDomainDetachHostUSBDevice(driver, vm, detach);
4834
        break;
4835
    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI:
4836
        ret = qemuDomainDetachHostSCSIDevice(driver, vm, detach);
4837
        break;
4838 4839 4840
    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI_HOST:
        ret = qemuDomainDetachSCSIVHostDevice(driver, vm, detach);
        break;
4841
    default:
4842 4843 4844
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                       _("hostdev subsys type '%s' not supported"),
                       virDomainHostdevSubsysTypeToString(detach->source.subsys.type));
4845 4846 4847
        return -1;
    }

4848
    if (ret < 0) {
4849 4850
        if (virDomainObjIsActive(vm))
            virDomainAuditHostdev(vm, detach, "detach", false);
4851 4852
    } else if ((ret = qemuDomainWaitForDeviceRemoval(vm)) == 1) {
        ret = qemuDomainRemoveHostDevice(driver, vm, detach);
4853
    }
4854

4855 4856
    qemuDomainResetDeviceRemoval(vm);

4857 4858
    return ret;
}
4859

4860
/* search for a hostdev matching dev and detach it */
4861
int qemuDomainDetachHostDevice(virQEMUDriverPtr driver,
4862 4863 4864 4865 4866
                               virDomainObjPtr vm,
                               virDomainDeviceDefPtr dev)
{
    virDomainHostdevDefPtr hostdev = dev->data.hostdev;
    virDomainHostdevSubsysPtr subsys = &hostdev->source.subsys;
4867
    virDomainHostdevSubsysUSBPtr usbsrc = &subsys->u.usb;
4868
    virDomainHostdevSubsysPCIPtr pcisrc = &subsys->u.pci;
4869
    virDomainHostdevSubsysSCSIPtr scsisrc = &subsys->u.scsi;
4870 4871 4872 4873
    virDomainHostdevDefPtr detach = NULL;
    int idx;

    if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) {
4874 4875 4876
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                       _("hostdev mode '%s' not supported"),
                       virDomainHostdevModeTypeToString(hostdev->mode));
4877 4878 4879 4880 4881 4882
        return -1;
    }

    idx = virDomainHostdevFind(vm->def, hostdev, &detach);

    if (idx < 0) {
4883
        switch (subsys->type) {
4884
        case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI:
4885 4886
            virReportError(VIR_ERR_OPERATION_FAILED,
                           _("host pci device %.4x:%.2x:%.2x.%.1x not found"),
4887 4888
                           pcisrc->addr.domain, pcisrc->addr.bus,
                           pcisrc->addr.slot, pcisrc->addr.function);
4889 4890
            break;
        case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB:
4891
            if (usbsrc->bus && usbsrc->device) {
4892 4893
                virReportError(VIR_ERR_OPERATION_FAILED,
                               _("host usb device %03d.%03d not found"),
4894
                               usbsrc->bus, usbsrc->device);
4895
            } else {
4896 4897
                virReportError(VIR_ERR_OPERATION_FAILED,
                               _("host usb device vendor=0x%.4x product=0x%.4x not found"),
4898
                               usbsrc->vendor, usbsrc->product);
4899 4900
            }
            break;
4901
        case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI: {
4902 4903 4904 4905 4906 4907 4908 4909 4910 4911
            if (scsisrc->protocol ==
                VIR_DOMAIN_HOSTDEV_SCSI_PROTOCOL_TYPE_ISCSI) {
                virDomainHostdevSubsysSCSIiSCSIPtr iscsisrc = &scsisrc->u.iscsi;
                virReportError(VIR_ERR_OPERATION_FAILED,
                               _("host scsi iSCSI path %s not found"),
                               iscsisrc->path);
            } else {
                 virDomainHostdevSubsysSCSIHostPtr scsihostsrc =
                     &scsisrc->u.host;
                 virReportError(VIR_ERR_OPERATION_FAILED,
4912
                                _("host scsi device %s:%u:%u.%llu not found"),
4913 4914 4915
                                scsihostsrc->adapter, scsihostsrc->bus,
                                scsihostsrc->target, scsihostsrc->unit);
            }
4916
            break;
4917
        }
4918 4919
        case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI_HOST:
            break;
4920
        default:
4921 4922
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           _("unexpected hostdev type %d"), subsys->type);
4923 4924 4925 4926 4927
            break;
        }
        return -1;
    }

4928 4929 4930 4931
    /* If this is a network hostdev, we need to use the higher-level detach
     * function so that mac address / virtualport are reset
     */
    if (detach->parent.type == VIR_DOMAIN_DEVICE_NET)
4932
        return qemuDomainDetachNetDevice(driver, vm, &detach->parent);
4933
    else
4934
        return qemuDomainDetachThisHostDevice(driver, vm, detach);
4935 4936
}

4937 4938 4939 4940 4941 4942 4943 4944 4945 4946 4947 4948 4949 4950 4951 4952 4953 4954 4955 4956 4957 4958 4959 4960 4961 4962 4963 4964 4965 4966 4967 4968 4969 4970 4971 4972 4973 4974 4975 4976 4977 4978 4979 4980 4981 4982 4983 4984 4985 4986 4987 4988 4989

int
qemuDomainDetachShmemDevice(virQEMUDriverPtr driver,
                            virDomainObjPtr vm,
                            virDomainShmemDefPtr dev)
{
    int ret = -1;
    ssize_t idx = -1;
    virDomainShmemDefPtr shmem = NULL;
    qemuDomainObjPrivatePtr priv = vm->privateData;

    if ((idx = virDomainShmemDefFind(vm->def, dev)) < 0) {
        virReportError(VIR_ERR_OPERATION_INVALID, "%s",
                       _("device not present in domain configuration"));
        return -1;
    }

    shmem = vm->def->shmems[idx];

    switch ((virDomainShmemModel)shmem->model) {
    case VIR_DOMAIN_SHMEM_MODEL_IVSHMEM_PLAIN:
    case VIR_DOMAIN_SHMEM_MODEL_IVSHMEM_DOORBELL:
        break;

    case VIR_DOMAIN_SHMEM_MODEL_IVSHMEM:
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
                       _("live detach of shmem model '%s' is not supported"),
                       virDomainShmemModelTypeToString(shmem->model));
        /* fall-through */
    case VIR_DOMAIN_SHMEM_MODEL_LAST:
        return -1;
    }

    qemuDomainMarkDeviceForRemoval(vm, &shmem->info);
    qemuDomainObjEnterMonitor(driver, vm);

    ret = qemuMonitorDelDevice(priv->mon, shmem->info.alias);

    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        ret = -1;

    if (ret == 0) {
        if ((ret = qemuDomainWaitForDeviceRemoval(vm)) == 1) {
            qemuDomainReleaseDeviceAddress(vm, &shmem->info, NULL);
            ret = qemuDomainRemoveShmemDevice(driver, vm, shmem);
        }
    }
    qemuDomainResetDeviceRemoval(vm);

    return ret;
}


4990
int
4991
qemuDomainDetachNetDevice(virQEMUDriverPtr driver,
4992 4993 4994
                          virDomainObjPtr vm,
                          virDomainDeviceDefPtr dev)
{
4995
    int detachidx, ret = -1;
4996 4997 4998
    virDomainNetDefPtr detach = NULL;
    qemuDomainObjPrivatePtr priv = vm->privateData;

4999
    if ((detachidx = virDomainNetFindIdx(vm->def, dev->data.net)) < 0)
5000
        goto cleanup;
5001

5002
    detach = vm->def->nets[detachidx];
5003

5004
    if (virDomainNetGetActualType(detach) == VIR_DOMAIN_NET_TYPE_HOSTDEV) {
5005
        /* coverity[negative_returns] */
5006
        ret = qemuDomainDetachThisHostDevice(driver, vm,
5007
                                             virDomainNetGetActualHostdev(detach));
5008 5009
        goto cleanup;
    }
5010
    if (qemuDomainIsS390CCW(vm->def) &&
5011 5012 5013 5014 5015 5016 5017 5018 5019 5020 5021 5022 5023 5024
        virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_VIRTIO_CCW)) {
        if (!virDomainDeviceAddressIsValid(&detach->info,
                                           VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW)) {
            virReportError(VIR_ERR_OPERATION_FAILED,
                            "%s", _("device cannot be detached without a CCW address"));
            goto cleanup;
        }
    } else {
        if (!virDomainDeviceAddressIsValid(&detach->info,
                                           VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI)) {
            virReportError(VIR_ERR_OPERATION_FAILED,
                            "%s", _("device cannot be detached without a PCI address"));
            goto cleanup;
        }
5025

5026 5027 5028 5029 5030 5031
        if (qemuIsMultiFunctionDevice(vm->def, &detach->info)) {
            virReportError(VIR_ERR_OPERATION_FAILED,
                            _("cannot hot unplug multifunction PCI device :%s"),
                            dev->data.disk->dst);
            goto cleanup;
        }
5032 5033
    }

5034
    if (!detach->info.alias) {
5035 5036 5037 5038
        if (qemuAssignDeviceNetAlias(vm->def, detach, -1) < 0)
            goto cleanup;
    }

5039 5040
    if (virDomainNetGetActualBandwidth(detach) &&
        virNetDevSupportBandwidth(virDomainNetGetActualType(detach)) &&
5041 5042 5043 5044
        virNetDevBandwidthClear(detach->ifname) < 0)
        VIR_WARN("cannot clear bandwidth setting for device : %s",
                 detach->ifname);

5045 5046 5047
    /* deactivate the tap/macvtap device on the host, which could also
     * affect the parent device (e.g. macvtap passthrough mode sets
     * the parent device offline)
5048 5049 5050
     */
    ignore_value(qemuInterfaceStopDevice(detach));

5051 5052
    qemuDomainMarkDeviceForRemoval(vm, &detach->info);

5053
    qemuDomainObjEnterMonitor(driver, vm);
5054 5055
    if (qemuMonitorDelDevice(priv->mon, detach->info.alias) < 0) {
        if (qemuDomainObjExitMonitor(driver, vm) < 0)
5056
            goto cleanup;
5057 5058
        virDomainAuditNet(vm, detach, NULL, "detach", false);
        goto cleanup;
5059
    }
5060 5061
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        goto cleanup;
5062

5063
    if ((ret = qemuDomainWaitForDeviceRemoval(vm)) == 1)
5064
        ret = qemuDomainRemoveNetDevice(driver, vm, detach);
5065

5066
 cleanup:
5067
    qemuDomainResetDeviceRemoval(vm);
5068 5069 5070
    return ret;
}

5071
int
5072
qemuDomainChangeGraphicsPasswords(virQEMUDriverPtr driver,
5073 5074 5075
                                  virDomainObjPtr vm,
                                  int type,
                                  virDomainGraphicsAuthDefPtr auth,
5076 5077
                                  const char *defaultPasswd,
                                  int asyncJob)
5078 5079 5080
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    time_t now = time(NULL);
5081 5082
    const char *expire;
    char *validTo = NULL;
5083
    const char *connected = NULL;
5084
    const char *password;
5085 5086
    int ret = -1;
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
5087

5088
    if (!auth->passwd && !defaultPasswd) {
5089 5090 5091
        ret = 0;
        goto cleanup;
    }
5092
    password = auth->passwd ? auth->passwd : defaultPasswd;
5093

5094 5095 5096
    if (auth->connected)
        connected = virDomainGraphicsAuthConnectedTypeToString(auth->connected);

5097 5098
    if (qemuDomainObjEnterMonitorAsync(driver, vm, asyncJob) < 0)
        goto cleanup;
5099
    ret = qemuMonitorSetPassword(priv->mon, type, password, connected);
5100 5101 5102

    if (ret == -2) {
        if (type != VIR_DOMAIN_GRAPHICS_TYPE_VNC) {
5103 5104
            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                           _("Graphics password only supported for VNC"));
5105 5106
            ret = -1;
        } else {
5107
            ret = qemuMonitorSetVNCPassword(priv->mon, password);
5108 5109
        }
    }
5110
    if (ret != 0)
5111
        goto end_job;
5112

5113 5114 5115
    if (password[0] == '\0' ||
        (auth->expires && auth->validTo <= now)) {
        expire = "now";
5116
    } else if (auth->expires) {
5117 5118 5119
        if (virAsprintf(&validTo, "%lu", (unsigned long) auth->validTo) < 0)
            goto end_job;
        expire = validTo;
5120
    } else {
5121
        expire = "never";
5122 5123
    }

5124
    ret = qemuMonitorExpirePassword(priv->mon, type, expire);
5125 5126 5127 5128

    if (ret == -2) {
        /* XXX we could fake this with a timer */
        if (auth->expires) {
5129 5130
            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                           _("Expiry of passwords is not supported"));
5131
            ret = -1;
5132 5133
        } else {
            ret = 0;
5134 5135 5136
        }
    }

5137
 end_job:
5138 5139
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        ret = -1;
5140
 cleanup:
5141
    VIR_FREE(validTo);
5142
    virObjectUnref(cfg);
5143 5144
    return ret;
}
5145

5146
int qemuDomainAttachLease(virQEMUDriverPtr driver,
5147 5148 5149
                          virDomainObjPtr vm,
                          virDomainLeaseDefPtr lease)
{
5150 5151 5152
    int ret = -1;
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);

5153
    if (virDomainLeaseInsertPreAlloc(vm->def) < 0)
5154
        goto cleanup;
5155

5156
    if (virDomainLockLeaseAttach(driver->lockManager, cfg->uri,
5157
                                 vm, lease) < 0) {
5158
        virDomainLeaseInsertPreAlloced(vm->def, NULL);
5159
        goto cleanup;
5160 5161 5162
    }

    virDomainLeaseInsertPreAlloced(vm->def, lease);
5163 5164
    ret = 0;

5165
 cleanup:
5166 5167
    virObjectUnref(cfg);
    return ret;
5168 5169
}

5170
int qemuDomainDetachLease(virQEMUDriverPtr driver,
5171 5172 5173
                          virDomainObjPtr vm,
                          virDomainLeaseDefPtr lease)
{
5174
    virDomainLeaseDefPtr det_lease;
5175
    int idx;
5176

5177
    if ((idx = virDomainLeaseIndex(vm->def, lease)) < 0) {
5178 5179 5180
        virReportError(VIR_ERR_INVALID_ARG,
                       _("Lease %s in lockspace %s does not exist"),
                       lease->key, NULLSTR(lease->lockspace));
5181 5182 5183 5184 5185 5186
        return -1;
    }

    if (virDomainLockLeaseDetach(driver->lockManager, vm, lease) < 0)
        return -1;

5187
    det_lease = virDomainLeaseRemoveAt(vm->def, idx);
5188
    virDomainLeaseDefFree(det_lease);
5189 5190
    return 0;
}
5191 5192 5193 5194 5195 5196 5197 5198 5199 5200 5201 5202 5203 5204

int qemuDomainDetachChrDevice(virQEMUDriverPtr driver,
                              virDomainObjPtr vm,
                              virDomainChrDefPtr chr)
{
    int ret = -1;
    qemuDomainObjPrivatePtr priv = vm->privateData;
    virDomainDefPtr vmdef = vm->def;
    virDomainChrDefPtr tmpChr;
    char *devstr = NULL;

    if (!(tmpChr = virDomainChrFind(vmdef, chr))) {
        virReportError(VIR_ERR_OPERATION_INVALID, "%s",
                       _("device not present in domain configuration"));
5205
        goto cleanup;
5206 5207
    }

P
Pavel Hrdina 已提交
5208
    if (!tmpChr->info.alias && qemuAssignDeviceChrAlias(vmdef, tmpChr, -1) < 0)
5209
        goto cleanup;
P
Pavel Hrdina 已提交
5210 5211 5212

    sa_assert(tmpChr->info.alias);

5213
    if (qemuBuildChrDeviceStr(&devstr, vmdef, chr, priv->qemuCaps) < 0)
5214
        goto cleanup;
5215

5216 5217
    qemuDomainMarkDeviceForRemoval(vm, &tmpChr->info);

5218
    qemuDomainObjEnterMonitor(driver, vm);
5219 5220 5221 5222
    if (devstr && qemuMonitorDelDevice(priv->mon, tmpChr->info.alias) < 0) {
        ignore_value(qemuDomainObjExitMonitor(driver, vm));
        goto cleanup;
    }
5223 5224
    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        goto cleanup;
5225

5226
    if ((ret = qemuDomainWaitForDeviceRemoval(vm)) == 1) {
5227
        qemuDomainReleaseDeviceAddress(vm, &tmpChr->info, NULL);
5228
        ret = qemuDomainRemoveChrDevice(driver, vm, tmpChr);
5229 5230
    }

5231
 cleanup:
5232
    qemuDomainResetDeviceRemoval(vm);
5233 5234 5235
    VIR_FREE(devstr);
    return ret;
}
5236 5237 5238 5239 5240 5241 5242 5243 5244 5245 5246 5247 5248 5249 5250 5251 5252 5253 5254 5255 5256 5257 5258 5259 5260 5261 5262 5263 5264 5265 5266 5267 5268 5269


int
qemuDomainDetachRNGDevice(virQEMUDriverPtr driver,
                          virDomainObjPtr vm,
                          virDomainRNGDefPtr rng)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    ssize_t idx;
    virDomainRNGDefPtr tmpRNG;
    int rc;
    int ret = -1;

    if ((idx = virDomainRNGFind(vm->def, rng) < 0)) {
        virReportError(VIR_ERR_OPERATION_INVALID, "%s",
                       _("device not present in domain configuration"));
        return -1;
    }

    tmpRNG = vm->def->rngs[idx];

    if (!tmpRNG->info.alias) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("alias not set for RNG device"));
        return -1;
    }

    qemuDomainMarkDeviceForRemoval(vm, &tmpRNG->info);

    qemuDomainObjEnterMonitor(driver, vm);
    rc = qemuMonitorDelDevice(priv->mon, tmpRNG->info.alias);
    if (qemuDomainObjExitMonitor(driver, vm) || rc < 0)
        goto cleanup;

5270
    if ((ret = qemuDomainWaitForDeviceRemoval(vm)) == 1)
5271 5272 5273 5274 5275 5276
        ret = qemuDomainRemoveRNGDevice(driver, vm, tmpRNG);

 cleanup:
    qemuDomainResetDeviceRemoval(vm);
    return ret;
}
5277 5278 5279 5280 5281 5282 5283 5284 5285 5286 5287 5288 5289


int
qemuDomainDetachMemoryDevice(virQEMUDriverPtr driver,
                             virDomainObjPtr vm,
                             virDomainMemoryDefPtr memdef)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    virDomainMemoryDefPtr mem;
    int idx;
    int rc;
    int ret = -1;

5290
    qemuDomainMemoryDeviceAlignSize(vm->def, memdef);
5291 5292 5293 5294 5295 5296 5297 5298 5299 5300 5301 5302 5303 5304 5305 5306 5307 5308 5309 5310 5311 5312

    if ((idx = virDomainMemoryFindByDef(vm->def, memdef)) < 0) {
        virReportError(VIR_ERR_OPERATION_INVALID, "%s",
                       _("device not present in domain configuration"));
        return -1;
    }

    mem = vm->def->mems[idx];

    if (!mem->info.alias) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("alias for the memory device was not found"));
        return -1;
    }

    qemuDomainMarkDeviceForRemoval(vm, &mem->info);

    qemuDomainObjEnterMonitor(driver, vm);
    rc = qemuMonitorDelDevice(priv->mon, mem->info.alias);
    if (qemuDomainObjExitMonitor(driver, vm) < 0 || rc < 0)
        goto cleanup;

5313
    if ((ret = qemuDomainWaitForDeviceRemoval(vm)) == 1)
5314 5315 5316 5317 5318 5319
        ret = qemuDomainRemoveMemoryDevice(driver, vm, mem);

 cleanup:
    qemuDomainResetDeviceRemoval(vm);
    return ret;
}
5320 5321 5322 5323 5324 5325 5326 5327 5328 5329 5330 5331 5332 5333 5334 5335 5336 5337 5338 5339 5340 5341 5342 5343 5344 5345 5346 5347 5348 5349 5350 5351 5352 5353 5354 5355 5356 5357 5358 5359 5360 5361 5362 5363 5364 5365 5366 5367 5368 5369 5370 5371 5372 5373 5374 5375 5376 5377 5378 5379 5380 5381 5382 5383 5384 5385 5386 5387 5388 5389 5390 5391 5392 5393 5394 5395 5396


static int
qemuDomainRemoveVcpu(virQEMUDriverPtr driver,
                     virDomainObjPtr vm,
                     unsigned int vcpu)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    virDomainVcpuDefPtr vcpuinfo = virDomainDefGetVcpu(vm->def, vcpu);
    qemuDomainVcpuPrivatePtr vcpupriv = QEMU_DOMAIN_VCPU_PRIVATE(vcpuinfo);
    int oldvcpus = virDomainDefGetVcpus(vm->def);
    unsigned int nvcpus = vcpupriv->vcpus;
    size_t i;

    if (qemuDomainRefreshVcpuInfo(driver, vm, QEMU_ASYNC_JOB_NONE, false) < 0)
        return -1;

    /* validation requires us to set the expected state prior to calling it */
    for (i = vcpu; i < vcpu + nvcpus; i++) {
        vcpuinfo = virDomainDefGetVcpu(vm->def, i);
        vcpuinfo->online = false;
    }

    if (qemuDomainValidateVcpuInfo(vm) < 0) {
        /* rollback vcpu count if the setting has failed */
        virDomainAuditVcpu(vm, oldvcpus, oldvcpus - nvcpus, "update", false);

        for (i = vcpu; i < vcpu + nvcpus; i++) {
            vcpuinfo = virDomainDefGetVcpu(vm->def, i);
            vcpuinfo->online = true;
        }
        return -1;
    }

    virDomainAuditVcpu(vm, oldvcpus, oldvcpus - nvcpus, "update", true);

    for (i = vcpu; i < vcpu + nvcpus; i++) {
        vcpuinfo = virDomainDefGetVcpu(vm->def, i);
        if (virCgroupDelThread(priv->cgroup, VIR_CGROUP_THREAD_VCPU, i) < 0)
            return -1;
    }

    return 0;
}


void
qemuDomainRemoveVcpuAlias(virQEMUDriverPtr driver,
                          virDomainObjPtr vm,
                          const char *alias)
{
    virDomainVcpuDefPtr vcpu;
    qemuDomainVcpuPrivatePtr vcpupriv;
    size_t i;

    for (i = 0; i < virDomainDefGetVcpusMax(vm->def); i++) {
        vcpu = virDomainDefGetVcpu(vm->def, i);
        vcpupriv = QEMU_DOMAIN_VCPU_PRIVATE(vcpu);

        if (STREQ_NULLABLE(alias, vcpupriv->alias)) {
            qemuDomainRemoveVcpu(driver, vm, i);
            return;
        }
    }
}


int
qemuDomainHotplugDelVcpu(virQEMUDriverPtr driver,
                         virDomainObjPtr vm,
                         unsigned int vcpu)
{
    virDomainVcpuDefPtr vcpuinfo = virDomainDefGetVcpu(vm->def, vcpu);
    qemuDomainVcpuPrivatePtr vcpupriv = QEMU_DOMAIN_VCPU_PRIVATE(vcpuinfo);
    int oldvcpus = virDomainDefGetVcpus(vm->def);
    unsigned int nvcpus = vcpupriv->vcpus;
    int rc;
5397
    int ret = -1;
5398 5399 5400 5401 5402 5403 5404 5405 5406 5407 5408 5409 5410 5411

    if (!vcpupriv->alias) {
        virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
                       _("vcpu '%u' can't be unplugged"), vcpu);
        return -1;
    }

    qemuDomainMarkDeviceAliasForRemoval(vm, vcpupriv->alias);

    qemuDomainObjEnterMonitor(driver, vm);

    rc = qemuMonitorDelDevice(qemuDomainGetMonitor(vm), vcpupriv->alias);

    if (qemuDomainObjExitMonitor(driver, vm) < 0)
5412
        goto cleanup;
5413 5414 5415

    if (rc < 0) {
        virDomainAuditVcpu(vm, oldvcpus, oldvcpus - nvcpus, "update", false);
5416
        goto cleanup;
5417 5418 5419 5420 5421 5422 5423
    }

    if ((rc = qemuDomainWaitForDeviceRemoval(vm)) <= 0) {
        if (rc == 0)
            virReportError(VIR_ERR_OPERATION_FAILED, "%s",
                           _("vcpu unplug request timed out"));

5424
        goto cleanup;
5425 5426
    }

5427 5428 5429 5430 5431 5432 5433 5434
    if (qemuDomainRemoveVcpu(driver, vm, vcpu) < 0)
        goto cleanup;

    ret = 0;

 cleanup:
    qemuDomainResetDeviceRemoval(vm);
    return ret;
5435
}
5436 5437 5438 5439 5440 5441 5442 5443 5444 5445 5446 5447 5448 5449 5450 5451 5452 5453 5454 5455 5456 5457 5458 5459 5460 5461 5462 5463 5464 5465 5466 5467 5468 5469 5470 5471 5472 5473 5474 5475 5476 5477 5478 5479 5480 5481 5482 5483 5484 5485 5486 5487 5488 5489 5490 5491 5492 5493 5494 5495 5496 5497 5498 5499 5500 5501 5502 5503 5504 5505 5506 5507 5508 5509 5510 5511 5512 5513 5514 5515 5516 5517 5518 5519 5520 5521 5522 5523 5524 5525 5526 5527 5528 5529 5530 5531 5532 5533 5534 5535 5536 5537 5538 5539 5540 5541 5542 5543 5544 5545 5546 5547 5548 5549 5550 5551 5552 5553 5554 5555 5556 5557 5558 5559 5560 5561 5562 5563 5564 5565 5566 5567 5568 5569 5570 5571 5572 5573 5574 5575 5576 5577 5578 5579 5580 5581 5582 5583 5584 5585 5586 5587 5588 5589 5590 5591 5592 5593 5594 5595 5596 5597 5598 5599 5600 5601 5602 5603 5604 5605 5606 5607 5608 5609 5610 5611 5612 5613 5614 5615 5616 5617 5618 5619 5620 5621 5622 5623 5624 5625 5626 5627 5628 5629 5630 5631 5632 5633 5634 5635 5636 5637 5638 5639 5640 5641 5642 5643 5644 5645 5646 5647 5648 5649 5650 5651 5652 5653 5654 5655 5656 5657 5658 5659 5660 5661 5662 5663 5664 5665 5666 5667 5668 5669 5670 5671 5672 5673 5674 5675 5676 5677 5678 5679 5680 5681 5682 5683 5684 5685 5686 5687 5688 5689 5690 5691 5692 5693 5694 5695 5696 5697 5698 5699 5700 5701 5702 5703 5704 5705 5706 5707 5708 5709 5710 5711 5712 5713 5714 5715 5716 5717 5718 5719 5720 5721 5722 5723 5724 5725 5726 5727 5728 5729 5730 5731 5732 5733 5734 5735 5736 5737 5738 5739 5740 5741 5742 5743 5744 5745 5746 5747 5748 5749 5750 5751 5752 5753 5754 5755 5756 5757 5758 5759 5760 5761 5762 5763 5764 5765 5766 5767 5768 5769 5770 5771 5772 5773 5774


static int
qemuDomainHotplugAddVcpu(virQEMUDriverPtr driver,
                         virDomainObjPtr vm,
                         unsigned int vcpu)
{
    virJSONValuePtr vcpuprops = NULL;
    virDomainVcpuDefPtr vcpuinfo = virDomainDefGetVcpu(vm->def, vcpu);
    qemuDomainVcpuPrivatePtr vcpupriv = QEMU_DOMAIN_VCPU_PRIVATE(vcpuinfo);
    unsigned int nvcpus = vcpupriv->vcpus;
    bool newhotplug = qemuDomainSupportsNewVcpuHotplug(vm);
    int ret = -1;
    int rc;
    int oldvcpus = virDomainDefGetVcpus(vm->def);
    size_t i;

    if (newhotplug) {
        if (virAsprintf(&vcpupriv->alias, "vcpu%u", vcpu) < 0)
            goto cleanup;

        if (!(vcpuprops = qemuBuildHotpluggableCPUProps(vcpuinfo)))
            goto cleanup;
    }

    qemuDomainObjEnterMonitor(driver, vm);

    if (newhotplug) {
        rc = qemuMonitorAddDeviceArgs(qemuDomainGetMonitor(vm), vcpuprops);
        vcpuprops = NULL;
    } else {
        rc = qemuMonitorSetCPU(qemuDomainGetMonitor(vm), vcpu, true);
    }

    if (qemuDomainObjExitMonitor(driver, vm) < 0)
        goto cleanup;

    virDomainAuditVcpu(vm, oldvcpus, oldvcpus + nvcpus, "update", rc == 0);

    if (rc < 0)
        goto cleanup;

    /* start outputting of the new XML element to allow keeping unpluggability */
    if (newhotplug)
        vm->def->individualvcpus = true;

    if (qemuDomainRefreshVcpuInfo(driver, vm, QEMU_ASYNC_JOB_NONE, false) < 0)
        goto cleanup;

    /* validation requires us to set the expected state prior to calling it */
    for (i = vcpu; i < vcpu + nvcpus; i++) {
        vcpuinfo = virDomainDefGetVcpu(vm->def, i);
        vcpupriv = QEMU_DOMAIN_VCPU_PRIVATE(vcpuinfo);

        vcpuinfo->online = true;

        if (vcpupriv->tid > 0 &&
            qemuProcessSetupVcpu(vm, i) < 0)
            goto cleanup;
    }

    if (qemuDomainValidateVcpuInfo(vm) < 0)
        goto cleanup;

    ret = 0;

 cleanup:
    virJSONValueFree(vcpuprops);
    return ret;
}


/**
 * qemuDomainSelectHotplugVcpuEntities:
 *
 * @def: domain definition
 * @nvcpus: target vcpu count
 * @enable: set to true if vcpus should be enabled
 *
 * Tries to find which vcpu entities need to be enabled or disabled to reach
 * @nvcpus. This function works in order of the legacy hotplug but is able to
 * skip over entries that are added out of order.
 *
 * Returns the bitmap of vcpus to modify on success, NULL on error.
 */
static virBitmapPtr
qemuDomainSelectHotplugVcpuEntities(virDomainDefPtr def,
                                    unsigned int nvcpus,
                                    bool *enable)
{
    virBitmapPtr ret = NULL;
    virDomainVcpuDefPtr vcpu;
    qemuDomainVcpuPrivatePtr vcpupriv;
    unsigned int maxvcpus = virDomainDefGetVcpusMax(def);
    unsigned int curvcpus = virDomainDefGetVcpus(def);
    ssize_t i;

    if (!(ret = virBitmapNew(maxvcpus)))
        return NULL;

    if (nvcpus > curvcpus) {
        *enable = true;

        for (i = 0; i < maxvcpus && curvcpus < nvcpus; i++) {
            vcpu = virDomainDefGetVcpu(def, i);
            vcpupriv =  QEMU_DOMAIN_VCPU_PRIVATE(vcpu);

            if (vcpu->online)
                continue;

            if (vcpupriv->vcpus == 0)
                continue;

            curvcpus += vcpupriv->vcpus;

            if (curvcpus > nvcpus) {
                virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                               _("target vm vcpu granularity does not allow the "
                                 "desired vcpu count"));
                goto error;
            }

            ignore_value(virBitmapSetBit(ret, i));
        }
    } else {
        *enable = false;

        for (i = maxvcpus - 1; i >= 0 && curvcpus > nvcpus; i--) {
            vcpu = virDomainDefGetVcpu(def, i);
            vcpupriv =  QEMU_DOMAIN_VCPU_PRIVATE(vcpu);

            if (!vcpu->online)
                continue;

            if (vcpupriv->vcpus == 0)
                continue;

            if (!vcpupriv->alias)
                continue;

            curvcpus -= vcpupriv->vcpus;

            if (curvcpus < nvcpus) {
                virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                               _("target vm vcpu granularity does not allow the "
                                 "desired vcpu count"));
                goto error;
            }

            ignore_value(virBitmapSetBit(ret, i));
        }
    }

    if (curvcpus != nvcpus) {
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("failed to find appropriate hotpluggable vcpus to "
                         "reach the desired target vcpu count"));
        goto error;
    }

    return ret;

 error:
    virBitmapFree(ret);
    return NULL;
}


static int
qemuDomainSetVcpusLive(virQEMUDriverPtr driver,
                       virQEMUDriverConfigPtr cfg,
                       virDomainObjPtr vm,
                       virBitmapPtr vcpumap,
                       bool enable)
{
    qemuDomainObjPrivatePtr priv = vm->privateData;
    qemuCgroupEmulatorAllNodesDataPtr emulatorCgroup = NULL;
    ssize_t nextvcpu = -1;
    int rc = 0;
    int ret = -1;

    if (qemuCgroupEmulatorAllNodesAllow(priv->cgroup, &emulatorCgroup) < 0)
        goto cleanup;

    if (enable) {
        while ((nextvcpu = virBitmapNextSetBit(vcpumap, nextvcpu)) != -1) {
            if ((rc = qemuDomainHotplugAddVcpu(driver, vm, nextvcpu)) < 0)
                break;
        }
    } else {
        for (nextvcpu = virDomainDefGetVcpusMax(vm->def) - 1; nextvcpu >= 0; nextvcpu--) {
            if (!virBitmapIsBitSet(vcpumap, nextvcpu))
                continue;

            if ((rc = qemuDomainHotplugDelVcpu(driver, vm, nextvcpu)) < 0)
                break;
        }
    }

    qemuDomainVcpuPersistOrder(vm->def);

    if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps) < 0)
        goto cleanup;

    if (rc < 0)
        goto cleanup;

    ret = 0;

 cleanup:
    qemuCgroupEmulatorAllNodesRestore(emulatorCgroup);

    return ret;
}


/**
 * qemuDomainSetVcpusConfig:
 * @def: config/offline definition of a domain
 * @nvcpus: target vcpu count
 *
 * Properly handle cold(un)plug of vcpus:
 * - plug in inactive vcpus/uplug active rather than rewriting state
 * - fix hotpluggable state
 */
static void
qemuDomainSetVcpusConfig(virDomainDefPtr def,
                         unsigned int nvcpus,
                         bool hotpluggable)
{
    virDomainVcpuDefPtr vcpu;
    size_t curvcpus = virDomainDefGetVcpus(def);
    size_t maxvcpus = virDomainDefGetVcpusMax(def);
    size_t i;

    /* ordering information may become invalid, thus clear it */
    virDomainDefVcpuOrderClear(def);

    if (curvcpus == nvcpus)
        return;

    if (curvcpus < nvcpus) {
        for (i = 0; i < maxvcpus; i++) {
            vcpu = virDomainDefGetVcpu(def, i);

            if (!vcpu)
                continue;

            if (vcpu->online) {
                /* non-hotpluggable vcpus need to be clustered at the beggining,
                 * thus we need to force vcpus to be hotpluggable when we find
                 * vcpus that are hotpluggable and online prior to the ones
                 * we are going to add */
                if (vcpu->hotpluggable == VIR_TRISTATE_BOOL_YES)
                    hotpluggable = true;

                continue;
            }

            vcpu->online = true;
            if (hotpluggable) {
                vcpu->hotpluggable = VIR_TRISTATE_BOOL_YES;
                def->individualvcpus = true;
            } else {
                vcpu->hotpluggable = VIR_TRISTATE_BOOL_NO;
            }

            if (++curvcpus == nvcpus)
                break;
        }
    } else {
        for (i = maxvcpus; i != 0; i--) {
            vcpu = virDomainDefGetVcpu(def, i - 1);

            if (!vcpu || !vcpu->online)
                continue;

            vcpu->online = false;
            vcpu->hotpluggable = VIR_TRISTATE_BOOL_YES;

            if (--curvcpus == nvcpus)
                break;
        }
    }
}


int
qemuDomainSetVcpusInternal(virQEMUDriverPtr driver,
                           virDomainObjPtr vm,
                           virDomainDefPtr def,
                           virDomainDefPtr persistentDef,
                           unsigned int nvcpus,
                           bool hotpluggable)
{
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
    virBitmapPtr vcpumap = NULL;
    bool enable;
    int ret = -1;

    if (def && nvcpus > virDomainDefGetVcpusMax(def)) {
        virReportError(VIR_ERR_INVALID_ARG,
                       _("requested vcpus is greater than max allowable"
                         " vcpus for the live domain: %u > %u"),
                       nvcpus, virDomainDefGetVcpusMax(def));
        goto cleanup;
    }

    if (persistentDef && nvcpus > virDomainDefGetVcpusMax(persistentDef)) {
        virReportError(VIR_ERR_INVALID_ARG,
                       _("requested vcpus is greater than max allowable"
                         " vcpus for the persistent domain: %u > %u"),
                       nvcpus, virDomainDefGetVcpusMax(persistentDef));
        goto cleanup;
    }

    if (def) {
        if (!(vcpumap = qemuDomainSelectHotplugVcpuEntities(vm->def, nvcpus,
                                                            &enable)))
            goto cleanup;

        if (qemuDomainSetVcpusLive(driver, cfg, vm, vcpumap, enable) < 0)
            goto cleanup;
    }

    if (persistentDef) {
        qemuDomainSetVcpusConfig(persistentDef, nvcpus, hotpluggable);

        if (virDomainSaveConfig(cfg->configDir, driver->caps, persistentDef) < 0)
            goto cleanup;
    }

    ret = 0;

 cleanup:
    virBitmapFree(vcpumap);
    virObjectUnref(cfg);
    return ret;
}
5775 5776 5777 5778 5779 5780 5781 5782 5783 5784 5785 5786


static void
qemuDomainSetVcpuConfig(virDomainDefPtr def,
                        virBitmapPtr map,
                        bool state)
{
    virDomainVcpuDefPtr vcpu;
    ssize_t next = -1;

    def->individualvcpus = true;

5787 5788 5789
    /* ordering information may become invalid, thus clear it */
    virDomainDefVcpuOrderClear(def);

5790
    while ((next = virBitmapNextSetBit(map, next)) >= 0) {
5791 5792 5793 5794 5795 5796 5797 5798 5799 5800 5801 5802 5803 5804 5805 5806 5807 5808 5809 5810 5811 5812 5813 5814 5815 5816 5817 5818 5819 5820 5821
        if (!(vcpu = virDomainDefGetVcpu(def, next)))
            continue;

        vcpu->online = state;
        vcpu->hotpluggable = VIR_TRISTATE_BOOL_YES;
    }
}


/**
 * qemuDomainFilterHotplugVcpuEntities:
 *
 * Returns a bitmap of hotpluggable vcpu entities that correspond to the logical
 * vcpus requested in @vcpus.
 */
static virBitmapPtr
qemuDomainFilterHotplugVcpuEntities(virDomainDefPtr def,
                                    virBitmapPtr vcpus,
                                    bool state)
{
    qemuDomainVcpuPrivatePtr vcpupriv;
    virDomainVcpuDefPtr vcpu;
    virBitmapPtr map = NULL;
    virBitmapPtr ret = NULL;
    ssize_t next = -1;
    size_t i;

    if (!(map = virBitmapNewCopy(vcpus)))
        return NULL;

    /* make sure that all selected vcpus are in the correct state */
5822
    while ((next = virBitmapNextSetBit(map, next)) >= 0) {
5823 5824 5825 5826 5827
        if (!(vcpu = virDomainDefGetVcpu(def, next)))
            continue;

        if (vcpu->online == state) {
            virReportError(VIR_ERR_INVALID_ARG,
5828
                           _("vcpu '%zd' is already in requested state"), next);
5829 5830 5831 5832 5833
            goto cleanup;
        }

        if (vcpu->online && !vcpu->hotpluggable) {
            virReportError(VIR_ERR_INVALID_ARG,
5834
                           _("vcpu '%zd' can't be hotunplugged"), next);
5835 5836 5837 5838 5839 5840 5841
            goto cleanup;
        }
    }

    /* Make sure that all vCPUs belonging to a single hotpluggable entity were
     * selected and then de-select any sub-threads of it. */
    next = -1;
5842
    while ((next = virBitmapNextSetBit(map, next)) >= 0) {
5843 5844 5845 5846 5847 5848 5849
        if (!(vcpu = virDomainDefGetVcpu(def, next)))
            continue;

        vcpupriv = QEMU_DOMAIN_VCPU_PRIVATE(vcpu);

        if (vcpupriv->vcpus == 0) {
            virReportError(VIR_ERR_INVALID_ARG,
5850
                           _("vcpu '%zd' belongs to a larger hotpluggable entity, "
5851 5852 5853 5854 5855 5856 5857 5858
                             "but siblings were not selected"), next);
            goto cleanup;
        }

        for (i = next + 1; i < next + vcpupriv->vcpus; i++) {
            if (!virBitmapIsBitSet(map, i)) {
                virReportError(VIR_ERR_INVALID_ARG,
                               _("vcpu '%zu' was not selected but it belongs to "
5859
                                 "hotpluggable entity '%zd-%zd' which was "
5860 5861 5862 5863 5864 5865 5866 5867 5868 5869 5870 5871 5872 5873 5874 5875 5876 5877
                                 "partially selected"),
                               i, next, next + vcpupriv->vcpus - 1);
                goto cleanup;
            }

            /* clear the subthreads */
            ignore_value(virBitmapClearBit(map, i));
        }
    }

    VIR_STEAL_PTR(ret, map);

 cleanup:
    virBitmapFree(map);
    return ret;
}


5878
static int
5879 5880
qemuDomainVcpuValidateConfig(virDomainDefPtr def,
                             virBitmapPtr map,
5881 5882
                             bool state)
{
5883 5884 5885 5886
    virDomainVcpuDefPtr vcpu;
    size_t maxvcpus = virDomainDefGetVcpusMax(def);
    ssize_t next;

5887 5888 5889 5890 5891 5892 5893
    /* vcpu 0 can't be disabled */
    if (!state && virBitmapIsBitSet(map, 0)) {
        virReportError(VIR_ERR_INVALID_ARG, "%s",
                       _("vCPU '0' must be enabled"));
        return -1;
    }

5894 5895 5896 5897 5898 5899 5900 5901 5902 5903 5904 5905 5906 5907 5908 5909 5910
    /* non-hotpluggable vcpus need to stay clustered starting from vcpu 0 */
    for (next = virBitmapNextSetBit(map, -1) + 1; next < maxvcpus; next++) {
        if (!(vcpu = virDomainDefGetVcpu(def, next)))
            continue;

        /* skip vcpus being modified */
        if (virBitmapIsBitSet(map, next))
            continue;

        if (vcpu->online && vcpu->hotpluggable == VIR_TRISTATE_BOOL_NO) {
            virReportError(VIR_ERR_INVALID_ARG,
                           _("vcpu '%zd' can't be modified as it is followed "
                             "by non-hotpluggable online vcpus"), next);
            return -1;
        }
    }

5911 5912 5913 5914
    return 0;
}


5915 5916 5917 5918 5919 5920 5921 5922 5923 5924 5925 5926 5927 5928 5929 5930 5931 5932 5933 5934 5935 5936 5937 5938 5939 5940 5941 5942 5943 5944 5945 5946 5947 5948
int
qemuDomainSetVcpuInternal(virQEMUDriverPtr driver,
                          virDomainObjPtr vm,
                          virDomainDefPtr def,
                          virDomainDefPtr persistentDef,
                          virBitmapPtr map,
                          bool state)
{
    virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
    virBitmapPtr livevcpus = NULL;
    int ret = -1;

    if (def) {
        if (!qemuDomainSupportsNewVcpuHotplug(vm)) {
            virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
                           _("this qemu version does not support specific "
                             "vCPU hotplug"));
            goto cleanup;
        }

        if (!(livevcpus = qemuDomainFilterHotplugVcpuEntities(def, map, state)))
            goto cleanup;

        /* Make sure that only one hotpluggable entity is selected.
         * qemuDomainSetVcpusLive allows setting more at once but error
         * resolution in case of a partial failure is hard, so don't let users
         * do so */
        if (virBitmapCountBits(livevcpus) != 1) {
            virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
                           _("only one hotpluggable entity can be selected"));
            goto cleanup;
        }
    }

5949
    if (persistentDef) {
5950
        if (qemuDomainVcpuValidateConfig(persistentDef, map, state) < 0)
5951 5952 5953
            goto cleanup;
    }

5954 5955 5956 5957 5958 5959 5960 5961 5962 5963 5964 5965 5966 5967 5968 5969 5970 5971
    if (livevcpus &&
        qemuDomainSetVcpusLive(driver, cfg, vm, livevcpus, state) < 0)
        goto cleanup;

    if (persistentDef) {
        qemuDomainSetVcpuConfig(persistentDef, map, state);

        if (virDomainSaveConfig(cfg->configDir, driver->caps, persistentDef) < 0)
            goto cleanup;
    }

    ret = 0;

 cleanup:
    virBitmapFree(livevcpus);
    virObjectUnref(cfg);
    return ret;
}