virt-aa-helper.c 42.2 KB
Newer Older
J
Jamie Strandboge 已提交
1 2
/*
 * virt-aa-helper: wrapper program used by AppArmor security driver.
3
 *
4
 * Copyright (C) 2010-2014 Red Hat, Inc.
5
 * Copyright (C) 2009-2011 Canonical Ltd.
J
Jamie Strandboge 已提交
6
 *
O
Osier Yang 已提交
7 8 9 10 11 12 13 14 15 16 17
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
18
 * License along with this library.  If not, see
O
Osier Yang 已提交
19
 * <http://www.gnu.org/licenses/>.
J
Jamie Strandboge 已提交
20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39
 *
 * Author:
 *   Jamie Strandboge <jamie@canonical.com>
 *
 */

#include <config.h>

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <stdarg.h>
#include <unistd.h>
#include <errno.h>
#include <sys/types.h>
#include <fcntl.h>
#include <getopt.h>
#include <sys/utsname.h>

#include "internal.h"
40
#include "virbuffer.h"
41
#include "viralloc.h"
42
#include "vircommand.h"
43
#include "virlog.h"
J
Jamie Strandboge 已提交
44 45 46 47

#include "security_driver.h"
#include "security_apparmor.h"
#include "domain_conf.h"
48
#include "virxml.h"
49
#include "viruuid.h"
50
#include "virusb.h"
51
#include "virpci.h"
E
Eric Blake 已提交
52
#include "virfile.h"
53
#include "configmake.h"
54
#include "virrandom.h"
55
#include "virstring.h"
56
#include "virgettext.h"
J
Jamie Strandboge 已提交
57

58 59
#include "storage/storage_driver.h"

60 61
#define VIR_FROM_THIS VIR_FROM_SECURITY

J
Jamie Strandboge 已提交
62 63 64
static char *progname;

typedef struct {
65
    bool allowDiskFormatProbing;
J
Jamie Strandboge 已提交
66 67 68 69 70 71 72 73 74
    char uuid[PROFILE_NAME_SIZE];       /* UUID of vm */
    bool dryrun;                /* dry run */
    char cmd;                   /* 'c'   create
                                 * 'a'   add (load)
                                 * 'r'   replace
                                 * 'R'   remove */
    char *files;                /* list of files */
    virDomainDefPtr def;        /* VM definition */
    virCapsPtr caps;            /* VM capabilities */
75
    virDomainXMLOptionPtr xmlopt; /* XML parser data */
76
    char *virtType;                  /* type of hypervisor (eg qemu, xen, lxc) */
77
    char *os;                   /* type of os (eg hvm, xen, exe) */
78
    virArch arch;               /* machine architecture */
79 80
    char *newfile;              /* newly added file */
    bool append;                /* append to .files instead of rewrite */
J
Jamie Strandboge 已提交
81 82 83 84 85 86 87 88 89
} vahControl;

static int
vahDeinit(vahControl * ctl)
{
    if (ctl == NULL)
        return -1;

    VIR_FREE(ctl->def);
90
    virObjectUnref(ctl->caps);
91
    virObjectUnref(ctl->xmlopt);
92
    VIR_FREE(ctl->files);
93
    VIR_FREE(ctl->virtType);
94
    VIR_FREE(ctl->os);
95
    VIR_FREE(ctl->newfile);
J
Jamie Strandboge 已提交
96 97 98 99 100 101 102 103 104 105

    return 0;
}

/*
 * Print usage
 */
static void
vah_usage(void)
{
106 107 108 109
    printf(_("\n%s [options] [< def.xml]\n\n"
            "  Options:\n"
            "    -a | --add                     load profile\n"
            "    -c | --create                  create profile from template\n"
110
            "    -d | --dryrun                  dry run\n"
111 112 113 114 115 116
            "    -D | --delete                  unload and delete profile\n"
            "    -f | --add-file <file>         add file to profile\n"
            "    -F | --append-file <file>      append file to profile\n"
            "    -r | --replace                 reload profile\n"
            "    -R | --remove                  unload profile\n"
            "    -h | --help                    this help\n"
117
            "    -p | --probing [0|1]           allow disk format probing\n"
118 119 120 121 122
            "    -u | --uuid <uuid>             uuid (profile name)\n"
            "\n"), progname);

    puts(_("This command is intended to be used by libvirtd "
           "and not used directly.\n"));
J
Jamie Strandboge 已提交
123 124 125 126 127 128
    return;
}

static void
vah_error(vahControl * ctl, int doexit, const char *str)
{
129
    fprintf(stderr, _("%s: error: %s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
130 131 132 133 134 135 136 137 138 139 140

    if (doexit) {
        if (ctl != NULL)
            vahDeinit(ctl);
        exit(EXIT_FAILURE);
    }
}

static void
vah_warning(const char *str)
{
141
    fprintf(stderr, _("%s: warning: %s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
142 143 144 145 146
}

static void
vah_info(const char *str)
{
147
    fprintf(stderr, _("%s:\n%s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
148 149 150 151 152 153 154 155
}

/*
 * run an apparmor_parser command
 */
static int
parserCommand(const char *profile_name, const char cmd)
{
156
    int result = -1;
J
Jamie Strandboge 已提交
157
    char flag[3];
158
    char *profile;
159 160
    int status;
    int ret;
J
Jamie Strandboge 已提交
161 162

    if (strchr("arR", cmd) == NULL) {
163
        vah_error(NULL, 0, _("invalid flag"));
J
Jamie Strandboge 已提交
164 165 166 167 168
        return -1;
    }

    snprintf(flag, 3, "-%c", cmd);

169 170
    if (virAsprintfQuiet(&profile, "%s/%s",
                         APPARMOR_DIR "/libvirt", profile_name) < 0) {
171
        vah_error(NULL, 0, _("profile name exceeds maximum length"));
J
Jamie Strandboge 已提交
172 173 174 175
        return -1;
    }

    if (!virFileExists(profile)) {
176
        vah_error(NULL, 0, _("profile does not exist"));
177
        goto cleanup;
J
Jamie Strandboge 已提交
178 179 180 181
    } else {
        const char * const argv[] = {
            "/sbin/apparmor_parser", flag, profile, NULL
        };
182 183 184
        if ((ret = virRun(argv, &status)) != 0 ||
            (WIFEXITED(status) && WEXITSTATUS(status) != 0)) {
            if (ret != 0) {
185
                vah_error(NULL, 0, _("failed to run apparmor_parser"));
186
                goto cleanup;
187 188 189
            } else if (cmd == 'R' && WIFEXITED(status) &&
                       WEXITSTATUS(status) == 234) {
                vah_warning(_("unable to unload already unloaded profile"));
190
            } else {
191
                vah_error(NULL, 0, _("apparmor_parser exited with error"));
192
                goto cleanup;
193
            }
J
Jamie Strandboge 已提交
194 195 196
        }
    }

197 198
    result = 0;

199
 cleanup:
200 201 202
    VIR_FREE(profile);

    return result;
J
Jamie Strandboge 已提交
203 204 205 206 207 208
}

/*
 * Update the dynamic files
 */
static int
209 210
update_include_file(const char *include_file, const char *included_files,
                    bool append)
J
Jamie Strandboge 已提交
211 212
{
    int rc = -1;
213
    int plen, flen = 0;
J
Jamie Strandboge 已提交
214 215
    int fd;
    char *pcontent = NULL;
216
    char *existing = NULL;
J
Jamie Strandboge 已提交
217 218 219
    const char *warning =
         "# DO NOT EDIT THIS FILE DIRECTLY. IT IS MANAGED BY LIBVIRT.\n";

220 221 222 223 224 225 226
    if (virFileExists(include_file)) {
        flen = virFileReadAll(include_file, MAX_FILE_LEN, &existing);
        if (flen < 0)
            return rc;
    }

    if (append && virFileExists(include_file)) {
227
        if (virAsprintfQuiet(&pcontent, "%s%s", existing, included_files) == -1) {
228
            vah_error(NULL, 0, _("could not allocate memory for profile"));
229
            goto cleanup;
230 231
        }
    } else {
232
        if (virAsprintfQuiet(&pcontent, "%s%s", warning, included_files) == -1) {
233
            vah_error(NULL, 0, _("could not allocate memory for profile"));
234
            goto cleanup;
235
        }
J
Jamie Strandboge 已提交
236 237 238 239
    }

    plen = strlen(pcontent);
    if (plen > MAX_FILE_LEN) {
240
        vah_error(NULL, 0, _("invalid length for new profile"));
241
        goto cleanup;
J
Jamie Strandboge 已提交
242 243 244
    }

    /* only update the disk profile if it is different */
245 246
    if (flen > 0 && flen == plen && STREQLEN(existing, pcontent, plen)) {
        rc = 0;
247
        goto cleanup;
J
Jamie Strandboge 已提交
248 249 250 251
    }

    /* write the file */
    if ((fd = open(include_file, O_CREAT | O_TRUNC | O_WRONLY, 0644)) == -1) {
252
        vah_error(NULL, 0, _("failed to create include file"));
253
        goto cleanup;
J
Jamie Strandboge 已提交
254 255 256
    }

    if (safewrite(fd, pcontent, plen) < 0) { /* don't write the '\0' */
257
        VIR_FORCE_CLOSE(fd);
258
        vah_error(NULL, 0, _("failed to write to profile"));
259
        goto cleanup;
J
Jamie Strandboge 已提交
260 261
    }

262
    if (VIR_CLOSE(fd) != 0) {
263
        vah_error(NULL, 0, _("failed to close or write to profile"));
264
        goto cleanup;
J
Jamie Strandboge 已提交
265 266 267
    }
    rc = 0;

268
 cleanup:
J
Jamie Strandboge 已提交
269
    VIR_FREE(pcontent);
270
    VIR_FREE(existing);
J
Jamie Strandboge 已提交
271 272 273 274 275 276 277 278 279

    return rc;
}

/*
 * Create a profile based on a template
 */
static int
create_profile(const char *profile, const char *profile_name,
280
               const char *profile_files, int virtType)
J
Jamie Strandboge 已提交
281
{
282
    char *template;
J
Jamie Strandboge 已提交
283 284 285 286
    char *tcontent = NULL;
    char *pcontent = NULL;
    char *replace_name = NULL;
    char *replace_files = NULL;
287
    char *tmp = NULL;
J
Jamie Strandboge 已提交
288 289 290 291 292
    const char *template_name = "\nprofile LIBVIRT_TEMPLATE";
    const char *template_end = "\n}";
    int tlen, plen;
    int fd;
    int rc = -1;
293
    const char *driver_name = NULL;
J
Jamie Strandboge 已提交
294 295

    if (virFileExists(profile)) {
296
        vah_error(NULL, 0, _("profile exists"));
J
Jamie Strandboge 已提交
297 298 299
        goto end;
    }

300 301 302 303 304 305 306 307 308
    switch (virtType) {
    case VIR_DOMAIN_VIRT_QEMU:
    case VIR_DOMAIN_VIRT_KQEMU:
    case VIR_DOMAIN_VIRT_KVM:
        driver_name = "qemu";
        break;
    default:
        driver_name = virDomainVirtTypeToString(virtType);
    }
C
Cédric Bosdonnat 已提交
309 310

    if (virAsprintfQuiet(&template, "%s/TEMPLATE.%s", APPARMOR_DIR "/libvirt",
311
                         driver_name) < 0) {
312
        vah_error(NULL, 0, _("template name exceeds maximum length"));
J
Jamie Strandboge 已提交
313 314 315 316
        goto end;
    }

    if (!virFileExists(template)) {
317
        vah_error(NULL, 0, _("template does not exist"));
J
Jamie Strandboge 已提交
318 319 320 321
        goto end;
    }

    if ((tlen = virFileReadAll(template, MAX_FILE_LEN, &tcontent)) < 0) {
322
        vah_error(NULL, 0, _("failed to read AppArmor template"));
J
Jamie Strandboge 已提交
323 324 325 326
        goto end;
    }

    if (strstr(tcontent, template_name) == NULL) {
327
        vah_error(NULL, 0, _("no replacement string in template"));
J
Jamie Strandboge 已提交
328 329 330 331
        goto clean_tcontent;
    }

    if (strstr(tcontent, template_end) == NULL) {
332
        vah_error(NULL, 0, _("no replacement string in template"));
J
Jamie Strandboge 已提交
333 334 335 336
        goto clean_tcontent;
    }

    /* '\nprofile <profile_name>\0' */
337
    if (virAsprintfQuiet(&replace_name, "\nprofile %s", profile_name) == -1) {
338
        vah_error(NULL, 0, _("could not allocate memory for profile name"));
J
Jamie Strandboge 已提交
339 340 341 342
        goto clean_tcontent;
    }

    /* '\n<profile_files>\n}\0' */
343 344
    if ((virtType != VIR_DOMAIN_VIRT_LXC) &&
            virAsprintfQuiet(&replace_files, "\n%s\n}", profile_files) == -1) {
345
        vah_error(NULL, 0, _("could not allocate memory for profile files"));
J
Jamie Strandboge 已提交
346 347 348 349
        VIR_FREE(replace_name);
        goto clean_tcontent;
    }

C
Cédric Bosdonnat 已提交
350
    plen = tlen + strlen(replace_name) - strlen(template_name) + 1;
351 352 353 354

    if (virtType != VIR_DOMAIN_VIRT_LXC)
        plen += strlen(replace_files) - strlen(template_end);

J
Jamie Strandboge 已提交
355
    if (plen > MAX_FILE_LEN || plen < tlen) {
356
        vah_error(NULL, 0, _("invalid length for new profile"));
J
Jamie Strandboge 已提交
357 358 359
        goto clean_replace;
    }

360
    if (!(pcontent = virStringReplace(tcontent, template_name, replace_name)))
J
Jamie Strandboge 已提交
361 362
        goto clean_all;

363 364 365 366 367 368 369
    if (virtType != VIR_DOMAIN_VIRT_LXC) {
        if (!(tmp = virStringReplace(pcontent, template_end, replace_files)))
            goto clean_all;
        VIR_FREE(pcontent);
        pcontent = tmp;
        tmp = NULL;
    }
J
Jamie Strandboge 已提交
370 371 372

    /* write the file */
    if ((fd = open(profile, O_CREAT | O_EXCL | O_WRONLY, 0644)) == -1) {
373
        vah_error(NULL, 0, _("failed to create profile"));
J
Jamie Strandboge 已提交
374 375 376 377
        goto clean_all;
    }

    if (safewrite(fd, pcontent, plen - 1) < 0) { /* don't write the '\0' */
378
        VIR_FORCE_CLOSE(fd);
379
        vah_error(NULL, 0, _("failed to write to profile"));
J
Jamie Strandboge 已提交
380 381 382
        goto clean_all;
    }

383
    if (VIR_CLOSE(fd) != 0) {
384
        vah_error(NULL, 0, _("failed to close or write to profile"));
J
Jamie Strandboge 已提交
385 386 387 388
        goto clean_all;
    }
    rc = 0;

389
 clean_all:
J
Jamie Strandboge 已提交
390
    VIR_FREE(pcontent);
391
 clean_replace:
J
Jamie Strandboge 已提交
392 393
    VIR_FREE(replace_name);
    VIR_FREE(replace_files);
394
 clean_tcontent:
J
Jamie Strandboge 已提交
395
    VIR_FREE(tcontent);
396
 end:
397
    VIR_FREE(template);
J
Jamie Strandboge 已提交
398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451
    return rc;
}

/*
 * Load an existing profile
 */
static int
parserLoad(const char *profile_name)
{
    return parserCommand(profile_name, 'a');
}

/*
 * Remove an existing profile
 */
static int
parserRemove(const char *profile_name)
{
    return parserCommand(profile_name, 'R');
}

/*
 * Replace an existing profile
 */
static int
parserReplace(const char *profile_name)
{
    return parserCommand(profile_name, 'r');
}

static int
valid_uuid(const char *uuid)
{
    unsigned char rawuuid[VIR_UUID_BUFLEN];

    if (strlen(uuid) != PROFILE_NAME_SIZE - 1)
        return -1;

    if (!STRPREFIX(uuid, AA_PREFIX))
        return -1;

    if (virUUIDParse(uuid + strlen(AA_PREFIX), rawuuid) < 0)
        return -1;

    return 0;
}

static int
valid_name(const char *name)
{
    /* just try to filter out any dangerous characters in the name that can be
     * used to subvert the profile */
    const char *bad = " /[]*";

452
    if (strlen(name) == 0)
J
Jamie Strandboge 已提交
453 454 455 456 457 458 459 460 461 462 463 464
        return -1;

    if (strcspn(name, bad) != strlen(name))
        return -1;

    return 0;
}

/* see if one of the strings in arr starts with str */
static int
array_starts_with(const char *str, const char * const *arr, const long size)
{
465
    size_t i;
J
Jamie Strandboge 已提交
466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513
    for (i = 0; i < size; i++) {
        if (strlen(str) < strlen(arr[i]))
            continue;

        if (STRPREFIX(str, arr[i]))
            return 0;
    }
    return 1;
}

/*
 * Don't allow access to special files or restricted paths such as /bin, /sbin,
 * /usr/bin, /usr/sbin and /etc. This is in an effort to prevent read/write
 * access to system files which could be used to elevate privileges. This is a
 * safety measure in case libvirtd is under a restrictive profile and is
 * subverted and trying to escape confinement.
 *
 * Note that we cannot exclude block devices because they are valid devices.
 * The TEMPLATE file can be adjusted to explicitly disallow these if needed.
 *
 * RETURN: -1 on error, 0 if ok, 1 if blocked
 */
static int
valid_path(const char *path, const bool readonly)
{
    const char * const restricted[] = {
        "/bin/",
        "/etc/",
        "/lib",
        "/lost+found/",
        "/proc/",
        "/sbin/",
        "/selinux/",
        "/sys/",
        "/usr/bin/",
        "/usr/lib",
        "/usr/sbin/",
        "/usr/share/",
        "/usr/local/bin/",
        "/usr/local/etc/",
        "/usr/local/lib",
        "/usr/local/sbin/"
    };
    /* these paths are ok for readonly, but not read/write */
    const char * const restricted_rw[] = {
        "/boot/",
        "/vmlinuz",
        "/initrd",
514
        "/initrd.img",
515
        "/usr/share/OVMF/",              /* for OVMF images */
516
        "/usr/share/ovmf/"               /* for OVMF images */
J
Jamie Strandboge 已提交
517
    };
518 519
    /* override the above with these */
    const char * const override[] = {
J
John Ferlan 已提交
520
        "/sys/devices/pci",              /* for hostdev pci devices */
521
        "/etc/libvirt-sandbox/services/" /* for virt-sandbox service config */
522
    };
J
Jamie Strandboge 已提交
523

524 525 526 527
    const int nropaths = ARRAY_CARDINALITY(restricted);
    const int nrwpaths = ARRAY_CARDINALITY(restricted_rw);
    const int nopaths = ARRAY_CARDINALITY(override);

528
    if (path == NULL) {
529
        vah_error(NULL, 0, _("bad pathname"));
J
Jamie Strandboge 已提交
530 531 532 533 534 535 536 537 538
        return -1;
    }

    /* Don't allow double quotes, since we use them to quote the filename
     * and this will confuse the apparmor parser.
     */
    if (strchr(path, '"') != NULL)
        return 1;

J
Jamie Strandboge 已提交
539 540 541 542
    /* Require an absolute path */
    if (STRNEQLEN(path, "/", 1))
        return 1;

543
    if (!virFileExists(path))
544
        vah_warning(_("path does not exist, skipping file type checks"));
J
Jamie Strandboge 已提交
545

546
    /* overrides are always allowed */
547
    if (array_starts_with(path, override, nopaths) == 0)
548
        return 0;
J
Jamie Strandboge 已提交
549

550 551
    /* allow read only paths upfront */
    if (readonly) {
552
        if (array_starts_with(path, restricted_rw, nrwpaths) == 0)
553
            return 0;
J
Jamie Strandboge 已提交
554 555
    }

556
    /* disallow RW acess to all paths in restricted and restriced_rw */
557 558
    if ((array_starts_with(path, restricted, nropaths) == 0 ||
         array_starts_with(path, restricted_rw, nrwpaths) == 0))
559 560
        return 1;

J
Jamie Strandboge 已提交
561 562 563
    return 0;
}

564 565 566 567 568 569 570
static int
verify_xpath_context(xmlXPathContextPtr ctxt)
{
    int rc = -1;
    char *tmp = NULL;

    if (!ctxt) {
571
        vah_warning(_("Invalid context"));
572 573 574 575 576
        goto error;
    }

    /* check if have <name> */
    if (!(tmp = virXPathString("string(./name[1])", ctxt))) {
577
        vah_warning(_("Could not find <name>"));
578 579 580 581 582 583
        goto error;
    }
    VIR_FREE(tmp);

    /* check if have <uuid> */
    if (!(tmp = virXPathString("string(./uuid[1])", ctxt))) {
584
        vah_warning(_("Could not find <uuid>"));
585 586 587 588 589 590
        goto error;
    }
    VIR_FREE(tmp);

    rc = 0;

591
 error:
592 593 594
    return rc;
}

595 596
/*
 * Parse the xml we received to fill in the following:
597
 * ctl->virtType
598
 * ctl->os
599 600 601 602 603 604 605 606 607 608
 * ctl->arch
 *
 * These are suitable for setting up a virCapsPtr
 */
static int
caps_mockup(vahControl * ctl, const char *xmlStr)
{
    int rc = -1;
    xmlDocPtr xml = NULL;
    xmlXPathContextPtr ctxt = NULL;
609
    char *arch;
610

611
    if (!(xml = virXMLParseStringCtxt(xmlStr, _("(domain_definition)"),
612
                                      &ctxt))) {
613 614 615
        goto cleanup;
    }

616
    if (!xmlStrEqual(ctxt->node->name, BAD_CAST "domain")) {
617
        vah_error(NULL, 0, _("unexpected root element, expecting <domain>"));
618 619 620
        goto cleanup;
    }

621 622 623 624
    /* Quick sanity check for some required elements */
    if (verify_xpath_context(ctxt) != 0)
        goto cleanup;

625 626 627 628 629
    ctl->virtType = virXPathString("string(./@type)", ctxt);
    if (!ctl->virtType) {
        vah_error(ctl, 0, _("domain type is not defined"));
        goto cleanup;
    }
630 631
    ctl->os = virXPathString("string(./os/type[1])", ctxt);
    if (!ctl->os) {
632
        vah_error(ctl, 0, _("os.type is not defined"));
633 634
        goto cleanup;
    }
635 636 637 638 639 640
    arch = virXPathString("string(./os/type[1]/@arch)", ctxt);
    if (!arch) {
        ctl->arch = virArchFromHost();
    } else {
        ctl->arch = virArchFromString(arch);
        VIR_FREE(arch);
641 642 643 644
    }

    rc = 0;

645
 cleanup:
646
    xmlFreeDoc(xml);
647 648 649 650 651
    xmlXPathFreeContext(ctxt);

    return rc;
}

652

J
Jamie Strandboge 已提交
653 654 655
static int
get_definition(vahControl * ctl, const char *xmlStr)
{
656
    int rc = -1, ostype, virtType;
J
Jamie Strandboge 已提交
657 658 659 660 661 662
    virCapsGuestPtr guest;  /* this is freed when caps is freed */

    /*
     * mock up some capabilities. We don't currently use these explicitly,
     * but need them for virDomainDefParseString().
     */
663 664
    if (caps_mockup(ctl, xmlStr) != 0)
        goto exit;
J
Jamie Strandboge 已提交
665

666
    if ((ctl->caps = virCapabilitiesNew(ctl->arch, true, true)) == NULL) {
667
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
668 669 670
        goto exit;
    }

671
    if (!(ctl->xmlopt = virDomainXMLOptionNew(NULL, NULL, NULL, NULL, NULL))) {
672 673 674 675
        vah_error(ctl, 0, _("Failed to create XML config object"));
        goto exit;
    }

676
    if ((ostype = virDomainOSTypeFromString(ctl->os)) < 0) {
677 678 679 680
        vah_error(ctl, 0, _("unknown OS type"));
        goto exit;
    }

J
Jamie Strandboge 已提交
681
    if ((guest = virCapabilitiesAddGuest(ctl->caps,
682
                                         ostype,
683
                                         ctl->arch,
J
Jamie Strandboge 已提交
684 685 686 687
                                         NULL,
                                         NULL,
                                         0,
                                         NULL)) == NULL) {
688
        vah_error(ctl, 0, _("could not allocate memory"));
689 690 691 692 693 694 695 696 697 698 699 700 701 702 703
        goto exit;
    }

    if ((virtType = virDomainVirtTypeFromString(ctl->virtType)) < 0) {
        vah_error(ctl, 0, _("unknown virtualization type"));
        goto exit;
    }

    if (virCapabilitiesAddGuestDomain(guest,
                                      virtType,
                                      NULL,
                                      NULL,
                                      0,
                                      NULL) == NULL) {
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
704 705 706
        goto exit;
    }

707
    ctl->def = virDomainDefParseString(xmlStr,
708
                                       ctl->caps, ctl->xmlopt, NULL,
709
                                       VIR_DOMAIN_DEF_PARSE_SKIP_SECLABEL |
710
                                       VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE);
711

J
Jamie Strandboge 已提交
712
    if (ctl->def == NULL) {
713
        vah_error(ctl, 0, _("could not parse XML"));
J
Jamie Strandboge 已提交
714 715 716 717
        goto exit;
    }

    if (!ctl->def->name) {
718
        vah_error(ctl, 0, _("could not find name in XML"));
J
Jamie Strandboge 已提交
719 720 721 722
        goto exit;
    }

    if (valid_name(ctl->def->name) != 0) {
723
        vah_error(ctl, 0, _("bad name"));
J
Jamie Strandboge 已提交
724 725 726 727 728
        goto exit;
    }

    rc = 0;

729
 exit:
J
Jamie Strandboge 已提交
730 731 732
    return rc;
}

733 734 735 736
/**
  * The permissions allowed are apparmor valid permissions and 'R'. 'R' stands for
  * read with no explicit deny rule.
  */
J
Jamie Strandboge 已提交
737
static int
F
Felix Geyer 已提交
738
vah_add_path(virBufferPtr buf, const char *path, const char *perms, bool recursive)
J
Jamie Strandboge 已提交
739 740 741 742
{
    char *tmp = NULL;
    int rc = -1;
    bool readonly = true;
743 744
    bool explicit_deny_rule = true;
    char *sub = NULL;
745
    char *perms_new = NULL;
J
Jamie Strandboge 已提交
746 747 748 749

    if (path == NULL)
        return rc;

J
Jamie Strandboge 已提交
750 751 752 753 754 755
    /* Skip files without an absolute path. Not having one confuses the
     * apparmor parser and this also ensures things like tcp consoles don't
     * get added to the profile.
     */
    if (STRNEQLEN(path, "/", 1)) {
        vah_warning(path);
756
        vah_warning(_("skipped non-absolute path"));
J
Jamie Strandboge 已提交
757 758 759
        return 0;
    }

J
Jamie Strandboge 已提交
760 761 762
    if (virFileExists(path)) {
        if ((tmp = realpath(path, NULL)) == NULL) {
            vah_error(NULL, 0, path);
763
            vah_error(NULL, 0, _("could not find realpath for disk"));
J
Jamie Strandboge 已提交
764 765
            return rc;
        }
766 767 768
    } else if (VIR_STRDUP_QUIET(tmp, path) < 0) {
        return rc;
    }
J
Jamie Strandboge 已提交
769

770
    if (VIR_STRDUP_QUIET(perms_new, perms) < 0)
771
        goto cleanup;
772 773

    if (strchr(perms_new, 'w') != NULL) {
J
Jamie Strandboge 已提交
774
        readonly = false;
775 776 777
        explicit_deny_rule = false;
    }

778
    if ((sub = strchr(perms_new, 'R')) != NULL) {
779 780 781 782
        /* Don't write the invalid R permission, replace it with 'r' */
        sub[0] = 'r';
        explicit_deny_rule = false;
    }
J
Jamie Strandboge 已提交
783 784 785 786 787

    rc = valid_path(tmp, readonly);
    if (rc != 0) {
        if (rc > 0) {
            vah_error(NULL, 0, path);
788
            vah_error(NULL, 0, _("skipped restricted file"));
J
Jamie Strandboge 已提交
789
        }
790
        goto cleanup;
J
Jamie Strandboge 已提交
791 792
    }

793 794 795
    if (tmp[strlen(tmp) - 1] == '/')
        tmp[strlen(tmp) - 1] = '\0';

796 797
    virBufferAsprintf(buf, "  \"%s%s\" %s,\n", tmp, recursive ? "/**" : "",
                      perms_new);
798
    if (explicit_deny_rule) {
799
        virBufferAddLit(buf, "  # don't audit writes to readonly files\n");
F
Felix Geyer 已提交
800 801 802 803 804
        virBufferAsprintf(buf, "  deny \"%s%s\" w,\n", tmp, recursive ? "/**" : "");
    }
    if (recursive) {
        /* allow reading (but not creating) the dir */
        virBufferAsprintf(buf, "  \"%s/\" r,\n", tmp);
805
    }
J
Jamie Strandboge 已提交
806

807
 cleanup:
808
    VIR_FREE(perms_new);
809
    VIR_FREE(tmp);
J
Jamie Strandboge 已提交
810 811 812 813

    return rc;
}

F
Felix Geyer 已提交
814 815 816 817 818 819
static int
vah_add_file(virBufferPtr buf, const char *path, const char *perms)
{
    return vah_add_path(buf, path, perms, false);
}

820 821 822 823 824 825 826 827 828 829 830 831
static int
vah_add_file_chardev(virBufferPtr buf,
                     const char *path,
                     const char *perms,
                     const int type)
{
    char *pipe_in;
    char *pipe_out;
    int rc = -1;

    if (type == VIR_DOMAIN_CHR_TYPE_PIPE) {
        /* add the pipe input */
832
        if (virAsprintfQuiet(&pipe_in, "%s.in", path) == -1) {
833
            vah_error(NULL, 0, _("could not allocate memory"));
834
            goto cleanup;
835 836 837 838 839 840
        }

        if (vah_add_file(buf, pipe_in, perms) != 0)
            goto clean_pipe_in;

        /* add the pipe output */
841
        if (virAsprintfQuiet(&pipe_out, "%s.out", path) == -1) {
842 843 844 845 846 847 848 849 850 851 852 853 854 855 856
            vah_error(NULL, 0, _("could not allocate memory"));
            goto clean_pipe_in;
        }

        if (vah_add_file(buf, pipe_out, perms) != 0)
            goto clean_pipe_out;

        rc = 0;
      clean_pipe_out:
        VIR_FREE(pipe_out);
      clean_pipe_in:
        VIR_FREE(pipe_in);
    } else {
        /* add the file */
        if (vah_add_file(buf, path, perms) != 0)
857
            goto cleanup;
858 859 860
        rc = 0;
    }

861
 cleanup:
862 863 864
    return rc;
}

J
Jamie Strandboge 已提交
865
static int
866
file_iterate_hostdev_cb(virUSBDevicePtr dev ATTRIBUTE_UNUSED,
867 868 869 870 871 872 873
                        const char *file, void *opaque)
{
    virBufferPtr buf = opaque;
    return vah_add_file(buf, file, "rw");
}

static int
874 875
file_iterate_pci_cb(virPCIDevicePtr dev ATTRIBUTE_UNUSED,
                    const char *file, void *opaque)
J
Jamie Strandboge 已提交
876 877 878 879 880
{
    virBufferPtr buf = opaque;
    return vah_add_file(buf, file, "rw");
}

881 882 883 884 885 886 887 888 889 890
static int
add_file_path(virDomainDiskDefPtr disk,
              const char *path,
              size_t depth,
              void *opaque)
{
    virBufferPtr buf = opaque;
    int ret;

    if (depth == 0) {
891
        if (disk->src->readonly)
892 893 894 895 896 897 898
            ret = vah_add_file(buf, path, "r");
        else
            ret = vah_add_file(buf, path, "rw");
    } else {
        ret = vah_add_file(buf, path, "r");
    }

899 900 901
    if (ret != 0)
        ret = -1;

902 903 904
    return ret;
}

J
Jamie Strandboge 已提交
905 906 907 908 909
static int
get_files(vahControl * ctl)
{
    virBuffer buf = VIR_BUFFER_INITIALIZER;
    int rc = -1;
910
    size_t i;
J
Jamie Strandboge 已提交
911 912
    char *uuid;
    char uuidstr[VIR_UUID_STRING_BUFLEN];
913
    bool needsVfio = false, needsvhost = false;
J
Jamie Strandboge 已提交
914 915 916

    /* verify uuid is same as what we were given on the command line */
    virUUIDFormat(ctl->def->uuid, uuidstr);
917
    if (virAsprintfQuiet(&uuid, "%s%s", AA_PREFIX, uuidstr) == -1) {
918
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
919 920 921 922
        return rc;
    }

    if (STRNEQ(uuid, ctl->uuid)) {
923
        vah_error(ctl, 0, _("given uuid does not match XML uuid"));
924
        goto cleanup;
J
Jamie Strandboge 已提交
925 926
    }

927
    for (i = 0; i < ctl->def->ndisks; i++) {
928 929
        virDomainDiskDefPtr disk = ctl->def->disks[i];

930
        if (!virDomainDiskGetSource(disk))
E
Eric Blake 已提交
931
            continue;
932 933 934
        /* XXX - if we knew the qemu user:group here we could send it in
         *        so that the open could be re-tried as that user:group.
         */
935
        if (!disk->src->backingStore) {
J
Jiri Denemark 已提交
936
            bool probe = ctl->allowDiskFormatProbing;
937
            virStorageFileGetMetadata(disk->src, -1, -1, probe, false);
J
Jiri Denemark 已提交
938
        }
939

940 941 942
        /* XXX passing ignoreOpenFailure = true to get back to the behavior
         * from before using virDomainDiskDefForeachPath. actually we should
         * be passing ignoreOpenFailure = false and handle open errors more
943 944
         * careful than just ignoring them.
         */
945
        if (virDomainDiskDefForeachPath(disk, true, add_file_path, &buf) < 0)
946
            goto cleanup;
947
    }
J
Jamie Strandboge 已提交
948 949

    for (i = 0; i < ctl->def->nserials; i++)
950
        if (ctl->def->serials[i] &&
951 952 953 954 955 956 957
            (ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->serials[i]->source->data.file.path &&
            ctl->def->serials[i]->source->data.file.path[0] != '\0')
958
            if (vah_add_file_chardev(&buf,
959
                                     ctl->def->serials[i]->source->data.file.path,
960
                                     "rw",
961
                                     ctl->def->serials[i]->source->type) != 0)
962
                goto cleanup;
J
Jamie Strandboge 已提交
963

964 965
    for (i = 0; i < ctl->def->nconsoles; i++)
        if (ctl->def->consoles[i] &&
966 967 968 969 970 971 972
            (ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->consoles[i]->source->data.file.path &&
            ctl->def->consoles[i]->source->data.file.path[0] != '\0')
973
            if (vah_add_file(&buf,
974
                             ctl->def->consoles[i]->source->data.file.path, "rw") != 0)
975
                goto cleanup;
J
Jamie Strandboge 已提交
976

977
    for (i = 0; i < ctl->def->nparallels; i++)
978
        if (ctl->def->parallels[i] &&
979 980 981 982 983 984 985
            (ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->parallels[i]->source->data.file.path &&
            ctl->def->parallels[i]->source->data.file.path[0] != '\0')
986
            if (vah_add_file_chardev(&buf,
987
                                     ctl->def->parallels[i]->source->data.file.path,
988
                                     "rw",
989
                                     ctl->def->parallels[i]->source->type) != 0)
990
                goto cleanup;
991

992
    for (i = 0; i < ctl->def->nchannels; i++)
993
        if (ctl->def->channels[i] &&
994 995 996 997 998 999 1000
            (ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->channels[i]->source->data.file.path &&
            ctl->def->channels[i]->source->data.file.path[0] != '\0')
1001
            if (vah_add_file_chardev(&buf,
1002
                                     ctl->def->channels[i]->source->data.file.path,
1003
                                     "rw",
1004
                                     ctl->def->channels[i]->source->type) != 0)
1005
                goto cleanup;
1006

1007
    if (ctl->def->os.kernel)
J
Jamie Strandboge 已提交
1008
        if (vah_add_file(&buf, ctl->def->os.kernel, "r") != 0)
1009
            goto cleanup;
J
Jamie Strandboge 已提交
1010

1011
    if (ctl->def->os.initrd)
J
Jamie Strandboge 已提交
1012
        if (vah_add_file(&buf, ctl->def->os.initrd, "r") != 0)
1013
            goto cleanup;
O
Olivia Yin 已提交
1014 1015 1016

    if (ctl->def->os.dtb)
        if (vah_add_file(&buf, ctl->def->os.dtb, "r") != 0)
1017
            goto cleanup;
J
Jamie Strandboge 已提交
1018

J
Ján Tomko 已提交
1019 1020 1021 1022
    if (ctl->def->os.slic_table)
        if (vah_add_file(&buf, ctl->def->os.slic_table, "r") != 0)
            goto cleanup;

1023 1024
    if (ctl->def->os.loader && ctl->def->os.loader->path)
        if (vah_add_file(&buf, ctl->def->os.loader->path, "r") != 0)
1025
            goto cleanup;
1026

1027 1028 1029 1030
    if (ctl->def->os.loader && ctl->def->os.loader->nvram)
        if (vah_add_file(&buf, ctl->def->os.loader->nvram, "rw") != 0)
            goto cleanup;

1031
    for (i = 0; i < ctl->def->ngraphics; i++) {
1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042
        virDomainGraphicsDefPtr graphics = ctl->def->graphics[i];
        size_t n;

        for (n = 0; n < graphics->nListens; n++) {
            virDomainGraphicsListenDef listenObj = graphics->listens[n];

            if (listenObj.type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET &&
                listenObj.socket &&
                vah_add_file(&buf, listenObj.socket, "rw"))
                goto cleanup;
        }
1043 1044
    }

1045 1046 1047 1048
    if (ctl->def->ngraphics == 1 &&
        ctl->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL)
        if (vah_add_file(&buf, ctl->def->graphics[0]->data.sdl.xauth,
                         "r") != 0)
1049
            goto cleanup;
J
Jamie Strandboge 已提交
1050 1051 1052 1053

    for (i = 0; i < ctl->def->nhostdevs; i++)
        if (ctl->def->hostdevs[i]) {
            virDomainHostdevDefPtr dev = ctl->def->hostdevs[i];
1054
            virDomainHostdevSubsysUSBPtr usbsrc = &dev->source.subsys.u.usb;
J
Jamie Strandboge 已提交
1055 1056
            switch (dev->source.subsys.type) {
            case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB: {
1057
                virUSBDevicePtr usb =
1058
                    virUSBDeviceNew(usbsrc->bus, usbsrc->device, NULL);
1059 1060 1061 1062

                if (usb == NULL)
                    continue;

1063 1064
                rc = virUSBDeviceFileIterate(usb, file_iterate_hostdev_cb, &buf);
                virUSBDeviceFree(usb);
1065
                if (rc != 0)
1066
                    goto cleanup;
J
Jamie Strandboge 已提交
1067 1068
                break;
            }
1069

J
Jamie Strandboge 已提交
1070
            case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI: {
1071
                virPCIDevicePtr pci = virPCIDeviceNew(
1072 1073 1074 1075
                           dev->source.subsys.u.pci.addr.domain,
                           dev->source.subsys.u.pci.addr.bus,
                           dev->source.subsys.u.pci.addr.slot,
                           dev->source.subsys.u.pci.addr.function);
J
Jamie Strandboge 已提交
1076

1077
                virDomainHostdevSubsysPCIBackendType backend = dev->source.subsys.u.pci.backend;
1078 1079 1080 1081 1082
                if (backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO ||
                        backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT) {
                    needsVfio = true;
                }

J
Jamie Strandboge 已提交
1083 1084 1085
                if (pci == NULL)
                    continue;

1086 1087
                rc = virPCIDeviceFileIterate(pci, file_iterate_pci_cb, &buf);
                virPCIDeviceFree(pci);
J
Jamie Strandboge 已提交
1088 1089 1090

                break;
            }
1091

J
Jamie Strandboge 已提交
1092 1093 1094 1095 1096 1097
            default:
                rc = 0;
                break;
            } /* switch */
        }

F
Felix Geyer 已提交
1098 1099 1100 1101 1102
    for (i = 0; i < ctl->def->nfss; i++) {
        if (ctl->def->fss[i] &&
                ctl->def->fss[i]->type == VIR_DOMAIN_FS_TYPE_MOUNT &&
                (ctl->def->fss[i]->fsdriver == VIR_DOMAIN_FS_DRIVER_TYPE_PATH ||
                 ctl->def->fss[i]->fsdriver == VIR_DOMAIN_FS_DRIVER_TYPE_DEFAULT) &&
1103
                ctl->def->fss[i]->src) {
F
Felix Geyer 已提交
1104 1105
            virDomainFSDefPtr fs = ctl->def->fss[i];

1106 1107 1108
            /* We don't need to add deny rw rules for readonly mounts,
             * this can only lead to troubles when mounting / readonly.
             */
1109
            if (vah_add_path(&buf, fs->src->path, fs->readonly ? "R" : "rw", true) != 0)
F
Felix Geyer 已提交
1110 1111 1112 1113
                goto cleanup;
        }
    }

1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125
    for (i = 0; i < ctl->def->nnets; i++) {
        if (ctl->def->nets[i] &&
                ctl->def->nets[i]->type == VIR_DOMAIN_NET_TYPE_VHOSTUSER &&
                ctl->def->nets[i]->data.vhostuser) {
            virDomainChrSourceDefPtr vhu = ctl->def->nets[i]->data.vhostuser;

            if (vah_add_file_chardev(&buf, vhu->data.nix.path, "rw",
                       vhu->type) != 0)
                goto cleanup;
        }
    }

1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140
    if (ctl->def->virtType == VIR_DOMAIN_VIRT_KVM) {
        for (i = 0; i < ctl->def->nnets; i++) {
            virDomainNetDefPtr net = ctl->def->nets[i];
            if (net && net->model) {
                if (net->driver.virtio.name == VIR_DOMAIN_NET_BACKEND_TYPE_QEMU)
                    continue;
                if (STRNEQ(net->model, "virtio"))
                    continue;
            }
            needsvhost = true;
        }
    }
    if (needsvhost)
        virBufferAddLit(&buf, "  /dev/vhost-net rw,\n");

1141 1142 1143 1144 1145
    if (needsVfio) {
        virBufferAddLit(&buf, "  /dev/vfio/vfio rw,\n");
        virBufferAddLit(&buf, "  /dev/vfio/[0-9]* rw,\n");
    }

1146 1147
    if (ctl->newfile)
        if (vah_add_file(&buf, ctl->newfile, "rw") != 0)
1148
            goto cleanup;
J
Jamie Strandboge 已提交
1149 1150

    if (virBufferError(&buf)) {
1151
        virBufferFreeAndReset(&buf);
1152
        vah_error(NULL, 0, _("failed to allocate file buffer"));
1153
        goto cleanup;
J
Jamie Strandboge 已提交
1154 1155 1156 1157 1158
    }

    rc = 0;
    ctl->files = virBufferContentAndReset(&buf);

1159
 cleanup:
J
Jamie Strandboge 已提交
1160 1161 1162 1163 1164 1165 1166 1167 1168
    VIR_FREE(uuid);
    return rc;
}

static int
vahParseArgv(vahControl * ctl, int argc, char **argv)
{
    int arg, idx = 0;
    struct option opt[] = {
1169
        {"probing", 1, 0, 'p' },
J
Jamie Strandboge 已提交
1170 1171 1172 1173 1174
        {"add", 0, 0, 'a'},
        {"create", 0, 0, 'c'},
        {"dryrun", 0, 0, 'd'},
        {"delete", 0, 0, 'D'},
        {"add-file", 0, 0, 'f'},
1175
        {"append-file", 0, 0, 'F'},
J
Jamie Strandboge 已提交
1176 1177 1178 1179 1180 1181 1182
        {"help", 0, 0, 'h'},
        {"replace", 0, 0, 'r'},
        {"remove", 0, 0, 'R'},
        {"uuid", 1, 0, 'u'},
        {0, 0, 0, 0}
    };

1183
    while ((arg = getopt_long(argc, argv, "acdDhrRH:b:u:p:f:F:", opt,
J
Jamie Strandboge 已提交
1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198
            &idx)) != -1) {
        switch (arg) {
            case 'a':
                ctl->cmd = 'a';
                break;
            case 'c':
                ctl->cmd = 'c';
                break;
            case 'd':
                ctl->dryrun = true;
                break;
            case 'D':
                ctl->cmd = 'D';
                break;
            case 'f':
1199
            case 'F':
1200
                if (VIR_STRDUP_QUIET(ctl->newfile, optarg) < 0)
1201
                    vah_error(ctl, 1, _("could not allocate memory for disk"));
1202
                ctl->append = arg == 'F';
J
Jamie Strandboge 已提交
1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215
                break;
            case 'h':
                vah_usage();
                exit(EXIT_SUCCESS);
                break;
            case 'r':
                ctl->cmd = 'r';
                break;
            case 'R':
                ctl->cmd = 'R';
                break;
            case 'u':
                if (strlen(optarg) > PROFILE_NAME_SIZE - 1)
1216
                    vah_error(ctl, 1, _("invalid UUID"));
J
Jamie Strandboge 已提交
1217 1218
                if (virStrcpy((char *) ctl->uuid, optarg,
                    PROFILE_NAME_SIZE) == NULL)
1219
                    vah_error(ctl, 1, _("error copying UUID"));
J
Jamie Strandboge 已提交
1220
                break;
1221 1222 1223 1224 1225 1226
            case 'p':
                if (STREQ(optarg, "1"))
                    ctl->allowDiskFormatProbing = true;
                else
                    ctl->allowDiskFormatProbing = false;
                break;
J
Jamie Strandboge 已提交
1227
            default:
1228
                vah_error(ctl, 1, _("unsupported option"));
J
Jamie Strandboge 已提交
1229 1230 1231 1232
                break;
        }
    }
    if (strchr("acDrR", ctl->cmd) == NULL)
1233
        vah_error(ctl, 1, _("bad command"));
J
Jamie Strandboge 已提交
1234 1235

    if (valid_uuid(ctl->uuid) != 0)
1236
        vah_error(ctl, 1, _("invalid UUID"));
J
Jamie Strandboge 已提交
1237 1238 1239 1240 1241 1242 1243 1244 1245

    if (!ctl->cmd) {
        vah_usage();
        exit(EXIT_FAILURE);
    }

    if (ctl->cmd == 'c' || ctl->cmd == 'r') {
        char *xmlStr = NULL;
        if (virFileReadLimFD(STDIN_FILENO, MAX_FILE_LEN, &xmlStr) < 0)
1246
            vah_error(ctl, 1, _("could not read xml file"));
J
Jamie Strandboge 已提交
1247 1248 1249

        if (get_definition(ctl, xmlStr) != 0 || ctl->def == NULL) {
            VIR_FREE(xmlStr);
1250
            vah_error(ctl, 1, _("could not get VM definition"));
J
Jamie Strandboge 已提交
1251 1252 1253 1254
        }
        VIR_FREE(xmlStr);

        if (get_files(ctl) != 0)
1255
            vah_error(ctl, 1, _("invalid VM definition"));
J
Jamie Strandboge 已提交
1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273
    }
    return 0;
}


/*
 * virt-aa-helper -c -u UUID < file.xml
 * virt-aa-helper -r -u UUID [-f <file>] < file.xml
 * virt-aa-helper -a -u UUID
 * virt-aa-helper -R -u UUID
 * virt-aa-helper -D -u UUID
 */
int
main(int argc, char **argv)
{
    vahControl _ctl, *ctl = &_ctl;
    virBuffer buf = VIR_BUFFER_INITIALIZER;
    int rc = -1;
1274 1275
    char *profile = NULL;
    char *include_file = NULL;
J
Jamie Strandboge 已提交
1276

1277 1278
    if (virGettextInitialize() < 0 ||
        virThreadInitialize() < 0 ||
1279 1280 1281 1282 1283
        virErrorInitialize() < 0) {
        fprintf(stderr, _("%s: initialization failed\n"), argv[0]);
        exit(EXIT_FAILURE);
    }

1284 1285 1286
    /* Initialize the log system */
    virLogSetFromEnv();

J
Jamie Strandboge 已提交
1287 1288
    /* clear the environment */
    environ = NULL;
1289
    if (setenv("PATH", "/sbin:/usr/sbin", 1) != 0)
1290 1291
        vah_error(ctl, 1, _("could not set PATH"));

1292
    /* ensure the traditional IFS setting */
1293
    if (setenv("IFS", " \t\n", 1) != 0)
1294
        vah_error(ctl, 1, _("could not set IFS"));
J
Jamie Strandboge 已提交
1295 1296 1297 1298 1299 1300 1301 1302 1303

    if (!(progname = strrchr(argv[0], '/')))
        progname = argv[0];
    else
        progname++;

    memset(ctl, 0, sizeof(vahControl));

    if (vahParseArgv(ctl, argc, argv) != 0)
1304
        vah_error(ctl, 1, _("could not parse arguments"));
J
Jamie Strandboge 已提交
1305

1306 1307
    if (virAsprintfQuiet(&profile, "%s/%s",
                         APPARMOR_DIR "/libvirt", ctl->uuid) < 0)
1308
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
1309

1310 1311
    if (virAsprintfQuiet(&include_file, "%s/%s.files",
                         APPARMOR_DIR "/libvirt", ctl->uuid) < 0)
1312
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
1313

1314
    if (ctl->cmd == 'a') {
J
Jamie Strandboge 已提交
1315
        rc = parserLoad(ctl->uuid);
1316
    } else if (ctl->cmd == 'R' || ctl->cmd == 'D') {
J
Jamie Strandboge 已提交
1317 1318 1319 1320 1321 1322 1323 1324
        rc = parserRemove(ctl->uuid);
        if (ctl->cmd == 'D') {
            unlink(include_file);
            unlink(profile);
        }
    } else if (ctl->cmd == 'c' || ctl->cmd == 'r') {
        char *included_files = NULL;

1325
        if (ctl->cmd == 'c' && virFileExists(profile))
1326
            vah_error(ctl, 1, _("profile exists"));
J
Jamie Strandboge 已提交
1327

1328 1329
        if (ctl->append && ctl->newfile) {
            if (vah_add_file(&buf, ctl->newfile, "rw") != 0)
1330
                goto cleanup;
1331
        } else {
1332 1333 1334
            if (ctl->def->virtType == VIR_DOMAIN_VIRT_QEMU ||
                ctl->def->virtType == VIR_DOMAIN_VIRT_KQEMU ||
                ctl->def->virtType == VIR_DOMAIN_VIRT_KVM) {
1335 1336
                virBufferAsprintf(&buf, "  \"%s/log/libvirt/**/%s.log\" w,\n",
                                  LOCALSTATEDIR, ctl->def->name);
1337
                virBufferAsprintf(&buf, "  \"%s/lib/libvirt/qemu/domain-%s/monitor.sock\" rw,\n",
1338
                                  LOCALSTATEDIR, ctl->def->name);
1339 1340 1341 1342
                virBufferAsprintf(&buf, "  \"%s/lib/libvirt/qemu/domain-%d-%.*s/*\" rw,\n",
                                  LOCALSTATEDIR, ctl->def->id, 20, ctl->def->name);
                virBufferAsprintf(&buf, "  \"%s/lib/libvirt/qemu/channel/target/domain-%d-%.*s/*\" rw,\n",
                                  LOCALSTATEDIR, ctl->def->id, 20, ctl->def->name);
1343 1344 1345 1346 1347 1348 1349 1350 1351
                virBufferAsprintf(&buf, "  \"%s/run/libvirt/**/%s.pid\" rwk,\n",
                                  LOCALSTATEDIR, ctl->def->name);
                virBufferAsprintf(&buf, "  \"/run/libvirt/**/%s.pid\" rwk,\n",
                                  ctl->def->name);
                virBufferAsprintf(&buf, "  \"%s/run/libvirt/**/*.tunnelmigrate.dest.%s\" rw,\n",
                                  LOCALSTATEDIR, ctl->def->name);
                virBufferAsprintf(&buf, "  \"/run/libvirt/**/*.tunnelmigrate.dest.%s\" rw,\n",
                                  ctl->def->name);
            }
1352
            if (ctl->files)
1353
                virBufferAdd(&buf, ctl->files, -1);
1354
        }
J
Jamie Strandboge 已提交
1355

1356 1357
        if (virBufferError(&buf)) {
            virBufferFreeAndReset(&buf);
1358
            vah_error(ctl, 1, _("failed to allocate buffer"));
1359
        }
J
Jamie Strandboge 已提交
1360 1361 1362 1363 1364 1365 1366 1367

        included_files = virBufferContentAndReset(&buf);

        /* (re)create the include file using included_files */
        if (ctl->dryrun) {
            vah_info(include_file);
            vah_info(included_files);
            rc = 0;
1368 1369 1370
        } else if (ctl->def->virtType == VIR_DOMAIN_VIRT_LXC) {
            rc = 0;
        } else if ((rc = update_include_file(include_file,
1371
                                             included_files,
1372
                                             ctl->append)) != 0) {
1373
            goto cleanup;
1374
        }
J
Jamie Strandboge 已提交
1375 1376 1377 1378 1379


        /* create the profile from TEMPLATE */
        if (ctl->cmd == 'c') {
            char *tmp = NULL;
1380 1381
            if (virAsprintfQuiet(&tmp, "  #include <libvirt/%s.files>\n",
                                 ctl->uuid) == -1) {
1382
                vah_error(ctl, 0, _("could not allocate memory"));
1383
                goto cleanup;
J
Jamie Strandboge 已提交
1384 1385 1386 1387 1388 1389 1390
            }

            if (ctl->dryrun) {
                vah_info(profile);
                vah_info(ctl->uuid);
                vah_info(tmp);
                rc = 0;
1391 1392
            } else if ((rc = create_profile(profile, ctl->uuid, tmp,
                                            ctl->def->virtType)) != 0) {
1393
                vah_error(ctl, 0, _("could not create profile"));
J
Jamie Strandboge 已提交
1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411
                unlink(include_file);
            }
            VIR_FREE(tmp);
        }

        if (rc == 0 && !ctl->dryrun) {
            if (ctl->cmd == 'c')
                rc = parserLoad(ctl->uuid);
            else
                rc = parserReplace(ctl->uuid);

            /* cleanup */
            if (rc != 0) {
                unlink(include_file);
                if (ctl->cmd == 'c')
                    unlink(profile);
            }
        }
1412
      cleanup:
J
Jamie Strandboge 已提交
1413 1414 1415 1416
        VIR_FREE(included_files);
    }

    vahDeinit(ctl);
1417 1418 1419 1420

    VIR_FREE(profile);
    VIR_FREE(include_file);

J
Jamie Strandboge 已提交
1421 1422
    exit(rc == 0 ? EXIT_SUCCESS : EXIT_FAILURE);
}