lxc_container.c 38.2 KB
Newer Older
1
/*
E
Eric Blake 已提交
2
 * Copyright (C) 2008-2011 Red Hat, Inc.
3
 * Copyright (C) 2008 IBM Corp.
4 5 6 7 8
 *
 * lxc_container.c: file description
 *
 * Authors:
 *  David L. Leskovec <dlesko at linux.vnet.ibm.com>
9
 *  Daniel P. Berrange <berrange@redhat.com>
10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
 */

#include <config.h>

#include <fcntl.h>
#include <limits.h>
#include <stdlib.h>
31
#include <stdio.h>
32 33
#include <sys/ioctl.h>
#include <sys/mount.h>
34
#include <sys/wait.h>
35
#include <sys/stat.h>
36
#include <unistd.h>
37
#include <mntent.h>
38
#include <dirent.h>
39 40 41 42 43 44

/* Yes, we want linux private one, for _syscall2() macro */
#include <linux/unistd.h>

/* For MS_MOVE */
#include <linux/fs.h>
45

D
Daniel P. Berrange 已提交
46
#if HAVE_CAPNG
47
# include <cap-ng.h>
D
Daniel P. Berrange 已提交
48
#endif
49

50 51 52 53
#if HAVE_LIBBLKID
# include <blkid/blkid.h>
#endif

54
#include "virterror_internal.h"
55
#include "logging.h"
56 57
#include "lxc_container.h"
#include "util.h"
58
#include "memory.h"
59
#include "veth.h"
60
#include "uuid.h"
E
Eric Blake 已提交
61
#include "virfile.h"
62
#include "command.h"
63

64 65
#define VIR_FROM_THIS VIR_FROM_LXC

66 67 68 69 70 71
/*
 * GLibc headers are behind the kernel, so we define these
 * constants if they're not present already.
 */

#ifndef CLONE_NEWPID
72
# define CLONE_NEWPID  0x20000000
73 74
#endif
#ifndef CLONE_NEWUTS
75
# define CLONE_NEWUTS  0x04000000
76 77
#endif
#ifndef CLONE_NEWUSER
78
# define CLONE_NEWUSER 0x10000000
79 80
#endif
#ifndef CLONE_NEWIPC
81
# define CLONE_NEWIPC  0x08000000
82 83
#endif
#ifndef CLONE_NEWNET
84
# define CLONE_NEWNET  0x40000000 /* New network namespace */
85 86 87 88 89 90 91 92
#endif

/* messages between parent and container */
typedef char lxc_message_t;
#define LXC_CONTINUE_MSG 'c'

typedef struct __lxc_child_argv lxc_child_argv_t;
struct __lxc_child_argv {
93
    virDomainDefPtr config;
94 95
    unsigned int nveths;
    char **veths;
96 97
    int monitor;
    char *ttyPath;
98
    int handshakefd;
99 100 101
};


102
/**
103
 * lxcContainerBuildInitCmd:
104
 * @vmDef: pointer to vm definition structure
105
 *
106
 * Build a virCommandPtr for launching the container 'init' process
107
 *
108
 * Returns a virCommandPtr
109
 */
110
static virCommandPtr lxcContainerBuildInitCmd(virDomainDefPtr vmDef)
111
{
112
    char uuidstr[VIR_UUID_STRING_BUFLEN];
113
    virCommandPtr cmd;
114 115 116

    virUUIDFormat(vmDef->uuid, uuidstr);

117 118 119 120 121 122
    cmd = virCommandNew(vmDef->os.init);

    virCommandAddEnvString(cmd, "PATH=/bin:/sbin");
    virCommandAddEnvString(cmd, "TERM=linux");
    virCommandAddEnvPair(cmd, "LIBVIRT_LXC_UUID", uuidstr);
    virCommandAddEnvPair(cmd, "LIBVIRT_LXC_NAME", vmDef->name);
123 124
    if (vmDef->os.cmdline)
        virCommandAddEnvPair(cmd, "LIBVIRT_LXC_CMDLINE", vmDef->os.cmdline);
125

126
    return cmd;
127 128 129
}

/**
130
 * lxcContainerSetStdio:
131 132
 * @control: control FD from parent
 * @ttyfd: FD of tty to set as the container console
133 134 135 136 137 138
 *
 * Sets the given tty as the primary conosole for the container as well as
 * stdout, stdin and stderr.
 *
 * Returns 0 on success or -1 in case of error
 */
139
static int lxcContainerSetStdio(int control, int ttyfd, int handshakefd)
140 141
{
    int rc = -1;
142
    int open_max, i;
143 144

    if (setsid() < 0) {
145
        virReportSystemError(errno, "%s",
146
                             _("setsid failed"));
147
        goto cleanup;
148 149 150
    }

    if (ioctl(ttyfd, TIOCSCTTY, NULL) < 0) {
151
        virReportSystemError(errno, "%s",
152
                             _("ioctl(TIOCSTTY) failed"));
153 154 155
        goto cleanup;
    }

156 157 158 159
    /* Just in case someone forget to set FD_CLOEXEC, explicitly
     * close all FDs before executing the container */
    open_max = sysconf (_SC_OPEN_MAX);
    for (i = 0; i < open_max; i++)
160
        if (i != ttyfd && i != control && i != handshakefd) {
161 162 163
            int tmpfd = i;
            VIR_FORCE_CLOSE(tmpfd);
        }
164 165

    if (dup2(ttyfd, 0) < 0) {
166
        virReportSystemError(errno, "%s",
167
                             _("dup2(stdin) failed"));
168 169 170 171
        goto cleanup;
    }

    if (dup2(ttyfd, 1) < 0) {
172
        virReportSystemError(errno, "%s",
173
                             _("dup2(stdout) failed"));
174 175 176 177
        goto cleanup;
    }

    if (dup2(ttyfd, 2) < 0) {
178
        virReportSystemError(errno, "%s",
179
                             _("dup2(stderr) failed"));
180 181 182 183 184 185
        goto cleanup;
    }

    rc = 0;

cleanup:
186
    VIR_DEBUG("rc=%d", rc);
187 188 189 190
    return rc;
}

/**
191
 * lxcContainerSendContinue:
192
 * @control: control FD to child
193
 *
194 195
 * Sends the continue message via the socket pair stored in the vm
 * structure.
196 197 198
 *
 * Returns 0 on success or -1 in case of error
 */
199
int lxcContainerSendContinue(int control)
200 201
{
    int rc = -1;
202 203
    lxc_message_t msg = LXC_CONTINUE_MSG;
    int writeCount = 0;
204

205 206 207
    writeCount = safewrite(control, &msg, sizeof(msg));
    if (writeCount != sizeof(msg)) {
        goto error_out;
208 209
    }

210 211 212
    rc = 0;
error_out:
    return rc;
213 214
}

215
/**
216
 * lxcContainerWaitForContinue:
217
 * @control: Control FD from parent
218 219 220 221 222 223 224
 *
 * This function will wait for the container continue message from the
 * parent process.  It will send this message on the socket pair stored in
 * the vm structure once it has completed the post clone container setup.
 *
 * Returns 0 on success or -1 in case of error
 */
225
int lxcContainerWaitForContinue(int control)
226 227 228 229
{
    lxc_message_t msg;
    int readLen;

230
    readLen = saferead(control, &msg, sizeof(msg));
231 232 233 234 235 236 237
    if (readLen != sizeof(msg)) {
        if (readLen >= 0)
            errno = EIO;
        return -1;
    }
    if (msg != LXC_CONTINUE_MSG) {
        errno = EINVAL;
238
        return -1;
239 240
    }

241
    return 0;
242 243
}

244

245
/**
246
 * lxcContainerRenameAndEnableInterfaces:
247 248
 * @nveths: number of interfaces
 * @veths: interface names
249
 *
250 251 252
 * This function will rename the interfaces to ethN
 * with id ascending order from zero and enable the
 * renamed interfaces for this container.
253 254 255
 *
 * Returns 0 on success or nonzero in case of error
 */
256 257
static int lxcContainerRenameAndEnableInterfaces(unsigned int nveths,
                                                 char **veths)
258 259
{
    int rc = 0;
260
    unsigned int i;
261
    char *newname = NULL;
262

263
    for (i = 0 ; i < nveths ; i++) {
264 265 266
        if (virAsprintf(&newname, "eth%d", i) < 0) {
            virReportOOMError();
            rc = -1;
267
            goto error_out;
268
        }
269

270
        VIR_DEBUG("Renaming %s to %s", veths[i], newname);
271
        rc = setInterfaceName(veths[i], newname);
272
        if (rc < 0)
273 274
            goto error_out;

275
        VIR_DEBUG("Enabling %s", newname);
276
        rc = vethInterfaceUpOrDown(newname, 1);
277
        if (rc < 0)
278
            goto error_out;
279

280
        VIR_FREE(newname);
281 282 283
    }

    /* enable lo device only if there were other net devices */
284
    if (veths)
285 286 287
        rc = vethInterfaceUpOrDown("lo", 1);

error_out:
288
    VIR_FREE(newname);
289 290 291
    return rc;
}

292

293
/*_syscall2(int, pivot_root, char *, newroot, const char *, oldroot)*/
294 295 296 297 298 299 300
extern int pivot_root(const char * new_root,const char * put_old);

static int lxcContainerChildMountSort(const void *a, const void *b)
{
  const char **sa = (const char**)a;
  const char **sb = (const char**)b;

E
Eric Blake 已提交
301
  /* Deliberately reversed args - we need to unmount deepest
302 303 304 305
     children first */
  return strcmp(*sb, *sa);
}

306
#ifndef MS_REC
307
# define MS_REC          16384
308 309 310
#endif

#ifndef MNT_DETACH
311
# define MNT_DETACH      0x00000002
312 313 314
#endif

#ifndef MS_PRIVATE
315
# define MS_PRIVATE              (1<<18)
316 317 318
#endif

#ifndef MS_SLAVE
319
# define MS_SLAVE                (1<<19)
320 321
#endif

322 323
static int lxcContainerPivotRoot(virDomainFSDefPtr root)
{
324
    int ret;
325
    char *oldroot = NULL, *newroot = NULL;
326

M
Mark McLoughlin 已提交
327 328
    ret = -1;

329 330
    /* root->parent must be private, so make / private. */
    if (mount("", "/", NULL, MS_PRIVATE|MS_REC, NULL) < 0) {
331
        virReportSystemError(errno, "%s",
332
                             _("Failed to make root private"));
333
        goto err;
334 335
    }

336
    if (virAsprintf(&oldroot, "%s/.oldroot", root->src) < 0) {
337
        virReportOOMError();
338
        goto err;
339 340
    }

341 342
    if (virFileMakePath(oldroot) < 0) {
        virReportSystemError(errno,
343
                             _("Failed to create %s"),
344
                             oldroot);
345 346 347 348 349
        goto err;
    }

    /* Create a tmpfs root since old and new roots must be
     * on separate filesystems */
350
    if (mount("tmprootfs", oldroot, "tmpfs", 0, NULL) < 0) {
351
        virReportSystemError(errno,
352
                             _("Failed to mount empty tmpfs at %s"),
353 354 355
                             oldroot);
        goto err;
    }
M
Mark McLoughlin 已提交
356

357 358
    /* Create a directory called 'new' in tmpfs */
    if (virAsprintf(&newroot, "%s/new", oldroot) < 0) {
359
        virReportOOMError();
360 361 362
        goto err;
    }

363 364
    if (virFileMakePath(newroot) < 0) {
        virReportSystemError(errno,
365
                             _("Failed to create %s"),
366 367 368 369 370 371
                             newroot);
        goto err;
    }

    /* ... and mount our root onto it */
    if (mount(root->src, newroot, NULL, MS_BIND|MS_REC, NULL) < 0) {
372
        virReportSystemError(errno,
373
                             _("Failed to bind new root %s into tmpfs"),
374 375 376 377
                             root->src);
        goto err;
    }

378 379 380 381 382 383 384 385 386
    if (root->readonly) {
        if (mount(root->src, newroot, NULL, MS_BIND|MS_REC|MS_RDONLY|MS_REMOUNT, NULL) < 0) {
            virReportSystemError(errno,
                                 _("Failed to make new root %s readonly"),
                                 root->src);
            goto err;
        }
    }

387 388
    /* Now we chroot into the tmpfs, then pivot into the
     * root->src bind-mounted onto '/new' */
389
    if (chdir(newroot) < 0) {
390
        virReportSystemError(errno,
391
                             _("Failed to chroot into %s"), newroot);
392
        goto err;
393 394 395 396
    }

    /* The old root directory will live at /.oldroot after
     * this and will soon be unmounted completely */
397
    if (pivot_root(".", ".oldroot") < 0) {
398
        virReportSystemError(errno, "%s",
399
                             _("Failed to pivot root"));
400
        goto err;
401 402 403
    }

    /* CWD is undefined after pivot_root, so go to / */
404 405 406
    if (chdir("/") < 0)
        goto err;

M
Mark McLoughlin 已提交
407 408 409
    ret = 0;

err:
410 411 412
    VIR_FREE(oldroot);
    VIR_FREE(newroot);

M
Mark McLoughlin 已提交
413
    return ret;
414 415
}

416

417
static int lxcContainerMountBasicFS(const char *srcprefix, bool pivotRoot)
418 419
{
    const struct {
420
        bool onlyPivotRoot;
421
        bool needPrefix;
422 423 424
        const char *src;
        const char *dst;
        const char *type;
425 426
        const char *opts;
        int mflags;
427
    } mnts[] = {
428 429 430
        /* When we want to make a bind mount readonly, for unknown reasons,
         * it is currently neccessary to bind it once, and then remount the
         * bind with the readonly flag. If this is not done, then the original
431
         * mount point in the main OS becomes readonly too which is not what
432 433
         * we want. Hence some things have two entries here.
         */
434 435 436 437 438 439 440 441
        { true, false, "devfs", "/dev", "tmpfs", "mode=755", MS_NOSUID },
        { false, false, "proc", "/proc", "proc", NULL, MS_NOSUID|MS_NOEXEC|MS_NODEV },
        { false, false, "/proc/sys", "/proc/sys", NULL, NULL, MS_BIND },
        { false, false, "/proc/sys", "/proc/sys", NULL, NULL, MS_BIND|MS_REMOUNT|MS_RDONLY },
        { false, true, "/sys", "/sys", NULL, NULL, MS_BIND },
        { false, true, "/sys", "/sys", NULL, NULL, MS_BIND|MS_REMOUNT|MS_RDONLY },
        { false, true, "/selinux", "/selinux", NULL, NULL, MS_BIND },
        { false, true, "/selinux", "/selinux", NULL, NULL, MS_BIND|MS_REMOUNT|MS_RDONLY },
442
    };
443
    int i, rc = -1;
444

445 446
    VIR_DEBUG("Mounting basic filesystems %s pivotRoot=%d", NULLSTR(srcprefix), pivotRoot);

447
    for (i = 0 ; i < ARRAY_CARDINALITY(mnts) ; i++) {
448 449
        char *src = NULL;
        const char *srcpath = NULL;
450 451 452 453 454 455

        VIR_DEBUG("Consider %s onlyPivotRoot=%d",
                  mnts[i].src, mnts[i].onlyPivotRoot);
        if (mnts[i].onlyPivotRoot && !pivotRoot)
            continue;

456
        if (virFileMakePath(mnts[i].dst) < 0) {
457
            virReportSystemError(errno,
458
                                 _("Failed to mkdir %s"),
459
                                 mnts[i].src);
460
            goto cleanup;
461
        }
462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477

        if (mnts[i].needPrefix && srcprefix) {
            if (virAsprintf(&src, "%s%s", srcprefix, mnts[i].src) < 0) {
                virReportOOMError();
                goto cleanup;
            }
            srcpath = src;
        } else {
            srcpath = mnts[i].src;
        }

        /* Skip if mount doesn't exist in source */
        if ((srcpath[0] == '/') &&
            (access(srcpath, R_OK) < 0))
            continue;

478 479
        VIR_DEBUG("Mount %s on %s type=%s flags=%x, opts=%s",
                  srcpath, mnts[i].dst, mnts[i].type, mnts[i].mflags, mnts[i].opts);
480 481
        if (mount(srcpath, mnts[i].dst, mnts[i].type, mnts[i].mflags, mnts[i].opts) < 0) {
            VIR_FREE(src);
482
            virReportSystemError(errno,
483 484
                                 _("Failed to mount %s on %s type %s"),
                                 mnts[i].src, mnts[i].dst, NULLSTR(mnts[i].type));
485
            goto cleanup;
486
        }
487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505
        VIR_FREE(src);
    }

    rc = 0;

cleanup:
    VIR_DEBUG("rc=%d", rc);
    return rc;
}


static int lxcContainerMountDevFS(virDomainFSDefPtr root)
{
    char *devpts = NULL;
    int rc = -1;

    if (virAsprintf(&devpts, "/.oldroot%s/dev/pts", root->src) < 0) {
        virReportOOMError();
        goto cleanup;
506
    }
507

508 509
    if (virFileMakePath("/dev/pts") < 0) {
        virReportSystemError(errno, "%s",
510
                             _("Cannot create /dev/pts"));
511
        goto cleanup;
512
    }
513 514 515

    VIR_DEBUG("Trying to move %s to %s", devpts, "/dev/pts");
    if ((rc = mount(devpts, "/dev/pts", NULL, MS_MOVE, NULL)) < 0) {
516
        virReportSystemError(errno, "%s",
517
                             _("Failed to mount /dev/pts in container"));
518
        goto cleanup;
519
    }
520 521 522 523

    rc = 0;

 cleanup:
524 525
    VIR_FREE(devpts);

526
    return rc;
527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543
}

static int lxcContainerPopulateDevices(void)
{
    int i;
    const struct {
        int maj;
        int min;
        mode_t mode;
        const char *path;
    } devs[] = {
        { LXC_DEV_MAJ_MEMORY, LXC_DEV_MIN_NULL, 0666, "/dev/null" },
        { LXC_DEV_MAJ_MEMORY, LXC_DEV_MIN_ZERO, 0666, "/dev/zero" },
        { LXC_DEV_MAJ_MEMORY, LXC_DEV_MIN_FULL, 0666, "/dev/full" },
        { LXC_DEV_MAJ_MEMORY, LXC_DEV_MIN_RANDOM, 0666, "/dev/random" },
        { LXC_DEV_MAJ_MEMORY, LXC_DEV_MIN_URANDOM, 0666, "/dev/urandom" },
    };
544 545 546 547

    /* Populate /dev/ with a few important bits */
    for (i = 0 ; i < ARRAY_CARDINALITY(devs) ; i++) {
        dev_t dev = makedev(devs[i].maj, devs[i].min);
548
        if (mknod(devs[i].path, S_IFCHR, dev) < 0 ||
549
            chmod(devs[i].path, devs[i].mode)) {
550
            virReportSystemError(errno,
551
                                 _("Failed to make device %s"),
552
                                 devs[i].path);
553 554 555 556
            return -1;
        }
    }

S
Serge Hallyn 已提交
557 558 559 560 561 562 563 564
    dev_t dev = makedev(LXC_DEV_MAJ_TTY, LXC_DEV_MIN_PTMX);
    if (mknod("/dev/ptmx", S_IFCHR, dev) < 0 ||
        chmod("/dev/ptmx", 0666)) {
        virReportSystemError(errno, "%s",
                             _("Failed to make device /dev/ptmx"));
        return -1;
    }

565
    if (access("/dev/pts/ptmx", W_OK) == 0) {
S
Serge Hallyn 已提交
566
        if (mount("/dev/pts/ptmx", "/dev/ptmx", "ptmx", MS_BIND, NULL) < 0) {
567
            virReportSystemError(errno, "%s",
S
Serge Hallyn 已提交
568
                                 _("Failed to bind-mount /dev/ptmx to /dev/pts/ptmx"));
569 570 571 572
            return -1;
        }
    }

573 574 575 576 577 578 579 580 581
    /* XXX we should allow multiple consoles per container
     * for tty2, tty3, etc, but the domain XML does not
     * handle this yet
     */
    if (symlink("/dev/pts/0", "/dev/tty1") < 0) {
        virReportSystemError(errno, "%s",
                             _("Failed to symlink /dev/pts/0 to /dev/tty1"));
        return -1;
    }
582 583 584 585 586
    if (symlink("/dev/pts/0", "/dev/console") < 0) {
        virReportSystemError(errno, "%s",
                             _("Failed to symlink /dev/pts/0 to /dev/console"));
        return -1;
    }
587

588 589 590 591
    return 0;
}


592 593
static int lxcContainerMountFSBind(virDomainFSDefPtr fs,
                                   const char *srcprefix)
594
{
595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616
    char *src = NULL;
    int ret = -1;

    if (virAsprintf(&src, "%s%s", srcprefix, fs->src) < 0) {
        virReportOOMError();
        goto cleanup;
    }

    if (virFileMakePath(fs->dst) < 0) {
        virReportSystemError(errno,
                             _("Failed to create %s"),
                             fs->dst);
        goto cleanup;
    }

    if (mount(src, fs->dst, NULL, MS_BIND, NULL) < 0) {
        virReportSystemError(errno,
                             _("Failed to bind mount directory %s to %s"),
                             src, fs->dst);
        goto cleanup;
    }

617 618 619 620 621 622
    if (fs->readonly) {
        VIR_DEBUG("Binding %s readonly", fs->dst);
        if (mount(fs->dst, fs->dst, NULL, MS_BIND|MS_REMOUNT|MS_RDONLY, NULL) < 0) {
            virReportSystemError(errno,
                                 _("Failed to make directory %s readonly"),
                                 fs->dst);
623 624 625 626 627 628 629 630 631 632 633
        }
    }

    ret = 0;

cleanup:
    VIR_FREE(src);
    return ret;
}


634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714
#ifdef HAVE_LIBBLKID
static int
lxcContainerMountDetectFilesystem(const char *src, char **type)
{
    int fd;
    int ret = -1;
    int rc;
    const char *data = NULL;
    blkid_probe blkid = NULL;

    *type = NULL;

    if ((fd = open(src, O_RDONLY)) < 0) {
        virReportSystemError(errno,
                             _("Unable to open filesystem %s"), src);
        return -1;
    }

    if (!(blkid = blkid_new_probe())) {
        virReportSystemError(errno, "%s",
                             _("Unable to create blkid library handle"));
        goto cleanup;
    }
    if (blkid_probe_set_device(blkid, fd, 0, 0) < 0) {
        virReportSystemError(EINVAL,
                             _("Unable to associate device %s with blkid library"),
                             src);
        goto cleanup;
    }

    blkid_probe_enable_superblocks(blkid, 1);

    blkid_probe_set_superblocks_flags(blkid, BLKID_SUBLKS_TYPE);

    rc = blkid_do_safeprobe(blkid);
    if (rc != 0) {
        if (rc == 1) /* Nothing found, return success with *type == NULL */
            goto done;

        if (rc == -2) {
            virReportSystemError(EINVAL,
                                 _("Too many filesystems detected for %s"),
                                 src);
        } else {
            virReportSystemError(errno,
                                 _("Unable to detect filesystem for %s"),
                                 src);
        }
        goto cleanup;
    }

    if (blkid_probe_lookup_value(blkid, "TYPE", &data, NULL) < 0) {
        virReportSystemError(ENOENT,
                             _("Unable to find filesystem type for %s"),
                             src);
        goto cleanup;
    }

    if (!(*type = strdup(data))) {
        virReportOOMError();
        goto cleanup;
    }

done:
    ret = 0;
cleanup:
    VIR_FORCE_CLOSE(fd);
    if (blkid)
        blkid_free_probe(blkid);
    return ret;
}
#else /* ! HAVE_LIBBLKID */
static int
lxcContainerMountDetectFilesystem(const char *src ATTRIBUTE_UNUSED,
                                  char **type)
{
    /* No libblkid, so just return success with no detected type */
    *type = NULL;
    return 0;
}
#endif /* ! HAVE_LIBBLKID */
715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771

/*
 * This functions attempts to do automatic detection of filesystem
 * type following the same rules as the util-linux 'mount' binary.
 *
 * The main difference is that we don't (currently) try to use
 * libblkid to detect the format first. We go straight to using
 * /etc/filesystems, and then /proc/filesystems
 */
static int lxcContainerMountFSBlockAuto(virDomainFSDefPtr fs,
                                        int fsflags,
                                        const char *src,
                                        const char *srcprefix)
{
    FILE *fp = NULL;
    int ret = -1;
    bool tryProc = false;
    bool gotStar = false;
    char *fslist = NULL;
    char *line = NULL;
    const char *type;

    VIR_DEBUG("src=%s srcprefix=%s dst=%s", src, srcprefix, fs->dst);

    /* First time around we use /etc/filesystems */
retry:
    if (virAsprintf(&fslist, "%s%s",
                    srcprefix, tryProc ? "/proc/filesystems" : "/etc/filesystems") < 0) {
        virReportOOMError();
        goto cleanup;
    }

    VIR_DEBUG("Open fslist %s", fslist);
    if (!(fp = fopen(fslist, "r"))) {
        /* If /etc/filesystems does not exist, then we need to retry
         * with /proc/filesystems next
         */
        if (errno == ENOENT &&
            !tryProc) {
            tryProc = true;
            VIR_FREE(fslist);
            goto retry;
        }

        virReportSystemError(errno,
                             _("Unable to read %s"),
                             fslist);
        goto cleanup;
    }

    while (!feof(fp)) {
        size_t n;
        VIR_FREE(line);
        if (getline(&line, &n, fp) <= 0) {
            if (feof(fp))
                break;

772 773 774
            goto cleanup;
        }

775 776 777 778 779 780 781 782 783 784 785 786 787
        if (strstr(line, "nodev"))
            continue;

        type = strchr(line, '\n');
        if (type)
            line[type-line] = '\0';

        type = line;
        virSkipSpaces(&type);

        /*
         * /etc/filesystems is only allowed to contain '*' on the last line
         */
788
        if (gotStar && !tryProc) {
789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812
            lxcError(VIR_ERR_INTERNAL_ERROR,
                     _("%s has unexpected '*' before last line"),
                     fslist);
            goto cleanup;
        }

        /* An '*' on the last line in /etc/filesystems
         * means try /proc/filesystems next. We don't
         * jump immediately though, since we need to see
         * if any more lines follow
         */
        if (!tryProc &&
            STREQ(type, "*"))
            gotStar = true;

        VIR_DEBUG("Trying mount %s with %s", src, type);
        if (mount(src, fs->dst, type, fsflags, NULL) < 0) {
            /* These errnos indicate a bogus filesystem type for
             * the image we have, so skip to the next type
             */
            if (errno == EINVAL || errno == ENODEV)
                continue;

            virReportSystemError(errno,
813
                                 _("Failed to mount device %s to %s"),
814 815 816 817 818 819
                                 src, fs->dst);
            goto cleanup;
        }

        ret = 0;
        break;
820 821
    }

822 823 824 825 826 827 828 829 830 831 832 833
    /* We've got to the end of /etc/filesystems and saw
     * a '*', so we must try /proc/filesystems next
     */
    if (ret != 0 &&
        !tryProc &&
        gotStar) {
        tryProc = true;
        VIR_FREE(fslist);
        VIR_FORCE_FCLOSE(fp);
        goto retry;
    }

834 835 836 837 838 839
    if (ret != 0) {
        virReportSystemError(ENODEV,
                             _("Failed to mount device %s to %s, unable to detect filesystem"),
                             src, fs->dst);
    }

840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858
    VIR_DEBUG("Done mounting filesystem ret=%d tryProc=%d", ret, tryProc);

cleanup:
    VIR_FREE(line);
    VIR_FORCE_FCLOSE(fp);
    return ret;
}


/*
 * Mount a block device 'src' on fs->dst, automatically
 * probing for filesystem type
 */
static int lxcContainerMountFSBlockHelper(virDomainFSDefPtr fs,
                                          const char *src,
                                          const char *srcprefix)
{
    int fsflags = 0;
    int ret = -1;
859 860
    char *format = NULL;

861 862 863 864 865 866 867 868 869 870
    if (fs->readonly)
        fsflags |= MS_RDONLY;

    if (virFileMakePath(fs->dst) < 0) {
        virReportSystemError(errno,
                             _("Failed to create %s"),
                             fs->dst);
        goto cleanup;
    }

871 872 873 874 875 876 877 878 879 880 881 882 883 884 885
    if (lxcContainerMountDetectFilesystem(src, &format) < 0)
        goto cleanup;

    if (format) {
        VIR_DEBUG("Mount %s with detected format %s", src, format);
        if (mount(src, fs->dst, format, fsflags, NULL) < 0) {
            virReportSystemError(errno,
                                 _("Failed to mount device %s to %s as %s"),
                                 src, fs->dst, format);
            goto cleanup;
        }
        ret = 0;
    } else {
        ret = lxcContainerMountFSBlockAuto(fs, fsflags, src, srcprefix);
    }
886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903

cleanup:
    return ret;
}


static int lxcContainerMountFSBlock(virDomainFSDefPtr fs,
                                    const char *srcprefix)
{
    char *src = NULL;
    int ret = -1;

    if (virAsprintf(&src, "%s%s", srcprefix, fs->src) < 0) {
        virReportOOMError();
        goto cleanup;
    }

    ret = lxcContainerMountFSBlockHelper(fs, src, srcprefix);
904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920

    VIR_DEBUG("Done mounting filesystem ret=%d", ret);

cleanup:
    VIR_FREE(src);
    return ret;
}


static int lxcContainerMountFS(virDomainFSDefPtr fs,
                               const char *srcprefix)
{
    switch (fs->type) {
    case VIR_DOMAIN_FS_TYPE_MOUNT:
        if (lxcContainerMountFSBind(fs, srcprefix) < 0)
            return -1;
        break;
921 922 923 924
    case VIR_DOMAIN_FS_TYPE_BLOCK:
        if (lxcContainerMountFSBlock(fs, srcprefix) < 0)
            return -1;
        break;
925 926 927 928 929
    case VIR_DOMAIN_FS_TYPE_FILE:
        lxcError(VIR_ERR_INTERNAL_ERROR,
                 _("Unexpected filesystem type %s"),
                 virDomainFSTypeToString(fs->type));
        break;
930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945
    default:
        lxcError(VIR_ERR_CONFIG_UNSUPPORTED,
                 _("Cannot mount filesystem type %s"),
                 virDomainFSTypeToString(fs->type));
        break;
    }
    return 0;
}


static int lxcContainerMountAllFS(virDomainDefPtr vmDef,
                                  const char *dstprefix,
                                  bool skipRoot)
{
    size_t i;
    VIR_DEBUG("Mounting %s %d", dstprefix, skipRoot);
946 947

    /* Pull in rest of container's mounts */
948
    for (i = 0 ; i < vmDef->nfss ; i++) {
949 950
        if (skipRoot &&
            STREQ(vmDef->fss[i]->dst, "/"))
951 952
            continue;

953
        if (lxcContainerMountFS(vmDef->fss[i], dstprefix) < 0)
954 955 956
            return -1;
    }

957
    VIR_DEBUG("Mounted all filesystems");
958 959 960 961 962 963
    return 0;
}


static int lxcContainerUnmountOldFS(void)
{
964
    struct mntent mntent;
965 966 967 968
    char **mounts = NULL;
    int nmounts = 0;
    FILE *procmnt;
    int i;
969
    char mntbuf[1024];
970 971 972
    int saveErrno;
    const char *failedUmount = NULL;
    int ret = -1;
973 974

    if (!(procmnt = setmntent("/proc/mounts", "r"))) {
975
        virReportSystemError(errno, "%s",
976
                             _("Failed to read /proc/mounts"));
977 978
        return -1;
    }
979
    while (getmntent_r(procmnt, &mntent, mntbuf, sizeof(mntbuf)) != NULL) {
980
        VIR_DEBUG("Got %s", mntent.mnt_dir);
981
        if (!STRPREFIX(mntent.mnt_dir, "/.oldroot"))
982 983 984
            continue;

        if (VIR_REALLOC_N(mounts, nmounts+1) < 0) {
985
            virReportOOMError();
986
            goto cleanup;
987
        }
988
        if (!(mounts[nmounts++] = strdup(mntent.mnt_dir))) {
989
            virReportOOMError();
990
            goto cleanup;
991
        }
992
        VIR_DEBUG("Grabbed %s", mntent.mnt_dir);
993 994
    }

995 996 997
    if (mounts)
        qsort(mounts, nmounts, sizeof(mounts[0]),
              lxcContainerChildMountSort);
998 999

    for (i = 0 ; i < nmounts ; i++) {
1000
        VIR_DEBUG("Umount %s", mounts[i]);
1001
        if (umount(mounts[i]) < 0) {
1002 1003 1004 1005 1006 1007 1008
            char ebuf[1024];
            failedUmount = mounts[i];
            saveErrno = errno;
            VIR_WARN("Failed to unmount '%s', trying to detach root '%s': %s",
                     failedUmount, mounts[nmounts-1],
                     virStrerror(errno, ebuf, sizeof(ebuf)));
            break;
1009 1010
        }
    }
1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034

    if (failedUmount) {
        /* This detaches the old root filesystem */
        if (umount2(mounts[nmounts-1], MNT_DETACH) < 0) {
            virReportSystemError(saveErrno,
                                 _("Failed to unmount '%s' and could not detach old root '%s'"),
                                 failedUmount, mounts[nmounts-1]);
            goto cleanup;
        }
        /* This unmounts the tmpfs on which the old root filesystem was hosted */
        if (umount(mounts[nmounts-1]) < 0) {
            virReportSystemError(saveErrno,
                                 _("Failed to unmount '%s' and could not unmount old root '%s'"),
                                 failedUmount, mounts[nmounts-1]);
            goto cleanup;
        }
    }

    ret = 0;

cleanup:
    for (i = 0 ; i < nmounts ; i++)
        VIR_FREE(mounts[i]);
    endmntent(procmnt);
1035 1036
    VIR_FREE(mounts);

1037
    return ret;
1038 1039 1040 1041 1042 1043 1044 1045 1046 1047
}


/* Got a FS mapped to /, we're going the pivot_root
 * approach to do a better-chroot-than-chroot
 * this is based on this thread http://lkml.org/lkml/2008/3/5/29
 */
static int lxcContainerSetupPivotRoot(virDomainDefPtr vmDef,
                                      virDomainFSDefPtr root)
{
1048
    /* Gives us a private root, leaving all parent OS mounts on /.oldroot */
1049 1050 1051
    if (lxcContainerPivotRoot(root) < 0)
        return -1;

1052
    /* Mounts the core /proc, /sys, etc filesystems */
1053
    if (lxcContainerMountBasicFS("/.oldroot", true) < 0)
1054 1055 1056 1057
        return -1;

    /* Mounts /dev and /dev/pts */
    if (lxcContainerMountDevFS(root) < 0)
1058 1059
        return -1;

1060
    /* Populates device nodes in /dev/ */
1061 1062 1063
    if (lxcContainerPopulateDevices() < 0)
        return -1;

1064
    /* Sets up any non-root mounts from guest config */
1065
    if (lxcContainerMountAllFS(vmDef, "/.oldroot", true) < 0)
1066 1067
        return -1;

1068
    /* Gets rid of all remaining mounts from host OS, including /.oldroot itself */
1069 1070 1071 1072 1073 1074
    if (lxcContainerUnmountOldFS() < 0)
        return -1;

    return 0;
}

1075

1076 1077 1078 1079
/* Nothing mapped to /, we're using the main root,
   but with extra stuff mapped in */
static int lxcContainerSetupExtraMounts(virDomainDefPtr vmDef)
{
1080 1081 1082 1083 1084 1085
    VIR_DEBUG("def=%p", vmDef);
    /*
     * This makes sure that any new filesystems in the
     * host OS propagate to the container, but any
     * changes in the container are private
     */
1086
    if (mount("", "/", NULL, MS_SLAVE|MS_REC, NULL) < 0) {
1087
        virReportSystemError(errno, "%s",
1088
                             _("Failed to make / slave"));
1089 1090
        return -1;
    }
1091

1092
    VIR_DEBUG("Mounting config FS");
1093 1094
    if (lxcContainerMountAllFS(vmDef, "", false) < 0)
        return -1;
1095

1096
    /* Mounts the core /proc, /sys, etc filesystems */
1097
    if (lxcContainerMountBasicFS(NULL, false) < 0)
1098 1099
        return -1;

1100
    VIR_DEBUG("Mounting completed");
1101 1102 1103
    return 0;
}

1104 1105
static int lxcContainerSetupMounts(virDomainDefPtr vmDef,
                                   virDomainFSDefPtr root)
1106 1107 1108 1109 1110 1111 1112
{
    if (root)
        return lxcContainerSetupPivotRoot(vmDef, root);
    else
        return lxcContainerSetupExtraMounts(vmDef);
}

D
Daniel P. Berrange 已提交
1113 1114 1115 1116 1117 1118 1119

/*
 * This is running as the 'init' process insid the container.
 * It removes some capabilities that could be dangerous to
 * host system, since they are not currently "containerized"
 */
static int lxcContainerDropCapabilities(void)
1120
{
D
Daniel P. Berrange 已提交
1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134
#if HAVE_CAPNG
    int ret;

    capng_get_caps_process();

    if ((ret = capng_updatev(CAPNG_DROP,
                             CAPNG_EFFECTIVE | CAPNG_PERMITTED |
                             CAPNG_INHERITABLE | CAPNG_BOUNDING_SET,
                             CAP_SYS_BOOT, /* No use of reboot */
                             CAP_SYS_MODULE, /* No kernel module loading */
                             CAP_SYS_TIME, /* No changing the clock */
                             CAP_AUDIT_CONTROL, /* No messing with auditing status */
                             CAP_MAC_ADMIN, /* No messing with LSM config */
                             -1 /* sentinal */)) < 0) {
1135
        lxcError(VIR_ERR_INTERNAL_ERROR,
1136
                 _("Failed to remove capabilities: %d"), ret);
D
Daniel P. Berrange 已提交
1137 1138
        return -1;
    }
1139

D
Daniel P. Berrange 已提交
1140
    if ((ret = capng_apply(CAPNG_SELECT_BOTH)) < 0) {
1141
        lxcError(VIR_ERR_INTERNAL_ERROR,
1142
                 _("Failed to apply capabilities: %d"), ret);
D
Daniel P. Berrange 已提交
1143
        return -1;
1144
    }
D
Daniel P. Berrange 已提交
1145

1146 1147 1148 1149 1150
    /* We do not need to call capng_lock() in this case. The bounding
     * set restriction will prevent them reacquiring sys_boot/module/time,
     * etc which is all that matters for the container. Once inside the
     * container it is fine for SECURE_NOROOT / SECURE_NO_SETUID_FIXUP to
     * be unmasked  - they can never escape the bounding set. */
D
Daniel P. Berrange 已提交
1151 1152

#else
1153
    VIR_WARN("libcap-ng support not compiled in, unable to clear capabilities");
D
Daniel Veillard 已提交
1154
#endif
1155 1156 1157 1158
    return 0;
}


1159
/**
1160 1161
 * lxcContainerChild:
 * @data: pointer to container arguments
1162 1163 1164 1165 1166 1167 1168 1169 1170
 *
 * This function is run in the process clone()'d in lxcStartContainer.
 * Perform a number of container setup tasks:
 *     Setup container file system
 *     mount container /proca
 * Then exec's the container init
 *
 * Returns 0 on success or -1 in case of error
 */
1171
static int lxcContainerChild( void *data )
1172
{
1173
    lxc_child_argv_t *argv = data;
1174
    virDomainDefPtr vmDef = argv->config;
1175
    int ttyfd = -1;
1176
    int ret = -1;
1177
    char *ttyPath = NULL;
1178
    virDomainFSDefPtr root;
1179
    virCommandPtr cmd = NULL;
1180 1181

    if (NULL == vmDef) {
1182
        lxcError(VIR_ERR_INTERNAL_ERROR,
J
Jim Meyering 已提交
1183
                 "%s", _("lxcChild() passed invalid vm definition"));
1184
        goto cleanup;
1185 1186
    }

1187 1188 1189
    cmd = lxcContainerBuildInitCmd(vmDef);
    virCommandWriteArgLog(cmd, 1);

1190
    root = virDomainGetRootFilesystem(vmDef);
1191

1192 1193
    if (root) {
        if (virAsprintf(&ttyPath, "%s%s", root->src, argv->ttyPath) < 0) {
1194
            virReportOOMError();
1195
            goto cleanup;
1196 1197 1198
        }
    } else {
        if (!(ttyPath = strdup(argv->ttyPath))) {
1199
            virReportOOMError();
1200
            goto cleanup;
1201 1202
        }
    }
1203
    VIR_DEBUG("Container TTY path: %s", ttyPath);
1204 1205

    ttyfd = open(ttyPath, O_RDWR|O_NOCTTY);
1206
    if (ttyfd < 0) {
1207
        virReportSystemError(errno,
1208
                             _("Failed to open tty %s"),
1209
                             ttyPath);
1210
        goto cleanup;
1211
    }
1212

1213
    if (lxcContainerSetupMounts(vmDef, root) < 0)
1214
        goto cleanup;
1215

1216 1217 1218 1219 1220 1221 1222
    if (!virFileExists(vmDef->os.init)) {
        virReportSystemError(errno,
                    _("cannot find init path '%s' relative to container root"),
                    vmDef->os.init);
        goto cleanup;
    }

1223
    /* Wait for interface devices to show up */
1224 1225 1226
    if (lxcContainerWaitForContinue(argv->monitor) < 0) {
        virReportSystemError(errno, "%s",
                             _("Failed to read the container continue message"));
1227
        goto cleanup;
1228 1229
    }
    VIR_DEBUG("Received container continue message");
1230

1231 1232
    /* rename and enable interfaces */
    if (lxcContainerRenameAndEnableInterfaces(argv->nveths,
1233
                                              argv->veths) < 0) {
1234
        goto cleanup;
1235
    }
1236

1237
    /* drop a set of root capabilities */
D
Daniel P. Berrange 已提交
1238
    if (lxcContainerDropCapabilities() < 0)
1239
        goto cleanup;
1240

1241 1242 1243 1244 1245 1246 1247
    if (lxcContainerSendContinue(argv->handshakefd) < 0) {
        virReportSystemError(errno, "%s",
                            _("failed to send continue signal to controller"));
        goto cleanup;
    }

    if (lxcContainerSetStdio(argv->monitor, ttyfd, argv->handshakefd) < 0) {
1248 1249
        goto cleanup;
    }
1250

1251
    ret = 0;
1252
cleanup:
1253 1254
    VIR_FREE(ttyPath);
    VIR_FORCE_CLOSE(ttyfd);
1255
    VIR_FORCE_CLOSE(argv->monitor);
1256
    VIR_FORCE_CLOSE(argv->handshakefd);
1257 1258

    if (ret == 0) {
E
Eric Blake 已提交
1259
        /* this function will only return if an error occurred */
1260 1261 1262
        ret = virCommandExec(cmd);
    }

1263 1264
    virCommandFree(cmd);
    return ret;
1265
}
1266

1267 1268
static int userns_supported(void)
{
1269 1270 1271 1272 1273 1274
#if 1
    /*
     * put off using userns until uid mapping is implemented
     */
    return 0;
#else
1275
    return lxcContainerAvailable(LXC_CONTAINER_FEATURE_USER) == 0;
1276
#endif
1277 1278
}

1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299
const char *lxcContainerGetAlt32bitArch(const char *arch)
{
    /* Any Linux 64bit arch which has a 32bit
     * personality available should be listed here */
    if (STREQ(arch, "x86_64"))
        return "i686";
    if (STREQ(arch, "s390x"))
        return "s390";
    if (STREQ(arch, "ppc64"))
        return "ppc";
    if (STREQ(arch, "parisc64"))
        return "parisc";
    if (STREQ(arch, "sparc64"))
        return "sparc";
    if (STREQ(arch, "mips64"))
        return "mips";

    return NULL;
}


1300 1301
/**
 * lxcContainerStart:
1302 1303 1304 1305 1306
 * @def: pointer to virtual machine structure
 * @nveths: number of interfaces
 * @veths: interface names
 * @control: control FD to the container
 * @ttyPath: path of tty to set as the container console
1307 1308 1309 1310 1311
 *
 * Starts a container process by calling clone() with the namespace flags
 *
 * Returns PID of container on success or -1 in case of error
 */
1312
int lxcContainerStart(virDomainDefPtr def,
1313 1314
                      unsigned int nveths,
                      char **veths,
1315
                      int control,
1316
                      int handshakefd,
1317 1318 1319
                      char *ttyPath)
{
    pid_t pid;
E
Eric Blake 已提交
1320
    int cflags;
1321 1322
    int stacksize = getpagesize() * 4;
    char *stack, *stacktop;
1323 1324
    lxc_child_argv_t args = { def, nveths, veths, control, ttyPath,
                              handshakefd};
1325 1326 1327

    /* allocate a stack for the container */
    if (VIR_ALLOC_N(stack, stacksize) < 0) {
1328
        virReportOOMError();
1329 1330 1331 1332
        return -1;
    }
    stacktop = stack + stacksize;

E
Eric Blake 已提交
1333
    cflags = CLONE_NEWPID|CLONE_NEWNS|CLONE_NEWUTS|CLONE_NEWIPC|SIGCHLD;
1334

1335
    if (userns_supported()) {
1336
        VIR_DEBUG("Enable user namespaces");
E
Eric Blake 已提交
1337
        cflags |= CLONE_NEWUSER;
1338
    }
1339

1340
    if (def->nets != NULL) {
1341
        VIR_DEBUG("Enable network namespaces");
E
Eric Blake 已提交
1342
        cflags |= CLONE_NEWNET;
1343
    }
1344

E
Eric Blake 已提交
1345
    pid = clone(lxcContainerChild, stacktop, cflags, &args);
1346
    VIR_FREE(stack);
1347
    VIR_DEBUG("clone() completed, new container PID is %d", pid);
1348 1349

    if (pid < 0) {
1350
        virReportSystemError(errno, "%s",
1351
                             _("Failed to run clone container"));
1352 1353 1354 1355 1356 1357
        return -1;
    }

    return pid;
}

1358 1359
ATTRIBUTE_NORETURN static int
lxcContainerDummyChild(void *argv ATTRIBUTE_UNUSED)
1360 1361 1362 1363 1364 1365
{
    _exit(0);
}

int lxcContainerAvailable(int features)
{
1366
    int flags = CLONE_NEWPID|CLONE_NEWNS|CLONE_NEWUTS|
1367 1368 1369 1370 1371
        CLONE_NEWIPC|SIGCHLD;
    int cpid;
    char *childStack;
    char *stack;

1372 1373 1374
    if (features & LXC_CONTAINER_FEATURE_USER)
        flags |= CLONE_NEWUSER;

1375 1376 1377 1378
    if (features & LXC_CONTAINER_FEATURE_NET)
        flags |= CLONE_NEWNET;

    if (VIR_ALLOC_N(stack, getpagesize() * 4) < 0) {
1379
        VIR_DEBUG("Unable to allocate stack");
1380 1381 1382 1383 1384 1385 1386 1387
        return -1;
    }

    childStack = stack + (getpagesize() * 4);

    cpid = clone(lxcContainerDummyChild, childStack, flags, NULL);
    VIR_FREE(stack);
    if (cpid < 0) {
1388
        char ebuf[1024] ATTRIBUTE_UNUSED;
1389
        VIR_DEBUG("clone call returned %s, container support is not enabled",
1390
              virStrerror(errno, ebuf, sizeof ebuf));
1391
        return -1;
E
Eric Blake 已提交
1392 1393
    } else if (virPidWait(cpid, NULL) < 0) {
        return -1;
1394 1395
    }

1396
    VIR_DEBUG("Mounted all filesystems");
1397
    return 0;
1398
}