virsh-optparse 9.9 KB
Newer Older
1 2 3
#!/bin/sh
# Ensure that virsh option parsing doesn't regress

4
# Copyright (C) 2011-2012, 2014 Red Hat, Inc.
5 6 7 8 9 10 11 12 13 14 15 16

# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 2 of the License, or
# (at your option) any later version.

# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.

# You should have received a copy of the GNU General Public License
17 18
# along with this program.  If not, see
# <http://www.gnu.org/licenses/>.
19

20
. "$(dirname $0)/test-lib.sh"
21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63

# If $abs_top_builddir/tools is not early in $PATH, put it there,
# so that we can safely invoke "virsh" simply with its name.
case $PATH in
  $abs_top_builddir/tools/src:$abs_top_builddir/tools:*) ;;
  $abs_top_builddir/tools:*) ;;
  *) PATH=$abs_top_builddir/tools:$PATH; export PATH ;;
esac

if test "$VERBOSE" = yes; then
  set -x
  virsh --version
fi

cat <<\EOF > exp-out || framework_failure

setvcpus: <domain> trying as domain NAME
setvcpus: count(optdata): 2
setvcpus: domain(optdata): test
setvcpus: found option <domain>: test
EOF

fail=0

test_url=test:///default

for args in \
    'test 2' \
    '--domain test 2' \
    '--domain=test 2' \
    'test --count 2' \
    'test --count=2' \
    '--domain test --count 2' \
    '--domain=test --count 2' \
    '--domain test --count=2' \
    '--domain=test --count=2' \
    '--count 2 --domain test' \
    '--count 2 --domain=test' \
    '--count=2 --domain test' \
    '--count=2 --domain=test' \
    '--count 2 test' \
    '--count=2 test' \
; do
64
  virsh -k0 -d0 -c $test_url setvcpus $args >out 2>>err || fail=1
E
Eric Blake 已提交
65
  LC_ALL=C sort out | compare exp-out - || fail=1
66
done
67 68 69 70 71

# Another complex parsing example
cat <<\EOF > exp-out || framework_failure
<domainsnapshot>
  <description>1&lt;2</description>
72
  <memory file='d,e'/>
73 74 75 76 77 78 79 80 81
  <disks>
    <disk name='vda' snapshot='external'>
      <source file='a&amp;b,c'/>
    </disk>
    <disk name='vdb'/>
  </disks>
</domainsnapshot>

EOF
82
virsh -q -c $test_url snapshot-create-as --print-xml test \
83
  --diskspec 'vda,file=a&b,,c,snapshot=external' --description '1<2' \
84
  --diskspec vdb --memspec file=d,,e >out 2>>err || fail=1
E
Eric Blake 已提交
85
compare exp-out out || fail=1
86

87 88 89 90 91 92 93 94 95 96 97 98
cat <<\EOF > exp-out || framework_failure
<domainsnapshot>
  <name>name</name>
  <description>vda</description>
  <disks>
    <disk name='vdb'/>
  </disks>
</domainsnapshot>

EOF
virsh -q -c $test_url snapshot-create-as  --print-xml test name vda vdb \
  >out 2>>err || fail=1
E
Eric Blake 已提交
99
compare exp-out out || fail=1
100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118

cat <<\EOF > exp-out || framework_failure
<domainsnapshot>
  <name>name</name>
  <description>desc</description>
  <disks>
    <disk name='vda'/>
    <disk name='vdb'/>
  </disks>
</domainsnapshot>

EOF
for args in \
    'test name desc vda vdb' \
    'test name desc --diskspec vda vdb' \
    'test name desc --diskspec vda --diskspec vdb' \
    'test name desc vda vdb' \
    'test --diskspec vda name --diskspec vdb desc' \
    '--description desc --name name --domain test vda vdb' \
119
    '--description desc --diskspec vda --name name --domain test vdb' \
120 121 122
; do
  virsh -q -c $test_url snapshot-create-as --print-xml $args \
    >out 2>>err || fail=1
E
Eric Blake 已提交
123
  compare exp-out out || fail=1
124 125
done

126 127
test -s err && fail=1

128 129 130 131 132 133
# Test a required argv
cat <<\EOF > exp-err || framework_failure
error: this function is not supported by the connection driver: virDomainQemuMonitorCommand
EOF
virsh -q -c $test_url qemu-monitor-command test a >out 2>err && fail=1
test -s out && fail=1
E
Eric Blake 已提交
134
compare exp-err err || fail=1
135

136 137 138 139
### Test a regular numeric option

# Non-numeric value
cat <<\EOF > exp-err || framework_failure
140
error: Numeric value 'abc' for <start> option is malformed or out of range
141 142 143 144 145 146 147
EOF
virsh -q -c $test_url cpu-stats test --start abc >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Numeric value with invalid suffix
cat <<\EOF > exp-err || framework_failure
148
error: Numeric value '42WB' for <start> option is malformed or out of range
149 150 151 152 153 154 155 156
EOF
virsh -q -c $test_url cpu-stats test --start 42WB >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Numeric value with valid suffix. Suffixes are not supported for
# regular numeric options, so this value is rejected
cat <<\EOF > exp-err || framework_failure
157
error: Numeric value '42MB' for <start> option is malformed or out of range
158 159 160 161 162 163 164
EOF
virsh -q -c $test_url cpu-stats test --start 42MB >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Numeric value bigger than INT_MAX
cat <<\EOF > exp-err || framework_failure
165
error: Numeric value '2147483648' for <start> option is malformed or out of range
166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203
EOF
virsh -q -c $test_url cpu-stats test --start 2147483648 >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Negative numeric value. The value is not valid for the command
# we're testing, but it has been parsed correctly
cat <<\EOF > exp-err || framework_failure
error: Invalid value for start CPU
EOF
virsh -q -c $test_url cpu-stats test --start -1 >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Zero. The test driver doesn't support the operation so the command
# fails, but the value has been parsed correctly
cat <<\EOF > exp-err || framework_failure
error: Failed to retrieve CPU statistics for domain 'test'
error: this function is not supported by the connection driver: virDomainGetCPUStats
EOF
virsh -q -c $test_url cpu-stats test --start 0 >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Valid numeric value. The test driver doesn't support the operation
# so the command fails, but the value has been parsed correctly
cat <<\EOF > exp-err || framework_failure
error: Failed to retrieve CPU statistics for domain 'test'
error: this function is not supported by the connection driver: virDomainGetCPUStats
EOF
virsh -q -c $test_url cpu-stats test --start 42 >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

### Test a scaled numeric option

# Non-numeric value
cat <<\EOF > exp-err || framework_failure
204
error: Scaled numeric value 'abc' for <size> option is malformed or out of range
205 206 207 208 209 210 211
EOF
virsh -q -c $test_url setmaxmem test abc >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Numeric value with invalid suffix
cat <<\EOF > exp-err || framework_failure
212
error: Scaled numeric value '42WB' for <size> option is malformed or out of range
213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230
EOF
virsh -q -c $test_url setmaxmem test 42WB >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Numeric value with valid suffix
virsh -q -c $test_url setmaxmem test 42MB >out 2>err || fail=1
test -s out && fail=1
test -s err && fail=1

# Numeric value bigger than INT_MAX. No failure here because
# scaled numeric values are unsigned long long
virsh -q -c $test_url setmaxmem test 2147483648 >out 2>err || fail=1
test -s out && fail=1
test -s err && fail=1

# Negative numeric value
cat <<\EOF > exp-err || framework_failure
231
error: Scaled numeric value '-1' for <size> option is malformed or out of range
232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255
EOF
virsh -q -c $test_url setmaxmem test -1 >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Zero. The value is not valid for the command we're testing, but
# it has been parsed correctly
cat <<\EOF > exp-err || framework_failure
error: Unable to change MaxMemorySize
error: memory in virDomainSetMaxMemory must not be zero
EOF
virsh -q -c $test_url setmaxmem test 0 >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Numeric value
virsh -q -c $test_url setmaxmem test 42 >out 2>err || fail=1
test -s out && fail=1
test -s err && fail=1

### Test the <timeout> option (numeric option converted to ms)

# Non-numeric value
cat <<\EOF > exp-err || framework_failure
256
error: Numeric value 'abc' for <timeout> option is malformed or out of range
257 258 259 260 261 262 263 264
EOF
virsh -q -c $test_url event --all --timeout abc >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Numeric value that's too big to be converted to ms and still
# fit inside an int
cat <<\EOF > exp-err || framework_failure
265
error: Numeric value '2147484' for <timeout> option is malformed or out of range
266 267 268 269 270 271 272
EOF
virsh -q -c $test_url event --all --timeout 2147484 >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Numeric value with invalid suffix
cat <<\EOF > exp-err || framework_failure
273
error: Numeric value '42WB' for <timeout> option is malformed or out of range
274 275 276 277 278 279 280 281
EOF
virsh -q -c $test_url event --all --timeout 42WB >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Numeric value with valid suffix. Suffixes are not supported for
# the <timeout> option, so this value is rejected
cat <<\EOF > exp-err || framework_failure
282
error: Numeric value '42MB' for <timeout> option is malformed or out of range
283 284 285 286 287 288 289
EOF
virsh -q -c $test_url event --all --timeout 42MB >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Negative value
cat <<\EOF > exp-err || framework_failure
290
error: Numeric value '-1' for <timeout> option is malformed or out of range
291 292 293 294 295 296 297 298
EOF
virsh -q -c $test_url event --all --timeout -1 >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Zero. This is not a valid timeout, but the value is parsed
# correctly
cat <<\EOF > exp-err || framework_failure
299
error: Numeric value '0' for <timeout> option is malformed or out of range
300 301 302 303 304 305 306 307 308 309 310 311 312 313 314
EOF
virsh -q -c $test_url event --all --timeout 0 >out 2>err && fail=1
test -s out && fail=1
compare exp-err err || fail=1

# Numeric value. No events will be received and the command will
# fail after a second, but the value has been parsed correctly
cat <<\EOF > exp-out || framework_failure
event loop timed out
events received: 0
EOF
virsh -q -c $test_url event --all --timeout 1 >out 2>err && fail=1
test -s err && fail=1
compare exp-out out || fail=1

315
(exit $fail); exit $fail