security_dac.c 38.6 KB
Newer Older
1
/*
2
 * Copyright (C) 2010-2014 Red Hat, Inc.
3 4 5 6 7 8 9 10 11 12 13 14
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
15
 * License along with this library.  If not, see
O
Osier Yang 已提交
16
 * <http://www.gnu.org/licenses/>.
17 18 19 20 21 22 23 24 25 26
 *
 * POSIX DAC security driver
 */

#include <config.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>

#include "security_dac.h"
27
#include "virerror.h"
28
#include "virfile.h"
29
#include "viralloc.h"
30
#include "virlog.h"
31
#include "virpci.h"
32
#include "virusb.h"
33
#include "virscsi.h"
34
#include "virstoragefile.h"
35
#include "virstring.h"
M
Martin Kletzander 已提交
36
#include "virutil.h"
37 38

#define VIR_FROM_THIS VIR_FROM_SECURITY
39 40 41

VIR_LOG_INIT("security.security_dac");

42
#define SECURITY_DAC_NAME "dac"
43 44 45 46 47 48 49

typedef struct _virSecurityDACData virSecurityDACData;
typedef virSecurityDACData *virSecurityDACDataPtr;

struct _virSecurityDACData {
    uid_t user;
    gid_t group;
50 51
    gid_t *groups;
    int ngroups;
52
    bool dynamicOwnership;
53
    char *baselabel;
54
    virSecurityManagerDACChownCallback chownCallback;
55 56
};

57 58 59 60 61 62 63 64
typedef struct _virSecurityDACCallbackData virSecurityDACCallbackData;
typedef virSecurityDACCallbackData *virSecurityDACCallbackDataPtr;

struct _virSecurityDACCallbackData {
    virSecurityManagerPtr manager;
    virSecurityLabelDefPtr secdef;
};

65 66 67 68 69
/* returns -1 on error, 0 on success */
int
virSecurityDACSetUserAndGroup(virSecurityManagerPtr mgr,
                              uid_t user,
                              gid_t group)
70 71 72 73
{
    virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);
    priv->user = user;
    priv->group = group;
74

75
    if (virAsprintf(&priv->baselabel, "+%u:+%u",
76 77 78 79 80
                    (unsigned int) user,
                    (unsigned int) group) < 0)
        return -1;

    return 0;
81 82
}

O
Osier Yang 已提交
83 84 85
void
virSecurityDACSetDynamicOwnership(virSecurityManagerPtr mgr,
                                  bool dynamicOwnership)
86 87 88 89 90
{
    virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);
    priv->dynamicOwnership = dynamicOwnership;
}

91 92 93 94 95 96 97 98
void
virSecurityDACSetChownCallback(virSecurityManagerPtr mgr,
                               virSecurityManagerDACChownCallback chownCallback)
{
    virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);
    priv->chownCallback = chownCallback;
}

99
/* returns 1 if label isn't found, 0 on success, -1 on error */
O
Osier Yang 已提交
100
static int
101
ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3)
102 103
virSecurityDACParseIds(virSecurityLabelDefPtr seclabel,
                       uid_t *uidPtr, gid_t *gidPtr)
104
{
105
    if (!seclabel || !seclabel->label)
106
        return 1;
107

108
    if (virParseOwnershipIds(seclabel->label, uidPtr, gidPtr) < 0)
109 110 111 112 113
        return -1;

    return 0;
}

O
Osier Yang 已提交
114
static int
115
ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4)
116 117
virSecurityDACGetIds(virSecurityLabelDefPtr seclabel,
                     virSecurityDACDataPtr priv,
118 119
                     uid_t *uidPtr, gid_t *gidPtr,
                     gid_t **groups, int *ngroups)
120
{
121 122
    int ret;

123 124 125 126 127
    if (groups)
        *groups = priv ? priv->groups : NULL;
    if (ngroups)
        *ngroups = priv ? priv->ngroups : 0;

128
    if ((ret = virSecurityDACParseIds(seclabel, uidPtr, gidPtr)) <= 0)
129 130 131
        return ret;

    if (!priv) {
132 133
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("DAC seclabel couldn't be determined"));
134 135 136
        return -1;
    }

137 138
    *uidPtr = priv->user;
    *gidPtr = priv->group;
139 140

    return 0;
141 142
}

143 144

/* returns 1 if label isn't found, 0 on success, -1 on error */
O
Osier Yang 已提交
145
static int
146
ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3)
147
virSecurityDACParseImageIds(virSecurityLabelDefPtr seclabel,
O
Osier Yang 已提交
148
                            uid_t *uidPtr, gid_t *gidPtr)
149
{
150
    if (!seclabel || !seclabel->imagelabel)
151
        return 1;
152

153
    if (virParseOwnershipIds(seclabel->imagelabel, uidPtr, gidPtr) < 0)
154 155 156 157 158
        return -1;

    return 0;
}

O
Osier Yang 已提交
159
static int
160
ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4)
161 162
virSecurityDACGetImageIds(virSecurityLabelDefPtr seclabel,
                          virSecurityDACDataPtr priv,
O
Osier Yang 已提交
163
                          uid_t *uidPtr, gid_t *gidPtr)
164
{
165 166
    int ret;

167
    if ((ret = virSecurityDACParseImageIds(seclabel, uidPtr, gidPtr)) <= 0)
168 169 170
        return ret;

    if (!priv) {
171 172
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("DAC imagelabel couldn't be determined"));
173
        return -1;
174
    }
175

176 177
    *uidPtr = priv->user;
    *gidPtr = priv->group;
178 179

    return 0;
180 181 182
}


183
static virSecurityDriverStatus
184
virSecurityDACProbe(const char *virtDriver ATTRIBUTE_UNUSED)
185 186 187 188 189 190 191 192 193 194 195
{
    return SECURITY_DRIVER_ENABLE;
}

static int
virSecurityDACOpen(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED)
{
    return 0;
}

static int
196
virSecurityDACClose(virSecurityManagerPtr mgr)
197
{
198 199
    virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);
    VIR_FREE(priv->groups);
200
    VIR_FREE(priv->baselabel);
201 202 203 204
    return 0;
}


O
Osier Yang 已提交
205 206
static const char *
virSecurityDACGetModel(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED)
207
{
208
    return SECURITY_DAC_NAME;
209 210
}

O
Osier Yang 已提交
211 212
static const char *
virSecurityDACGetDOI(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED)
213 214 215 216
{
    return "0";
}

217 218 219 220 221 222 223 224 225 226 227 228 229 230 231
static int
virSecurityDACPreFork(virSecurityManagerPtr mgr)
{
    virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);
    int ngroups;

    VIR_FREE(priv->groups);
    priv->ngroups = 0;
    if ((ngroups = virGetGroupList(priv->user, priv->group,
                                   &priv->groups)) < 0)
        return -1;
    priv->ngroups = ngroups;
    return 0;
}

232
static int
233
virSecurityDACSetOwnership(const char *path, uid_t uid, gid_t gid)
234
{
235 236
    VIR_INFO("Setting DAC user and group on '%s' to '%ld:%ld'",
             path, (long) uid, (long) gid);
237 238 239 240 241 242 243 244 245 246 247 248 249

    if (chown(path, uid, gid) < 0) {
        struct stat sb;
        int chown_errno = errno;

        if (stat(path, &sb) >= 0) {
            if (sb.st_uid == uid &&
                sb.st_gid == gid) {
                /* It's alright, there's nothing to change anyway. */
                return 0;
            }
        }

250
        if (chown_errno == EOPNOTSUPP || chown_errno == EINVAL) {
251 252 253
            VIR_INFO("Setting user and group to '%ld:%ld' on '%s' not "
                     "supported by filesystem",
                     (long) uid, (long) gid, path);
254
        } else if (chown_errno == EPERM) {
255 256 257
            VIR_INFO("Setting user and group to '%ld:%ld' on '%s' not "
                     "permitted",
                     (long) uid, (long) gid, path);
258
        } else if (chown_errno == EROFS) {
259 260 261
            VIR_INFO("Setting user and group to '%ld:%ld' on '%s' not "
                     "possible on readonly filesystem",
                     (long) uid, (long) gid, path);
262 263
        } else {
            virReportSystemError(chown_errno,
264 265 266
                                 _("unable to set user and group to '%ld:%ld' "
                                   "on '%s'"),
                                 (long) uid, (long) gid, path);
267 268 269 270 271 272 273 274 275 276 277 278
            return -1;
        }
    }
    return 0;
}

static int
virSecurityDACRestoreSecurityFileLabel(const char *path)
{
    VIR_INFO("Restoring DAC user and group on '%s'", path);

    /* XXX record previous ownership */
279
    return virSecurityDACSetOwnership(path, 0, 0);
280 281 282 283
}


static int
284 285 286
virSecurityDACSetSecurityImageLabel(virSecurityManagerPtr mgr,
                                    virDomainDefPtr def,
                                    virStorageSourcePtr src)
287
{
288
    virSecurityLabelDefPtr secdef;
289
    virSecurityDeviceLabelDefPtr disk_seclabel;
290
    virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);
291 292 293
    uid_t user;
    gid_t group;

294 295 296 297 298 299 300 301
    if (!priv->dynamicOwnership)
        return 0;

    /* XXX: Add support for gluster DAC permissions */
    if (!src->path || !virStorageSourceIsLocalStorage(src))
        return 0;

    secdef = virDomainDefGetSecurityLabelDef(def, SECURITY_DAC_NAME);
302
    if (secdef && !secdef->relabel)
303
        return 0;
304

305 306
    disk_seclabel = virStorageSourceGetSecurityLabelDef(src,
                                                        SECURITY_DAC_NAME);
307
    if (disk_seclabel && !disk_seclabel->relabel)
308 309 310 311 312 313 314 315 316
        return 0;

    if (disk_seclabel && disk_seclabel->label) {
        if (virParseOwnershipIds(disk_seclabel->label, &user, &group) < 0)
            return -1;
    } else {
        if (virSecurityDACGetImageIds(secdef, priv, &user, &group))
            return -1;
    }
317

318
    return virSecurityDACSetOwnership(src->path, user, group);
319 320 321 322
}


static int
323 324 325
virSecurityDACSetSecurityDiskLabel(virSecurityManagerPtr mgr,
                                   virDomainDefPtr def,
                                   virDomainDiskDefPtr disk)
326 327

{
328
    virStorageSourcePtr next;
329

330 331 332 333
    for (next = disk->src; next; next = next->backingStore) {
        if (virSecurityDACSetSecurityImageLabel(mgr, def, next) < 0)
            return -1;
    }
334

335
    return 0;
336 337 338 339 340
}


static int
virSecurityDACRestoreSecurityImageLabelInt(virSecurityManagerPtr mgr,
341
                                           virDomainDefPtr def,
342
                                           virStorageSourcePtr src,
343
                                           bool migrated)
344 345
{
    virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);
346 347
    virSecurityLabelDefPtr secdef;
    virSecurityDeviceLabelDefPtr disk_seclabel;
348 349 350 351

    if (!priv->dynamicOwnership)
        return 0;

352
    if (!src->path || !virStorageSourceIsLocalStorage(src))
353 354
        return 0;

355 356 357 358 359 360 361
    /* Don't restore labels on readoly/shared disks, because other VMs may
     * still be accessing these. Alternatively we could iterate over all
     * running domains and try to figure out if it is in use, but this would
     * not work for clustered filesystems, since we can't see running VMs using
     * the file on other nodes. Safest bet is thus to skip the restore step. */
    if (src->readonly || src->shared)
        return 0;
362

363
    secdef = virDomainDefGetSecurityLabelDef(def, SECURITY_DAC_NAME);
364
    if (secdef && !secdef->relabel)
365 366
        return 0;

367
    disk_seclabel = virStorageSourceGetSecurityLabelDef(src,
368
                                                        SECURITY_DAC_NAME);
369
    if (disk_seclabel && !disk_seclabel->relabel)
370 371
        return 0;

372 373 374
    /* If we have a shared FS and are doing migration, we must not change
     * ownership, because that kills access on the destination host which is
     * sub-optimal for the guest VM's I/O attempts :-) */
375
    if (migrated) {
376
        int rc = virFileIsSharedFS(src->path);
377 378 379 380
        if (rc < 0)
            return -1;
        if (rc == 1) {
            VIR_DEBUG("Skipping image label restore on %s because FS is shared",
381
                      src->path);
382 383 384 385
            return 0;
        }
    }

386 387 388 389 390 391 392 393 394 395
    return virSecurityDACRestoreSecurityFileLabel(src->path);
}


static int
virSecurityDACRestoreSecurityImageLabel(virSecurityManagerPtr mgr,
                                        virDomainDefPtr def,
                                        virStorageSourcePtr src)
{
    return virSecurityDACRestoreSecurityImageLabelInt(mgr, def, src, false);
396 397 398 399
}


static int
400 401 402
virSecurityDACRestoreSecurityDiskLabel(virSecurityManagerPtr mgr,
                                       virDomainDefPtr def,
                                       virDomainDiskDefPtr disk)
403
{
404
    return virSecurityDACRestoreSecurityImageLabelInt(mgr, def, disk->src, false);
405 406 407 408
}


static int
409 410
virSecurityDACSetSecurityHostdevLabelHelper(const char *file,
                                            void *opaque)
411
{
412 413 414
    virSecurityDACCallbackDataPtr cbdata = opaque;
    virSecurityManagerPtr mgr = cbdata->manager;
    virSecurityLabelDefPtr secdef = cbdata->secdef;
415
    virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);
416 417
    uid_t user;
    gid_t group;
418

419
    if (virSecurityDACGetIds(secdef, priv, &user, &group, NULL, NULL))
420 421 422
        return -1;

    return virSecurityDACSetOwnership(file, user, group);
423 424 425
}


426 427 428 429 430 431 432 433 434
static int
virSecurityDACSetSecurityPCILabel(virPCIDevicePtr dev ATTRIBUTE_UNUSED,
                                  const char *file,
                                  void *opaque)
{
    return virSecurityDACSetSecurityHostdevLabelHelper(file, opaque);
}


435
static int
436
virSecurityDACSetSecurityUSBLabel(virUSBDevicePtr dev ATTRIBUTE_UNUSED,
437 438 439
                                  const char *file,
                                  void *opaque)
{
440 441
    return virSecurityDACSetSecurityHostdevLabelHelper(file, opaque);
}
442

443

444 445 446 447 448 449
static int
virSecurityDACSetSecuritySCSILabel(virSCSIDevicePtr dev ATTRIBUTE_UNUSED,
                                   const char *file,
                                   void *opaque)
{
    return virSecurityDACSetSecurityHostdevLabelHelper(file, opaque);
450 451 452 453 454
}


static int
virSecurityDACSetSecurityHostdevLabel(virSecurityManagerPtr mgr,
455
                                      virDomainDefPtr def,
456 457
                                      virDomainHostdevDefPtr dev,
                                      const char *vroot)
458 459
{
    virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);
460
    virSecurityDACCallbackData cbdata;
461 462 463 464 465 466 467 468
    int ret = -1;

    if (!priv->dynamicOwnership)
        return 0;

    if (dev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS)
        return 0;

469 470 471
    cbdata.manager = mgr;
    cbdata.secdef = virDomainDefGetSecurityLabelDef(def, SECURITY_DAC_NAME);

472
    if (cbdata.secdef && !cbdata.secdef->relabel)
473 474
        return 0;

475
    switch ((virDomainHostdevSubsysType) dev->source.subsys.type) {
476
    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB: {
477
        virUSBDevicePtr usb;
478

479 480 481
        if (dev->missing)
            return 0;

482 483 484
        usb = virUSBDeviceNew(dev->source.subsys.u.usb.bus,
                              dev->source.subsys.u.usb.device,
                              vroot);
485 486 487
        if (!usb)
            goto done;

488 489 490
        ret = virUSBDeviceFileIterate(usb,
                                      virSecurityDACSetSecurityUSBLabel,
                                      &cbdata);
491
        virUSBDeviceFree(usb);
492 493 494 495
        break;
    }

    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI: {
496
        virPCIDevicePtr pci =
497 498 499 500
            virPCIDeviceNew(dev->source.subsys.u.pci.addr.domain,
                            dev->source.subsys.u.pci.addr.bus,
                            dev->source.subsys.u.pci.addr.slot,
                            dev->source.subsys.u.pci.addr.function);
501 502 503 504

        if (!pci)
            goto done;

505
        if (dev->source.subsys.u.pci.backend
506
            == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO) {
507
            char *vfioGroupDev = virPCIDeviceGetIOMMUGroupDev(pci);
508

509 510
            if (!vfioGroupDev) {
                virPCIDeviceFree(pci);
511
                goto done;
512
            }
513
            ret = virSecurityDACSetSecurityPCILabel(pci, vfioGroupDev, &cbdata);
514 515
            VIR_FREE(vfioGroupDev);
        } else {
516 517 518
            ret = virPCIDeviceFileIterate(pci,
                                          virSecurityDACSetSecurityPCILabel,
                                          &cbdata);
519 520
        }

521
        virPCIDeviceFree(pci);
522 523 524
        break;
    }

525 526
    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI: {
        virSCSIDevicePtr scsi =
527 528
            virSCSIDeviceNew(NULL,
                             dev->source.subsys.u.scsi.adapter,
529 530 531
                             dev->source.subsys.u.scsi.bus,
                             dev->source.subsys.u.scsi.target,
                             dev->source.subsys.u.scsi.unit,
532 533
                             dev->readonly,
                             dev->shareable);
534 535 536 537

        if (!scsi)
            goto done;

538 539 540
        ret = virSCSIDeviceFileIterate(scsi,
                                       virSecurityDACSetSecuritySCSILabel,
                                       &cbdata);
541 542 543 544 545
        virSCSIDeviceFree(scsi);

        break;
    }

546
    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST:
547 548 549 550
        ret = 0;
        break;
    }

551
 done:
552 553 554 555 556
    return ret;
}


static int
557
virSecurityDACRestoreSecurityPCILabel(virPCIDevicePtr dev ATTRIBUTE_UNUSED,
558 559 560 561 562 563 564 565
                                      const char *file,
                                      void *opaque ATTRIBUTE_UNUSED)
{
    return virSecurityDACRestoreSecurityFileLabel(file);
}


static int
566 567 568
virSecurityDACRestoreSecurityUSBLabel(virUSBDevicePtr dev ATTRIBUTE_UNUSED,
                                      const char *file,
                                      void *opaque ATTRIBUTE_UNUSED)
569 570 571 572 573
{
    return virSecurityDACRestoreSecurityFileLabel(file);
}


574 575 576 577 578 579 580 581 582
static int
virSecurityDACRestoreSecuritySCSILabel(virSCSIDevicePtr dev ATTRIBUTE_UNUSED,
                                       const char *file,
                                       void *opaque ATTRIBUTE_UNUSED)
{
    return virSecurityDACRestoreSecurityFileLabel(file);
}


583 584
static int
virSecurityDACRestoreSecurityHostdevLabel(virSecurityManagerPtr mgr,
585
                                          virDomainDefPtr def,
586 587
                                          virDomainHostdevDefPtr dev,
                                          const char *vroot)
588 589 590

{
    virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);
591
    virSecurityLabelDefPtr secdef;
592 593
    int ret = -1;

594 595
    secdef = virDomainDefGetSecurityLabelDef(def, SECURITY_DAC_NAME);

596
    if (!priv->dynamicOwnership || (secdef && !secdef->relabel))
597 598 599 600 601
        return 0;

    if (dev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS)
        return 0;

602
    switch ((virDomainHostdevSubsysType) dev->source.subsys.type) {
603
    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB: {
604
        virUSBDevicePtr usb;
605 606 607

        if (dev->missing)
            return 0;
608

609 610 611
        usb = virUSBDeviceNew(dev->source.subsys.u.usb.bus,
                              dev->source.subsys.u.usb.device,
                              vroot);
612 613 614
        if (!usb)
            goto done;

615 616
        ret = virUSBDeviceFileIterate(usb, virSecurityDACRestoreSecurityUSBLabel, mgr);
        virUSBDeviceFree(usb);
617 618 619 620 621

        break;
    }

    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI: {
622
        virPCIDevicePtr pci =
623 624 625 626
            virPCIDeviceNew(dev->source.subsys.u.pci.addr.domain,
                            dev->source.subsys.u.pci.addr.bus,
                            dev->source.subsys.u.pci.addr.slot,
                            dev->source.subsys.u.pci.addr.function);
627 628 629 630

        if (!pci)
            goto done;

631
        if (dev->source.subsys.u.pci.backend
632
            == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO) {
633
            char *vfioGroupDev = virPCIDeviceGetIOMMUGroupDev(pci);
634

635 636
            if (!vfioGroupDev) {
                virPCIDeviceFree(pci);
637
                goto done;
638
            }
639 640 641 642 643
            ret = virSecurityDACRestoreSecurityPCILabel(pci, vfioGroupDev, mgr);
            VIR_FREE(vfioGroupDev);
        } else {
            ret = virPCIDeviceFileIterate(pci, virSecurityDACRestoreSecurityPCILabel, mgr);
        }
644
        virPCIDeviceFree(pci);
645 646 647
        break;
    }

648 649
    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI: {
        virSCSIDevicePtr scsi =
650 651
            virSCSIDeviceNew(NULL,
                             dev->source.subsys.u.scsi.adapter,
652 653 654
                             dev->source.subsys.u.scsi.bus,
                             dev->source.subsys.u.scsi.target,
                             dev->source.subsys.u.scsi.unit,
655 656
                             dev->readonly,
                             dev->shareable);
657 658 659 660 661 662 663 664 665 666

        if (!scsi)
            goto done;

        ret = virSCSIDeviceFileIterate(scsi, virSecurityDACRestoreSecuritySCSILabel, mgr);
        virSCSIDeviceFree(scsi);

        break;
    }

667
    case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_LAST:
668 669 670 671
        ret = 0;
        break;
    }

672
 done:
673 674 675 676 677 678
    return ret;
}


static int
virSecurityDACSetChardevLabel(virSecurityManagerPtr mgr,
679
                              virDomainDefPtr def,
680 681
                              virDomainChrDefPtr dev,
                              virDomainChrSourceDefPtr dev_source)
682 683 684

{
    virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);
685
    virSecurityLabelDefPtr seclabel;
686
    virSecurityDeviceLabelDefPtr chr_seclabel = NULL;
687 688
    char *in = NULL, *out = NULL;
    int ret = -1;
689 690 691
    uid_t user;
    gid_t group;

692 693
    seclabel = virDomainDefGetSecurityLabelDef(def, SECURITY_DAC_NAME);

694 695 696 697
    if (dev)
        chr_seclabel = virDomainChrDefGetSecurityLabelDef(dev,
                                                          SECURITY_DAC_NAME);

698
    if (chr_seclabel && !chr_seclabel->relabel)
699 700 701 702 703 704 705 706 707
        return 0;

    if (chr_seclabel && chr_seclabel->label) {
        if (virParseOwnershipIds(chr_seclabel->label, &user, &group) < 0)
            return -1;
    } else {
        if (virSecurityDACGetIds(seclabel, priv, &user, &group, NULL, NULL) < 0)
            return -1;
    }
708

709
    switch ((virDomainChrType) dev_source->type) {
710 711
    case VIR_DOMAIN_CHR_TYPE_DEV:
    case VIR_DOMAIN_CHR_TYPE_FILE:
712 713
        ret = virSecurityDACSetOwnership(dev_source->data.file.path,
                                         user, group);
714 715 716
        break;

    case VIR_DOMAIN_CHR_TYPE_PIPE:
717 718
        if ((virAsprintf(&in, "%s.in", dev_source->data.file.path) < 0) ||
            (virAsprintf(&out, "%s.out", dev_source->data.file.path) < 0))
719 720
            goto done;
        if (virFileExists(in) && virFileExists(out)) {
721 722
            if ((virSecurityDACSetOwnership(in, user, group) < 0) ||
                (virSecurityDACSetOwnership(out, user, group) < 0)) {
723
                goto done;
724
            }
725
        } else if (virSecurityDACSetOwnership(dev_source->data.file.path,
726
                                              user, group) < 0) {
727
            goto done;
728 729 730 731
        }
        ret = 0;
        break;

732 733 734 735 736 737 738 739 740 741 742
    case VIR_DOMAIN_CHR_TYPE_SPICEPORT:
    case VIR_DOMAIN_CHR_TYPE_NULL:
    case VIR_DOMAIN_CHR_TYPE_VC:
    case VIR_DOMAIN_CHR_TYPE_PTY:
    case VIR_DOMAIN_CHR_TYPE_STDIO:
    case VIR_DOMAIN_CHR_TYPE_UDP:
    case VIR_DOMAIN_CHR_TYPE_TCP:
    case VIR_DOMAIN_CHR_TYPE_UNIX:
    case VIR_DOMAIN_CHR_TYPE_SPICEVMC:
    case VIR_DOMAIN_CHR_TYPE_NMDM:
    case VIR_DOMAIN_CHR_TYPE_LAST:
743 744 745 746
        ret = 0;
        break;
    }

747
 done:
748 749 750 751 752 753 754
    VIR_FREE(in);
    VIR_FREE(out);
    return ret;
}

static int
virSecurityDACRestoreChardevLabel(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED,
755
                                  virDomainDefPtr def ATTRIBUTE_UNUSED,
756 757
                                  virDomainChrDefPtr dev,
                                  virDomainChrSourceDefPtr dev_source)
758
{
759
    virSecurityDeviceLabelDefPtr chr_seclabel = NULL;
760 761 762
    char *in = NULL, *out = NULL;
    int ret = -1;

763 764 765 766
    if (dev)
        chr_seclabel = virDomainChrDefGetSecurityLabelDef(dev,
                                                          SECURITY_DAC_NAME);

767
    if (chr_seclabel && !chr_seclabel->relabel)
768 769
        return 0;

770
    switch ((virDomainChrType) dev_source->type) {
771 772
    case VIR_DOMAIN_CHR_TYPE_DEV:
    case VIR_DOMAIN_CHR_TYPE_FILE:
773
        ret = virSecurityDACRestoreSecurityFileLabel(dev_source->data.file.path);
774 775 776
        break;

    case VIR_DOMAIN_CHR_TYPE_PIPE:
777 778
        if ((virAsprintf(&out, "%s.out", dev_source->data.file.path) < 0) ||
            (virAsprintf(&in, "%s.in", dev_source->data.file.path) < 0))
779
            goto done;
780 781 782
        if (virFileExists(in) && virFileExists(out)) {
            if ((virSecurityDACRestoreSecurityFileLabel(out) < 0) ||
                (virSecurityDACRestoreSecurityFileLabel(in) < 0)) {
J
Jim Fehlig 已提交
783
                goto done;
784
            }
785
        } else if (virSecurityDACRestoreSecurityFileLabel(dev_source->data.file.path) < 0) {
786 787
            goto done;
        }
788 789 790
        ret = 0;
        break;

791 792 793 794 795 796 797 798 799 800 801
    case VIR_DOMAIN_CHR_TYPE_NULL:
    case VIR_DOMAIN_CHR_TYPE_VC:
    case VIR_DOMAIN_CHR_TYPE_PTY:
    case VIR_DOMAIN_CHR_TYPE_STDIO:
    case VIR_DOMAIN_CHR_TYPE_UDP:
    case VIR_DOMAIN_CHR_TYPE_TCP:
    case VIR_DOMAIN_CHR_TYPE_UNIX:
    case VIR_DOMAIN_CHR_TYPE_SPICEVMC:
    case VIR_DOMAIN_CHR_TYPE_SPICEPORT:
    case VIR_DOMAIN_CHR_TYPE_NMDM:
    case VIR_DOMAIN_CHR_TYPE_LAST:
802 803 804 805
        ret = 0;
        break;
    }

806
 done:
807 808 809 810 811 812 813
    VIR_FREE(in);
    VIR_FREE(out);
    return ret;
}


static int
814
virSecurityDACRestoreChardevCallback(virDomainDefPtr def,
815 816 817 818 819
                                     virDomainChrDefPtr dev,
                                     void *opaque)
{
    virSecurityManagerPtr mgr = opaque;

820
    return virSecurityDACRestoreChardevLabel(mgr, def, dev, &dev->source);
821 822 823
}


824 825 826 827 828 829 830 831 832
static int
virSecurityDACSetSecurityTPMFileLabel(virSecurityManagerPtr mgr,
                                      virDomainDefPtr def,
                                      virDomainTPMDefPtr tpm)
{
    int ret = 0;

    switch (tpm->type) {
    case VIR_DOMAIN_TPM_TYPE_PASSTHROUGH:
833
        ret = virSecurityDACSetChardevLabel(mgr, def, NULL,
834 835 836 837 838 839 840 841 842 843 844
                                            &tpm->data.passthrough.source);
        break;
    case VIR_DOMAIN_TPM_TYPE_LAST:
        break;
    }

    return ret;
}


static int
O
Osier Yang 已提交
845
virSecurityDACRestoreSecurityTPMFileLabel(virSecurityManagerPtr mgr,
846
                                          virDomainDefPtr def,
O
Osier Yang 已提交
847
                                          virDomainTPMDefPtr tpm)
848 849 850 851 852
{
    int ret = 0;

    switch (tpm->type) {
    case VIR_DOMAIN_TPM_TYPE_PASSTHROUGH:
853
        ret = virSecurityDACRestoreChardevLabel(mgr, def, NULL,
854 855 856 857 858 859 860 861 862 863
                                          &tpm->data.passthrough.source);
        break;
    case VIR_DOMAIN_TPM_TYPE_LAST:
        break;
    }

    return ret;
}


864 865
static int
virSecurityDACRestoreSecurityAllLabel(virSecurityManagerPtr mgr,
866
                                      virDomainDefPtr def,
867
                                      bool migrated)
868 869
{
    virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);
870
    virSecurityLabelDefPtr secdef;
871
    size_t i;
872 873
    int rc = 0;

874
    secdef = virDomainDefGetSecurityLabelDef(def, SECURITY_DAC_NAME);
875

876
    if (!priv->dynamicOwnership || (secdef && !secdef->relabel))
877
        return 0;
878 879

    VIR_DEBUG("Restoring security label on %s migrated=%d",
880
              def->name, migrated);
881

882
    for (i = 0; i < def->nhostdevs; i++) {
883
        if (virSecurityDACRestoreSecurityHostdevLabel(mgr,
884
                                                      def,
885 886
                                                      def->hostdevs[i],
                                                      NULL) < 0)
887 888
            rc = -1;
    }
889
    for (i = 0; i < def->ndisks; i++) {
890
        if (virSecurityDACRestoreSecurityImageLabelInt(mgr,
891
                                                       def,
892
                                                       def->disks[i]->src,
893 894 895 896
                                                       migrated) < 0)
            rc = -1;
    }

897
    if (virDomainChrDefForeach(def,
898 899
                               false,
                               virSecurityDACRestoreChardevCallback,
900
                               mgr) < 0)
901 902
        rc = -1;

903 904
    if (def->tpm) {
        if (virSecurityDACRestoreSecurityTPMFileLabel(mgr,
905
                                                      def,
906 907 908 909
                                                      def->tpm) < 0)
            rc = -1;
    }

910 911
    if (def->os.kernel &&
        virSecurityDACRestoreSecurityFileLabel(def->os.kernel) < 0)
912 913
        rc = -1;

914 915
    if (def->os.initrd &&
        virSecurityDACRestoreSecurityFileLabel(def->os.initrd) < 0)
916 917
        rc = -1;

O
Olivia Yin 已提交
918 919 920 921
    if (def->os.dtb &&
        virSecurityDACRestoreSecurityFileLabel(def->os.dtb) < 0)
        rc = -1;

922 923 924 925 926
    return rc;
}


static int
927
virSecurityDACSetChardevCallback(virDomainDefPtr def,
928 929 930 931 932
                                 virDomainChrDefPtr dev,
                                 void *opaque)
{
    virSecurityManagerPtr mgr = opaque;

933
    return virSecurityDACSetChardevLabel(mgr, def, dev, &dev->source);
934 935 936 937 938
}


static int
virSecurityDACSetSecurityAllLabel(virSecurityManagerPtr mgr,
939
                                  virDomainDefPtr def,
940 941 942
                                  const char *stdin_path ATTRIBUTE_UNUSED)
{
    virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);
943
    virSecurityLabelDefPtr secdef;
944
    size_t i;
945 946
    uid_t user;
    gid_t group;
947

948 949
    secdef = virDomainDefGetSecurityLabelDef(def, SECURITY_DAC_NAME);

950
    if (!priv->dynamicOwnership || (secdef && !secdef->relabel))
951 952
        return 0;

953
    for (i = 0; i < def->ndisks; i++) {
954
        /* XXX fixme - we need to recursively label the entire tree :-( */
E
Eric Blake 已提交
955
        if (virDomainDiskGetType(def->disks[i]) == VIR_STORAGE_TYPE_DIR)
956
            continue;
957 958 959
        if (virSecurityDACSetSecurityDiskLabel(mgr,
                                               def,
                                               def->disks[i]) < 0)
960 961
            return -1;
    }
962
    for (i = 0; i < def->nhostdevs; i++) {
963
        if (virSecurityDACSetSecurityHostdevLabel(mgr,
964
                                                  def,
965 966
                                                  def->hostdevs[i],
                                                  NULL) < 0)
967 968 969
            return -1;
    }

970
    if (virDomainChrDefForeach(def,
971 972
                               true,
                               virSecurityDACSetChardevCallback,
973
                               mgr) < 0)
974 975
        return -1;

976 977 978 979 980 981 982
    if (def->tpm) {
        if (virSecurityDACSetSecurityTPMFileLabel(mgr,
                                                  def,
                                                  def->tpm) < 0)
            return -1;
    }

983
    if (virSecurityDACGetImageIds(secdef, priv, &user, &group))
984 985
        return -1;

986
    if (def->os.kernel &&
987
        virSecurityDACSetOwnership(def->os.kernel, user, group) < 0)
988 989
        return -1;

990
    if (def->os.initrd &&
991
        virSecurityDACSetOwnership(def->os.initrd, user, group) < 0)
992 993
        return -1;

O
Olivia Yin 已提交
994 995 996 997
    if (def->os.dtb &&
        virSecurityDACSetOwnership(def->os.dtb, user, group) < 0)
        return -1;

998 999 1000 1001 1002 1003
    return 0;
}


static int
virSecurityDACSetSavedStateLabel(virSecurityManagerPtr mgr,
1004
                                 virDomainDefPtr def,
1005 1006
                                 const char *savefile)
{
1007 1008
    virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);
    virSecurityLabelDefPtr secdef;
1009 1010
    uid_t user;
    gid_t group;
1011

1012 1013 1014
    secdef = virDomainDefGetSecurityLabelDef(def, SECURITY_DAC_NAME);

    if (virSecurityDACGetImageIds(secdef, priv, &user, &group) < 0)
1015 1016 1017
        return -1;

    return virSecurityDACSetOwnership(savefile, user, group);
1018 1019 1020 1021 1022
}


static int
virSecurityDACRestoreSavedStateLabel(virSecurityManagerPtr mgr,
1023
                                     virDomainDefPtr def ATTRIBUTE_UNUSED,
1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036
                                     const char *savefile)
{
    virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);

    if (!priv->dynamicOwnership)
        return 0;

    return virSecurityDACRestoreSecurityFileLabel(savefile);
}


static int
virSecurityDACSetProcessLabel(virSecurityManagerPtr mgr,
1037
                              virDomainDefPtr def)
1038
{
1039 1040
    virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);
    virSecurityLabelDefPtr secdef;
1041 1042
    uid_t user;
    gid_t group;
1043 1044
    gid_t *groups;
    int ngroups;
1045

1046 1047 1048
    secdef = virDomainDefGetSecurityLabelDef(def, SECURITY_DAC_NAME);

    if (virSecurityDACGetIds(secdef, priv, &user, &group, &groups, &ngroups) < 0)
1049
        return -1;
1050

1051 1052
    VIR_DEBUG("Dropping privileges of DEF to %u:%u, %d supplemental groups",
              (unsigned int) user, (unsigned int) group, ngroups);
1053

1054
    if (virSetUIDGID(user, group, groups, ngroups) < 0)
1055 1056 1057
        return -1;

    return 0;
1058 1059 1060
}


1061 1062
static int
virSecurityDACSetChildProcessLabel(virSecurityManagerPtr mgr,
1063
                                   virDomainDefPtr def,
1064 1065
                                   virCommandPtr cmd)
{
1066 1067
    virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);
    virSecurityLabelDefPtr secdef;
1068 1069 1070
    uid_t user;
    gid_t group;

1071 1072 1073
    secdef = virDomainDefGetSecurityLabelDef(def, SECURITY_DAC_NAME);

    if (virSecurityDACGetIds(secdef, priv, &user, &group, NULL, NULL))
1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084
        return -1;

    VIR_DEBUG("Setting child to drop privileges of DEF to %u:%u",
              (unsigned int) user, (unsigned int) group);

    virCommandSetUID(cmd, user);
    virCommandSetGID(cmd, group);
    return 0;
}


1085 1086 1087 1088 1089 1090 1091 1092
static int
virSecurityDACVerify(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED,
                     virDomainDefPtr def ATTRIBUTE_UNUSED)
{
    return 0;
}

static int
1093 1094
virSecurityDACGenLabel(virSecurityManagerPtr mgr,
                       virDomainDefPtr def)
1095
{
1096 1097 1098 1099 1100
    int rc = -1;
    virSecurityLabelDefPtr seclabel;
    virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);

    seclabel = virDomainDefGetSecurityLabelDef(def, SECURITY_DAC_NAME);
1101
    if (seclabel == NULL)
1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119
        return rc;

    if (seclabel->imagelabel) {
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("security image label already "
                         "defined for VM"));
        return rc;
    }

    if (seclabel->model
        && STRNEQ(seclabel->model, SECURITY_DAC_NAME)) {
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("security label model %s is not supported "
                         "with selinux"),
                       seclabel->model);
            return rc;
    }

1120
    switch ((virDomainSeclabelType) seclabel->type) {
1121 1122 1123 1124 1125 1126 1127 1128 1129
    case VIR_DOMAIN_SECLABEL_STATIC:
        if (seclabel->label == NULL) {
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           _("missing label for static security "
                             "driver in domain %s"), def->name);
            return rc;
        }
        break;
    case VIR_DOMAIN_SECLABEL_DYNAMIC:
1130
        if (virAsprintf(&seclabel->label, "+%u:+%u",
1131
                        (unsigned int) priv->user,
1132
                        (unsigned int) priv->group) < 0)
1133 1134 1135 1136 1137 1138 1139 1140 1141 1142
            return rc;
        if (seclabel->label == NULL) {
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           _("cannot generate dac user and group id "
                             "for domain %s"), def->name);
            return rc;
        }
        break;
    case VIR_DOMAIN_SECLABEL_NONE:
        /* no op */
1143
        return 0;
1144 1145
    case VIR_DOMAIN_SECLABEL_DEFAULT:
    case VIR_DOMAIN_SECLABEL_LAST:
1146 1147 1148 1149 1150 1151
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("unexpected security label type '%s'"),
                       virDomainSeclabelTypeToString(seclabel->type));
        return rc;
    }

1152
    if (seclabel->relabel && !seclabel->imagelabel &&
1153 1154 1155
        VIR_STRDUP(seclabel->imagelabel, seclabel->label) < 0) {
        VIR_FREE(seclabel->label);
        return rc;
1156 1157
    }

1158 1159 1160 1161 1162
    return 0;
}

static int
virSecurityDACReleaseLabel(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED,
1163
                           virDomainDefPtr def ATTRIBUTE_UNUSED)
1164 1165 1166 1167 1168 1169
{
    return 0;
}

static int
virSecurityDACReserveLabel(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED,
1170 1171
                           virDomainDefPtr def ATTRIBUTE_UNUSED,
                           pid_t pid ATTRIBUTE_UNUSED)
1172 1173 1174 1175 1176 1177
{
    return 0;
}

static int
virSecurityDACGetProcessLabel(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED,
1178
                              virDomainDefPtr def,
1179
                              pid_t pid ATTRIBUTE_UNUSED,
1180
                              virSecurityLabelPtr seclabel)
1181
{
1182 1183 1184 1185 1186 1187 1188
    virSecurityLabelDefPtr secdef =
        virDomainDefGetSecurityLabelDef(def, SECURITY_DAC_NAME);

    if (!secdef || !seclabel)
        return -1;

    if (secdef->label)
1189 1190
        ignore_value(virStrcpy(seclabel->label, secdef->label,
                               VIR_SECURITY_LABEL_BUFLEN));
1191

1192 1193 1194 1195
    return 0;
}

static int
1196
virSecurityDACSetDaemonSocketLabel(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED,
1197
                                   virDomainDefPtr vm ATTRIBUTE_UNUSED)
1198 1199 1200 1201 1202
{
    return 0;
}


1203 1204
static int
virSecurityDACSetSocketLabel(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED,
1205
                             virDomainDefPtr def ATTRIBUTE_UNUSED)
1206 1207 1208 1209 1210
{
    return 0;
}


1211 1212
static int
virSecurityDACClearSocketLabel(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED,
1213
                               virDomainDefPtr def ATTRIBUTE_UNUSED)
1214 1215 1216 1217
{
    return 0;
}

1218
static int
1219
virSecurityDACSetImageFDLabel(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED,
1220
                              virDomainDefPtr def ATTRIBUTE_UNUSED,
1221
                              int fd ATTRIBUTE_UNUSED)
1222 1223 1224 1225
{
    return 0;
}

1226 1227 1228 1229 1230 1231 1232 1233
static int
virSecurityDACSetTapFDLabel(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED,
                            virDomainDefPtr def ATTRIBUTE_UNUSED,
                            int fd ATTRIBUTE_UNUSED)
{
    return 0;
}

O
Osier Yang 已提交
1234 1235 1236 1237
static char *
virSecurityDACGetMountOptions(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED,
                              virDomainDefPtr vm ATTRIBUTE_UNUSED)
{
1238 1239 1240
    return NULL;
}

1241 1242 1243 1244 1245 1246 1247 1248
static const char *
virSecurityDACGetBaseLabel(virSecurityManagerPtr mgr,
                           int virt ATTRIBUTE_UNUSED)
{
    virSecurityDACDataPtr priv = virSecurityManagerGetPrivateData(mgr);
    return priv->baselabel;
}

1249
virSecurityDriver virSecurityDriverDAC = {
1250
    .privateDataLen                     = sizeof(virSecurityDACData),
1251
    .name                               = SECURITY_DAC_NAME,
1252 1253 1254
    .probe                              = virSecurityDACProbe,
    .open                               = virSecurityDACOpen,
    .close                              = virSecurityDACClose,
1255

1256 1257
    .getModel                           = virSecurityDACGetModel,
    .getDOI                             = virSecurityDACGetDOI,
1258

1259 1260
    .preFork                            = virSecurityDACPreFork,

1261
    .domainSecurityVerify               = virSecurityDACVerify,
1262

1263
    .domainSetSecurityDiskLabel         = virSecurityDACSetSecurityDiskLabel,
1264
    .domainRestoreSecurityDiskLabel     = virSecurityDACRestoreSecurityDiskLabel,
1265

1266
    .domainSetSecurityImageLabel        = virSecurityDACSetSecurityImageLabel,
1267 1268
    .domainRestoreSecurityImageLabel    = virSecurityDACRestoreSecurityImageLabel,

1269 1270 1271
    .domainSetSecurityDaemonSocketLabel = virSecurityDACSetDaemonSocketLabel,
    .domainSetSecuritySocketLabel       = virSecurityDACSetSocketLabel,
    .domainClearSecuritySocketLabel     = virSecurityDACClearSocketLabel,
1272

1273 1274 1275
    .domainGenSecurityLabel             = virSecurityDACGenLabel,
    .domainReserveSecurityLabel         = virSecurityDACReserveLabel,
    .domainReleaseSecurityLabel         = virSecurityDACReleaseLabel,
1276

1277 1278
    .domainGetSecurityProcessLabel      = virSecurityDACGetProcessLabel,
    .domainSetSecurityProcessLabel      = virSecurityDACSetProcessLabel,
1279
    .domainSetSecurityChildProcessLabel = virSecurityDACSetChildProcessLabel,
1280

1281 1282
    .domainSetSecurityAllLabel          = virSecurityDACSetSecurityAllLabel,
    .domainRestoreSecurityAllLabel      = virSecurityDACRestoreSecurityAllLabel,
1283

1284 1285
    .domainSetSecurityHostdevLabel      = virSecurityDACSetSecurityHostdevLabel,
    .domainRestoreSecurityHostdevLabel  = virSecurityDACRestoreSecurityHostdevLabel,
1286

1287 1288
    .domainSetSavedStateLabel           = virSecurityDACSetSavedStateLabel,
    .domainRestoreSavedStateLabel       = virSecurityDACRestoreSavedStateLabel,
1289

1290
    .domainSetSecurityImageFDLabel      = virSecurityDACSetImageFDLabel,
1291
    .domainSetSecurityTapFDLabel        = virSecurityDACSetTapFDLabel,
1292

1293
    .domainGetSecurityMountOptions      = virSecurityDACGetMountOptions,
1294 1295

    .getBaseLabel                       = virSecurityDACGetBaseLabel,
1296
};