vircommand.c 72.5 KB
Newer Older
1
/*
2
 * vircommand.c: Child command execution
3
 *
4
 * Copyright (C) 2010-2014 Red Hat, Inc.
5 6 7 8 9 10 11 12 13 14 15 16
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
17
 * License along with this library.  If not, see
O
Osier Yang 已提交
18
 * <http://www.gnu.org/licenses/>.
19 20 21 22 23 24
 *
 */

#include <config.h>

#include <poll.h>
25
#include <signal.h>
26 27
#include <stdarg.h>
#include <stdlib.h>
28
#include <sys/stat.h>
29
#include <sys/wait.h>
30 31
#include <fcntl.h>

32
#if WITH_CAPNG
33 34
# include <cap-ng.h>
#endif
35

36 37 38 39 40 41 42
#if defined(WITH_SECDRIVER_SELINUX)
# include <selinux/selinux.h>
#endif
#if defined(WITH_SECDRIVER_APPARMOR)
# include <sys/apparmor.h>
#endif

43
#include "vircommand.h"
44
#include "viralloc.h"
45
#include "virerror.h"
46
#include "virutil.h"
47
#include "virlog.h"
E
Eric Blake 已提交
48
#include "virfile.h"
49
#include "virpidfile.h"
50
#include "virprocess.h"
51
#include "virbuffer.h"
52
#include "virthread.h"
53
#include "virstring.h"
54

55 56
#define VIR_FROM_THIS VIR_FROM_NONE

57
/* Flags for virExec */
58
enum {
59 60 61
    VIR_EXEC_NONE       = 0,
    VIR_EXEC_NONBLOCK   = (1 << 0),
    VIR_EXEC_DAEMON     = (1 << 1),
62
    VIR_EXEC_CLEAR_CAPS = (1 << 2),
63 64
    VIR_EXEC_RUN_SYNC   = (1 << 3),
    VIR_EXEC_ASYNC_IO   = (1 << 4),
65 66
};

67 68 69 70 71 72 73 74
typedef struct _virCommandFD virCommandFD;
typedef virCommandFD *virCommandFDPtr;

struct _virCommandFD {
    int fd;
    unsigned int flags;
};

75 76 77 78 79 80 81 82 83 84 85 86 87
struct _virCommand {
    int has_error; /* ENOMEM on allocation failure, -1 for anything else.  */

    char **args;
    size_t nargs;
    size_t maxargs;

    char **env;
    size_t nenv;
    size_t maxenv;

    char *pwd;

88 89
    size_t npassfd;
    virCommandFDPtr passfd;
90 91 92 93 94 95 96 97

    unsigned int flags;

    char *inbuf;
    char **outbuf;
    char **errbuf;

    int infd;
98
    int inpipe;
99 100 101 102 103
    int outfd;
    int errfd;
    int *outfdptr;
    int *errfdptr;

104
    virThreadPtr asyncioThread;
105

106 107 108 109
    bool handshake;
    int handshakeWait[2];
    int handshakeNotify[2];

110 111 112 113 114
    virExecHook hook;
    void *opaque;

    pid_t pid;
    char *pidfile;
115
    bool reap;
116

117 118 119 120
    unsigned long long maxMemLock;
    unsigned int maxProcesses;
    unsigned int maxFiles;

121 122
    uid_t uid;
    gid_t gid;
123
    unsigned long long capabilities;
124 125 126 127 128 129
#if defined(WITH_SECDRIVER_SELINUX)
    char *seLinuxLabel;
#endif
#if defined(WITH_SECDRIVER_APPARMOR)
    char *appArmorProfile;
#endif
130 131
};

132 133 134
/* See virCommandSetDryRun for description for this variable */
static virBufferPtr dryRunBuffer;

135 136 137 138 139 140 141 142 143 144 145 146
/*
 * virCommandFDIsSet:
 * @fd: FD to test
 * @set: the set
 * @set_size: actual size of @set
 *
 * Check if FD is already in @set or not.
 *
 * Returns true if @set contains @fd,
 * false otherwise.
 */
static bool
147 148
virCommandFDIsSet(virCommandPtr cmd,
                  int fd)
149
{
150
    size_t i = 0;
151 152
    if (!cmd)
        return false;
153

154 155
    while (i < cmd->npassfd)
        if (cmd->passfd[i++].fd == fd)
156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175
            return true;

    return false;
}

/*
 * virCommandFDSet:
 * @fd: FD to be put into @set
 * @set: the set
 * @set_size: actual size of @set
 *
 * This is practically generalized implementation
 * of FD_SET() as we do not want to be limited
 * by FD_SETSIZE.
 *
 * Returns: 0 on success,
 *          -1 on usage error,
 *          ENOMEM on OOM
 */
static int
176 177 178
virCommandFDSet(virCommandPtr cmd,
                int fd,
                unsigned int flags)
179
{
180
    if (!cmd || fd < 0)
181 182
        return -1;

183
    if (virCommandFDIsSet(cmd, fd))
184 185
        return 0;

186
    if (VIR_EXPAND_N(cmd->passfd, cmd->npassfd, 1) < 0)
187 188
        return ENOMEM;

189 190
    cmd->passfd[cmd->npassfd - 1].fd = fd;
    cmd->passfd[cmd->npassfd - 1].flags = flags;
191 192 193

    return 0;
}
194

E
Eric Blake 已提交
195 196
#ifndef WIN32

E
Eric Blake 已提交
197 198 199 200 201
/**
 * virFork:
 * @pid - a pointer to a pid_t that will receive the return value from
 *        fork()
 *
202
 * Wrapper around fork() that avoids various race/deadlock conditions.
E
Eric Blake 已提交
203 204 205 206 207 208 209 210
 *
 * on return from virFork(), if *pid < 0, the fork failed and there is
 * no new process. Otherwise, just like fork(), if *pid == 0, it is the
 * child process returning, and if *pid > 0, it is the parent.
 *
 * Even if *pid >= 0, if the return value from virFork() is < 0, it
 * indicates a failure that occurred in the parent or child process
 * after the fork. In this case, the child process should call
211
 * _exit(EXIT_CANCELED) after doing any additional error reporting.
212
 */
E
Eric Blake 已提交
213 214 215
int
virFork(pid_t *pid)
{
216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246
    sigset_t oldmask, newmask;
    struct sigaction sig_action;
    int saved_errno, ret = -1;

    *pid = -1;

    /*
     * Need to block signals now, so that child process can safely
     * kill off caller's signal handlers without a race.
     */
    sigfillset(&newmask);
    if (pthread_sigmask(SIG_SETMASK, &newmask, &oldmask) != 0) {
        saved_errno = errno;
        virReportSystemError(errno,
                             "%s", _("cannot block signals"));
        goto cleanup;
    }

    /* Ensure we hold the logging lock, to protect child processes
     * from deadlocking on another thread's inherited mutex state */
    virLogLock();

    *pid = fork();
    saved_errno = errno; /* save for caller */

    /* Unlock for both parent and child process */
    virLogUnlock();

    if (*pid < 0) {
        /* attempt to restore signal mask, but ignore failure, to
           avoid obscuring the fork failure */
247
        ignore_value(pthread_sigmask(SIG_SETMASK, &oldmask, NULL));
248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270
        virReportSystemError(saved_errno,
                             "%s", _("cannot fork child process"));
        goto cleanup;
    }

    if (*pid) {

        /* parent process */

        /* Restore our original signal mask now that the child is
           safely running */
        if (pthread_sigmask(SIG_SETMASK, &oldmask, NULL) != 0) {
            saved_errno = errno; /* save for caller */
            virReportSystemError(errno, "%s", _("cannot unblock signals"));
            goto cleanup;
        }
        ret = 0;

    } else {

        /* child process */

        int logprio;
271
        size_t i;
272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306

        /* Remove any error callback so errors in child now
           get sent to stderr where they stand a fighting chance
           of being seen / logged */
        virSetErrorFunc(NULL, NULL);
        virSetErrorLogPriorityFunc(NULL);

        /* Make sure any hook logging is sent to stderr, since child
         * process may close the logfile FDs */
        logprio = virLogGetDefaultPriority();
        virLogReset();
        virLogSetDefaultPriority(logprio);

        /* Clear out all signal handlers from parent so nothing
           unexpected can happen in our child once we unblock
           signals */
        sig_action.sa_handler = SIG_DFL;
        sig_action.sa_flags = 0;
        sigemptyset(&sig_action.sa_mask);

        for (i = 1; i < NSIG; i++) {
            /* Only possible errors are EFAULT or EINVAL
               The former wont happen, the latter we
               expect, so no need to check return value */

            sigaction(i, &sig_action, NULL);
        }

        /* Unmask all signals in child, since we've no idea
           what the caller's done with their signal mask
           and don't want to propagate that to children */
        sigemptyset(&newmask);
        if (pthread_sigmask(SIG_SETMASK, &newmask, NULL) != 0) {
            saved_errno = errno; /* save for caller */
            virReportSystemError(errno, "%s", _("cannot unblock signals"));
307 308
            virDispatchError(NULL);
            _exit(EXIT_CANCELED);
309 310 311 312 313 314 315 316 317 318
        }
        ret = 0;
    }

cleanup:
    if (ret < 0)
        errno = saved_errno;
    return ret;
}

E
Eric Blake 已提交
319 320 321 322 323 324 325 326
/*
 * Ensure that *null is an fd visiting /dev/null.  Return 0 on
 * success, -1 on failure.  Allows for lazy opening of shared
 * /dev/null fd only as required.
 */
static int
getDevNull(int *null)
{
327
    if (*null == -1 && (*null = open("/dev/null", O_RDWR|O_CLOEXEC)) < 0) {
E
Eric Blake 已提交
328 329 330 331 332 333 334 335
        virReportSystemError(errno,
                             _("cannot open %s"),
                             "/dev/null");
        return -1;
    }
    return 0;
}

336 337 338 339 340 341 342 343 344 345 346 347
/* Ensure that STD is an inheritable copy of FD.  Return 0 on success,
 * -1 on failure.  */
static int
prepareStdFd(int fd, int std)
{
    if (fd == std)
        return virSetInherit(fd, true);
    if (dup2(fd, std) != std)
        return -1;
    return 0;
}

348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395
/* virCommandHandshakeChild:
 *
 *   child side of handshake - called by child process in virExec() to
 *   indicate to parent that the child process has successfully
 *   completed its pre-exec initialization.
 */
static int
virCommandHandshakeChild(virCommandPtr cmd)
{
    char c = '1';
    int rv;

    if (!cmd->handshake)
       return true;

    VIR_DEBUG("Notifying parent for handshake start on %d",
              cmd->handshakeWait[1]);
    if (safewrite(cmd->handshakeWait[1], &c, sizeof(c)) != sizeof(c)) {
        virReportSystemError(errno, "%s",
                             _("Unable to notify parent process"));
        return -1;
    }

    VIR_DEBUG("Waiting on parent for handshake complete on %d",
              cmd->handshakeNotify[0]);
    if ((rv = saferead(cmd->handshakeNotify[0], &c,
                       sizeof(c))) != sizeof(c)) {
        if (rv < 0)
            virReportSystemError(errno, "%s",
                                 _("Unable to wait on parent process"));
        else
            virReportSystemError(EIO, "%s",
                                 _("libvirtd quit during handshake"));
        return -1;
    }
    if (c != '1') {
        virReportSystemError(EINVAL,
                             _("Unexpected confirm code '%c' from parent"),
                             c);
        return -1;
    }
    VIR_FORCE_CLOSE(cmd->handshakeWait[1]);
    VIR_FORCE_CLOSE(cmd->handshakeNotify[0]);

    VIR_DEBUG("Handshake with parent is done");
    return 0;
}

396
/*
397 398 399
 * virExec:
 * @cmd virCommandPtr containing all information about the program to
 *      exec.
400 401
 */
static int
402
virExec(virCommandPtr cmd)
403 404
{
    pid_t pid;
405
    int null = -1, fd, openmax;
E
Eric Blake 已提交
406 407
    int pipeout[2] = {-1, -1};
    int pipeerr[2] = {-1, -1};
408
    int childin = cmd->infd;
409 410 411
    int childout = -1;
    int childerr = -1;
    int tmpfd;
412
    char *binarystr = NULL;
413
    const char *binary = NULL;
414
    int forkRet, ret;
415
    struct sigaction waxon, waxoff;
416 417
    gid_t *groups = NULL;
    int ngroups;
418

419
    if (cmd->args[0][0] != '/') {
420
        if (!(binary = binarystr = virFindFileInPath(cmd->args[0]))) {
421 422
            virReportSystemError(ENOENT,
                                 _("Cannot find '%s' in path"),
423
                                 cmd->args[0]);
424 425 426
            return -1;
        }
    } else {
427
        binary = cmd->args[0];
428 429
    }

430
    if (childin < 0) {
E
Eric Blake 已提交
431 432
        if (getDevNull(&null) < 0)
            goto cleanup;
433
        childin = null;
434 435
    }

436 437
    if (cmd->outfdptr != NULL) {
        if (*cmd->outfdptr == -1) {
438
            if (pipe2(pipeout, O_CLOEXEC) < 0) {
439 440 441 442 443
                virReportSystemError(errno,
                                     "%s", _("cannot create pipe"));
                goto cleanup;
            }

444
            if ((cmd->flags & VIR_EXEC_NONBLOCK) &&
445
                virSetNonBlock(pipeout[0]) == -1) {
446 447
                virReportSystemError(errno, "%s",
                                     _("Failed to set non-blocking file descriptor flag"));
448 449 450 451 452
                goto cleanup;
            }

            childout = pipeout[1];
        } else {
453
            childout = *cmd->outfdptr;
454 455
        }
    } else {
E
Eric Blake 已提交
456 457
        if (getDevNull(&null) < 0)
            goto cleanup;
458 459 460
        childout = null;
    }

461 462
    if (cmd->errfdptr != NULL) {
        if (cmd->errfdptr == cmd->outfdptr) {
463
            childerr = childout;
464
        } else if (*cmd->errfdptr == -1) {
465
            if (pipe2(pipeerr, O_CLOEXEC) < 0) {
466 467 468 469 470
                virReportSystemError(errno,
                                     "%s", _("Failed to create pipe"));
                goto cleanup;
            }

471
            if ((cmd->flags & VIR_EXEC_NONBLOCK) &&
472
                virSetNonBlock(pipeerr[0]) == -1) {
473 474
                virReportSystemError(errno, "%s",
                                     _("Failed to set non-blocking file descriptor flag"));
475 476 477 478 479
                goto cleanup;
            }

            childerr = pipeerr[1];
        } else {
480
            childerr = *cmd->errfdptr;
481 482
        }
    } else {
E
Eric Blake 已提交
483 484
        if (getDevNull(&null) < 0)
            goto cleanup;
485 486 487
        childerr = null;
    }

488 489 490
    if ((ngroups = virGetGroupList(cmd->uid, cmd->gid, &groups)) < 0)
        goto cleanup;

491 492 493 494 495 496 497
    forkRet = virFork(&pid);

    if (pid < 0) {
        goto cleanup;
    }

    if (pid) { /* parent */
498 499 500 501
        if (forkRet < 0) {
            goto cleanup;
        }

502
        VIR_FORCE_CLOSE(null);
503
        if (cmd->outfdptr && *cmd->outfdptr == -1) {
504
            VIR_FORCE_CLOSE(pipeout[1]);
505
            *cmd->outfdptr = pipeout[0];
506
        }
507
        if (cmd->errfdptr && *cmd->errfdptr == -1) {
508
            VIR_FORCE_CLOSE(pipeerr[1]);
509
            *cmd->errfdptr = pipeerr[0];
510 511
        }

512
        cmd->pid = pid;
513

514
        VIR_FREE(binarystr);
515
        VIR_FREE(groups);
516 517 518 519 520 521

        return 0;
    }

    /* child */

522
    ret = EXIT_CANCELED;
523 524 525 526 527 528 529 530
    if (forkRet < 0) {
        /* The fork was successful, but after that there was an error
         * in the child (which was already logged).
        */
        goto fork_error;
    }

    openmax = sysconf(_SC_OPEN_MAX);
J
John Ferlan 已提交
531 532 533 534 535
    if (openmax < 0) {
        virReportSystemError(errno,  "%s",
                             _("sysconf(_SC_OPEN_MAX) failed"));
        goto fork_error;
    }
536 537
    for (fd = 3; fd < openmax; fd++) {
        if (fd == childin || fd == childout || fd == childerr)
538
            continue;
539
        if (!virCommandFDIsSet(cmd, fd)) {
540
            tmpfd = fd;
541
            VIR_MASS_CLOSE(tmpfd);
542 543
        } else if (virSetInherit(fd, true) < 0) {
            virReportSystemError(errno, _("failed to preserve fd %d"), fd);
544
            goto fork_error;
545
        }
546
    }
547

548
    if (prepareStdFd(childin, STDIN_FILENO) < 0) {
549 550 551 552
        virReportSystemError(errno,
                             "%s", _("failed to setup stdin file handle"));
        goto fork_error;
    }
553
    if (childout > 0 && prepareStdFd(childout, STDOUT_FILENO) < 0) {
554 555 556 557
        virReportSystemError(errno,
                             "%s", _("failed to setup stdout file handle"));
        goto fork_error;
    }
558
    if (childerr > 0 && prepareStdFd(childerr, STDERR_FILENO) < 0) {
559 560 561 562 563
        virReportSystemError(errno,
                             "%s", _("failed to setup stderr file handle"));
        goto fork_error;
    }

564 565 566
    if (childin != STDIN_FILENO && childin != null &&
        childin != childerr && childin != childout)
        VIR_FORCE_CLOSE(childin);
567 568 569
    if (childout > STDERR_FILENO && childout != null && childout != childerr)
        VIR_FORCE_CLOSE(childout);
    if (childerr > STDERR_FILENO && childerr != null)
570
        VIR_FORCE_CLOSE(childerr);
E
Eric Blake 已提交
571
    VIR_FORCE_CLOSE(null);
572 573 574 575 576 577

    /* Initialize full logging for a while */
    virLogSetFromEnv();

    /* Daemonize as late as possible, so the parent process can detect
     * the above errors with wait* */
578
    if (cmd->flags & VIR_EXEC_DAEMON) {
579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598
        if (setsid() < 0) {
            virReportSystemError(errno,
                                 "%s", _("cannot become session leader"));
            goto fork_error;
        }

        if (chdir("/") < 0) {
            virReportSystemError(errno,
                                 "%s", _("cannot change to root directory"));
            goto fork_error;
        }

        pid = fork();
        if (pid < 0) {
            virReportSystemError(errno,
                                 "%s", _("cannot fork child process"));
            goto fork_error;
        }

        if (pid > 0) {
599
            if (cmd->pidfile && (virPidFileWritePath(cmd->pidfile, pid) < 0)) {
600 601 602 603 604
                kill(pid, SIGTERM);
                usleep(500*1000);
                kill(pid, SIGTERM);
                virReportSystemError(errno,
                                     _("could not write pidfile %s for %d"),
605
                                     cmd->pidfile, pid);
606 607
                goto fork_error;
            }
608
            _exit(EXIT_SUCCESS);
609 610 611
        }
    }

612 613 614 615 616 617 618 619 620 621 622 623 624 625
    /* virFork reset all signal handlers to the defaults.
     * This is good for the child process, but our hook
     * risks running something that generates SIGPIPE,
     * so we need to temporarily block that again
     */
    memset(&waxoff, 0, sizeof(waxoff));
    waxoff.sa_handler = SIG_IGN;
    sigemptyset(&waxoff.sa_mask);
    memset(&waxon, 0, sizeof(waxon));
    if (sigaction(SIGPIPE, &waxoff, &waxon) < 0) {
        virReportSystemError(errno, "%s",
                             _("Could not disable SIGPIPE"));
        goto fork_error;
    }
626

627 628 629 630 631 632 633
    if (virProcessSetMaxMemLock(0, cmd->maxMemLock) < 0)
        goto fork_error;
    if (virProcessSetMaxProcesses(0, cmd->maxProcesses) < 0)
        goto fork_error;
    if (virProcessSetMaxFiles(0, cmd->maxFiles) < 0)
        goto fork_error;

634 635 636 637 638 639
    if (cmd->hook) {
        VIR_DEBUG("Run hook %p %p", cmd->hook, cmd->opaque);
        ret = cmd->hook(cmd->opaque);
        VIR_DEBUG("Done hook %d", ret);
        if (ret < 0)
           goto fork_error;
640
    }
641

642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667
# if defined(WITH_SECDRIVER_SELINUX)
    if (cmd->seLinuxLabel) {
        VIR_DEBUG("Setting child security label to %s", cmd->seLinuxLabel);
        if (setexeccon_raw(cmd->seLinuxLabel) == -1) {
            virReportSystemError(errno,
                                 _("unable to set SELinux security context "
                                   "'%s' for '%s'"),
                                 cmd->seLinuxLabel, cmd->args[0]);
            if (security_getenforce() == 1)
                goto fork_error;
        }
    }
# endif
# if defined(WITH_SECDRIVER_APPARMOR)
    if (cmd->appArmorProfile) {
        VIR_DEBUG("Setting child AppArmor profile to %s", cmd->appArmorProfile);
        if (aa_change_profile(cmd->appArmorProfile) < 0) {
            virReportSystemError(errno,
                                 _("unable to set AppArmor profile '%s' "
                                   "for '%s'"),
                                 cmd->appArmorProfile, cmd->args[0]);
            goto fork_error;
        }
    }
# endif

668 669 670 671 672 673 674
    /* The steps above may need to do something privileged, so we delay
     * setuid and clearing capabilities until the last minute.
     */
    if (cmd->uid != (uid_t)-1 || cmd->gid != (gid_t)-1 ||
        cmd->capabilities || (cmd->flags & VIR_EXEC_CLEAR_CAPS)) {
        VIR_DEBUG("Setting child uid:gid to %d:%d with caps %llx",
                  (int)cmd->uid, (int)cmd->gid, cmd->capabilities);
675 676
        if (virSetUIDGIDWithCaps(cmd->uid, cmd->gid, groups, ngroups,
                                 cmd->capabilities,
677
                                 !!(cmd->flags & VIR_EXEC_CLEAR_CAPS)) < 0) {
678
            goto fork_error;
679
        }
680 681
    }

682 683 684 685 686 687 688 689 690 691 692 693
    if (cmd->pwd) {
        VIR_DEBUG("Running child in %s", cmd->pwd);
        if (chdir(cmd->pwd) < 0) {
            virReportSystemError(errno,
                                 _("Unable to change to %s"), cmd->pwd);
            goto fork_error;
        }
    }

    if (virCommandHandshakeChild(cmd) < 0)
       goto fork_error;

694 695 696 697
    if (sigaction(SIGPIPE, &waxon, NULL) < 0) {
        virReportSystemError(errno, "%s",
                             _("Could not re-enable SIGPIPE"));
        goto fork_error;
698 699 700 701 702
    }

    /* Close logging again to ensure no FDs leak to child */
    virLogReset();

703 704
    if (cmd->env)
        execve(binary, cmd->args, cmd->env);
705
    else
706
        execv(binary, cmd->args);
707

708
    ret = errno == ENOENT ? EXIT_ENOENT : EXIT_CANNOT_INVOKE;
709 710
    virReportSystemError(errno,
                         _("cannot execute binary %s"),
711
                         cmd->args[0]);
712 713 714

 fork_error:
    virDispatchError(NULL);
715
    _exit(ret);
716 717 718 719 720

 cleanup:
    /* This is cleanup of parent process only - child
       should never jump here on error */

721
    VIR_FREE(groups);
722
    VIR_FREE(binarystr);
723

724 725
    /* NB we don't virReportError() on any failures here
       because the code which jumped here already raised
726 727 728 729 730 731 732 733 734 735
       an error condition which we must not overwrite */
    VIR_FORCE_CLOSE(pipeerr[0]);
    VIR_FORCE_CLOSE(pipeerr[1]);
    VIR_FORCE_CLOSE(pipeout[0]);
    VIR_FORCE_CLOSE(pipeout[1]);
    VIR_FORCE_CLOSE(null);
    return -1;
}

/**
E
Eric Blake 已提交
736
 * virRun:
737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769
 * @argv NULL terminated argv to run
 * @status optional variable to return exit status in
 *
 * Run a command without using the shell.
 *
 * If status is NULL, then return 0 if the command run and
 * exited with 0 status; Otherwise return -1
 *
 * If status is not-NULL, then return 0 if the command ran.
 * The status variable is filled with the command exit status
 * and should be checked by caller for success. Return -1
 * only if the command could not be run.
 */
int
virRun(const char *const*argv, int *status)
{
    int ret;
    virCommandPtr cmd = virCommandNewArgs(argv);

    ret = virCommandRun(cmd, status);
    virCommandFree(cmd);
    return ret;
}

#else /* WIN32 */

int
virRun(const char *const *argv ATTRIBUTE_UNUSED,
       int *status)
{
    if (status)
        *status = ENOTSUP;
    else
770 771
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       "%s", _("virRun is not implemented for WIN32"));
772 773 774 775
    return -1;
}

static int
776
virExec(virCommandPtr cmd ATTRIBUTE_UNUSED)
777 778 779 780
{
    /* XXX: Some day we can implement pieces of virCommand/virExec on
     * top of _spawn() or CreateProcess(), but we can't implement
     * everything, since mingw completely lacks fork(), so we cannot
781
     * run our own code in the child process.  */
782 783
    virReportError(VIR_ERR_INTERNAL_ERROR,
                   "%s", _("virExec is not implemented for WIN32"));
784 785 786 787 788 789 790 791 792 793 794 795 796 797 798
    return -1;
}

int
virFork(pid_t *pid)
{
    *pid = -1;
    errno = ENOTSUP;

    return -1;
}

#endif /* WIN32 */


E
Eric Blake 已提交
799 800 801 802 803 804 805
/**
 * virCommandNew:
 * @binary: program to run
 *
 * Create a new command for named binary.  If @binary is relative,
 * it will be found via a PATH search of the parent's PATH (and not
 * any altered PATH set by virCommandAddEnv* commands).
806 807 808 809 810 811 812 813 814
 */
virCommandPtr
virCommandNew(const char *binary)
{
    const char *const args[] = { binary, NULL };

    return virCommandNewArgs(args);
}

E
Eric Blake 已提交
815 816 817 818
/**
 * virCommandNewArgs:
 * @args: array of arguments
 *
819
 * Create a new command with a NULL terminated
E
Eric Blake 已提交
820 821
 * set of args, taking binary from args[0].  More arguments can
 * be added later.  @args[0] is handled like @binary of virCommandNew.
822 823 824 825 826 827 828 829 830
 */
virCommandPtr
virCommandNewArgs(const char *const*args)
{
    virCommandPtr cmd;

    if (VIR_ALLOC(cmd) < 0)
        return NULL;

831 832 833 834 835
    cmd->handshakeWait[0] = -1;
    cmd->handshakeWait[1] = -1;
    cmd->handshakeNotify[0] = -1;
    cmd->handshakeNotify[1] = -1;

836
    cmd->infd = cmd->inpipe = cmd->outfd = cmd->errfd = -1;
837
    cmd->pid = -1;
838 839
    cmd->uid = -1;
    cmd->gid = -1;
840 841 842 843 844 845

    virCommandAddArgSet(cmd, args);

    return cmd;
}

E
Eric Blake 已提交
846 847 848 849 850
/**
 * virCommandNewArgList:
 * @binary: program to run
 * @...: additional arguments
 *
851
 * Create a new command with a NULL terminated
E
Eric Blake 已提交
852 853
 * list of args, starting with the binary to run.  More arguments can
 * be added later.  @binary is handled as in virCommandNew.
854 855 856 857 858 859 860 861 862
 */
virCommandPtr
virCommandNewArgList(const char *binary, ...)
{
    virCommandPtr cmd = virCommandNew(binary);
    va_list list;
    const char *arg;

    if (!cmd || cmd->has_error)
E
Eric Blake 已提交
863
        return cmd;
864 865 866 867 868 869 870 871

    va_start(list, binary);
    while ((arg = va_arg(list, const char *)) != NULL)
        virCommandAddArg(cmd, arg);
    va_end(list);
    return cmd;
}

872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893
/**
 * virCommandNewVAList:
 * @binary: program to run
 * @va_list: additional arguments
 *
 * Create a new command with a NULL terminated
 * variable argument list.  @binary is handled as in virCommandNew.
 */
virCommandPtr
virCommandNewVAList(const char *binary, va_list list)
{
    virCommandPtr cmd = virCommandNew(binary);
    const char *arg;

    if (!cmd || cmd->has_error)
        return cmd;

    while ((arg = va_arg(list, const char *)) != NULL)
        virCommandAddArg(cmd, arg);
    return cmd;
}

894

895 896 897 898
#define VIR_COMMAND_MAYBE_CLOSE_FD(fd, flags)       \
    if ((fd > STDERR_FILENO) &&                     \
        (flags & VIR_COMMAND_PASS_FD_CLOSE_PARENT)) \
        VIR_FORCE_CLOSE(fd)
899

E
Eric Blake 已提交
900
/**
901
 * virCommandPassFD:
E
Eric Blake 已提交
902 903
 * @cmd: the command to modify
 * @fd: fd to reassign to the child
904
 * @flags: the flags
E
Eric Blake 已提交
905
 *
906 907 908 909 910 911 912
 * Transfer the specified file descriptor to the child, instead
 * of closing it on exec. @fd must not be one of the three
 * standard streams.
 *
 * If the flag VIR_COMMAND_PASS_FD_CLOSE_PARENT is set then fd will
 * be closed in the parent no later than Run/RunAsync/Free. The parent
 * should cease using the @fd when this call completes
913 914
 */
void
915
virCommandPassFD(virCommandPtr cmd, int fd, unsigned int flags)
916
{
917 918 919 920 921 922 923 924 925 926 927 928 929 930
    int ret = 0;

    if (!cmd) {
        VIR_COMMAND_MAYBE_CLOSE_FD(fd, flags);
        return;
    }

    if (fd <= STDERR_FILENO) {
        VIR_DEBUG("invalid fd %d", fd);
        VIR_COMMAND_MAYBE_CLOSE_FD(fd, flags);
        if (!cmd->has_error)
            cmd->has_error = -1;
        return;
    }
931

932 933 934 935 936 937 938 939
    if ((ret = virCommandFDSet(cmd, fd, flags)) != 0) {
        if (!cmd->has_error)
            cmd->has_error = ret;
        VIR_DEBUG("cannot preserve %d", fd);
        VIR_COMMAND_MAYBE_CLOSE_FD(fd, flags);
        return;
    }
}
940

E
Eric Blake 已提交
941 942 943 944 945 946 947
/**
 * virCommandSetPidFile:
 * @cmd: the command to modify
 * @pidfile: filename to use
 *
 * Save the child PID in a pidfile.  The pidfile will be populated
 * before the exec of the child.
948 949 950 951 952 953 954 955
 */
void
virCommandSetPidFile(virCommandPtr cmd, const char *pidfile)
{
    if (!cmd || cmd->has_error)
        return;

    VIR_FREE(cmd->pidfile);
956
    if (VIR_STRDUP_QUIET(cmd->pidfile, pidfile) < 0)
957 958 959 960
        cmd->has_error = ENOMEM;
}


961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978
void
virCommandSetGID(virCommandPtr cmd, gid_t gid)
{
    if (!cmd || cmd->has_error)
        return;

    cmd->gid = gid;
}

void
virCommandSetUID(virCommandPtr cmd, uid_t uid)
{
    if (!cmd || cmd->has_error)
        return;

    cmd->uid = uid;
}

979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005
void
virCommandSetMaxMemLock(virCommandPtr cmd, unsigned long long bytes)
{
    if (!cmd || cmd->has_error)
        return;

    cmd->maxMemLock = bytes;
}

void
virCommandSetMaxProcesses(virCommandPtr cmd, unsigned int procs)
{
    if (!cmd || cmd->has_error)
        return;

    cmd->maxProcesses = procs;
}

void
virCommandSetMaxFiles(virCommandPtr cmd, unsigned int files)
{
    if (!cmd || cmd->has_error)
        return;

    cmd->maxFiles = files;
}

E
Eric Blake 已提交
1006 1007 1008 1009 1010
/**
 * virCommandClearCaps:
 * @cmd: the command to modify
 *
 * Remove all capabilities from the child, after any hooks have been run.
1011 1012 1013 1014 1015 1016 1017 1018 1019 1020
 */
void
virCommandClearCaps(virCommandPtr cmd)
{
    if (!cmd || cmd->has_error)
        return;

    cmd->flags |= VIR_EXEC_CLEAR_CAPS;
}

E
Eric Blake 已提交
1021 1022 1023 1024 1025
/**
 * virCommandAllowCap:
 * @cmd: the command to modify
 * @capability: what to allow
 *
1026
 * Allow specific capabilities
1027 1028 1029
 */
void
virCommandAllowCap(virCommandPtr cmd,
1030
                   int capability)
1031 1032 1033 1034
{
    if (!cmd || cmd->has_error)
        return;

1035
    cmd->capabilities |= (1ULL << capability);
1036 1037 1038
}


1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057
/**
 * virCommandSetSELinuxLabel:
 * @cmd: the command to modify
 * @label: the SELinux label to use for the child process
 *
 * Saves a copy of @label to use when setting the SELinux context
 * label (with setexeccon_raw()) after the child process has been
 * started. If SELinux isn't compiled into libvirt, or if label is
 * NULL, nothing will be done.
 */
void
virCommandSetSELinuxLabel(virCommandPtr cmd,
                          const char *label ATTRIBUTE_UNUSED)
{
    if (!cmd || cmd->has_error)
        return;

#if defined(WITH_SECDRIVER_SELINUX)
    VIR_FREE(cmd->seLinuxLabel);
1058
    if (VIR_STRDUP_QUIET(cmd->seLinuxLabel, label) < 0)
1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082
        cmd->has_error = ENOMEM;
#endif
    return;
}


/**
 * virCommandSetAppArmorProfile:
 * @cmd: the command to modify
 * @profile: the AppArmor profile to use
 *
 * Saves a copy of @profile to use when aa_change_profile() after the
 * child process has been started. If AppArmor support isn't
 * configured into libvirt, or if profile is NULL, nothing will be done.
 */
void
virCommandSetAppArmorProfile(virCommandPtr cmd,
                             const char *profile ATTRIBUTE_UNUSED)
{
    if (!cmd || cmd->has_error)
        return;

#if defined(WITH_SECDRIVER_APPARMOR)
    VIR_FREE(cmd->appArmorProfile);
1083
    if (VIR_STRDUP_QUIET(cmd->appArmorProfile, profile) < 0)
1084 1085 1086 1087 1088
        cmd->has_error = ENOMEM;
#endif
    return;
}

1089

E
Eric Blake 已提交
1090 1091 1092 1093 1094 1095 1096
/**
 * virCommandDaemonize:
 * @cmd: the command to modify
 *
 * Daemonize the child process.  The child will have a current working
 * directory of /, and must be started with virCommandRun, which will
 * complete as soon as the daemon grandchild has started.
1097 1098 1099 1100 1101 1102 1103 1104 1105 1106
 */
void
virCommandDaemonize(virCommandPtr cmd)
{
    if (!cmd || cmd->has_error)
        return;

    cmd->flags |= VIR_EXEC_DAEMON;
}

E
Eric Blake 已提交
1107 1108 1109 1110
/**
 * virCommandNonblockingFDs:
 * @cmd: the command to modify
 *
1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122
 * Set FDs created by virCommandSetOutputFD and virCommandSetErrorFD
 * as non-blocking in the parent.
 */
void
virCommandNonblockingFDs(virCommandPtr cmd)
{
    if (!cmd || cmd->has_error)
        return;

    cmd->flags |= VIR_EXEC_NONBLOCK;
}

1123
/* Add an environment variable to the cmd->env list.  'env' is a
1124 1125
 * string like "name=value".  If the named environment variable is
 * already set, then it is replaced in the list.
1126 1127 1128 1129
 */
static inline void
virCommandAddEnv(virCommandPtr cmd, char *env)
{
1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143
    size_t namelen;
    size_t i;

    /* Search for the name in the existing environment. */
    namelen = strcspn(env, "=");
    for (i = 0; i < cmd->nenv; ++i) {
        /* + 1 because we want to match the '=' character too. */
        if (STREQLEN(cmd->env[i], env, namelen + 1)) {
            VIR_FREE(cmd->env[i]);
            cmd->env[i] = env;
            return;
        }
    }

1144 1145 1146 1147 1148 1149 1150 1151 1152 1153
    /* Arg plus trailing NULL. */
    if (VIR_RESIZE_N(cmd->env, cmd->maxenv, cmd->nenv, 1 + 1) < 0) {
        VIR_FREE(env);
        cmd->has_error = ENOMEM;
        return;
    }

    cmd->env[cmd->nenv++] = env;
}

E
Eric Blake 已提交
1154 1155 1156 1157 1158 1159 1160
/**
 * virCommandAddEnvFormat:
 * @cmd: the command to modify
 * @format: format of arguments, end result must be in name=value format
 * @...: arguments to be formatted
 *
 * Add an environment variable to the child created by a printf-style format.
1161 1162
 */
void
1163
virCommandAddEnvFormat(virCommandPtr cmd, const char *format, ...)
1164 1165
{
    char *env;
1166
    va_list list;
1167 1168 1169 1170

    if (!cmd || cmd->has_error)
        return;

1171 1172
    va_start(list, format);
    if (virVasprintf(&env, format, list) < 0) {
1173
        cmd->has_error = ENOMEM;
1174
        va_end(list);
1175 1176
        return;
    }
1177
    va_end(list);
1178

1179
    virCommandAddEnv(cmd, env);
1180 1181
}

E
Eric Blake 已提交
1182 1183 1184 1185 1186 1187
/**
 * virCommandAddEnvPair:
 * @cmd: the command to modify
 * @name: variable name, must not contain =
 * @value: value to assign to name
 *
1188 1189 1190 1191 1192 1193 1194 1195 1196
 * Add an environment variable to the child
 * using separate name & value strings
 */
void
virCommandAddEnvPair(virCommandPtr cmd, const char *name, const char *value)
{
    virCommandAddEnvFormat(cmd, "%s=%s", name, value);
}

1197

E
Eric Blake 已提交
1198 1199 1200 1201 1202
/**
 * virCommandAddEnvString:
 * @cmd: the command to modify
 * @str: name=value format
 *
1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213
 * Add an environment variable to the child
 * using a preformatted env string FOO=BAR
 */
void
virCommandAddEnvString(virCommandPtr cmd, const char *str)
{
    char *env;

    if (!cmd || cmd->has_error)
        return;

1214
    if (VIR_STRDUP_QUIET(env, str) < 0) {
1215 1216 1217 1218
        cmd->has_error = ENOMEM;
        return;
    }

1219
    virCommandAddEnv(cmd, env);
1220 1221 1222
}


E
Eric Blake 已提交
1223 1224 1225 1226 1227
/**
 * virCommandAddEnvBuffer:
 * @cmd: the command to modify
 * @buf: buffer that contains name=value string, which will be reset on return
 *
1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239
 * Convert a buffer containing preformatted name=value into an
 * environment variable of the child.
 * Correctly transfers memory errors or contents from buf to cmd.
 */
void
virCommandAddEnvBuffer(virCommandPtr cmd, virBufferPtr buf)
{
    if (!cmd || cmd->has_error) {
        virBufferFreeAndReset(buf);
        return;
    }

1240
    if (virBufferError(buf)) {
1241 1242 1243 1244
        cmd->has_error = ENOMEM;
        virBufferFreeAndReset(buf);
        return;
    }
1245 1246 1247 1248
    if (!virBufferUse(buf)) {
        cmd->has_error = EINVAL;
        return;
    }
1249

1250
    virCommandAddEnv(cmd, virBufferContentAndReset(buf));
1251 1252 1253
}


E
Eric Blake 已提交
1254
/**
1255
 * virCommandAddEnvPassAllowSUID:
E
Eric Blake 已提交
1256 1257 1258
 * @cmd: the command to modify
 * @name: the name to look up in current environment
 *
1259 1260
 * Pass an environment variable to the child
 * using current process' value
1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286
 *
 * Allow to be passed even if setuid
 */
void
virCommandAddEnvPassAllowSUID(virCommandPtr cmd, const char *name)
{
    const char *value;
    if (!cmd || cmd->has_error)
        return;

    value = virGetEnvAllowSUID(name);
    if (value)
        virCommandAddEnvPair(cmd, name, value);
}


/**
 * virCommandAddEnvPassBlockSUID:
 * @cmd: the command to modify
 * @name: the name to look up in current environment
 * @defvalue: value to return if running setuid, may be NULL
 *
 * Pass an environment variable to the child
 * using current process' value.
 *
 * Do not pass if running setuid
1287 1288
 */
void
1289
virCommandAddEnvPassBlockSUID(virCommandPtr cmd, const char *name, const char *defvalue)
1290
{
1291
    const char *value;
1292 1293 1294
    if (!cmd || cmd->has_error)
        return;

1295 1296 1297
    value = virGetEnvBlockSUID(name);
    if (!value)
        value = defvalue;
1298 1299 1300 1301 1302
    if (value)
        virCommandAddEnvPair(cmd, name, value);
}


E
Eric Blake 已提交
1303 1304 1305 1306
/**
 * virCommandAddEnvPassCommon:
 * @cmd: the command to modify
 *
1307
 * Set LC_ALL to C, and propagate other essential environment
E
Eric Blake 已提交
1308
 * variables (such as PATH) from the parent process.
1309 1310 1311 1312
 */
void
virCommandAddEnvPassCommon(virCommandPtr cmd)
{
1313 1314 1315
    if (!cmd || cmd->has_error)
        return;

1316 1317 1318 1319
    if (VIR_RESIZE_N(cmd->env, cmd->maxenv, cmd->nenv, 9) < 0) {
        cmd->has_error = ENOMEM;
        return;
    }
1320 1321 1322

    virCommandAddEnvPair(cmd, "LC_ALL", "C");

1323 1324 1325 1326 1327 1328 1329
    virCommandAddEnvPassBlockSUID(cmd, "LD_PRELOAD", NULL);
    virCommandAddEnvPassBlockSUID(cmd, "LD_LIBRARY_PATH", NULL);
    virCommandAddEnvPassBlockSUID(cmd, "PATH", "/bin:/usr/bin");
    virCommandAddEnvPassBlockSUID(cmd, "HOME", NULL);
    virCommandAddEnvPassAllowSUID(cmd, "USER");
    virCommandAddEnvPassAllowSUID(cmd, "LOGNAME");
    virCommandAddEnvPassBlockSUID(cmd, "TMPDIR", NULL);
1330 1331
}

E
Eric Blake 已提交
1332 1333 1334 1335 1336
/**
 * virCommandAddArg:
 * @cmd: the command to modify
 * @val: the argument to add
 *
1337 1338 1339 1340 1341 1342 1343 1344 1345 1346
 * Add a command line argument to the child
 */
void
virCommandAddArg(virCommandPtr cmd, const char *val)
{
    char *arg;

    if (!cmd || cmd->has_error)
        return;

1347
    if (VIR_STRDUP_QUIET(arg, val) < 0) {
1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362
        cmd->has_error = ENOMEM;
        return;
    }

    /* Arg plus trailing NULL. */
    if (VIR_RESIZE_N(cmd->args, cmd->maxargs, cmd->nargs, 1 + 1) < 0) {
        VIR_FREE(arg);
        cmd->has_error = ENOMEM;
        return;
    }

    cmd->args[cmd->nargs++] = arg;
}


E
Eric Blake 已提交
1363 1364 1365 1366 1367
/**
 * virCommandAddArgBuffer:
 * @cmd: the command to modify
 * @buf: buffer that contains argument string, which will be reset on return
 *
1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386
 * Convert a buffer into a command line argument to the child.
 * Correctly transfers memory errors or contents from buf to cmd.
 */
void
virCommandAddArgBuffer(virCommandPtr cmd, virBufferPtr buf)
{
    if (!cmd || cmd->has_error) {
        virBufferFreeAndReset(buf);
        return;
    }

    /* Arg plus trailing NULL. */
    if (virBufferError(buf) ||
        VIR_RESIZE_N(cmd->args, cmd->maxargs, cmd->nargs, 1 + 1) < 0) {
        cmd->has_error = ENOMEM;
        virBufferFreeAndReset(buf);
        return;
    }

1387 1388
    cmd->args[cmd->nargs] = virBufferContentAndReset(buf);
    if (!cmd->args[cmd->nargs]) {
1389 1390 1391 1392
        if (VIR_STRDUP_QUIET(cmd->args[cmd->nargs], "") < 0) {
            cmd->has_error = ENOMEM;
            return;
        }
1393 1394
    }
    cmd->nargs++;
1395 1396 1397
}


E
Eric Blake 已提交
1398 1399 1400 1401 1402 1403 1404
/**
 * virCommandAddArgFormat:
 * @cmd: the command to modify
 * @format: format of arguments, end result must be in name=value format
 * @...: arguments to be formatted
 *
 * Add a command line argument created by a printf-style format.
1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432
 */
void
virCommandAddArgFormat(virCommandPtr cmd, const char *format, ...)
{
    char *arg;
    va_list list;

    if (!cmd || cmd->has_error)
        return;

    va_start(list, format);
    if (virVasprintf(&arg, format, list) < 0) {
        cmd->has_error = ENOMEM;
        va_end(list);
        return;
    }
    va_end(list);

    /* Arg plus trailing NULL. */
    if (VIR_RESIZE_N(cmd->args, cmd->maxargs, cmd->nargs, 1 + 1) < 0) {
        VIR_FREE(arg);
        cmd->has_error = ENOMEM;
        return;
    }

    cmd->args[cmd->nargs++] = arg;
}

E
Eric Blake 已提交
1433 1434 1435 1436 1437 1438
/**
 * virCommandAddArgPair:
 * @cmd: the command to modify
 * @name: left half of argument
 * @value: right half of argument
 *
1439 1440 1441 1442 1443 1444 1445 1446
 * Add "NAME=VAL" as a single command line argument to the child
 */
void
virCommandAddArgPair(virCommandPtr cmd, const char *name, const char *val)
{
    virCommandAddArgFormat(cmd, "%s=%s", name, val);
}

E
Eric Blake 已提交
1447 1448 1449 1450 1451
/**
 * virCommandAddArgSet:
 * @cmd: the command to modify
 * @vals: array of arguments to add
 *
1452 1453 1454 1455 1456 1457 1458 1459 1460 1461
 * Add a NULL terminated list of args
 */
void
virCommandAddArgSet(virCommandPtr cmd, const char *const*vals)
{
    int narg = 0;

    if (!cmd || cmd->has_error)
        return;

1462 1463 1464 1465 1466
    if (vals[0] == NULL) {
        cmd->has_error = EINVAL;
        return;
    }

1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477
    while (vals[narg] != NULL)
        narg++;

    /* narg plus trailing NULL. */
    if (VIR_RESIZE_N(cmd->args, cmd->maxargs, cmd->nargs, narg + 1) < 0) {
        cmd->has_error = ENOMEM;
        return;
    }

    narg = 0;
    while (vals[narg] != NULL) {
1478 1479 1480
        char *arg;

        if (VIR_STRDUP_QUIET(arg, vals[narg++]) < 0) {
1481 1482 1483 1484 1485 1486 1487
            cmd->has_error = ENOMEM;
            return;
        }
        cmd->args[cmd->nargs++] = arg;
    }
}

E
Eric Blake 已提交
1488 1489 1490 1491 1492 1493
/**
 * virCommandAddArgList:
 * @cmd: the command to modify
 * @...: list of arguments to add
 *
 * Add a NULL terminated list of args.
1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519
 */
void
virCommandAddArgList(virCommandPtr cmd, ...)
{
    va_list list;
    int narg = 0;

    if (!cmd || cmd->has_error)
        return;

    va_start(list, cmd);
    while (va_arg(list, const char *) != NULL)
        narg++;
    va_end(list);

    /* narg plus trailing NULL. */
    if (VIR_RESIZE_N(cmd->args, cmd->maxargs, cmd->nargs, narg + 1) < 0) {
        cmd->has_error = ENOMEM;
        return;
    }

    va_start(list, cmd);
    while (1) {
        char *arg = va_arg(list, char *);
        if (!arg)
            break;
1520
        if (VIR_STRDUP_QUIET(arg, arg) < 0) {
1521 1522 1523 1524 1525 1526 1527 1528 1529
            cmd->has_error = ENOMEM;
            va_end(list);
            return;
        }
        cmd->args[cmd->nargs++] = arg;
    }
    va_end(list);
}

E
Eric Blake 已提交
1530 1531 1532 1533 1534
/**
 * virCommandSetWorkingDirectory:
 * @cmd: the command to modify
 * @pwd: directory to use
 *
1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546
 * Set the working directory of a non-daemon child process, rather
 * than the parent's working directory.  Daemons automatically get /
 * without using this call.
 */
void
virCommandSetWorkingDirectory(virCommandPtr cmd, const char *pwd)
{
    if (!cmd || cmd->has_error)
        return;

    if (cmd->pwd) {
        cmd->has_error = -1;
1547
        VIR_DEBUG("cannot set directory twice");
1548
    } else {
1549
        if (VIR_STRDUP_QUIET(cmd->pwd, pwd) < 0)
1550 1551 1552 1553 1554
            cmd->has_error = ENOMEM;
    }
}


E
Eric Blake 已提交
1555 1556 1557 1558 1559
/**
 * virCommandSetInputBuffer:
 * @cmd: the command to modify
 * @inbuf: string to feed to stdin
 *
1560 1561 1562
 * Feed the child's stdin from a string buffer.  This requires the
 * use of virCommandRun() or combination of virCommandDoAsyncIO and
 * virCommandRunAsync. The buffer is forgotten after each @cmd run.
1563 1564 1565 1566 1567 1568 1569 1570 1571
 */
void
virCommandSetInputBuffer(virCommandPtr cmd, const char *inbuf)
{
    if (!cmd || cmd->has_error)
        return;

    if (cmd->infd != -1 || cmd->inbuf) {
        cmd->has_error = -1;
1572
        VIR_DEBUG("cannot specify input twice");
1573 1574 1575
        return;
    }

1576
    if (VIR_STRDUP_QUIET(cmd->inbuf, inbuf) < 0)
1577 1578 1579 1580
        cmd->has_error = ENOMEM;
}


E
Eric Blake 已提交
1581 1582 1583 1584 1585
/**
 * virCommandSetOutputBuffer:
 * @cmd: the command to modify
 * @outbuf: address of variable to store malloced result buffer
 *
1586 1587 1588
 * Capture the child's stdout to a string buffer.  *outbuf is
 * guaranteed to be allocated after successful virCommandRun or
 * virCommandWait, and is best-effort allocated after failed
1589 1590 1591 1592
 * virCommandRun or virCommandRunAsync; caller is responsible for
 * freeing *outbuf. This requires the use of virCommandRun() or
 * combination of virCommandDoAsyncIO and virCommandRunAsync. The
 * buffer is forgotten after each @cmd run.
1593 1594 1595 1596
 */
void
virCommandSetOutputBuffer(virCommandPtr cmd, char **outbuf)
{
1597
    *outbuf = NULL;
1598 1599 1600 1601 1602
    if (!cmd || cmd->has_error)
        return;

    if (cmd->outfdptr) {
        cmd->has_error = -1;
1603
        VIR_DEBUG("cannot specify output twice");
1604 1605 1606 1607 1608 1609 1610 1611
        return;
    }

    cmd->outbuf = outbuf;
    cmd->outfdptr = &cmd->outfd;
}


E
Eric Blake 已提交
1612 1613 1614 1615 1616
/**
 * virCommandSetErrorBuffer:
 * @cmd: the command to modify
 * @errbuf: address of variable to store malloced result buffer
 *
1617 1618 1619
 * Capture the child's stderr to a string buffer.  *errbuf is
 * guaranteed to be allocated after successful virCommandRun or
 * virCommandWait, and is best-effort allocated after failed
1620 1621 1622 1623 1624 1625 1626
 * virCommandRun or virCommandRunAsync; caller is responsible for
 * freeing *errbuf. It is possible to pass the same pointer as
 * for virCommandSetOutputBuffer(), in which case the child
 * process will interleave all output into a single string.  This
 * requires the use of virCommandRun() or combination of
 * virCommandDoAsyncIO and virCommandRunAsync.The buffer is
 * forgotten after each @cmd run.
1627 1628 1629 1630
 */
void
virCommandSetErrorBuffer(virCommandPtr cmd, char **errbuf)
{
1631
    *errbuf = NULL;
1632 1633 1634 1635 1636
    if (!cmd || cmd->has_error)
        return;

    if (cmd->errfdptr) {
        cmd->has_error = -1;
1637
        VIR_DEBUG("cannot specify stderr twice");
1638 1639 1640 1641 1642 1643 1644 1645
        return;
    }

    cmd->errbuf = errbuf;
    cmd->errfdptr = &cmd->errfd;
}


E
Eric Blake 已提交
1646 1647 1648 1649 1650
/**
 * virCommandSetInputFD:
 * @cmd: the command to modify
 * @infd: the descriptor to use
 *
1651 1652 1653 1654 1655 1656 1657 1658 1659 1660
 * Attach a file descriptor to the child's stdin
 */
void
virCommandSetInputFD(virCommandPtr cmd, int infd)
{
    if (!cmd || cmd->has_error)
        return;

    if (cmd->infd != -1 || cmd->inbuf) {
        cmd->has_error = -1;
1661
        VIR_DEBUG("cannot specify input twice");
1662 1663 1664 1665
        return;
    }
    if (infd < 0) {
        cmd->has_error = -1;
1666
        VIR_DEBUG("cannot specify invalid input fd");
1667 1668 1669 1670 1671 1672 1673
        return;
    }

    cmd->infd = infd;
}


E
Eric Blake 已提交
1674 1675 1676 1677 1678 1679 1680 1681
/**
 * virCommandSetOutputFD:
 * @cmd: the command to modify
 * @outfd: location of output fd
 *
 * Attach a file descriptor to the child's stdout.  If *@outfd is -1 on
 * entry, then a pipe will be created and returned in this variable when
 * the child is run.  Otherwise, *@outfd is used as the output.
1682 1683 1684 1685 1686 1687 1688 1689 1690
 */
void
virCommandSetOutputFD(virCommandPtr cmd, int *outfd)
{
    if (!cmd || cmd->has_error)
        return;

    if (cmd->outfdptr) {
        cmd->has_error = -1;
1691
        VIR_DEBUG("cannot specify output twice");
1692 1693 1694 1695 1696 1697 1698
        return;
    }

    cmd->outfdptr = outfd;
}


E
Eric Blake 已提交
1699 1700 1701 1702 1703 1704 1705 1706 1707
/**
 * virCommandSetErrorFD:
 * @cmd: the command to modify
 * @errfd: location of error fd
 *
 * Attach a file descriptor to the child's stderr.  If *@errfd is -1 on
 * entry, then a pipe will be created and returned in this variable when
 * the child is run.  Otherwise, *@errfd is used for error collection,
 * and may be the same as outfd given to virCommandSetOutputFD().
1708 1709 1710 1711 1712 1713 1714 1715 1716
 */
void
virCommandSetErrorFD(virCommandPtr cmd, int *errfd)
{
    if (!cmd || cmd->has_error)
        return;

    if (cmd->errfdptr) {
        cmd->has_error = -1;
1717
        VIR_DEBUG("cannot specify stderr twice");
1718 1719 1720 1721 1722 1723 1724
        return;
    }

    cmd->errfdptr = errfd;
}


E
Eric Blake 已提交
1725 1726 1727 1728 1729 1730
/**
 * virCommandSetPreExecHook:
 * @cmd: the command to modify
 * @hook: the hook to run
 * @opaque: argument to pass to the hook
 *
1731 1732 1733
 * Run HOOK(OPAQUE) in the child as the last thing before changing
 * directories, dropping capabilities, and executing the new process.
 * Force the child to fail if HOOK does not return zero.
E
Eric Blake 已提交
1734 1735 1736
 *
 * Since @hook runs in the child, it should be careful to avoid
 * any functions that are not async-signal-safe.
1737 1738 1739 1740 1741 1742 1743 1744 1745
 */
void
virCommandSetPreExecHook(virCommandPtr cmd, virExecHook hook, void *opaque)
{
    if (!cmd || cmd->has_error)
        return;

    if (cmd->hook) {
        cmd->has_error = -1;
1746
        VIR_DEBUG("cannot specify hook twice");
1747 1748 1749 1750 1751 1752 1753
        return;
    }
    cmd->hook = hook;
    cmd->opaque = opaque;
}


E
Eric Blake 已提交
1754 1755 1756 1757 1758
/**
 * virCommandWriteArgLog:
 * @cmd: the command to log
 * @logfd: where to log the results
 *
1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774
 * Call after adding all arguments and environment settings, but before
 * Run/RunAsync, to immediately output the environment and arguments of
 * cmd to logfd.  If virCommandRun cannot succeed (because of an
 * out-of-memory condition while building cmd), nothing will be logged.
 */
void
virCommandWriteArgLog(virCommandPtr cmd, int logfd)
{
    int ioError = 0;
    size_t i;

    /* Any errors will be reported later by virCommandRun, which means
     * no command will be run, so there is nothing to log. */
    if (!cmd || cmd->has_error)
        return;

1775
    for (i = 0; i < cmd->nenv; i++) {
1776 1777 1778 1779 1780
        if (safewrite(logfd, cmd->env[i], strlen(cmd->env[i])) < 0)
            ioError = errno;
        if (safewrite(logfd, " ", 1) < 0)
            ioError = errno;
    }
1781
    for (i = 0; i < cmd->nargs; i++) {
1782 1783 1784 1785 1786 1787 1788 1789 1790
        if (safewrite(logfd, cmd->args[i], strlen(cmd->args[i])) < 0)
            ioError = errno;
        if (safewrite(logfd, i == cmd->nargs - 1 ? "\n" : " ", 1) < 0)
            ioError = errno;
    }

    if (ioError) {
        char ebuf[1024];
        VIR_WARN("Unable to write command %s args to logfile: %s",
1791
                 cmd->args[0], virStrerror(ioError, ebuf, sizeof(ebuf)));
1792 1793 1794 1795
    }
}


E
Eric Blake 已提交
1796 1797 1798 1799
/**
 * virCommandToString:
 * @cmd: the command to convert
 *
1800 1801 1802 1803
 * Call after adding all arguments and environment settings, but
 * before Run/RunAsync, to return a string representation of the
 * environment and arguments of cmd, suitably quoted for pasting into
 * a shell.  If virCommandRun cannot succeed (because of an
1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814
 * out-of-memory condition while building cmd), NULL will be returned.
 * Caller is responsible for freeing the resulting string.
 */
char *
virCommandToString(virCommandPtr cmd)
{
    size_t i;
    virBuffer buf = VIR_BUFFER_INITIALIZER;

    /* Cannot assume virCommandRun will be called; so report the error
     * now.  If virCommandRun is called, it will report the same error. */
1815 1816
    if (!cmd ||cmd->has_error == ENOMEM) {
        virReportOOMError();
1817 1818
        return NULL;
    }
1819
    if (cmd->has_error) {
1820 1821
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("invalid use of command API"));
1822 1823 1824 1825
        return NULL;
    }

    for (i = 0; i < cmd->nenv; i++) {
1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838
        /* In shell, a='b c' has a different meaning than 'a=b c', so
         * we must determine where the '=' lives.  */
        char *eq = strchr(cmd->env[i], '=');

        if (!eq) {
            virBufferFreeAndReset(&buf);
            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                           _("invalid use of command API"));
            return NULL;
        }
        eq++;
        virBufferAdd(&buf, cmd->env[i], eq - cmd->env[i]);
        virBufferEscapeShell(&buf, eq);
1839 1840
        virBufferAddChar(&buf, ' ');
    }
1841
    virBufferEscapeShell(&buf, cmd->args[0]);
1842 1843
    for (i = 1; i < cmd->nargs; i++) {
        virBufferAddChar(&buf, ' ');
1844
        virBufferEscapeShell(&buf, cmd->args[i]);
1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860
    }

    if (virBufferError(&buf)) {
        virBufferFreeAndReset(&buf);
        virReportOOMError();
        return NULL;
    }

    return virBufferContentAndReset(&buf);
}


/*
 * Manage input and output to the child process.
 */
static int
1861
virCommandProcessIO(virCommandPtr cmd)
1862
{
1863
    int outfd = -1, errfd = -1;
1864 1865
    size_t inlen = 0, outlen = 0, errlen = 0;
    size_t inoff = 0;
1866
    int ret = 0;
1867 1868 1869

    /* With an input buffer, feed data to child
     * via pipe */
1870
    if (cmd->inbuf)
1871 1872
        inlen = strlen(cmd->inbuf);

1873 1874 1875 1876 1877
    /* With out/err buffer, the outfd/errfd have been filled with an
     * FD for us.  Guarantee an allocated string with partial results
     * even if we encounter a later failure, as well as freeing any
     * results accumulated over a prior run of the same command.  */
    if (cmd->outbuf) {
1878
        outfd = cmd->outfd;
1879
        if (VIR_REALLOC_N(*cmd->outbuf, 1) < 0)
1880 1881 1882
            ret = -1;
    }
    if (cmd->errbuf) {
1883
        errfd = cmd->errfd;
1884
        if (VIR_REALLOC_N(*cmd->errbuf, 1) < 0)
1885 1886 1887 1888 1889
            ret = -1;
    }
    if (ret == -1)
        goto cleanup;
    ret = -1;
1890 1891

    for (;;) {
1892
        size_t i;
1893 1894 1895
        struct pollfd fds[3];
        int nfds = 0;

1896 1897
        if (cmd->inpipe != -1) {
            fds[nfds].fd = cmd->inpipe;
1898
            fds[nfds].events = POLLOUT;
1899
            fds[nfds].revents = 0;
1900 1901 1902 1903 1904
            nfds++;
        }
        if (outfd != -1) {
            fds[nfds].fd = outfd;
            fds[nfds].events = POLLIN;
1905
            fds[nfds].revents = 0;
1906 1907 1908 1909 1910
            nfds++;
        }
        if (errfd != -1) {
            fds[nfds].fd = errfd;
            fds[nfds].events = POLLIN;
1911
            fds[nfds].revents = 0;
1912 1913 1914 1915 1916 1917 1918
            nfds++;
        }

        if (nfds == 0)
            break;

        if (poll(fds, nfds, -1) < 0) {
1919
            if (errno == EAGAIN || errno == EINTR)
1920 1921 1922
                continue;
            virReportSystemError(errno, "%s",
                                 _("unable to poll on child"));
1923
            goto cleanup;
1924 1925
        }

1926
        for (i = 0; i < nfds; i++) {
1927
            if (fds[i].revents & (POLLIN | POLLHUP | POLLERR) &&
1928
                (fds[i].fd == errfd || fds[i].fd == outfd)) {
1929 1930 1931 1932 1933 1934 1935 1936 1937 1938 1939
                char data[1024];
                char **buf;
                size_t *len;
                int done;
                if (fds[i].fd == outfd) {
                    buf = cmd->outbuf;
                    len = &outlen;
                } else {
                    buf = cmd->errbuf;
                    len = &errlen;
                }
1940 1941
                /* Silence a false positive from clang. */
                sa_assert(buf);
1942 1943 1944 1945 1946 1947

                done = read(fds[i].fd, data, sizeof(data));
                if (done < 0) {
                    if (errno != EINTR &&
                        errno != EAGAIN) {
                        virReportSystemError(errno, "%s",
1948 1949 1950
                                             (fds[i].fd == outfd) ?
                                             _("unable to read child stdout") :
                                             _("unable to read child stderr"));
1951
                        goto cleanup;
1952 1953 1954 1955 1956 1957 1958
                    }
                } else if (done == 0) {
                    if (fds[i].fd == outfd)
                        outfd = -1;
                    else
                        errfd = -1;
                } else {
1959
                    if (VIR_REALLOC_N(*buf, *len + done + 1) < 0)
1960
                        goto cleanup;
1961 1962 1963
                    memcpy(*buf + *len, data, done);
                    *len += done;
                }
1964 1965
            }

1966
            if (fds[i].revents & (POLLOUT | POLLERR) &&
1967
                fds[i].fd == cmd->inpipe) {
1968 1969
                int done;

1970
                done = write(cmd->inpipe, cmd->inbuf + inoff,
1971 1972
                             inlen - inoff);
                if (done < 0) {
1973 1974
                    if (errno == EPIPE) {
                        VIR_DEBUG("child closed stdin early, ignoring EPIPE "
1975 1976
                                  "on fd %d", cmd->inpipe);
                        VIR_FORCE_CLOSE(cmd->inpipe);
1977
                    } else if (errno != EINTR && errno != EAGAIN) {
1978 1979
                        virReportSystemError(errno, "%s",
                                             _("unable to write to child input"));
1980
                        goto cleanup;
1981 1982 1983
                    }
                } else {
                    inoff += done;
1984 1985
                    if (inoff == inlen)
                        VIR_FORCE_CLOSE(cmd->inpipe);
1986 1987 1988 1989 1990
                }
            }
        }
    }

1991 1992
    ret = 0;
cleanup:
1993
    if (cmd->outbuf && *cmd->outbuf)
1994
        (*cmd->outbuf)[outlen] = '\0';
1995
    if (cmd->errbuf && *cmd->errbuf)
1996 1997
        (*cmd->errbuf)[errlen] = '\0';
    return ret;
1998 1999
}

E
Eric Blake 已提交
2000 2001 2002 2003
/**
 * virCommandExec:
 * @cmd: command to run
 *
2004
 * Exec the command, replacing the current process. Meant to be called
E
Eric Blake 已提交
2005 2006
 * in the hook after already forking / cloning, so does not attempt to
 * daemonize or preserve any FDs.
2007 2008 2009 2010
 *
 * Returns -1 on any error executing the command.
 * Will not return on success.
 */
2011
#ifndef WIN32
2012 2013 2014 2015 2016 2017 2018
int virCommandExec(virCommandPtr cmd)
{
    if (!cmd ||cmd->has_error == ENOMEM) {
        virReportOOMError();
        return -1;
    }
    if (cmd->has_error) {
2019 2020
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("invalid use of command API"));
2021 2022 2023 2024 2025
        return -1;
    }

    return execve(cmd->args[0], cmd->args, cmd->env);
}
2026 2027 2028 2029 2030 2031 2032 2033 2034 2035 2036 2037
#else
int virCommandExec(virCommandPtr cmd ATTRIBUTE_UNUSED)
{
    /* Mingw execve() has a broken signature. Disable this
     * function until gnulib fixes the signature, since we
     * don't really need this on Win32 anyway.
     */
    virReportSystemError(ENOSYS, "%s",
                         _("Executing new processes is not supported on Win32 platform"));
    return -1;
}
#endif
2038

E
Eric Blake 已提交
2039 2040 2041 2042 2043
/**
 * virCommandRun:
 * @cmd: command to run
 * @exitstatus: optional status collection
 *
2044 2045 2046
 * Run the command and wait for completion.
 * Returns -1 on any error executing the
 * command. Returns 0 if the command executed,
E
Eric Blake 已提交
2047 2048
 * with the exit status set.  If @exitstatus is NULL, then the
 * child must exit with status 0 for this to succeed.
2049 2050 2051 2052 2053 2054 2055
 */
int
virCommandRun(virCommandPtr cmd, int *exitstatus)
{
    int ret = 0;
    char *outbuf = NULL;
    char *errbuf = NULL;
2056 2057 2058
    struct stat st;
    bool string_io;
    bool async_io = false;
2059
    char *str;
2060
    int tmpfd;
2061

2062 2063
    if (!cmd ||cmd->has_error == ENOMEM) {
        virReportOOMError();
2064 2065
        return -1;
    }
2066
    if (cmd->has_error) {
2067 2068
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("invalid use of command API"));
2069 2070 2071
        return -1;
    }

2072 2073 2074 2075 2076 2077 2078 2079 2080 2081 2082 2083 2084 2085 2086 2087 2088
    /* Avoid deadlock, by requiring that any open fd not under our
     * control must be visiting a regular file, or that we are
     * daemonized and no string io is required.  */
    string_io = cmd->inbuf || cmd->outbuf || cmd->errbuf;
    if (cmd->infd != -1 &&
        (fstat(cmd->infd, &st) < 0 || !S_ISREG(st.st_mode)))
        async_io = true;
    if (cmd->outfdptr && cmd->outfdptr != &cmd->outfd &&
        (*cmd->outfdptr == -1 ||
         fstat(*cmd->outfdptr, &st) < 0 || !S_ISREG(st.st_mode)))
        async_io = true;
    if (cmd->errfdptr && cmd->errfdptr != &cmd->errfd &&
        (*cmd->errfdptr == -1 ||
         fstat(*cmd->errfdptr, &st) < 0 || !S_ISREG(st.st_mode)))
        async_io = true;
    if (async_io) {
        if (!(cmd->flags & VIR_EXEC_DAEMON) || string_io) {
2089 2090
            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                           _("cannot mix caller fds with blocking execution"));
2091 2092 2093 2094
            return -1;
        }
    } else {
        if ((cmd->flags & VIR_EXEC_DAEMON) && string_io) {
2095 2096
            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                           _("cannot mix string I/O with daemon"));
2097 2098 2099 2100
            return -1;
        }
    }

2101 2102 2103 2104 2105 2106 2107
    /* If caller requested the same string for stdout and stderr, then
     * merge those into one string.  */
    if (cmd->outbuf && cmd->outbuf == cmd->errbuf) {
        cmd->errfdptr = &cmd->outfd;
        cmd->errbuf = NULL;
    }

2108
    /* If caller hasn't requested capture of stdout/err, then capture
2109 2110 2111
     * it ourselves so we can log it.  But the intermediate child for
     * a daemon has no expected output, and we don't want our
     * capturing pipes passed on to the daemon grandchild.
2112
     */
2113 2114 2115 2116 2117 2118 2119 2120 2121 2122 2123
    if (!(cmd->flags & VIR_EXEC_DAEMON)) {
        if (!cmd->outfdptr) {
            cmd->outfdptr = &cmd->outfd;
            cmd->outbuf = &outbuf;
            string_io = true;
        }
        if (!cmd->errfdptr) {
            cmd->errfdptr = &cmd->errfd;
            cmd->errbuf = &errbuf;
            string_io = true;
        }
2124 2125
    }

2126
    cmd->flags |= VIR_EXEC_RUN_SYNC;
2127 2128 2129 2130 2131
    if (virCommandRunAsync(cmd, NULL) < 0) {
        cmd->has_error = -1;
        return -1;
    }

2132 2133 2134 2135
    if (string_io) {
        VIR_FORCE_CLOSE(cmd->infd);
        ret = virCommandProcessIO(cmd);
    }
2136 2137 2138 2139

    if (virCommandWait(cmd, exitstatus) < 0)
        ret = -1;

2140
    str = (exitstatus ? virProcessTranslateStatus(*exitstatus)
2141 2142 2143
           : (char *) "status 0");
    VIR_DEBUG("Result %s, stdout: '%s' stderr: '%s'",
              NULLSTR(str),
2144 2145
              cmd->outbuf ? NULLSTR(*cmd->outbuf) : "(null)",
              cmd->errbuf ? NULLSTR(*cmd->errbuf) : "(null)");
2146 2147
    if (exitstatus)
        VIR_FREE(str);
2148 2149 2150

    /* Reset any capturing, in case caller runs
     * this identical command again */
2151
    VIR_FORCE_CLOSE(cmd->inpipe);
2152
    if (cmd->outbuf == &outbuf) {
2153
        tmpfd = cmd->outfd;
2154 2155 2156 2157
        if (VIR_CLOSE(cmd->outfd) < 0)
            VIR_DEBUG("ignoring failed close on fd %d", tmpfd);
        cmd->outfdptr = NULL;
        cmd->outbuf = NULL;
E
Eric Blake 已提交
2158
        VIR_FREE(outbuf);
2159 2160
    }
    if (cmd->errbuf == &errbuf) {
2161
        tmpfd = cmd->errfd;
2162 2163 2164 2165
        if (VIR_CLOSE(cmd->errfd) < 0)
            VIR_DEBUG("ignoring failed close on fd %d", tmpfd);
        cmd->errfdptr = NULL;
        cmd->errbuf = NULL;
E
Eric Blake 已提交
2166
        VIR_FREE(errbuf);
2167 2168 2169 2170 2171 2172
    }

    return ret;
}


2173
static void
2174
virCommandDoAsyncIOHelper(void *opaque)
2175
{
2176 2177 2178 2179
    virCommandPtr cmd = opaque;
    if (virCommandProcessIO(cmd) < 0) {
        /* If something went wrong, save errno or -1*/
        cmd->has_error = errno ? errno : -1;
2180 2181 2182 2183
    }
}


E
Eric Blake 已提交
2184 2185 2186 2187 2188
/**
 * virCommandRunAsync:
 * @cmd: command to start
 * @pid: optional variable to track child pid
 *
2189 2190 2191
 * Run the command asynchronously
 * Returns -1 on any error executing the
 * command. Returns 0 if the command executed.
2192 2193 2194 2195 2196 2197 2198 2199 2200 2201
 *
 * There are two approaches to child process cleanup.
 * 1. Use auto-cleanup, by passing NULL for pid.  The child will be
 * auto-reaped by virCommandFree, unless you reap it earlier via
 * virCommandWait or virCommandAbort.  Good for where cmd is in
 * scope for the duration of the child process.
 * 2. Use manual cleanup, by passing the address of a pid_t variable
 * for pid.  While cmd is still in scope, you may reap the child via
 * virCommandWait or virCommandAbort.  But after virCommandFree, if
 * you have not yet reaped the child, then it continues to run until
2202
 * you call virProcessWait or virProcessAbort.
2203 2204 2205 2206
 */
int
virCommandRunAsync(virCommandPtr cmd, pid_t *pid)
{
2207
    int ret = -1;
2208
    char *str = NULL;
2209
    size_t i;
2210
    bool synchronous = false;
2211
    int infd[2] = {-1, -1};
2212

2213 2214
    if (!cmd || cmd->has_error == ENOMEM) {
        virReportOOMError();
2215 2216
        return -1;
    }
2217
    if (cmd->has_error) {
2218 2219
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("invalid use of command API"));
2220 2221 2222
        return -1;
    }

2223 2224 2225
    synchronous = cmd->flags & VIR_EXEC_RUN_SYNC;
    cmd->flags &= ~VIR_EXEC_RUN_SYNC;

2226 2227 2228 2229 2230 2231 2232 2233 2234
    /* Buffer management can only be requested via virCommandRun or
     * virCommandDoAsyncIO. */
    if (cmd->inbuf && cmd->infd == -1 &&
        (synchronous || cmd->flags & VIR_EXEC_ASYNC_IO)) {
        if (pipe2(infd, O_CLOEXEC) < 0) {
            virReportSystemError(errno, "%s",
                                 _("unable to open pipe"));
            cmd->has_error = -1;
            return -1;
2235
        }
2236 2237
        cmd->infd = infd[0];
        cmd->inpipe = infd[1];
2238
    } else if ((cmd->inbuf && cmd->infd == -1) ||
2239 2240
               (cmd->outbuf && cmd->outfdptr != &cmd->outfd) ||
               (cmd->errbuf && cmd->errfdptr != &cmd->errfd)) {
2241 2242
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("cannot mix string I/O with asynchronous command"));
2243 2244 2245
        return -1;
    }

2246
    if (cmd->pid != -1) {
2247 2248 2249
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("command is already running as pid %lld"),
                       (long long) cmd->pid);
2250
        goto cleanup;
2251 2252
    }

2253
    if (!synchronous && (cmd->flags & VIR_EXEC_DAEMON)) {
2254 2255
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("daemonized command cannot use virCommandRunAsync"));
2256
        goto cleanup;
2257
    }
2258
    if (cmd->pwd && (cmd->flags & VIR_EXEC_DAEMON)) {
2259 2260 2261
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("daemonized command cannot set working directory %s"),
                       cmd->pwd);
2262
        goto cleanup;
2263
    }
2264
    if (cmd->pidfile && !(cmd->flags & VIR_EXEC_DAEMON)) {
2265 2266
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("creation of pid file requires daemonized command"));
2267
        goto cleanup;
2268
    }
2269 2270

    str = virCommandToString(cmd);
2271 2272 2273 2274 2275 2276 2277 2278 2279 2280 2281 2282 2283
    if (dryRunBuffer) {
        if (!str) {
            /* error already reported by virCommandToString */
            goto cleanup;
        }

        VIR_DEBUG("Dry run requested, appending stringified "
                  "command to dryRunBuffer=%p", dryRunBuffer);
        virBufferAdd(dryRunBuffer, str, -1);
        virBufferAddChar(dryRunBuffer, '\n');
        ret = 0;
        goto cleanup;
    }
2284

2285
    VIR_DEBUG("About to run %s", str ? str : cmd->args[0]);
2286
    ret = virExec(cmd);
2287 2288 2289
    VIR_DEBUG("Command result %d, with PID %d",
              ret, (int)cmd->pid);

2290 2291 2292
    for (i = 0; i < cmd->npassfd; i++) {
        if (cmd->passfd[i].flags & VIR_COMMAND_PASS_FD_CLOSE_PARENT)
            VIR_FORCE_CLOSE(cmd->passfd[i].fd);
2293
    }
2294 2295
    cmd->npassfd = 0;
    VIR_FREE(cmd->passfd);
2296 2297 2298

    if (ret == 0 && pid)
        *pid = cmd->pid;
2299 2300
    else
        cmd->reap = true;
2301

2302
    if (ret == 0 && cmd->flags & VIR_EXEC_ASYNC_IO) {
2303
        if (cmd->inbuf)
2304
            VIR_FORCE_CLOSE(cmd->infd);
2305 2306 2307 2308 2309 2310 2311 2312 2313 2314 2315
        /* clear any error so we can catch if the helper thread reports one */
        cmd->has_error = 0;
        if (VIR_ALLOC(cmd->asyncioThread) < 0 ||
            virThreadCreate(cmd->asyncioThread, true,
                            virCommandDoAsyncIOHelper, cmd) < 0) {
            virReportSystemError(errno, "%s",
                                 _("Unable to create thread "
                                   "to process command's IO"));
            VIR_FREE(cmd->asyncioThread);
            virCommandAbort(cmd);
            ret = -1;
2316 2317 2318
        }
    }

2319 2320 2321 2322 2323
cleanup:
    if (ret < 0) {
        VIR_FORCE_CLOSE(cmd->infd);
        VIR_FORCE_CLOSE(cmd->inpipe);
    }
2324
    VIR_FREE(str);
2325 2326 2327 2328
    return ret;
}


E
Eric Blake 已提交
2329 2330 2331 2332 2333 2334 2335
/**
 * virCommandWait:
 * @cmd: command to wait on
 * @exitstatus: optional status collection
 *
 * Wait for the command previously started with virCommandRunAsync()
 * to complete. Return -1 on any error waiting for
2336
 * completion. Returns 0 if the command
E
Eric Blake 已提交
2337 2338
 * finished with the exit status set.  If @exitstatus is NULL, then the
 * child must exit with status 0 for this to succeed.
2339 2340 2341 2342 2343
 */
int
virCommandWait(virCommandPtr cmd, int *exitstatus)
{
    int ret;
2344
    int status = 0;
2345

2346 2347
    if (!cmd ||cmd->has_error == ENOMEM) {
        virReportOOMError();
2348 2349
        return -1;
    }
2350
    if (cmd->has_error) {
2351 2352
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("invalid use of command API"));
2353 2354 2355
        return -1;
    }

2356 2357 2358 2359 2360 2361 2362
    if (dryRunBuffer) {
        VIR_DEBUG("Dry run requested, claiming success");
        if (exitstatus)
            *exitstatus = 0;
        return 0;
    }

2363
    if (cmd->pid == -1) {
2364 2365
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("command is not yet running"));
2366 2367 2368
        return -1;
    }

2369
    /* If virProcessWait reaps pid but then returns failure because
2370 2371 2372
     * exitstatus was NULL, then a second virCommandWait would risk
     * calling waitpid on an unrelated process.  Besides, that error
     * message is not as detailed as what we can provide.  So, we
2373
     * guarantee that virProcessWait only fails due to failure to wait,
2374
     * and repeat the exitstatus check code ourselves.  */
2375
    ret = virProcessWait(cmd->pid, exitstatus ? exitstatus : &status);
2376 2377 2378 2379 2380 2381 2382 2383 2384 2385 2386 2387 2388
    if (cmd->flags & VIR_EXEC_ASYNC_IO) {
        cmd->flags &= ~VIR_EXEC_ASYNC_IO;
        virThreadJoin(cmd->asyncioThread);
        VIR_FREE(cmd->asyncioThread);
        VIR_FORCE_CLOSE(cmd->inpipe);
        if (cmd->has_error) {
            const char *msg = _("Error while processing command's IO");
            if (cmd->has_error < 0)
                virReportError(VIR_ERR_INTERNAL_ERROR, "%s", msg);
            else
                virReportSystemError(cmd->has_error, "%s", msg);
            ret = -1;
        }
2389
    }
2390 2391 2392 2393
    if (ret == 0) {
        cmd->pid = -1;
        cmd->reap = false;
        if (status) {
2394
            char *str = virCommandToString(cmd);
2395
            char *st = virProcessTranslateStatus(status);
2396 2397
            bool haveErrMsg = cmd->errbuf && *cmd->errbuf && (*cmd->errbuf)[0];

2398
            virReportError(VIR_ERR_INTERNAL_ERROR,
2399 2400 2401 2402
                           _("Child process (%s) unexpected %s%s%s"),
                           str ? str : cmd->args[0], NULLSTR(st),
                           haveErrMsg ? ": " : "",
                           haveErrMsg ? *cmd->errbuf : "");
2403
            VIR_FREE(str);
2404
            VIR_FREE(st);
2405 2406 2407 2408
            return -1;
        }
    }

2409
    return ret;
2410 2411 2412
}


E
Eric Blake 已提交
2413
#ifndef WIN32
E
Eric Blake 已提交
2414 2415 2416 2417
/**
 * virCommandAbort:
 * @cmd: command to abort
 *
2418 2419 2420 2421 2422 2423 2424 2425 2426 2427
 * Abort an async command if it is running, without issuing
 * any errors or affecting errno.  Designed for error paths
 * where some but not all paths to the cleanup code might
 * have started the child process.
 */
void
virCommandAbort(virCommandPtr cmd)
{
    if (!cmd || cmd->pid == -1)
        return;
2428
    virProcessAbort(cmd->pid);
2429 2430 2431
    cmd->pid = -1;
    cmd->reap = false;
}
E
Eric Blake 已提交
2432 2433 2434 2435 2436
#else /* WIN32 */
void
virCommandAbort(virCommandPtr cmd ATTRIBUTE_UNUSED)
{
    /* Mingw lacks WNOHANG and kill().  But since we haven't ported
2437
     * virExec to mingw yet, there's no process to be killed,
E
Eric Blake 已提交
2438 2439 2440
     * making this implementation trivially correct for now :)  */
}
#endif
2441

2442

E
Eric Blake 已提交
2443 2444 2445 2446 2447 2448 2449 2450 2451
/**
 * virCommandRequireHandshake:
 * @cmd: command to modify
 *
 * Request that the child perform a handshake with
 * the parent when the hook function has completed
 * execution. The child will not exec() until the
 * parent has notified
 */
2452 2453 2454 2455 2456 2457 2458 2459 2460 2461 2462
void virCommandRequireHandshake(virCommandPtr cmd)
{
    if (!cmd || cmd->has_error)
        return;

    if (cmd->handshake) {
        cmd->has_error = -1;
        VIR_DEBUG("Cannot require handshake twice");
        return;
    }

2463
    if (pipe2(cmd->handshakeWait, O_CLOEXEC) < 0) {
2464 2465 2466
        cmd->has_error = errno;
        return;
    }
2467
    if (pipe2(cmd->handshakeNotify, O_CLOEXEC) < 0) {
2468 2469 2470 2471 2472 2473
        VIR_FORCE_CLOSE(cmd->handshakeWait[0]);
        VIR_FORCE_CLOSE(cmd->handshakeWait[1]);
        cmd->has_error = errno;
        return;
    }

2474 2475 2476 2477
    VIR_DEBUG("Transfer handshake wait=%d notify=%d, "
              "keep handshake wait=%d notify=%d",
              cmd->handshakeWait[1], cmd->handshakeNotify[0],
              cmd->handshakeWait[0], cmd->handshakeNotify[1]);
2478 2479 2480 2481
    virCommandPassFD(cmd, cmd->handshakeWait[1],
                     VIR_COMMAND_PASS_FD_CLOSE_PARENT);
    virCommandPassFD(cmd, cmd->handshakeNotify[0],
                     VIR_COMMAND_PASS_FD_CLOSE_PARENT);
2482 2483 2484
    cmd->handshake = true;
}

E
Eric Blake 已提交
2485 2486 2487 2488 2489 2490 2491
/**
 * virCommandHandshakeWait:
 * @cmd: command to wait on
 *
 * Wait for the child to complete execution of its
 * hook function.  To be called in the parent.
 */
2492 2493 2494 2495 2496 2497 2498 2499 2500
int virCommandHandshakeWait(virCommandPtr cmd)
{
    char c;
    int rv;
    if (!cmd ||cmd->has_error == ENOMEM) {
        virReportOOMError();
        return -1;
    }
    if (cmd->has_error || !cmd->handshake) {
2501 2502
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("invalid use of command API"));
2503 2504 2505 2506
        return -1;
    }

    if (cmd->handshakeWait[0] == -1) {
2507 2508
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("Handshake is already complete"));
2509 2510 2511 2512 2513 2514
        return -1;
    }

    VIR_DEBUG("Wait for handshake on %d", cmd->handshakeWait[0]);
    if ((rv = saferead(cmd->handshakeWait[0], &c, sizeof(c))) != sizeof(c)) {
        if (rv < 0)
2515 2516
            virReportSystemError(errno, "%s",
                                 _("Unable to wait for child process"));
2517
        else
2518 2519
            virReportSystemError(EIO, "%s",
                                 _("Child quit during startup handshake"));
2520 2521 2522 2523 2524 2525 2526 2527 2528 2529
        VIR_FORCE_CLOSE(cmd->handshakeWait[0]);
        return -1;
    }
    if (c != '1') {
        char *msg;
        ssize_t len;
        if (VIR_ALLOC_N(msg, 1024) < 0) {
            VIR_FORCE_CLOSE(cmd->handshakeWait[0]);
            return -1;
        }
2530 2531 2532 2533 2534
        /* Close the handshakeNotify fd before trying to read anything
         * further on the handshakeWait pipe; so that a child waiting
         * on our acknowledgment will die rather than deadlock.  */
        VIR_FORCE_CLOSE(cmd->handshakeNotify[1]);

2535 2536 2537
        if ((len = saferead(cmd->handshakeWait[0], msg, 1024)) < 0) {
            VIR_FORCE_CLOSE(cmd->handshakeWait[0]);
            VIR_FREE(msg);
2538 2539
            virReportSystemError(errno, "%s",
                                 _("No error message from child failure"));
2540 2541 2542 2543
            return -1;
        }
        VIR_FORCE_CLOSE(cmd->handshakeWait[0]);
        msg[len-1] = '\0';
2544
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", msg);
2545 2546 2547 2548 2549 2550 2551
        VIR_FREE(msg);
        return -1;
    }
    VIR_FORCE_CLOSE(cmd->handshakeWait[0]);
    return 0;
}

E
Eric Blake 已提交
2552 2553 2554 2555 2556 2557 2558
/**
 * virCommandHandshakeNotify:
 * @cmd: command to resume
 *
 * Notify the child that it is OK to exec() the
 * real binary now.  To be called in the parent.
 */
2559 2560 2561 2562 2563 2564 2565 2566
int virCommandHandshakeNotify(virCommandPtr cmd)
{
    char c = '1';
    if (!cmd ||cmd->has_error == ENOMEM) {
        virReportOOMError();
        return -1;
    }
    if (cmd->has_error || !cmd->handshake) {
2567 2568
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("invalid use of command API"));
2569 2570 2571 2572
        return -1;
    }

    if (cmd->handshakeNotify[1] == -1) {
2573 2574
        virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                       _("Handshake is already complete"));
2575 2576 2577
        return -1;
    }

2578
    VIR_DEBUG("Notify handshake on %d", cmd->handshakeNotify[1]);
2579 2580 2581 2582 2583 2584 2585 2586 2587 2588
    if (safewrite(cmd->handshakeNotify[1], &c, sizeof(c)) != sizeof(c)) {
        virReportSystemError(errno, "%s", _("Unable to notify child process"));
        VIR_FORCE_CLOSE(cmd->handshakeNotify[1]);
        return -1;
    }
    VIR_FORCE_CLOSE(cmd->handshakeNotify[1]);
    return 0;
}


E
Eric Blake 已提交
2589 2590 2591 2592
/**
 * virCommandFree:
 * @cmd: optional command to free
 *
2593 2594
 * Release all resources.  The only exception is that if you called
 * virCommandRunAsync with a non-null pid, then the asynchronous child
2595
 * is not reaped, and you must call virProcessWait() or virProcessAbort() yourself.
2596 2597 2598 2599
 */
void
virCommandFree(virCommandPtr cmd)
{
2600
    size_t i;
2601 2602 2603
    if (!cmd)
        return;

2604 2605 2606
    for (i = 0; i < cmd->npassfd; i++) {
        if (cmd->passfd[i].flags & VIR_COMMAND_PASS_FD_CLOSE_PARENT)
            VIR_FORCE_CLOSE(cmd->passfd[i].fd);
2607
    }
2608 2609
    cmd->npassfd = 0;
    VIR_FREE(cmd->passfd);
2610

2611 2612 2613 2614
    if (cmd->asyncioThread) {
        virThreadJoin(cmd->asyncioThread);
        VIR_FREE(cmd->asyncioThread);
    }
E
Eric Blake 已提交
2615
    VIR_FREE(cmd->inbuf);
2616 2617 2618
    VIR_FORCE_CLOSE(cmd->outfd);
    VIR_FORCE_CLOSE(cmd->errfd);

2619
    for (i = 0; i < cmd->nargs; i++)
2620 2621 2622
        VIR_FREE(cmd->args[i]);
    VIR_FREE(cmd->args);

2623
    for (i = 0; i < cmd->nenv; i++)
2624 2625 2626 2627 2628
        VIR_FREE(cmd->env[i]);
    VIR_FREE(cmd->env);

    VIR_FREE(cmd->pwd);

2629 2630
    if (cmd->handshake) {
        /* The other 2 fds in these arrays are closed
2631
         * due to use with virCommandPassFD
2632 2633 2634 2635 2636
         */
        VIR_FORCE_CLOSE(cmd->handshakeWait[0]);
        VIR_FORCE_CLOSE(cmd->handshakeNotify[1]);
    }

2637 2638
    VIR_FREE(cmd->pidfile);

2639 2640 2641
    if (cmd->reap)
        virCommandAbort(cmd);

2642 2643 2644 2645 2646 2647
#if defined(WITH_SECDRIVER_SELINUX)
    VIR_FREE(cmd->seLinuxLabel);
#endif
#if defined(WITH_SECDRIVER_APPARMOR)
    VIR_FREE(cmd->appArmorProfile);
#endif
2648

2649 2650
    VIR_FREE(cmd);
}
2651 2652 2653 2654 2655 2656 2657 2658 2659 2660 2661 2662 2663 2664 2665 2666 2667 2668 2669 2670 2671 2672 2673 2674 2675 2676 2677 2678 2679 2680 2681 2682 2683 2684 2685 2686 2687 2688 2689 2690 2691 2692 2693 2694 2695 2696 2697

/**
 * virCommandDoAsyncIO:
 * @cmd: command to do async IO on
 *
 * This requests asynchronous string IO on @cmd. It is useful in
 * combination with virCommandRunAsync():
 *
 *      virCommandPtr cmd = virCommandNew*(...);
 *      char *buf = NULL;
 *
 *      ...
 *
 *      virCommandSetOutputBuffer(cmd, &buf);
 *      virCommandDoAsyncIO(cmd);
 *
 *      if (virCommandRunAsync(cmd, NULL) < 0)
 *          goto cleanup;
 *
 *      ...
 *
 *      if (virCommandWait(cmd, NULL) < 0)
 *          goto cleanup;
 *
 *      // @buf now contains @cmd's stdout
 *      VIR_DEBUG("STDOUT: %s", NULLSTR(buf));
 *
 *      ...
 *
 *  cleanup:
 *      VIR_FREE(buf);
 *      virCommandFree(cmd);
 *
 * The libvirt's event loop is used for handling stdios of @cmd.
 * Since current implementation uses strlen to determine length
 * of data to be written to @cmd's stdin, don't pass any binary
 * data. If you want to re-run command, you need to call this and
 * buffer setting functions (virCommandSet.*Buffer) prior each run.
 */
void
virCommandDoAsyncIO(virCommandPtr cmd)
{
   if (!cmd || cmd->has_error)
       return;

   cmd->flags |= VIR_EXEC_ASYNC_IO | VIR_EXEC_NONBLOCK;
}
2698 2699 2700 2701 2702 2703 2704 2705 2706 2707 2708 2709 2710 2711 2712 2713 2714 2715 2716 2717 2718 2719 2720 2721 2722 2723 2724 2725 2726 2727 2728 2729

/**
 * virCommandSetDryRun:
 * @buf: buffer to store stringified commands
 *
 * Sometimes it's desired to not actually run given command, but
 * see its string representation without having to change the
 * callee. Unit testing serves as a great example. In such cases,
 * the callee constructs the command and calls it via
 * virCommandRun* API. The virCommandSetDryRun allows you to
 * modify this behavior: once called, every call to
 * virCommandRun* results in command string representation being
 * appended to @buf instead of being executed. the strings are
 * escaped for a shell and separated by a newline. For example:
 *
 * virBuffer buffer = VIR_BUFFER_INITIALIZER;
 * virCommandSetDryRun(&buffer);
 *
 * virCommandPtr echocmd = virCommandNewArgList("/bin/echo", "Hello world", NULL);
 * virCommandRun(echocmd, NULL);
 *
 * After this, the @buffer should contain:
 *
 * /bin/echo 'Hello world'\n
 *
 * To cancel this effect pass NULL.
 */
void
virCommandSetDryRun(virBufferPtr buf)
{
    dryRunBuffer = buf;
}