lxc_controller.c 42.8 KB
Newer Older
1
/*
2 3
 * Copyright (C) 2010-2011 Red Hat, Inc.
 * Copyright IBM Corp. 2008
4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20
 *
 * lxc_controller.c: linux container process controller
 *
 * Authors:
 *  David L. Leskovec <dlesko at linux.vnet.ibm.com>
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
O
Osier Yang 已提交
21 22
 * License along with this library;  If not, see
 * <http://www.gnu.org/licenses/>.
23 24 25 26 27
 */

#include <config.h>

#include <sys/epoll.h>
28 29
#include <sys/wait.h>
#include <sys/socket.h>
30 31
#include <sys/types.h>
#include <sys/un.h>
32 33
#include <sys/utsname.h>
#include <sys/personality.h>
34
#include <unistd.h>
35
#include <paths.h>
36
#include <errno.h>
37 38
#include <fcntl.h>
#include <signal.h>
39
#include <getopt.h>
40
#include <sys/mount.h>
E
Eric Blake 已提交
41
#include <locale.h>
42 43
#include <grp.h>
#include <sys/stat.h>
44
#include <time.h>
45

D
Daniel P. Berrange 已提交
46
#if HAVE_CAPNG
47
# include <cap-ng.h>
D
Daniel P. Berrange 已提交
48 49
#endif

50 51 52 53 54
#if HAVE_NUMACTL
# define NUMA_VERSION1_COMPATIBILITY 1
# include <numa.h>
#endif

55
#include "virterror_internal.h"
56
#include "logging.h"
57 58 59
#include "util.h"

#include "lxc_conf.h"
60
#include "lxc_container.h"
61
#include "lxc_cgroup.h"
62 63
#include "virnetdev.h"
#include "virnetdevveth.h"
64 65
#include "memory.h"
#include "util.h"
E
Eric Blake 已提交
66
#include "virfile.h"
67
#include "virpidfile.h"
68
#include "command.h"
69 70
#include "processinfo.h"
#include "nodeinfo.h"
71
#include "virrandom.h"
72
#include "rpc/virnetserver.h"
73

74 75
#define VIR_FROM_THIS VIR_FROM_LXC

76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99
typedef struct _virLXCControllerConsole virLXCControllerConsole;
typedef virLXCControllerConsole *virLXCControllerConsolePtr;
struct _virLXCControllerConsole {
    int hostWatch;
    int hostFd;  /* PTY FD in the host OS */
    bool hostClosed;
    int hostEpoll;
    bool hostBlocking;

    int contWatch;
    int contFd;  /* PTY FD in the container */
    bool contClosed;
    int contEpoll;
    bool contBlocking;

    int epollWatch;
    int epollFd; /* epoll FD for dealing with EOF */

    size_t fromHostLen;
    char fromHostBuf[1024];
    size_t fromContLen;
    char fromContBuf[1024];
};

100 101 102 103 104
typedef struct _virLXCController virLXCController;
typedef virLXCController *virLXCControllerPtr;
struct _virLXCController {
    char *name;
    virDomainDefPtr def;
105

106 107
    int handshakeFd;

108 109
    pid_t initpid;

110 111
    size_t nveths;
    char **veths;
112 113 114

    size_t nconsoles;
    virLXCControllerConsolePtr consoles;
115
    char *devptmx;
116 117 118

    size_t nloopDevs;
    int *loopDevFds;
119 120

    virSecurityManagerPtr securityManager;
121

122 123
    /* Server socket */
    virNetServerPtr server;
124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165
};

static void virLXCControllerFree(virLXCControllerPtr ctrl);

static virLXCControllerPtr virLXCControllerNew(const char *name)
{
    virLXCControllerPtr ctrl = NULL;
    virCapsPtr caps = NULL;
    char *configFile = NULL;

    if (VIR_ALLOC(ctrl) < 0)
        goto no_memory;

    if (!(ctrl->name = strdup(name)))
        goto no_memory;

    if ((caps = lxcCapsInit(NULL)) == NULL)
        goto error;

    if ((configFile = virDomainConfigFile(LXC_STATE_DIR,
                                          ctrl->name)) == NULL)
        goto error;

    if ((ctrl->def = virDomainDefParseFile(caps,
                                           configFile,
                                           1 << VIR_DOMAIN_VIRT_LXC,
                                           0)) == NULL)
        goto error;

cleanup:
    VIR_FREE(configFile);
    virCapabilitiesFree(caps);
    return ctrl;

no_memory:
    virReportOOMError();
error:
    virLXCControllerFree(ctrl);
    ctrl = NULL;
    goto cleanup;
}

166

167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187
static int virLXCControllerCloseLoopDevices(virLXCControllerPtr ctrl,
                                            bool force)
{
    size_t i;

    for (i = 0 ; i < ctrl->nloopDevs ; i++) {
        if (force) {
            VIR_FORCE_CLOSE(ctrl->loopDevFds[i]);
        } else {
            if (VIR_CLOSE(ctrl->loopDevFds[i]) < 0) {
                virReportSystemError(errno, "%s",
                                     _("Unable to close loop device"));
                return -1;
            }
        }
    }

    return 0;
}


188 189 190 191 192
static void virLXCControllerStopInit(virLXCControllerPtr ctrl)
{
    if (ctrl->initpid == 0)
        return;

193
    virLXCControllerCloseLoopDevices(ctrl, true);
194 195 196 197 198
    virPidAbort(ctrl->initpid);
    ctrl->initpid = 0;
}


199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214
static void virLXCControllerConsoleClose(virLXCControllerConsolePtr console)
{
    if (console->hostWatch != -1)
        virEventRemoveHandle(console->hostWatch);
    VIR_FORCE_CLOSE(console->hostFd);

    if (console->contWatch != -1)
        virEventRemoveHandle(console->contWatch);
    VIR_FORCE_CLOSE(console->contFd);

    if (console->epollWatch != -1)
        virEventRemoveHandle(console->epollWatch);
    VIR_FORCE_CLOSE(console->epollFd);
}


215 216
static void virLXCControllerFree(virLXCControllerPtr ctrl)
{
217 218
    size_t i;

219 220 221
    if (!ctrl)
        return;

222 223
    virLXCControllerStopInit(ctrl);

224 225
    virSecurityManagerFree(ctrl->securityManager);

226 227 228 229
    for (i = 0 ; i < ctrl->nveths ; i++)
        VIR_FREE(ctrl->veths[i]);
    VIR_FREE(ctrl->veths);

230 231 232 233
    for (i = 0 ; i < ctrl->nconsoles ; i++)
        virLXCControllerConsoleClose(&(ctrl->consoles[i]));
    VIR_FREE(ctrl->consoles);

234 235
    VIR_FORCE_CLOSE(ctrl->handshakeFd);

236 237
    VIR_FREE(ctrl->devptmx);

238 239 240
    virDomainDefFree(ctrl->def);
    VIR_FREE(ctrl->name);

241
    virNetServerFree(ctrl->server);
242

243 244 245
    VIR_FREE(ctrl);
}

246

247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278
static int virLXCControllerAddConsole(virLXCControllerPtr ctrl,
                                      int hostFd)
{
    if (VIR_EXPAND_N(ctrl->consoles, ctrl->nconsoles, 1) < 0) {
        virReportOOMError();
        return -1;
    }
    ctrl->consoles[ctrl->nconsoles-1].hostFd = hostFd;
    ctrl->consoles[ctrl->nconsoles-1].hostWatch = -1;

    ctrl->consoles[ctrl->nconsoles-1].contFd = -1;
    ctrl->consoles[ctrl->nconsoles-1].contWatch = -1;

    ctrl->consoles[ctrl->nconsoles-1].epollFd = -1;
    ctrl->consoles[ctrl->nconsoles-1].epollWatch = -1;
    return 0;
}


static int virLXCControllerConsoleSetNonblocking(virLXCControllerConsolePtr console)
{
    if (virSetBlocking(console->hostFd, false) < 0 ||
        virSetBlocking(console->contFd, false) < 0) {
        virReportSystemError(errno, "%s",
                             _("Unable to set console file descriptor non-blocking"));
        return -1;
    }

    return 0;
}


279 280 281 282 283 284 285 286 287 288 289 290
static int virLXCControllerDaemonHandshake(virLXCControllerPtr ctrl)
{
    if (lxcContainerSendContinue(ctrl->handshakeFd) < 0) {
        virReportSystemError(errno, "%s",
                             _("error sending continue signal to daemon"));
        return -1;
    }
    VIR_FORCE_CLOSE(ctrl->handshakeFd);
    return 0;
}


291 292 293
static int virLXCControllerValidateNICs(virLXCControllerPtr ctrl)
{
    if (ctrl->def->nnets != ctrl->nveths) {
294 295 296
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("expecting %d veths, but got %zu"),
                       ctrl->def->nnets, ctrl->nveths);
297 298 299 300 301 302 303
        return -1;
    }

    return 0;
}


304 305 306
static int virLXCControllerValidateConsoles(virLXCControllerPtr ctrl)
{
    if (ctrl->def->nconsoles != ctrl->nconsoles) {
307 308 309
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("expecting %d consoles, but got %zu tty file handlers"),
                       ctrl->def->nconsoles, ctrl->nconsoles);
310 311 312 313 314 315 316
        return -1;
    }

    return 0;
}


317
static int virLXCControllerSetupLoopDevice(virDomainFSDefPtr fs)
318
{
319
    int lofd;
320 321
    char *loname = NULL;

322
    if ((lofd = virFileLoopDeviceAssociate(fs->src, &loname)) < 0)
323 324 325 326 327 328 329 330 331 332 333 334 335 336 337
        return -1;

    /*
     * We now change it into a block device type, so that
     * the rest of container setup 'just works'
     */
    fs->type = VIR_DOMAIN_FS_TYPE_BLOCK;
    VIR_FREE(fs->src);
    fs->src = loname;
    loname = NULL;

    return lofd;
}


338
static int virLXCControllerSetupLoopDevices(virLXCControllerPtr ctrl)
339 340 341 342
{
    size_t i;
    int ret = -1;

343
    for (i = 0 ; i < ctrl->def->nfss ; i++) {
344 345
        int fd;

346
        if (ctrl->def->fss[i]->type != VIR_DOMAIN_FS_TYPE_FILE)
347 348
            continue;

349
        fd = virLXCControllerSetupLoopDevice(ctrl->def->fss[i]);
350 351 352 353
        if (fd < 0)
            goto cleanup;

        VIR_DEBUG("Saving loop fd %d", fd);
354
        if (VIR_EXPAND_N(ctrl->loopDevFds, ctrl->nloopDevs, 1) < 0) {
355 356 357 358
            VIR_FORCE_CLOSE(fd);
            virReportOOMError();
            goto cleanup;
        }
359
        ctrl->loopDevFds[ctrl->nloopDevs - 1] = fd;
360 361 362 363 364 365 366 367 368
    }

    VIR_DEBUG("Setup all loop devices");
    ret = 0;

cleanup:
    return ret;
}

369
#if HAVE_NUMACTL
370
static int virLXCControllerSetupNUMAPolicy(virLXCControllerPtr ctrl)
371 372 373 374 375 376 377 378 379
{
    nodemask_t mask;
    int mode = -1;
    int node = -1;
    int ret = -1;
    int i = 0;
    int maxnode = 0;
    bool warned = false;

380
    if (!ctrl->def->numatune.memory.nodemask)
381 382 383 384 385
        return 0;

    VIR_DEBUG("Setting NUMA memory policy");

    if (numa_available() < 0) {
386 387
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                       "%s", _("Host kernel is not aware of NUMA."));
388 389 390 391 392 393 394 395
        return -1;
    }

    maxnode = numa_max_node() + 1;

    /* Convert nodemask to NUMA bitmask. */
    nodemask_zero(&mask);
    for (i = 0; i < VIR_DOMAIN_CPUMASK_LEN; i++) {
396
        if (ctrl->def->numatune.memory.nodemask[i]) {
397
            if (i > NUMA_NUM_NODES) {
398 399
                virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                               _("Host cannot support NUMA node %d"), i);
400 401 402 403 404 405 406 407 408 409 410
                return -1;
            }
            if (i > maxnode && !warned) {
                VIR_WARN("nodeset is out of range, there is only %d NUMA "
                         "nodes on host", maxnode);
                warned = true;
            }
            nodemask_set(&mask, i);
        }
    }

411
    mode = ctrl->def->numatune.memory.mode;
412 413 414 415 416 417 418 419 420 421 422 423 424 425 426

    if (mode == VIR_DOMAIN_NUMATUNE_MEM_STRICT) {
        numa_set_bind_policy(1);
        numa_set_membind(&mask);
        numa_set_bind_policy(0);
    } else if (mode == VIR_DOMAIN_NUMATUNE_MEM_PREFERRED) {
        int nnodes = 0;
        for (i = 0; i < NUMA_NUM_NODES; i++) {
            if (nodemask_isset(&mask, i)) {
                node = i;
                nnodes++;
            }
        }

        if (nnodes != 1) {
427 428 429
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                           "%s", _("NUMA memory tuning in 'preferred' mode "
                                   "only supports single node"));
430 431 432 433 434 435 436 437
            goto cleanup;
        }

        numa_set_bind_policy(0);
        numa_set_preferred(node);
    } else if (mode == VIR_DOMAIN_NUMATUNE_MEM_INTERLEAVE) {
        numa_set_interleave_mask(&mask);
    } else {
438 439 440
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                       _("Unable to set NUMA policy %s"),
                       virDomainNumatuneMemModeTypeToString(mode));
441 442 443 444 445 446 447 448 449
        goto cleanup;
    }

    ret = 0;

cleanup:
    return ret;
}
#else
450
static int virLXCControllerSetupNUMAPolicy(virLXCControllerPtr ctrl)
451
{
452
    if (ctrl->def->numatune.memory.nodemask) {
453 454
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("NUMA policy is not available on this platform"));
455 456 457 458 459 460 461
        return -1;
    }

    return 0;
}
#endif

462 463 464 465

/*
 * To be run while still single threaded
 */
466
static int virLXCControllerSetupCpuAffinity(virLXCControllerPtr ctrl)
467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489
{
    int i, hostcpus, maxcpu = CPU_SETSIZE;
    virNodeInfo nodeinfo;
    unsigned char *cpumap;
    int cpumaplen;

    VIR_DEBUG("Setting CPU affinity");

    if (nodeGetInfo(NULL, &nodeinfo) < 0)
        return -1;

    /* setaffinity fails if you set bits for CPUs which
     * aren't present, so we have to limit ourselves */
    hostcpus = VIR_NODEINFO_MAXCPUS(nodeinfo);
    if (maxcpu > hostcpus)
        maxcpu = hostcpus;

    cpumaplen = VIR_CPU_MAPLEN(maxcpu);
    if (VIR_ALLOC_N(cpumap, cpumaplen) < 0) {
        virReportOOMError();
        return -1;
    }

490
    if (ctrl->def->cpumask) {
491 492
        /* XXX why don't we keep 'cpumask' in the libvirt cpumap
         * format to start with ?!?! */
493 494
        for (i = 0 ; i < maxcpu && i < ctrl->def->cpumasklen ; i++)
            if (ctrl->def->cpumask[i])
495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519
                VIR_USE_CPU(cpumap, i);
    } else {
        /* You may think this is redundant, but we can't assume libvirtd
         * itself is running on all pCPUs, so we need to explicitly set
         * the spawned LXC instance to all pCPUs if no map is given in
         * its config file */
        for (i = 0 ; i < maxcpu ; i++)
            VIR_USE_CPU(cpumap, i);
    }

    /* We are pressuming we are running between fork/exec of LXC
     * so use '0' to indicate our own process ID. No threads are
     * running at this point
     */
    if (virProcessInfoSetAffinity(0, /* Self */
                                  cpumap, cpumaplen, maxcpu) < 0) {
        VIR_FREE(cpumap);
        return -1;
    }
    VIR_FREE(cpumap);

    return 0;
}


520
/**
521 522
 * virLXCControllerSetupResourceLimits
 * @ctrl: the controller state
523 524 525 526 527 528
 *
 * Creates a cgroup for the container, moves the task inside,
 * and sets resource limits
 *
 * Returns 0 on success or -1 in case of error
 */
529
static int virLXCControllerSetupResourceLimits(virLXCControllerPtr ctrl)
530 531
{

532
    if (virLXCControllerSetupCpuAffinity(ctrl) < 0)
533 534
        return -1;

535
    if (virLXCControllerSetupNUMAPolicy(ctrl) < 0)
536 537
        return -1;

538
    return virLXCCgroupSetup(ctrl->def);
D
Dan Smith 已提交
539 540
}

541

542 543 544 545 546 547 548
static int virLXCControllerClientHook(virNetServerPtr server ATTRIBUTE_UNUSED,
                                      virNetServerClientPtr client,
                                      void *opaque)
{
    virLXCControllerPtr ctrl = opaque;
    virNetServerClientSetPrivateData(client, ctrl, NULL);
    return 0;
549 550
}

551 552

static int virLXCControllerSetupServer(virLXCControllerPtr ctrl)
553
{
554 555
    virNetServerServicePtr svc = NULL;
    char *sockpath;
556

557 558 559 560
    if (virAsprintf(&sockpath, "%s/%s.sock",
                    LXC_STATE_DIR, ctrl->name) < 0) {
        virReportOOMError();
        return -1;
561 562
    }

563 564 565 566 567
    if (!(ctrl->server = virNetServerNew(0, 0, 0, 1,
                                         -1, 0, false,
                                         NULL,
                                         virLXCControllerClientHook,
                                         ctrl)))
C
Chris Lalancette 已提交
568
        goto error;
569

570 571 572 573 574 575 576
    if (!(svc = virNetServerServiceNewUNIX(sockpath,
                                           0700,
                                           0,
                                           0,
                                           false,
                                           5,
                                           NULL)))
577
        goto error;
578 579

    if (virNetServerAddService(ctrl->server, svc, NULL) < 0)
580
        goto error;
581 582
    virNetServerServiceFree(svc);
    svc = NULL;
583

584 585 586
    virNetServerUpdateServices(ctrl->server, true);
    VIR_FREE(sockpath);
    return 0;
587 588

error:
589 590 591 592
    VIR_FREE(sockpath);
    virNetServerFree(ctrl->server);
    ctrl->server = NULL;
    virNetServerServiceFree(svc);
593 594
    return -1;
}
595

D
Daniel P. Berrange 已提交
596 597 598 599 600 601 602 603 604

static int lxcControllerClearCapabilities(void)
{
#if HAVE_CAPNG
    int ret;

    capng_clear(CAPNG_SELECT_BOTH);

    if ((ret = capng_apply(CAPNG_SELECT_BOTH)) < 0) {
605 606
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("failed to apply capabilities: %d"), ret);
D
Daniel P. Berrange 已提交
607 608 609
        return -1;
    }
#else
610
    VIR_WARN("libcap-ng support not compiled in, unable to clear capabilities");
D
Daniel P. Berrange 已提交
611 612 613 614
#endif
    return 0;
}

615 616 617 618
static bool quit = false;
static virMutex lock;


619 620
static void virLXCControllerSignalChildIO(virNetServerPtr server ATTRIBUTE_UNUSED,
                                          siginfo_t *info ATTRIBUTE_UNUSED,
621
                                          void *opaque)
622
{
623
    virLXCControllerPtr ctrl = opaque;
624
    int ret;
625 626

    ret = waitpid(-1, NULL, WNOHANG);
627 628 629 630 631
    if (ret == ctrl->initpid) {
        virMutexLock(&lock);
        quit = true;
        virMutexUnlock(&lock);
    }
632 633 634
}


635
static void virLXCControllerConsoleUpdateWatch(virLXCControllerConsolePtr console)
636 637 638 639
{
    int hostEvents = 0;
    int contEvents = 0;

640
    if (!console->hostClosed || (!console->hostBlocking && console->fromContLen)) {
641 642 643 644 645
        if (console->fromHostLen < sizeof(console->fromHostBuf))
            hostEvents |= VIR_EVENT_HANDLE_READABLE;
        if (console->fromContLen)
            hostEvents |= VIR_EVENT_HANDLE_WRITABLE;
    }
646
    if (!console->contClosed || (!console->contBlocking && console->fromHostLen)) {
647 648 649 650 651 652
        if (console->fromContLen < sizeof(console->fromContBuf))
            contEvents |= VIR_EVENT_HANDLE_READABLE;
        if (console->fromHostLen)
            contEvents |= VIR_EVENT_HANDLE_WRITABLE;
    }

653 654 655
    VIR_DEBUG("Container watch %d=%d host watch %d=%d",
              console->contWatch, contEvents,
              console->hostWatch, hostEvents);
656 657
    virEventUpdateHandle(console->contWatch, contEvents);
    virEventUpdateHandle(console->hostWatch, hostEvents);
658

659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694
    if (console->hostClosed) {
        int events = EPOLLIN | EPOLLET;
        if (console->hostBlocking)
            events |= EPOLLOUT;

        if (events != console->hostEpoll) {
            struct epoll_event event;
            int action = EPOLL_CTL_ADD;
            if (console->hostEpoll)
                action = EPOLL_CTL_MOD;

            VIR_DEBUG("newHostEvents=%x oldHostEvents=%x", events, console->hostEpoll);

            event.events = events;
            event.data.fd = console->hostFd;
            if (epoll_ctl(console->epollFd, action, console->hostFd, &event) < 0) {
                VIR_DEBUG(":fail");
                virReportSystemError(errno, "%s",
                                     _("Unable to add epoll fd"));
                quit = true;
                goto cleanup;
            }
            console->hostEpoll = events;
            VIR_DEBUG("newHostEvents=%x oldHostEvents=%x", events, console->hostEpoll);
        }
    } else if (console->hostEpoll) {
        VIR_DEBUG("Stop epoll oldContEvents=%x", console->hostEpoll);
        if (epoll_ctl(console->epollFd, EPOLL_CTL_DEL, console->hostFd, NULL) < 0) {
            virReportSystemError(errno, "%s",
                                 _("Unable to remove epoll fd"));
                VIR_DEBUG(":fail");
            quit = true;
            goto cleanup;
        }
        console->hostEpoll = 0;
    }
695

696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734
    if (console->contClosed) {
        int events = EPOLLIN | EPOLLET;
        if (console->contBlocking)
            events |= EPOLLOUT;

        if (events != console->contEpoll) {
            struct epoll_event event;
            int action = EPOLL_CTL_ADD;
            if (console->contEpoll)
                action = EPOLL_CTL_MOD;

            VIR_DEBUG("newContEvents=%x oldContEvents=%x", events, console->contEpoll);

            event.events = events;
            event.data.fd = console->contFd;
            if (epoll_ctl(console->epollFd, action, console->contFd, &event) < 0) {
                virReportSystemError(errno, "%s",
                                     _("Unable to add epoll fd"));
                VIR_DEBUG(":fail");
                quit = true;
                goto cleanup;
            }
            console->contEpoll = events;
            VIR_DEBUG("newHostEvents=%x oldHostEvents=%x", events, console->contEpoll);
        }
    } else if (console->contEpoll) {
        VIR_DEBUG("Stop epoll oldContEvents=%x", console->contEpoll);
        if (epoll_ctl(console->epollFd, EPOLL_CTL_DEL, console->contFd, NULL) < 0) {
            virReportSystemError(errno, "%s",
                                 _("Unable to remove epoll fd"));
                VIR_DEBUG(":fail");
            quit = true;
            goto cleanup;
        }
        console->contEpoll = 0;
    }
cleanup:
    return;
}
735 736


737
static void virLXCControllerConsoleEPoll(int watch, int fd, int events, void *opaque)
738
{
739
    virLXCControllerConsolePtr console = opaque;
740

741 742 743 744 745 746 747 748 749 750
    virMutexLock(&lock);
    VIR_DEBUG("IO event watch=%d fd=%d events=%d fromHost=%zu fromcont=%zu",
              watch, fd, events,
              console->fromHostLen,
              console->fromContLen);

    while (1) {
        struct epoll_event event;
        int ret;
        ret = epoll_wait(console->epollFd, &event, 1, 0);
751
        if (ret < 0) {
S
Stefan Berger 已提交
752
            if (errno == EINTR)
753 754 755 756 757 758 759
                continue;
            virReportSystemError(errno, "%s",
                                 _("Unable to wait on epoll"));
            quit = true;
            goto cleanup;
        }

760 761 762 763 764 765 766
        if (ret == 0)
            break;

        VIR_DEBUG("fd=%d hostFd=%d contFd=%d hostEpoll=%x contEpoll=%x",
                  event.data.fd, console->hostFd, console->contFd,
                  console->hostEpoll, console->contEpoll);

767 768 769
        /* If we get HUP+dead PID, we just re-enable the main loop
         * which will see the PID has died and exit */
        if ((event.events & EPOLLIN)) {
770 771
            if (event.data.fd == console->hostFd) {
                console->hostClosed = false;
772
            } else {
773
                console->contClosed = false;
774
            }
775
            virLXCControllerConsoleUpdateWatch(console);
776 777 778 779 780
            break;
        }
    }

cleanup:
781
    virMutexUnlock(&lock);
782 783
}

784
static void virLXCControllerConsoleIO(int watch, int fd, int events, void *opaque)
785
{
786
    virLXCControllerConsolePtr console = opaque;
787 788

    virMutexLock(&lock);
789 790 791 792
    VIR_DEBUG("IO event watch=%d fd=%d events=%d fromHost=%zu fromcont=%zu",
              watch, fd, events,
              console->fromHostLen,
              console->fromContLen);
793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848
    if (events & VIR_EVENT_HANDLE_READABLE) {
        char *buf;
        size_t *len;
        size_t avail;
        ssize_t done;
        if (watch == console->hostWatch) {
            buf = console->fromHostBuf;
            len = &console->fromHostLen;
            avail = sizeof(console->fromHostBuf) - *len;
        } else {
            buf = console->fromContBuf;
            len = &console->fromContLen;
            avail = sizeof(console->fromContBuf) - *len;
        }
    reread:
        done = read(fd, buf + *len, avail);
        if (done == -1 && errno == EINTR)
            goto reread;
        if (done == -1 && errno != EAGAIN) {
            virReportSystemError(errno, "%s",
                                 _("Unable to read container pty"));
            goto error;
        }
        if (done > 0) {
            *len += done;
        } else {
            VIR_DEBUG("Read fd %d done %d errno %d", fd, (int)done, errno);
        }
    }

    if (events & VIR_EVENT_HANDLE_WRITABLE) {
        char *buf;
        size_t *len;
        ssize_t done;
        if (watch == console->hostWatch) {
            buf = console->fromContBuf;
            len = &console->fromContLen;
        } else {
            buf = console->fromHostBuf;
            len = &console->fromHostLen;
        }

    rewrite:
        done = write(fd, buf, *len);
        if (done == -1 && errno == EINTR)
            goto rewrite;
        if (done == -1 && errno != EAGAIN) {
            virReportSystemError(errno, "%s",
                                 _("Unable to write to container pty"));
            goto error;
        }
        if (done > 0) {
            memmove(buf, buf + done, (*len - done));
            *len -= done;
        } else {
            VIR_DEBUG("Write fd %d done %d errno %d", fd, (int)done, errno);
849 850 851 852
            if (watch == console->hostWatch)
                console->hostBlocking = true;
            else
                console->contBlocking = true;
853 854 855 856 857 858 859 860 861 862 863 864
        }
    }

    if (events & VIR_EVENT_HANDLE_HANGUP) {
        if (watch == console->hostWatch) {
            console->hostClosed = true;
        } else {
            console->contClosed = true;
        }
        VIR_DEBUG("Got EOF on %d %d", watch, fd);
    }

865
    virLXCControllerConsoleUpdateWatch(console);
866 867 868 869 870 871 872 873 874 875 876 877
    virMutexUnlock(&lock);
    return;

error:
    virEventRemoveHandle(console->contWatch);
    virEventRemoveHandle(console->hostWatch);
    console->contWatch = console->hostWatch = -1;
    quit = true;
    virMutexUnlock(&lock);
}


878
/**
879
 * lxcControllerMain
880 881
 * @serverFd: server socket fd to accept client requests
 * @clientFd: initial client which is the libvirtd daemon
882
 *
883
 * Processes I/O on consoles and the monitor
884 885 886
 *
 * Returns 0 on success or -1 in case of error
 */
887
static int virLXCControllerMain(virLXCControllerPtr ctrl)
888
{
889
    virErrorPtr err;
890
    int rc = -1;
891
    size_t i;
892 893 894 895

    if (virMutexInit(&lock) < 0)
        goto cleanup2;

896 897 898 899
    if (virNetServerAddSignalHandler(ctrl->server,
                                     SIGCHLD,
                                     virLXCControllerSignalChildIO,
                                     ctrl) < 0)
900 901
        goto cleanup;

902 903
    virResetLastError();

904 905
    for (i = 0 ; i < ctrl->nconsoles ; i++) {
        if ((ctrl->consoles[i].epollFd = epoll_create1(EPOLL_CLOEXEC)) < 0) {
906 907 908 909 910
            virReportSystemError(errno, "%s",
                                 _("Unable to create epoll fd"));
            goto cleanup;
        }

911 912 913 914 915
        if ((ctrl->consoles[i].epollWatch = virEventAddHandle(ctrl->consoles[i].epollFd,
                                                              VIR_EVENT_HANDLE_READABLE,
                                                              virLXCControllerConsoleEPoll,
                                                              &(ctrl->consoles[i]),
                                                              NULL)) < 0) {
916 917
            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                           _("Unable to watch epoll FD"));
918 919 920
            goto cleanup;
        }

921 922 923 924 925
        if ((ctrl->consoles[i].hostWatch = virEventAddHandle(ctrl->consoles[i].hostFd,
                                                             VIR_EVENT_HANDLE_READABLE,
                                                             virLXCControllerConsoleIO,
                                                             &(ctrl->consoles[i]),
                                                             NULL)) < 0) {
926 927
            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                           _("Unable to watch host console PTY"));
928 929 930
            goto cleanup;
        }

931 932 933 934 935
        if ((ctrl->consoles[i].contWatch = virEventAddHandle(ctrl->consoles[i].contFd,
                                                             VIR_EVENT_HANDLE_READABLE,
                                                             virLXCControllerConsoleIO,
                                                             &(ctrl->consoles[i]),
                                                             NULL)) < 0) {
936 937
            virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
                           _("Unable to watch host console PTY"));
938 939
            goto cleanup;
        }
940
    }
941

942 943 944 945
    virMutexLock(&lock);
    while (!quit) {
        virMutexUnlock(&lock);
        if (virEventRunDefaultImpl() < 0)
946
            goto cleanup;
947
        virMutexLock(&lock);
948
    }
949
    virMutexUnlock(&lock);
950

951 952 953
    err = virGetLastError();
    if (!err || err->code == VIR_ERR_OK)
        rc = 0;
954 955

cleanup:
956 957
    virMutexDestroy(&lock);
cleanup2:
958

959 960
    for (i = 0 ; i < ctrl->nconsoles ; i++)
        virLXCControllerConsoleClose(&(ctrl->consoles[i]));
961

962 963 964
    return rc;
}

965 966 967


/**
968
 * virLXCControllerMoveInterfaces
969 970 971 972 973 974 975 976
 * @nveths: number of interfaces
 * @veths: interface names
 * @container: pid of container
 *
 * Moves network interfaces into a container's namespace
 *
 * Returns 0 on success or -1 in case of error
 */
977
static int virLXCControllerMoveInterfaces(virLXCControllerPtr ctrl)
978
{
979 980 981
    size_t i;

    for (i = 0 ; i < ctrl->nveths ; i++) {
982
        if (virNetDevSetNamespace(ctrl->veths[i], ctrl->initpid) < 0)
983
            return -1;
984
    }
985 986 987 988 989 990

    return 0;
}


/**
991 992
 * virLXCControllerDeleteInterfaces:
 * @ctrl: the LXC controller
993 994 995 996 997
 *
 * Cleans up the container interfaces by deleting the veth device pairs.
 *
 * Returns 0 on success or -1 in case of error
 */
998
static int virLXCControllerDeleteInterfaces(virLXCControllerPtr ctrl)
999
{
1000 1001
    size_t i;
    int ret = 0;
1002

1003 1004 1005 1006 1007 1008
    for (i = 0 ; i < ctrl->nveths ; i++) {
        if (virNetDevVethDelete(ctrl->veths[i]) < 0)
            ret = -1;
    }

    return ret;
1009 1010
}

1011

1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030
static int lxcSetPersonality(virDomainDefPtr def)
{
    struct utsname utsname;
    const char *altArch;

    uname(&utsname);

    altArch = lxcContainerGetAlt32bitArch(utsname.machine);
    if (altArch &&
        STREQ(def->os.arch, altArch)) {
        if (personality(PER_LINUX32) < 0) {
            virReportSystemError(errno, _("Unable to request personality for %s on %s"),
                                 altArch, utsname.machine);
            return -1;
        }
    }
    return 0;
}

1031
#ifndef MS_REC
1032
# define MS_REC          16384
1033 1034 1035
#endif

#ifndef MS_SLAVE
1036
# define MS_SLAVE              (1<<19)
1037
#endif
1038

1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082
/* Create a private tty using the private devpts at PTMX, returning
 * the master in *TTYMASTER and the name of the slave, _from the
 * perspective of the guest after remounting file systems_, in
 * *TTYNAME.  Heavily borrowed from glibc, but doesn't require that
 * devpts == "/dev/pts" */
static int
lxcCreateTty(char *ptmx, int *ttymaster, char **ttyName)
{
    int ret = -1;
    int ptyno;
    int unlock = 0;

    if ((*ttymaster = open(ptmx, O_RDWR|O_NOCTTY|O_NONBLOCK)) < 0)
        goto cleanup;

    if (ioctl(*ttymaster, TIOCSPTLCK, &unlock) < 0)
        goto cleanup;

    if (ioctl(*ttymaster, TIOCGPTN, &ptyno) < 0)
        goto cleanup;

    /* If mount() succeeded at honoring newinstance, then the kernel
     * was new enough to also honor the mode=0620,gid=5 options, which
     * guarantee that the new pty already has correct permissions; so
     * while glibc has to fstat(), fchmod(), and fchown() for older
     * kernels, we can skip those steps.  ptyno shouldn't currently be
     * anything other than 0, but let's play it safe.  */
    if (virAsprintf(ttyName, "/dev/pts/%d", ptyno) < 0) {
        virReportOOMError();
        errno = ENOMEM;
        goto cleanup;
    }

    ret = 0;

cleanup:
    if (ret != 0) {
        VIR_FORCE_CLOSE(*ttymaster);
        VIR_FREE(*ttyName);
    }

    return ret;
}

1083

1084
static int
1085
virLXCControllerSetupDevPTS(virLXCControllerPtr ctrl)
1086
{
1087
    virDomainFSDefPtr root = virDomainGetRootFilesystem(ctrl->def);
1088
    char *mount_options = NULL;
1089 1090 1091
    char *opts;
    char *devpts = NULL;
    int ret = -1;
1092

1093 1094
    if (!root) {
        if (ctrl->nconsoles != 1) {
1095 1096 1097
            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                           _("Expected exactly one console, but got %zu"),
                           ctrl->nconsoles);
1098 1099 1100
            return -1;
        }
        return 0;
1101 1102
    }

1103
    VIR_DEBUG("Setting up private /dev/pts");
1104

1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124
    /*
     * If doing a chroot style setup, we need to prepare
     * a private /dev/pts for the child now, which they
     * will later move into position.
     *
     * This is complex because 'virsh console' needs to
     * use /dev/pts from the host OS, and the guest OS
     * needs to use /dev/pts from the guest.
     *
     * This means that we (libvirt_lxc) need to see and
     * use both /dev/pts instances. We're running in the
     * host OS context though and don't want to expose
     * the guest OS /dev/pts there.
     *
     * Thus we call unshare(CLONE_NS) so that we can see
     * the guest's new /dev/pts, without it becoming
     * visible to the host OS. We also put the root FS
     * into slave mode, just in case it was currently
     * marked as shared
     */
1125 1126
    mount_options = virSecurityManagerGetMountOptions(ctrl->securityManager,
                                                      ctrl->def);
1127

1128 1129 1130 1131 1132 1133
    if (!virFileExists(root->src)) {
        virReportSystemError(errno,
                             _("root source %s does not exist"),
                             root->src);
        goto cleanup;
    }
1134

1135 1136 1137 1138 1139
    if (unshare(CLONE_NEWNS) < 0) {
        virReportSystemError(errno, "%s",
                             _("Cannot unshare mount namespace"));
        goto cleanup;
    }
1140

1141 1142 1143 1144 1145
    if (mount("", "/", NULL, MS_SLAVE|MS_REC, NULL) < 0) {
        virReportSystemError(errno, "%s",
                             _("Failed to switch root mount into slave mode"));
        goto cleanup;
    }
1146

1147 1148 1149 1150 1151
    if (virAsprintf(&devpts, "%s/dev/pts", root->src) < 0 ||
        virAsprintf(&ctrl->devptmx, "%s/dev/pts/ptmx", root->src) < 0) {
        virReportOOMError();
        goto cleanup;
    }
1152

1153 1154 1155 1156 1157 1158
    if (virFileMakePath(devpts) < 0) {
        virReportSystemError(errno,
                             _("Failed to make path %s"),
                             devpts);
        goto cleanup;
    }
1159

1160 1161 1162 1163 1164 1165 1166
    /* XXX should we support gid=X for X!=5 for distros which use
     * a different gid for tty?  */
    if (virAsprintf(&opts, "newinstance,ptmxmode=0666,mode=0620,gid=5%s",
                    (mount_options ? mount_options : "")) < 0) {
        virReportOOMError();
        goto cleanup;
    }
1167

1168 1169 1170 1171 1172 1173 1174 1175
    VIR_DEBUG("Mount devpts on %s type=tmpfs flags=%x, opts=%s",
              devpts, MS_NOSUID, opts);
    if (mount("devpts", devpts, "devpts", MS_NOSUID, opts) < 0) {
        virReportSystemError(errno,
                             _("Failed to mount devpts on %s"),
                             devpts);
        goto cleanup;
    }
1176

1177 1178 1179
    if (access(ctrl->devptmx, R_OK) < 0) {
        VIR_WARN("Kernel does not support private devpts, using shared devpts");
        VIR_FREE(ctrl->devptmx);
1180 1181
    }

1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196
    ret = 0;

cleanup:
    VIR_FREE(opts);
    VIR_FREE(devpts);
    return ret;
}


static int
virLXCControllerSetupConsoles(virLXCControllerPtr ctrl,
                              char **containerTTYPaths)
{
    size_t i;

1197
    for (i = 0 ; i < ctrl->nconsoles ; i++) {
1198 1199 1200
        if (ctrl->devptmx) {
            VIR_DEBUG("Opening tty on private %s", ctrl->devptmx);
            if (lxcCreateTty(ctrl->devptmx,
1201 1202
                             &ctrl->consoles[i].contFd,
                             &containerTTYPaths[i]) < 0) {
1203 1204
                virReportSystemError(errno, "%s",
                                     _("Failed to allocate tty"));
1205
                return -1;
1206 1207 1208
            }
        } else {
            VIR_DEBUG("Opening tty on shared /dev/ptmx");
1209 1210
            if (virFileOpenTty(&ctrl->consoles[i].contFd,
                               &containerTTYPaths[i],
1211 1212 1213
                               0) < 0) {
                virReportSystemError(errno, "%s",
                                     _("Failed to allocate tty"));
1214
                return -1;
1215 1216 1217
            }
        }
    }
1218 1219 1220 1221 1222
    return 0;
}


static int
1223
virLXCControllerRun(virLXCControllerPtr ctrl)
1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250
{
    int rc = -1;
    int control[2] = { -1, -1};
    int containerhandshake[2] = { -1, -1 };
    char **containerTTYPaths = NULL;
    size_t i;

    if (VIR_ALLOC_N(containerTTYPaths, ctrl->nconsoles) < 0) {
        virReportOOMError();
        goto cleanup;
    }

    if (socketpair(PF_UNIX, SOCK_STREAM, 0, control) < 0) {
        virReportSystemError(errno, "%s",
                             _("sockpair failed"));
        goto cleanup;
    }

    if (socketpair(PF_UNIX, SOCK_STREAM, 0, containerhandshake) < 0) {
        virReportSystemError(errno, "%s",
                             _("socketpair failed"));
        goto cleanup;
    }

    if (virLXCControllerSetupLoopDevices(ctrl) < 0)
        goto cleanup;

1251
    if (virLXCControllerSetupResourceLimits(ctrl) < 0)
1252 1253 1254 1255 1256 1257 1258
        goto cleanup;

    if (virLXCControllerSetupDevPTS(ctrl) < 0)
        goto cleanup;

    if (virLXCControllerSetupConsoles(ctrl, containerTTYPaths) < 0)
        goto cleanup;
1259

1260
    if (lxcSetPersonality(ctrl->def) < 0)
1261
        goto cleanup;
1262

1263
    if ((ctrl->initpid = lxcContainerStart(ctrl->def,
1264
                                           ctrl->securityManager,
1265 1266 1267 1268
                                           ctrl->nveths,
                                           ctrl->veths,
                                           control[1],
                                           containerhandshake[1],
1269 1270
                                           containerTTYPaths,
                                           ctrl->nconsoles)) < 0)
1271
        goto cleanup;
1272
    VIR_FORCE_CLOSE(control[1]);
1273
    VIR_FORCE_CLOSE(containerhandshake[1]);
1274

1275
    if (virLXCControllerMoveInterfaces(ctrl) < 0)
1276 1277
        goto cleanup;

1278 1279 1280
    if (lxcContainerSendContinue(control[0]) < 0) {
        virReportSystemError(errno, "%s",
                             _("Unable to send container continue message"));
1281
        goto cleanup;
1282
    }
1283

1284 1285 1286 1287 1288 1289
    if (lxcContainerWaitForContinue(containerhandshake[0]) < 0) {
        virReportSystemError(errno, "%s",
                             _("error receiving signal from container"));
        goto cleanup;
    }

1290 1291 1292
    /* Now the container is fully setup... */

    /* ...we can close the loop devices... */
1293 1294
    if (virLXCControllerCloseLoopDevices(ctrl, false) < 0)
        goto cleanup;
1295 1296

    /* ...and reduce our privileges */
D
Daniel P. Berrange 已提交
1297 1298 1299
    if (lxcControllerClearCapabilities() < 0)
        goto cleanup;

1300
    if (virLXCControllerDaemonHandshake(ctrl) < 0)
1301 1302
        goto cleanup;

1303 1304
    for (i = 0 ; i < ctrl->nconsoles ; i++)
        if (virLXCControllerConsoleSetNonblocking(&(ctrl->consoles[i])) < 0)
1305
            goto cleanup;
1306

1307
    rc = virLXCControllerMain(ctrl);
1308 1309

cleanup:
1310 1311
    VIR_FORCE_CLOSE(control[0]);
    VIR_FORCE_CLOSE(control[1]);
1312 1313
    VIR_FORCE_CLOSE(containerhandshake[0]);
    VIR_FORCE_CLOSE(containerhandshake[1]);
1314

1315 1316 1317
    for (i = 0 ; i < ctrl->nconsoles ; i++)
        VIR_FREE(containerTTYPaths[i]);
    VIR_FREE(containerTTYPaths);
1318

1319
    virLXCControllerStopInit(ctrl);
1320

1321 1322 1323 1324
    return rc;
}


1325
int main(int argc, char *argv[])
1326 1327
{
    pid_t pid;
1328 1329
    int rc = 1;
    char *name = NULL;
1330
    size_t nveths = 0;
1331
    char **veths = NULL;
1332
    int handshakeFd = -1;
1333
    int bg = 0;
1334
    const struct option options[] = {
1335 1336 1337 1338
        { "background", 0, NULL, 'b' },
        { "name",   1, NULL, 'n' },
        { "veth",   1, NULL, 'v' },
        { "console", 1, NULL, 'c' },
1339
        { "handshakefd", 1, NULL, 's' },
1340
        { "security", 1, NULL, 'S' },
1341 1342 1343
        { "help", 0, NULL, 'h' },
        { 0, 0, 0, 0 },
    };
1344 1345
    int *ttyFDs = NULL;
    size_t nttyFDs = 0;
1346
    virLXCControllerPtr ctrl = NULL;
1347
    size_t i;
1348
    const char *securityDriver = "none";
1349

E
Eric Blake 已提交
1350 1351
    if (setlocale(LC_ALL, "") == NULL ||
        bindtextdomain(PACKAGE, LOCALEDIR) == NULL ||
1352 1353
        textdomain(PACKAGE) == NULL ||
        virRandomInitialize(time(NULL) ^ getpid())) {
E
Eric Blake 已提交
1354 1355 1356 1357
        fprintf(stderr, _("%s: initialization failed\n"), argv[0]);
        exit(EXIT_FAILURE);
    }

1358 1359 1360
    /* Initialize logging */
    virLogSetFromEnv();

1361 1362
    while (1) {
        int c;
1363

1364
        c = getopt_long(argc, argv, "dn:v:m:c:s:h:S:",
1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376
                       options, NULL);

        if (c == -1)
            break;

        switch (c) {
        case 'b':
            bg = 1;
            break;

        case 'n':
            if ((name = strdup(optarg)) == NULL) {
1377
                virReportOOMError();
1378
                goto cleanup;
1379
            }
1380 1381 1382 1383
            break;

        case 'v':
            if (VIR_REALLOC_N(veths, nveths+1) < 0) {
1384
                virReportOOMError();
1385
                goto cleanup;
1386
            }
1387
            if ((veths[nveths++] = strdup(optarg)) == NULL) {
1388
                virReportOOMError();
1389
                goto cleanup;
1390
            }
1391 1392 1393
            break;

        case 'c':
1394 1395 1396 1397 1398
            if (VIR_REALLOC_N(ttyFDs, nttyFDs + 1) < 0) {
                virReportOOMError();
                goto cleanup;
            }
            if (virStrToLong_i(optarg, NULL, 10, &ttyFDs[nttyFDs++]) < 0) {
1399 1400 1401 1402 1403
                fprintf(stderr, "malformed --console argument '%s'", optarg);
                goto cleanup;
            }
            break;

1404
        case 's':
1405
            if (virStrToLong_i(optarg, NULL, 10, &handshakeFd) < 0) {
1406 1407 1408 1409 1410 1411
                fprintf(stderr, "malformed --handshakefd argument '%s'",
                        optarg);
                goto cleanup;
            }
            break;

1412
        case 'S':
1413
            securityDriver = optarg;
1414 1415
            break;

1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426
        case 'h':
        case '?':
            fprintf(stderr, "\n");
            fprintf(stderr, "syntax: %s [OPTIONS]\n", argv[0]);
            fprintf(stderr, "\n");
            fprintf(stderr, "Options\n");
            fprintf(stderr, "\n");
            fprintf(stderr, "  -b, --background\n");
            fprintf(stderr, "  -n NAME, --name NAME\n");
            fprintf(stderr, "  -c FD, --console FD\n");
            fprintf(stderr, "  -v VETH, --veth VETH\n");
1427
            fprintf(stderr, "  -s FD, --handshakefd FD\n");
1428
            fprintf(stderr, "  -S NAME, --security NAME\n");
1429 1430 1431
            fprintf(stderr, "  -h, --help\n");
            fprintf(stderr, "\n");
            goto cleanup;
1432 1433 1434
        }
    }

1435 1436 1437 1438 1439
    if (name == NULL) {
        fprintf(stderr, "%s: missing --name argument for configuration\n", argv[0]);
        goto cleanup;
    }

1440
    if (handshakeFd < 0) {
1441 1442 1443 1444 1445
        fprintf(stderr, "%s: missing --handshake argument for container PTY\n",
                argv[0]);
        goto cleanup;
    }

1446
    if (getuid() != 0) {
1447 1448 1449
        fprintf(stderr, "%s: must be run as the 'root' user\n", argv[0]);
        goto cleanup;
    }
1450

1451 1452
    virEventRegisterDefaultImpl();

1453
    if (!(ctrl = virLXCControllerNew(name)))
1454
        goto cleanup;
1455

1456 1457
    ctrl->handshakeFd = handshakeFd;

1458 1459 1460 1461 1462
    if (!(ctrl->securityManager = virSecurityManagerNew(securityDriver,
                                                        LXC_DRIVER_NAME,
                                                        false, false, false)))
        goto cleanup;

1463
    VIR_DEBUG("Security model %s type %s label %s imagelabel %s",
1464 1465 1466 1467
              NULLSTR(ctrl->def->seclabel.model),
              virDomainSeclabelTypeToString(ctrl->def->seclabel.type),
              NULLSTR(ctrl->def->seclabel.label),
              NULLSTR(ctrl->def->seclabel.imagelabel));
1468

1469 1470 1471
    ctrl->veths = veths;
    ctrl->nveths = nveths;

1472 1473 1474 1475 1476 1477
    for (i = 0 ; i < nttyFDs ; i++) {
        if (virLXCControllerAddConsole(ctrl, ttyFDs[i]) < 0)
            goto cleanup;
        ttyFDs[i] = -1;
    }

1478
    if (virLXCControllerValidateNICs(ctrl) < 0)
1479
        goto cleanup;
1480

1481 1482 1483
    if (virLXCControllerValidateConsoles(ctrl) < 0)
        goto cleanup;

1484
    if (virLXCControllerSetupServer(ctrl) < 0)
1485
        goto cleanup;
1486

1487 1488 1489
    if (bg) {
        if ((pid = fork()) < 0)
            goto cleanup;
1490

1491
        if (pid > 0) {
1492
            if ((rc = virPidFileWrite(LXC_STATE_DIR, name, pid)) < 0) {
1493
                virReportSystemError(-rc,
1494 1495
                                     _("Unable to write pid file '%s/%s.pid'"),
                                     LXC_STATE_DIR, name);
1496 1497
                _exit(1);
            }
1498

1499 1500 1501 1502
            /* First child now exits, allowing original caller
             * (ie libvirtd's LXC driver to complete their
             * waitpid & continue */
            _exit(0);
1503 1504
        }

1505 1506
        /* Don't hold onto any cwd we inherit from libvirtd either */
        if (chdir("/") < 0) {
1507
            virReportSystemError(errno, "%s",
1508
                                 _("Unable to change to root dir"));
1509 1510 1511 1512
            goto cleanup;
        }

        if (setsid() < 0) {
1513
            virReportSystemError(errno, "%s",
1514
                                 _("Unable to become session leader"));
1515 1516 1517
            goto cleanup;
        }
    }
1518

1519
    rc = virLXCControllerRun(ctrl);
1520

1521
cleanup:
1522
    virPidFileDelete(LXC_STATE_DIR, name);
1523
    virLXCControllerDeleteInterfaces(ctrl);
1524 1525 1526 1527
    for (i = 0 ; i < nttyFDs ; i++)
        VIR_FORCE_CLOSE(ttyFDs[i]);
    VIR_FREE(ttyFDs);

1528
    virLXCControllerFree(ctrl);
1529

1530
    return rc ? EXIT_FAILURE : EXIT_SUCCESS;
1531
}