storage_backend_logical.c 21.3 KB
Newer Older
1 2 3
/*
 * storage_backend_logvol.c: storage backend for logical volume handling
 *
4
 * Copyright (C) 2007-2009 Red Hat, Inc.
5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33
 * Copyright (C) 2007-2008 Daniel P. Berrange
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
 *
 * Author: Daniel P. Berrange <berrange@redhat.com>
 */

#include <config.h>

#include <sys/wait.h>
#include <sys/stat.h>
#include <stdio.h>
#include <regex.h>
#include <string.h>
#include <unistd.h>
#include <fcntl.h>

34
#include "virterror_internal.h"
35 36 37
#include "storage_backend_logical.h"
#include "storage_conf.h"
#include "util.h"
38
#include "memory.h"
39
#include "logging.h"
40

41 42
#define VIR_FROM_THIS VIR_FROM_STORAGE

43 44 45 46 47 48 49 50 51 52 53 54
#define PV_BLANK_SECTOR_SIZE 512


static int
virStorageBackendLogicalSetActive(virConnectPtr conn,
                                  virStoragePoolObjPtr pool,
                                  int on)
{
    const char *cmdargv[4];

    cmdargv[0] = VGCHANGE;
    cmdargv[1] = on ? "-ay" : "-an";
55
    cmdargv[2] = pool->def->source.name;
56 57
    cmdargv[3] = NULL;

58
    if (virRun(conn, cmdargv, NULL) < 0)
59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86
        return -1;

    return 0;
}


static int
virStorageBackendLogicalMakeVol(virConnectPtr conn,
                                virStoragePoolObjPtr pool,
                                char **const groups,
                                void *data)
{
    virStorageVolDefPtr vol = NULL;
    unsigned long long offset, size, length;

    /* See if we're only looking for a specific volume */
    if (data != NULL) {
        vol = data;
        if (STRNEQ(vol->name, groups[0]))
            return 0;
    }

    /* Or filling in more data on an existing volume */
    if (vol == NULL)
        vol = virStorageVolDefFindByName(pool, groups[0]);

    /* Or a completely new volume */
    if (vol == NULL) {
87
        if (VIR_ALLOC(vol) < 0) {
88
            virReportOOMError(conn);
89 90 91
            return -1;
        }

92 93
        vol->type = VIR_STORAGE_VOL_BLOCK;

94
        if ((vol->name = strdup(groups[0])) == NULL) {
95
            virReportOOMError(conn);
96
            virStorageVolDefFree(vol);
97 98 99
            return -1;
        }

100 101
        if (VIR_REALLOC_N(pool->volumes.objs,
                          pool->volumes.count + 1)) {
102
            virReportOOMError(conn);
103 104 105 106
            virStorageVolDefFree(vol);
            return -1;
        }
        pool->volumes.objs[pool->volumes.count++] = vol;
107 108 109
    }

    if (vol->target.path == NULL) {
110 111 112 113 114 115 116 117 118 119 120 121 122
        if (virAsprintf(&vol->target.path, "%s/%s",
                        pool->def->target.path, vol->name) < 0) {
            virReportOOMError(conn);
            virStorageVolDefFree(vol);
            return -1;
        }
    }

    if (groups[1] && !STREQ(groups[1], "")) {
        if (virAsprintf(&vol->backingStore.path, "%s/%s",
                        pool->def->target.path, groups[1]) < 0) {
            virReportOOMError(conn);
            virStorageVolDefFree(vol);
123 124
            return -1;
        }
125 126

        vol->backingStore.format = VIR_STORAGE_POOL_LOGICAL_LVM2;
127 128 129
    }

    if (vol->key == NULL &&
130
        (vol->key = strdup(groups[2])) == NULL) {
131
        virReportOOMError(conn);
132 133 134 135 136 137 138 139
        return -1;
    }

    if (virStorageBackendUpdateVolInfo(conn, vol, 1) < 0)
        return -1;


    /* Finally fill in extents information */
140 141
    if (VIR_REALLOC_N(vol->source.extents,
                      vol->source.nextent + 1) < 0) {
142
        virReportOOMError(conn);
143 144 145 146
        return -1;
    }

    if ((vol->source.extents[vol->source.nextent].path =
147
         strdup(groups[3])) == NULL) {
148
        virReportOOMError(conn);
149 150 151
        return -1;
    }

152
    if (virStrToLong_ull(groups[4], NULL, 10, &offset) < 0) {
153
        virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR,
J
Jim Meyering 已提交
154
                              "%s", _("malformed volume extent offset value"));
155 156
        return -1;
    }
157
    if (virStrToLong_ull(groups[5], NULL, 10, &length) < 0) {
158
        virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR,
J
Jim Meyering 已提交
159
                              "%s", _("malformed volume extent length value"));
160 161
        return -1;
    }
162
    if (virStrToLong_ull(groups[6], NULL, 10, &size) < 0) {
163
        virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR,
J
Jim Meyering 已提交
164
                              "%s", _("malformed volume extent size value"));
165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180
        return -1;
    }

    vol->source.extents[vol->source.nextent].start = offset * size;
    vol->source.extents[vol->source.nextent].end = (offset * size) + length;
    vol->source.nextent++;

    return 0;
}

static int
virStorageBackendLogicalFindLVs(virConnectPtr conn,
                                virStoragePoolObjPtr pool,
                                virStorageVolDefPtr vol)
{
    /*
181 182 183 184 185 186
     *  # lvs --separator , --noheadings --units b --unbuffered --nosuffix --options "lv_name,origin,uuid,devices,seg_size,vg_extent_size" VGNAME
     *  RootLV,,06UgP5-2rhb-w3Bo-3mdR-WeoL-pytO-SAa2ky,/dev/hda2(0),5234491392,33554432
     *  SwapLV,,oHviCK-8Ik0-paqS-V20c-nkhY-Bm1e-zgzU0M,/dev/hda2(156),1040187392,33554432
     *  Test2,,3pg3he-mQsA-5Sui-h0i6-HNmc-Cz7W-QSndcR,/dev/hda2(219),1073741824,33554432
     *  Test3,,UB5hFw-kmlm-LSoX-EI1t-ioVd-h7GL-M0W8Ht,/dev/hda2(251),2181038080,33554432
     *  Test3,Test2,UB5hFw-kmlm-LSoX-EI1t-ioVd-h7GL-M0W8Ht,/dev/hda2(187),1040187392,33554432
187
     *
188
     * Pull out name, origin, & uuid, device, device extent start #, segment size, extent size.
189 190
     *
     * NB can be multiple rows per volume if they have many extents
191
     *
192 193 194 195
     * NB lvs from some distros (e.g. SLES10 SP2) outputs trailing "," on each line
     *
     * NB Encrypted logical volumes can print ':' in their name, so it is
     *    not a suitable separator (rhbz 470693).
196 197
     */
    const char *regexes[] = {
198
        "^\\s*(\\S+),(\\S*),(\\S+),(\\S+)\\((\\S+)\\),(\\S+),([0-9]+),?\\s*$"
199 200
    };
    int vars[] = {
201
        7
202 203
    };
    const char *prog[] = {
204
        LVS, "--separator", ",", "--noheadings", "--units", "b",
205
        "--unbuffered", "--nosuffix", "--options",
206
        "lv_name,origin,uuid,devices,seg_size,vg_extent_size",
207
        pool->def->source.name, NULL
208 209
    };

210 211 212 213 214 215 216 217 218 219 220 221
    int exitstatus;

    if (virStorageBackendRunProgRegex(conn,
                                      pool,
                                      prog,
                                      1,
                                      regexes,
                                      vars,
                                      virStorageBackendLogicalMakeVol,
                                      vol,
                                      &exitstatus) < 0) {
        virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR,
J
Jim Meyering 已提交
222
                              "%s", _("lvs command failed"));
223 224 225 226 227 228 229 230 231 232 233
                              return -1;
    }

    if (exitstatus != 0) {
        virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR,
                              _("lvs command failed with exitstatus %d"),
                              exitstatus);
        return -1;
    }

    return 0;
234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251
}

static int
virStorageBackendLogicalRefreshPoolFunc(virConnectPtr conn ATTRIBUTE_UNUSED,
                                        virStoragePoolObjPtr pool ATTRIBUTE_UNUSED,
                                        char **const groups,
                                        void *data ATTRIBUTE_UNUSED)
{
    if (virStrToLong_ull(groups[0], NULL, 10, &pool->def->capacity) < 0)
        return -1;
    if (virStrToLong_ull(groups[1], NULL, 10, &pool->def->available) < 0)
        return -1;
    pool->def->allocation = pool->def->capacity - pool->def->available;

    return 0;
}


252
static int
253
virStorageBackendLogicalFindPoolSourcesFunc(virConnectPtr conn,
254 255 256 257
                                            virStoragePoolObjPtr pool ATTRIBUTE_UNUSED,
                                            char **const groups,
                                            void *data)
{
258 259 260 261 262 263 264 265 266 267 268
    virStoragePoolSourceListPtr sourceList = data;
    char *pvname = NULL;
    char *vgname = NULL;
    int i;
    virStoragePoolSourceDevicePtr dev;
    virStoragePoolSource *thisSource;

    pvname = strdup(groups[0]);
    vgname = strdup(groups[1]);

    if (pvname == NULL || vgname == NULL) {
269
        virReportOOMError(conn);
270 271 272 273 274 275 276 277 278 279
        goto err_no_memory;
    }

    thisSource = NULL;
    for (i = 0 ; i < sourceList->nsources; i++) {
        if (STREQ(sourceList->sources[i].name, vgname)) {
            thisSource = &sourceList->sources[i];
            break;
        }
    }
280

281
    if (thisSource == NULL) {
282 283
        if (!(thisSource = virStoragePoolSourceListNewSource(conn,
                                                             sourceList)))
284 285 286
            goto err_no_memory;

        thisSource->name = vgname;
287
    }
288 289
    else
        VIR_FREE(vgname);
290

291
    if (VIR_REALLOC_N(thisSource->devices, thisSource->ndevice + 1) != 0) {
292
        virReportOOMError(conn);
293
        goto err_no_memory;
294 295
    }

296 297
    dev = &thisSource->devices[thisSource->ndevice];
    thisSource->ndevice++;
298
    thisSource->format = VIR_STORAGE_POOL_LOGICAL_LVM2;
299 300 301

    memset(dev, 0, sizeof(*dev));
    dev->path = pvname;
302 303

    return 0;
304 305 306 307 308 309

 err_no_memory:
    VIR_FREE(pvname);
    VIR_FREE(vgname);

    return -1;
310 311 312 313 314 315 316 317
}

static char *
virStorageBackendLogicalFindPoolSources(virConnectPtr conn,
                                        const char *srcSpec ATTRIBUTE_UNUSED,
                                        unsigned int flags ATTRIBUTE_UNUSED)
{
    /*
318 319 320
     * # pvs --noheadings -o pv_name,vg_name
     *   /dev/sdb
     *   /dev/sdc VolGroup00
321 322
     */
    const char *regexes[] = {
323
        "^\\s*(\\S+)\\s+(\\S+)\\s*$"
324 325
    };
    int vars[] = {
326
        2
327
    };
328
    const char *const prog[] = { PVS, "--noheadings", "-o", "pv_name,vg_name", NULL };
329
    const char *const scanprog[] = { VGSCAN, NULL };
330 331
    int exitstatus;
    char *retval = NULL;
332 333
    virStoragePoolSourceList sourceList;
    int i;
334

335 336 337 338 339
    /*
     * NOTE: ignoring errors here; this is just to "touch" any logical volumes
     * that might be hanging around, so if this fails for some reason, the
     * worst that happens is that scanning doesn't pick everything up
     */
340 341 342
    if (virRun(conn, scanprog, &exitstatus) < 0) {
        VIR_WARN0("Failure when running vgscan to refresh physical volumes");
    }
343

344
    memset(&sourceList, 0, sizeof(sourceList));
345 346
    sourceList.type = VIR_STORAGE_POOL_LOGICAL;

347 348
    if (virStorageBackendRunProgRegex(conn, NULL, prog, 1, regexes, vars,
                                      virStorageBackendLogicalFindPoolSourcesFunc,
349
                                      &sourceList, &exitstatus) < 0)
350 351
        return NULL;

352
    retval = virStoragePoolSourceListFormat(conn, &sourceList);
353
    if (retval == NULL) {
354 355
        virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR, "%s",
                              _("failed to get source from sourceList"));
356 357 358 359
        goto cleanup;
    }

 cleanup:
360 361 362 363
    for (i = 0; i < sourceList.nsources; i++)
        virStoragePoolSourceFree(&sourceList.sources[i]);

    VIR_FREE(sourceList.sources);
364 365 366 367 368

    return retval;
}


369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391
static int
virStorageBackendLogicalStartPool(virConnectPtr conn,
                                  virStoragePoolObjPtr pool)
{
    if (virStorageBackendLogicalSetActive(conn, pool, 1) < 0)
        return -1;

    return 0;
}


static int
virStorageBackendLogicalBuildPool(virConnectPtr conn,
                                  virStoragePoolObjPtr pool,
                                  unsigned int flags ATTRIBUTE_UNUSED)
{
    const char **vgargv;
    const char *pvargv[3];
    int n = 0, i, fd;
    char zeros[PV_BLANK_SECTOR_SIZE];

    memset(zeros, 0, sizeof(zeros));

392
    if (VIR_ALLOC_N(vgargv, 3 + pool->def->source.ndevice) < 0) {
393
        virReportOOMError(conn);
394 395 396 397
        return -1;
    }

    vgargv[n++] = VGCREATE;
398
    vgargv[n++] = pool->def->source.name;
399 400 401 402 403 404 405 406 407 408

    pvargv[0] = PVCREATE;
    pvargv[2] = NULL;
    for (i = 0 ; i < pool->def->source.ndevice ; i++) {
        /*
         * LVM requires that the first sector is blanked if using
         * a whole disk as a PV. So we just blank them out regardless
         * rather than trying to figure out if we're a disk or partition
         */
        if ((fd = open(pool->def->source.devices[i].path, O_WRONLY)) < 0) {
409 410 411
            virReportSystemError(conn, errno,
                                 _("cannot open device '%s'"),
                                 pool->def->source.devices[i].path);
412 413
            goto cleanup;
        }
414
        if (safewrite(fd, zeros, sizeof(zeros)) < 0) {
415 416 417
            virReportSystemError(conn, errno,
                                 _("cannot clear device header of '%s'"),
                                 pool->def->source.devices[i].path);
418 419 420 421
            close(fd);
            goto cleanup;
        }
        if (close(fd) < 0) {
422 423 424
            virReportSystemError(conn, errno,
                                 _("cannot close device '%s'"),
                                 pool->def->source.devices[i].path);
425 426 427 428 429 430 431 432 433
            goto cleanup;
        }

        /*
         * Initialize the physical volume because vgcreate is not
         * clever enough todo this for us :-(
         */
        vgargv[n++] = pool->def->source.devices[i].path;
        pvargv[1] = pool->def->source.devices[i].path;
434
        if (virRun(conn, pvargv, NULL) < 0)
435 436 437
            goto cleanup;
    }

438
    vgargv[n] = NULL;
439 440

    /* Now create the volume group itself */
441
    if (virRun(conn, vgargv, NULL) < 0)
442 443
        goto cleanup;

444
    VIR_FREE(vgargv);
445 446 447 448

    return 0;

 cleanup:
449
    VIR_FREE(vgargv);
450 451 452 453 454 455 456 457 458 459 460 461 462
    return -1;
}


static int
virStorageBackendLogicalRefreshPool(virConnectPtr conn,
                                    virStoragePoolObjPtr pool)
{
    /*
     *  # vgs --separator : --noheadings --units b --unbuffered --nosuffix --options "vg_size,vg_free" VGNAME
     *    10603200512:4328521728
     *
     * Pull out size & free
463 464
     *
     * NB vgs from some distros (e.g. SLES10 SP2) outputs trailing ":" on each line
465 466
     */
    const char *regexes[] = {
467
        "^\\s*(\\S+):([0-9]+):?\\s*$"
468 469 470 471 472 473 474
    };
    int vars[] = {
        2
    };
    const char *prog[] = {
        VGS, "--separator", ":", "--noheadings", "--units", "b", "--unbuffered",
        "--nosuffix", "--options", "vg_size,vg_free",
475
        pool->def->source.name, NULL
476
    };
477
    int exitstatus;
478

D
Daniel P. Berrange 已提交
479
    virFileWaitForDevices(conn);
480

481 482 483 484 485 486 487 488 489 490 491 492 493 494
    /* Get list of all logical volumes */
    if (virStorageBackendLogicalFindLVs(conn, pool, NULL) < 0) {
        virStoragePoolObjClearVols(pool);
        return -1;
    }

    /* Now get basic volgrp metadata */
    if (virStorageBackendRunProgRegex(conn,
                                      pool,
                                      prog,
                                      1,
                                      regexes,
                                      vars,
                                      virStorageBackendLogicalRefreshPoolFunc,
495 496 497 498 499 500 501
                                      NULL,
                                      &exitstatus) < 0) {
        virStoragePoolObjClearVols(pool);
        return -1;
    }

    if (exitstatus != 0) {
502 503 504 505 506 507 508
        virStoragePoolObjClearVols(pool);
        return -1;
    }

    return 0;
}

509 510 511 512
/*
 * This is actually relatively safe; if you happen to try to "stop" the
 * pool that your / is on, for instance, you will get failure like:
 * "Can't deactivate volume group "VolGroup00" with 3 open logical volume(s)"
513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529
 */
static int
virStorageBackendLogicalStopPool(virConnectPtr conn,
                                 virStoragePoolObjPtr pool)
{
    if (virStorageBackendLogicalSetActive(conn, pool, 0) < 0)
        return -1;

    return 0;
}

static int
virStorageBackendLogicalDeletePool(virConnectPtr conn,
                                   virStoragePoolObjPtr pool,
                                   unsigned int flags ATTRIBUTE_UNUSED)
{
    const char *cmdargv[] = {
530
        VGREMOVE, "-f", pool->def->source.name, NULL
531
    };
532 533
    const char *pvargv[3];
    int i, error;
534

535
    /* first remove the volume group */
536
    if (virRun(conn, cmdargv, NULL) < 0)
537 538
        return -1;

539 540 541 542 543 544 545 546
    /* now remove the pv devices and clear them out */
    error = 0;
    pvargv[0] = PVREMOVE;
    pvargv[2] = NULL;
    for (i = 0 ; i < pool->def->source.ndevice ; i++) {
        pvargv[1] = pool->def->source.devices[i].path;
        if (virRun(conn, pvargv, NULL) < 0) {
            error = -1;
547 548 549
            virReportSystemError(conn, errno,
                                 _("cannot remove PV device '%s'"),
                                 pool->def->source.devices[i].path);
550 551 552
            break;
        }
    }
553

554
    return error;
555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571
}


static int
virStorageBackendLogicalDeleteVol(virConnectPtr conn,
                                  virStoragePoolObjPtr pool,
                                  virStorageVolDefPtr vol,
                                  unsigned int flags);


static int
virStorageBackendLogicalCreateVol(virConnectPtr conn,
                                  virStoragePoolObjPtr pool,
                                  virStorageVolDefPtr vol)
{
    int fd = -1;
    char size[100];
572
    const char *cmdargvnew[] = {
573 574 575
        LVCREATE, "--name", vol->name, "-L", size,
        pool->def->target.path, NULL
    };
576 577 578 579 580 581
    const char *cmdargvsnap[] = {
        LVCREATE, "--name", vol->name, "-L", size,
        "-s", vol->backingStore.path, NULL
    };
    const char **cmdargv = cmdargvnew;

582 583 584 585 586 587 588
    if (vol->target.encryption != NULL) {
        virStorageReportError(conn, VIR_ERR_NO_SUPPORT,
                              "%s", _("storage pool does not support encrypted "
                                      "volumes"));
        return -1;
    }

589 590 591
    if (vol->backingStore.path) {
        cmdargv = cmdargvsnap;
    }
592 593 594 595

    snprintf(size, sizeof(size)-1, "%lluK", vol->capacity/1024);
    size[sizeof(size)-1] = '\0';

596 597
    vol->type = VIR_STORAGE_VOL_BLOCK;

598 599 600 601
    if (vol->target.path != NULL) {
        /* A target path passed to CreateVol has no meaning */
        VIR_FREE(vol->target.path);
    }
602 603 604 605

    if (virAsprintf(&vol->target.path, "%s/%s",
                    pool->def->target.path,
                    vol->name) == -1) {
606
        virReportOOMError(conn);
607 608 609
        return -1;
    }

610
    if (virRun(conn, cmdargv, NULL) < 0)
611 612 613
        return -1;

    if ((fd = open(vol->target.path, O_RDONLY)) < 0) {
614 615 616
        virReportSystemError(conn, errno,
                             _("cannot read path '%s'"),
                             vol->target.path);
617 618 619 620 621 622
        goto cleanup;
    }

    /* We can only chown/grp if root */
    if (getuid() == 0) {
        if (fchown(fd, vol->target.perms.uid, vol->target.perms.gid) < 0) {
623 624 625
            virReportSystemError(conn, errno,
                                 _("cannot set file owner '%s'"),
                                 vol->target.path);
626 627 628 629
            goto cleanup;
        }
    }
    if (fchmod(fd, vol->target.perms.mode) < 0) {
630 631 632
        virReportSystemError(conn, errno,
                             _("cannot set file mode '%s'"),
                             vol->target.path);
633 634 635 636
        goto cleanup;
    }

    if (close(fd) < 0) {
637 638 639
        virReportSystemError(conn, errno,
                             _("cannot close file '%s'"),
                             vol->target.path);
640 641 642 643 644 645
        goto cleanup;
    }
    fd = -1;

    /* Fill in data about this new vol */
    if (virStorageBackendLogicalFindLVs(conn, pool, vol) < 0) {
646 647 648
        virReportSystemError(conn, errno,
                             _("cannot find newly created volume '%s'"),
                             vol->target.path);
649 650 651 652 653 654 655 656 657 658 659 660
        goto cleanup;
    }

    return 0;

 cleanup:
    if (fd != -1)
        close(fd);
    virStorageBackendLogicalDeleteVol(conn, pool, vol, 0);
    return -1;
}

661 662
static int
virStorageBackendLogicalBuildVolFrom(virConnectPtr conn,
663
                                     virStoragePoolObjPtr pool,
664 665 666 667 668 669 670 671 672 673
                                     virStorageVolDefPtr vol,
                                     virStorageVolDefPtr inputvol,
                                     unsigned int flags)
{
    virStorageBackendBuildVolFrom build_func;

    build_func = virStorageBackendGetBuildVolFromFunction(conn, vol, inputvol);
    if (!build_func)
        return -1;

674
    return build_func(conn, pool, vol, inputvol, flags);
675 676
}

677 678 679 680 681 682 683 684 685 686
static int
virStorageBackendLogicalDeleteVol(virConnectPtr conn,
                                  virStoragePoolObjPtr pool ATTRIBUTE_UNUSED,
                                  virStorageVolDefPtr vol,
                                  unsigned int flags ATTRIBUTE_UNUSED)
{
    const char *cmdargv[] = {
        LVREMOVE, "-f", vol->target.path, NULL
    };

687
    if (virRun(conn, cmdargv, NULL) < 0)
688 689 690 691 692 693 694 695 696
        return -1;

    return 0;
}


virStorageBackend virStorageBackendLogical = {
    .type = VIR_STORAGE_POOL_LOGICAL,

697
    .findPoolSources = virStorageBackendLogicalFindPoolSources,
698 699 700 701 702
    .startPool = virStorageBackendLogicalStartPool,
    .buildPool = virStorageBackendLogicalBuildPool,
    .refreshPool = virStorageBackendLogicalRefreshPool,
    .stopPool = virStorageBackendLogicalStopPool,
    .deletePool = virStorageBackendLogicalDeletePool,
703 704
    .buildVol = NULL,
    .buildVolFrom = virStorageBackendLogicalBuildVolFrom,
705 706 707
    .createVol = virStorageBackendLogicalCreateVol,
    .deleteVol = virStorageBackendLogicalDeleteVol,
};