datatypes.c 38.3 KB
Newer Older
1 2 3
/*
 * datatypes.h: management of structs for public data types
 *
4
 * Copyright (C) 2006-2009 Red Hat, Inc.
5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library; if not, write to the Free Software
 * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
 *
 */

#include <config.h>
D
Daniel P. Berrange 已提交
23
#include <unistd.h>
24 25 26

#include "datatypes.h"
#include "virterror_internal.h"
27
#include "logging.h"
28
#include "memory.h"
29
#include "uuid.h"
C
Chris Lalancette 已提交
30
#include "util.h"
31

32 33
#define VIR_FROM_THIS VIR_FROM_NONE

34 35 36 37
#define virLibConnError(conn, code, fmt...)                       \
    virReportErrorHelper(conn, VIR_FROM_THIS, code, __FILE__,     \
                         __FUNCTION__, __LINE__, fmt)

38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54
/************************************************************************
 *									*
 *			Domain and Connections allocations		*
 *									*
 ************************************************************************/

/**
 * virDomainFreeName:
 * @domain: a domain object
 *
 * Destroy the domain object, this is just used by the domain hash callback.
 *
 * Returns 0 in case of success and -1 in case of failure.
 */
static int
virDomainFreeName(virDomainPtr domain, const char *name ATTRIBUTE_UNUSED)
{
55
    return (virUnrefDomain(domain));
56 57 58 59 60 61 62 63 64 65 66 67 68
}

/**
 * virNetworkFreeName:
 * @network: a network object
 *
 * Destroy the network object, this is just used by the network hash callback.
 *
 * Returns 0 in case of success and -1 in case of failure.
 */
static int
virNetworkFreeName(virNetworkPtr network, const char *name ATTRIBUTE_UNUSED)
{
69
    return (virUnrefNetwork(network));
70 71
}

D
Daniel Veillard 已提交
72 73
/**
 * virInterfaceFreeName:
D
Dan Kenigsberg 已提交
74
 * @interface: an interface object
D
Daniel Veillard 已提交
75 76 77 78 79 80
 *
 * Destroy the interface object, this is just used by the interface hash callback.
 *
 * Returns 0 in case of success and -1 in case of failure.
 */
static int
81
virInterfaceFreeName(virInterfacePtr iface, const char *name ATTRIBUTE_UNUSED)
D
Daniel Veillard 已提交
82
{
83
    return (virUnrefInterface(iface));
D
Daniel Veillard 已提交
84 85
}

86 87 88 89 90 91 92 93 94 95 96
/**
 * virStoragePoolFreeName:
 * @pool: a pool object
 *
 * Destroy the pool object, this is just used by the pool hash callback.
 *
 * Returns 0 in case of success and -1 in case of failure.
 */
static int
virStoragePoolFreeName(virStoragePoolPtr pool, const char *name ATTRIBUTE_UNUSED)
{
97
    return (virUnrefStoragePool(pool));
98 99 100 101 102 103 104 105 106 107 108 109 110
}

/**
 * virStorageVolFreeName:
 * @vol: a vol object
 *
 * Destroy the vol object, this is just used by the vol hash callback.
 *
 * Returns 0 in case of success and -1 in case of failure.
 */
static int
virStorageVolFreeName(virStorageVolPtr vol, const char *name ATTRIBUTE_UNUSED)
{
111
    return (virUnrefStorageVol(vol));
112 113
}

114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130
/**
 * virSecretFreeName:
 * @secret_: a secret object
 *
 * Destroy the secret object, this is just used by the secret hash callback.
 *
 * Returns 0 in case of success and -1 in case of failure.
 */
static void
virSecretFreeName(void *secret_, const char *name ATTRIBUTE_UNUSED)
{
    virSecretPtr secret;

    secret = secret_;
    virUnrefSecret(secret);
}

131 132 133 134 135 136 137 138 139 140 141 142
/**
 * virGetConnect:
 *
 * Allocates a new hypervisor connection structure
 *
 * Returns a new pointer or NULL in case of error.
 */
virConnectPtr
virGetConnect(void) {
    virConnectPtr ret;

    if (VIR_ALLOC(ret) < 0) {
143
        virReportOOMError(NULL);
144 145
        goto failed;
    }
146 147 148 149 150
    if (virMutexInit(&ret->lock) < 0) {
        VIR_FREE(ret);
        goto failed;
    }

151 152 153 154 155
    ret->magic = VIR_CONNECT_MAGIC;
    ret->driver = NULL;
    ret->networkDriver = NULL;
    ret->privateData = NULL;
    ret->networkPrivateData = NULL;
D
Daniel Veillard 已提交
156
    ret->interfacePrivateData = NULL;
157 158 159 160 161 162
    ret->domains = virHashCreate(20);
    if (ret->domains == NULL)
        goto failed;
    ret->networks = virHashCreate(20);
    if (ret->networks == NULL)
        goto failed;
D
Daniel Veillard 已提交
163 164 165
    ret->interfaces = virHashCreate(20);
    if (ret->interfaces == NULL)
        goto failed;
166 167 168 169 170 171
    ret->storagePools = virHashCreate(20);
    if (ret->storagePools == NULL)
        goto failed;
    ret->storageVols = virHashCreate(20);
    if (ret->storageVols == NULL)
        goto failed;
172 173 174
    ret->nodeDevices = virHashCreate(256);
    if (ret->nodeDevices == NULL)
        goto failed;
175 176 177
    ret->secrets = virHashCreate(20);
    if (ret->secrets == NULL)
        goto failed;
178 179 180 181 182 183 184 185 186 187

    ret->refs = 1;
    return(ret);

failed:
    if (ret != NULL) {
        if (ret->domains != NULL)
            virHashFree(ret->domains, (virHashDeallocator) virDomainFreeName);
        if (ret->networks != NULL)
            virHashFree(ret->networks, (virHashDeallocator) virNetworkFreeName);
D
Daniel Veillard 已提交
188 189
        if (ret->interfaces != NULL)
           virHashFree(ret->interfaces, (virHashDeallocator) virInterfaceFreeName);
190 191 192 193
        if (ret->storagePools != NULL)
            virHashFree(ret->storagePools, (virHashDeallocator) virStoragePoolFreeName);
        if (ret->storageVols != NULL)
            virHashFree(ret->storageVols, (virHashDeallocator) virStorageVolFreeName);
194 195
        if (ret->nodeDevices != NULL)
            virHashFree(ret->nodeDevices, (virHashDeallocator) virNodeDeviceFree);
196 197
        if (ret->secrets != NULL)
            virHashFree(ret->secrets, virSecretFreeName);
198

199
        virMutexDestroy(&ret->lock);
200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215
        VIR_FREE(ret);
    }
    return(NULL);
}

/**
 * virReleaseConnect:
 * @conn: the hypervisor connection to release
 *
 * Unconditionally release all memory associated with a connection.
 * The conn.lock mutex must be held prior to calling this, and will
 * be released prior to this returning. The connection obj must not
 * be used once this method returns.
 */
static void
virReleaseConnect(virConnectPtr conn) {
216
    DEBUG("release connection %p", conn);
217 218 219 220
    if (conn->domains != NULL)
        virHashFree(conn->domains, (virHashDeallocator) virDomainFreeName);
    if (conn->networks != NULL)
        virHashFree(conn->networks, (virHashDeallocator) virNetworkFreeName);
D
Daniel Veillard 已提交
221 222
    if (conn->interfaces != NULL)
        virHashFree(conn->interfaces, (virHashDeallocator) virInterfaceFreeName);
223 224 225 226
    if (conn->storagePools != NULL)
        virHashFree(conn->storagePools, (virHashDeallocator) virStoragePoolFreeName);
    if (conn->storageVols != NULL)
        virHashFree(conn->storageVols, (virHashDeallocator) virStorageVolFreeName);
227 228
    if (conn->nodeDevices != NULL)
        virHashFree(conn->nodeDevices, (virHashDeallocator) virNodeDeviceFree);
229 230
    if (conn->secrets != NULL)
        virHashFree(conn->secrets, virSecretFreeName);
231 232 233

    virResetError(&conn->err);

234
    xmlFreeURI(conn->uri);
235

236 237
    virMutexUnlock(&conn->lock);
    virMutexDestroy(&conn->lock);
238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254
    VIR_FREE(conn);
}

/**
 * virUnrefConnect:
 * @conn: the hypervisor connection to unreference
 *
 * Unreference the connection. If the use count drops to zero, the structure is
 * actually freed.
 *
 * Returns the reference count or -1 in case of failure.
 */
int
virUnrefConnect(virConnectPtr conn) {
    int refs;

    if ((!VIR_IS_CONNECT(conn))) {
255
        virLibConnError(NULL, VIR_ERR_INVALID_ARG, __FUNCTION__);
256 257
        return(-1);
    }
258
    virMutexLock(&conn->lock);
259
    DEBUG("unref connection %p %d", conn, conn->refs);
260 261 262
    conn->refs--;
    refs = conn->refs;
    if (refs == 0) {
263 264 265 266 267 268 269 270 271 272 273 274 275
        /* make sure to release the connection lock before we call the
         * close() callbacks, otherwise we will deadlock if an error
         * is raised by any of the callbacks
         */
        virMutexUnlock(&conn->lock);
        if (conn->networkDriver)
            conn->networkDriver->close (conn);
        if (conn->interfaceDriver)
            conn->interfaceDriver->close (conn);
        if (conn->storageDriver)
            conn->storageDriver->close (conn);
        if (conn->deviceMonitor)
            conn->deviceMonitor->close (conn);
276 277
        if (conn->secretDriver)
            conn->secretDriver->close (conn);
278 279 280 281 282 283 284
        if (conn->driver)
            conn->driver->close (conn);

        /* reacquire the connection lock since virReleaseConnect expects
         * it to already be held
         */
        virMutexLock(&conn->lock);
285 286 287 288
        virReleaseConnect(conn);
        /* Already unlocked mutex */
        return (0);
    }
289
    virMutexUnlock(&conn->lock);
290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306
    return (refs);
}

/**
 * virGetDomain:
 * @conn: the hypervisor connection
 * @name: pointer to the domain name
 * @uuid: pointer to the uuid
 *
 * Lookup if the domain is already registered for that connection,
 * if yes return a new pointer to it, if no allocate a new structure,
 * and register it in the table. In any case a corresponding call to
 * virUnrefDomain() is needed to not leak data.
 *
 * Returns a pointer to the domain, or NULL in case of failure
 */
virDomainPtr
D
Daniel P. Berrange 已提交
307
virGetDomain(virConnectPtr conn, const char *name, const unsigned char *uuid) {
308 309 310
    virDomainPtr ret = NULL;

    if ((!VIR_IS_CONNECT(conn)) || (name == NULL) || (uuid == NULL)) {
311
        virLibConnError(NULL, VIR_ERR_INVALID_ARG, __FUNCTION__);
312 313
        return(NULL);
    }
314
    virMutexLock(&conn->lock);
315 316 317 318 319 320 321

    /* TODO search by UUID first as they are better differenciators */

    ret = (virDomainPtr) virHashLookup(conn->domains, name);
    /* TODO check the UUID */
    if (ret == NULL) {
        if (VIR_ALLOC(ret) < 0) {
322
            virMutexUnlock(&conn->lock);
323
            virReportOOMError(conn);
324 325 326 327
            goto error;
        }
        ret->name = strdup(name);
        if (ret->name == NULL) {
328
            virMutexUnlock(&conn->lock);
329
            virReportOOMError(conn);
330 331 332 333 334 335 336 337 338
            goto error;
        }
        ret->magic = VIR_DOMAIN_MAGIC;
        ret->conn = conn;
        ret->id = -1;
        if (uuid != NULL)
            memcpy(&(ret->uuid[0]), uuid, VIR_UUID_BUFLEN);

        if (virHashAddEntry(conn->domains, name, ret) < 0) {
339
            virMutexUnlock(&conn->lock);
340
            virLibConnError(conn, VIR_ERR_INTERNAL_ERROR,
341
                            "%s", _("failed to add domain to connection hash table"));
342 343 344 345 346 347 348 349
            goto error;
        }
        conn->refs++;
        DEBUG("New hash entry %p", ret);
    } else {
        DEBUG("Existing hash entry %p: refs now %d", ret, ret->refs+1);
    }
    ret->refs++;
350
    virMutexUnlock(&conn->lock);
351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378
    return(ret);

 error:
    if (ret != NULL) {
        VIR_FREE(ret->name);
        VIR_FREE(ret);
    }
    return(NULL);
}

/**
 * virReleaseDomain:
 * @domain: the domain to release
 *
 * Unconditionally release all memory associated with a domain.
 * The conn.lock mutex must be held prior to calling this, and will
 * be released prior to this returning. The domain obj must not
 * be used once this method returns.
 *
 * It will also unreference the associated connection object,
 * which may also be released if its ref count hits zero.
 */
static void
virReleaseDomain(virDomainPtr domain) {
    virConnectPtr conn = domain->conn;
    DEBUG("release domain %p %s", domain, domain->name);

    /* TODO search by UUID first as they are better differenciators */
379 380
    if (virHashRemoveEntry(conn->domains, domain->name, NULL) < 0) {
        virMutexUnlock(&conn->lock);
381
        virLibConnError(conn, VIR_ERR_INTERNAL_ERROR,
382
                        "%s", _("domain missing from connection hash table"));
383 384
        conn = NULL;
    }
385 386 387 388 389 390

    domain->magic = -1;
    domain->id = -1;
    VIR_FREE(domain->name);
    VIR_FREE(domain);

391 392 393 394 395 396 397 398 399
    if (conn) {
        DEBUG("unref connection %p %d", conn, conn->refs);
        conn->refs--;
        if (conn->refs == 0) {
            virReleaseConnect(conn);
            /* Already unlocked mutex */
            return;
        }
        virMutexUnlock(&conn->lock);
400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417
    }
}


/**
 * virUnrefDomain:
 * @domain: the domain to unreference
 *
 * Unreference the domain. If the use count drops to zero, the structure is
 * actually freed.
 *
 * Returns the reference count or -1 in case of failure.
 */
int
virUnrefDomain(virDomainPtr domain) {
    int refs;

    if (!VIR_IS_CONNECTED_DOMAIN(domain)) {
418
        virLibConnError(NULL, VIR_ERR_INVALID_ARG, __FUNCTION__);
419 420
        return(-1);
    }
421
    virMutexLock(&domain->conn->lock);
422 423 424 425 426 427 428 429 430
    DEBUG("unref domain %p %s %d", domain, domain->name, domain->refs);
    domain->refs--;
    refs = domain->refs;
    if (refs == 0) {
        virReleaseDomain(domain);
        /* Already unlocked mutex */
        return (0);
    }

431
    virMutexUnlock(&domain->conn->lock);
432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448
    return (refs);
}

/**
 * virGetNetwork:
 * @conn: the hypervisor connection
 * @name: pointer to the network name
 * @uuid: pointer to the uuid
 *
 * Lookup if the network is already registered for that connection,
 * if yes return a new pointer to it, if no allocate a new structure,
 * and register it in the table. In any case a corresponding call to
 * virUnrefNetwork() is needed to not leak data.
 *
 * Returns a pointer to the network, or NULL in case of failure
 */
virNetworkPtr
D
Daniel P. Berrange 已提交
449
virGetNetwork(virConnectPtr conn, const char *name, const unsigned char *uuid) {
450 451 452
    virNetworkPtr ret = NULL;

    if ((!VIR_IS_CONNECT(conn)) || (name == NULL) || (uuid == NULL)) {
453
        virLibConnError(NULL, VIR_ERR_INVALID_ARG, __FUNCTION__);
454 455
        return(NULL);
    }
456
    virMutexLock(&conn->lock);
457 458 459 460 461 462 463

    /* TODO search by UUID first as they are better differenciators */

    ret = (virNetworkPtr) virHashLookup(conn->networks, name);
    /* TODO check the UUID */
    if (ret == NULL) {
        if (VIR_ALLOC(ret) < 0) {
464
            virMutexUnlock(&conn->lock);
465
            virReportOOMError(conn);
466 467 468 469
            goto error;
        }
        ret->name = strdup(name);
        if (ret->name == NULL) {
470
            virMutexUnlock(&conn->lock);
471
            virReportOOMError(conn);
472 473 474 475 476 477 478 479
            goto error;
        }
        ret->magic = VIR_NETWORK_MAGIC;
        ret->conn = conn;
        if (uuid != NULL)
            memcpy(&(ret->uuid[0]), uuid, VIR_UUID_BUFLEN);

        if (virHashAddEntry(conn->networks, name, ret) < 0) {
480
            virMutexUnlock(&conn->lock);
481
            virLibConnError(conn, VIR_ERR_INTERNAL_ERROR,
482
                            "%s", _("failed to add network to connection hash table"));
483 484 485 486 487
            goto error;
        }
        conn->refs++;
    }
    ret->refs++;
488
    virMutexUnlock(&conn->lock);
489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516
    return(ret);

 error:
    if (ret != NULL) {
        VIR_FREE(ret->name);
        VIR_FREE(ret);
    }
    return(NULL);
}

/**
 * virReleaseNetwork:
 * @network: the network to release
 *
 * Unconditionally release all memory associated with a network.
 * The conn.lock mutex must be held prior to calling this, and will
 * be released prior to this returning. The network obj must not
 * be used once this method returns.
 *
 * It will also unreference the associated connection object,
 * which may also be released if its ref count hits zero.
 */
static void
virReleaseNetwork(virNetworkPtr network) {
    virConnectPtr conn = network->conn;
    DEBUG("release network %p %s", network, network->name);

    /* TODO search by UUID first as they are better differenciators */
517 518
    if (virHashRemoveEntry(conn->networks, network->name, NULL) < 0) {
        virMutexUnlock(&conn->lock);
519
        virLibConnError(conn, VIR_ERR_INTERNAL_ERROR,
520
                        "%s", _("network missing from connection hash table"));
521 522
        conn = NULL;
    }
523 524 525 526 527

    network->magic = -1;
    VIR_FREE(network->name);
    VIR_FREE(network);

528 529 530 531 532 533 534 535 536
    if (conn) {
        DEBUG("unref connection %p %d", conn, conn->refs);
        conn->refs--;
        if (conn->refs == 0) {
            virReleaseConnect(conn);
            /* Already unlocked mutex */
            return;
        }
        virMutexUnlock(&conn->lock);
537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554
    }
}


/**
 * virUnrefNetwork:
 * @network: the network to unreference
 *
 * Unreference the network. If the use count drops to zero, the structure is
 * actually freed.
 *
 * Returns the reference count or -1 in case of failure.
 */
int
virUnrefNetwork(virNetworkPtr network) {
    int refs;

    if (!VIR_IS_CONNECTED_NETWORK(network)) {
555
        virLibConnError(NULL, VIR_ERR_INVALID_ARG, __FUNCTION__);
556 557
        return(-1);
    }
558
    virMutexLock(&network->conn->lock);
559 560 561 562 563 564 565 566 567
    DEBUG("unref network %p %s %d", network, network->name, network->refs);
    network->refs--;
    refs = network->refs;
    if (refs == 0) {
        virReleaseNetwork(network);
        /* Already unlocked mutex */
        return (0);
    }

568
    virMutexUnlock(&network->conn->lock);
569 570 571 572
    return (refs);
}


D
Daniel Veillard 已提交
573 574 575 576 577 578 579
/**
 * virGetInterface:
 * @conn: the hypervisor connection
 * @name: pointer to the interface name
 * @mac: pointer to the mac
 *
 * Lookup if the interface is already registered for that connection,
580 581 582 583
 * if yes return a new pointer to it (possibly updating the MAC
 * address), if no allocate a new structure, and register it in the
 * table. In any case a corresponding call to virUnrefInterface() is
 * needed to not leak data.
D
Daniel Veillard 已提交
584 585 586 587 588 589 590
 *
 * Returns a pointer to the interface, or NULL in case of failure
 */
virInterfacePtr
virGetInterface(virConnectPtr conn, const char *name, const char *mac) {
    virInterfacePtr ret = NULL;

591
    if ((!VIR_IS_CONNECT(conn)) || (name == NULL)) {
D
Daniel Veillard 已提交
592 593 594
        virLibConnError(NULL, VIR_ERR_INVALID_ARG, __FUNCTION__);
        return(NULL);
    }
595 596 597 598 599

    /* a NULL mac from caller is okay. Treat it as blank */
    if (mac == NULL)
       mac = "";

D
Daniel Veillard 已提交
600 601 602
    virMutexLock(&conn->lock);

    ret = (virInterfacePtr) virHashLookup(conn->interfaces, name);
603

604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635
    if (ret != NULL) {
        if (STRCASENEQ(ret->mac, mac)) {
            /*
             * If the mac address has changed, try to modify it in
             * place, which will only work if the new mac is the
             * same length as, or shorter than, the old mac.
             */
            size_t newmaclen = strlen(mac);
            size_t oldmaclen = strlen(ret->mac);
            if (newmaclen <= oldmaclen) {
                strcpy(ret->mac, mac);
            } else {
                /*
                 * If it's longer, we're kind of screwed, because we
                 * can't add a new hashtable entry (it would clash
                 * with the existing entry of same name), and we can't
                 * free/re-alloc the existing entry's mac, as some
                 * other thread may already be using the existing mac
                 * pointer.  Fortunately, this should never happen,
                 * since the length of the mac address for any
                 * interface is determined by the type of the
                 * interface, and that is unlikely to change.
                 */
                virMutexUnlock(&conn->lock);
                virLibConnError(conn, VIR_ERR_INTERNAL_ERROR,
_("Failed to change interface mac address from %s to %s due to differing lengths."),
                                ret->mac, mac);
                ret = NULL;
                goto error;
            }
        }
    } else {
D
Daniel Veillard 已提交
636
        if (VIR_ALLOC(ret) < 0) {
637
            virMutexUnlock(&conn->lock);
D
Daniel Veillard 已提交
638 639 640 641 642
            virReportOOMError(conn);
            goto error;
        }
        ret->name = strdup(name);
        if (ret->name == NULL) {
643
            virMutexUnlock(&conn->lock);
D
Daniel Veillard 已提交
644 645 646 647 648
            virReportOOMError(conn);
            goto error;
        }
        ret->mac = strdup(mac);
        if (ret->mac == NULL) {
649
            virMutexUnlock(&conn->lock);
D
Daniel Veillard 已提交
650 651 652 653 654 655 656 657
            virReportOOMError(conn);
            goto error;
        }

        ret->magic = VIR_INTERFACE_MAGIC;
        ret->conn = conn;

        if (virHashAddEntry(conn->interfaces, name, ret) < 0) {
658
            virMutexUnlock(&conn->lock);
D
Daniel Veillard 已提交
659
            virLibConnError(conn, VIR_ERR_INTERNAL_ERROR,
660
                            "%s", _("failed to add interface to connection hash table"));
D
Daniel Veillard 已提交
661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681
            goto error;
        }
        conn->refs++;
    }
    ret->refs++;
    virMutexUnlock(&conn->lock);
    return(ret);

 error:
    if (ret != NULL) {
        VIR_FREE(ret->name);
        VIR_FREE(ret->mac);
        VIR_FREE(ret);
    }
    return(NULL);
}

/**
 * virReleaseInterface:
 * @interface: the interface to release
 *
D
Dan Kenigsberg 已提交
682
 * Unconditionally release all memory associated with an interface.
D
Daniel Veillard 已提交
683 684 685 686 687 688 689 690
 * The conn.lock mutex must be held prior to calling this, and will
 * be released prior to this returning. The interface obj must not
 * be used once this method returns.
 *
 * It will also unreference the associated connection object,
 * which may also be released if its ref count hits zero.
 */
static void
691 692 693
virReleaseInterface(virInterfacePtr iface) {
    virConnectPtr conn = iface->conn;
    DEBUG("release interface %p %s", iface, iface->name);
D
Daniel Veillard 已提交
694

695 696 697
    if (virHashRemoveEntry(conn->interfaces, iface->name, NULL) < 0) {
        /* unlock before reporting error because error report grabs lock */
        virMutexUnlock(&conn->lock);
D
Daniel Veillard 已提交
698
        virLibConnError(conn, VIR_ERR_INTERNAL_ERROR,
699
                        "%s", _("interface missing from connection hash table"));
700 701 702
        /* don't decr the conn refct if we weren't connected to it */
        conn = NULL;
    }
D
Daniel Veillard 已提交
703

704 705 706 707
    iface->magic = -1;
    VIR_FREE(iface->name);
    VIR_FREE(iface->mac);
    VIR_FREE(iface);
D
Daniel Veillard 已提交
708

709 710 711 712 713 714 715 716 717
    if (conn) {
        DEBUG("unref connection %p %d", conn, conn->refs);
        conn->refs--;
        if (conn->refs == 0) {
            virReleaseConnect(conn);
            /* Already unlocked mutex */
            return;
        }
        virMutexUnlock(&conn->lock);
D
Daniel Veillard 已提交
718 719 720 721 722 723 724 725 726 727 728 729 730 731
    }
}


/**
 * virUnrefInterface:
 * @interface: the interface to unreference
 *
 * Unreference the interface. If the use count drops to zero, the structure is
 * actually freed.
 *
 * Returns the reference count or -1 in case of failure.
 */
int
732
virUnrefInterface(virInterfacePtr iface) {
D
Daniel Veillard 已提交
733 734
    int refs;

735
    if (!VIR_IS_CONNECTED_INTERFACE(iface)) {
D
Daniel Veillard 已提交
736 737 738
        virLibConnError(NULL, VIR_ERR_INVALID_ARG, __FUNCTION__);
        return(-1);
    }
739 740 741 742
    virMutexLock(&iface->conn->lock);
    DEBUG("unref interface %p %s %d", iface, iface->name, iface->refs);
    iface->refs--;
    refs = iface->refs;
D
Daniel Veillard 已提交
743
    if (refs == 0) {
744
        virReleaseInterface(iface);
D
Daniel Veillard 已提交
745 746 747 748
        /* Already unlocked mutex */
        return (0);
    }

749
    virMutexUnlock(&iface->conn->lock);
D
Daniel Veillard 已提交
750 751 752 753
    return (refs);
}


754 755 756 757 758 759 760 761 762 763 764 765 766 767
/**
 * virGetStoragePool:
 * @conn: the hypervisor connection
 * @name: pointer to the storage pool name
 * @uuid: pointer to the uuid
 *
 * Lookup if the storage pool is already registered for that connection,
 * if yes return a new pointer to it, if no allocate a new structure,
 * and register it in the table. In any case a corresponding call to
 * virFreeStoragePool() is needed to not leak data.
 *
 * Returns a pointer to the network, or NULL in case of failure
 */
virStoragePoolPtr
D
Daniel P. Berrange 已提交
768
virGetStoragePool(virConnectPtr conn, const char *name, const unsigned char *uuid) {
769 770 771
    virStoragePoolPtr ret = NULL;

    if ((!VIR_IS_CONNECT(conn)) || (name == NULL) || (uuid == NULL)) {
772
        virLibConnError(NULL, VIR_ERR_INVALID_ARG, __FUNCTION__);
773 774
        return(NULL);
    }
775
    virMutexLock(&conn->lock);
776 777 778 779 780 781 782

    /* TODO search by UUID first as they are better differenciators */

    ret = (virStoragePoolPtr) virHashLookup(conn->storagePools, name);
    /* TODO check the UUID */
    if (ret == NULL) {
        if (VIR_ALLOC(ret) < 0) {
783
            virMutexUnlock(&conn->lock);
784
            virReportOOMError(conn);
785 786 787 788
            goto error;
        }
        ret->name = strdup(name);
        if (ret->name == NULL) {
789
            virMutexUnlock(&conn->lock);
790
            virReportOOMError(conn);
791 792 793 794 795 796 797 798
            goto error;
        }
        ret->magic = VIR_STORAGE_POOL_MAGIC;
        ret->conn = conn;
        if (uuid != NULL)
            memcpy(&(ret->uuid[0]), uuid, VIR_UUID_BUFLEN);

        if (virHashAddEntry(conn->storagePools, name, ret) < 0) {
799
            virMutexUnlock(&conn->lock);
800
            virLibConnError(conn, VIR_ERR_INTERNAL_ERROR,
801
                            "%s", _("failed to add storage pool to connection hash table"));
802 803 804 805 806
            goto error;
        }
        conn->refs++;
    }
    ret->refs++;
807
    virMutexUnlock(&conn->lock);
808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836
    return(ret);

error:
    if (ret != NULL) {
        VIR_FREE(ret->name);
        VIR_FREE(ret);
    }
    return(NULL);
}


/**
 * virReleaseStoragePool:
 * @pool: the pool to release
 *
 * Unconditionally release all memory associated with a pool.
 * The conn.lock mutex must be held prior to calling this, and will
 * be released prior to this returning. The pool obj must not
 * be used once this method returns.
 *
 * It will also unreference the associated connection object,
 * which may also be released if its ref count hits zero.
 */
static void
virReleaseStoragePool(virStoragePoolPtr pool) {
    virConnectPtr conn = pool->conn;
    DEBUG("release pool %p %s", pool, pool->name);

    /* TODO search by UUID first as they are better differenciators */
837 838
    if (virHashRemoveEntry(conn->storagePools, pool->name, NULL) < 0) {
        virMutexUnlock(&conn->lock);
839
        virLibConnError(conn, VIR_ERR_INTERNAL_ERROR,
840
                        "%s", _("pool missing from connection hash table"));
841 842
        conn = NULL;
    }
843 844 845 846 847

    pool->magic = -1;
    VIR_FREE(pool->name);
    VIR_FREE(pool);

848 849 850 851 852 853 854 855 856
    if (conn) {
        DEBUG("unref connection %p %d", conn, conn->refs);
        conn->refs--;
        if (conn->refs == 0) {
            virReleaseConnect(conn);
            /* Already unlocked mutex */
            return;
        }
        virMutexUnlock(&conn->lock);
857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874
    }
}


/**
 * virUnrefStoragePool:
 * @pool: the pool to unreference
 *
 * Unreference the pool. If the use count drops to zero, the structure is
 * actually freed.
 *
 * Returns the reference count or -1 in case of failure.
 */
int
virUnrefStoragePool(virStoragePoolPtr pool) {
    int refs;

    if (!VIR_IS_CONNECTED_STORAGE_POOL(pool)) {
875
        virLibConnError(NULL, VIR_ERR_INVALID_ARG, __FUNCTION__);
876 877
        return(-1);
    }
878
    virMutexLock(&pool->conn->lock);
879 880 881 882 883 884 885 886 887
    DEBUG("unref pool %p %s %d", pool, pool->name, pool->refs);
    pool->refs--;
    refs = pool->refs;
    if (refs == 0) {
        virReleaseStoragePool(pool);
        /* Already unlocked mutex */
        return (0);
    }

888
    virMutexUnlock(&pool->conn->lock);
889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907
    return (refs);
}


/**
 * virGetStorageVol:
 * @conn: the hypervisor connection
 * @pool: pool owning the volume
 * @name: pointer to the storage vol name
 * @uuid: pointer to the uuid
 *
 * Lookup if the storage vol is already registered for that connection,
 * if yes return a new pointer to it, if no allocate a new structure,
 * and register it in the table. In any case a corresponding call to
 * virFreeStorageVol() is needed to not leak data.
 *
 * Returns a pointer to the storage vol, or NULL in case of failure
 */
virStorageVolPtr
D
Daniel P. Berrange 已提交
908
virGetStorageVol(virConnectPtr conn, const char *pool, const char *name, const char *key) {
909 910 911
    virStorageVolPtr ret = NULL;

    if ((!VIR_IS_CONNECT(conn)) || (name == NULL) || (key == NULL)) {
912
        virLibConnError(NULL, VIR_ERR_INVALID_ARG, __FUNCTION__);
913 914
        return(NULL);
    }
915
    virMutexLock(&conn->lock);
916 917 918 919

    ret = (virStorageVolPtr) virHashLookup(conn->storageVols, key);
    if (ret == NULL) {
        if (VIR_ALLOC(ret) < 0) {
920
            virMutexUnlock(&conn->lock);
921
            virReportOOMError(conn);
922 923 924 925
            goto error;
        }
        ret->pool = strdup(pool);
        if (ret->pool == NULL) {
926
            virMutexUnlock(&conn->lock);
927
            virReportOOMError(conn);
928 929 930 931
            goto error;
        }
        ret->name = strdup(name);
        if (ret->name == NULL) {
932
            virMutexUnlock(&conn->lock);
933
            virReportOOMError(conn);
934 935
            goto error;
        }
C
Chris Lalancette 已提交
936 937 938 939 940 941
        if (virStrcpyStatic(ret->key, key) == NULL) {
            virMutexUnlock(&conn->lock);
            virLibConnError(conn, VIR_ERR_INTERNAL_ERROR,
                            _("Volume key %s too large for destination"), key);
            goto error;
        }
942 943 944 945
        ret->magic = VIR_STORAGE_VOL_MAGIC;
        ret->conn = conn;

        if (virHashAddEntry(conn->storageVols, key, ret) < 0) {
946
            virMutexUnlock(&conn->lock);
947
            virLibConnError(conn, VIR_ERR_INTERNAL_ERROR,
948
                            "%s", _("failed to add storage vol to connection hash table"));
949 950 951 952 953
            goto error;
        }
        conn->refs++;
    }
    ret->refs++;
954
    virMutexUnlock(&conn->lock);
955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984
    return(ret);

error:
    if (ret != NULL) {
        VIR_FREE(ret->name);
        VIR_FREE(ret->pool);
        VIR_FREE(ret);
    }
    return(NULL);
}


/**
 * virReleaseStorageVol:
 * @vol: the vol to release
 *
 * Unconditionally release all memory associated with a vol.
 * The conn.lock mutex must be held prior to calling this, and will
 * be released prior to this returning. The vol obj must not
 * be used once this method returns.
 *
 * It will also unreference the associated connection object,
 * which may also be released if its ref count hits zero.
 */
static void
virReleaseStorageVol(virStorageVolPtr vol) {
    virConnectPtr conn = vol->conn;
    DEBUG("release vol %p %s", vol, vol->name);

    /* TODO search by UUID first as they are better differenciators */
985 986
    if (virHashRemoveEntry(conn->storageVols, vol->key, NULL) < 0) {
        virMutexUnlock(&conn->lock);
987
        virLibConnError(conn, VIR_ERR_INTERNAL_ERROR,
988
                        "%s", _("vol missing from connection hash table"));
989 990
        conn = NULL;
    }
991 992 993 994 995 996

    vol->magic = -1;
    VIR_FREE(vol->name);
    VIR_FREE(vol->pool);
    VIR_FREE(vol);

997 998 999 1000 1001 1002 1003 1004 1005
    if (conn) {
        DEBUG("unref connection %p %d", conn, conn->refs);
        conn->refs--;
        if (conn->refs == 0) {
            virReleaseConnect(conn);
            /* Already unlocked mutex */
            return;
        }
        virMutexUnlock(&conn->lock);
1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023
    }
}


/**
 * virUnrefStorageVol:
 * @vol: the vol to unreference
 *
 * Unreference the vol. If the use count drops to zero, the structure is
 * actually freed.
 *
 * Returns the reference count or -1 in case of failure.
 */
int
virUnrefStorageVol(virStorageVolPtr vol) {
    int refs;

    if (!VIR_IS_CONNECTED_STORAGE_VOL(vol)) {
1024
        virLibConnError(NULL, VIR_ERR_INVALID_ARG, __FUNCTION__);
1025 1026
        return(-1);
    }
1027
    virMutexLock(&vol->conn->lock);
1028 1029 1030 1031 1032 1033 1034 1035 1036
    DEBUG("unref vol %p %s %d", vol, vol->name, vol->refs);
    vol->refs--;
    refs = vol->refs;
    if (refs == 0) {
        virReleaseStorageVol(vol);
        /* Already unlocked mutex */
        return (0);
    }

1037
    virMutexUnlock(&vol->conn->lock);
1038 1039
    return (refs);
}
1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059


/**
 * virGetNodeDevice:
 * @conn: the hypervisor connection
 * @name: device name (unique on node)
 *
 * Lookup if the device is already registered for that connection,
 * if yes return a new pointer to it, if no allocate a new structure,
 * and register it in the table. In any case a corresponding call to
 * virFreeNodeDevice() is needed to not leak data.
 *
 * Returns a pointer to the node device, or NULL in case of failure
 */
virNodeDevicePtr
virGetNodeDevice(virConnectPtr conn, const char *name)
{
    virNodeDevicePtr ret = NULL;

    if ((!VIR_IS_CONNECT(conn)) || (name == NULL)) {
1060
        virLibConnError(NULL, VIR_ERR_INVALID_ARG, __FUNCTION__);
1061 1062
        return(NULL);
    }
1063
    virMutexLock(&conn->lock);
1064 1065 1066

    ret = (virNodeDevicePtr) virHashLookup(conn->nodeDevices, name);
    if (ret == NULL) {
1067 1068
        if (VIR_ALLOC(ret) < 0) {
            virMutexUnlock(&conn->lock);
1069
            virReportOOMError(conn);
1070 1071 1072 1073 1074 1075
            goto error;
        }
        ret->magic = VIR_NODE_DEVICE_MAGIC;
        ret->conn = conn;
        ret->name = strdup(name);
        if (ret->name == NULL) {
1076
            virMutexUnlock(&conn->lock);
1077
            virReportOOMError(conn);
1078 1079 1080 1081
            goto error;
        }

        if (virHashAddEntry(conn->nodeDevices, name, ret) < 0) {
1082
            virMutexUnlock(&conn->lock);
1083
            virLibConnError(conn, VIR_ERR_INTERNAL_ERROR,
1084
                            "%s", _("failed to add node dev to conn hash table"));
1085 1086 1087 1088 1089
            goto error;
        }
        conn->refs++;
    }
    ret->refs++;
1090
    virMutexUnlock(&conn->lock);
1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118
    return(ret);

error:
    if (ret != NULL) {
        VIR_FREE(ret->name);
        VIR_FREE(ret);
    }
    return(NULL);
}


/**
 * virReleaseNodeDevice:
 * @dev: the dev to release
 *
 * Unconditionally release all memory associated with a dev.
 * The conn.lock mutex must be held prior to calling this, and will
 * be released prior to this returning. The dev obj must not
 * be used once this method returns.
 *
 * It will also unreference the associated connection object,
 * which may also be released if its ref count hits zero.
 */
static void
virReleaseNodeDevice(virNodeDevicePtr dev) {
    virConnectPtr conn = dev->conn;
    DEBUG("release dev %p %s", dev, dev->name);

1119 1120
    if (virHashRemoveEntry(conn->nodeDevices, dev->name, NULL) < 0) {
        virMutexUnlock(&conn->lock);
1121
        virLibConnError(conn, VIR_ERR_INTERNAL_ERROR,
1122
                        "%s", _("dev missing from connection hash table"));
1123 1124
        conn = NULL;
    }
1125 1126 1127

    dev->magic = -1;
    VIR_FREE(dev->name);
1128
    VIR_FREE(dev->parent);
1129 1130
    VIR_FREE(dev);

1131 1132 1133 1134 1135 1136 1137 1138 1139
    if (conn) {
        DEBUG("unref connection %p %d", conn, conn->refs);
        conn->refs--;
        if (conn->refs == 0) {
            virReleaseConnect(conn);
            /* Already unlocked mutex */
            return;
        }
        virMutexUnlock(&conn->lock);
1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156
    }
}


/**
 * virUnrefNodeDevice:
 * @dev: the dev to unreference
 *
 * Unreference the dev. If the use count drops to zero, the structure is
 * actually freed.
 *
 * Returns the reference count or -1 in case of failure.
 */
int
virUnrefNodeDevice(virNodeDevicePtr dev) {
    int refs;

1157
    virMutexLock(&dev->conn->lock);
1158 1159 1160 1161 1162 1163 1164 1165 1166
    DEBUG("unref dev %p %s %d", dev, dev->name, dev->refs);
    dev->refs--;
    refs = dev->refs;
    if (refs == 0) {
        virReleaseNodeDevice(dev);
        /* Already unlocked mutex */
        return (0);
    }

1167
    virMutexUnlock(&dev->conn->lock);
1168 1169
    return (refs);
}
1170

1171

1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184
/**
 * virGetSecret:
 * @conn: the hypervisor connection
 * @uuid: secret UUID
 *
 * Lookup if the secret is already registered for that connection, if so return
 * a pointer to it, otherwise allocate a new structure, and register it in the
 * table. In any case a corresponding call to virFreeSecret() is needed to not
 * leak data.
 *
 * Returns a pointer to the secret, or NULL in case of failure
 */
virSecretPtr
1185 1186
virGetSecret(virConnectPtr conn, const unsigned char *uuid,
             int usageType, const char *usageID)
1187 1188
{
    virSecretPtr ret = NULL;
1189
    char uuidstr[VIR_UUID_STRING_BUFLEN];
1190

1191
    if (!VIR_IS_CONNECT(conn) || uuid == NULL || usageID == NULL) {
1192 1193 1194 1195 1196
        virLibConnError(NULL, VIR_ERR_INVALID_ARG, __FUNCTION__);
        return NULL;
    }
    virMutexLock(&conn->lock);

1197 1198 1199
    virUUIDFormat(uuid, uuidstr);

    ret = virHashLookup(conn->secrets, uuidstr);
1200 1201 1202 1203 1204 1205 1206 1207
    if (ret == NULL) {
        if (VIR_ALLOC(ret) < 0) {
            virMutexUnlock(&conn->lock);
            virReportOOMError(conn);
            goto error;
        }
        ret->magic = VIR_SECRET_MAGIC;
        ret->conn = conn;
1208
        memcpy(&(ret->uuid[0]), uuid, VIR_UUID_BUFLEN);
1209 1210 1211 1212 1213 1214
        ret->usageType = usageType;
        if (!(ret->usageID = strdup(usageID))) {
            virMutexUnlock(&conn->lock);
            virReportOOMError(conn);
            goto error;
        }
1215
        if (virHashAddEntry(conn->secrets, uuidstr, ret) < 0) {
1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228
            virMutexUnlock(&conn->lock);
            virLibConnError(conn, VIR_ERR_INTERNAL_ERROR,
                            "%s", _("failed to add secret to conn hash table"));
            goto error;
        }
        conn->refs++;
    }
    ret->refs++;
    virMutexUnlock(&conn->lock);
    return ret;

error:
    if (ret != NULL) {
1229
        VIR_FREE(ret->usageID);
1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249
        VIR_FREE(ret->uuid);
        VIR_FREE(ret);
    }
    return NULL;
}

/**
 * virReleaseSecret:
 * @secret: the secret to release
 *
 * Unconditionally release all memory associated with a secret.  The conn.lock
 * mutex must be held prior to calling this, and will be released prior to this
 * returning. The secret obj must not be used once this method returns.
 *
 * It will also unreference the associated connection object, which may also be
 * released if its ref count hits zero.
 */
static void
virReleaseSecret(virSecretPtr secret) {
    virConnectPtr conn = secret->conn;
1250 1251
    char uuidstr[VIR_UUID_STRING_BUFLEN];
    DEBUG("release secret %p %p", secret, secret->uuid);
1252

1253 1254
    virUUIDFormat(secret->uuid, uuidstr);
    if (virHashRemoveEntry(conn->secrets, uuidstr, NULL) < 0) {
1255 1256 1257 1258 1259 1260
        virMutexUnlock(&conn->lock);
        virLibConnError(conn, VIR_ERR_INTERNAL_ERROR,
                        "%s", _("secret missing from connection hash table"));
        conn = NULL;
    }

1261
    VIR_FREE(secret->usageID);
1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294
    secret->magic = -1;
    VIR_FREE(secret);

    if (conn) {
        DEBUG("unref connection %p %d", conn, conn->refs);
        conn->refs--;
        if (conn->refs == 0) {
            virReleaseConnect(conn);
            /* Already unlocked mutex */
            return;
        }
        virMutexUnlock(&conn->lock);
    }
}

/**
 * virUnrefSecret:
 * @secret: the secret to unreference
 *
 * Unreference the secret. If the use count drops to zero, the structure is
 * actually freed.
 *
 * Returns the reference count or -1 in case of failure.
 */
int
virUnrefSecret(virSecretPtr secret) {
    int refs;

    if (!VIR_IS_CONNECTED_SECRET(secret)) {
        virLibConnError(NULL, VIR_ERR_INVALID_ARG, __FUNCTION__);
        return -1;
    }
    virMutexLock(&secret->conn->lock);
1295
    DEBUG("unref secret %p %p %d", secret, secret->uuid, secret->refs);
1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306
    secret->refs--;
    refs = secret->refs;
    if (refs == 0) {
        virReleaseSecret(secret);
        /* Already unlocked mutex */
        return 0;
    }

    virMutexUnlock(&secret->conn->lock);
    return refs;
}
1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364

virStreamPtr virGetStream(virConnectPtr conn) {
    virStreamPtr ret = NULL;

    virMutexLock(&conn->lock);

    if (VIR_ALLOC(ret) < 0) {
        virReportOOMError(conn);
        goto error;
    }
    ret->magic = VIR_STREAM_MAGIC;
    ret->conn = conn;
    conn->refs++;
    ret->refs++;
    virMutexUnlock(&conn->lock);
    return(ret);

error:
    virMutexUnlock(&conn->lock);
    VIR_FREE(ret);
    return(NULL);
}

static void
virReleaseStream(virStreamPtr st) {
    virConnectPtr conn = st->conn;
    DEBUG("release dev %p", st);

    st->magic = -1;
    VIR_FREE(st);

    DEBUG("unref connection %p %d", conn, conn->refs);
    conn->refs--;
    if (conn->refs == 0) {
        virReleaseConnect(conn);
        /* Already unlocked mutex */
        return;
    }

    virMutexUnlock(&conn->lock);
}

int virUnrefStream(virStreamPtr st) {
    int refs;

    virMutexLock(&st->conn->lock);
    DEBUG("unref stream %p %d", st, st->refs);
    st->refs--;
    refs = st->refs;
    if (refs == 0) {
        virReleaseStream(st);
        /* Already unlocked mutex */
        return (0);
    }

    virMutexUnlock(&st->conn->lock);
    return (refs);
}