viriscsi.c 16.6 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42
/*
 * viriscsi.c: helper APIs for managing iSCSI
 *
 * Copyright (C) 2007-2014 Red Hat, Inc.
 * Copyright (C) 2007-2008 Daniel P. Berrange
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library.  If not, see
 * <http://www.gnu.org/licenses/>.
 *
 */

#include <config.h>

#include <regex.h>
#include <stdio.h>

#include "viriscsi.h"

#include "viralloc.h"
#include "vircommand.h"
#include "virerror.h"
#include "virfile.h"
#include "virlog.h"
#include "virrandom.h"
#include "virstring.h"

#define VIR_FROM_THIS VIR_FROM_NONE

VIR_LOG_INIT("util.iscsi");


43 44 45
static int
virISCSIScanTargetsInternal(const char *portal,
                            const char *ifacename,
46
                            bool persist,
47 48 49 50
                            size_t *ntargetsret,
                            char ***targetsret);


51 52 53 54 55 56 57 58 59 60 61 62
struct virISCSISessionData {
    char *session;
    const char *devpath;
};


static int
virISCSIExtractSession(char **const groups,
                       void *opaque)
{
    struct virISCSISessionData *data = opaque;

63 64
    if (!data->session &&
        STREQ(groups[1], data->devpath))
65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90
        return VIR_STRDUP(data->session, groups[0]);
    return 0;
}


char *
virISCSIGetSession(const char *devpath,
                   bool probe)
{
    /*
     * # iscsiadm --mode session
     * tcp: [1] 192.168.122.170:3260,1 demo-tgt-b
     * tcp: [2] 192.168.122.170:3260,1 demo-tgt-a
     *
     * Pull out 2nd and 4th fields
     */
    const char *regexes[] = {
        "^tcp:\\s+\\[(\\S+)\\]\\s+\\S+\\s+(\\S+).*$"
    };
    int vars[] = {
        2,
    };
    struct virISCSISessionData cbdata = {
        .session = NULL,
        .devpath = devpath,
    };
91
    int exitstatus = 0;
92
    VIR_AUTOFREE(char *) error = NULL;
93

94
    VIR_AUTOPTR(virCommand) cmd = virCommandNewArgList(ISCSIADM, "--mode",
95 96
                                             "session", NULL);
    virCommandSetErrorBuffer(cmd, &error);
97 98 99 100 101 102

    if (virCommandRunRegex(cmd,
                           1,
                           regexes,
                           vars,
                           virISCSIExtractSession,
103
                           &cbdata, NULL, &exitstatus) < 0)
104
        return NULL;
105

106
    if (cbdata.session == NULL && !probe)
107
        virReportError(VIR_ERR_INTERNAL_ERROR,
108 109
                       _("cannot find iscsiadm session: %s"),
                       NULLSTR(error));
110 111 112 113 114 115 116 117 118 119 120 121 122 123

    return cbdata.session;
}



#define IQN_FOUND 1
#define IQN_MISSING 0
#define IQN_ERROR -1

static int
virStorageBackendIQNFound(const char *initiatoriqn,
                          char **ifacename)
{
124 125
    int ret = IQN_ERROR;
    char *line = NULL;
126 127 128
    VIR_AUTOFREE(char *) outbuf = NULL;
    VIR_AUTOFREE(char *) iface = NULL;
    VIR_AUTOFREE(char *) iqn = NULL;
129 130
    VIR_AUTOPTR(virCommand) cmd = virCommandNewArgList(ISCSIADM,
                                             "--mode", "iface", NULL);
131

132 133
    *ifacename = NULL;

134 135
    virCommandSetOutputBuffer(cmd, &outbuf);
    if (virCommandRun(cmd, NULL) < 0)
136
        goto cleanup;
137

138 139 140 141 142
    /* Example of data we are dealing with:
     * default tcp,<empty>,<empty>,<empty>,<empty>
     * iser iser,<empty>,<empty>,<empty>,<empty>
     * libvirt-iface-253db048 tcp,<empty>,<empty>,<empty>,iqn.2017-03.com.user:client
     */
143

144 145
    line = outbuf;
    while (line && *line) {
146
        char *current = line;
147
        char *newline;
148 149
        char *next;
        size_t i;
150

151 152 153 154 155 156 157
        if (!(newline = strchr(line, '\n')))
            break;

        *newline = '\0';

        VIR_FREE(iface);
        VIR_FREE(iqn);
158

159 160 161 162 163 164
        /* Find the first space, copy everything up to that point into
         * iface and move past it to continue processing */
        if (!(next = strchr(current, ' ')))
            goto error;

        if (VIR_STRNDUP(iface, current, (next - current)) < 0)
165
            goto cleanup;
166 167 168 169 170 171 172 173 174 175

        current = next + 1;

        /* There are five comma separated fields after iface and we only
         * care about the last one, so we need to skip four commas and
         * copy whatever's left into iqn */
        for (i = 0; i < 4; i++) {
            if (!(next = strchr(current, ',')))
                goto error;
            current = next + 1;
176 177
        }

178 179 180
        if (VIR_STRDUP(iqn, current) < 0)
            goto cleanup;

181
        if (STREQ(iqn, initiatoriqn)) {
182
            VIR_STEAL_PTR(*ifacename, iface);
183

184 185 186 187
            VIR_DEBUG("Found interface '%s' with IQN '%s'", *ifacename, iqn);
            break;
        }

188 189
        line = newline + 1;
    }
190 191

    ret = *ifacename ? IQN_FOUND : IQN_MISSING;
192

193
 cleanup:
194
    if (ret == IQN_MISSING)
195 196 197
        VIR_DEBUG("Could not find interface with IQN '%s'", iqn);

    return ret;
198 199 200 201 202 203

 error:
    virReportError(VIR_ERR_INTERNAL_ERROR,
                   _("malformed output of %s: %s"),
                   ISCSIADM, line);
    goto cleanup;
204 205 206 207 208 209 210 211
}


static int
virStorageBackendCreateIfaceIQN(const char *initiatoriqn,
                                char **ifacename)
{
    int ret = -1, exitstatus = -1;
212
    VIR_AUTOFREE(char *) temp_ifacename = NULL;
213
    VIR_AUTOPTR(virCommand) cmd = NULL;
214 215 216

    if (virAsprintf(&temp_ifacename,
                    "libvirt-iface-%08llx",
217
                    (unsigned long long)virRandomBits(32)) < 0)
218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270
        return -1;

    VIR_DEBUG("Attempting to create interface '%s' with IQN '%s'",
              temp_ifacename, initiatoriqn);

    cmd = virCommandNewArgList(ISCSIADM,
                               "--mode", "iface",
                               "--interface", temp_ifacename,
                               "--op", "new",
                               NULL);
    /* Note that we ignore the exitstatus.  Older versions of iscsiadm
     * tools returned an exit status of > 0, even if they succeeded.
     * We will just rely on whether the interface got created
     * properly. */
    if (virCommandRun(cmd, &exitstatus) < 0) {
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("Failed to run command '%s' to create new iscsi interface"),
                       ISCSIADM);
        goto cleanup;
    }
    virCommandFree(cmd);

    cmd = virCommandNewArgList(ISCSIADM,
                               "--mode", "iface",
                               "--interface", temp_ifacename,
                               "--op", "update",
                               "--name", "iface.initiatorname",
                               "--value",
                               initiatoriqn,
                               NULL);
    /* Note that we ignore the exitstatus.  Older versions of iscsiadm tools
     * returned an exit status of > 0, even if they succeeded.  We will just
     * rely on whether iface file got updated properly. */
    if (virCommandRun(cmd, &exitstatus) < 0) {
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("Failed to run command '%s' to update iscsi interface with IQN '%s'"),
                       ISCSIADM, initiatoriqn);
        goto cleanup;
    }

    /* Check again to make sure the interface was created. */
    if (virStorageBackendIQNFound(initiatoriqn, ifacename) != IQN_FOUND) {
        VIR_DEBUG("Failed to find interface '%s' with IQN '%s' "
                  "after attempting to create it",
                  &temp_ifacename[0], initiatoriqn);
        goto cleanup;
    } else {
        VIR_DEBUG("Interface '%s' with IQN '%s' was created successfully",
                  *ifacename, initiatoriqn);
    }

    ret = 0;

271
 cleanup:
272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290
    if (ret != 0)
        VIR_FREE(*ifacename);
    return ret;
}


static int
virISCSIConnection(const char *portal,
                   const char *initiatoriqn,
                   const char *target,
                   const char **extraargv)
{
    const char *const baseargv[] = {
        ISCSIADM,
        "--mode", "node",
        "--portal", portal,
        "--targetname", target,
        NULL
    };
291
    VIR_AUTOPTR(virCommand) cmd = NULL;
292
    VIR_AUTOFREE(char *) ifacename = NULL;
293 294 295 296 297 298 299 300 301 302

    cmd = virCommandNewArgs(baseargv);
    virCommandAddArgSet(cmd, extraargv);

    if (initiatoriqn) {
        switch (virStorageBackendIQNFound(initiatoriqn, &ifacename)) {
        case IQN_FOUND:
            VIR_DEBUG("ifacename: '%s'", ifacename);
            break;
        case IQN_MISSING:
303
            if (virStorageBackendCreateIfaceIQN(initiatoriqn, &ifacename) != 0)
304
                return -1;
305 306 307 308
            /*
             * iscsiadm doesn't let you send commands to the Interface IQN,
             * unless you've first issued a 'sendtargets' command to the
             * portal. Without the sendtargets all that is received is a
309
             * "iscsiadm: No records found". However, we must ensure that
310 311
             * the command is issued over interface name we invented above
             * and that targets are made persistent.
312
             */
313 314
            if (virISCSIScanTargetsInternal(portal, ifacename,
                                            true, NULL, NULL) < 0)
315
                return -1;
316

317 318 319
            break;
        case IQN_ERROR:
        default:
320
            return -1;
321 322 323 324 325
        }
        virCommandAddArgList(cmd, "--interface", ifacename, NULL);
    }

    if (virCommandRun(cmd, NULL) < 0)
326
        return -1;
327

328
    return 0;
329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354
}


int
virISCSIConnectionLogin(const char *portal,
                        const char *initiatoriqn,
                        const char *target)
{
    const char *extraargv[] = { "--login", NULL };
    return virISCSIConnection(portal, initiatoriqn, target, extraargv);
}


int
virISCSIConnectionLogout(const char *portal,
                         const char *initiatoriqn,
                         const char *target)
{
    const char *extraargv[] = { "--logout", NULL };
    return virISCSIConnection(portal, initiatoriqn, target, extraargv);
}


int
virISCSIRescanLUNs(const char *session)
{
355
    VIR_AUTOPTR(virCommand) cmd = virCommandNewArgList(ISCSIADM,
356 357 358 359
                                             "--mode", "session",
                                             "-r", session,
                                             "-R",
                                             NULL);
360
    return virCommandRun(cmd, NULL);
361 362 363 364 365 366 367 368 369 370 371 372 373 374
}


struct virISCSITargetList {
    size_t ntargets;
    char **targets;
};


static int
virISCSIGetTargets(char **const groups,
                   void *data)
{
    struct virISCSITargetList *list = data;
375
    VIR_AUTOFREE(char *) target = NULL;
376 377 378 379

    if (VIR_STRDUP(target, groups[1]) < 0)
        return -1;

380
    if (VIR_APPEND_ELEMENT(list->targets, list->ntargets, target) < 0)
381 382 383 384 385 386
        return -1;

    return 0;
}


387 388 389
static int
virISCSIScanTargetsInternal(const char *portal,
                            const char *ifacename,
390
                            bool persist,
391 392
                            size_t *ntargetsret,
                            char ***targetsret)
393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409
{
    /**
     *
     * The output of sendtargets is very simple, just two columns,
     * portal then target name
     *
     * 192.168.122.185:3260,1 iqn.2004-04.com:fedora14:iscsi.demo0.bf6d84
     * 192.168.122.185:3260,1 iqn.2004-04.com:fedora14:iscsi.demo1.bf6d84
     * 192.168.122.185:3260,1 iqn.2004-04.com:fedora14:iscsi.demo2.bf6d84
     * 192.168.122.185:3260,1 iqn.2004-04.com:fedora14:iscsi.demo3.bf6d84
     */
    const char *regexes[] = {
        "^\\s*(\\S+)\\s+(\\S+)\\s*$"
    };
    int vars[] = { 2 };
    struct virISCSITargetList list;
    size_t i;
410
    VIR_AUTOPTR(virCommand) cmd = virCommandNewArgList(ISCSIADM,
411 412 413 414 415
                                             "--mode", "discovery",
                                             "--type", "sendtargets",
                                             "--portal", portal,
                                             NULL);

416 417 418 419 420 421
    if (!persist) {
        virCommandAddArgList(cmd,
                             "--op", "nonpersistent",
                             NULL);
    }

422 423 424 425 426 427
    if (ifacename) {
        virCommandAddArgList(cmd,
                             "--interface", ifacename,
                             NULL);
    }

428 429 430 431 432 433 434
    memset(&list, 0, sizeof(list));

    if (virCommandRunRegex(cmd,
                           1,
                           regexes,
                           vars,
                           virISCSIGetTargets,
435
                           &list, NULL, NULL) < 0)
436
        return -1;
437 438 439 440 441

    if (ntargetsret && targetsret) {
        *ntargetsret = list.ntargets;
        *targetsret = list.targets;
    } else {
442
        for (i = 0; i < list.ntargets; i++)
443 444 445 446
            VIR_FREE(list.targets[i]);
        VIR_FREE(list.targets);
    }

447
    return 0;
448 449
}

450 451 452 453 454

/**
 * virISCSIScanTargets:
 * @portal: iSCSI portal
 * @initiatoriqn: Initiator IQN
455
 * @persists: whether scanned targets should be saved
456 457 458 459 460 461 462 463
 * @ntargets: number of items in @targetsret array
 * @targets: array of targets
 *
 * For given @portal issue sendtargets command. Optionally,
 * @initiatoriqn can be set to override default configuration.
 * The targets are stored into @targets array and the size of
 * the array is stored into @ntargets.
 *
464 465 466
 * If @persist is true, then targets returned by iSCSI portal are
 * made persistent on the host (their config is saved).
 *
467 468 469 470 471 472
 * Returns: 0 on success,
 *         -1 otherwise (with error reported)
 */
int
virISCSIScanTargets(const char *portal,
                    const char *initiatoriqn,
473
                    bool persist,
474 475 476
                    size_t *ntargets,
                    char ***targets)
{
477
    VIR_AUTOFREE(char *) ifacename = NULL;
478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499

    if (ntargets)
        *ntargets = 0;
    if (targets)
        *targets = NULL;

    if (initiatoriqn) {
        switch ((virStorageBackendIQNFound(initiatoriqn, &ifacename))) {
        case IQN_FOUND:
            break;

        case IQN_MISSING:
            virReportError(VIR_ERR_OPERATION_FAILED,
                           _("no iSCSI interface defined for IQN %s"),
                           initiatoriqn);
            ATTRIBUTE_FALLTHROUGH;
        case IQN_ERROR:
        default:
            return -1;
        }
    }

500
    return virISCSIScanTargetsInternal(portal, ifacename,
501
                                      persist, ntargets, targets);
502 503 504
}


J
John Ferlan 已提交
505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524
/*
 * virISCSINodeNew:
 * @portal: address for iSCSI target
 * @target: IQN and specific LUN target
 *
 * Usage of nonpersistent discovery in virISCSIScanTargets is useful primarily
 * only when the target IQN is not known; however, since we have the target IQN
 * usage of the "--op new" can be done. This avoids problems if "--op delete"
 * had been used wiping out the static nodes determined by the scanning of
 * all targets.
 *
 * NB: If an iSCSI node record is already created for this portal and
 * target, subsequent "--op new" commands do not return an error.
 *
 * Returns 0 on success, -1 w/ error message on error
 */
int
virISCSINodeNew(const char *portal,
                const char *target)
{
525
    VIR_AUTOPTR(virCommand) cmd = NULL;
J
John Ferlan 已提交
526 527 528 529 530 531 532 533 534 535 536 537 538
    int status;

    cmd = virCommandNewArgList(ISCSIADM,
                               "--mode", "node",
                               "--portal", portal,
                               "--targetname", target,
                               "--op", "new",
                               NULL);

    if (virCommandRun(cmd, &status) < 0) {
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("Failed new node mode for target '%s'"),
                       target);
539
        return -1;
J
John Ferlan 已提交
540 541 542 543 544 545
    }

    if (status != 0) {
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("%s failed new mode for target '%s' with status '%d'"),
                       ISCSIADM, target, status);
546
        return -1;
J
John Ferlan 已提交
547 548
    }

549
    return 0;
J
John Ferlan 已提交
550 551
}

552 553 554 555 556 557 558

int
virISCSINodeUpdate(const char *portal,
                   const char *target,
                   const char *name,
                   const char *value)
{
559
    VIR_AUTOPTR(virCommand) cmd = NULL;
560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575
    int status;

    cmd = virCommandNewArgList(ISCSIADM,
                               "--mode", "node",
                               "--portal", portal,
                               "--target", target,
                               "--op", "update",
                               "--name", name,
                               "--value", value,
                               NULL);

    /* Ignore non-zero status.  */
    if (virCommandRun(cmd, &status) < 0) {
        virReportError(VIR_ERR_INTERNAL_ERROR,
                       _("Failed to update '%s' of node mode for target '%s'"),
                       name, target);
576
        return -1;
577 578
    }

579
    return 0;
580
}