virt-aa-helper.c 42.6 KB
Newer Older
J
Jamie Strandboge 已提交
1 2
/*
 * virt-aa-helper: wrapper program used by AppArmor security driver.
3
 *
4
 * Copyright (C) 2010-2014 Red Hat, Inc.
5
 * Copyright (C) 2009-2011 Canonical Ltd.
J
Jamie Strandboge 已提交
6
 *
O
Osier Yang 已提交
7 8 9 10 11 12 13 14 15 16 17
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
18
 * License along with this library.  If not, see
O
Osier Yang 已提交
19
 * <http://www.gnu.org/licenses/>.
J
Jamie Strandboge 已提交
20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39
 *
 * Author:
 *   Jamie Strandboge <jamie@canonical.com>
 *
 */

#include <config.h>

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <stdarg.h>
#include <unistd.h>
#include <errno.h>
#include <sys/types.h>
#include <fcntl.h>
#include <getopt.h>
#include <sys/utsname.h>

#include "internal.h"
40
#include "virbuffer.h"
41
#include "viralloc.h"
42
#include "vircommand.h"
43
#include "virlog.h"
44
#include "driver.h"
J
Jamie Strandboge 已提交
45 46 47 48

#include "security_driver.h"
#include "security_apparmor.h"
#include "domain_conf.h"
49
#include "virxml.h"
50
#include "viruuid.h"
51
#include "virusb.h"
52
#include "virpci.h"
E
Eric Blake 已提交
53
#include "virfile.h"
54
#include "configmake.h"
55
#include "virrandom.h"
56
#include "virstring.h"
57
#include "virgettext.h"
58
#include "virhostdev.h"
J
Jamie Strandboge 已提交
59

60
#include "storage/storage_source.h"
61

62 63
#define VIR_FROM_THIS VIR_FROM_SECURITY

J
Jamie Strandboge 已提交
64 65 66
static char *progname;

typedef struct {
67
    bool allowDiskFormatProbing;
J
Jamie Strandboge 已提交
68 69 70 71 72 73 74 75 76
    char uuid[PROFILE_NAME_SIZE];       /* UUID of vm */
    bool dryrun;                /* dry run */
    char cmd;                   /* 'c'   create
                                 * 'a'   add (load)
                                 * 'r'   replace
                                 * 'R'   remove */
    char *files;                /* list of files */
    virDomainDefPtr def;        /* VM definition */
    virCapsPtr caps;            /* VM capabilities */
77
    virDomainXMLOptionPtr xmlopt; /* XML parser data */
78
    char *virtType;                  /* type of hypervisor (eg qemu, xen, lxc) */
79
    char *os;                   /* type of os (eg hvm, xen, exe) */
80
    virArch arch;               /* machine architecture */
81 82
    char *newfile;              /* newly added file */
    bool append;                /* append to .files instead of rewrite */
J
Jamie Strandboge 已提交
83 84 85 86 87 88 89 90 91
} vahControl;

static int
vahDeinit(vahControl * ctl)
{
    if (ctl == NULL)
        return -1;

    VIR_FREE(ctl->def);
92
    virObjectUnref(ctl->caps);
93
    virObjectUnref(ctl->xmlopt);
94
    VIR_FREE(ctl->files);
95
    VIR_FREE(ctl->virtType);
96
    VIR_FREE(ctl->os);
97
    VIR_FREE(ctl->newfile);
J
Jamie Strandboge 已提交
98 99 100 101 102 103 104 105 106 107

    return 0;
}

/*
 * Print usage
 */
static void
vah_usage(void)
{
108 109 110 111
    printf(_("\n%s [options] [< def.xml]\n\n"
            "  Options:\n"
            "    -a | --add                     load profile\n"
            "    -c | --create                  create profile from template\n"
112
            "    -d | --dryrun                  dry run\n"
113 114 115 116 117 118
            "    -D | --delete                  unload and delete profile\n"
            "    -f | --add-file <file>         add file to profile\n"
            "    -F | --append-file <file>      append file to profile\n"
            "    -r | --replace                 reload profile\n"
            "    -R | --remove                  unload profile\n"
            "    -h | --help                    this help\n"
119
            "    -p | --probing [0|1]           allow disk format probing\n"
120 121 122 123 124
            "    -u | --uuid <uuid>             uuid (profile name)\n"
            "\n"), progname);

    puts(_("This command is intended to be used by libvirtd "
           "and not used directly.\n"));
J
Jamie Strandboge 已提交
125 126 127 128 129 130
    return;
}

static void
vah_error(vahControl * ctl, int doexit, const char *str)
{
131
    fprintf(stderr, _("%s: error: %s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
132 133 134 135 136 137 138 139 140 141 142

    if (doexit) {
        if (ctl != NULL)
            vahDeinit(ctl);
        exit(EXIT_FAILURE);
    }
}

static void
vah_warning(const char *str)
{
143
    fprintf(stderr, _("%s: warning: %s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
144 145 146 147 148
}

static void
vah_info(const char *str)
{
149
    fprintf(stderr, _("%s:\n%s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
150 151 152 153 154 155 156 157
}

/*
 * run an apparmor_parser command
 */
static int
parserCommand(const char *profile_name, const char cmd)
{
158
    int result = -1;
J
Jamie Strandboge 已提交
159
    char flag[3];
160
    char *profile;
161 162
    int status;
    int ret;
J
Jamie Strandboge 已提交
163 164

    if (strchr("arR", cmd) == NULL) {
165
        vah_error(NULL, 0, _("invalid flag"));
J
Jamie Strandboge 已提交
166 167 168 169 170
        return -1;
    }

    snprintf(flag, 3, "-%c", cmd);

171 172
    if (virAsprintfQuiet(&profile, "%s/%s",
                         APPARMOR_DIR "/libvirt", profile_name) < 0) {
173
        vah_error(NULL, 0, _("profile name exceeds maximum length"));
J
Jamie Strandboge 已提交
174 175 176 177
        return -1;
    }

    if (!virFileExists(profile)) {
178
        vah_error(NULL, 0, _("profile does not exist"));
179
        goto cleanup;
J
Jamie Strandboge 已提交
180 181 182 183
    } else {
        const char * const argv[] = {
            "/sbin/apparmor_parser", flag, profile, NULL
        };
184 185 186
        if ((ret = virRun(argv, &status)) != 0 ||
            (WIFEXITED(status) && WEXITSTATUS(status) != 0)) {
            if (ret != 0) {
187
                vah_error(NULL, 0, _("failed to run apparmor_parser"));
188
                goto cleanup;
189 190 191
            } else if (cmd == 'R' && WIFEXITED(status) &&
                       WEXITSTATUS(status) == 234) {
                vah_warning(_("unable to unload already unloaded profile"));
192
            } else {
193
                vah_error(NULL, 0, _("apparmor_parser exited with error"));
194
                goto cleanup;
195
            }
J
Jamie Strandboge 已提交
196 197 198
        }
    }

199 200
    result = 0;

201
 cleanup:
202 203 204
    VIR_FREE(profile);

    return result;
J
Jamie Strandboge 已提交
205 206 207 208 209 210
}

/*
 * Update the dynamic files
 */
static int
211 212
update_include_file(const char *include_file, const char *included_files,
                    bool append)
J
Jamie Strandboge 已提交
213 214
{
    int rc = -1;
215
    int plen, flen = 0;
J
Jamie Strandboge 已提交
216 217
    int fd;
    char *pcontent = NULL;
218
    char *existing = NULL;
J
Jamie Strandboge 已提交
219 220 221
    const char *warning =
         "# DO NOT EDIT THIS FILE DIRECTLY. IT IS MANAGED BY LIBVIRT.\n";

222 223 224 225 226 227 228
    if (virFileExists(include_file)) {
        flen = virFileReadAll(include_file, MAX_FILE_LEN, &existing);
        if (flen < 0)
            return rc;
    }

    if (append && virFileExists(include_file)) {
229
        if (virAsprintfQuiet(&pcontent, "%s%s", existing, included_files) == -1) {
230
            vah_error(NULL, 0, _("could not allocate memory for profile"));
231
            goto cleanup;
232 233
        }
    } else {
234
        if (virAsprintfQuiet(&pcontent, "%s%s", warning, included_files) == -1) {
235
            vah_error(NULL, 0, _("could not allocate memory for profile"));
236
            goto cleanup;
237
        }
J
Jamie Strandboge 已提交
238 239 240 241
    }

    plen = strlen(pcontent);
    if (plen > MAX_FILE_LEN) {
242
        vah_error(NULL, 0, _("invalid length for new profile"));
243
        goto cleanup;
J
Jamie Strandboge 已提交
244 245 246
    }

    /* only update the disk profile if it is different */
247 248
    if (flen > 0 && flen == plen && STREQLEN(existing, pcontent, plen)) {
        rc = 0;
249
        goto cleanup;
J
Jamie Strandboge 已提交
250 251 252 253
    }

    /* write the file */
    if ((fd = open(include_file, O_CREAT | O_TRUNC | O_WRONLY, 0644)) == -1) {
254
        vah_error(NULL, 0, _("failed to create include file"));
255
        goto cleanup;
J
Jamie Strandboge 已提交
256 257 258
    }

    if (safewrite(fd, pcontent, plen) < 0) { /* don't write the '\0' */
259
        VIR_FORCE_CLOSE(fd);
260
        vah_error(NULL, 0, _("failed to write to profile"));
261
        goto cleanup;
J
Jamie Strandboge 已提交
262 263
    }

264
    if (VIR_CLOSE(fd) != 0) {
265
        vah_error(NULL, 0, _("failed to close or write to profile"));
266
        goto cleanup;
J
Jamie Strandboge 已提交
267 268 269
    }
    rc = 0;

270
 cleanup:
J
Jamie Strandboge 已提交
271
    VIR_FREE(pcontent);
272
    VIR_FREE(existing);
J
Jamie Strandboge 已提交
273 274 275 276 277 278 279 280 281

    return rc;
}

/*
 * Create a profile based on a template
 */
static int
create_profile(const char *profile, const char *profile_name,
282
               const char *profile_files, int virtType)
J
Jamie Strandboge 已提交
283
{
284
    char *template;
J
Jamie Strandboge 已提交
285 286 287 288
    char *tcontent = NULL;
    char *pcontent = NULL;
    char *replace_name = NULL;
    char *replace_files = NULL;
289
    char *tmp = NULL;
J
Jamie Strandboge 已提交
290 291 292 293 294
    const char *template_name = "\nprofile LIBVIRT_TEMPLATE";
    const char *template_end = "\n}";
    int tlen, plen;
    int fd;
    int rc = -1;
295
    const char *driver_name = NULL;
J
Jamie Strandboge 已提交
296 297

    if (virFileExists(profile)) {
298
        vah_error(NULL, 0, _("profile exists"));
J
Jamie Strandboge 已提交
299 300 301
        goto end;
    }

302 303 304 305 306 307 308 309 310
    switch (virtType) {
    case VIR_DOMAIN_VIRT_QEMU:
    case VIR_DOMAIN_VIRT_KQEMU:
    case VIR_DOMAIN_VIRT_KVM:
        driver_name = "qemu";
        break;
    default:
        driver_name = virDomainVirtTypeToString(virtType);
    }
C
Cédric Bosdonnat 已提交
311 312

    if (virAsprintfQuiet(&template, "%s/TEMPLATE.%s", APPARMOR_DIR "/libvirt",
313
                         driver_name) < 0) {
314
        vah_error(NULL, 0, _("template name exceeds maximum length"));
J
Jamie Strandboge 已提交
315 316 317 318
        goto end;
    }

    if (!virFileExists(template)) {
319
        vah_error(NULL, 0, _("template does not exist"));
J
Jamie Strandboge 已提交
320 321 322 323
        goto end;
    }

    if ((tlen = virFileReadAll(template, MAX_FILE_LEN, &tcontent)) < 0) {
324
        vah_error(NULL, 0, _("failed to read AppArmor template"));
J
Jamie Strandboge 已提交
325 326 327 328
        goto end;
    }

    if (strstr(tcontent, template_name) == NULL) {
329
        vah_error(NULL, 0, _("no replacement string in template"));
J
Jamie Strandboge 已提交
330 331 332 333
        goto clean_tcontent;
    }

    if (strstr(tcontent, template_end) == NULL) {
334
        vah_error(NULL, 0, _("no replacement string in template"));
J
Jamie Strandboge 已提交
335 336 337 338
        goto clean_tcontent;
    }

    /* '\nprofile <profile_name>\0' */
339
    if (virAsprintfQuiet(&replace_name, "\nprofile %s", profile_name) == -1) {
340
        vah_error(NULL, 0, _("could not allocate memory for profile name"));
J
Jamie Strandboge 已提交
341 342 343 344
        goto clean_tcontent;
    }

    /* '\n<profile_files>\n}\0' */
345 346
    if ((virtType != VIR_DOMAIN_VIRT_LXC) &&
            virAsprintfQuiet(&replace_files, "\n%s\n}", profile_files) == -1) {
347
        vah_error(NULL, 0, _("could not allocate memory for profile files"));
J
Jamie Strandboge 已提交
348 349 350 351
        VIR_FREE(replace_name);
        goto clean_tcontent;
    }

C
Cédric Bosdonnat 已提交
352
    plen = tlen + strlen(replace_name) - strlen(template_name) + 1;
353 354 355 356

    if (virtType != VIR_DOMAIN_VIRT_LXC)
        plen += strlen(replace_files) - strlen(template_end);

J
Jamie Strandboge 已提交
357
    if (plen > MAX_FILE_LEN || plen < tlen) {
358
        vah_error(NULL, 0, _("invalid length for new profile"));
J
Jamie Strandboge 已提交
359 360 361
        goto clean_replace;
    }

362
    if (!(pcontent = virStringReplace(tcontent, template_name, replace_name)))
J
Jamie Strandboge 已提交
363 364
        goto clean_all;

365 366 367 368 369 370 371
    if (virtType != VIR_DOMAIN_VIRT_LXC) {
        if (!(tmp = virStringReplace(pcontent, template_end, replace_files)))
            goto clean_all;
        VIR_FREE(pcontent);
        pcontent = tmp;
        tmp = NULL;
    }
J
Jamie Strandboge 已提交
372 373 374

    /* write the file */
    if ((fd = open(profile, O_CREAT | O_EXCL | O_WRONLY, 0644)) == -1) {
375
        vah_error(NULL, 0, _("failed to create profile"));
J
Jamie Strandboge 已提交
376 377 378 379
        goto clean_all;
    }

    if (safewrite(fd, pcontent, plen - 1) < 0) { /* don't write the '\0' */
380
        VIR_FORCE_CLOSE(fd);
381
        vah_error(NULL, 0, _("failed to write to profile"));
J
Jamie Strandboge 已提交
382 383 384
        goto clean_all;
    }

385
    if (VIR_CLOSE(fd) != 0) {
386
        vah_error(NULL, 0, _("failed to close or write to profile"));
J
Jamie Strandboge 已提交
387 388 389 390
        goto clean_all;
    }
    rc = 0;

391
 clean_all:
J
Jamie Strandboge 已提交
392
    VIR_FREE(pcontent);
393
 clean_replace:
J
Jamie Strandboge 已提交
394 395
    VIR_FREE(replace_name);
    VIR_FREE(replace_files);
396
 clean_tcontent:
J
Jamie Strandboge 已提交
397
    VIR_FREE(tcontent);
398
 end:
399
    VIR_FREE(template);
J
Jamie Strandboge 已提交
400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451
    return rc;
}

/*
 * Load an existing profile
 */
static int
parserLoad(const char *profile_name)
{
    return parserCommand(profile_name, 'a');
}

/*
 * Remove an existing profile
 */
static int
parserRemove(const char *profile_name)
{
    return parserCommand(profile_name, 'R');
}

/*
 * Replace an existing profile
 */
static int
parserReplace(const char *profile_name)
{
    return parserCommand(profile_name, 'r');
}

static int
valid_uuid(const char *uuid)
{
    unsigned char rawuuid[VIR_UUID_BUFLEN];

    if (strlen(uuid) != PROFILE_NAME_SIZE - 1)
        return -1;

    if (!STRPREFIX(uuid, AA_PREFIX))
        return -1;

    if (virUUIDParse(uuid + strlen(AA_PREFIX), rawuuid) < 0)
        return -1;

    return 0;
}

static int
valid_name(const char *name)
{
    /* just try to filter out any dangerous characters in the name that can be
     * used to subvert the profile */
452
    const char *bad = "/[]{}?^,\"*";
J
Jamie Strandboge 已提交
453

454
    if (strlen(name) == 0)
J
Jamie Strandboge 已提交
455 456 457 458 459 460 461 462 463 464 465 466
        return -1;

    if (strcspn(name, bad) != strlen(name))
        return -1;

    return 0;
}

/* see if one of the strings in arr starts with str */
static int
array_starts_with(const char *str, const char * const *arr, const long size)
{
467
    size_t i;
J
Jamie Strandboge 已提交
468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515
    for (i = 0; i < size; i++) {
        if (strlen(str) < strlen(arr[i]))
            continue;

        if (STRPREFIX(str, arr[i]))
            return 0;
    }
    return 1;
}

/*
 * Don't allow access to special files or restricted paths such as /bin, /sbin,
 * /usr/bin, /usr/sbin and /etc. This is in an effort to prevent read/write
 * access to system files which could be used to elevate privileges. This is a
 * safety measure in case libvirtd is under a restrictive profile and is
 * subverted and trying to escape confinement.
 *
 * Note that we cannot exclude block devices because they are valid devices.
 * The TEMPLATE file can be adjusted to explicitly disallow these if needed.
 *
 * RETURN: -1 on error, 0 if ok, 1 if blocked
 */
static int
valid_path(const char *path, const bool readonly)
{
    const char * const restricted[] = {
        "/bin/",
        "/etc/",
        "/lib",
        "/lost+found/",
        "/proc/",
        "/sbin/",
        "/selinux/",
        "/sys/",
        "/usr/bin/",
        "/usr/lib",
        "/usr/sbin/",
        "/usr/share/",
        "/usr/local/bin/",
        "/usr/local/etc/",
        "/usr/local/lib",
        "/usr/local/sbin/"
    };
    /* these paths are ok for readonly, but not read/write */
    const char * const restricted_rw[] = {
        "/boot/",
        "/vmlinuz",
        "/initrd",
516
        "/initrd.img",
517
        "/usr/share/OVMF/",              /* for OVMF images */
518 519
        "/usr/share/ovmf/",              /* for OVMF images */
        "/usr/share/AAVMF/",             /* for AAVMF images */
520 521
        "/usr/share/qemu-efi/",          /* for AAVMF images */
        "/usr/share/qemu-efi-aarch64/"   /* for AAVMF images */
J
Jamie Strandboge 已提交
522
    };
523 524
    /* override the above with these */
    const char * const override[] = {
J
John Ferlan 已提交
525
        "/sys/devices/pci",              /* for hostdev pci devices */
526
        "/etc/libvirt-sandbox/services/" /* for virt-sandbox service config */
527
    };
J
Jamie Strandboge 已提交
528

529 530 531 532
    const int nropaths = ARRAY_CARDINALITY(restricted);
    const int nrwpaths = ARRAY_CARDINALITY(restricted_rw);
    const int nopaths = ARRAY_CARDINALITY(override);

533
    if (path == NULL) {
534
        vah_error(NULL, 0, _("bad pathname"));
J
Jamie Strandboge 已提交
535 536 537 538 539 540 541 542 543
        return -1;
    }

    /* Don't allow double quotes, since we use them to quote the filename
     * and this will confuse the apparmor parser.
     */
    if (strchr(path, '"') != NULL)
        return 1;

J
Jamie Strandboge 已提交
544 545 546 547
    /* Require an absolute path */
    if (STRNEQLEN(path, "/", 1))
        return 1;

548
    if (!virFileExists(path))
549
        vah_warning(_("path does not exist, skipping file type checks"));
J
Jamie Strandboge 已提交
550

551
    /* overrides are always allowed */
552
    if (array_starts_with(path, override, nopaths) == 0)
553
        return 0;
J
Jamie Strandboge 已提交
554

555 556
    /* allow read only paths upfront */
    if (readonly) {
557
        if (array_starts_with(path, restricted_rw, nrwpaths) == 0)
558
            return 0;
J
Jamie Strandboge 已提交
559 560
    }

561
    /* disallow RW acess to all paths in restricted and restriced_rw */
562 563
    if ((array_starts_with(path, restricted, nropaths) == 0 ||
         array_starts_with(path, restricted_rw, nrwpaths) == 0))
564 565
        return 1;

J
Jamie Strandboge 已提交
566 567 568
    return 0;
}

569 570 571 572 573 574 575
static int
verify_xpath_context(xmlXPathContextPtr ctxt)
{
    int rc = -1;
    char *tmp = NULL;

    if (!ctxt) {
576
        vah_warning(_("Invalid context"));
577 578 579 580 581
        goto error;
    }

    /* check if have <name> */
    if (!(tmp = virXPathString("string(./name[1])", ctxt))) {
582
        vah_warning(_("Could not find <name>"));
583 584 585 586 587 588
        goto error;
    }
    VIR_FREE(tmp);

    /* check if have <uuid> */
    if (!(tmp = virXPathString("string(./uuid[1])", ctxt))) {
589
        vah_warning(_("Could not find <uuid>"));
590 591 592 593 594 595
        goto error;
    }
    VIR_FREE(tmp);

    rc = 0;

596
 error:
597 598 599
    return rc;
}

600 601
/*
 * Parse the xml we received to fill in the following:
602
 * ctl->virtType
603
 * ctl->os
604 605 606 607 608 609 610 611 612 613
 * ctl->arch
 *
 * These are suitable for setting up a virCapsPtr
 */
static int
caps_mockup(vahControl * ctl, const char *xmlStr)
{
    int rc = -1;
    xmlDocPtr xml = NULL;
    xmlXPathContextPtr ctxt = NULL;
614
    char *arch;
615

616
    if (!(xml = virXMLParseStringCtxt(xmlStr, _("(domain_definition)"),
617
                                      &ctxt))) {
618 619 620
        goto cleanup;
    }

621
    if (!virXMLNodeNameEqual(ctxt->node, "domain")) {
622
        vah_error(NULL, 0, _("unexpected root element, expecting <domain>"));
623 624 625
        goto cleanup;
    }

626 627 628 629
    /* Quick sanity check for some required elements */
    if (verify_xpath_context(ctxt) != 0)
        goto cleanup;

630 631 632 633 634
    ctl->virtType = virXPathString("string(./@type)", ctxt);
    if (!ctl->virtType) {
        vah_error(ctl, 0, _("domain type is not defined"));
        goto cleanup;
    }
635 636
    ctl->os = virXPathString("string(./os/type[1])", ctxt);
    if (!ctl->os) {
637
        vah_error(ctl, 0, _("os.type is not defined"));
638 639
        goto cleanup;
    }
640 641 642 643 644 645
    arch = virXPathString("string(./os/type[1]/@arch)", ctxt);
    if (!arch) {
        ctl->arch = virArchFromHost();
    } else {
        ctl->arch = virArchFromString(arch);
        VIR_FREE(arch);
646 647 648 649
    }

    rc = 0;

650
 cleanup:
651
    xmlFreeDoc(xml);
652 653 654 655 656
    xmlXPathFreeContext(ctxt);

    return rc;
}

657

J
Jamie Strandboge 已提交
658 659 660
static int
get_definition(vahControl * ctl, const char *xmlStr)
{
661
    int rc = -1, ostype, virtType;
J
Jamie Strandboge 已提交
662 663 664 665 666 667
    virCapsGuestPtr guest;  /* this is freed when caps is freed */

    /*
     * mock up some capabilities. We don't currently use these explicitly,
     * but need them for virDomainDefParseString().
     */
668 669
    if (caps_mockup(ctl, xmlStr) != 0)
        goto exit;
J
Jamie Strandboge 已提交
670

671
    if ((ctl->caps = virCapabilitiesNew(ctl->arch, true, true)) == NULL) {
672
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
673 674 675
        goto exit;
    }

676
    if (!(ctl->xmlopt = virDomainXMLOptionNew(NULL, NULL, NULL, NULL, NULL))) {
677 678 679 680
        vah_error(ctl, 0, _("Failed to create XML config object"));
        goto exit;
    }

681
    if ((ostype = virDomainOSTypeFromString(ctl->os)) < 0) {
682 683 684 685
        vah_error(ctl, 0, _("unknown OS type"));
        goto exit;
    }

J
Jamie Strandboge 已提交
686
    if ((guest = virCapabilitiesAddGuest(ctl->caps,
687
                                         ostype,
688
                                         ctl->arch,
J
Jamie Strandboge 已提交
689 690 691 692
                                         NULL,
                                         NULL,
                                         0,
                                         NULL)) == NULL) {
693
        vah_error(ctl, 0, _("could not allocate memory"));
694 695 696 697 698 699 700 701 702 703 704 705 706 707 708
        goto exit;
    }

    if ((virtType = virDomainVirtTypeFromString(ctl->virtType)) < 0) {
        vah_error(ctl, 0, _("unknown virtualization type"));
        goto exit;
    }

    if (virCapabilitiesAddGuestDomain(guest,
                                      virtType,
                                      NULL,
                                      NULL,
                                      0,
                                      NULL) == NULL) {
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
709 710 711
        goto exit;
    }

712
    ctl->def = virDomainDefParseString(xmlStr,
713
                                       ctl->caps, ctl->xmlopt, NULL,
714
                                       VIR_DOMAIN_DEF_PARSE_SKIP_SECLABEL |
715
                                       VIR_DOMAIN_DEF_PARSE_SKIP_VALIDATE);
716

J
Jamie Strandboge 已提交
717
    if (ctl->def == NULL) {
718
        vah_error(ctl, 0, _("could not parse XML"));
J
Jamie Strandboge 已提交
719 720 721 722
        goto exit;
    }

    if (!ctl->def->name) {
723
        vah_error(ctl, 0, _("could not find name in XML"));
J
Jamie Strandboge 已提交
724 725 726 727
        goto exit;
    }

    if (valid_name(ctl->def->name) != 0) {
728
        vah_error(ctl, 0, _("bad name"));
J
Jamie Strandboge 已提交
729 730 731 732 733
        goto exit;
    }

    rc = 0;

734
 exit:
J
Jamie Strandboge 已提交
735 736 737
    return rc;
}

738 739 740 741
/**
  * The permissions allowed are apparmor valid permissions and 'R'. 'R' stands for
  * read with no explicit deny rule.
  */
J
Jamie Strandboge 已提交
742
static int
F
Felix Geyer 已提交
743
vah_add_path(virBufferPtr buf, const char *path, const char *perms, bool recursive)
J
Jamie Strandboge 已提交
744 745 746 747
{
    char *tmp = NULL;
    int rc = -1;
    bool readonly = true;
748 749
    bool explicit_deny_rule = true;
    char *sub = NULL;
750
    char *perms_new = NULL;
J
Jamie Strandboge 已提交
751 752 753 754

    if (path == NULL)
        return rc;

J
Jamie Strandboge 已提交
755 756 757 758 759 760
    /* Skip files without an absolute path. Not having one confuses the
     * apparmor parser and this also ensures things like tcp consoles don't
     * get added to the profile.
     */
    if (STRNEQLEN(path, "/", 1)) {
        vah_warning(path);
761
        vah_warning(_("skipped non-absolute path"));
J
Jamie Strandboge 已提交
762 763 764
        return 0;
    }

J
Jamie Strandboge 已提交
765 766 767
    if (virFileExists(path)) {
        if ((tmp = realpath(path, NULL)) == NULL) {
            vah_error(NULL, 0, path);
768
            vah_error(NULL, 0, _("could not find realpath for disk"));
J
Jamie Strandboge 已提交
769 770
            return rc;
        }
771 772 773
    } else if (VIR_STRDUP_QUIET(tmp, path) < 0) {
        return rc;
    }
J
Jamie Strandboge 已提交
774

775
    if (VIR_STRDUP_QUIET(perms_new, perms) < 0)
776
        goto cleanup;
777 778

    if (strchr(perms_new, 'w') != NULL) {
J
Jamie Strandboge 已提交
779
        readonly = false;
780 781 782
        explicit_deny_rule = false;
    }

783
    if ((sub = strchr(perms_new, 'R')) != NULL) {
784 785 786 787
        /* Don't write the invalid R permission, replace it with 'r' */
        sub[0] = 'r';
        explicit_deny_rule = false;
    }
J
Jamie Strandboge 已提交
788 789 790 791 792

    rc = valid_path(tmp, readonly);
    if (rc != 0) {
        if (rc > 0) {
            vah_error(NULL, 0, path);
793
            vah_error(NULL, 0, _("skipped restricted file"));
J
Jamie Strandboge 已提交
794
        }
795
        goto cleanup;
J
Jamie Strandboge 已提交
796 797
    }

798 799 800
    if (tmp[strlen(tmp) - 1] == '/')
        tmp[strlen(tmp) - 1] = '\0';

801 802
    virBufferAsprintf(buf, "  \"%s%s\" %s,\n", tmp, recursive ? "/**" : "",
                      perms_new);
803
    if (explicit_deny_rule) {
804
        virBufferAddLit(buf, "  # don't audit writes to readonly files\n");
F
Felix Geyer 已提交
805 806 807 808 809
        virBufferAsprintf(buf, "  deny \"%s%s\" w,\n", tmp, recursive ? "/**" : "");
    }
    if (recursive) {
        /* allow reading (but not creating) the dir */
        virBufferAsprintf(buf, "  \"%s/\" r,\n", tmp);
810
    }
J
Jamie Strandboge 已提交
811

812
 cleanup:
813
    VIR_FREE(perms_new);
814
    VIR_FREE(tmp);
J
Jamie Strandboge 已提交
815 816 817 818

    return rc;
}

F
Felix Geyer 已提交
819 820 821 822 823 824
static int
vah_add_file(virBufferPtr buf, const char *path, const char *perms)
{
    return vah_add_path(buf, path, perms, false);
}

825 826 827 828 829 830 831 832 833 834 835 836
static int
vah_add_file_chardev(virBufferPtr buf,
                     const char *path,
                     const char *perms,
                     const int type)
{
    char *pipe_in;
    char *pipe_out;
    int rc = -1;

    if (type == VIR_DOMAIN_CHR_TYPE_PIPE) {
        /* add the pipe input */
837
        if (virAsprintfQuiet(&pipe_in, "%s.in", path) == -1) {
838
            vah_error(NULL, 0, _("could not allocate memory"));
839
            goto cleanup;
840 841 842 843 844 845
        }

        if (vah_add_file(buf, pipe_in, perms) != 0)
            goto clean_pipe_in;

        /* add the pipe output */
846
        if (virAsprintfQuiet(&pipe_out, "%s.out", path) == -1) {
847 848 849 850 851 852 853 854 855 856 857 858 859 860 861
            vah_error(NULL, 0, _("could not allocate memory"));
            goto clean_pipe_in;
        }

        if (vah_add_file(buf, pipe_out, perms) != 0)
            goto clean_pipe_out;

        rc = 0;
      clean_pipe_out:
        VIR_FREE(pipe_out);
      clean_pipe_in:
        VIR_FREE(pipe_in);
    } else {
        /* add the file */
        if (vah_add_file(buf, path, perms) != 0)
862
            goto cleanup;
863 864 865
        rc = 0;
    }

866
 cleanup:
867 868 869
    return rc;
}

J
Jamie Strandboge 已提交
870
static int
871
file_iterate_hostdev_cb(virUSBDevicePtr dev ATTRIBUTE_UNUSED,
872 873 874 875 876 877 878
                        const char *file, void *opaque)
{
    virBufferPtr buf = opaque;
    return vah_add_file(buf, file, "rw");
}

static int
879 880
file_iterate_pci_cb(virPCIDevicePtr dev ATTRIBUTE_UNUSED,
                    const char *file, void *opaque)
J
Jamie Strandboge 已提交
881 882 883 884 885
{
    virBufferPtr buf = opaque;
    return vah_add_file(buf, file, "rw");
}

886 887 888 889 890 891 892 893 894 895
static int
add_file_path(virDomainDiskDefPtr disk,
              const char *path,
              size_t depth,
              void *opaque)
{
    virBufferPtr buf = opaque;
    int ret;

    if (depth == 0) {
896
        if (disk->src->readonly)
897
            ret = vah_add_file(buf, path, "rk");
898
        else
899
            ret = vah_add_file(buf, path, "rwk");
900
    } else {
901
        ret = vah_add_file(buf, path, "rk");
902 903
    }

904 905 906
    if (ret != 0)
        ret = -1;

907 908 909
    return ret;
}

J
Jamie Strandboge 已提交
910 911 912 913 914
static int
get_files(vahControl * ctl)
{
    virBuffer buf = VIR_BUFFER_INITIALIZER;
    int rc = -1;
915
    size_t i;
J
Jamie Strandboge 已提交
916 917
    char *uuid;
    char uuidstr[VIR_UUID_STRING_BUFLEN];
918
    bool needsVfio = false, needsvhost = false;
J
Jamie Strandboge 已提交
919 920 921

    /* verify uuid is same as what we were given on the command line */
    virUUIDFormat(ctl->def->uuid, uuidstr);
922
    if (virAsprintfQuiet(&uuid, "%s%s", AA_PREFIX, uuidstr) == -1) {
923
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
924 925 926 927
        return rc;
    }

    if (STRNEQ(uuid, ctl->uuid)) {
928
        vah_error(ctl, 0, _("given uuid does not match XML uuid"));
929
        goto cleanup;
J
Jamie Strandboge 已提交
930 931
    }

932 933 934 935
    /* load the storage driver so that backing store can be accessed */
#ifdef WITH_STORAGE
    virDriverLoadModule("storage", "storageRegister");
#endif
936

937
    for (i = 0; i < ctl->def->ndisks; i++) {
938 939
        virDomainDiskDefPtr disk = ctl->def->disks[i];

940
        if (!virDomainDiskGetSource(disk))
E
Eric Blake 已提交
941
            continue;
942 943 944
        /* XXX - if we knew the qemu user:group here we could send it in
         *        so that the open could be re-tried as that user:group.
         */
945
        if (!virStorageSourceHasBacking(disk->src)) {
J
Jiri Denemark 已提交
946
            bool probe = ctl->allowDiskFormatProbing;
947
            virStorageFileGetMetadata(disk->src, -1, -1, probe, false);
J
Jiri Denemark 已提交
948
        }
949

950 951 952
        /* XXX passing ignoreOpenFailure = true to get back to the behavior
         * from before using virDomainDiskDefForeachPath. actually we should
         * be passing ignoreOpenFailure = false and handle open errors more
953 954
         * careful than just ignoring them.
         */
955
        if (virDomainDiskDefForeachPath(disk, true, add_file_path, &buf) < 0)
956
            goto cleanup;
957
    }
J
Jamie Strandboge 已提交
958 959

    for (i = 0; i < ctl->def->nserials; i++)
960
        if (ctl->def->serials[i] &&
961 962 963 964 965 966 967
            (ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->serials[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->serials[i]->source->data.file.path &&
            ctl->def->serials[i]->source->data.file.path[0] != '\0')
968
            if (vah_add_file_chardev(&buf,
969
                                     ctl->def->serials[i]->source->data.file.path,
970
                                     "rw",
971
                                     ctl->def->serials[i]->source->type) != 0)
972
                goto cleanup;
J
Jamie Strandboge 已提交
973

974 975
    for (i = 0; i < ctl->def->nconsoles; i++)
        if (ctl->def->consoles[i] &&
976 977 978 979 980 981 982
            (ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->consoles[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->consoles[i]->source->data.file.path &&
            ctl->def->consoles[i]->source->data.file.path[0] != '\0')
983
            if (vah_add_file(&buf,
984
                             ctl->def->consoles[i]->source->data.file.path, "rw") != 0)
985
                goto cleanup;
J
Jamie Strandboge 已提交
986

987
    for (i = 0; i < ctl->def->nparallels; i++)
988
        if (ctl->def->parallels[i] &&
989 990 991 992 993 994 995
            (ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->parallels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->parallels[i]->source->data.file.path &&
            ctl->def->parallels[i]->source->data.file.path[0] != '\0')
996
            if (vah_add_file_chardev(&buf,
997
                                     ctl->def->parallels[i]->source->data.file.path,
998
                                     "rw",
999
                                     ctl->def->parallels[i]->source->type) != 0)
1000
                goto cleanup;
1001

1002
    for (i = 0; i < ctl->def->nchannels; i++)
1003
        if (ctl->def->channels[i] &&
1004 1005 1006 1007 1008 1009 1010
            (ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_UNIX ||
             ctl->def->channels[i]->source->type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->channels[i]->source->data.file.path &&
            ctl->def->channels[i]->source->data.file.path[0] != '\0')
1011
            if (vah_add_file_chardev(&buf,
1012
                                     ctl->def->channels[i]->source->data.file.path,
1013
                                     "rw",
1014
                                     ctl->def->channels[i]->source->type) != 0)
1015
                goto cleanup;
1016

1017
    if (ctl->def->os.kernel)
J
Jamie Strandboge 已提交
1018
        if (vah_add_file(&buf, ctl->def->os.kernel, "r") != 0)
1019
            goto cleanup;
J
Jamie Strandboge 已提交
1020

1021
    if (ctl->def->os.initrd)
J
Jamie Strandboge 已提交
1022
        if (vah_add_file(&buf, ctl->def->os.initrd, "r") != 0)
1023
            goto cleanup;
O
Olivia Yin 已提交
1024 1025 1026

    if (ctl->def->os.dtb)
        if (vah_add_file(&buf, ctl->def->os.dtb, "r") != 0)
1027
            goto cleanup;
J
Jamie Strandboge 已提交
1028

J
Ján Tomko 已提交
1029 1030 1031 1032
    if (ctl->def->os.slic_table)
        if (vah_add_file(&buf, ctl->def->os.slic_table, "r") != 0)
            goto cleanup;

1033
    if (ctl->def->os.loader && ctl->def->os.loader->path)
1034
        if (vah_add_file(&buf, ctl->def->os.loader->path, "rk") != 0)
1035
            goto cleanup;
1036

1037
    if (ctl->def->os.loader && ctl->def->os.loader->nvram)
1038
        if (vah_add_file(&buf, ctl->def->os.loader->nvram, "rwk") != 0)
1039 1040
            goto cleanup;

1041
    for (i = 0; i < ctl->def->ngraphics; i++) {
1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052
        virDomainGraphicsDefPtr graphics = ctl->def->graphics[i];
        size_t n;

        for (n = 0; n < graphics->nListens; n++) {
            virDomainGraphicsListenDef listenObj = graphics->listens[n];

            if (listenObj.type == VIR_DOMAIN_GRAPHICS_LISTEN_TYPE_SOCKET &&
                listenObj.socket &&
                vah_add_file(&buf, listenObj.socket, "rw"))
                goto cleanup;
        }
1053 1054
    }

1055 1056 1057 1058
    if (ctl->def->ngraphics == 1 &&
        ctl->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL)
        if (vah_add_file(&buf, ctl->def->graphics[0]->data.sdl.xauth,
                         "r") != 0)
1059
            goto cleanup;
J
Jamie Strandboge 已提交
1060 1061 1062 1063

    for (i = 0; i < ctl->def->nhostdevs; i++)
        if (ctl->def->hostdevs[i]) {
            virDomainHostdevDefPtr dev = ctl->def->hostdevs[i];
1064
            virDomainHostdevSubsysUSBPtr usbsrc = &dev->source.subsys.u.usb;
J
Jamie Strandboge 已提交
1065 1066
            switch (dev->source.subsys.type) {
            case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB: {
1067
                virUSBDevicePtr usb =
1068
                    virUSBDeviceNew(usbsrc->bus, usbsrc->device, NULL);
1069 1070 1071 1072

                if (usb == NULL)
                    continue;

1073 1074 1075
                if (virHostdevFindUSBDevice(dev, true, &usb) < 0)
                    continue;

1076 1077
                rc = virUSBDeviceFileIterate(usb, file_iterate_hostdev_cb, &buf);
                virUSBDeviceFree(usb);
1078
                if (rc != 0)
1079
                    goto cleanup;
J
Jamie Strandboge 已提交
1080 1081
                break;
            }
1082

J
Jamie Strandboge 已提交
1083
            case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI: {
1084
                virPCIDevicePtr pci = virPCIDeviceNew(
1085 1086 1087 1088
                           dev->source.subsys.u.pci.addr.domain,
                           dev->source.subsys.u.pci.addr.bus,
                           dev->source.subsys.u.pci.addr.slot,
                           dev->source.subsys.u.pci.addr.function);
J
Jamie Strandboge 已提交
1089

1090
                virDomainHostdevSubsysPCIBackendType backend = dev->source.subsys.u.pci.backend;
1091 1092 1093 1094 1095
                if (backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO ||
                        backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT) {
                    needsVfio = true;
                }

J
Jamie Strandboge 已提交
1096 1097 1098
                if (pci == NULL)
                    continue;

1099 1100
                rc = virPCIDeviceFileIterate(pci, file_iterate_pci_cb, &buf);
                virPCIDeviceFree(pci);
J
Jamie Strandboge 已提交
1101 1102 1103

                break;
            }
1104

J
Jamie Strandboge 已提交
1105 1106 1107 1108 1109 1110
            default:
                rc = 0;
                break;
            } /* switch */
        }

F
Felix Geyer 已提交
1111 1112 1113 1114 1115
    for (i = 0; i < ctl->def->nfss; i++) {
        if (ctl->def->fss[i] &&
                ctl->def->fss[i]->type == VIR_DOMAIN_FS_TYPE_MOUNT &&
                (ctl->def->fss[i]->fsdriver == VIR_DOMAIN_FS_DRIVER_TYPE_PATH ||
                 ctl->def->fss[i]->fsdriver == VIR_DOMAIN_FS_DRIVER_TYPE_DEFAULT) &&
1116
                ctl->def->fss[i]->src) {
F
Felix Geyer 已提交
1117 1118
            virDomainFSDefPtr fs = ctl->def->fss[i];

1119 1120 1121
            /* We don't need to add deny rw rules for readonly mounts,
             * this can only lead to troubles when mounting / readonly.
             */
1122
            if (vah_add_path(&buf, fs->src->path, fs->readonly ? "R" : "rw", true) != 0)
F
Felix Geyer 已提交
1123 1124 1125 1126
                goto cleanup;
        }
    }

1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138
    for (i = 0; i < ctl->def->nnets; i++) {
        if (ctl->def->nets[i] &&
                ctl->def->nets[i]->type == VIR_DOMAIN_NET_TYPE_VHOSTUSER &&
                ctl->def->nets[i]->data.vhostuser) {
            virDomainChrSourceDefPtr vhu = ctl->def->nets[i]->data.vhostuser;

            if (vah_add_file_chardev(&buf, vhu->data.nix.path, "rw",
                       vhu->type) != 0)
                goto cleanup;
        }
    }

1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151
    if (ctl->def->virtType == VIR_DOMAIN_VIRT_KVM) {
        for (i = 0; i < ctl->def->nnets; i++) {
            virDomainNetDefPtr net = ctl->def->nets[i];
            if (net && net->model) {
                if (net->driver.virtio.name == VIR_DOMAIN_NET_BACKEND_TYPE_QEMU)
                    continue;
                if (STRNEQ(net->model, "virtio"))
                    continue;
            }
            needsvhost = true;
        }
    }
    if (needsvhost)
1152
        virBufferAddLit(&buf, "  \"/dev/vhost-net\" rw,\n");
1153

1154
    if (needsVfio) {
1155 1156
        virBufferAddLit(&buf, "  \"/dev/vfio/vfio\" rw,\n");
        virBufferAddLit(&buf, "  \"/dev/vfio/[0-9]*\" rw,\n");
1157 1158
    }

1159
    if (ctl->newfile)
1160
        if (vah_add_file(&buf, ctl->newfile, "rwk") != 0)
1161
            goto cleanup;
J
Jamie Strandboge 已提交
1162 1163

    if (virBufferError(&buf)) {
1164
        virBufferFreeAndReset(&buf);
1165
        vah_error(NULL, 0, _("failed to allocate file buffer"));
1166
        goto cleanup;
J
Jamie Strandboge 已提交
1167 1168 1169 1170 1171
    }

    rc = 0;
    ctl->files = virBufferContentAndReset(&buf);

1172
 cleanup:
J
Jamie Strandboge 已提交
1173 1174 1175 1176 1177 1178 1179 1180 1181
    VIR_FREE(uuid);
    return rc;
}

static int
vahParseArgv(vahControl * ctl, int argc, char **argv)
{
    int arg, idx = 0;
    struct option opt[] = {
1182
        {"probing", 1, 0, 'p' },
J
Jamie Strandboge 已提交
1183 1184 1185 1186 1187
        {"add", 0, 0, 'a'},
        {"create", 0, 0, 'c'},
        {"dryrun", 0, 0, 'd'},
        {"delete", 0, 0, 'D'},
        {"add-file", 0, 0, 'f'},
1188
        {"append-file", 0, 0, 'F'},
J
Jamie Strandboge 已提交
1189 1190 1191 1192 1193 1194 1195
        {"help", 0, 0, 'h'},
        {"replace", 0, 0, 'r'},
        {"remove", 0, 0, 'R'},
        {"uuid", 1, 0, 'u'},
        {0, 0, 0, 0}
    };

1196
    while ((arg = getopt_long(argc, argv, "acdDhrRH:b:u:p:f:F:", opt,
J
Jamie Strandboge 已提交
1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211
            &idx)) != -1) {
        switch (arg) {
            case 'a':
                ctl->cmd = 'a';
                break;
            case 'c':
                ctl->cmd = 'c';
                break;
            case 'd':
                ctl->dryrun = true;
                break;
            case 'D':
                ctl->cmd = 'D';
                break;
            case 'f':
1212
            case 'F':
1213
                if (VIR_STRDUP_QUIET(ctl->newfile, optarg) < 0)
1214
                    vah_error(ctl, 1, _("could not allocate memory for disk"));
1215
                ctl->append = arg == 'F';
J
Jamie Strandboge 已提交
1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228
                break;
            case 'h':
                vah_usage();
                exit(EXIT_SUCCESS);
                break;
            case 'r':
                ctl->cmd = 'r';
                break;
            case 'R':
                ctl->cmd = 'R';
                break;
            case 'u':
                if (strlen(optarg) > PROFILE_NAME_SIZE - 1)
1229
                    vah_error(ctl, 1, _("invalid UUID"));
J
Jamie Strandboge 已提交
1230 1231
                if (virStrcpy((char *) ctl->uuid, optarg,
                    PROFILE_NAME_SIZE) == NULL)
1232
                    vah_error(ctl, 1, _("error copying UUID"));
J
Jamie Strandboge 已提交
1233
                break;
1234 1235 1236 1237 1238 1239
            case 'p':
                if (STREQ(optarg, "1"))
                    ctl->allowDiskFormatProbing = true;
                else
                    ctl->allowDiskFormatProbing = false;
                break;
J
Jamie Strandboge 已提交
1240
            default:
1241
                vah_error(ctl, 1, _("unsupported option"));
J
Jamie Strandboge 已提交
1242 1243 1244 1245
                break;
        }
    }
    if (strchr("acDrR", ctl->cmd) == NULL)
1246
        vah_error(ctl, 1, _("bad command"));
J
Jamie Strandboge 已提交
1247 1248

    if (valid_uuid(ctl->uuid) != 0)
1249
        vah_error(ctl, 1, _("invalid UUID"));
J
Jamie Strandboge 已提交
1250 1251 1252 1253 1254 1255 1256 1257 1258

    if (!ctl->cmd) {
        vah_usage();
        exit(EXIT_FAILURE);
    }

    if (ctl->cmd == 'c' || ctl->cmd == 'r') {
        char *xmlStr = NULL;
        if (virFileReadLimFD(STDIN_FILENO, MAX_FILE_LEN, &xmlStr) < 0)
1259
            vah_error(ctl, 1, _("could not read xml file"));
J
Jamie Strandboge 已提交
1260 1261 1262

        if (get_definition(ctl, xmlStr) != 0 || ctl->def == NULL) {
            VIR_FREE(xmlStr);
1263
            vah_error(ctl, 1, _("could not get VM definition"));
J
Jamie Strandboge 已提交
1264 1265 1266 1267
        }
        VIR_FREE(xmlStr);

        if (get_files(ctl) != 0)
1268
            vah_error(ctl, 1, _("invalid VM definition"));
J
Jamie Strandboge 已提交
1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 1282 1283 1284 1285 1286
    }
    return 0;
}


/*
 * virt-aa-helper -c -u UUID < file.xml
 * virt-aa-helper -r -u UUID [-f <file>] < file.xml
 * virt-aa-helper -a -u UUID
 * virt-aa-helper -R -u UUID
 * virt-aa-helper -D -u UUID
 */
int
main(int argc, char **argv)
{
    vahControl _ctl, *ctl = &_ctl;
    virBuffer buf = VIR_BUFFER_INITIALIZER;
    int rc = -1;
1287 1288
    char *profile = NULL;
    char *include_file = NULL;
J
Jamie Strandboge 已提交
1289

1290 1291
    if (virGettextInitialize() < 0 ||
        virThreadInitialize() < 0 ||
1292 1293 1294 1295 1296
        virErrorInitialize() < 0) {
        fprintf(stderr, _("%s: initialization failed\n"), argv[0]);
        exit(EXIT_FAILURE);
    }

1297 1298
    virFileActivateDirOverride(argv[0]);

1299 1300 1301
    /* Initialize the log system */
    virLogSetFromEnv();

J
Jamie Strandboge 已提交
1302 1303
    /* clear the environment */
    environ = NULL;
1304
    if (setenv("PATH", "/sbin:/usr/sbin", 1) != 0)
1305 1306
        vah_error(ctl, 1, _("could not set PATH"));

1307
    /* ensure the traditional IFS setting */
1308
    if (setenv("IFS", " \t\n", 1) != 0)
1309
        vah_error(ctl, 1, _("could not set IFS"));
J
Jamie Strandboge 已提交
1310 1311 1312 1313 1314 1315 1316 1317 1318

    if (!(progname = strrchr(argv[0], '/')))
        progname = argv[0];
    else
        progname++;

    memset(ctl, 0, sizeof(vahControl));

    if (vahParseArgv(ctl, argc, argv) != 0)
1319
        vah_error(ctl, 1, _("could not parse arguments"));
J
Jamie Strandboge 已提交
1320

1321 1322
    if (virAsprintfQuiet(&profile, "%s/%s",
                         APPARMOR_DIR "/libvirt", ctl->uuid) < 0)
1323
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
1324

1325 1326
    if (virAsprintfQuiet(&include_file, "%s/%s.files",
                         APPARMOR_DIR "/libvirt", ctl->uuid) < 0)
1327
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
1328

1329
    if (ctl->cmd == 'a') {
J
Jamie Strandboge 已提交
1330
        rc = parserLoad(ctl->uuid);
1331
    } else if (ctl->cmd == 'R' || ctl->cmd == 'D') {
J
Jamie Strandboge 已提交
1332 1333 1334 1335 1336 1337 1338 1339
        rc = parserRemove(ctl->uuid);
        if (ctl->cmd == 'D') {
            unlink(include_file);
            unlink(profile);
        }
    } else if (ctl->cmd == 'c' || ctl->cmd == 'r') {
        char *included_files = NULL;

1340
        if (ctl->cmd == 'c' && virFileExists(profile))
1341
            vah_error(ctl, 1, _("profile exists"));
J
Jamie Strandboge 已提交
1342

1343
        if (ctl->append && ctl->newfile) {
1344
            if (vah_add_file(&buf, ctl->newfile, "rwk") != 0)
1345
                goto cleanup;
1346
        } else {
1347 1348 1349
            if (ctl->def->virtType == VIR_DOMAIN_VIRT_QEMU ||
                ctl->def->virtType == VIR_DOMAIN_VIRT_KQEMU ||
                ctl->def->virtType == VIR_DOMAIN_VIRT_KVM) {
1350 1351
                virBufferAsprintf(&buf, "  \"%s/log/libvirt/**/%s.log\" w,\n",
                                  LOCALSTATEDIR, ctl->def->name);
1352
                virBufferAsprintf(&buf, "  \"%s/lib/libvirt/qemu/domain-%s/monitor.sock\" rw,\n",
1353
                                  LOCALSTATEDIR, ctl->def->name);
1354 1355
                virBufferAsprintf(&buf, "  \"%s/lib/libvirt/qemu/domain-%d-%.*s/*\" rw,\n",
                                  LOCALSTATEDIR, ctl->def->id, 20, ctl->def->name);
1356 1357 1358 1359 1360 1361 1362 1363 1364
                virBufferAsprintf(&buf, "  \"%s/run/libvirt/**/%s.pid\" rwk,\n",
                                  LOCALSTATEDIR, ctl->def->name);
                virBufferAsprintf(&buf, "  \"/run/libvirt/**/%s.pid\" rwk,\n",
                                  ctl->def->name);
                virBufferAsprintf(&buf, "  \"%s/run/libvirt/**/*.tunnelmigrate.dest.%s\" rw,\n",
                                  LOCALSTATEDIR, ctl->def->name);
                virBufferAsprintf(&buf, "  \"/run/libvirt/**/*.tunnelmigrate.dest.%s\" rw,\n",
                                  ctl->def->name);
            }
1365
            if (ctl->files)
1366
                virBufferAdd(&buf, ctl->files, -1);
1367
        }
J
Jamie Strandboge 已提交
1368

1369 1370
        if (virBufferError(&buf)) {
            virBufferFreeAndReset(&buf);
1371
            vah_error(ctl, 1, _("failed to allocate buffer"));
1372
        }
J
Jamie Strandboge 已提交
1373 1374 1375 1376 1377 1378 1379 1380

        included_files = virBufferContentAndReset(&buf);

        /* (re)create the include file using included_files */
        if (ctl->dryrun) {
            vah_info(include_file);
            vah_info(included_files);
            rc = 0;
1381 1382 1383
        } else if (ctl->def->virtType == VIR_DOMAIN_VIRT_LXC) {
            rc = 0;
        } else if ((rc = update_include_file(include_file,
1384
                                             included_files,
1385
                                             ctl->append)) != 0) {
1386
            goto cleanup;
1387
        }
J
Jamie Strandboge 已提交
1388 1389 1390 1391 1392


        /* create the profile from TEMPLATE */
        if (ctl->cmd == 'c') {
            char *tmp = NULL;
1393 1394
            if (virAsprintfQuiet(&tmp, "  #include <libvirt/%s.files>\n",
                                 ctl->uuid) == -1) {
1395
                vah_error(ctl, 0, _("could not allocate memory"));
1396
                goto cleanup;
J
Jamie Strandboge 已提交
1397 1398 1399 1400 1401 1402 1403
            }

            if (ctl->dryrun) {
                vah_info(profile);
                vah_info(ctl->uuid);
                vah_info(tmp);
                rc = 0;
1404 1405
            } else if ((rc = create_profile(profile, ctl->uuid, tmp,
                                            ctl->def->virtType)) != 0) {
1406
                vah_error(ctl, 0, _("could not create profile"));
J
Jamie Strandboge 已提交
1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424
                unlink(include_file);
            }
            VIR_FREE(tmp);
        }

        if (rc == 0 && !ctl->dryrun) {
            if (ctl->cmd == 'c')
                rc = parserLoad(ctl->uuid);
            else
                rc = parserReplace(ctl->uuid);

            /* cleanup */
            if (rc != 0) {
                unlink(include_file);
                if (ctl->cmd == 'c')
                    unlink(profile);
            }
        }
1425
      cleanup:
J
Jamie Strandboge 已提交
1426 1427 1428 1429
        VIR_FREE(included_files);
    }

    vahDeinit(ctl);
1430 1431 1432 1433

    VIR_FREE(profile);
    VIR_FREE(include_file);

J
Jamie Strandboge 已提交
1434 1435
    exit(rc == 0 ? EXIT_SUCCESS : EXIT_FAILURE);
}