domain_capabilities.c 17.0 KB
Newer Older
M
Michal Privoznik 已提交
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29
/*
 * domain_capabilities.c: domain capabilities XML processing
 *
 * Copyright (C) 2014 Red Hat, Inc.
 *
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
 * License along with this library.  If not, see
 * <http://www.gnu.org/licenses/>.
 */

#include <config.h>

#include "domain_capabilities.h"
#include "domain_conf.h"
#include "viralloc.h"
#include "virstring.h"

#define VIR_FROM_THIS VIR_FROM_CAPABILITIES

30 31
VIR_ENUM_IMPL(virDomainCapsCPUUsable,
              VIR_DOMCAPS_CPU_USABLE_LAST,
32 33
              "unknown", "yes", "no",
);
J
Jiri Denemark 已提交
34

M
Michal Privoznik 已提交
35
static virClassPtr virDomainCapsClass;
36
static virClassPtr virDomainCapsCPUModelsClass;
M
Michal Privoznik 已提交
37 38

static void virDomainCapsDispose(void *obj);
39
static void virDomainCapsCPUModelsDispose(void *obj);
M
Michal Privoznik 已提交
40 41 42

static int virDomainCapsOnceInit(void)
{
43
    if (!VIR_CLASS_NEW(virDomainCaps, virClassForObjectLockable()))
M
Michal Privoznik 已提交
44
        return -1;
45

46
    if (!VIR_CLASS_NEW(virDomainCapsCPUModels, virClassForObject()))
47 48
        return -1;

M
Michal Privoznik 已提交
49 50 51 52
    return 0;
}


53
VIR_ONCE_GLOBAL_INIT(virDomainCaps);
M
Michal Privoznik 已提交
54 55


56 57 58 59 60 61 62 63 64 65 66 67 68 69
static void
virDomainCapsStringValuesFree(virDomainCapsStringValuesPtr values)
{
    size_t i;

    if (!values || !values->values)
        return;

    for (i = 0; i < values->nvalues; i++)
        VIR_FREE(values->values[i]);
    VIR_FREE(values->values);
}


70 71 72 73 74 75 76 77 78 79 80 81
void
virSEVCapabilitiesFree(virSEVCapability *cap)
{
    if (!cap)
        return;

    VIR_FREE(cap->pdh);
    VIR_FREE(cap->cert_chain);
    VIR_FREE(cap);
}


M
Michal Privoznik 已提交
82 83 84 85 86 87 88
static void
virDomainCapsDispose(void *obj)
{
    virDomainCapsPtr caps = obj;

    VIR_FREE(caps->path);
    VIR_FREE(caps->machine);
89
    virObjectUnref(caps->cpu.custom);
90
    virCPUDefFree(caps->cpu.hostModel);
91
    virSEVCapabilitiesFree(caps->sev);
92 93

    virDomainCapsStringValuesFree(&caps->os.loader.values);
M
Michal Privoznik 已提交
94 95 96
}


97 98 99 100 101 102
static void
virDomainCapsCPUModelsDispose(void *obj)
{
    virDomainCapsCPUModelsPtr cpuModels = obj;
    size_t i;

103
    for (i = 0; i < cpuModels->nmodels; i++) {
104
        VIR_FREE(cpuModels->models[i].name);
105 106
        virStringListFree(cpuModels->models[i].blockers);
    }
107 108 109 110 111

    VIR_FREE(cpuModels->models);
}


M
Michal Privoznik 已提交
112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138
virDomainCapsPtr
virDomainCapsNew(const char *path,
                 const char *machine,
                 virArch arch,
                 virDomainVirtType virttype)
{
    virDomainCapsPtr caps = NULL;

    if (virDomainCapsInitialize() < 0)
        return NULL;

    if (!(caps = virObjectLockableNew(virDomainCapsClass)))
        return NULL;

    if (VIR_STRDUP(caps->path, path) < 0 ||
        VIR_STRDUP(caps->machine, machine) < 0)
        goto error;
    caps->arch = arch;
    caps->virttype = virttype;

    return caps;
 error:
    virObjectUnref(caps);
    return NULL;
}


139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171
virDomainCapsCPUModelsPtr
virDomainCapsCPUModelsNew(size_t nmodels)
{
    virDomainCapsCPUModelsPtr cpuModels = NULL;

    if (virDomainCapsInitialize() < 0)
        return NULL;

    if (!(cpuModels = virObjectNew(virDomainCapsCPUModelsClass)))
        return NULL;

    if (VIR_ALLOC_N(cpuModels->models, nmodels) < 0)
        goto error;
    cpuModels->nmodels_max = nmodels;

    return cpuModels;

 error:
    virObjectUnref(cpuModels);
    return NULL;
}


virDomainCapsCPUModelsPtr
virDomainCapsCPUModelsCopy(virDomainCapsCPUModelsPtr old)
{
    virDomainCapsCPUModelsPtr cpuModels;
    size_t i;

    if (!(cpuModels = virDomainCapsCPUModelsNew(old->nmodels)))
        return NULL;

    for (i = 0; i < old->nmodels; i++) {
J
Jiri Denemark 已提交
172 173
        if (virDomainCapsCPUModelsAdd(cpuModels,
                                      old->models[i].name, -1,
174 175
                                      old->models[i].usable,
                                      old->models[i].blockers) < 0)
176 177 178 179 180 181 182 183 184 185 186
            goto error;
    }

    return cpuModels;

 error:
    virObjectUnref(cpuModels);
    return NULL;
}


187 188
virDomainCapsCPUModelsPtr
virDomainCapsCPUModelsFilter(virDomainCapsCPUModelsPtr old,
189 190
                             const char **models,
                             const char **blacklist)
191 192 193 194 195 196 197 198
{
    virDomainCapsCPUModelsPtr cpuModels;
    size_t i;

    if (!(cpuModels = virDomainCapsCPUModelsNew(0)))
        return NULL;

    for (i = 0; i < old->nmodels; i++) {
199
        if (models && !virStringListHasString(models, old->models[i].name))
200 201
            continue;

202 203 204
        if (blacklist && virStringListHasString(blacklist, old->models[i].name))
            continue;

205
        if (virDomainCapsCPUModelsAdd(cpuModels,
J
Jiri Denemark 已提交
206
                                      old->models[i].name, -1,
207 208
                                      old->models[i].usable,
                                      old->models[i].blockers) < 0)
209 210 211 212 213 214 215 216 217 218 219
            goto error;
    }

    return cpuModels;

 error:
    virObjectUnref(cpuModels);
    return NULL;
}


220 221
int
virDomainCapsCPUModelsAddSteal(virDomainCapsCPUModelsPtr cpuModels,
J
Jiri Denemark 已提交
222
                               char **name,
223 224
                               virDomainCapsCPUUsable usable,
                               char ***blockers)
225 226 227 228 229
{
    if (VIR_RESIZE_N(cpuModels->models, cpuModels->nmodels_max,
                     cpuModels->nmodels, 1) < 0)
        return -1;

J
Jiri Denemark 已提交
230 231
    cpuModels->models[cpuModels->nmodels].usable = usable;
    VIR_STEAL_PTR(cpuModels->models[cpuModels->nmodels].name, *name);
232 233 234 235

    if (blockers)
        VIR_STEAL_PTR(cpuModels->models[cpuModels->nmodels].blockers, *blockers);

J
Jiri Denemark 已提交
236
    cpuModels->nmodels++;
237 238 239 240 241 242 243
    return 0;
}


int
virDomainCapsCPUModelsAdd(virDomainCapsCPUModelsPtr cpuModels,
                          const char *name,
J
Jiri Denemark 已提交
244
                          ssize_t nameLen,
245 246
                          virDomainCapsCPUUsable usable,
                          char **blockers)
247
{
248 249 250 251 252
    char *nameCopy = NULL;
    char **blockersCopy = NULL;

    if (VIR_STRNDUP(nameCopy, name, nameLen) < 0)
        goto error;
253

254
    if (virStringListCopy(&blockersCopy, (const char **)blockers) < 0)
255 256
        goto error;

257 258
    if (virDomainCapsCPUModelsAddSteal(cpuModels, &nameCopy,
                                       usable, &blockersCopy) < 0)
259 260 261 262 263
        goto error;

    return 0;

 error:
264 265
    VIR_FREE(nameCopy);
    virStringListFree(blockersCopy);
266 267 268 269
    return -1;
}


270 271 272 273 274 275 276 277 278 279
virDomainCapsCPUModelPtr
virDomainCapsCPUModelsGet(virDomainCapsCPUModelsPtr cpuModels,
                          const char *name)
{
    size_t i;

    if (!cpuModels)
        return NULL;

    for (i = 0; i < cpuModels->nmodels; i++) {
280
        if (STRCASEEQ(cpuModels->models[i].name, name))
281 282 283 284 285 286 287
            return cpuModels->models + i;
    }

    return NULL;
}


M
Michal Privoznik 已提交
288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333
int
virDomainCapsEnumSet(virDomainCapsEnumPtr capsEnum,
                     const char *capsEnumName,
                     size_t nvalues,
                     unsigned int *values)
{
    int ret = -1;
    size_t i;

    for (i = 0; i < nvalues; i++) {
        unsigned int val = 1 << values[i];

        if (!val) {
            /* Integer overflow */
            virReportError(VIR_ERR_INTERNAL_ERROR,
                           _("integer overflow on %s. Please contact the "
                             "libvirt development team at libvir-list@redhat.com"),
                           capsEnumName);
            goto cleanup;
        }

        capsEnum->values |= val;
    }

    ret = 0;
 cleanup:
    return ret;
}


void
virDomainCapsEnumClear(virDomainCapsEnumPtr capsEnum)
{
    capsEnum->values = 0;
}


static int
virDomainCapsEnumFormat(virBufferPtr buf,
                        virDomainCapsEnumPtr capsEnum,
                        const char *capsEnumName,
                        virDomainCapsValToStr valToStr)
{
    int ret = -1;
    size_t i;

334 335 336 337 338
    if (!capsEnum->report) {
        ret = 0;
        goto cleanup;
    }

M
Michal Privoznik 已提交
339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364
    virBufferAsprintf(buf, "<enum name='%s'", capsEnumName);
    if (!capsEnum->values) {
        virBufferAddLit(buf, "/>\n");
        ret = 0;
        goto cleanup;
    }
    virBufferAddLit(buf, ">\n");
    virBufferAdjustIndent(buf, 2);

    for (i = 0; i < sizeof(capsEnum->values) * CHAR_BIT; i++) {
        const char *val;

        if (!(capsEnum->values & (1 << i)))
            continue;

        if ((val = (valToStr)(i)))
            virBufferAsprintf(buf, "<value>%s</value>\n", val);
    }
    virBufferAdjustIndent(buf, -2);
    virBufferAddLit(buf, "</enum>\n");

    ret = 0;
 cleanup:
    return ret;
}

365 366 367 368 369 370 371 372 373 374 375 376

static void
virDomainCapsStringValuesFormat(virBufferPtr buf,
                                virDomainCapsStringValuesPtr values)
{
    size_t i;

    for (i = 0; i < values->nvalues; i++)
        virBufferEscapeString(buf, "<value>%s</value>\n", values->values[i]);
}


377 378
#define FORMAT_PROLOGUE(item) \
    do { \
379 380
        if (item->supported == VIR_TRISTATE_BOOL_ABSENT) \
            return; \
381
        virBufferAsprintf(buf, "<" #item " supported='%s'%s\n", \
382 383
                (item->supported == VIR_TRISTATE_BOOL_YES) ? "yes" : "no", \
                (item->supported == VIR_TRISTATE_BOOL_YES) ? ">" : "/>"); \
384
        if (item->supported == VIR_TRISTATE_BOOL_NO) \
385 386
            return; \
        virBufferAdjustIndent(buf, 2); \
M
Michal Privoznik 已提交
387 388
    } while (0)

389 390 391 392
#define FORMAT_EPILOGUE(item) \
    do { \
        virBufferAdjustIndent(buf, -2); \
        virBufferAddLit(buf, "</" #item ">\n"); \
M
Michal Privoznik 已提交
393 394
    } while (0)

395 396
#define FORMAT_SINGLE(name, supported) \
    do { \
397 398 399 400
        if (supported != VIR_TRISTATE_BOOL_ABSENT) { \
            virBufferAsprintf(&buf, "<%s supported='%s'/>\n", name, \
                    (supported == VIR_TRISTATE_BOOL_YES) ? "yes" : "no"); \
        } \
401 402
    } while (0)

403 404 405 406
#define ENUM_PROCESS(master, capsEnum, valToStr) \
    do { \
        virDomainCapsEnumFormat(buf, &master->capsEnum, \
                                #capsEnum, valToStr); \
M
Michal Privoznik 已提交
407 408
    } while (0)

409 410 411 412 413 414 415

static void
virDomainCapsLoaderFormat(virBufferPtr buf,
                          virDomainCapsLoaderPtr loader)
{
    FORMAT_PROLOGUE(loader);

416
    virDomainCapsStringValuesFormat(buf, &loader->values);
417 418
    ENUM_PROCESS(loader, type, virDomainLoaderTypeToString);
    ENUM_PROCESS(loader, readonly, virTristateBoolTypeToString);
419
    ENUM_PROCESS(loader, secure, virTristateBoolTypeToString);
420 421 422 423 424 425 426 427 428 429 430 431

    FORMAT_EPILOGUE(loader);
}

static void
virDomainCapsOSFormat(virBufferPtr buf,
                      virDomainCapsOSPtr os)
{
    virDomainCapsLoaderPtr loader = &os->loader;

    FORMAT_PROLOGUE(os);

432 433
    ENUM_PROCESS(os, firmware, virDomainOsDefFirmwareTypeToString);

434 435 436 437 438
    virDomainCapsLoaderFormat(buf, loader);

    FORMAT_EPILOGUE(os);
}

439 440 441 442 443 444 445 446 447
static void
virDomainCapsCPUCustomFormat(virBufferPtr buf,
                             virDomainCapsCPUModelsPtr custom)
{
    size_t i;

    virBufferAdjustIndent(buf, 2);

    for (i = 0; i < custom->nmodels; i++) {
J
Jiri Denemark 已提交
448 449 450 451
        virDomainCapsCPUModelPtr model = custom->models + i;
        virBufferAsprintf(buf, "<model usable='%s'>%s</model>\n",
                          virDomainCapsCPUUsableTypeToString(model->usable),
                          model->name);
452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467
    }

    virBufferAdjustIndent(buf, -2);
}

static void
virDomainCapsCPUFormat(virBufferPtr buf,
                       virDomainCapsCPUPtr cpu)
{
    virBufferAddLit(buf, "<cpu>\n");
    virBufferAdjustIndent(buf, 2);

    virBufferAsprintf(buf, "<mode name='%s' supported='%s'/>\n",
                      virCPUModeTypeToString(VIR_CPU_MODE_HOST_PASSTHROUGH),
                      cpu->hostPassthrough ? "yes" : "no");

468 469 470 471 472 473
    virBufferAsprintf(buf, "<mode name='%s' ",
                      virCPUModeTypeToString(VIR_CPU_MODE_HOST_MODEL));
    if (cpu->hostModel) {
        virBufferAddLit(buf, "supported='yes'>\n");
        virBufferAdjustIndent(buf, 2);

474
        virCPUDefFormatBuf(buf, cpu->hostModel);
475 476 477 478 479 480

        virBufferAdjustIndent(buf, -2);
        virBufferAddLit(buf, "</mode>\n");
    } else {
        virBufferAddLit(buf, "supported='no'/>\n");
    }
481 482 483 484 485 486 487 488 489 490 491 492 493 494 495

    virBufferAsprintf(buf, "<mode name='%s' ",
                      virCPUModeTypeToString(VIR_CPU_MODE_CUSTOM));
    if (cpu->custom && cpu->custom->nmodels) {
        virBufferAddLit(buf, "supported='yes'>\n");
        virDomainCapsCPUCustomFormat(buf, cpu->custom);
        virBufferAddLit(buf, "</mode>\n");
    } else {
        virBufferAddLit(buf, "supported='no'/>\n");
    }

    virBufferAdjustIndent(buf, -2);
    virBufferAddLit(buf, "</cpu>\n");
}

M
Michal Privoznik 已提交
496 497 498 499 500 501 502 503
static void
virDomainCapsDeviceDiskFormat(virBufferPtr buf,
                              virDomainCapsDeviceDiskPtr const disk)
{
    FORMAT_PROLOGUE(disk);

    ENUM_PROCESS(disk, diskDevice, virDomainDiskDeviceTypeToString);
    ENUM_PROCESS(disk, bus, virDomainDiskBusTypeToString);
504
    ENUM_PROCESS(disk, model, virDomainDiskModelTypeToString);
M
Michal Privoznik 已提交
505 506 507 508 509

    FORMAT_EPILOGUE(disk);
}


510 511 512 513 514 515 516 517 518 519 520 521
static void
virDomainCapsDeviceGraphicsFormat(virBufferPtr buf,
                                  virDomainCapsDeviceGraphicsPtr const graphics)
{
    FORMAT_PROLOGUE(graphics);

    ENUM_PROCESS(graphics, type, virDomainGraphicsTypeToString);

    FORMAT_EPILOGUE(graphics);
}


522 523 524 525 526 527 528 529 530 531 532 533
static void
virDomainCapsDeviceVideoFormat(virBufferPtr buf,
                               virDomainCapsDeviceVideoPtr const video)
{
    FORMAT_PROLOGUE(video);

    ENUM_PROCESS(video, modelType, virDomainVideoTypeToString);

    FORMAT_EPILOGUE(video);
}


M
Michal Privoznik 已提交
534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549
static void
virDomainCapsDeviceHostdevFormat(virBufferPtr buf,
                                 virDomainCapsDeviceHostdevPtr const hostdev)
{
    FORMAT_PROLOGUE(hostdev);

    ENUM_PROCESS(hostdev, mode, virDomainHostdevModeTypeToString);
    ENUM_PROCESS(hostdev, startupPolicy, virDomainStartupPolicyTypeToString);
    ENUM_PROCESS(hostdev, subsysType, virDomainHostdevSubsysTypeToString);
    ENUM_PROCESS(hostdev, capsType, virDomainHostdevCapsTypeToString);
    ENUM_PROCESS(hostdev, pciBackend, virDomainHostdevSubsysPCIBackendTypeToString);

    FORMAT_EPILOGUE(hostdev);
}


550 551 552 553 554 555 556 557 558 559 560 561 562
static void
virDomainCapsDeviceRNGFormat(virBufferPtr buf,
                             virDomainCapsDeviceRNGPtr const rng)
{
    FORMAT_PROLOGUE(rng);

    ENUM_PROCESS(rng, model, virDomainRNGModelTypeToString);
    ENUM_PROCESS(rng, backendModel, virDomainRNGBackendTypeToString);

    FORMAT_EPILOGUE(rng);
}


A
Andrea Bolognani 已提交
563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589
/**
 * virDomainCapsFeatureGICFormat:
 * @buf: target buffer
 * @gic: GIC features
 *
 * Format GIC features for inclusion in the domcapabilities XML.
 *
 * The resulting XML will look like
 *
 *   <gic supported='yes'>
 *     <enum name='version>
 *       <value>2</value>
 *       <value>3</value>
 *     </enum>
 *   </gic>
 */
static void
virDomainCapsFeatureGICFormat(virBufferPtr buf,
                              virDomainCapsFeatureGICPtr const gic)
{
    FORMAT_PROLOGUE(gic);

    ENUM_PROCESS(gic, version, virGICVersionTypeToString);

    FORMAT_EPILOGUE(gic);
}

590 591 592 593
static void
virDomainCapsFeatureSEVFormat(virBufferPtr buf,
                              virSEVCapabilityPtr const sev)
{
594 595 596 597 598 599 600
    if (!sev) {
        virBufferAddLit(buf, "<sev supported='no'/>\n");
    } else {
        virBufferAddLit(buf, "<sev supported='yes'>\n");
        virBufferAdjustIndent(buf, 2);
        virBufferAsprintf(buf, "<cbitpos>%d</cbitpos>\n", sev->cbitpos);
        virBufferAsprintf(buf, "<reducedPhysBits>%d</reducedPhysBits>\n",
601
                          sev->reduced_phys_bits);
602 603 604 605 606
        virBufferAdjustIndent(buf, -2);
        virBufferAddLit(buf, "</sev>\n");
    }

    return;
607 608
}

A
Andrea Bolognani 已提交
609

610 611
char *
virDomainCapsFormat(virDomainCapsPtr const caps)
M
Michal Privoznik 已提交
612
{
613
    virBuffer buf = VIR_BUFFER_INITIALIZER;
M
Michal Privoznik 已提交
614 615 616
    const char *virttype_str = virDomainVirtTypeToString(caps->virttype);
    const char *arch_str = virArchToString(caps->arch);

617 618
    virBufferAddLit(&buf, "<domainCapabilities>\n");
    virBufferAdjustIndent(&buf, 2);
M
Michal Privoznik 已提交
619

620 621
    virBufferEscapeString(&buf, "<path>%s</path>\n", caps->path);
    virBufferAsprintf(&buf, "<domain>%s</domain>\n", virttype_str);
622
    if (caps->machine)
623 624
        virBufferAsprintf(&buf, "<machine>%s</machine>\n", caps->machine);
    virBufferAsprintf(&buf, "<arch>%s</arch>\n", arch_str);
M
Michal Privoznik 已提交
625 626

    if (caps->maxvcpus)
627
        virBufferAsprintf(&buf, "<vcpu max='%d'/>\n", caps->maxvcpus);
M
Michal Privoznik 已提交
628

629
    FORMAT_SINGLE("iothreads", caps->iothreads);
630

631 632
    virDomainCapsOSFormat(&buf, &caps->os);
    virDomainCapsCPUFormat(&buf, &caps->cpu);
633

634 635
    virBufferAddLit(&buf, "<devices>\n");
    virBufferAdjustIndent(&buf, 2);
M
Michal Privoznik 已提交
636

637 638 639 640
    virDomainCapsDeviceDiskFormat(&buf, &caps->disk);
    virDomainCapsDeviceGraphicsFormat(&buf, &caps->graphics);
    virDomainCapsDeviceVideoFormat(&buf, &caps->video);
    virDomainCapsDeviceHostdevFormat(&buf, &caps->hostdev);
641
    virDomainCapsDeviceRNGFormat(&buf, &caps->rng);
M
Michal Privoznik 已提交
642

643 644
    virBufferAdjustIndent(&buf, -2);
    virBufferAddLit(&buf, "</devices>\n");
M
Michal Privoznik 已提交
645

646 647
    virBufferAddLit(&buf, "<features>\n");
    virBufferAdjustIndent(&buf, 2);
A
Andrea Bolognani 已提交
648

649
    virDomainCapsFeatureGICFormat(&buf, &caps->gic);
650 651
    FORMAT_SINGLE("vmcoreinfo", caps->vmcoreinfo);
    FORMAT_SINGLE("genid", caps->genid);
652
    virDomainCapsFeatureSEVFormat(&buf, caps->sev);
653

654 655
    virBufferAdjustIndent(&buf, -2);
    virBufferAddLit(&buf, "</features>\n");
A
Andrea Bolognani 已提交
656

657 658
    virBufferAdjustIndent(&buf, -2);
    virBufferAddLit(&buf, "</domainCapabilities>\n");
M
Michal Privoznik 已提交
659

660
    virBufferCheckError(&buf);
M
Michal Privoznik 已提交
661 662
    return virBufferContentAndReset(&buf);
}