virt-aa-helper.c 40.0 KB
Newer Older
J
Jamie Strandboge 已提交
1 2
/*
 * virt-aa-helper: wrapper program used by AppArmor security driver.
3
 *
4
 * Copyright (C) 2010-2014 Red Hat, Inc.
5
 * Copyright (C) 2009-2011 Canonical Ltd.
J
Jamie Strandboge 已提交
6
 *
O
Osier Yang 已提交
7 8 9 10 11 12 13 14 15 16 17
 * This library is free software; you can redistribute it and/or
 * modify it under the terms of the GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or (at your option) any later version.
 *
 * This library is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
 * Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public
18
 * License along with this library.  If not, see
O
Osier Yang 已提交
19
 * <http://www.gnu.org/licenses/>.
J
Jamie Strandboge 已提交
20 21 22 23 24 25 26 27 28 29 30 31 32 33 34
 *
 * Author:
 *   Jamie Strandboge <jamie@canonical.com>
 *
 */

#include <config.h>

#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <stdarg.h>
#include <unistd.h>
#include <errno.h>
#include <sys/types.h>
35
#include <sys/stat.h>
J
Jamie Strandboge 已提交
36 37 38
#include <fcntl.h>
#include <getopt.h>
#include <sys/utsname.h>
39
#include <locale.h>
J
Jamie Strandboge 已提交
40 41

#include "internal.h"
42
#include "virbuffer.h"
43
#include "viralloc.h"
44
#include "vircommand.h"
J
Jamie Strandboge 已提交
45 46 47 48

#include "security_driver.h"
#include "security_apparmor.h"
#include "domain_conf.h"
49
#include "virxml.h"
50
#include "viruuid.h"
51
#include "virusb.h"
52
#include "virpci.h"
E
Eric Blake 已提交
53
#include "virfile.h"
54
#include "configmake.h"
55
#include "virrandom.h"
56
#include "virstring.h"
J
Jamie Strandboge 已提交
57

58 59
#include "storage/storage_driver.h"

60 61
#define VIR_FROM_THIS VIR_FROM_SECURITY

J
Jamie Strandboge 已提交
62 63 64
static char *progname;

typedef struct {
65
    bool allowDiskFormatProbing;
J
Jamie Strandboge 已提交
66 67 68 69 70 71 72 73 74
    char uuid[PROFILE_NAME_SIZE];       /* UUID of vm */
    bool dryrun;                /* dry run */
    char cmd;                   /* 'c'   create
                                 * 'a'   add (load)
                                 * 'r'   replace
                                 * 'R'   remove */
    char *files;                /* list of files */
    virDomainDefPtr def;        /* VM definition */
    virCapsPtr caps;            /* VM capabilities */
75
    virDomainXMLOptionPtr xmlopt; /* XML parser data */
J
Jamie Strandboge 已提交
76
    char *hvm;                  /* type of hypervisor (eg hvm, xen) */
77
    virArch arch;               /* machine architecture */
78 79
    char *newfile;              /* newly added file */
    bool append;                /* append to .files instead of rewrite */
J
Jamie Strandboge 已提交
80 81 82 83 84 85 86 87 88
} vahControl;

static int
vahDeinit(vahControl * ctl)
{
    if (ctl == NULL)
        return -1;

    VIR_FREE(ctl->def);
89
    virObjectUnref(ctl->caps);
90
    virObjectUnref(ctl->xmlopt);
91 92
    VIR_FREE(ctl->files);
    VIR_FREE(ctl->hvm);
93
    VIR_FREE(ctl->newfile);
J
Jamie Strandboge 已提交
94 95 96 97 98 99 100 101 102 103

    return 0;
}

/*
 * Print usage
 */
static void
vah_usage(void)
{
104 105 106 107 108 109 110 111 112 113 114 115 116 117 118
    printf(_("\n%s [options] [< def.xml]\n\n"
            "  Options:\n"
            "    -a | --add                     load profile\n"
            "    -c | --create                  create profile from template\n"
            "    -D | --delete                  unload and delete profile\n"
            "    -f | --add-file <file>         add file to profile\n"
            "    -F | --append-file <file>      append file to profile\n"
            "    -r | --replace                 reload profile\n"
            "    -R | --remove                  unload profile\n"
            "    -h | --help                    this help\n"
            "    -u | --uuid <uuid>             uuid (profile name)\n"
            "\n"), progname);

    puts(_("This command is intended to be used by libvirtd "
           "and not used directly.\n"));
J
Jamie Strandboge 已提交
119 120 121 122 123 124
    return;
}

static void
vah_error(vahControl * ctl, int doexit, const char *str)
{
125
    fprintf(stderr, _("%s: error: %s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
126 127 128 129 130 131 132 133 134 135 136

    if (doexit) {
        if (ctl != NULL)
            vahDeinit(ctl);
        exit(EXIT_FAILURE);
    }
}

static void
vah_warning(const char *str)
{
137
    fprintf(stderr, _("%s: warning: %s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
138 139 140 141 142
}

static void
vah_info(const char *str)
{
143
    fprintf(stderr, _("%s:\n%s%c"), progname, str, '\n');
J
Jamie Strandboge 已提交
144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159
}

/*
 * Replace @oldstr in @orig with @repstr
 * @len is number of bytes allocated for @orig. Assumes @orig, @oldstr and
 * @repstr are null terminated
 */
static int
replace_string(char *orig, const size_t len, const char *oldstr,
               const char *repstr)
{
    int idx;
    char *pos = NULL;
    char *tmp = NULL;

    if ((pos = strstr(orig, oldstr)) == NULL) {
160
        vah_error(NULL, 0, _("could not find replacement string"));
J
Jamie Strandboge 已提交
161 162 163
        return -1;
    }

164
    if (VIR_ALLOC_N_QUIET(tmp, len) < 0) {
165
        vah_error(NULL, 0, _("could not allocate memory for string"));
J
Jamie Strandboge 已提交
166 167 168 169 170 171 172 173 174 175 176
        return -1;
    }
    tmp[0] = '\0';

    idx = abs(pos - orig);

    /* copy everything up to oldstr */
    strncat(tmp, orig, idx);

    /* add the replacement string */
    if (strlen(tmp) + strlen(repstr) > len - 1) {
177
        vah_error(NULL, 0, _("not enough space in target buffer"));
J
Jamie Strandboge 已提交
178 179 180 181 182 183 184
        VIR_FREE(tmp);
        return -1;
    }
    strcat(tmp, repstr);

    /* add everything after oldstr */
    if (strlen(tmp) + strlen(orig) - (idx + strlen(oldstr)) > len - 1) {
185
        vah_error(NULL, 0, _("not enough space in target buffer"));
J
Jamie Strandboge 已提交
186 187 188 189 190 191 192
        VIR_FREE(tmp);
        return -1;
    }
    strncat(tmp, orig + idx + strlen(oldstr),
            strlen(orig) - (idx + strlen(oldstr)));

    if (virStrcpy(orig, tmp, len) == NULL) {
193
        vah_error(NULL, 0, _("error replacing string"));
J
Jamie Strandboge 已提交
194 195 196 197 198 199 200 201 202 203 204 205 206 207
        VIR_FREE(tmp);
        return -1;
    }
    VIR_FREE(tmp);

    return 0;
}

/*
 * run an apparmor_parser command
 */
static int
parserCommand(const char *profile_name, const char cmd)
{
208
    int result = -1;
J
Jamie Strandboge 已提交
209
    char flag[3];
210
    char *profile;
211 212
    int status;
    int ret;
J
Jamie Strandboge 已提交
213 214

    if (strchr("arR", cmd) == NULL) {
215
        vah_error(NULL, 0, _("invalid flag"));
J
Jamie Strandboge 已提交
216 217 218 219 220
        return -1;
    }

    snprintf(flag, 3, "-%c", cmd);

221 222
    if (virAsprintfQuiet(&profile, "%s/%s",
                         APPARMOR_DIR "/libvirt", profile_name) < 0) {
223
        vah_error(NULL, 0, _("profile name exceeds maximum length"));
J
Jamie Strandboge 已提交
224 225 226 227
        return -1;
    }

    if (!virFileExists(profile)) {
228
        vah_error(NULL, 0, _("profile does not exist"));
229
        goto cleanup;
J
Jamie Strandboge 已提交
230 231 232 233
    } else {
        const char * const argv[] = {
            "/sbin/apparmor_parser", flag, profile, NULL
        };
234 235 236
        if ((ret = virRun(argv, &status)) != 0 ||
            (WIFEXITED(status) && WEXITSTATUS(status) != 0)) {
            if (ret != 0) {
237
                vah_error(NULL, 0, _("failed to run apparmor_parser"));
238
                goto cleanup;
239 240 241
            } else if (cmd == 'R' && WIFEXITED(status) &&
                       WEXITSTATUS(status) == 234) {
                vah_warning(_("unable to unload already unloaded profile"));
242
            } else {
243
                vah_error(NULL, 0, _("apparmor_parser exited with error"));
244
                goto cleanup;
245
            }
J
Jamie Strandboge 已提交
246 247 248
        }
    }

249 250
    result = 0;

251
 cleanup:
252 253 254
    VIR_FREE(profile);

    return result;
J
Jamie Strandboge 已提交
255 256 257 258 259 260
}

/*
 * Update the dynamic files
 */
static int
261 262
update_include_file(const char *include_file, const char *included_files,
                    bool append)
J
Jamie Strandboge 已提交
263 264
{
    int rc = -1;
265
    int plen, flen = 0;
J
Jamie Strandboge 已提交
266 267
    int fd;
    char *pcontent = NULL;
268
    char *existing = NULL;
J
Jamie Strandboge 已提交
269 270 271
    const char *warning =
         "# DO NOT EDIT THIS FILE DIRECTLY. IT IS MANAGED BY LIBVIRT.\n";

272 273 274 275 276 277 278
    if (virFileExists(include_file)) {
        flen = virFileReadAll(include_file, MAX_FILE_LEN, &existing);
        if (flen < 0)
            return rc;
    }

    if (append && virFileExists(include_file)) {
279
        if (virAsprintfQuiet(&pcontent, "%s%s", existing, included_files) == -1) {
280
            vah_error(NULL, 0, _("could not allocate memory for profile"));
281
            goto cleanup;
282 283
        }
    } else {
284
        if (virAsprintfQuiet(&pcontent, "%s%s", warning, included_files) == -1) {
285
            vah_error(NULL, 0, _("could not allocate memory for profile"));
286
            goto cleanup;
287
        }
J
Jamie Strandboge 已提交
288 289 290 291
    }

    plen = strlen(pcontent);
    if (plen > MAX_FILE_LEN) {
292
        vah_error(NULL, 0, _("invalid length for new profile"));
293
        goto cleanup;
J
Jamie Strandboge 已提交
294 295 296
    }

    /* only update the disk profile if it is different */
297 298
    if (flen > 0 && flen == plen && STREQLEN(existing, pcontent, plen)) {
        rc = 0;
299
        goto cleanup;
J
Jamie Strandboge 已提交
300 301 302 303
    }

    /* write the file */
    if ((fd = open(include_file, O_CREAT | O_TRUNC | O_WRONLY, 0644)) == -1) {
304
        vah_error(NULL, 0, _("failed to create include file"));
305
        goto cleanup;
J
Jamie Strandboge 已提交
306 307 308
    }

    if (safewrite(fd, pcontent, plen) < 0) { /* don't write the '\0' */
309
        VIR_FORCE_CLOSE(fd);
310
        vah_error(NULL, 0, _("failed to write to profile"));
311
        goto cleanup;
J
Jamie Strandboge 已提交
312 313
    }

314
    if (VIR_CLOSE(fd) != 0) {
315
        vah_error(NULL, 0, _("failed to close or write to profile"));
316
        goto cleanup;
J
Jamie Strandboge 已提交
317 318 319
    }
    rc = 0;

320
 cleanup:
J
Jamie Strandboge 已提交
321
    VIR_FREE(pcontent);
322
    VIR_FREE(existing);
J
Jamie Strandboge 已提交
323 324 325 326 327 328 329 330 331

    return rc;
}

/*
 * Create a profile based on a template
 */
static int
create_profile(const char *profile, const char *profile_name,
332
               const char *profile_files, int virtType)
J
Jamie Strandboge 已提交
333
{
334
    char *template;
J
Jamie Strandboge 已提交
335 336 337 338 339 340 341 342 343
    char *tcontent = NULL;
    char *pcontent = NULL;
    char *replace_name = NULL;
    char *replace_files = NULL;
    const char *template_name = "\nprofile LIBVIRT_TEMPLATE";
    const char *template_end = "\n}";
    int tlen, plen;
    int fd;
    int rc = -1;
344
    const char *driver_name = NULL;
J
Jamie Strandboge 已提交
345 346

    if (virFileExists(profile)) {
347
        vah_error(NULL, 0, _("profile exists"));
J
Jamie Strandboge 已提交
348 349 350
        goto end;
    }

351 352 353 354 355 356 357 358 359
    switch (virtType) {
    case VIR_DOMAIN_VIRT_QEMU:
    case VIR_DOMAIN_VIRT_KQEMU:
    case VIR_DOMAIN_VIRT_KVM:
        driver_name = "qemu";
        break;
    default:
        driver_name = virDomainVirtTypeToString(virtType);
    }
C
Cédric Bosdonnat 已提交
360 361

    if (virAsprintfQuiet(&template, "%s/TEMPLATE.%s", APPARMOR_DIR "/libvirt",
362
                         driver_name) < 0) {
363
        vah_error(NULL, 0, _("template name exceeds maximum length"));
J
Jamie Strandboge 已提交
364 365 366 367
        goto end;
    }

    if (!virFileExists(template)) {
368
        vah_error(NULL, 0, _("template does not exist"));
J
Jamie Strandboge 已提交
369 370 371 372
        goto end;
    }

    if ((tlen = virFileReadAll(template, MAX_FILE_LEN, &tcontent)) < 0) {
373
        vah_error(NULL, 0, _("failed to read AppArmor template"));
J
Jamie Strandboge 已提交
374 375 376 377
        goto end;
    }

    if (strstr(tcontent, template_name) == NULL) {
378
        vah_error(NULL, 0, _("no replacement string in template"));
J
Jamie Strandboge 已提交
379 380 381 382
        goto clean_tcontent;
    }

    if (strstr(tcontent, template_end) == NULL) {
383
        vah_error(NULL, 0, _("no replacement string in template"));
J
Jamie Strandboge 已提交
384 385 386 387
        goto clean_tcontent;
    }

    /* '\nprofile <profile_name>\0' */
388
    if (virAsprintfQuiet(&replace_name, "\nprofile %s", profile_name) == -1) {
389
        vah_error(NULL, 0, _("could not allocate memory for profile name"));
J
Jamie Strandboge 已提交
390 391 392 393
        goto clean_tcontent;
    }

    /* '\n<profile_files>\n}\0' */
394 395
    if ((virtType != VIR_DOMAIN_VIRT_LXC) &&
            virAsprintfQuiet(&replace_files, "\n%s\n}", profile_files) == -1) {
396
        vah_error(NULL, 0, _("could not allocate memory for profile files"));
J
Jamie Strandboge 已提交
397 398 399 400
        VIR_FREE(replace_name);
        goto clean_tcontent;
    }

C
Cédric Bosdonnat 已提交
401
    plen = tlen + strlen(replace_name) - strlen(template_name) + 1;
402 403 404 405

    if (virtType != VIR_DOMAIN_VIRT_LXC)
        plen += strlen(replace_files) - strlen(template_end);

J
Jamie Strandboge 已提交
406
    if (plen > MAX_FILE_LEN || plen < tlen) {
407
        vah_error(NULL, 0, _("invalid length for new profile"));
J
Jamie Strandboge 已提交
408 409 410
        goto clean_replace;
    }

411
    if (VIR_ALLOC_N_QUIET(pcontent, plen) < 0) {
412
        vah_error(NULL, 0, _("could not allocate memory for profile"));
J
Jamie Strandboge 已提交
413 414 415 416 417 418 419 420
        goto clean_replace;
    }
    pcontent[0] = '\0';
    strcpy(pcontent, tcontent);

    if (replace_string(pcontent, plen, template_name, replace_name) < 0)
        goto clean_all;

421 422
    if ((virtType != VIR_DOMAIN_VIRT_LXC) &&
            replace_string(pcontent, plen, template_end, replace_files) < 0)
J
Jamie Strandboge 已提交
423 424 425 426
        goto clean_all;

    /* write the file */
    if ((fd = open(profile, O_CREAT | O_EXCL | O_WRONLY, 0644)) == -1) {
427
        vah_error(NULL, 0, _("failed to create profile"));
J
Jamie Strandboge 已提交
428 429 430 431
        goto clean_all;
    }

    if (safewrite(fd, pcontent, plen - 1) < 0) { /* don't write the '\0' */
432
        VIR_FORCE_CLOSE(fd);
433
        vah_error(NULL, 0, _("failed to write to profile"));
J
Jamie Strandboge 已提交
434 435 436
        goto clean_all;
    }

437
    if (VIR_CLOSE(fd) != 0) {
438
        vah_error(NULL, 0, _("failed to close or write to profile"));
J
Jamie Strandboge 已提交
439 440 441 442
        goto clean_all;
    }
    rc = 0;

443
 clean_all:
J
Jamie Strandboge 已提交
444
    VIR_FREE(pcontent);
445
 clean_replace:
J
Jamie Strandboge 已提交
446 447
    VIR_FREE(replace_name);
    VIR_FREE(replace_files);
448
 clean_tcontent:
J
Jamie Strandboge 已提交
449
    VIR_FREE(tcontent);
450
 end:
451
    VIR_FREE(template);
J
Jamie Strandboge 已提交
452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505
    return rc;
}

/*
 * Load an existing profile
 */
static int
parserLoad(const char *profile_name)
{
    return parserCommand(profile_name, 'a');
}

/*
 * Remove an existing profile
 */
static int
parserRemove(const char *profile_name)
{
    return parserCommand(profile_name, 'R');
}

/*
 * Replace an existing profile
 */
static int
parserReplace(const char *profile_name)
{
    return parserCommand(profile_name, 'r');
}

static int
valid_uuid(const char *uuid)
{
    unsigned char rawuuid[VIR_UUID_BUFLEN];

    if (strlen(uuid) != PROFILE_NAME_SIZE - 1)
        return -1;

    if (!STRPREFIX(uuid, AA_PREFIX))
        return -1;

    if (virUUIDParse(uuid + strlen(AA_PREFIX), rawuuid) < 0)
        return -1;

    return 0;
}

static int
valid_name(const char *name)
{
    /* just try to filter out any dangerous characters in the name that can be
     * used to subvert the profile */
    const char *bad = " /[]*";

506
    if (strlen(name) == 0)
J
Jamie Strandboge 已提交
507 508 509 510 511 512 513 514 515 516 517 518
        return -1;

    if (strcspn(name, bad) != strlen(name))
        return -1;

    return 0;
}

/* see if one of the strings in arr starts with str */
static int
array_starts_with(const char *str, const char * const *arr, const long size)
{
519
    size_t i;
J
Jamie Strandboge 已提交
520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545
    for (i = 0; i < size; i++) {
        if (strlen(str) < strlen(arr[i]))
            continue;

        if (STRPREFIX(str, arr[i]))
            return 0;
    }
    return 1;
}

/*
 * Don't allow access to special files or restricted paths such as /bin, /sbin,
 * /usr/bin, /usr/sbin and /etc. This is in an effort to prevent read/write
 * access to system files which could be used to elevate privileges. This is a
 * safety measure in case libvirtd is under a restrictive profile and is
 * subverted and trying to escape confinement.
 *
 * Note that we cannot exclude block devices because they are valid devices.
 * The TEMPLATE file can be adjusted to explicitly disallow these if needed.
 *
 * RETURN: -1 on error, 0 if ok, 1 if blocked
 */
static int
valid_path(const char *path, const bool readonly)
{
    struct stat sb;
546
    int npaths, opaths;
J
Jamie Strandboge 已提交
547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571
    const char * const restricted[] = {
        "/bin/",
        "/etc/",
        "/lib",
        "/lost+found/",
        "/proc/",
        "/sbin/",
        "/selinux/",
        "/sys/",
        "/usr/bin/",
        "/usr/lib",
        "/usr/sbin/",
        "/usr/share/",
        "/usr/local/bin/",
        "/usr/local/etc/",
        "/usr/local/lib",
        "/usr/local/sbin/"
    };
    /* these paths are ok for readonly, but not read/write */
    const char * const restricted_rw[] = {
        "/boot/",
        "/vmlinuz",
        "/initrd",
        "/initrd.img"
    };
572 573
    /* override the above with these */
    const char * const override[] = {
J
John Ferlan 已提交
574
        "/sys/devices/pci",              /* for hostdev pci devices */
575
        "/etc/libvirt-sandbox/services/" /* for virt-sandbox service config */
576
    };
J
Jamie Strandboge 已提交
577

578
    if (path == NULL) {
579
        vah_error(NULL, 0, _("bad pathname"));
J
Jamie Strandboge 已提交
580 581 582 583 584 585 586 587 588
        return -1;
    }

    /* Don't allow double quotes, since we use them to quote the filename
     * and this will confuse the apparmor parser.
     */
    if (strchr(path, '"') != NULL)
        return 1;

J
Jamie Strandboge 已提交
589 590 591 592
    /* Require an absolute path */
    if (STRNEQLEN(path, "/", 1))
        return 1;

593
    if (!virFileExists(path)) {
594
        vah_warning(_("path does not exist, skipping file type checks"));
595
    } else {
J
Jamie Strandboge 已提交
596 597 598 599 600 601 602 603 604 605 606 607
        if (stat(path, &sb) == -1)
            return -1;

        switch (sb.st_mode & S_IFMT) {
            case S_IFSOCK:
                return 1;
                break;
            default:
                break;
        }
    }

608
    opaths = sizeof(override)/sizeof(*(override));
609

610
    npaths = sizeof(restricted)/sizeof(*(restricted));
611 612 613
    if (array_starts_with(path, restricted, npaths) == 0 &&
        array_starts_with(path, override, opaths) != 0)
            return 1;
J
Jamie Strandboge 已提交
614

615
    npaths = sizeof(restricted_rw)/sizeof(*(restricted_rw));
J
Jamie Strandboge 已提交
616 617 618 619 620 621 622 623
    if (!readonly) {
        if (array_starts_with(path, restricted_rw, npaths) == 0)
            return 1;
    }

    return 0;
}

624 625 626 627 628 629 630
static int
verify_xpath_context(xmlXPathContextPtr ctxt)
{
    int rc = -1;
    char *tmp = NULL;

    if (!ctxt) {
631
        vah_warning(_("Invalid context"));
632 633 634 635 636
        goto error;
    }

    /* check if have <name> */
    if (!(tmp = virXPathString("string(./name[1])", ctxt))) {
637
        vah_warning(_("Could not find <name>"));
638 639 640 641 642 643
        goto error;
    }
    VIR_FREE(tmp);

    /* check if have <uuid> */
    if (!(tmp = virXPathString("string(./uuid[1])", ctxt))) {
644
        vah_warning(_("Could not find <uuid>"));
645 646 647 648 649 650
        goto error;
    }
    VIR_FREE(tmp);

    rc = 0;

651
 error:
652 653 654
    return rc;
}

655 656 657 658 659 660 661 662 663 664 665 666 667
/*
 * Parse the xml we received to fill in the following:
 * ctl->hvm
 * ctl->arch
 *
 * These are suitable for setting up a virCapsPtr
 */
static int
caps_mockup(vahControl * ctl, const char *xmlStr)
{
    int rc = -1;
    xmlDocPtr xml = NULL;
    xmlXPathContextPtr ctxt = NULL;
668
    char *arch;
669

670
    if (!(xml = virXMLParseStringCtxt(xmlStr, _("(domain_definition)"),
671
                                      &ctxt))) {
672 673 674
        goto cleanup;
    }

675
    if (!xmlStrEqual(ctxt->node->name, BAD_CAST "domain")) {
676
        vah_error(NULL, 0, _("unexpected root element, expecting <domain>"));
677 678 679
        goto cleanup;
    }

680 681 682 683
    /* Quick sanity check for some required elements */
    if (verify_xpath_context(ctxt) != 0)
        goto cleanup;

684
    ctl->hvm = virXPathString("string(./os/type[1])", ctxt);
685 686
    if (!ctl->hvm) {
        vah_error(ctl, 0, _("os.type is not defined"));
687 688
        goto cleanup;
    }
689 690 691 692 693 694
    arch = virXPathString("string(./os/type[1]/@arch)", ctxt);
    if (!arch) {
        ctl->arch = virArchFromHost();
    } else {
        ctl->arch = virArchFromString(arch);
        VIR_FREE(arch);
695 696 697 698
    }

    rc = 0;

699
 cleanup:
700
    xmlFreeDoc(xml);
701 702 703 704 705
    xmlXPathFreeContext(ctxt);

    return rc;
}

706

J
Jamie Strandboge 已提交
707 708 709 710 711 712 713 714 715 716
static int
get_definition(vahControl * ctl, const char *xmlStr)
{
    int rc = -1;
    virCapsGuestPtr guest;  /* this is freed when caps is freed */

    /*
     * mock up some capabilities. We don't currently use these explicitly,
     * but need them for virDomainDefParseString().
     */
717 718
    if (caps_mockup(ctl, xmlStr) != 0)
        goto exit;
J
Jamie Strandboge 已提交
719

720
    if ((ctl->caps = virCapabilitiesNew(ctl->arch, true, true)) == NULL) {
721
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
722 723 724
        goto exit;
    }

725
    if (!(ctl->xmlopt = virDomainXMLOptionNew(NULL, NULL, NULL))) {
726 727 728 729
        vah_error(ctl, 0, _("Failed to create XML config object"));
        goto exit;
    }

J
Jamie Strandboge 已提交
730 731
    if ((guest = virCapabilitiesAddGuest(ctl->caps,
                                         ctl->hvm,
732
                                         ctl->arch,
J
Jamie Strandboge 已提交
733 734 735 736
                                         NULL,
                                         NULL,
                                         0,
                                         NULL)) == NULL) {
737
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
738 739 740
        goto exit;
    }

741 742
    ctl->def = virDomainDefParseString(xmlStr,
                                       ctl->caps, ctl->xmlopt,
743 744
                                       -1,
                                       VIR_DOMAIN_DEF_PARSE_INACTIVE);
J
Jamie Strandboge 已提交
745
    if (ctl->def == NULL) {
746
        vah_error(ctl, 0, _("could not parse XML"));
J
Jamie Strandboge 已提交
747 748 749 750
        goto exit;
    }

    if (!ctl->def->name) {
751
        vah_error(ctl, 0, _("could not find name in XML"));
J
Jamie Strandboge 已提交
752 753 754 755
        goto exit;
    }

    if (valid_name(ctl->def->name) != 0) {
756
        vah_error(ctl, 0, _("bad name"));
J
Jamie Strandboge 已提交
757 758 759 760 761
        goto exit;
    }

    rc = 0;

762
 exit:
J
Jamie Strandboge 已提交
763 764 765 766
    return rc;
}

static int
F
Felix Geyer 已提交
767
vah_add_path(virBufferPtr buf, const char *path, const char *perms, bool recursive)
J
Jamie Strandboge 已提交
768 769 770 771 772 773 774 775
{
    char *tmp = NULL;
    int rc = -1;
    bool readonly = true;

    if (path == NULL)
        return rc;

J
Jamie Strandboge 已提交
776 777 778 779 780 781
    /* Skip files without an absolute path. Not having one confuses the
     * apparmor parser and this also ensures things like tcp consoles don't
     * get added to the profile.
     */
    if (STRNEQLEN(path, "/", 1)) {
        vah_warning(path);
782
        vah_warning(_("skipped non-absolute path"));
J
Jamie Strandboge 已提交
783 784 785
        return 0;
    }

J
Jamie Strandboge 已提交
786 787 788
    if (virFileExists(path)) {
        if ((tmp = realpath(path, NULL)) == NULL) {
            vah_error(NULL, 0, path);
789
            vah_error(NULL, 0, _("could not find realpath for disk"));
J
Jamie Strandboge 已提交
790 791
            return rc;
        }
792 793 794
    } else if (VIR_STRDUP_QUIET(tmp, path) < 0) {
        return rc;
    }
J
Jamie Strandboge 已提交
795 796 797 798 799 800 801 802

    if (strchr(perms, 'w') != NULL)
        readonly = false;

    rc = valid_path(tmp, readonly);
    if (rc != 0) {
        if (rc > 0) {
            vah_error(NULL, 0, path);
803
            vah_error(NULL, 0, _("skipped restricted file"));
J
Jamie Strandboge 已提交
804
        }
805
        goto cleanup;
J
Jamie Strandboge 已提交
806 807
    }

F
Felix Geyer 已提交
808
    virBufferAsprintf(buf, "  \"%s%s\" %s,\n", tmp, recursive ? "/**" : "", perms);
809
    if (readonly) {
810
        virBufferAddLit(buf, "  # don't audit writes to readonly files\n");
F
Felix Geyer 已提交
811 812 813 814 815
        virBufferAsprintf(buf, "  deny \"%s%s\" w,\n", tmp, recursive ? "/**" : "");
    }
    if (recursive) {
        /* allow reading (but not creating) the dir */
        virBufferAsprintf(buf, "  \"%s/\" r,\n", tmp);
816
    }
J
Jamie Strandboge 已提交
817

818
 cleanup:
819
    VIR_FREE(tmp);
J
Jamie Strandboge 已提交
820 821 822 823

    return rc;
}

F
Felix Geyer 已提交
824 825 826 827 828 829
static int
vah_add_file(virBufferPtr buf, const char *path, const char *perms)
{
    return vah_add_path(buf, path, perms, false);
}

830 831 832 833 834 835 836 837 838 839 840 841
static int
vah_add_file_chardev(virBufferPtr buf,
                     const char *path,
                     const char *perms,
                     const int type)
{
    char *pipe_in;
    char *pipe_out;
    int rc = -1;

    if (type == VIR_DOMAIN_CHR_TYPE_PIPE) {
        /* add the pipe input */
842
        if (virAsprintfQuiet(&pipe_in, "%s.in", path) == -1) {
843
            vah_error(NULL, 0, _("could not allocate memory"));
844
            goto cleanup;
845 846 847 848 849 850
        }

        if (vah_add_file(buf, pipe_in, perms) != 0)
            goto clean_pipe_in;

        /* add the pipe output */
851
        if (virAsprintfQuiet(&pipe_out, "%s.out", path) == -1) {
852 853 854 855 856 857 858 859 860 861 862 863 864 865 866
            vah_error(NULL, 0, _("could not allocate memory"));
            goto clean_pipe_in;
        }

        if (vah_add_file(buf, pipe_out, perms) != 0)
            goto clean_pipe_out;

        rc = 0;
      clean_pipe_out:
        VIR_FREE(pipe_out);
      clean_pipe_in:
        VIR_FREE(pipe_in);
    } else {
        /* add the file */
        if (vah_add_file(buf, path, perms) != 0)
867
            goto cleanup;
868 869 870
        rc = 0;
    }

871
 cleanup:
872 873 874
    return rc;
}

J
Jamie Strandboge 已提交
875
static int
876
file_iterate_hostdev_cb(virUSBDevicePtr dev ATTRIBUTE_UNUSED,
877 878 879 880 881 882 883
                        const char *file, void *opaque)
{
    virBufferPtr buf = opaque;
    return vah_add_file(buf, file, "rw");
}

static int
884 885
file_iterate_pci_cb(virPCIDevicePtr dev ATTRIBUTE_UNUSED,
                    const char *file, void *opaque)
J
Jamie Strandboge 已提交
886 887 888 889 890
{
    virBufferPtr buf = opaque;
    return vah_add_file(buf, file, "rw");
}

891 892 893 894 895 896 897 898 899 900
static int
add_file_path(virDomainDiskDefPtr disk,
              const char *path,
              size_t depth,
              void *opaque)
{
    virBufferPtr buf = opaque;
    int ret;

    if (depth == 0) {
901
        if (disk->src->readonly)
902 903 904 905 906 907 908
            ret = vah_add_file(buf, path, "r");
        else
            ret = vah_add_file(buf, path, "rw");
    } else {
        ret = vah_add_file(buf, path, "r");
    }

909 910 911
    if (ret != 0)
        ret = -1;

912 913 914
    return ret;
}

J
Jamie Strandboge 已提交
915 916 917 918 919
static int
get_files(vahControl * ctl)
{
    virBuffer buf = VIR_BUFFER_INITIALIZER;
    int rc = -1;
920
    size_t i;
J
Jamie Strandboge 已提交
921 922
    char *uuid;
    char uuidstr[VIR_UUID_STRING_BUFLEN];
923
    bool needsVfio = false, needsvhost = false;
J
Jamie Strandboge 已提交
924 925 926

    /* verify uuid is same as what we were given on the command line */
    virUUIDFormat(ctl->def->uuid, uuidstr);
927
    if (virAsprintfQuiet(&uuid, "%s%s", AA_PREFIX, uuidstr) == -1) {
928
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
929 930 931 932
        return rc;
    }

    if (STRNEQ(uuid, ctl->uuid)) {
933
        vah_error(ctl, 0, _("given uuid does not match XML uuid"));
934
        goto cleanup;
J
Jamie Strandboge 已提交
935 936
    }

937
    for (i = 0; i < ctl->def->ndisks; i++) {
938 939
        virDomainDiskDefPtr disk = ctl->def->disks[i];

940
        if (!virDomainDiskGetSource(disk))
E
Eric Blake 已提交
941
            continue;
942 943 944
        /* XXX - if we knew the qemu user:group here we could send it in
         *        so that the open could be re-tried as that user:group.
         */
945
        if (!disk->src->backingStore) {
J
Jiri Denemark 已提交
946
            bool probe = ctl->allowDiskFormatProbing;
947
            virStorageFileGetMetadata(disk->src, -1, -1, probe, false);
J
Jiri Denemark 已提交
948
        }
949

950 951 952
        /* XXX passing ignoreOpenFailure = true to get back to the behavior
         * from before using virDomainDiskDefForeachPath. actually we should
         * be passing ignoreOpenFailure = false and handle open errors more
953 954
         * careful than just ignoring them.
         */
955
        if (virDomainDiskDefForeachPath(disk, true, add_file_path, &buf) < 0)
956
            goto cleanup;
957
    }
J
Jamie Strandboge 已提交
958 959

    for (i = 0; i < ctl->def->nserials; i++)
960
        if (ctl->def->serials[i] &&
961 962 963 964 965
            (ctl->def->serials[i]->source.type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->serials[i]->source.type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->serials[i]->source.type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->serials[i]->source.type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->serials[i]->source.data.file.path)
966 967 968 969
            if (vah_add_file_chardev(&buf,
                                     ctl->def->serials[i]->source.data.file.path,
                                     "rw",
                                     ctl->def->serials[i]->source.type) != 0)
970
                goto cleanup;
J
Jamie Strandboge 已提交
971

972 973 974 975 976 977 978 979 980
    for (i = 0; i < ctl->def->nconsoles; i++)
        if (ctl->def->consoles[i] &&
            (ctl->def->consoles[i]->source.type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->consoles[i]->source.type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->consoles[i]->source.type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->consoles[i]->source.type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->consoles[i]->source.data.file.path)
            if (vah_add_file(&buf,
                             ctl->def->consoles[i]->source.data.file.path, "rw") != 0)
981
                goto cleanup;
J
Jamie Strandboge 已提交
982

983
    for (i = 0; i < ctl->def->nparallels; i++)
984
        if (ctl->def->parallels[i] &&
985 986 987 988 989
            (ctl->def->parallels[i]->source.type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->parallels[i]->source.type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->parallels[i]->source.type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->parallels[i]->source.type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->parallels[i]->source.data.file.path)
990 991 992 993
            if (vah_add_file_chardev(&buf,
                                     ctl->def->parallels[i]->source.data.file.path,
                                     "rw",
                                     ctl->def->parallels[i]->source.type) != 0)
994
                goto cleanup;
995

996
    for (i = 0; i < ctl->def->nchannels; i++)
997
        if (ctl->def->channels[i] &&
998 999 1000 1001 1002
            (ctl->def->channels[i]->source.type == VIR_DOMAIN_CHR_TYPE_PTY ||
             ctl->def->channels[i]->source.type == VIR_DOMAIN_CHR_TYPE_DEV ||
             ctl->def->channels[i]->source.type == VIR_DOMAIN_CHR_TYPE_FILE ||
             ctl->def->channels[i]->source.type == VIR_DOMAIN_CHR_TYPE_PIPE) &&
            ctl->def->channels[i]->source.data.file.path)
1003 1004 1005 1006
            if (vah_add_file_chardev(&buf,
                                     ctl->def->channels[i]->source.data.file.path,
                                     "rw",
                                     ctl->def->channels[i]->source.type) != 0)
1007
                goto cleanup;
1008

1009
    if (ctl->def->os.kernel)
J
Jamie Strandboge 已提交
1010
        if (vah_add_file(&buf, ctl->def->os.kernel, "r") != 0)
1011
            goto cleanup;
J
Jamie Strandboge 已提交
1012

1013
    if (ctl->def->os.initrd)
J
Jamie Strandboge 已提交
1014
        if (vah_add_file(&buf, ctl->def->os.initrd, "r") != 0)
1015
            goto cleanup;
O
Olivia Yin 已提交
1016 1017 1018

    if (ctl->def->os.dtb)
        if (vah_add_file(&buf, ctl->def->os.dtb, "r") != 0)
1019
            goto cleanup;
J
Jamie Strandboge 已提交
1020

1021 1022
    if (ctl->def->os.loader && ctl->def->os.loader->path)
        if (vah_add_file(&buf, ctl->def->os.loader->path, "r") != 0)
1023
            goto cleanup;
1024

1025 1026 1027 1028
    for (i = 0; i < ctl->def->ngraphics; i++) {
        if (ctl->def->graphics[i]->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC &&
            ctl->def->graphics[i]->data.vnc.socket &&
            vah_add_file(&buf, ctl->def->graphics[i]->data.vnc.socket, "rw"))
1029
            goto cleanup;
1030 1031
    }

1032 1033 1034 1035
    if (ctl->def->ngraphics == 1 &&
        ctl->def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL)
        if (vah_add_file(&buf, ctl->def->graphics[0]->data.sdl.xauth,
                         "r") != 0)
1036
            goto cleanup;
J
Jamie Strandboge 已提交
1037 1038 1039 1040

    for (i = 0; i < ctl->def->nhostdevs; i++)
        if (ctl->def->hostdevs[i]) {
            virDomainHostdevDefPtr dev = ctl->def->hostdevs[i];
1041
            virDomainHostdevSubsysUSBPtr usbsrc = &dev->source.subsys.u.usb;
J
Jamie Strandboge 已提交
1042 1043
            switch (dev->source.subsys.type) {
            case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB: {
1044
                virUSBDevicePtr usb =
1045
                    virUSBDeviceNew(usbsrc->bus, usbsrc->device, NULL);
1046 1047 1048 1049

                if (usb == NULL)
                    continue;

1050 1051
                rc = virUSBDeviceFileIterate(usb, file_iterate_hostdev_cb, &buf);
                virUSBDeviceFree(usb);
1052
                if (rc != 0)
1053
                    goto cleanup;
J
Jamie Strandboge 已提交
1054 1055
                break;
            }
1056

J
Jamie Strandboge 已提交
1057
            case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI: {
1058
                virPCIDevicePtr pci = virPCIDeviceNew(
1059 1060 1061 1062
                           dev->source.subsys.u.pci.addr.domain,
                           dev->source.subsys.u.pci.addr.bus,
                           dev->source.subsys.u.pci.addr.slot,
                           dev->source.subsys.u.pci.addr.function);
J
Jamie Strandboge 已提交
1063

1064
                virDomainHostdevSubsysPCIBackendType backend = dev->source.subsys.u.pci.backend;
1065 1066 1067 1068 1069
                if (backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_VFIO ||
                        backend == VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT) {
                    needsVfio = true;
                }

J
Jamie Strandboge 已提交
1070 1071 1072
                if (pci == NULL)
                    continue;

1073 1074
                rc = virPCIDeviceFileIterate(pci, file_iterate_pci_cb, &buf);
                virPCIDeviceFree(pci);
J
Jamie Strandboge 已提交
1075 1076 1077

                break;
            }
1078

J
Jamie Strandboge 已提交
1079 1080 1081 1082 1083 1084
            default:
                rc = 0;
                break;
            } /* switch */
        }

F
Felix Geyer 已提交
1085 1086 1087 1088 1089
    for (i = 0; i < ctl->def->nfss; i++) {
        if (ctl->def->fss[i] &&
                ctl->def->fss[i]->type == VIR_DOMAIN_FS_TYPE_MOUNT &&
                (ctl->def->fss[i]->fsdriver == VIR_DOMAIN_FS_DRIVER_TYPE_PATH ||
                 ctl->def->fss[i]->fsdriver == VIR_DOMAIN_FS_DRIVER_TYPE_DEFAULT) &&
1090
                ctl->def->fss[i]->src) {
F
Felix Geyer 已提交
1091 1092 1093 1094 1095 1096 1097
            virDomainFSDefPtr fs = ctl->def->fss[i];

            if (vah_add_path(&buf, fs->src, fs->readonly ? "r" : "rw", true) != 0)
                goto cleanup;
        }
    }

1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112
    if (ctl->def->virtType == VIR_DOMAIN_VIRT_KVM) {
        for (i = 0; i < ctl->def->nnets; i++) {
            virDomainNetDefPtr net = ctl->def->nets[i];
            if (net && net->model) {
                if (net->driver.virtio.name == VIR_DOMAIN_NET_BACKEND_TYPE_QEMU)
                    continue;
                if (STRNEQ(net->model, "virtio"))
                    continue;
            }
            needsvhost = true;
        }
    }
    if (needsvhost)
        virBufferAddLit(&buf, "  /dev/vhost-net rw,\n");

1113 1114 1115 1116 1117
    if (needsVfio) {
        virBufferAddLit(&buf, "  /dev/vfio/vfio rw,\n");
        virBufferAddLit(&buf, "  /dev/vfio/[0-9]* rw,\n");
    }

1118 1119
    if (ctl->newfile)
        if (vah_add_file(&buf, ctl->newfile, "rw") != 0)
1120
            goto cleanup;
J
Jamie Strandboge 已提交
1121 1122

    if (virBufferError(&buf)) {
1123
        virBufferFreeAndReset(&buf);
1124
        vah_error(NULL, 0, _("failed to allocate file buffer"));
1125
        goto cleanup;
J
Jamie Strandboge 已提交
1126 1127 1128 1129 1130
    }

    rc = 0;
    ctl->files = virBufferContentAndReset(&buf);

1131
 cleanup:
J
Jamie Strandboge 已提交
1132 1133 1134 1135 1136 1137 1138 1139 1140
    VIR_FREE(uuid);
    return rc;
}

static int
vahParseArgv(vahControl * ctl, int argc, char **argv)
{
    int arg, idx = 0;
    struct option opt[] = {
1141
        {"probing", 1, 0, 'p' },
J
Jamie Strandboge 已提交
1142 1143 1144 1145 1146
        {"add", 0, 0, 'a'},
        {"create", 0, 0, 'c'},
        {"dryrun", 0, 0, 'd'},
        {"delete", 0, 0, 'D'},
        {"add-file", 0, 0, 'f'},
1147
        {"append-file", 0, 0, 'F'},
J
Jamie Strandboge 已提交
1148 1149 1150 1151 1152 1153 1154
        {"help", 0, 0, 'h'},
        {"replace", 0, 0, 'r'},
        {"remove", 0, 0, 'R'},
        {"uuid", 1, 0, 'u'},
        {0, 0, 0, 0}
    };

1155
    while ((arg = getopt_long(argc, argv, "acdDhrRH:b:u:p:f:F:", opt,
J
Jamie Strandboge 已提交
1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170
            &idx)) != -1) {
        switch (arg) {
            case 'a':
                ctl->cmd = 'a';
                break;
            case 'c':
                ctl->cmd = 'c';
                break;
            case 'd':
                ctl->dryrun = true;
                break;
            case 'D':
                ctl->cmd = 'D';
                break;
            case 'f':
1171
            case 'F':
1172
                if (VIR_STRDUP_QUIET(ctl->newfile, optarg) < 0)
1173
                    vah_error(ctl, 1, _("could not allocate memory for disk"));
1174
                ctl->append = arg == 'F';
J
Jamie Strandboge 已提交
1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187
                break;
            case 'h':
                vah_usage();
                exit(EXIT_SUCCESS);
                break;
            case 'r':
                ctl->cmd = 'r';
                break;
            case 'R':
                ctl->cmd = 'R';
                break;
            case 'u':
                if (strlen(optarg) > PROFILE_NAME_SIZE - 1)
1188
                    vah_error(ctl, 1, _("invalid UUID"));
J
Jamie Strandboge 已提交
1189 1190
                if (virStrcpy((char *) ctl->uuid, optarg,
                    PROFILE_NAME_SIZE) == NULL)
1191
                    vah_error(ctl, 1, _("error copying UUID"));
J
Jamie Strandboge 已提交
1192
                break;
1193 1194 1195 1196 1197 1198
            case 'p':
                if (STREQ(optarg, "1"))
                    ctl->allowDiskFormatProbing = true;
                else
                    ctl->allowDiskFormatProbing = false;
                break;
J
Jamie Strandboge 已提交
1199
            default:
1200
                vah_error(ctl, 1, _("unsupported option"));
J
Jamie Strandboge 已提交
1201 1202 1203 1204
                break;
        }
    }
    if (strchr("acDrR", ctl->cmd) == NULL)
1205
        vah_error(ctl, 1, _("bad command"));
J
Jamie Strandboge 已提交
1206 1207

    if (valid_uuid(ctl->uuid) != 0)
1208
        vah_error(ctl, 1, _("invalid UUID"));
J
Jamie Strandboge 已提交
1209 1210 1211 1212 1213 1214 1215 1216 1217

    if (!ctl->cmd) {
        vah_usage();
        exit(EXIT_FAILURE);
    }

    if (ctl->cmd == 'c' || ctl->cmd == 'r') {
        char *xmlStr = NULL;
        if (virFileReadLimFD(STDIN_FILENO, MAX_FILE_LEN, &xmlStr) < 0)
1218
            vah_error(ctl, 1, _("could not read xml file"));
J
Jamie Strandboge 已提交
1219 1220 1221

        if (get_definition(ctl, xmlStr) != 0 || ctl->def == NULL) {
            VIR_FREE(xmlStr);
1222
            vah_error(ctl, 1, _("could not get VM definition"));
J
Jamie Strandboge 已提交
1223 1224 1225 1226
        }
        VIR_FREE(xmlStr);

        if (get_files(ctl) != 0)
1227
            vah_error(ctl, 1, _("invalid VM definition"));
J
Jamie Strandboge 已提交
1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245
    }
    return 0;
}


/*
 * virt-aa-helper -c -u UUID < file.xml
 * virt-aa-helper -r -u UUID [-f <file>] < file.xml
 * virt-aa-helper -a -u UUID
 * virt-aa-helper -R -u UUID
 * virt-aa-helper -D -u UUID
 */
int
main(int argc, char **argv)
{
    vahControl _ctl, *ctl = &_ctl;
    virBuffer buf = VIR_BUFFER_INITIALIZER;
    int rc = -1;
1246 1247
    char *profile = NULL;
    char *include_file = NULL;
J
Jamie Strandboge 已提交
1248

E
Eric Blake 已提交
1249 1250 1251
    if (setlocale(LC_ALL, "") == NULL ||
        bindtextdomain(PACKAGE, LOCALEDIR) == NULL ||
        textdomain(PACKAGE) == NULL) {
1252
        fprintf(stderr, _("%s: initialization failed\n"), argv[0]);
E
Eric Blake 已提交
1253 1254 1255
        exit(EXIT_FAILURE);
    }

1256 1257 1258 1259 1260 1261
    if (virThreadInitialize() < 0 ||
        virErrorInitialize() < 0) {
        fprintf(stderr, _("%s: initialization failed\n"), argv[0]);
        exit(EXIT_FAILURE);
    }

J
Jamie Strandboge 已提交
1262 1263
    /* clear the environment */
    environ = NULL;
1264
    if (setenv("PATH", "/sbin:/usr/sbin", 1) != 0)
1265 1266
        vah_error(ctl, 1, _("could not set PATH"));

1267
    /* ensure the traditional IFS setting */
1268
    if (setenv("IFS", " \t\n", 1) != 0)
1269
        vah_error(ctl, 1, _("could not set IFS"));
J
Jamie Strandboge 已提交
1270 1271 1272 1273 1274 1275 1276 1277 1278

    if (!(progname = strrchr(argv[0], '/')))
        progname = argv[0];
    else
        progname++;

    memset(ctl, 0, sizeof(vahControl));

    if (vahParseArgv(ctl, argc, argv) != 0)
1279
        vah_error(ctl, 1, _("could not parse arguments"));
J
Jamie Strandboge 已提交
1280

1281 1282
    if (virAsprintfQuiet(&profile, "%s/%s",
                         APPARMOR_DIR "/libvirt", ctl->uuid) < 0)
1283
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
1284

1285 1286
    if (virAsprintfQuiet(&include_file, "%s/%s.files",
                         APPARMOR_DIR "/libvirt", ctl->uuid) < 0)
1287
        vah_error(ctl, 0, _("could not allocate memory"));
J
Jamie Strandboge 已提交
1288

1289
    if (ctl->cmd == 'a') {
J
Jamie Strandboge 已提交
1290
        rc = parserLoad(ctl->uuid);
1291
    } else if (ctl->cmd == 'R' || ctl->cmd == 'D') {
J
Jamie Strandboge 已提交
1292 1293 1294 1295 1296 1297 1298 1299
        rc = parserRemove(ctl->uuid);
        if (ctl->cmd == 'D') {
            unlink(include_file);
            unlink(profile);
        }
    } else if (ctl->cmd == 'c' || ctl->cmd == 'r') {
        char *included_files = NULL;

1300
        if (ctl->cmd == 'c' && virFileExists(profile))
1301
            vah_error(ctl, 1, _("profile exists"));
J
Jamie Strandboge 已提交
1302

1303 1304
        if (ctl->append && ctl->newfile) {
            if (vah_add_file(&buf, ctl->newfile, "rw") != 0)
1305
                goto cleanup;
1306
        } else {
1307 1308 1309
            if (ctl->def->virtType == VIR_DOMAIN_VIRT_QEMU ||
                ctl->def->virtType == VIR_DOMAIN_VIRT_KQEMU ||
                ctl->def->virtType == VIR_DOMAIN_VIRT_KVM) {
1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320 1321 1322
                virBufferAsprintf(&buf, "  \"%s/log/libvirt/**/%s.log\" w,\n",
                                  LOCALSTATEDIR, ctl->def->name);
                virBufferAsprintf(&buf, "  \"%s/lib/libvirt/**/%s.monitor\" rw,\n",
                                  LOCALSTATEDIR, ctl->def->name);
                virBufferAsprintf(&buf, "  \"%s/run/libvirt/**/%s.pid\" rwk,\n",
                                  LOCALSTATEDIR, ctl->def->name);
                virBufferAsprintf(&buf, "  \"/run/libvirt/**/%s.pid\" rwk,\n",
                                  ctl->def->name);
                virBufferAsprintf(&buf, "  \"%s/run/libvirt/**/*.tunnelmigrate.dest.%s\" rw,\n",
                                  LOCALSTATEDIR, ctl->def->name);
                virBufferAsprintf(&buf, "  \"/run/libvirt/**/*.tunnelmigrate.dest.%s\" rw,\n",
                                  ctl->def->name);
            }
1323
            if (ctl->files)
1324
                virBufferAdd(&buf, ctl->files, -1);
1325
        }
J
Jamie Strandboge 已提交
1326

1327 1328
        if (virBufferError(&buf)) {
            virBufferFreeAndReset(&buf);
1329
            vah_error(ctl, 1, _("failed to allocate buffer"));
1330
        }
J
Jamie Strandboge 已提交
1331 1332 1333 1334 1335 1336 1337 1338

        included_files = virBufferContentAndReset(&buf);

        /* (re)create the include file using included_files */
        if (ctl->dryrun) {
            vah_info(include_file);
            vah_info(included_files);
            rc = 0;
1339 1340 1341
        } else if (ctl->def->virtType == VIR_DOMAIN_VIRT_LXC) {
            rc = 0;
        } else if ((rc = update_include_file(include_file,
1342
                                             included_files,
1343
                                             ctl->append)) != 0) {
1344
            goto cleanup;
1345
        }
J
Jamie Strandboge 已提交
1346 1347 1348 1349 1350


        /* create the profile from TEMPLATE */
        if (ctl->cmd == 'c') {
            char *tmp = NULL;
1351 1352
            if (virAsprintfQuiet(&tmp, "  #include <libvirt/%s.files>\n",
                                 ctl->uuid) == -1) {
1353
                vah_error(ctl, 0, _("could not allocate memory"));
1354
                goto cleanup;
J
Jamie Strandboge 已提交
1355 1356 1357 1358 1359 1360 1361
            }

            if (ctl->dryrun) {
                vah_info(profile);
                vah_info(ctl->uuid);
                vah_info(tmp);
                rc = 0;
1362 1363
            } else if ((rc = create_profile(profile, ctl->uuid, tmp,
                                            ctl->def->virtType)) != 0) {
1364
                vah_error(ctl, 0, _("could not create profile"));
J
Jamie Strandboge 已提交
1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382
                unlink(include_file);
            }
            VIR_FREE(tmp);
        }

        if (rc == 0 && !ctl->dryrun) {
            if (ctl->cmd == 'c')
                rc = parserLoad(ctl->uuid);
            else
                rc = parserReplace(ctl->uuid);

            /* cleanup */
            if (rc != 0) {
                unlink(include_file);
                if (ctl->cmd == 'c')
                    unlink(profile);
            }
        }
1383
      cleanup:
J
Jamie Strandboge 已提交
1384 1385 1386 1387
        VIR_FREE(included_files);
    }

    vahDeinit(ctl);
1388 1389 1390 1391

    VIR_FREE(profile);
    VIR_FREE(include_file);

J
Jamie Strandboge 已提交
1392 1393
    exit(rc == 0 ? EXIT_SUCCESS : EXIT_FAILURE);
}